All of lore.kernel.org
 help / color / mirror / Atom feed
From: Christian Brauner <christian.brauner@ubuntu.com>
To: Aleksa Sarai <cyphar@cyphar.com>
Cc: containers@lists.linux-foundation.org,
	linux-kernel@vger.kernel.org, stable@vger.kernel.org,
	Alexander Viro <viro@zeniv.linux.org.uk>,
	linux-kselftest@vger.kernel.org, linux-fsdevel@vger.kernel.org,
	Shuah Khan <shuah@kernel.org>
Subject: Re: [PATCH] openat2: reject RESOLVE_BENEATH|RESOLVE_IN_ROOT
Date: Fri, 9 Oct 2020 13:50:14 +0200	[thread overview]
Message-ID: <20201009115014.ft7kjyejhqvommnv@wittgenstein> (raw)
In-Reply-To: <20201007103608.17349-1-cyphar@cyphar.com>

On Wed, Oct 07, 2020 at 09:36:08PM +1100, Aleksa Sarai wrote:
> This was an oversight in the original implementation, as it makes no
> sense to specify both scoping flags to the same openat2(2) invocation
> (before this patch, the result of such an invocation was equivalent to
> RESOLVE_IN_ROOT being ignored).
> 
> This is a userspace-visible ABI change, but the only user of openat2(2)
> at the moment is LXC which doesn't specify both flags and so no
> userspace programs will break as a result.

Indeed!

> 
> Fixes: fddb5d430ad9 ("open: introduce openat2(2) syscall")
> Signed-off-by: Aleksa Sarai <cyphar@cyphar.com>
> Acked-by: Christian Brauner <christian.brauner@ubuntu.com>
> Cc: <stable@vger.kernel.org> # v5.6+
> ---

Thanks! This is a good fix imho.
Christian
_______________________________________________
Containers mailing list
Containers@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/containers

WARNING: multiple messages have this Message-ID (diff)
From: Christian Brauner <christian.brauner@ubuntu.com>
To: Aleksa Sarai <cyphar@cyphar.com>
Cc: Alexander Viro <viro@zeniv.linux.org.uk>,
	Shuah Khan <shuah@kernel.org>,
	containers@lists.linux-foundation.org,
	linux-kernel@vger.kernel.org, stable@vger.kernel.org,
	linux-kselftest@vger.kernel.org, linux-fsdevel@vger.kernel.org
Subject: Re: [PATCH] openat2: reject RESOLVE_BENEATH|RESOLVE_IN_ROOT
Date: Fri, 9 Oct 2020 13:50:14 +0200	[thread overview]
Message-ID: <20201009115014.ft7kjyejhqvommnv@wittgenstein> (raw)
In-Reply-To: <20201007103608.17349-1-cyphar@cyphar.com>

On Wed, Oct 07, 2020 at 09:36:08PM +1100, Aleksa Sarai wrote:
> This was an oversight in the original implementation, as it makes no
> sense to specify both scoping flags to the same openat2(2) invocation
> (before this patch, the result of such an invocation was equivalent to
> RESOLVE_IN_ROOT being ignored).
> 
> This is a userspace-visible ABI change, but the only user of openat2(2)
> at the moment is LXC which doesn't specify both flags and so no
> userspace programs will break as a result.

Indeed!

> 
> Fixes: fddb5d430ad9 ("open: introduce openat2(2) syscall")
> Signed-off-by: Aleksa Sarai <cyphar@cyphar.com>
> Acked-by: Christian Brauner <christian.brauner@ubuntu.com>
> Cc: <stable@vger.kernel.org> # v5.6+
> ---

Thanks! This is a good fix imho.
Christian

  reply	other threads:[~2020-10-09 11:50 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-10-07 10:36 [PATCH] openat2: reject RESOLVE_BENEATH|RESOLVE_IN_ROOT Aleksa Sarai
2020-10-07 10:36 ` Aleksa Sarai
2020-10-09 11:50 ` Christian Brauner [this message]
2020-10-09 11:50   ` Christian Brauner
2020-10-27 22:28 ` Shuah Khan
2020-10-27 22:28   ` Shuah Khan
2020-10-27 23:39   ` Aleksa Sarai

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20201009115014.ft7kjyejhqvommnv@wittgenstein \
    --to=christian.brauner@ubuntu.com \
    --cc=containers@lists.linux-foundation.org \
    --cc=cyphar@cyphar.com \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-kselftest@vger.kernel.org \
    --cc=shuah@kernel.org \
    --cc=stable@vger.kernel.org \
    --cc=viro@zeniv.linux.org.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.