* [PATCH] ARM: dts: imx6q-icore-ofcap10: Use 10.1" Ampire panel compatible
@ 2020-08-28 16:03 ` Jagan Teki
0 siblings, 0 replies; 6+ messages in thread
From: Jagan Teki @ 2020-08-28 16:03 UTC (permalink / raw)
To: Shawn Guo, Sascha Hauer, Rob Herring
Cc: Fabio Estevam, linux-arm-kernel, devicetree, linux-kernel,
linux-amarula, Jagan Teki
Adding display timings directly on device tree files make it difficult
to maintain as a same copy of timings may exist on different files or
panel-simple driver.
We have a panel-simple driver for this particular usage so supporting
on this driver will help to use the same timings on any device tree
files if the board mounted on a similar vendor display.
Engicam C.TOUCH OF 10.1" LCD board uses Ampire 10.1" TFT LCD and
it has supported by panel-simple already, so simply use that binding.
Signed-off-by: Jagan Teki <jagan@amarulasolutions.com>
---
Note:
Panel patch in ML already,
https://lkml.org/lkml/2020/8/28/685
arch/arm/boot/dts/imx6q-icore-ofcap10.dts | 28 +++++++++++++----------
1 file changed, 16 insertions(+), 12 deletions(-)
diff --git a/arch/arm/boot/dts/imx6q-icore-ofcap10.dts b/arch/arm/boot/dts/imx6q-icore-ofcap10.dts
index 81cc346dd149..02aca1e28ce3 100644
--- a/arch/arm/boot/dts/imx6q-icore-ofcap10.dts
+++ b/arch/arm/boot/dts/imx6q-icore-ofcap10.dts
@@ -12,6 +12,17 @@
/ {
model = "Engicam i.CoreM6 Quad/Dual OpenFrame Capacitive touch 10.1 Kit";
compatible = "engicam,imx6-icore", "fsl,imx6q";
+
+ panel {
+ compatible = "ampire,am-1280800n3tzqw-t00h";
+ backlight = <&backlight_lvds>;
+
+ port {
+ panel_in: endpoint {
+ remote-endpoint = <&lvds0_out>;
+ };
+ };
+ };
};
&ldb {
@@ -22,18 +33,11 @@ lvds-channel@0 {
fsl,data-width = <24>;
status = "okay";
- display-timings {
- native-mode = <&timing0>;
- timing0: timing0 {
- clock-frequency = <60000000>;
- hactive = <1280>;
- vactive = <800>;
- hback-porch = <40>;
- hfront-porch = <40>;
- vback-porch = <10>;
- vfront-porch = <3>;
- hsync-len = <80>;
- vsync-len = <10>;
+ port@4 {
+ reg = <4>;
+
+ lvds0_out: endpoint {
+ remote-endpoint = <&panel_in>;
};
};
};
--
2.25.1
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [PATCH] ARM: dts: imx6q-icore-ofcap10: Use 10.1" Ampire panel compatible
@ 2020-08-28 16:03 ` Jagan Teki
0 siblings, 0 replies; 6+ messages in thread
From: Jagan Teki @ 2020-08-28 16:03 UTC (permalink / raw)
To: Shawn Guo, Sascha Hauer, Rob Herring
Cc: devicetree, linux-amarula, linux-kernel, Jagan Teki,
Fabio Estevam, linux-arm-kernel
Adding display timings directly on device tree files make it difficult
to maintain as a same copy of timings may exist on different files or
panel-simple driver.
We have a panel-simple driver for this particular usage so supporting
on this driver will help to use the same timings on any device tree
files if the board mounted on a similar vendor display.
Engicam C.TOUCH OF 10.1" LCD board uses Ampire 10.1" TFT LCD and
it has supported by panel-simple already, so simply use that binding.
Signed-off-by: Jagan Teki <jagan@amarulasolutions.com>
---
Note:
Panel patch in ML already,
https://lkml.org/lkml/2020/8/28/685
arch/arm/boot/dts/imx6q-icore-ofcap10.dts | 28 +++++++++++++----------
1 file changed, 16 insertions(+), 12 deletions(-)
diff --git a/arch/arm/boot/dts/imx6q-icore-ofcap10.dts b/arch/arm/boot/dts/imx6q-icore-ofcap10.dts
index 81cc346dd149..02aca1e28ce3 100644
--- a/arch/arm/boot/dts/imx6q-icore-ofcap10.dts
+++ b/arch/arm/boot/dts/imx6q-icore-ofcap10.dts
@@ -12,6 +12,17 @@
/ {
model = "Engicam i.CoreM6 Quad/Dual OpenFrame Capacitive touch 10.1 Kit";
compatible = "engicam,imx6-icore", "fsl,imx6q";
+
+ panel {
+ compatible = "ampire,am-1280800n3tzqw-t00h";
+ backlight = <&backlight_lvds>;
+
+ port {
+ panel_in: endpoint {
+ remote-endpoint = <&lvds0_out>;
+ };
+ };
+ };
};
&ldb {
@@ -22,18 +33,11 @@ lvds-channel@0 {
fsl,data-width = <24>;
status = "okay";
- display-timings {
- native-mode = <&timing0>;
- timing0: timing0 {
- clock-frequency = <60000000>;
- hactive = <1280>;
- vactive = <800>;
- hback-porch = <40>;
- hfront-porch = <40>;
- vback-porch = <10>;
- vfront-porch = <3>;
- hsync-len = <80>;
- vsync-len = <10>;
+ port@4 {
+ reg = <4>;
+
+ lvds0_out: endpoint {
+ remote-endpoint = <&panel_in>;
};
};
};
--
2.25.1
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH] ARM: dts: imx6q-icore-ofcap10: Use 10.1" Ampire panel compatible
2020-08-28 16:03 ` Jagan Teki
@ 2020-10-27 14:14 ` Jagan Teki
-1 siblings, 0 replies; 6+ messages in thread
From: Jagan Teki @ 2020-10-27 14:14 UTC (permalink / raw)
To: Shawn Guo, Sascha Hauer, Rob Herring
Cc: Fabio Estevam, linux-arm-kernel, devicetree, linux-kernel, linux-amarula
Hi Shawn,
On Fri, Aug 28, 2020 at 9:33 PM Jagan Teki <jagan@amarulasolutions.com> wrote:
>
> Adding display timings directly on device tree files make it difficult
> to maintain as a same copy of timings may exist on different files or
> panel-simple driver.
>
> We have a panel-simple driver for this particular usage so supporting
> on this driver will help to use the same timings on any device tree
> files if the board mounted on a similar vendor display.
>
> Engicam C.TOUCH OF 10.1" LCD board uses Ampire 10.1" TFT LCD and
> it has supported by panel-simple already, so simply use that binding.
>
> Signed-off-by: Jagan Teki <jagan@amarulasolutions.com>
> ---
> Note:
> Panel patch in ML already,
> https://lkml.org/lkml/2020/8/28/685
Panel is part of the Mainline tree now, hope this can apply?
Jagan.
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] ARM: dts: imx6q-icore-ofcap10: Use 10.1" Ampire panel compatible
@ 2020-10-27 14:14 ` Jagan Teki
0 siblings, 0 replies; 6+ messages in thread
From: Jagan Teki @ 2020-10-27 14:14 UTC (permalink / raw)
To: Shawn Guo, Sascha Hauer, Rob Herring
Cc: devicetree, Fabio Estevam, linux-kernel, linux-arm-kernel, linux-amarula
Hi Shawn,
On Fri, Aug 28, 2020 at 9:33 PM Jagan Teki <jagan@amarulasolutions.com> wrote:
>
> Adding display timings directly on device tree files make it difficult
> to maintain as a same copy of timings may exist on different files or
> panel-simple driver.
>
> We have a panel-simple driver for this particular usage so supporting
> on this driver will help to use the same timings on any device tree
> files if the board mounted on a similar vendor display.
>
> Engicam C.TOUCH OF 10.1" LCD board uses Ampire 10.1" TFT LCD and
> it has supported by panel-simple already, so simply use that binding.
>
> Signed-off-by: Jagan Teki <jagan@amarulasolutions.com>
> ---
> Note:
> Panel patch in ML already,
> https://lkml.org/lkml/2020/8/28/685
Panel is part of the Mainline tree now, hope this can apply?
Jagan.
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] ARM: dts: imx6q-icore-ofcap10: Use 10.1" Ampire panel compatible
2020-08-28 16:03 ` Jagan Teki
@ 2020-10-28 7:30 ` Shawn Guo
-1 siblings, 0 replies; 6+ messages in thread
From: Shawn Guo @ 2020-10-28 7:30 UTC (permalink / raw)
To: Jagan Teki
Cc: Sascha Hauer, Rob Herring, Fabio Estevam, linux-arm-kernel,
devicetree, linux-kernel, linux-amarula
On Fri, Aug 28, 2020 at 09:33:02PM +0530, Jagan Teki wrote:
> Adding display timings directly on device tree files make it difficult
> to maintain as a same copy of timings may exist on different files or
> panel-simple driver.
>
> We have a panel-simple driver for this particular usage so supporting
> on this driver will help to use the same timings on any device tree
> files if the board mounted on a similar vendor display.
>
> Engicam C.TOUCH OF 10.1" LCD board uses Ampire 10.1" TFT LCD and
> it has supported by panel-simple already, so simply use that binding.
>
> Signed-off-by: Jagan Teki <jagan@amarulasolutions.com>
Applied, thanks.
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] ARM: dts: imx6q-icore-ofcap10: Use 10.1" Ampire panel compatible
@ 2020-10-28 7:30 ` Shawn Guo
0 siblings, 0 replies; 6+ messages in thread
From: Shawn Guo @ 2020-10-28 7:30 UTC (permalink / raw)
To: Jagan Teki
Cc: devicetree, linux-amarula, Sascha Hauer, linux-kernel,
Rob Herring, Fabio Estevam, linux-arm-kernel
On Fri, Aug 28, 2020 at 09:33:02PM +0530, Jagan Teki wrote:
> Adding display timings directly on device tree files make it difficult
> to maintain as a same copy of timings may exist on different files or
> panel-simple driver.
>
> We have a panel-simple driver for this particular usage so supporting
> on this driver will help to use the same timings on any device tree
> files if the board mounted on a similar vendor display.
>
> Engicam C.TOUCH OF 10.1" LCD board uses Ampire 10.1" TFT LCD and
> it has supported by panel-simple already, so simply use that binding.
>
> Signed-off-by: Jagan Teki <jagan@amarulasolutions.com>
Applied, thanks.
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2020-10-29 0:57 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-08-28 16:03 [PATCH] ARM: dts: imx6q-icore-ofcap10: Use 10.1" Ampire panel compatible Jagan Teki
2020-08-28 16:03 ` Jagan Teki
2020-10-27 14:14 ` Jagan Teki
2020-10-27 14:14 ` Jagan Teki
2020-10-28 7:30 ` Shawn Guo
2020-10-28 7:30 ` Shawn Guo
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.