* [PATCH] ARM: imx: add missing clk_disable_unprepare() when remove imx_mmdc
@ 2020-10-28 9:15 ` Qinglang Miao
0 siblings, 0 replies; 4+ messages in thread
From: Qinglang Miao @ 2020-10-28 9:15 UTC (permalink / raw)
To: Russell King, Shawn Guo, Sascha Hauer, Pengutronix Kernel Team,
Fabio Estevam, NXP Linux Team
Cc: linux-arm-kernel, linux-kernel, Qinglang Miao
Clock source is prepared and enabled by clk_prepare_enable()
in probe function, but no disable or unprepare in remove.
Signed-off-by: Qinglang Miao <miaoqinglang@huawei.com>
---
arch/arm/mach-imx/mmdc.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/arch/arm/mach-imx/mmdc.c b/arch/arm/mach-imx/mmdc.c
index 0dfd0ae7a..56375e8da 100644
--- a/arch/arm/mach-imx/mmdc.c
+++ b/arch/arm/mach-imx/mmdc.c
@@ -462,6 +462,7 @@ static int imx_mmdc_remove(struct platform_device *pdev)
cpuhp_state_remove_instance_nocalls(cpuhp_mmdc_state, &pmu_mmdc->node);
perf_pmu_unregister(&pmu_mmdc->pmu);
+ clk_disable_unprepare(mmdc_ipg_clk);
kfree(pmu_mmdc);
return 0;
}
--
2.23.0
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [PATCH] ARM: imx: add missing clk_disable_unprepare() when remove imx_mmdc
@ 2020-10-28 9:15 ` Qinglang Miao
0 siblings, 0 replies; 4+ messages in thread
From: Qinglang Miao @ 2020-10-28 9:15 UTC (permalink / raw)
To: Russell King, Shawn Guo, Sascha Hauer, Pengutronix Kernel Team,
Fabio Estevam, NXP Linux Team
Cc: Qinglang Miao, linux-kernel, linux-arm-kernel
Clock source is prepared and enabled by clk_prepare_enable()
in probe function, but no disable or unprepare in remove.
Signed-off-by: Qinglang Miao <miaoqinglang@huawei.com>
---
arch/arm/mach-imx/mmdc.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/arch/arm/mach-imx/mmdc.c b/arch/arm/mach-imx/mmdc.c
index 0dfd0ae7a..56375e8da 100644
--- a/arch/arm/mach-imx/mmdc.c
+++ b/arch/arm/mach-imx/mmdc.c
@@ -462,6 +462,7 @@ static int imx_mmdc_remove(struct platform_device *pdev)
cpuhp_state_remove_instance_nocalls(cpuhp_mmdc_state, &pmu_mmdc->node);
perf_pmu_unregister(&pmu_mmdc->pmu);
+ clk_disable_unprepare(mmdc_ipg_clk);
kfree(pmu_mmdc);
return 0;
}
--
2.23.0
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] ARM: imx: add missing clk_disable_unprepare() when remove imx_mmdc
2020-10-28 9:15 ` Qinglang Miao
@ 2020-11-01 9:23 ` Shawn Guo
-1 siblings, 0 replies; 4+ messages in thread
From: Shawn Guo @ 2020-11-01 9:23 UTC (permalink / raw)
To: Qinglang Miao
Cc: Russell King, Sascha Hauer, Pengutronix Kernel Team,
Fabio Estevam, NXP Linux Team, linux-arm-kernel, linux-kernel
On Wed, Oct 28, 2020 at 05:15:39PM +0800, Qinglang Miao wrote:
> Clock source is prepared and enabled by clk_prepare_enable()
> in probe function, but no disable or unprepare in remove.
>
> Signed-off-by: Qinglang Miao <miaoqinglang@huawei.com>
Applied, thanks.
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] ARM: imx: add missing clk_disable_unprepare() when remove imx_mmdc
@ 2020-11-01 9:23 ` Shawn Guo
0 siblings, 0 replies; 4+ messages in thread
From: Shawn Guo @ 2020-11-01 9:23 UTC (permalink / raw)
To: Qinglang Miao
Cc: Sascha Hauer, Russell King, linux-kernel, NXP Linux Team,
Pengutronix Kernel Team, Fabio Estevam, linux-arm-kernel
On Wed, Oct 28, 2020 at 05:15:39PM +0800, Qinglang Miao wrote:
> Clock source is prepared and enabled by clk_prepare_enable()
> in probe function, but no disable or unprepare in remove.
>
> Signed-off-by: Qinglang Miao <miaoqinglang@huawei.com>
Applied, thanks.
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2020-11-01 9:24 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-10-28 9:15 [PATCH] ARM: imx: add missing clk_disable_unprepare() when remove imx_mmdc Qinglang Miao
2020-10-28 9:15 ` Qinglang Miao
2020-11-01 9:23 ` Shawn Guo
2020-11-01 9:23 ` Shawn Guo
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.