[PATCH v1] kernel.h: Drop unneeded <linux/kernel.h> inclusion from other headers

[PATCH v1] kernel.h: Drop unneeded <linux/kernel.h> inclusion from other headers

[Andy Shevchenko]

There is no evidence we need kernel.h inclusion in certain headers.
Drop unneeded <linux/kernel.h> inclusion from other headers.

Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
---
 include/linux/rwsem.h    | 1 -
 include/linux/spinlock.h | 1 -
 2 files changed, 2 deletions(-)

diff --git a/include/linux/rwsem.h b/include/linux/rwsem.h
index 25e3fde85617..97571bf1286d 100644
--- a/include/linux/rwsem.h
+++ b/include/linux/rwsem.h
@@ -11,7 +11,6 @@
 #include <linux/linkage.h>
 
 #include <linux/types.h>
-#include <linux/kernel.h>
 #include <linux/list.h>
 #include <linux/spinlock.h>
 #include <linux/atomic.h>
diff --git a/include/linux/spinlock.h b/include/linux/spinlock.h
index 79897841a2cc..520f32c93745 100644
--- a/include/linux/spinlock.h
+++ b/include/linux/spinlock.h
@@ -53,7 +53,6 @@
 #include <linux/compiler.h>
 #include <linux/irqflags.h>
 #include <linux/thread_info.h>
-#include <linux/kernel.h>
 #include <linux/stringify.h>
 #include <linux/bottom_half.h>
 #include <linux/lockdep.h>
-- 
2.28.0

Re: [PATCH v1] kernel.h: Drop unneeded <linux/kernel.h> inclusion from other headers

[Will Deacon]

On Wed, Oct 28, 2020 at 07:28:26PM +0200, Andy Shevchenko wrote:
> There is no evidence we need kernel.h inclusion in certain headers.

Did you run some tools to determine this or is it just a hunch?

Will

Re: [PATCH v1] kernel.h: Drop unneeded <linux/kernel.h> inclusion from other headers

[Andy Shevchenko]

On Fri, Oct 30, 2020 at 08:33:56AM +0000, Will Deacon wrote:
> On Wed, Oct 28, 2020 at 07:28:26PM +0200, Andy Shevchenko wrote:
> > There is no evidence we need kernel.h inclusion in certain headers.
> 
> Did you run some tools to determine this or is it just a hunch?

I read files manually. So, closer to the latter.
Also I rely on 0day and other CIs that didn't show anything for a long time.

-- 
With Best Regards,
Andy Shevchenko

Re: [PATCH v1] kernel.h: Drop unneeded <linux/kernel.h> inclusion from other headers

[Andy Shevchenko]

On Fri, Oct 30, 2020 at 01:06:06PM +0200, Andy Shevchenko wrote:
> On Fri, Oct 30, 2020 at 08:33:56AM +0000, Will Deacon wrote:
> > On Wed, Oct 28, 2020 at 07:28:26PM +0200, Andy Shevchenko wrote:
> > > There is no evidence we need kernel.h inclusion in certain headers.
> > 
> > Did you run some tools to determine this or is it just a hunch?
> 
> I read files manually. So, closer to the latter.
> Also I rely on 0day and other CIs that didn't show anything for a long time.

Will, any recommendation what should I run to be solid about this change?

-- 
With Best Regards,
Andy Shevchenko

Re: [PATCH v1] kernel.h: Drop unneeded <linux/kernel.h> inclusion from other headers

[Will Deacon]

Hi Andy,

On Mon, Dec 28, 2020 at 11:37:26PM +0200, Andy Shevchenko wrote:
> On Fri, Oct 30, 2020 at 01:06:06PM +0200, Andy Shevchenko wrote:
> > On Fri, Oct 30, 2020 at 08:33:56AM +0000, Will Deacon wrote:
> > > On Wed, Oct 28, 2020 at 07:28:26PM +0200, Andy Shevchenko wrote:
> > > > There is no evidence we need kernel.h inclusion in certain headers.
> > > 
> > > Did you run some tools to determine this or is it just a hunch?
> > 
> > I read files manually. So, closer to the latter.
> > Also I rely on 0day and other CIs that didn't show anything for a long time.
> 
> Will, any recommendation what should I run to be solid about this change?

Sorry, I don't have any good suggestions here. That's actually why I asked,
in case you happened to have something to make these sort of changes less
error-prone! So I'm not trying to block this change, it's just a shame that
it's not easier to do.

Will