From: Shawn Guo <shawnguo@kernel.org>
To: Oleksij Rempel <o.rempel@pengutronix.de>
Cc: mkl@pengutronix.de, Wolfgang Grandegger <wg@grandegger.com>,
"David S. Miller" <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>,
Rob Herring <robh+dt@kernel.org>,
Sascha Hauer <s.hauer@pengutronix.de>,
kernel@pengutronix.de, linux-can@vger.kernel.org,
netdev@vger.kernel.org, devicetree@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, Fabio Estevam <festevam@gmail.com>,
Joakim Zhang <qiangqing.zhang@nxp.com>
Subject: Re: [PATCH v1] ARM: dts: imx6/7: sync fsl,stop-mode with current flexcan driver
Date: Sat, 31 Oct 2020 16:33:12 +0800 [thread overview]
Message-ID: <20201031083312.GV28755@dragon> (raw)
In-Reply-To: <20201016075158.31574-1-o.rempel@pengutronix.de>
On Fri, Oct 16, 2020 at 09:51:58AM +0200, Oleksij Rempel wrote:
> After this patch we need 2 arguments less for the fsl,stop-mode
> property:
>
> | commit d9b081e3fc4bdc33e672dcb7bb256394909432fc
> | Author: Marc Kleine-Budde <mkl@pengutronix.de>
> | Date: Sun Jun 14 21:09:20 2020 +0200
> |
> | can: flexcan: remove ack_grp and ack_bit handling from driver
> |
> | Since commit:
> |
> | 048e3a34a2e7 can: flexcan: poll MCR_LPM_ACK instead of GPR ACK for stop mode acknowledgment
> |
> | the driver polls the IP core's internal bit MCR[LPM_ACK] as stop mode
> | acknowledge and not the acknowledgment on chip level.
> |
> | This means the 4th and 5th value of the property "fsl,stop-mode" isn't used
> | anymore. This patch removes the used "ack_gpr" and "ack_bit" from the driver.
>
> This patch removes the two last arguments, as they are not needed
> anymore.
>
> Signed-off-by: Oleksij Rempel <o.rempel@pengutronix.de>
>
> # Please enter the commit message for your changes. Lines starting
It shouldn't be here.
Fixed it up and applied the patch.
Shawn
WARNING: multiple messages have this Message-ID (diff)
From: Shawn Guo <shawnguo@kernel.org>
To: Oleksij Rempel <o.rempel@pengutronix.de>
Cc: devicetree@vger.kernel.org,
Joakim Zhang <qiangqing.zhang@nxp.com>,
netdev@vger.kernel.org, Sascha Hauer <s.hauer@pengutronix.de>,
linux-kernel@vger.kernel.org, linux-can@vger.kernel.org,
Rob Herring <robh+dt@kernel.org>,
mkl@pengutronix.de, linux-arm-kernel@lists.infradead.org,
kernel@pengutronix.de, Jakub Kicinski <kuba@kernel.org>,
Fabio Estevam <festevam@gmail.com>,
"David S. Miller" <davem@davemloft.net>,
Wolfgang Grandegger <wg@grandegger.com>
Subject: Re: [PATCH v1] ARM: dts: imx6/7: sync fsl,stop-mode with current flexcan driver
Date: Sat, 31 Oct 2020 16:33:12 +0800 [thread overview]
Message-ID: <20201031083312.GV28755@dragon> (raw)
In-Reply-To: <20201016075158.31574-1-o.rempel@pengutronix.de>
On Fri, Oct 16, 2020 at 09:51:58AM +0200, Oleksij Rempel wrote:
> After this patch we need 2 arguments less for the fsl,stop-mode
> property:
>
> | commit d9b081e3fc4bdc33e672dcb7bb256394909432fc
> | Author: Marc Kleine-Budde <mkl@pengutronix.de>
> | Date: Sun Jun 14 21:09:20 2020 +0200
> |
> | can: flexcan: remove ack_grp and ack_bit handling from driver
> |
> | Since commit:
> |
> | 048e3a34a2e7 can: flexcan: poll MCR_LPM_ACK instead of GPR ACK for stop mode acknowledgment
> |
> | the driver polls the IP core's internal bit MCR[LPM_ACK] as stop mode
> | acknowledge and not the acknowledgment on chip level.
> |
> | This means the 4th and 5th value of the property "fsl,stop-mode" isn't used
> | anymore. This patch removes the used "ack_gpr" and "ack_bit" from the driver.
>
> This patch removes the two last arguments, as they are not needed
> anymore.
>
> Signed-off-by: Oleksij Rempel <o.rempel@pengutronix.de>
>
> # Please enter the commit message for your changes. Lines starting
It shouldn't be here.
Fixed it up and applied the patch.
Shawn
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2020-10-31 8:35 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-16 7:51 [PATCH v1] ARM: dts: imx6/7: sync fsl,stop-mode with current flexcan driver Oleksij Rempel
2020-10-16 7:51 ` [PATCH v1] ARM: dts: imx6/7: sync fsl, stop-mode " Oleksij Rempel
2020-10-16 8:06 ` [PATCH v1] ARM: dts: imx6/7: sync fsl,stop-mode " Joakim Zhang
2020-10-16 8:06 ` Joakim Zhang
2020-10-31 8:33 ` Shawn Guo [this message]
2020-10-31 8:33 ` Shawn Guo
-- strict thread matches above, loose matches on Subject: below --
2020-10-16 7:44 Oleksij Rempel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201031083312.GV28755@dragon \
--to=shawnguo@kernel.org \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=festevam@gmail.com \
--cc=kernel@pengutronix.de \
--cc=kuba@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-can@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mkl@pengutronix.de \
--cc=netdev@vger.kernel.org \
--cc=o.rempel@pengutronix.de \
--cc=qiangqing.zhang@nxp.com \
--cc=robh+dt@kernel.org \
--cc=s.hauer@pengutronix.de \
--cc=wg@grandegger.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.