From: Jakub Kicinski <kuba@kernel.org>
To: Anant Thazhemadam <anant.thazhemadam@gmail.com>
Cc: Oliver Neukum <oneukum@suse.com>,
"David S . Miller" <davem@davemloft.net>,
netdev@vger.kernel.org, linux-usb@vger.kernel.org,
linux-kernel@vger.kernel.org,
linux-kernel-mentees@lists.linuxfoundation.org
Subject: Re: [PATCH v2] net: usb: usbnet: update __usbnet_{read|write}_cmd() to use new API
Date: Sat, 31 Oct 2020 14:11:43 -0700 [thread overview]
Message-ID: <20201031141143.5c8463e1@kicinski-fedora-PC1C0HJN.hsd1.ca.comcast.net> (raw)
In-Reply-To: <20201029132256.11793-1-anant.thazhemadam@gmail.com>
On Thu, 29 Oct 2020 18:52:56 +0530 Anant Thazhemadam wrote:
> + return usb_control_msg_recv(dev->udev, 0,
> + cmd, reqtype, value, index, data, size,
> + USB_CTRL_GET_TIMEOUT, GFP_KERNEL);
Please align continuation lines after the opening bracket.
WARNING: multiple messages have this Message-ID (diff)
From: Jakub Kicinski <kuba@kernel.org>
To: Anant Thazhemadam <anant.thazhemadam@gmail.com>
Cc: linux-usb@vger.kernel.org, netdev@vger.kernel.org,
Oliver Neukum <oneukum@suse.com>,
linux-kernel@vger.kernel.org,
linux-kernel-mentees@lists.linuxfoundation.org,
"David S . Miller" <davem@davemloft.net>
Subject: Re: [Linux-kernel-mentees] [PATCH v2] net: usb: usbnet: update __usbnet_{read|write}_cmd() to use new API
Date: Sat, 31 Oct 2020 14:11:43 -0700 [thread overview]
Message-ID: <20201031141143.5c8463e1@kicinski-fedora-PC1C0HJN.hsd1.ca.comcast.net> (raw)
In-Reply-To: <20201029132256.11793-1-anant.thazhemadam@gmail.com>
On Thu, 29 Oct 2020 18:52:56 +0530 Anant Thazhemadam wrote:
> + return usb_control_msg_recv(dev->udev, 0,
> + cmd, reqtype, value, index, data, size,
> + USB_CTRL_GET_TIMEOUT, GFP_KERNEL);
Please align continuation lines after the opening bracket.
_______________________________________________
Linux-kernel-mentees mailing list
Linux-kernel-mentees@lists.linuxfoundation.org
https://lists.linuxfoundation.org/mailman/listinfo/linux-kernel-mentees
next prev parent reply other threads:[~2020-10-31 21:11 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-10 6:56 [PATCH] net: usb: usbnet: update __usbnet_{read|write}_cmd() to use new API Anant Thazhemadam
2020-10-10 6:56 ` [Linux-kernel-mentees] " Anant Thazhemadam
2020-10-10 17:03 ` Jakub Kicinski
2020-10-10 17:03 ` [Linux-kernel-mentees] " Jakub Kicinski
2020-10-10 17:48 ` Anant Thazhemadam
2020-10-10 17:48 ` [Linux-kernel-mentees] " Anant Thazhemadam
2020-10-13 0:14 ` kernel test robot
2020-10-13 0:14 ` kernel test robot
2020-10-13 0:14 ` [Linux-kernel-mentees] " kernel test robot
2020-10-29 13:22 ` [PATCH v2] " Anant Thazhemadam
2020-10-29 13:22 ` [Linux-kernel-mentees] " Anant Thazhemadam
2020-10-29 15:16 ` Anant Thazhemadam
2020-10-29 15:16 ` [Linux-kernel-mentees] " Anant Thazhemadam
2020-10-29 16:30 ` Alan Stern
2020-10-29 16:30 ` [Linux-kernel-mentees] " Alan Stern
2020-10-31 21:11 ` Jakub Kicinski [this message]
2020-10-31 21:11 ` Jakub Kicinski
2020-10-31 21:31 ` Anant Thazhemadam
2020-10-31 21:31 ` [Linux-kernel-mentees] " Anant Thazhemadam
2020-10-31 21:35 ` [PATCH v3] " Anant Thazhemadam
2020-10-31 21:35 ` [Linux-kernel-mentees] " Anant Thazhemadam
2020-11-02 9:40 ` Oliver Neukum
2020-11-02 9:40 ` [Linux-kernel-mentees] " Oliver Neukum
2020-11-02 16:40 ` Anant Thazhemadam
2020-11-02 16:40 ` [Linux-kernel-mentees] " Anant Thazhemadam
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201031141143.5c8463e1@kicinski-fedora-PC1C0HJN.hsd1.ca.comcast.net \
--to=kuba@kernel.org \
--cc=anant.thazhemadam@gmail.com \
--cc=davem@davemloft.net \
--cc=linux-kernel-mentees@lists.linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=oneukum@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.