All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH 1/3] riscv: Fix compressed Image formats build
@ 2020-11-02  4:03 Kefeng Wang
  2020-11-02  4:03 ` [PATCH 2/3] riscv: cleaning up boot dir Kefeng Wang
                   ` (2 more replies)
  0 siblings, 3 replies; 9+ messages in thread
From: Kefeng Wang @ 2020-11-02  4:03 UTC (permalink / raw)
  To: Paul Walmsley, Palmer Dabbelt, Albert Ou, linux-riscv; +Cc: Kefeng Wang

make[1]: *** No rule to make target `Image.lzma'.  Stop.

When make ARCH=riscv Image.lzma, it won't work, let's fix it.

Signed-off-by: Kefeng Wang <wangkefeng.wang@huawei.com>
---
 arch/riscv/Makefile | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/arch/riscv/Makefile b/arch/riscv/Makefile
index 0289a97325d1..0d9ecb959962 100644
--- a/arch/riscv/Makefile
+++ b/arch/riscv/Makefile
@@ -96,5 +96,8 @@ $(BOOT_TARGETS): vmlinux
 	$(Q)$(MAKE) $(build)=$(boot) $(boot)/$@
 	@$(kecho) '  Kernel: $(boot)/$@ is ready'
 
+Image.%: Image
+	$(Q)$(MAKE) $(build)=$(boot) $(boot)/$@
+
 zinstall install:
 	$(Q)$(MAKE) $(build)=$(boot) $@
-- 
2.26.2


_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv

^ permalink raw reply related	[flat|nested] 9+ messages in thread

* [PATCH 2/3] riscv: cleaning up boot dir
  2020-11-02  4:03 [PATCH 1/3] riscv: Fix compressed Image formats build Kefeng Wang
@ 2020-11-02  4:03 ` Kefeng Wang
  2020-11-03 15:53   ` Atish Patra
  2020-11-02  4:03 ` [PATCH 3/3] riscv: Ignore all compressed Image formats Kefeng Wang
  2020-11-03 15:34 ` [PATCH 1/3] riscv: Fix compressed Image formats build Atish Patra
  2 siblings, 1 reply; 9+ messages in thread
From: Kefeng Wang @ 2020-11-02  4:03 UTC (permalink / raw)
  To: Paul Walmsley, Palmer Dabbelt, Albert Ou, linux-riscv; +Cc: Kefeng Wang

Let's remove all files under riscv boot dir by using archclean rule.

Signed-off-by: Kefeng Wang <wangkefeng.wang@huawei.com>
---
 arch/riscv/Makefile      | 3 +++
 arch/riscv/boot/Makefile | 3 ++-
 2 files changed, 5 insertions(+), 1 deletion(-)

diff --git a/arch/riscv/Makefile b/arch/riscv/Makefile
index 0d9ecb959962..8c29e553ef7f 100644
--- a/arch/riscv/Makefile
+++ b/arch/riscv/Makefile
@@ -101,3 +101,6 @@ Image.%: Image
 
 zinstall install:
 	$(Q)$(MAKE) $(build)=$(boot) $@
+
+archclean:
+	$(Q)$(MAKE) $(clean)=$(boot)
diff --git a/arch/riscv/boot/Makefile b/arch/riscv/boot/Makefile
index c59fca695f9d..666f08662170 100644
--- a/arch/riscv/boot/Makefile
+++ b/arch/riscv/boot/Makefile
@@ -18,7 +18,8 @@ KCOV_INSTRUMENT := n
 
 OBJCOPYFLAGS_Image :=-O binary -R .note -R .note.gnu.build-id -R .comment -S
 
-targets := Image loader
+targets := Image Image.bz2 Image.gz Image.lz4 Image.lzma Image.lzo \
+	   loader loader.o loader.lds loader.bin
 
 $(obj)/Image: vmlinux FORCE
 	$(call if_changed,objcopy)
-- 
2.26.2


_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv

^ permalink raw reply related	[flat|nested] 9+ messages in thread

* [PATCH 3/3] riscv: Ignore all compressed Image formats
  2020-11-02  4:03 [PATCH 1/3] riscv: Fix compressed Image formats build Kefeng Wang
  2020-11-02  4:03 ` [PATCH 2/3] riscv: cleaning up boot dir Kefeng Wang
@ 2020-11-02  4:03 ` Kefeng Wang
  2020-11-02  7:27   ` Kefeng Wang
  2020-11-03 15:34 ` [PATCH 1/3] riscv: Fix compressed Image formats build Atish Patra
  2 siblings, 1 reply; 9+ messages in thread
From: Kefeng Wang @ 2020-11-02  4:03 UTC (permalink / raw)
  To: Paul Walmsley, Palmer Dabbelt, Albert Ou, linux-riscv; +Cc: Kefeng Wang

Do not track all compressed Image formats.

Signed-off-by: Kefeng Wang <wangkefeng.wang@huawei.com>
---
 arch/riscv/boot/.gitignore | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/riscv/boot/.gitignore b/arch/riscv/boot/.gitignore
index 574c10f8ff68..2a31a61ca382 100644
--- a/arch/riscv/boot/.gitignore
+++ b/arch/riscv/boot/.gitignore
@@ -1,5 +1,5 @@
 # SPDX-License-Identifier: GPL-2.0-only
 Image
-Image.gz
+Image.*
 loader
 loader.lds
-- 
2.26.2


_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv

^ permalink raw reply related	[flat|nested] 9+ messages in thread

* Re: [PATCH 3/3] riscv: Ignore all compressed Image formats
  2020-11-02  4:03 ` [PATCH 3/3] riscv: Ignore all compressed Image formats Kefeng Wang
@ 2020-11-02  7:27   ` Kefeng Wang
  2020-11-03 15:56     ` Atish Patra
  0 siblings, 1 reply; 9+ messages in thread
From: Kefeng Wang @ 2020-11-02  7:27 UTC (permalink / raw)
  To: Paul Walmsley, Palmer Dabbelt, Albert Ou, linux-riscv


On 2020/11/2 12:03, Kefeng Wang wrote:
> Do not track all compressed Image formats.
should add all loader.* too, eg loader.bin,  will resend after all 
patches reviewed.
>
> Signed-off-by: Kefeng Wang <wangkefeng.wang@huawei.com>
> ---
>   arch/riscv/boot/.gitignore | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/riscv/boot/.gitignore b/arch/riscv/boot/.gitignore
> index 574c10f8ff68..2a31a61ca382 100644
> --- a/arch/riscv/boot/.gitignore
> +++ b/arch/riscv/boot/.gitignore
> @@ -1,5 +1,5 @@
>   # SPDX-License-Identifier: GPL-2.0-only
>   Image
> -Image.gz
> +Image.*
>   loader
>   loader.lds

_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv

^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: [PATCH 1/3] riscv: Fix compressed Image formats build
  2020-11-02  4:03 [PATCH 1/3] riscv: Fix compressed Image formats build Kefeng Wang
  2020-11-02  4:03 ` [PATCH 2/3] riscv: cleaning up boot dir Kefeng Wang
  2020-11-02  4:03 ` [PATCH 3/3] riscv: Ignore all compressed Image formats Kefeng Wang
@ 2020-11-03 15:34 ` Atish Patra
  2 siblings, 0 replies; 9+ messages in thread
From: Atish Patra @ 2020-11-03 15:34 UTC (permalink / raw)
  To: Kefeng Wang; +Cc: linux-riscv, Albert Ou, Palmer Dabbelt, Paul Walmsley

On Sun, Nov 1, 2020 at 7:58 PM Kefeng Wang <wangkefeng.wang@huawei.com> wrote:
>
> make[1]: *** No rule to make target `Image.lzma'.  Stop.
>
> When make ARCH=riscv Image.lzma, it won't work, let's fix it.
>
> Signed-off-by: Kefeng Wang <wangkefeng.wang@huawei.com>
> ---
>  arch/riscv/Makefile | 3 +++
>  1 file changed, 3 insertions(+)
>
> diff --git a/arch/riscv/Makefile b/arch/riscv/Makefile
> index 0289a97325d1..0d9ecb959962 100644
> --- a/arch/riscv/Makefile
> +++ b/arch/riscv/Makefile
> @@ -96,5 +96,8 @@ $(BOOT_TARGETS): vmlinux
>         $(Q)$(MAKE) $(build)=$(boot) $(boot)/$@
>         @$(kecho) '  Kernel: $(boot)/$@ is ready'
>
> +Image.%: Image
> +       $(Q)$(MAKE) $(build)=$(boot) $(boot)/$@
> +
>  zinstall install:
>         $(Q)$(MAKE) $(build)=$(boot) $@
> --
> 2.26.2
>
>
> _______________________________________________
> linux-riscv mailing list
> linux-riscv@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-riscv


Reviewed-by: Atish Patra <atish.patra@wdc.com>

-- 
Regards,
Atish

_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv

^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: [PATCH 2/3] riscv: cleaning up boot dir
  2020-11-02  4:03 ` [PATCH 2/3] riscv: cleaning up boot dir Kefeng Wang
@ 2020-11-03 15:53   ` Atish Patra
  2020-11-04  3:16     ` Kefeng Wang
  0 siblings, 1 reply; 9+ messages in thread
From: Atish Patra @ 2020-11-03 15:53 UTC (permalink / raw)
  To: Kefeng Wang; +Cc: linux-riscv, Albert Ou, Palmer Dabbelt, Paul Walmsley

On Sun, Nov 1, 2020 at 7:58 PM Kefeng Wang <wangkefeng.wang@huawei.com> wrote:
>
> Let's remove all files under riscv boot dir by using archclean rule.
>
> Signed-off-by: Kefeng Wang <wangkefeng.wang@huawei.com>
> ---
>  arch/riscv/Makefile      | 3 +++
>  arch/riscv/boot/Makefile | 3 ++-
>  2 files changed, 5 insertions(+), 1 deletion(-)
>
> diff --git a/arch/riscv/Makefile b/arch/riscv/Makefile
> index 0d9ecb959962..8c29e553ef7f 100644
> --- a/arch/riscv/Makefile
> +++ b/arch/riscv/Makefile
> @@ -101,3 +101,6 @@ Image.%: Image
>
>  zinstall install:
>         $(Q)$(MAKE) $(build)=$(boot) $@
> +
> +archclean:
> +       $(Q)$(MAKE) $(clean)=$(boot)
> diff --git a/arch/riscv/boot/Makefile b/arch/riscv/boot/Makefile
> index c59fca695f9d..666f08662170 100644
> --- a/arch/riscv/boot/Makefile
> +++ b/arch/riscv/boot/Makefile
> @@ -18,7 +18,8 @@ KCOV_INSTRUMENT := n
>
>  OBJCOPYFLAGS_Image :=-O binary -R .note -R .note.gnu.build-id -R .comment -S
>
> -targets := Image loader
> +targets := Image Image.bz2 Image.gz Image.lz4 Image.lzma Image.lzo \
> +          loader loader.o loader.lds loader.bin
>

Image.* should be sufficient to clean all compressed images.

>  $(obj)/Image: vmlinux FORCE
>         $(call if_changed,objcopy)
> --
> 2.26.2
>
>
> _______________________________________________
> linux-riscv mailing list
> linux-riscv@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-riscv

Otherwise,

Reviewed-by: Atish Patra <atish.patra@wdc.com>

-- 
Regards,
Atish

_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv

^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: [PATCH 3/3] riscv: Ignore all compressed Image formats
  2020-11-02  7:27   ` Kefeng Wang
@ 2020-11-03 15:56     ` Atish Patra
  2020-11-04  3:17       ` Kefeng Wang
  0 siblings, 1 reply; 9+ messages in thread
From: Atish Patra @ 2020-11-03 15:56 UTC (permalink / raw)
  To: Kefeng Wang; +Cc: linux-riscv, Albert Ou, Palmer Dabbelt, Paul Walmsley

On Sun, Nov 1, 2020 at 11:27 PM Kefeng Wang <wangkefeng.wang@huawei.com> wrote:
>
>
> On 2020/11/2 12:03, Kefeng Wang wrote:
> > Do not track all compressed Image formats.
> should add all loader.* too, eg loader.bin,  will resend after all
> patches reviewed.
> >

But not loader.S & loader.lds.S

> > Signed-off-by: Kefeng Wang <wangkefeng.wang@huawei.com>
> > ---
> >   arch/riscv/boot/.gitignore | 2 +-
> >   1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/arch/riscv/boot/.gitignore b/arch/riscv/boot/.gitignore
> > index 574c10f8ff68..2a31a61ca382 100644
> > --- a/arch/riscv/boot/.gitignore
> > +++ b/arch/riscv/boot/.gitignore
> > @@ -1,5 +1,5 @@
> >   # SPDX-License-Identifier: GPL-2.0-only
> >   Image
> > -Image.gz
> > +Image.*
> >   loader
> >   loader.lds
>
> _______________________________________________
> linux-riscv mailing list
> linux-riscv@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-riscv



-- 
Regards,
Atish

_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv

^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: [PATCH 2/3] riscv: cleaning up boot dir
  2020-11-03 15:53   ` Atish Patra
@ 2020-11-04  3:16     ` Kefeng Wang
  0 siblings, 0 replies; 9+ messages in thread
From: Kefeng Wang @ 2020-11-04  3:16 UTC (permalink / raw)
  To: Atish Patra; +Cc: linux-riscv, Albert Ou, Palmer Dabbelt, Paul Walmsley


On 2020/11/3 23:53, Atish Patra wrote:
> On Sun, Nov 1, 2020 at 7:58 PM Kefeng Wang <wangkefeng.wang@huawei.com> wrote:
>> Let's remove all files under riscv boot dir by using archclean rule.
>>
>> Signed-off-by: Kefeng Wang <wangkefeng.wang@huawei.com>
>> ---
>>   arch/riscv/Makefile      | 3 +++
>>   arch/riscv/boot/Makefile | 3 ++-
>>   2 files changed, 5 insertions(+), 1 deletion(-)
>>
>> diff --git a/arch/riscv/Makefile b/arch/riscv/Makefile
>> index 0d9ecb959962..8c29e553ef7f 100644
>> --- a/arch/riscv/Makefile
>> +++ b/arch/riscv/Makefile
>> @@ -101,3 +101,6 @@ Image.%: Image
>>
>>   zinstall install:
>>          $(Q)$(MAKE) $(build)=$(boot) $@
>> +
>> +archclean:
>> +       $(Q)$(MAKE) $(clean)=$(boot)
>> diff --git a/arch/riscv/boot/Makefile b/arch/riscv/boot/Makefile
>> index c59fca695f9d..666f08662170 100644
>> --- a/arch/riscv/boot/Makefile
>> +++ b/arch/riscv/boot/Makefile
>> @@ -18,7 +18,8 @@ KCOV_INSTRUMENT := n
>>
>>   OBJCOPYFLAGS_Image :=-O binary -R .note -R .note.gnu.build-id -R .comment -S
>>
>> -targets := Image loader
>> +targets := Image Image.bz2 Image.gz Image.lz4 Image.lzma Image.lzo \
>> +          loader loader.o loader.lds loader.bin
>>
> Image.* should be sufficient to clean all compressed images.

Will change and resend, thanks.

>
>>   $(obj)/Image: vmlinux FORCE
>>          $(call if_changed,objcopy)
>> --
>> 2.26.2
>>
>>
>> _______________________________________________
>> linux-riscv mailing list
>> linux-riscv@lists.infradead.org
>> http://lists.infradead.org/mailman/listinfo/linux-riscv
> Otherwise,
>
> Reviewed-by: Atish Patra <atish.patra@wdc.com>
>

_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv

^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: [PATCH 3/3] riscv: Ignore all compressed Image formats
  2020-11-03 15:56     ` Atish Patra
@ 2020-11-04  3:17       ` Kefeng Wang
  0 siblings, 0 replies; 9+ messages in thread
From: Kefeng Wang @ 2020-11-04  3:17 UTC (permalink / raw)
  To: Atish Patra; +Cc: linux-riscv, Albert Ou, Palmer Dabbelt, Paul Walmsley


On 2020/11/3 23:56, Atish Patra wrote:
> On Sun, Nov 1, 2020 at 11:27 PM Kefeng Wang <wangkefeng.wang@huawei.com> wrote:
>>
>> On 2020/11/2 12:03, Kefeng Wang wrote:
>>> Do not track all compressed Image formats.
>> should add all loader.* too, eg loader.bin,  will resend after all
>> patches reviewed.
> But not loader.S & loader.lds.S

Yes, only add loader.bin, will send v2, thanks

>
>>> Signed-off-by: Kefeng Wang <wangkefeng.wang@huawei.com>
>>> ---
>>>    arch/riscv/boot/.gitignore | 2 +-
>>>    1 file changed, 1 insertion(+), 1 deletion(-)
>>>
>>> diff --git a/arch/riscv/boot/.gitignore b/arch/riscv/boot/.gitignore
>>> index 574c10f8ff68..2a31a61ca382 100644
>>> --- a/arch/riscv/boot/.gitignore
>>> +++ b/arch/riscv/boot/.gitignore
>>> @@ -1,5 +1,5 @@
>>>    # SPDX-License-Identifier: GPL-2.0-only
>>>    Image
>>> -Image.gz
>>> +Image.*
>>>    loader
>>>    loader.lds
>> _______________________________________________
>> linux-riscv mailing list
>> linux-riscv@lists.infradead.org
>> http://lists.infradead.org/mailman/listinfo/linux-riscv
>
>

_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv

^ permalink raw reply	[flat|nested] 9+ messages in thread

end of thread, other threads:[~2020-11-04  3:17 UTC | newest]

Thread overview: 9+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-11-02  4:03 [PATCH 1/3] riscv: Fix compressed Image formats build Kefeng Wang
2020-11-02  4:03 ` [PATCH 2/3] riscv: cleaning up boot dir Kefeng Wang
2020-11-03 15:53   ` Atish Patra
2020-11-04  3:16     ` Kefeng Wang
2020-11-02  4:03 ` [PATCH 3/3] riscv: Ignore all compressed Image formats Kefeng Wang
2020-11-02  7:27   ` Kefeng Wang
2020-11-03 15:56     ` Atish Patra
2020-11-04  3:17       ` Kefeng Wang
2020-11-03 15:34 ` [PATCH 1/3] riscv: Fix compressed Image formats build Atish Patra

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.