* [PATCH] Append the password to the username on git URI reassembling.
@ 2020-11-02 10:24 ds
2020-11-02 10:52 ` [bitbake-devel] " Paul Barker
0 siblings, 1 reply; 3+ messages in thread
From: ds @ 2020-11-02 10:24 UTC (permalink / raw)
To: bitbake-devel; +Cc: Dominik Schmidt
This allows the users to specify SRC_URIs of the form
git://user:password@host.tld/path/to/repo.git
which allows pulling in private repositories.
---
lib/bb/fetch2/git.py | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/lib/bb/fetch2/git.py b/lib/bb/fetch2/git.py
index b97967b4..090fa173 100644
--- a/lib/bb/fetch2/git.py
+++ b/lib/bb/fetch2/git.py
@@ -596,7 +596,10 @@ class Git(FetchMethod):
Return the repository URL
"""
if ud.user:
- username = ud.user + '@'
+ username = ud.user
+ if ud.pswd:
+ username += ":" + ud.pswd
+ username += "@"
else:
username = ""
return "%s://%s%s%s" % (ud.proto, username, ud.host, ud.path)
--
2.25.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [bitbake-devel] [PATCH] Append the password to the username on git URI reassembling.
2020-11-02 10:24 [PATCH] Append the password to the username on git URI reassembling ds
@ 2020-11-02 10:52 ` Paul Barker
2020-11-02 11:30 ` Richard Purdie
0 siblings, 1 reply; 3+ messages in thread
From: Paul Barker @ 2020-11-02 10:52 UTC (permalink / raw)
To: Dominik Schmidt; +Cc: bitbake-devel
On Mon, 2 Nov 2020 at 10:25, Dominik Schmidt <ds@technokrat.ch> wrote:
>
> This allows the users to specify SRC_URIs of the form
>
> git://user:password@host.tld/path/to/repo.git
>
> which allows pulling in private repositories.
This has been discussed and rejected before multiple times, see for
example https://lists.openembedded.org/g/bitbake-devel/topic/72129859.
Thanks,
--
Paul Barker
Konsulko Group
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [bitbake-devel] [PATCH] Append the password to the username on git URI reassembling.
2020-11-02 10:52 ` [bitbake-devel] " Paul Barker
@ 2020-11-02 11:30 ` Richard Purdie
0 siblings, 0 replies; 3+ messages in thread
From: Richard Purdie @ 2020-11-02 11:30 UTC (permalink / raw)
To: Paul Barker, Dominik Schmidt; +Cc: bitbake-devel
On Mon, 2020-11-02 at 10:52 +0000, Paul Barker wrote:
> On Mon, 2 Nov 2020 at 10:25, Dominik Schmidt <ds@technokrat.ch>
> wrote:
> > This allows the users to specify SRC_URIs of the form
> >
> > git://user:password@host.tld/path/to/repo.git
> >
> > which allows pulling in private repositories.
>
> This has been discussed and rejected before multiple times, see for
> example https://lists.openembedded.org/g/bitbake-devel/topic/72129859
> .
I think we should put a comment in the code about this as we keep
getting patches...
Cheers,
Richard
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-11-02 11:30 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-11-02 10:24 [PATCH] Append the password to the username on git URI reassembling ds
2020-11-02 10:52 ` [bitbake-devel] " Paul Barker
2020-11-02 11:30 ` Richard Purdie
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.