* [igt-dev] [PATCH i-g-t] i915/perf: Make sure i915 is loaded before reading proc
@ 2020-11-02 19:49 Umesh Nerlige Ramappa
2020-11-02 20:37 ` [igt-dev] ✓ Fi.CI.BAT: success for i915/perf: Make sure i915 is loaded before reading proc (rev3) Patchwork
` (2 more replies)
0 siblings, 3 replies; 12+ messages in thread
From: Umesh Nerlige Ramappa @ 2020-11-02 19:49 UTC (permalink / raw)
To: igt-dev; +Cc: Petri Latvala
The previous test may have unloaded i915 or failed to load it back. To
combat such cases, each test fixture is supposed to ensure that i915 is
loaded prior to running the subtests. In most fixtures this happens
automatically when we try to get a handle to i915. In perf OA, we stat
some proc/sys files even before getting a handle to i915. Occassionally,
perf tests fail trying to stat these files. Fix perf OA by checking and
loading i915 if it's not loaded.
v2: Use drm_load_module() (Petri)
Closes: https://gitlab.freedesktop.org/drm/intel/-/issues/405
Signed-off-by: Umesh Nerlige Ramappa <umesh.nerlige.ramappa@intel.com>
Reviewed-by: Petri Latvala <petri.latvala@intel.com>
Reviewed-by: Ashutosh Dixit <ashutosh.dixit@intel.com>
---
tests/i915/perf.c | 7 +++++++
1 file changed, 7 insertions(+)
diff --git a/tests/i915/perf.c b/tests/i915/perf.c
index a5c4adc3..caeabd62 100644
--- a/tests/i915/perf.c
+++ b/tests/i915/perf.c
@@ -4806,6 +4806,13 @@ igt_main
igt_fixture {
struct stat sb;
+ /*
+ * Prior tests may have unloaded i915 or failed while
+ * loading/unloading i915. Load i915 here before we stat the
+ * files.
+ */
+ drm_load_module(DRIVER_INTEL);
+
igt_require(stat("/proc/sys/dev/i915/perf_stream_paranoid", &sb)
== 0);
igt_require(stat("/proc/sys/dev/i915/oa_max_sample_rate", &sb)
--
2.20.1
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply related [flat|nested] 12+ messages in thread
* [igt-dev] ✓ Fi.CI.BAT: success for i915/perf: Make sure i915 is loaded before reading proc (rev3)
2020-11-02 19:49 [igt-dev] [PATCH i-g-t] i915/perf: Make sure i915 is loaded before reading proc Umesh Nerlige Ramappa
@ 2020-11-02 20:37 ` Patchwork
2020-11-03 3:58 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork
2020-11-03 8:06 ` [igt-dev] [PATCH i-g-t] i915/perf: Make sure i915 is loaded before reading proc Petri Latvala
2 siblings, 0 replies; 12+ messages in thread
From: Patchwork @ 2020-11-02 20:37 UTC (permalink / raw)
To: Umesh Nerlige Ramappa; +Cc: igt-dev
[-- Attachment #1.1: Type: text/plain, Size: 5038 bytes --]
== Series Details ==
Series: i915/perf: Make sure i915 is loaded before reading proc (rev3)
URL : https://patchwork.freedesktop.org/series/83222/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_9247 -> IGTPW_5117
====================================================
Summary
-------
**SUCCESS**
No regressions found.
External URL: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5117/index.html
Known issues
------------
Here are the changes found in IGTPW_5117 that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@gem_exec_suspend@basic-s0:
- fi-apl-guc: [PASS][1] -> [DMESG-WARN][2] ([i915#1635] / [i915#62]) +1 similar issue
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9247/fi-apl-guc/igt@gem_exec_suspend@basic-s0.html
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5117/fi-apl-guc/igt@gem_exec_suspend@basic-s0.html
* igt@i915_module_load@reload:
- fi-byt-j1900: [PASS][3] -> [DMESG-WARN][4] ([i915#1982]) +1 similar issue
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9247/fi-byt-j1900/igt@i915_module_load@reload.html
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5117/fi-byt-j1900/igt@i915_module_load@reload.html
* igt@i915_pm_rpm@module-reload:
- fi-skl-lmem: [PASS][5] -> [DMESG-WARN][6] ([i915#2605])
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9247/fi-skl-lmem/igt@i915_pm_rpm@module-reload.html
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5117/fi-skl-lmem/igt@i915_pm_rpm@module-reload.html
#### Possible fixes ####
* igt@i915_pm_rpm@basic-pci-d3-state:
- fi-bsw-n3050: [DMESG-WARN][7] ([i915#1982]) -> [PASS][8]
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9247/fi-bsw-n3050/igt@i915_pm_rpm@basic-pci-d3-state.html
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5117/fi-bsw-n3050/igt@i915_pm_rpm@basic-pci-d3-state.html
* igt@i915_selftest@live@gt_heartbeat:
- {fi-tgl-dsi}: [DMESG-FAIL][9] ([i915#2601]) -> [PASS][10]
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9247/fi-tgl-dsi/igt@i915_selftest@live@gt_heartbeat.html
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5117/fi-tgl-dsi/igt@i915_selftest@live@gt_heartbeat.html
* igt@kms_cursor_legacy@basic-busy-flip-before-cursor-atomic:
- {fi-kbl-7560u}: [DMESG-WARN][11] ([i915#1982]) -> [PASS][12]
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9247/fi-kbl-7560u/igt@kms_cursor_legacy@basic-busy-flip-before-cursor-atomic.html
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5117/fi-kbl-7560u/igt@kms_cursor_legacy@basic-busy-flip-before-cursor-atomic.html
- fi-bsw-kefka: [DMESG-WARN][13] ([i915#1982]) -> [PASS][14] +1 similar issue
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9247/fi-bsw-kefka/igt@kms_cursor_legacy@basic-busy-flip-before-cursor-atomic.html
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5117/fi-bsw-kefka/igt@kms_cursor_legacy@basic-busy-flip-before-cursor-atomic.html
* igt@kms_flip@basic-flip-vs-wf_vblank@c-edp1:
- fi-icl-u2: [DMESG-WARN][15] ([i915#1982]) -> [PASS][16]
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9247/fi-icl-u2/igt@kms_flip@basic-flip-vs-wf_vblank@c-edp1.html
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5117/fi-icl-u2/igt@kms_flip@basic-flip-vs-wf_vblank@c-edp1.html
#### Warnings ####
* igt@amdgpu/amd_prime@i915-to-amd:
- fi-gdg-551: [INCOMPLETE][17] ([i915#172]) -> [SKIP][18] ([fdo#109271])
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9247/fi-gdg-551/igt@amdgpu/amd_prime@i915-to-amd.html
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5117/fi-gdg-551/igt@amdgpu/amd_prime@i915-to-amd.html
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[i915#1635]: https://gitlab.freedesktop.org/drm/intel/issues/1635
[i915#172]: https://gitlab.freedesktop.org/drm/intel/issues/172
[i915#1982]: https://gitlab.freedesktop.org/drm/intel/issues/1982
[i915#2601]: https://gitlab.freedesktop.org/drm/intel/issues/2601
[i915#2605]: https://gitlab.freedesktop.org/drm/intel/issues/2605
[i915#62]: https://gitlab.freedesktop.org/drm/intel/issues/62
Participating hosts (43 -> 39)
------------------------------
Missing (4): fi-ilk-m540 fi-bsw-cyan fi-bdw-samus fi-hsw-4200u
Build changes
-------------
* CI: CI-20190529 -> None
* IGT: IGT_5830 -> IGTPW_5117
CI-20190529: 20190529
CI_DRM_9247: 009a99e9be393d32ed57bcac34d6b1fb37c28cdf @ git://anongit.freedesktop.org/gfx-ci/linux
IGTPW_5117: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5117/index.html
IGT_5830: 12d370cb57e0cfcb781c87ad9e15e68b17a1f41f @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5117/index.html
[-- Attachment #1.2: Type: text/html, Size: 6120 bytes --]
[-- Attachment #2: Type: text/plain, Size: 154 bytes --]
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply [flat|nested] 12+ messages in thread
* [igt-dev] ✓ Fi.CI.IGT: success for i915/perf: Make sure i915 is loaded before reading proc (rev3)
2020-11-02 19:49 [igt-dev] [PATCH i-g-t] i915/perf: Make sure i915 is loaded before reading proc Umesh Nerlige Ramappa
2020-11-02 20:37 ` [igt-dev] ✓ Fi.CI.BAT: success for i915/perf: Make sure i915 is loaded before reading proc (rev3) Patchwork
@ 2020-11-03 3:58 ` Patchwork
2020-11-03 8:06 ` [igt-dev] [PATCH i-g-t] i915/perf: Make sure i915 is loaded before reading proc Petri Latvala
2 siblings, 0 replies; 12+ messages in thread
From: Patchwork @ 2020-11-03 3:58 UTC (permalink / raw)
To: Umesh Nerlige Ramappa; +Cc: igt-dev
[-- Attachment #1.1: Type: text/plain, Size: 23773 bytes --]
== Series Details ==
Series: i915/perf: Make sure i915 is loaded before reading proc (rev3)
URL : https://patchwork.freedesktop.org/series/83222/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_9247_full -> IGTPW_5117_full
====================================================
Summary
-------
**SUCCESS**
No regressions found.
External URL: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5117/index.html
Known issues
------------
Here are the changes found in IGTPW_5117_full that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@core_hotunplug@hotunbind-rebind:
- shard-tglb: [PASS][1] -> [DMESG-WARN][2] ([i915#1982]) +1 similar issue
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9247/shard-tglb1/igt@core_hotunplug@hotunbind-rebind.html
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5117/shard-tglb1/igt@core_hotunplug@hotunbind-rebind.html
* igt@gem_eio@kms:
- shard-hsw: [PASS][3] -> [INCOMPLETE][4] ([i915#1888] / [i915#2244])
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9247/shard-hsw4/igt@gem_eio@kms.html
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5117/shard-hsw1/igt@gem_eio@kms.html
- shard-snb: [PASS][5] -> [INCOMPLETE][6] ([i915#82])
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9247/shard-snb6/igt@gem_eio@kms.html
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5117/shard-snb6/igt@gem_eio@kms.html
* igt@gem_exec_whisper@basic-contexts-forked-all:
- shard-glk: [PASS][7] -> [DMESG-WARN][8] ([i915#118] / [i915#95])
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9247/shard-glk1/igt@gem_exec_whisper@basic-contexts-forked-all.html
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5117/shard-glk8/igt@gem_exec_whisper@basic-contexts-forked-all.html
* igt@kms_cursor_legacy@basic-flip-before-cursor-legacy:
- shard-hsw: [PASS][9] -> [DMESG-WARN][10] ([i915#1982]) +1 similar issue
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9247/shard-hsw6/igt@kms_cursor_legacy@basic-flip-before-cursor-legacy.html
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5117/shard-hsw1/igt@kms_cursor_legacy@basic-flip-before-cursor-legacy.html
* igt@kms_draw_crc@draw-method-rgb565-mmap-wc-xtiled:
- shard-apl: [PASS][11] -> [DMESG-WARN][12] ([i915#1635] / [i915#1982]) +4 similar issues
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9247/shard-apl6/igt@kms_draw_crc@draw-method-rgb565-mmap-wc-xtiled.html
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5117/shard-apl4/igt@kms_draw_crc@draw-method-rgb565-mmap-wc-xtiled.html
* igt@kms_flip@absolute-wf_vblank-interruptible@a-dp1:
- shard-kbl: [PASS][13] -> [DMESG-WARN][14] ([i915#1982]) +3 similar issues
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9247/shard-kbl7/igt@kms_flip@absolute-wf_vblank-interruptible@a-dp1.html
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5117/shard-kbl6/igt@kms_flip@absolute-wf_vblank-interruptible@a-dp1.html
* igt@kms_flip@flip-vs-expired-vblank@b-hdmi-a1:
- shard-glk: [PASS][15] -> [FAIL][16] ([i915#2122])
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9247/shard-glk6/igt@kms_flip@flip-vs-expired-vblank@b-hdmi-a1.html
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5117/shard-glk7/igt@kms_flip@flip-vs-expired-vblank@b-hdmi-a1.html
* igt@kms_frontbuffer_tracking@fbc-2p-scndscrn-spr-indfb-draw-mmap-gtt:
- shard-glk: [PASS][17] -> [FAIL][18] ([i915#49])
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9247/shard-glk9/igt@kms_frontbuffer_tracking@fbc-2p-scndscrn-spr-indfb-draw-mmap-gtt.html
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5117/shard-glk6/igt@kms_frontbuffer_tracking@fbc-2p-scndscrn-spr-indfb-draw-mmap-gtt.html
* igt@kms_frontbuffer_tracking@psr-1p-offscren-pri-indfb-draw-mmap-cpu:
- shard-iclb: [PASS][19] -> [DMESG-WARN][20] ([i915#1982])
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9247/shard-iclb8/igt@kms_frontbuffer_tracking@psr-1p-offscren-pri-indfb-draw-mmap-cpu.html
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5117/shard-iclb7/igt@kms_frontbuffer_tracking@psr-1p-offscren-pri-indfb-draw-mmap-cpu.html
* igt@kms_plane_cursor@pipe-a-overlay-size-256:
- shard-glk: [PASS][21] -> [DMESG-WARN][22] ([i915#1982]) +5 similar issues
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9247/shard-glk9/igt@kms_plane_cursor@pipe-a-overlay-size-256.html
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5117/shard-glk6/igt@kms_plane_cursor@pipe-a-overlay-size-256.html
* igt@kms_psr@psr2_primary_mmap_cpu:
- shard-iclb: [PASS][23] -> [SKIP][24] ([fdo#109441]) +2 similar issues
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9247/shard-iclb2/igt@kms_psr@psr2_primary_mmap_cpu.html
[24]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5117/shard-iclb1/igt@kms_psr@psr2_primary_mmap_cpu.html
* igt@perf@invalid-open-flags:
- shard-tglb: [PASS][25] -> [SKIP][26] ([i915#1354])
[25]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9247/shard-tglb2/igt@perf@invalid-open-flags.html
[26]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5117/shard-tglb5/igt@perf@invalid-open-flags.html
- shard-apl: [PASS][27] -> [SKIP][28] ([fdo#109271] / [i915#1354] / [i915#1635])
[27]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9247/shard-apl3/igt@perf@invalid-open-flags.html
[28]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5117/shard-apl6/igt@perf@invalid-open-flags.html
- shard-iclb: [PASS][29] -> [SKIP][30] ([i915#1354])
[29]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9247/shard-iclb7/igt@perf@invalid-open-flags.html
[30]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5117/shard-iclb4/igt@perf@invalid-open-flags.html
- shard-glk: [PASS][31] -> [SKIP][32] ([fdo#109271] / [i915#1354])
[31]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9247/shard-glk1/igt@perf@invalid-open-flags.html
[32]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5117/shard-glk1/igt@perf@invalid-open-flags.html
- shard-hsw: [PASS][33] -> [SKIP][34] ([fdo#109271]) +1 similar issue
[33]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9247/shard-hsw6/igt@perf@invalid-open-flags.html
[34]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5117/shard-hsw1/igt@perf@invalid-open-flags.html
- shard-kbl: [PASS][35] -> [SKIP][36] ([fdo#109271] / [i915#1354])
[35]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9247/shard-kbl7/igt@perf@invalid-open-flags.html
[36]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5117/shard-kbl6/igt@perf@invalid-open-flags.html
#### Possible fixes ####
* igt@feature_discovery@psr2:
- shard-iclb: [SKIP][37] ([i915#658]) -> [PASS][38]
[37]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9247/shard-iclb4/igt@feature_discovery@psr2.html
[38]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5117/shard-iclb2/igt@feature_discovery@psr2.html
* igt@gem_exec_reloc@basic-many-active@rcs0:
- shard-hsw: [FAIL][39] ([i915#2389]) -> [PASS][40] +1 similar issue
[39]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9247/shard-hsw4/igt@gem_exec_reloc@basic-many-active@rcs0.html
[40]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5117/shard-hsw6/igt@gem_exec_reloc@basic-many-active@rcs0.html
- shard-snb: [FAIL][41] ([i915#2389]) -> [PASS][42]
[41]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9247/shard-snb7/igt@gem_exec_reloc@basic-many-active@rcs0.html
[42]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5117/shard-snb5/igt@gem_exec_reloc@basic-many-active@rcs0.html
* igt@gem_partial_pwrite_pread@writes-after-reads-uncached:
- shard-snb: [FAIL][43] -> [PASS][44]
[43]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9247/shard-snb7/igt@gem_partial_pwrite_pread@writes-after-reads-uncached.html
[44]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5117/shard-snb7/igt@gem_partial_pwrite_pread@writes-after-reads-uncached.html
* igt@gem_pipe_control_store_loop@fresh-buffer:
- shard-tglb: [INCOMPLETE][45] -> [PASS][46]
[45]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9247/shard-tglb1/igt@gem_pipe_control_store_loop@fresh-buffer.html
[46]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5117/shard-tglb3/igt@gem_pipe_control_store_loop@fresh-buffer.html
* igt@i915_pm_rc6_residency@rc6-idle:
- shard-hsw: [WARN][47] ([i915#1519]) -> [PASS][48]
[47]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9247/shard-hsw6/igt@i915_pm_rc6_residency@rc6-idle.html
[48]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5117/shard-hsw6/igt@i915_pm_rc6_residency@rc6-idle.html
* igt@i915_pm_rpm@pm-tiling:
- shard-hsw: [SKIP][49] ([fdo#109271]) -> [PASS][50] +2 similar issues
[49]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9247/shard-hsw6/igt@i915_pm_rpm@pm-tiling.html
[50]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5117/shard-hsw4/igt@i915_pm_rpm@pm-tiling.html
- shard-kbl: [SKIP][51] ([fdo#109271]) -> [PASS][52] +1 similar issue
[51]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9247/shard-kbl6/igt@i915_pm_rpm@pm-tiling.html
[52]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5117/shard-kbl1/igt@i915_pm_rpm@pm-tiling.html
- shard-apl: [SKIP][53] ([fdo#109271] / [i915#1635]) -> [PASS][54] +1 similar issue
[53]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9247/shard-apl6/igt@i915_pm_rpm@pm-tiling.html
[54]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5117/shard-apl3/igt@i915_pm_rpm@pm-tiling.html
- shard-glk: [SKIP][55] ([fdo#109271]) -> [PASS][56] +1 similar issue
[55]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9247/shard-glk4/igt@i915_pm_rpm@pm-tiling.html
[56]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5117/shard-glk8/igt@i915_pm_rpm@pm-tiling.html
- shard-iclb: [SKIP][57] ([i915#579]) -> [PASS][58]
[57]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9247/shard-iclb7/igt@i915_pm_rpm@pm-tiling.html
[58]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5117/shard-iclb2/igt@i915_pm_rpm@pm-tiling.html
* igt@kms_draw_crc@draw-method-xrgb8888-render-untiled:
- shard-glk: [DMESG-WARN][59] ([i915#1982]) -> [PASS][60] +6 similar issues
[59]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9247/shard-glk3/igt@kms_draw_crc@draw-method-xrgb8888-render-untiled.html
[60]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5117/shard-glk8/igt@kms_draw_crc@draw-method-xrgb8888-render-untiled.html
* igt@kms_draw_crc@draw-method-xrgb8888-render-xtiled:
- shard-snb: [FAIL][61] ([i915#54]) -> [PASS][62]
[61]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9247/shard-snb7/igt@kms_draw_crc@draw-method-xrgb8888-render-xtiled.html
[62]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5117/shard-snb6/igt@kms_draw_crc@draw-method-xrgb8888-render-xtiled.html
* igt@kms_flip@2x-flip-vs-expired-vblank@ab-hdmi-a1-hdmi-a2:
- shard-glk: [FAIL][63] ([i915#79]) -> [PASS][64]
[63]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9247/shard-glk2/igt@kms_flip@2x-flip-vs-expired-vblank@ab-hdmi-a1-hdmi-a2.html
[64]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5117/shard-glk5/igt@kms_flip@2x-flip-vs-expired-vblank@ab-hdmi-a1-hdmi-a2.html
* igt@kms_flip@2x-plain-flip-fb-recreate-interruptible@bc-hdmi-a1-hdmi-a2:
- shard-glk: [FAIL][65] ([i915#2122]) -> [PASS][66]
[65]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9247/shard-glk9/igt@kms_flip@2x-plain-flip-fb-recreate-interruptible@bc-hdmi-a1-hdmi-a2.html
[66]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5117/shard-glk9/igt@kms_flip@2x-plain-flip-fb-recreate-interruptible@bc-hdmi-a1-hdmi-a2.html
* igt@kms_flip@2x-plain-flip-fb-recreate@ab-vga1-hdmi-a1:
- shard-hsw: [DMESG-WARN][67] ([i915#1982]) -> [PASS][68]
[67]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9247/shard-hsw6/igt@kms_flip@2x-plain-flip-fb-recreate@ab-vga1-hdmi-a1.html
[68]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5117/shard-hsw4/igt@kms_flip@2x-plain-flip-fb-recreate@ab-vga1-hdmi-a1.html
* igt@kms_flip@dpms-vs-vblank-race@b-dp1:
- shard-kbl: [INCOMPLETE][69] -> [PASS][70]
[69]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9247/shard-kbl6/igt@kms_flip@dpms-vs-vblank-race@b-dp1.html
[70]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5117/shard-kbl6/igt@kms_flip@dpms-vs-vblank-race@b-dp1.html
* igt@kms_flip@flip-vs-suspend@c-hdmi-a1:
- shard-hsw: [INCOMPLETE][71] ([i915#2055]) -> [PASS][72]
[71]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9247/shard-hsw1/igt@kms_flip@flip-vs-suspend@c-hdmi-a1.html
[72]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5117/shard-hsw4/igt@kms_flip@flip-vs-suspend@c-hdmi-a1.html
* igt@kms_flip_tiling@flip-to-yf-tiled:
- shard-kbl: [DMESG-WARN][73] ([i915#1982]) -> [PASS][74] +3 similar issues
[73]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9247/shard-kbl4/igt@kms_flip_tiling@flip-to-yf-tiled.html
[74]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5117/shard-kbl2/igt@kms_flip_tiling@flip-to-yf-tiled.html
* igt@kms_frontbuffer_tracking@psr-rgb101010-draw-mmap-wc:
- shard-iclb: [DMESG-WARN][75] ([i915#1982]) -> [PASS][76] +1 similar issue
[75]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9247/shard-iclb3/igt@kms_frontbuffer_tracking@psr-rgb101010-draw-mmap-wc.html
[76]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5117/shard-iclb1/igt@kms_frontbuffer_tracking@psr-rgb101010-draw-mmap-wc.html
* igt@kms_plane@plane-panning-bottom-right-suspend-pipe-a-planes:
- shard-iclb: [INCOMPLETE][77] ([i915#1185] / [i915#250]) -> [PASS][78]
[77]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9247/shard-iclb3/igt@kms_plane@plane-panning-bottom-right-suspend-pipe-a-planes.html
[78]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5117/shard-iclb6/igt@kms_plane@plane-panning-bottom-right-suspend-pipe-a-planes.html
* igt@kms_psr@psr2_cursor_mmap_cpu:
- shard-iclb: [SKIP][79] ([fdo#109441]) -> [PASS][80] +1 similar issue
[79]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9247/shard-iclb6/igt@kms_psr@psr2_cursor_mmap_cpu.html
[80]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5117/shard-iclb2/igt@kms_psr@psr2_cursor_mmap_cpu.html
* igt@kms_psr@suspend:
- shard-iclb: [INCOMPLETE][81] ([i915#1185]) -> [PASS][82]
[81]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9247/shard-iclb7/igt@kms_psr@suspend.html
[82]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5117/shard-iclb4/igt@kms_psr@suspend.html
* igt@kms_vblank@pipe-b-wait-forked-busy-hang:
- shard-apl: [DMESG-WARN][83] ([i915#1635] / [i915#1982]) -> [PASS][84] +4 similar issues
[83]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9247/shard-apl1/igt@kms_vblank@pipe-b-wait-forked-busy-hang.html
[84]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5117/shard-apl7/igt@kms_vblank@pipe-b-wait-forked-busy-hang.html
* igt@kms_vblank@pipe-d-accuracy-idle:
- shard-tglb: [DMESG-WARN][85] ([i915#1982]) -> [PASS][86] +2 similar issues
[85]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9247/shard-tglb2/igt@kms_vblank@pipe-d-accuracy-idle.html
[86]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5117/shard-tglb8/igt@kms_vblank@pipe-d-accuracy-idle.html
* igt@perf@non-system-wide-paranoid:
- shard-apl: [SKIP][87] ([fdo#109271] / [i915#1354] / [i915#1635]) -> [PASS][88]
[87]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9247/shard-apl3/igt@perf@non-system-wide-paranoid.html
[88]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5117/shard-apl1/igt@perf@non-system-wide-paranoid.html
- shard-glk: [SKIP][89] ([fdo#109271] / [i915#1354]) -> [PASS][90]
[89]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9247/shard-glk1/igt@perf@non-system-wide-paranoid.html
[90]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5117/shard-glk3/igt@perf@non-system-wide-paranoid.html
- shard-iclb: [SKIP][91] ([i915#1354]) -> [PASS][92]
[91]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9247/shard-iclb7/igt@perf@non-system-wide-paranoid.html
[92]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5117/shard-iclb7/igt@perf@non-system-wide-paranoid.html
- shard-kbl: [SKIP][93] ([fdo#109271] / [i915#1354]) -> [PASS][94]
[93]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9247/shard-kbl7/igt@perf@non-system-wide-paranoid.html
[94]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5117/shard-kbl3/igt@perf@non-system-wide-paranoid.html
- shard-tglb: [SKIP][95] ([i915#1354]) -> [PASS][96]
[95]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9247/shard-tglb2/igt@perf@non-system-wide-paranoid.html
[96]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5117/shard-tglb6/igt@perf@non-system-wide-paranoid.html
#### Warnings ####
* igt@i915_pm_backlight@fade_with_suspend:
- shard-tglb: [INCOMPLETE][97] ([i915#1436] / [i915#456]) -> [DMESG-WARN][98] ([i915#2411])
[97]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9247/shard-tglb2/igt@i915_pm_backlight@fade_with_suspend.html
[98]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5117/shard-tglb2/igt@i915_pm_backlight@fade_with_suspend.html
* igt@i915_pm_dc@dc3co-vpb-simulation:
- shard-iclb: [SKIP][99] ([i915#658]) -> [SKIP][100] ([i915#588])
[99]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9247/shard-iclb8/igt@i915_pm_dc@dc3co-vpb-simulation.html
[100]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5117/shard-iclb2/igt@i915_pm_dc@dc3co-vpb-simulation.html
* igt@i915_pm_rpm@dpms-mode-unset-non-lpsp:
- shard-iclb: [SKIP][101] ([i915#579]) -> [SKIP][102] ([fdo#110892])
[101]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9247/shard-iclb7/igt@i915_pm_rpm@dpms-mode-unset-non-lpsp.html
[102]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5117/shard-iclb6/igt@i915_pm_rpm@dpms-mode-unset-non-lpsp.html
* igt@i915_pm_rpm@pm-tiling:
- shard-tglb: [SKIP][103] ([i915#579]) -> [DMESG-WARN][104] ([i915#2411])
[103]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9247/shard-tglb3/igt@i915_pm_rpm@pm-tiling.html
[104]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5117/shard-tglb7/igt@i915_pm_rpm@pm-tiling.html
* igt@kms_plane_alpha_blend@pipe-a-alpha-7efc:
- shard-apl: [DMESG-FAIL][105] ([fdo#108145] / [i915#1635] / [i915#1982]) -> [FAIL][106] ([fdo#108145] / [i915#1635] / [i915#265])
[105]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9247/shard-apl7/igt@kms_plane_alpha_blend@pipe-a-alpha-7efc.html
[106]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5117/shard-apl2/igt@kms_plane_alpha_blend@pipe-a-alpha-7efc.html
* igt@perf@per-context-mode-unprivileged:
- shard-apl: [SKIP][107] ([fdo#109271] / [i915#1635]) -> [SKIP][108] ([fdo#109271] / [i915#1354] / [i915#1635])
[107]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9247/shard-apl7/igt@perf@per-context-mode-unprivileged.html
[108]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5117/shard-apl1/igt@perf@per-context-mode-unprivileged.html
- shard-iclb: [SKIP][109] ([fdo#109289]) -> [SKIP][110] ([i915#1354])
[109]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9247/shard-iclb1/igt@perf@per-context-mode-unprivileged.html
[110]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5117/shard-iclb7/igt@perf@per-context-mode-unprivileged.html
- shard-glk: [SKIP][111] ([fdo#109271]) -> [SKIP][112] ([fdo#109271] / [i915#1354])
[111]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9247/shard-glk1/igt@perf@per-context-mode-unprivileged.html
[112]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5117/shard-glk7/igt@perf@per-context-mode-unprivileged.html
- shard-kbl: [SKIP][113] ([fdo#109271]) -> [SKIP][114] ([fdo#109271] / [i915#1354])
[113]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9247/shard-kbl3/igt@perf@per-context-mode-unprivileged.html
[114]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5117/shard-kbl4/igt@perf@per-context-mode-unprivileged.html
- shard-tglb: [SKIP][115] ([fdo#109289]) -> [SKIP][116] ([i915#1354])
[115]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9247/shard-tglb1/igt@perf@per-context-mode-unprivileged.html
[116]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5117/shard-tglb5/igt@perf@per-context-mode-unprivileged.html
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[fdo#108145]: https://bugs.freedesktop.org/show_bug.cgi?id=108145
[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[fdo#109289]: https://bugs.freedesktop.org/show_bug.cgi?id=109289
[fdo#109441]: https://bugs.freedesktop.org/show_bug.cgi?id=109441
[fdo#110892]: https://bugs.freedesktop.org/show_bug.cgi?id=110892
[i915#118]: https://gitlab.freedesktop.org/drm/intel/issues/118
[i915#1185]: https://gitlab.freedesktop.org/drm/intel/issues/1185
[i915#1354]: https://gitlab.freedesktop.org/drm/intel/issues/1354
[i915#1436]: https://gitlab.freedesktop.org/drm/intel/issues/1436
[i915#1519]: https://gitlab.freedesktop.org/drm/intel/issues/1519
[i915#1635]: https://gitlab.freedesktop.org/drm/intel/issues/1635
[i915#1888]: https://gitlab.freedesktop.org/drm/intel/issues/1888
[i915#1982]: https://gitlab.freedesktop.org/drm/intel/issues/1982
[i915#2055]: https://gitlab.freedesktop.org/drm/intel/issues/2055
[i915#2122]: https://gitlab.freedesktop.org/drm/intel/issues/2122
[i915#2244]: https://gitlab.freedesktop.org/drm/intel/issues/2244
[i915#2389]: https://gitlab.freedesktop.org/drm/intel/issues/2389
[i915#2411]: https://gitlab.freedesktop.org/drm/intel/issues/2411
[i915#250]: https://gitlab.freedesktop.org/drm/intel/issues/250
[i915#2521]: https://gitlab.freedesktop.org/drm/intel/issues/2521
[i915#265]: https://gitlab.freedesktop.org/drm/intel/issues/265
[i915#456]: https://gitlab.freedesktop.org/drm/intel/issues/456
[i915#49]: https://gitlab.freedesktop.org/drm/intel/issues/49
[i915#54]: https://gitlab.freedesktop.org/drm/intel/issues/54
[i915#579]: https://gitlab.freedesktop.org/drm/intel/issues/579
[i915#588]: https://gitlab.freedesktop.org/drm/intel/issues/588
[i915#658]: https://gitlab.freedesktop.org/drm/intel/issues/658
[i915#79]: https://gitlab.freedesktop.org/drm/intel/issues/79
[i915#82]: https://gitlab.freedesktop.org/drm/intel/issues/82
[i915#95]: https://gitlab.freedesktop.org/drm/intel/issues/95
Participating hosts (11 -> 8)
------------------------------
Missing (3): pig-skl-6260u pig-glk-j5005 pig-icl-1065g7
Build changes
-------------
* CI: CI-20190529 -> None
* IGT: IGT_5830 -> IGTPW_5117
* Piglit: piglit_4509 -> None
CI-20190529: 20190529
CI_DRM_9247: 009a99e9be393d32ed57bcac34d6b1fb37c28cdf @ git://anongit.freedesktop.org/gfx-ci/linux
IGTPW_5117: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5117/index.html
IGT_5830: 12d370cb57e0cfcb781c87ad9e15e68b17a1f41f @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5117/index.html
[-- Attachment #1.2: Type: text/html, Size: 29485 bytes --]
[-- Attachment #2: Type: text/plain, Size: 154 bytes --]
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [igt-dev] [PATCH i-g-t] i915/perf: Make sure i915 is loaded before reading proc
2020-11-02 19:49 [igt-dev] [PATCH i-g-t] i915/perf: Make sure i915 is loaded before reading proc Umesh Nerlige Ramappa
2020-11-02 20:37 ` [igt-dev] ✓ Fi.CI.BAT: success for i915/perf: Make sure i915 is loaded before reading proc (rev3) Patchwork
2020-11-03 3:58 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork
@ 2020-11-03 8:06 ` Petri Latvala
2020-11-04 0:15 ` Umesh Nerlige Ramappa
2 siblings, 1 reply; 12+ messages in thread
From: Petri Latvala @ 2020-11-03 8:06 UTC (permalink / raw)
To: Umesh Nerlige Ramappa; +Cc: igt-dev
On Mon, Nov 02, 2020 at 11:49:57AM -0800, Umesh Nerlige Ramappa wrote:
> The previous test may have unloaded i915 or failed to load it back. To
> combat such cases, each test fixture is supposed to ensure that i915 is
> loaded prior to running the subtests. In most fixtures this happens
> automatically when we try to get a handle to i915. In perf OA, we stat
> some proc/sys files even before getting a handle to i915. Occassionally,
> perf tests fail trying to stat these files. Fix perf OA by checking and
> loading i915 if it's not loaded.
>
> v2: Use drm_load_module() (Petri)
>
> Closes: https://gitlab.freedesktop.org/drm/intel/-/issues/405
> Signed-off-by: Umesh Nerlige Ramappa <umesh.nerlige.ramappa@intel.com>
> Reviewed-by: Petri Latvala <petri.latvala@intel.com>
> Reviewed-by: Ashutosh Dixit <ashutosh.dixit@intel.com>
> ---
Excellent, thanks. I would slap an R-b here but it's already in :P
--
Petri Latvala
> tests/i915/perf.c | 7 +++++++
> 1 file changed, 7 insertions(+)
>
> diff --git a/tests/i915/perf.c b/tests/i915/perf.c
> index a5c4adc3..caeabd62 100644
> --- a/tests/i915/perf.c
> +++ b/tests/i915/perf.c
> @@ -4806,6 +4806,13 @@ igt_main
> igt_fixture {
> struct stat sb;
>
> + /*
> + * Prior tests may have unloaded i915 or failed while
> + * loading/unloading i915. Load i915 here before we stat the
> + * files.
> + */
> + drm_load_module(DRIVER_INTEL);
> +
> igt_require(stat("/proc/sys/dev/i915/perf_stream_paranoid", &sb)
> == 0);
> igt_require(stat("/proc/sys/dev/i915/oa_max_sample_rate", &sb)
> --
> 2.20.1
>
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [igt-dev] [PATCH i-g-t] i915/perf: Make sure i915 is loaded before reading proc
2020-11-03 8:06 ` [igt-dev] [PATCH i-g-t] i915/perf: Make sure i915 is loaded before reading proc Petri Latvala
@ 2020-11-04 0:15 ` Umesh Nerlige Ramappa
2020-11-04 10:35 ` Petri Latvala
0 siblings, 1 reply; 12+ messages in thread
From: Umesh Nerlige Ramappa @ 2020-11-04 0:15 UTC (permalink / raw)
To: Petri Latvala; +Cc: igt-dev
On Tue, Nov 03, 2020 at 10:06:44AM +0200, Petri Latvala wrote:
>On Mon, Nov 02, 2020 at 11:49:57AM -0800, Umesh Nerlige Ramappa wrote:
>> The previous test may have unloaded i915 or failed to load it back. To
>> combat such cases, each test fixture is supposed to ensure that i915 is
>> loaded prior to running the subtests. In most fixtures this happens
>> automatically when we try to get a handle to i915. In perf OA, we stat
>> some proc/sys files even before getting a handle to i915. Occassionally,
>> perf tests fail trying to stat these files. Fix perf OA by checking and
>> loading i915 if it's not loaded.
>>
>> v2: Use drm_load_module() (Petri)
>>
>> Closes: https://gitlab.freedesktop.org/drm/intel/-/issues/405
>> Signed-off-by: Umesh Nerlige Ramappa <umesh.nerlige.ramappa@intel.com>
>> Reviewed-by: Petri Latvala <petri.latvala@intel.com>
>> Reviewed-by: Ashutosh Dixit <ashutosh.dixit@intel.com>
>> ---
>
>
>Excellent, thanks. I would slap an R-b here but it's already in :P
>
Thanks Petri, Would you please also help me merge this? I don't have
permissions.
Thanks,
Umesh
>
>--
>Petri Latvala
>
>
>
>> tests/i915/perf.c | 7 +++++++
>> 1 file changed, 7 insertions(+)
>>
>> diff --git a/tests/i915/perf.c b/tests/i915/perf.c
>> index a5c4adc3..caeabd62 100644
>> --- a/tests/i915/perf.c
>> +++ b/tests/i915/perf.c
>> @@ -4806,6 +4806,13 @@ igt_main
>> igt_fixture {
>> struct stat sb;
>>
>> + /*
>> + * Prior tests may have unloaded i915 or failed while
>> + * loading/unloading i915. Load i915 here before we stat the
>> + * files.
>> + */
>> + drm_load_module(DRIVER_INTEL);
>> +
>> igt_require(stat("/proc/sys/dev/i915/perf_stream_paranoid", &sb)
>> == 0);
>> igt_require(stat("/proc/sys/dev/i915/oa_max_sample_rate", &sb)
>> --
>> 2.20.1
>>
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [igt-dev] [PATCH i-g-t] i915/perf: Make sure i915 is loaded before reading proc
2020-11-04 0:15 ` Umesh Nerlige Ramappa
@ 2020-11-04 10:35 ` Petri Latvala
0 siblings, 0 replies; 12+ messages in thread
From: Petri Latvala @ 2020-11-04 10:35 UTC (permalink / raw)
To: Umesh Nerlige Ramappa; +Cc: igt-dev
On Tue, Nov 03, 2020 at 04:15:42PM -0800, Umesh Nerlige Ramappa wrote:
> On Tue, Nov 03, 2020 at 10:06:44AM +0200, Petri Latvala wrote:
> > On Mon, Nov 02, 2020 at 11:49:57AM -0800, Umesh Nerlige Ramappa wrote:
> > > The previous test may have unloaded i915 or failed to load it back. To
> > > combat such cases, each test fixture is supposed to ensure that i915 is
> > > loaded prior to running the subtests. In most fixtures this happens
> > > automatically when we try to get a handle to i915. In perf OA, we stat
> > > some proc/sys files even before getting a handle to i915. Occassionally,
> > > perf tests fail trying to stat these files. Fix perf OA by checking and
> > > loading i915 if it's not loaded.
> > >
> > > v2: Use drm_load_module() (Petri)
> > >
> > > Closes: https://gitlab.freedesktop.org/drm/intel/-/issues/405
> > > Signed-off-by: Umesh Nerlige Ramappa <umesh.nerlige.ramappa@intel.com>
> > > Reviewed-by: Petri Latvala <petri.latvala@intel.com>
> > > Reviewed-by: Ashutosh Dixit <ashutosh.dixit@intel.com>
> > > ---
> >
> >
> > Excellent, thanks. I would slap an R-b here but it's already in :P
> >
> Thanks Petri, Would you please also help me merge this? I don't have
> permissions.
Merged now.
--
Petri Latvala
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [igt-dev] [PATCH i-g-t] i915/perf: Make sure i915 is loaded before reading proc
2020-10-30 22:55 Umesh Nerlige Ramappa
2020-10-30 23:06 ` Dixit, Ashutosh
@ 2020-11-02 9:48 ` Petri Latvala
1 sibling, 0 replies; 12+ messages in thread
From: Petri Latvala @ 2020-11-02 9:48 UTC (permalink / raw)
To: Umesh Nerlige Ramappa; +Cc: igt-dev
On Fri, Oct 30, 2020 at 03:55:48PM -0700, Umesh Nerlige Ramappa wrote:
> The previous test may have unloaded i915 or failed to load it back. To
> combat such cases, each test fixture is supposed to ensure that i915 is
> loaded prior to running the subtests. In most fixtures this happens
> automatically when we try to get a handle to i915. In perf OA, we stat
> some proc/sys files even before getting a handle to i915. Occassionally,
> perf tests fail trying to stat these files. Fix perf OA by checking and
> loading i915 if it's not loaded.
>
> v2: Remove the if check (Ashutosh)
>
> Closes: https://gitlab.freedesktop.org/drm/intel/-/issues/405
> Signed-off-by: Umesh Nerlige Ramappa <umesh.nerlige.ramappa@intel.com>
> Reviewed-by: Petri Latvala <petri.latvala@intel.com>
> Reviewed-by: Ashutosh Dixit <ashutosh.dixit@intel.com>
> ---
> tests/i915/perf.c | 8 ++++++++
> 1 file changed, 8 insertions(+)
>
> diff --git a/tests/i915/perf.c b/tests/i915/perf.c
> index a5c4adc3..bd8281bd 100644
> --- a/tests/i915/perf.c
> +++ b/tests/i915/perf.c
> @@ -41,6 +41,7 @@
> #include "i915/gem.h"
> #include "i915/perf.h"
> #include "igt.h"
> +#include "igt_kmod.h"
> #include "igt_sysfs.h"
> #include "drm.h"
>
> @@ -4806,6 +4807,13 @@ igt_main
> igt_fixture {
> struct stat sb;
>
> + /*
> + * Prior tests may have unloaded i915 or failed while
> + * loading/unloading i915. Load i915 here before we stat the
> + * files.
> + */
> + igt_i915_driver_load(NULL);
> +
Please use drm_load_module() instead, Chris's patch for exporting that
is now merged.
--
Petri Latvala
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [igt-dev] [PATCH i-g-t] i915/perf: Make sure i915 is loaded before reading proc
2020-10-30 22:55 Umesh Nerlige Ramappa
@ 2020-10-30 23:06 ` Dixit, Ashutosh
2020-11-02 9:48 ` Petri Latvala
1 sibling, 0 replies; 12+ messages in thread
From: Dixit, Ashutosh @ 2020-10-30 23:06 UTC (permalink / raw)
To: Umesh Nerlige Ramappa; +Cc: igt-dev, Petri Latvala
On Fri, 30 Oct 2020 15:55:48 -0700, Umesh Nerlige Ramappa wrote:
> @@ -4806,6 +4807,13 @@ igt_main
> igt_fixture {
> struct stat sb;
>
> + /*
> + * Prior tests may have unloaded i915 or failed while
> + * loading/unloading i915. Load i915 here before we stat the
> + * files.
> + */
> + igt_i915_driver_load(NULL);
> +
I was thinking that the original if () was also ok because there will be an
additional igt_debug() if the module is already loaded and the if will
avoid that. Anyway you decide what to do, either way:
Reviewed-by: Ashutosh Dixit <ashutosh.dixit@intel.com>
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply [flat|nested] 12+ messages in thread
* [igt-dev] [PATCH i-g-t] i915/perf: Make sure i915 is loaded before reading proc
@ 2020-10-30 22:55 Umesh Nerlige Ramappa
2020-10-30 23:06 ` Dixit, Ashutosh
2020-11-02 9:48 ` Petri Latvala
0 siblings, 2 replies; 12+ messages in thread
From: Umesh Nerlige Ramappa @ 2020-10-30 22:55 UTC (permalink / raw)
To: igt-dev; +Cc: Petri Latvala
The previous test may have unloaded i915 or failed to load it back. To
combat such cases, each test fixture is supposed to ensure that i915 is
loaded prior to running the subtests. In most fixtures this happens
automatically when we try to get a handle to i915. In perf OA, we stat
some proc/sys files even before getting a handle to i915. Occassionally,
perf tests fail trying to stat these files. Fix perf OA by checking and
loading i915 if it's not loaded.
v2: Remove the if check (Ashutosh)
Closes: https://gitlab.freedesktop.org/drm/intel/-/issues/405
Signed-off-by: Umesh Nerlige Ramappa <umesh.nerlige.ramappa@intel.com>
Reviewed-by: Petri Latvala <petri.latvala@intel.com>
Reviewed-by: Ashutosh Dixit <ashutosh.dixit@intel.com>
---
tests/i915/perf.c | 8 ++++++++
1 file changed, 8 insertions(+)
diff --git a/tests/i915/perf.c b/tests/i915/perf.c
index a5c4adc3..bd8281bd 100644
--- a/tests/i915/perf.c
+++ b/tests/i915/perf.c
@@ -41,6 +41,7 @@
#include "i915/gem.h"
#include "i915/perf.h"
#include "igt.h"
+#include "igt_kmod.h"
#include "igt_sysfs.h"
#include "drm.h"
@@ -4806,6 +4807,13 @@ igt_main
igt_fixture {
struct stat sb;
+ /*
+ * Prior tests may have unloaded i915 or failed while
+ * loading/unloading i915. Load i915 here before we stat the
+ * files.
+ */
+ igt_i915_driver_load(NULL);
+
igt_require(stat("/proc/sys/dev/i915/perf_stream_paranoid", &sb)
== 0);
igt_require(stat("/proc/sys/dev/i915/oa_max_sample_rate", &sb)
--
2.20.1
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply related [flat|nested] 12+ messages in thread
* Re: [igt-dev] [PATCH i-g-t] i915/perf: Make sure i915 is loaded before reading proc
2020-10-30 10:16 ` Petri Latvala
@ 2020-10-30 22:39 ` Umesh Nerlige Ramappa
0 siblings, 0 replies; 12+ messages in thread
From: Umesh Nerlige Ramappa @ 2020-10-30 22:39 UTC (permalink / raw)
To: Petri Latvala; +Cc: igt-dev
On Fri, Oct 30, 2020 at 12:16:03PM +0200, Petri Latvala wrote:
>On Thu, Oct 29, 2020 at 05:39:11PM -0700, Umesh Nerlige Ramappa wrote:
>> The previous test may have unloaded i915 or failed to load it back. To
>> combat such cases, each test fixture is supposed to ensure that i915 is
>> loaded prior to running the subtests. In most fixtures this happens
>> automatically when we try to get a handle to i915. In perf OA, we stat
>> some proc/sys files even before getting a handle to i915. Occassionally,
>> perf tests fail trying to stat these files. Fix perf OA by checking and
>> loading i915 if it's not loaded.
>>
>> Closes: https://gitlab.freedesktop.org/drm/intel/-/issues/405
>> Signed-off-by: Umesh Nerlige Ramappa <umesh.nerlige.ramappa@intel.com>
>> ---
>
>I had a patch also fixing this back in August but I guess I didn't CC
>the correct people (in fact CCd none).
>
>https://patchwork.freedesktop.org/series/80805/
>
>Same comment as for that other patch by Chris, we might want to
>generalize this by exporting __try_modprobe to be callable from tests.
Thanks Petri,
Ashutosh suggested that there is no need to check igt_kmod_is_loaded.
That happens within igt_i915_driver_load. I will remove the if and post
v2.
Thanks,
Umesh
>
>Anyway,
>Reviewed-by: Petri Latvala <petri.latvala@intel.com>
>
>
>
>
>> tests/i915/perf.c | 9 +++++++++
>> 1 file changed, 9 insertions(+)
>>
>> diff --git a/tests/i915/perf.c b/tests/i915/perf.c
>> index a5c4adc3..a5bd63c2 100644
>> --- a/tests/i915/perf.c
>> +++ b/tests/i915/perf.c
>> @@ -41,6 +41,7 @@
>> #include "i915/gem.h"
>> #include "i915/perf.h"
>> #include "igt.h"
>> +#include "igt_kmod.h"
>> #include "igt_sysfs.h"
>> #include "drm.h"
>>
>> @@ -4806,6 +4807,14 @@ igt_main
>> igt_fixture {
>> struct stat sb;
>>
>> + /*
>> + * Prior tests may have unloaded i915 or failed while
>> + * loading/unloading i915. Load i915 here before we stat the
>> + * files.
>> + */
>> + if (!igt_kmod_is_loaded("i915"))
>> + igt_assert(!igt_i915_driver_load(NULL));
>> +
>> igt_require(stat("/proc/sys/dev/i915/perf_stream_paranoid", &sb)
>> == 0);
>> igt_require(stat("/proc/sys/dev/i915/oa_max_sample_rate", &sb)
>> --
>> 2.20.1
>>
>> _______________________________________________
>> igt-dev mailing list
>> igt-dev@lists.freedesktop.org
>> https://lists.freedesktop.org/mailman/listinfo/igt-dev
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [igt-dev] [PATCH i-g-t] i915/perf: Make sure i915 is loaded before reading proc
2020-10-30 0:39 Umesh Nerlige Ramappa
@ 2020-10-30 10:16 ` Petri Latvala
2020-10-30 22:39 ` Umesh Nerlige Ramappa
0 siblings, 1 reply; 12+ messages in thread
From: Petri Latvala @ 2020-10-30 10:16 UTC (permalink / raw)
To: Umesh Nerlige Ramappa; +Cc: igt-dev
On Thu, Oct 29, 2020 at 05:39:11PM -0700, Umesh Nerlige Ramappa wrote:
> The previous test may have unloaded i915 or failed to load it back. To
> combat such cases, each test fixture is supposed to ensure that i915 is
> loaded prior to running the subtests. In most fixtures this happens
> automatically when we try to get a handle to i915. In perf OA, we stat
> some proc/sys files even before getting a handle to i915. Occassionally,
> perf tests fail trying to stat these files. Fix perf OA by checking and
> loading i915 if it's not loaded.
>
> Closes: https://gitlab.freedesktop.org/drm/intel/-/issues/405
> Signed-off-by: Umesh Nerlige Ramappa <umesh.nerlige.ramappa@intel.com>
> ---
I had a patch also fixing this back in August but I guess I didn't CC
the correct people (in fact CCd none).
https://patchwork.freedesktop.org/series/80805/
Same comment as for that other patch by Chris, we might want to
generalize this by exporting __try_modprobe to be callable from tests.
Anyway,
Reviewed-by: Petri Latvala <petri.latvala@intel.com>
> tests/i915/perf.c | 9 +++++++++
> 1 file changed, 9 insertions(+)
>
> diff --git a/tests/i915/perf.c b/tests/i915/perf.c
> index a5c4adc3..a5bd63c2 100644
> --- a/tests/i915/perf.c
> +++ b/tests/i915/perf.c
> @@ -41,6 +41,7 @@
> #include "i915/gem.h"
> #include "i915/perf.h"
> #include "igt.h"
> +#include "igt_kmod.h"
> #include "igt_sysfs.h"
> #include "drm.h"
>
> @@ -4806,6 +4807,14 @@ igt_main
> igt_fixture {
> struct stat sb;
>
> + /*
> + * Prior tests may have unloaded i915 or failed while
> + * loading/unloading i915. Load i915 here before we stat the
> + * files.
> + */
> + if (!igt_kmod_is_loaded("i915"))
> + igt_assert(!igt_i915_driver_load(NULL));
> +
> igt_require(stat("/proc/sys/dev/i915/perf_stream_paranoid", &sb)
> == 0);
> igt_require(stat("/proc/sys/dev/i915/oa_max_sample_rate", &sb)
> --
> 2.20.1
>
> _______________________________________________
> igt-dev mailing list
> igt-dev@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/igt-dev
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply [flat|nested] 12+ messages in thread
* [igt-dev] [PATCH i-g-t] i915/perf: Make sure i915 is loaded before reading proc
@ 2020-10-30 0:39 Umesh Nerlige Ramappa
2020-10-30 10:16 ` Petri Latvala
0 siblings, 1 reply; 12+ messages in thread
From: Umesh Nerlige Ramappa @ 2020-10-30 0:39 UTC (permalink / raw)
To: igt-dev
The previous test may have unloaded i915 or failed to load it back. To
combat such cases, each test fixture is supposed to ensure that i915 is
loaded prior to running the subtests. In most fixtures this happens
automatically when we try to get a handle to i915. In perf OA, we stat
some proc/sys files even before getting a handle to i915. Occassionally,
perf tests fail trying to stat these files. Fix perf OA by checking and
loading i915 if it's not loaded.
Closes: https://gitlab.freedesktop.org/drm/intel/-/issues/405
Signed-off-by: Umesh Nerlige Ramappa <umesh.nerlige.ramappa@intel.com>
---
tests/i915/perf.c | 9 +++++++++
1 file changed, 9 insertions(+)
diff --git a/tests/i915/perf.c b/tests/i915/perf.c
index a5c4adc3..a5bd63c2 100644
--- a/tests/i915/perf.c
+++ b/tests/i915/perf.c
@@ -41,6 +41,7 @@
#include "i915/gem.h"
#include "i915/perf.h"
#include "igt.h"
+#include "igt_kmod.h"
#include "igt_sysfs.h"
#include "drm.h"
@@ -4806,6 +4807,14 @@ igt_main
igt_fixture {
struct stat sb;
+ /*
+ * Prior tests may have unloaded i915 or failed while
+ * loading/unloading i915. Load i915 here before we stat the
+ * files.
+ */
+ if (!igt_kmod_is_loaded("i915"))
+ igt_assert(!igt_i915_driver_load(NULL));
+
igt_require(stat("/proc/sys/dev/i915/perf_stream_paranoid", &sb)
== 0);
igt_require(stat("/proc/sys/dev/i915/oa_max_sample_rate", &sb)
--
2.20.1
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply related [flat|nested] 12+ messages in thread
end of thread, other threads:[~2020-11-04 10:35 UTC | newest]
Thread overview: 12+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-11-02 19:49 [igt-dev] [PATCH i-g-t] i915/perf: Make sure i915 is loaded before reading proc Umesh Nerlige Ramappa
2020-11-02 20:37 ` [igt-dev] ✓ Fi.CI.BAT: success for i915/perf: Make sure i915 is loaded before reading proc (rev3) Patchwork
2020-11-03 3:58 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork
2020-11-03 8:06 ` [igt-dev] [PATCH i-g-t] i915/perf: Make sure i915 is loaded before reading proc Petri Latvala
2020-11-04 0:15 ` Umesh Nerlige Ramappa
2020-11-04 10:35 ` Petri Latvala
-- strict thread matches above, loose matches on Subject: below --
2020-10-30 22:55 Umesh Nerlige Ramappa
2020-10-30 23:06 ` Dixit, Ashutosh
2020-11-02 9:48 ` Petri Latvala
2020-10-30 0:39 Umesh Nerlige Ramappa
2020-10-30 10:16 ` Petri Latvala
2020-10-30 22:39 ` Umesh Nerlige Ramappa
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.