From: Sasha Levin <sashal@kernel.org>
To: linux-kernel@vger.kernel.org, stable@vger.kernel.org
Cc: Qian Cai <cai@redhat.com>,
"Paul E . McKenney" <paulmck@kernel.org>,
Will Deacon <will@kernel.org>, Sasha Levin <sashal@kernel.org>,
linux-arm-kernel@lists.infradead.org
Subject: [PATCH AUTOSEL 5.8 29/29] arm64/smp: Move rcu_cpu_starting() earlier
Date: Mon, 2 Nov 2020 20:19:28 -0500 [thread overview]
Message-ID: <20201103011928.183145-29-sashal@kernel.org> (raw)
In-Reply-To: <20201103011928.183145-1-sashal@kernel.org>
From: Qian Cai <cai@redhat.com>
[ Upstream commit ce3d31ad3cac765484463b4f5a0b6b1f8f1a963e ]
The call to rcu_cpu_starting() in secondary_start_kernel() is not early
enough in the CPU-hotplug onlining process, which results in lockdep
splats as follows:
WARNING: suspicious RCU usage
-----------------------------
kernel/locking/lockdep.c:3497 RCU-list traversed in non-reader section!!
other info that might help us debug this:
RCU used illegally from offline CPU!
rcu_scheduler_active = 1, debug_locks = 1
no locks held by swapper/1/0.
Call trace:
dump_backtrace+0x0/0x3c8
show_stack+0x14/0x60
dump_stack+0x14c/0x1c4
lockdep_rcu_suspicious+0x134/0x14c
__lock_acquire+0x1c30/0x2600
lock_acquire+0x274/0xc48
_raw_spin_lock+0xc8/0x140
vprintk_emit+0x90/0x3d0
vprintk_default+0x34/0x40
vprintk_func+0x378/0x590
printk+0xa8/0xd4
__cpuinfo_store_cpu+0x71c/0x868
cpuinfo_store_cpu+0x2c/0xc8
secondary_start_kernel+0x244/0x318
This is avoided by moving the call to rcu_cpu_starting up near the
beginning of the secondary_start_kernel() function.
Signed-off-by: Qian Cai <cai@redhat.com>
Acked-by: Paul E. McKenney <paulmck@kernel.org>
Link: https://lore.kernel.org/lkml/160223032121.7002.1269740091547117869.tip-bot2@tip-bot2/
Link: https://lore.kernel.org/r/20201028182614.13655-1-cai@redhat.com
Signed-off-by: Will Deacon <will@kernel.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
---
arch/arm64/kernel/smp.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/arch/arm64/kernel/smp.c b/arch/arm64/kernel/smp.c
index 8cd6316a0d833..3e0fd4e6bcdcb 100644
--- a/arch/arm64/kernel/smp.c
+++ b/arch/arm64/kernel/smp.c
@@ -214,6 +214,7 @@ asmlinkage notrace void secondary_start_kernel(void)
if (system_uses_irq_prio_masking())
init_gic_priority_masking();
+ rcu_cpu_starting(cpu);
preempt_disable();
trace_hardirqs_off();
--
2.27.0
WARNING: multiple messages have this Message-ID (diff)
From: Sasha Levin <sashal@kernel.org>
To: linux-kernel@vger.kernel.org, stable@vger.kernel.org
Cc: Qian Cai <cai@redhat.com>, Sasha Levin <sashal@kernel.org>,
Will Deacon <will@kernel.org>,
linux-arm-kernel@lists.infradead.org,
"Paul E . McKenney" <paulmck@kernel.org>
Subject: [PATCH AUTOSEL 5.8 29/29] arm64/smp: Move rcu_cpu_starting() earlier
Date: Mon, 2 Nov 2020 20:19:28 -0500 [thread overview]
Message-ID: <20201103011928.183145-29-sashal@kernel.org> (raw)
In-Reply-To: <20201103011928.183145-1-sashal@kernel.org>
From: Qian Cai <cai@redhat.com>
[ Upstream commit ce3d31ad3cac765484463b4f5a0b6b1f8f1a963e ]
The call to rcu_cpu_starting() in secondary_start_kernel() is not early
enough in the CPU-hotplug onlining process, which results in lockdep
splats as follows:
WARNING: suspicious RCU usage
-----------------------------
kernel/locking/lockdep.c:3497 RCU-list traversed in non-reader section!!
other info that might help us debug this:
RCU used illegally from offline CPU!
rcu_scheduler_active = 1, debug_locks = 1
no locks held by swapper/1/0.
Call trace:
dump_backtrace+0x0/0x3c8
show_stack+0x14/0x60
dump_stack+0x14c/0x1c4
lockdep_rcu_suspicious+0x134/0x14c
__lock_acquire+0x1c30/0x2600
lock_acquire+0x274/0xc48
_raw_spin_lock+0xc8/0x140
vprintk_emit+0x90/0x3d0
vprintk_default+0x34/0x40
vprintk_func+0x378/0x590
printk+0xa8/0xd4
__cpuinfo_store_cpu+0x71c/0x868
cpuinfo_store_cpu+0x2c/0xc8
secondary_start_kernel+0x244/0x318
This is avoided by moving the call to rcu_cpu_starting up near the
beginning of the secondary_start_kernel() function.
Signed-off-by: Qian Cai <cai@redhat.com>
Acked-by: Paul E. McKenney <paulmck@kernel.org>
Link: https://lore.kernel.org/lkml/160223032121.7002.1269740091547117869.tip-bot2@tip-bot2/
Link: https://lore.kernel.org/r/20201028182614.13655-1-cai@redhat.com
Signed-off-by: Will Deacon <will@kernel.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
---
arch/arm64/kernel/smp.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/arch/arm64/kernel/smp.c b/arch/arm64/kernel/smp.c
index 8cd6316a0d833..3e0fd4e6bcdcb 100644
--- a/arch/arm64/kernel/smp.c
+++ b/arch/arm64/kernel/smp.c
@@ -214,6 +214,7 @@ asmlinkage notrace void secondary_start_kernel(void)
if (system_uses_irq_prio_masking())
init_gic_priority_masking();
+ rcu_cpu_starting(cpu);
preempt_disable();
trace_hardirqs_off();
--
2.27.0
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2020-11-03 1:24 UTC|newest]
Thread overview: 58+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-03 1:19 [PATCH AUTOSEL 5.8 01/29] ARM: dts: sun4i-a10: fix cpu_alert temperature Sasha Levin
2020-11-03 1:19 ` Sasha Levin
2020-11-03 1:19 ` [PATCH AUTOSEL 5.8 02/29] arm64: dts: meson-axg: add USB nodes Sasha Levin
2020-11-03 1:19 ` Sasha Levin
2020-11-03 1:19 ` Sasha Levin
2020-11-03 1:19 ` [PATCH AUTOSEL 5.8 03/29] arm64: dts: meson-axg-s400: enable USB OTG Sasha Levin
2020-11-03 1:19 ` Sasha Levin
2020-11-03 1:19 ` Sasha Levin
2020-11-03 1:19 ` [PATCH AUTOSEL 5.8 04/29] arm64: dts: meson: add missing g12 rng clock Sasha Levin
2020-11-03 1:19 ` Sasha Levin
2020-11-03 1:19 ` Sasha Levin
2020-11-03 1:19 ` [PATCH AUTOSEL 5.8 05/29] arm64: dts: amlogic: meson-g12: use the G12A specific dwmac compatible Sasha Levin
2020-11-03 1:19 ` Sasha Levin
2020-11-03 1:19 ` Sasha Levin
2020-11-03 1:19 ` [PATCH AUTOSEL 5.8 06/29] x86/kexec: Use up-to-dated screen_info copy to fill boot params Sasha Levin
2020-11-03 1:19 ` [PATCH AUTOSEL 5.8 07/29] hyperv_fb: Update screen_info after removing old framebuffer Sasha Levin
2020-11-03 1:19 ` Sasha Levin
2020-11-03 1:19 ` [PATCH AUTOSEL 5.8 08/29] io_uring: don't miss setting IO_WQ_WORK_CONCURRENT Sasha Levin
2020-11-03 1:19 ` [PATCH AUTOSEL 5.8 09/29] of: Fix reserved-memory overlap detection Sasha Levin
2020-11-03 1:19 ` [PATCH AUTOSEL 5.8 10/29] ARM: dts: mmp3: Add power domain for the camera Sasha Levin
2020-11-03 1:19 ` Sasha Levin
2020-11-03 1:19 ` [PATCH AUTOSEL 5.8 11/29] drm/sun4i: frontend: Rework a bit the phase data Sasha Levin
2020-11-03 1:19 ` Sasha Levin
2020-11-03 1:19 ` Sasha Levin
2020-11-03 1:19 ` [PATCH AUTOSEL 5.8 12/29] drm/sun4i: frontend: Reuse the ch0 phase for RGB formats Sasha Levin
2020-11-03 1:19 ` Sasha Levin
2020-11-03 1:19 ` Sasha Levin
2020-11-03 1:19 ` [PATCH AUTOSEL 5.8 13/29] drm/sun4i: frontend: Fix the scaler phase on A33 Sasha Levin
2020-11-03 1:19 ` Sasha Levin
2020-11-03 1:19 ` Sasha Levin
2020-11-03 1:19 ` [PATCH AUTOSEL 5.8 14/29] drm/v3d: Fix double free in v3d_submit_cl_ioctl() Sasha Levin
2020-11-03 1:19 ` Sasha Levin
2020-11-03 1:19 ` [PATCH AUTOSEL 5.8 15/29] blk-cgroup: Fix memleak on error path Sasha Levin
2020-11-03 1:19 ` [PATCH AUTOSEL 5.8 16/29] blk-cgroup: Pre-allocate tree node on blkg_conf_prep Sasha Levin
2020-11-03 1:19 ` [PATCH AUTOSEL 5.8 17/29] btrfs: add a helper to read the tree_root commit root for backref lookup Sasha Levin
2020-11-03 1:19 ` [PATCH AUTOSEL 5.8 18/29] scsi: core: Don't start concurrent async scan on same host Sasha Levin
2020-11-03 1:19 ` [PATCH AUTOSEL 5.8 19/29] drm/amdgpu: add DID for navi10 blockchain SKU Sasha Levin
2020-11-03 1:19 ` Sasha Levin
2020-11-03 1:19 ` Sasha Levin
2020-11-03 1:19 ` [PATCH AUTOSEL 5.8 20/29] scsi: ibmvscsi: Fix potential race after loss of transport Sasha Levin
2020-11-03 1:19 ` Sasha Levin
2020-11-03 1:19 ` [PATCH AUTOSEL 5.8 21/29] vsock: use ns_capable_noaudit() on socket create Sasha Levin
2020-11-03 1:19 ` [PATCH AUTOSEL 5.8 22/29] nvme-rdma: handle unexpected nvme completion data length Sasha Levin
2020-11-03 1:19 ` Sasha Levin
2020-11-03 1:19 ` [PATCH AUTOSEL 5.8 23/29] nvmet: fix a NULL pointer dereference when tracing the flush command Sasha Levin
2020-11-03 1:19 ` Sasha Levin
2020-11-03 1:19 ` [PATCH AUTOSEL 5.8 24/29] drm/vc4: drv: Add error handding for bind Sasha Levin
2020-11-03 1:19 ` Sasha Levin
2020-11-03 1:19 ` [PATCH AUTOSEL 5.8 25/29] ACPI: NFIT: Fix comparison to '-ENXIO' Sasha Levin
2020-11-03 1:19 ` Sasha Levin
2020-11-03 1:19 ` [PATCH AUTOSEL 5.8 26/29] usb: cdns3: gadget: suspicious implicit sign extension Sasha Levin
2020-11-03 1:19 ` [PATCH AUTOSEL 5.8 27/29] drm/nouveau/nouveau: fix the start/end range for migration Sasha Levin
2020-11-03 1:19 ` Sasha Levin
2020-11-03 1:19 ` Sasha Levin
2020-11-03 1:19 ` [PATCH AUTOSEL 5.8 28/29] drm/nouveau/gem: fix "refcount_t: underflow; use-after-free" Sasha Levin
2020-11-03 1:19 ` Sasha Levin
2020-11-03 1:19 ` Sasha Levin [this message]
2020-11-03 1:19 ` [PATCH AUTOSEL 5.8 29/29] arm64/smp: Move rcu_cpu_starting() earlier Sasha Levin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201103011928.183145-29-sashal@kernel.org \
--to=sashal@kernel.org \
--cc=cai@redhat.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=paulmck@kernel.org \
--cc=stable@vger.kernel.org \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.