Re: [PATCH v2 1/2] media: i2c: Add driver for the Sony Exmor-RS IMX300 camera sensor

From: kernel test robot <lkp@intel.com>
To: kholk11@gmail.com, mchehab@kernel.org
Cc: kbuild-all@lists.01.org, robh+dt@kernel.org, marijns95@gmail.com,
	konradybcio@gmail.com, martin.botka1@gmail.com,
	devicetree@vger.kernel.org, linux-media@vger.kernel.org,
	phone-devel@vger.kernel.org, linux-kernel@vger.kernel.org,
	AngeloGioacchino Del Regno <kholk11@gmail.com>
Subject: Re: [PATCH v2 1/2] media: i2c: Add driver for the Sony Exmor-RS IMX300 camera sensor
Date: Wed, 4 Nov 2020 12:50:07 +0800	[thread overview]
Message-ID: <202011041252.NXg717LI-lkp@intel.com> (raw)
In-Reply-To: <20201029172947.34315-2-kholk11@gmail.com>

[-- Attachment #1: Type: text/plain, Size: 2457 bytes --]

Hi,

Thank you for the patch! Perhaps something to improve:

[auto build test WARNING on linuxtv-media/master]
[also build test WARNING on robh/for-next linus/master v5.10-rc2 next-20201103]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/0day-ci/linux/commits/kholk11-gmail-com/Add-support-for-the-Sony-Exmor-RS-IMX300-camera-sensor/20201030-013153
base:   git://linuxtv.org/media_tree.git master
config: parisc-randconfig-s031-20201104 (attached as .config)
compiler: hppa-linux-gcc (GCC) 9.3.0
reproduce:
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # apt-get install sparse
        # sparse version: v0.6.3-76-gf680124b-dirty
        # https://github.com/0day-ci/linux/commit/8be57de72d799d8cffbdb7bbb8a5eca25cedfb0f
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review kholk11-gmail-com/Add-support-for-the-Sony-Exmor-RS-IMX300-camera-sensor/20201030-013153
        git checkout 8be57de72d799d8cffbdb7bbb8a5eca25cedfb0f
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross C=1 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__' ARCH=parisc 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

"sparse warnings: (new ones prefixed by >>)"
>> drivers/media/i2c/imx300.c:1876:17: sparse: sparse: incompatible types in comparison expression (different signedness):
>> drivers/media/i2c/imx300.c:1876:17: sparse:    signed long long *
>> drivers/media/i2c/imx300.c:1876:17: sparse:    unsigned long long [usertype] *

vim +1876 drivers/media/i2c/imx300.c

  1864	
  1865	static s64 get_pixel_rate(struct imx300 *imx300)
  1866	{
  1867		s64 prate;
  1868	
  1869		if (imx300->mode->high_bw)
  1870			prate = IMX300_HIGH_BW_PIXEL_RATE;
  1871		else
  1872			prate = IMX300_LOW_BW_PIXEL_RATE;
  1873	
  1874		/* Satisfy the settle time for 8bits */
  1875		if (imx300->cur_bps == 8) {
> 1876			do_div(prate, 10);
  1877			prate *= 12;
  1878		}
  1879	
  1880		return prate;
  1881	}
  1882	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 28679 bytes --]