All of lore.kernel.org
 help / color / mirror / Atom feed
From: Sam Ravnborg <sam@ravnborg.org>
To: Rob Herring <robh@kernel.org>
Cc: devicetree@vger.kernel.org, Sameer Pujar <spujar@nvidia.com>,
	Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>,
	kuninori.morimoto.gx@renesas.com, linux-kernel@vger.kernel.org,
	dri-devel@lists.freedesktop.org,
	Thierry Reding <thierry.reding@gmail.com>,
	Jacopo Mondi <jacopo+renesas@jmondi.org>
Subject: Re: [PATCH v3 1/3] dt-bindings: Convert graph bindings to json-schema
Date: Thu, 5 Nov 2020 22:43:49 +0100	[thread overview]
Message-ID: <20201105214349.GH216923@ravnborg.org> (raw)
In-Reply-To: <20201102203656.220187-2-robh@kernel.org>

Hi Rob/Sameer


On Mon, Nov 02, 2020 at 02:36:54PM -0600, Rob Herring wrote:
> From: Sameer Pujar <spujar@nvidia.com>
> 
> Convert device tree bindings of graph to YAML format. Currently graph.txt
> doc is referenced in multiple files and all of these need to use schema
> references. For now graph.txt is updated to refer to graph.yaml.
> 
> For users of the graph binding, they should reference to the graph
> schema from either 'ports' or 'port' property:
> 
> properties:
>   ports:
>     type: object
>     $ref: graph.yaml#/properties/ports
Please fix so this example is correct - append /schemas/

> 
>     properties:
>       port@0:
>         description: What data this port has
> 
>       ...
> 
> Or:
> 
> properties:
>   port:
>     description: What data this port has
>     type: object
>     $ref: graph.yaml#/properties/port
Likewise.

Otherwise I could be confused when looking it up later.

> 
> Signed-off-by: Sameer Pujar <spujar@nvidia.com>
> Acked-by: Philipp Zabel <p.zabel@pengutronix.de>
> Signed-off-by: Rob Herring <robh@kernel.org>

With the changelog fixed:
Reviewed-by: Sam Ravnborg <sam@ravnborg.org>

WARNING: multiple messages have this Message-ID (diff)
From: Sam Ravnborg <sam@ravnborg.org>
To: Rob Herring <robh@kernel.org>
Cc: devicetree@vger.kernel.org,
	Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>,
	kuninori.morimoto.gx@renesas.com,
	Sameer Pujar <spujar@nvidia.com>,
	linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org,
	Thierry Reding <thierry.reding@gmail.com>,
	Jacopo Mondi <jacopo+renesas@jmondi.org>
Subject: Re: [PATCH v3 1/3] dt-bindings: Convert graph bindings to json-schema
Date: Thu, 5 Nov 2020 22:43:49 +0100	[thread overview]
Message-ID: <20201105214349.GH216923@ravnborg.org> (raw)
In-Reply-To: <20201102203656.220187-2-robh@kernel.org>

Hi Rob/Sameer


On Mon, Nov 02, 2020 at 02:36:54PM -0600, Rob Herring wrote:
> From: Sameer Pujar <spujar@nvidia.com>
> 
> Convert device tree bindings of graph to YAML format. Currently graph.txt
> doc is referenced in multiple files and all of these need to use schema
> references. For now graph.txt is updated to refer to graph.yaml.
> 
> For users of the graph binding, they should reference to the graph
> schema from either 'ports' or 'port' property:
> 
> properties:
>   ports:
>     type: object
>     $ref: graph.yaml#/properties/ports
Please fix so this example is correct - append /schemas/

> 
>     properties:
>       port@0:
>         description: What data this port has
> 
>       ...
> 
> Or:
> 
> properties:
>   port:
>     description: What data this port has
>     type: object
>     $ref: graph.yaml#/properties/port
Likewise.

Otherwise I could be confused when looking it up later.

> 
> Signed-off-by: Sameer Pujar <spujar@nvidia.com>
> Acked-by: Philipp Zabel <p.zabel@pengutronix.de>
> Signed-off-by: Rob Herring <robh@kernel.org>

With the changelog fixed:
Reviewed-by: Sam Ravnborg <sam@ravnborg.org>
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

  reply	other threads:[~2020-11-05 21:43 UTC|newest]

Thread overview: 34+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-11-02 20:36 [PATCH v3 0/3] dt-bindings: Convert graph bindings to json-schema Rob Herring
2020-11-02 20:36 ` Rob Herring
2020-11-02 20:36 ` [PATCH v3 1/3] " Rob Herring
2020-11-02 20:36   ` Rob Herring
2020-11-05 21:43   ` Sam Ravnborg [this message]
2020-11-05 21:43     ` Sam Ravnborg
2020-11-11  9:51   ` Sameer Pujar
2020-11-11  9:51     ` Sameer Pujar
2020-11-11 13:35     ` Rob Herring
2020-11-11 13:35       ` Rob Herring
2020-11-11 14:00   ` Laurent Pinchart
2020-11-11 14:00     ` Laurent Pinchart
2020-11-11 14:25     ` Rob Herring
2020-11-11 14:25       ` Rob Herring
2020-11-11 14:27       ` Laurent Pinchart
2020-11-11 14:27         ` Laurent Pinchart
2020-11-11 23:03         ` Rob Herring
2020-11-11 23:03           ` Rob Herring
2020-11-12  7:56           ` Laurent Pinchart
2020-11-12  7:56             ` Laurent Pinchart
2020-11-12 20:49   ` Rob Herring
2020-11-12 20:49     ` Rob Herring
2020-11-02 20:36 ` [PATCH v3 2/3] dt-bindings: usb-connector: Add reference to graph schema Rob Herring
2020-11-02 20:36   ` Rob Herring
2020-11-11 14:01   ` Laurent Pinchart
2020-11-11 14:01     ` Laurent Pinchart
2020-11-02 20:36 ` [PATCH v3 3/3] dt-bindings: panel: common: " Rob Herring
2020-11-02 20:36   ` Rob Herring
2020-11-05 21:46   ` Sam Ravnborg
2020-11-05 21:46     ` Sam Ravnborg
2020-11-11 14:02   ` Laurent Pinchart
2020-11-11 14:02     ` Laurent Pinchart
2020-11-03  6:05 ` [PATCH v3 0/3] dt-bindings: Convert graph bindings to json-schema Sameer Pujar
2020-11-03  6:05   ` Sameer Pujar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20201105214349.GH216923@ravnborg.org \
    --to=sam@ravnborg.org \
    --cc=devicetree@vger.kernel.org \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=jacopo+renesas@jmondi.org \
    --cc=kuninori.morimoto.gx@renesas.com \
    --cc=laurent.pinchart+renesas@ideasonboard.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=robh@kernel.org \
    --cc=spujar@nvidia.com \
    --cc=thierry.reding@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.