All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH v3 1/1] doc: dt-binding: cdns,usb3: add wakeup-irq
@ 2020-11-04  8:05 Peter Chen
  2020-11-05 22:37 ` Rob Herring
  0 siblings, 1 reply; 2+ messages in thread
From: Peter Chen @ 2020-11-04  8:05 UTC (permalink / raw)
  To: robh+dt
  Cc: devicetree, linux-imx, linux-usb, pawell, rogerq, jun.li, Peter Chen

To support low power mode for controller, the driver needs wakeup-irq
to reflect the signal changing after controller is stopped, and waking
the controller up accordingly.

Signed-off-by: Peter Chen <peter.chen@nxp.com>
---
Changes for v3:
- Fix the dt_binding_check error

Changes for v2:
- Add "minItems: 3" to make wakeup irq optional

 Documentation/devicetree/bindings/usb/cdns,usb3.yaml | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/Documentation/devicetree/bindings/usb/cdns,usb3.yaml b/Documentation/devicetree/bindings/usb/cdns,usb3.yaml
index ac20b98e9910..b32c877dc2a8 100644
--- a/Documentation/devicetree/bindings/usb/cdns,usb3.yaml
+++ b/Documentation/devicetree/bindings/usb/cdns,usb3.yaml
@@ -26,16 +26,21 @@ properties:
       - const: dev
 
   interrupts:
+    minItems: 3
     items:
       - description: OTG/DRD controller interrupt
       - description: XHCI host controller interrupt
       - description: Device controller interrupt
+      - description: interrupt used to wake up core, e.g when usbcmd.rs is
+                     cleared by xhci core, this interrupt is optional
 
   interrupt-names:
+    minItems: 3
     items:
       - const: host
       - const: peripheral
       - const: otg
+      - const: wakeup
 
   dr_mode:
     enum: [host, otg, peripheral]
-- 
2.17.1


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH v3 1/1] doc: dt-binding: cdns,usb3: add wakeup-irq
  2020-11-04  8:05 [PATCH v3 1/1] doc: dt-binding: cdns,usb3: add wakeup-irq Peter Chen
@ 2020-11-05 22:37 ` Rob Herring
  0 siblings, 0 replies; 2+ messages in thread
From: Rob Herring @ 2020-11-05 22:37 UTC (permalink / raw)
  To: Peter Chen
  Cc: devicetree, pawell, linux-usb, rogerq, jun.li, linux-imx, robh+dt

On Wed, 04 Nov 2020 16:05:24 +0800, Peter Chen wrote:
> To support low power mode for controller, the driver needs wakeup-irq
> to reflect the signal changing after controller is stopped, and waking
> the controller up accordingly.
> 
> Signed-off-by: Peter Chen <peter.chen@nxp.com>
> ---
> Changes for v3:
> - Fix the dt_binding_check error
> 
> Changes for v2:
> - Add "minItems: 3" to make wakeup irq optional
> 
>  Documentation/devicetree/bindings/usb/cdns,usb3.yaml | 5 +++++
>  1 file changed, 5 insertions(+)
> 

Reviewed-by: Rob Herring <robh@kernel.org>

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2020-11-05 22:37 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-11-04  8:05 [PATCH v3 1/1] doc: dt-binding: cdns,usb3: add wakeup-irq Peter Chen
2020-11-05 22:37 ` Rob Herring

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.