* [LTP] [PATCH] tcp_cmds/ping: TCONF on unknown -f parameter
@ 2020-11-06 10:37 Kory Maincent
2020-11-06 11:38 ` Alexey Kodanev
0 siblings, 1 reply; 3+ messages in thread
From: Kory Maincent @ 2020-11-06 10:37 UTC (permalink / raw)
To: ltp
The ping from busybox does not have -f parameter.
Return TCONF in that case.
Signed-off-by: Kory Maincent <kory.maincent@bootlin.com>
---
testcases/network/tcp_cmds/ping/ping02.sh | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/testcases/network/tcp_cmds/ping/ping02.sh b/testcases/network/tcp_cmds/ping/ping02.sh
index e0a63c5f6..6daf22635 100755
--- a/testcases/network/tcp_cmds/ping/ping02.sh
+++ b/testcases/network/tcp_cmds/ping/ping02.sh
@@ -27,6 +27,10 @@ do_test()
local ipaddr=$(tst_ipaddr rhost)
local s
+ if ! $PING -c 1 -f $ipaddr >/dev/null; then
+ tst_brk TCONF "$PING: invalid option -- 'f'"
+ fi
+
for s in $PACKETSIZES; do
EXPECT_PASS $PING -c $COUNT -f -s $s $ipaddr -p "$pat" \>/dev/null
done
--
2.17.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* [LTP] [PATCH] tcp_cmds/ping: TCONF on unknown -f parameter
2020-11-06 10:37 [LTP] [PATCH] tcp_cmds/ping: TCONF on unknown -f parameter Kory Maincent
@ 2020-11-06 11:38 ` Alexey Kodanev
2020-11-06 13:42 ` =?unknown-8bit?q?K=C3=B6ry?= Maincent
0 siblings, 1 reply; 3+ messages in thread
From: Alexey Kodanev @ 2020-11-06 11:38 UTC (permalink / raw)
To: ltp
On 06.11.2020 13:37, Kory Maincent wrote:
> The ping from busybox does not have -f parameter.
> Return TCONF in that case.
>
> Signed-off-by: Kory Maincent <kory.maincent@bootlin.com>
> ---
> testcases/network/tcp_cmds/ping/ping02.sh | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/testcases/network/tcp_cmds/ping/ping02.sh b/testcases/network/tcp_cmds/ping/ping02.sh
> index e0a63c5f6..6daf22635 100755
> --- a/testcases/network/tcp_cmds/ping/ping02.sh
> +++ b/testcases/network/tcp_cmds/ping/ping02.sh
> @@ -27,6 +27,10 @@ do_test()
> local ipaddr=$(tst_ipaddr rhost)
> local s
>
> + if ! $PING -c 1 -f $ipaddr >/dev/null; then
> + tst_brk TCONF "$PING: invalid option -- 'f'"
Hi Kory,
If it's not supported, what about replacing it with '-i 0'?
> + fi
> +
> for s in $PACKETSIZES; do
> EXPECT_PASS $PING -c $COUNT -f -s $s $ipaddr -p "$pat" \>/dev/null
> done
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* [LTP] [PATCH] tcp_cmds/ping: TCONF on unknown -f parameter
2020-11-06 11:38 ` Alexey Kodanev
@ 2020-11-06 13:42 ` =?unknown-8bit?q?K=C3=B6ry?= Maincent
0 siblings, 0 replies; 3+ messages in thread
From: =?unknown-8bit?q?K=C3=B6ry?= Maincent @ 2020-11-06 13:42 UTC (permalink / raw)
To: ltp
Hello Alexey,
On Fri, 6 Nov 2020 14:38:33 +0300
Alexey Kodanev <alexey.kodanev@oracle.com> wrote:
> On 06.11.2020 13:37, Kory Maincent wrote:
> > The ping from busybox does not have -f parameter.
> > Return TCONF in that case.
> >
> > Signed-off-by: Kory Maincent <kory.maincent@bootlin.com>
> > ---
> > testcases/network/tcp_cmds/ping/ping02.sh | 4 ++++
> > 1 file changed, 4 insertions(+)
> >
> > diff --git a/testcases/network/tcp_cmds/ping/ping02.sh
> > b/testcases/network/tcp_cmds/ping/ping02.sh index
> > e0a63c5f6..6daf22635 100755 ---
> > a/testcases/network/tcp_cmds/ping/ping02.sh +++
> > b/testcases/network/tcp_cmds/ping/ping02.sh @@ -27,6 +27,10 @@
> > do_test() local ipaddr=$(tst_ipaddr rhost)
> > local s
> >
> > + if ! $PING -c 1 -f $ipaddr >/dev/null; then
> > + tst_brk TCONF "$PING: invalid option -- 'f'"
>
> Hi Kory,
>
> If it's not supported, what about replacing it with '-i 0'?
Ah yes good idea, thanks.
Regards,
>
>
> > + fi
> > +
> > for s in $PACKETSIZES; do
> > EXPECT_PASS $PING -c $COUNT -f -s $s $ipaddr -p
> > "$pat" \>/dev/null done
> >
>
--
K?ry Maincent, Bootlin
Embedded Linux and kernel engineering
https://bootlin.com
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-11-06 13:42 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-11-06 10:37 [LTP] [PATCH] tcp_cmds/ping: TCONF on unknown -f parameter Kory Maincent
2020-11-06 11:38 ` Alexey Kodanev
2020-11-06 13:42 ` =?unknown-8bit?q?K=C3=B6ry?= Maincent
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.