From: Rob Herring <robh@kernel.org>
To: Samuel Holland <samuel@sholland.org>
Cc: linux-arm-kernel@lists.infradead.org,
Chen-Yu Tsai <wens@csie.org>, Maxime Ripard <mripard@kernel.org>,
Liam Girdwood <lgirdwood@gmail.com>,
devicetree@vger.kernel.org, Mark Brown <broonie@kernel.org>,
alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org,
phone-devel@vger.kernel.org,
Jernej Skrabec <jernej.skrabec@siol.net>,
Rob Herring <robh+dt@kernel.org>
Subject: Re: [PATCH 1/7] ASoC: dt-bindings: sun8i-codec: Increase #sound-dai-cells
Date: Fri, 6 Nov 2020 10:15:39 -0600 [thread overview]
Message-ID: <20201106161539.GA3295779@bogus> (raw)
In-Reply-To: <20201106041513.38481-2-samuel@sholland.org>
On Thu, 05 Nov 2020 22:15:07 -0600, Samuel Holland wrote:
> Increase sound-dai-cells to 1 to allow using the DAIs in the codec
> corresponding to AIF2 and AIF3.
>
> The generic ASoC OF code supports a #sound-dai-cells value of 0 or 1
> with no impact to the driver, so this is a backward-compatible change.
>
> Signed-off-by: Samuel Holland <samuel@sholland.org>
> ---
> .../devicetree/bindings/sound/allwinner,sun8i-a33-codec.yaml | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
My bot found errors running 'make dt_binding_check' on your patch:
yamllint warnings/errors:
dtschema/dtc warnings/errors:
/builds/robherring/linux-dt-review/Documentation/devicetree/bindings/sound/allwinner,sun8i-a33-codec.example.dt.yaml: audio-codec@1c22e00: #sound-dai-cells:0:0: 1 was expected
From schema: /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/sound/allwinner,sun8i-a33-codec.yaml
See https://patchwork.ozlabs.org/patch/1395481
The base for the patch is generally the last rc1. Any dependencies
should be noted.
If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure 'yamllint' is installed and dt-schema is up to
date:
pip3 install dtschema --upgrade
Please check and re-submit.
WARNING: multiple messages have this Message-ID (diff)
From: Rob Herring <robh@kernel.org>
To: Samuel Holland <samuel@sholland.org>
Cc: devicetree@vger.kernel.org, alsa-devel@alsa-project.org,
Jernej Skrabec <jernej.skrabec@siol.net>,
Liam Girdwood <lgirdwood@gmail.com>,
Maxime Ripard <mripard@kernel.org>,
linux-kernel@vger.kernel.org, Rob Herring <robh+dt@kernel.org>,
Chen-Yu Tsai <wens@csie.org>, Mark Brown <broonie@kernel.org>,
phone-devel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 1/7] ASoC: dt-bindings: sun8i-codec: Increase #sound-dai-cells
Date: Fri, 6 Nov 2020 10:15:39 -0600 [thread overview]
Message-ID: <20201106161539.GA3295779@bogus> (raw)
In-Reply-To: <20201106041513.38481-2-samuel@sholland.org>
On Thu, 05 Nov 2020 22:15:07 -0600, Samuel Holland wrote:
> Increase sound-dai-cells to 1 to allow using the DAIs in the codec
> corresponding to AIF2 and AIF3.
>
> The generic ASoC OF code supports a #sound-dai-cells value of 0 or 1
> with no impact to the driver, so this is a backward-compatible change.
>
> Signed-off-by: Samuel Holland <samuel@sholland.org>
> ---
> .../devicetree/bindings/sound/allwinner,sun8i-a33-codec.yaml | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
My bot found errors running 'make dt_binding_check' on your patch:
yamllint warnings/errors:
dtschema/dtc warnings/errors:
/builds/robherring/linux-dt-review/Documentation/devicetree/bindings/sound/allwinner,sun8i-a33-codec.example.dt.yaml: audio-codec@1c22e00: #sound-dai-cells:0:0: 1 was expected
From schema: /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/sound/allwinner,sun8i-a33-codec.yaml
See https://patchwork.ozlabs.org/patch/1395481
The base for the patch is generally the last rc1. Any dependencies
should be noted.
If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure 'yamllint' is installed and dt-schema is up to
date:
pip3 install dtschema --upgrade
Please check and re-submit.
WARNING: multiple messages have this Message-ID (diff)
From: Rob Herring <robh@kernel.org>
To: Samuel Holland <samuel@sholland.org>
Cc: devicetree@vger.kernel.org, alsa-devel@alsa-project.org,
Jernej Skrabec <jernej.skrabec@siol.net>,
Liam Girdwood <lgirdwood@gmail.com>,
Maxime Ripard <mripard@kernel.org>,
linux-kernel@vger.kernel.org, Rob Herring <robh+dt@kernel.org>,
Chen-Yu Tsai <wens@csie.org>, Mark Brown <broonie@kernel.org>,
phone-devel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 1/7] ASoC: dt-bindings: sun8i-codec: Increase #sound-dai-cells
Date: Fri, 6 Nov 2020 10:15:39 -0600 [thread overview]
Message-ID: <20201106161539.GA3295779@bogus> (raw)
In-Reply-To: <20201106041513.38481-2-samuel@sholland.org>
On Thu, 05 Nov 2020 22:15:07 -0600, Samuel Holland wrote:
> Increase sound-dai-cells to 1 to allow using the DAIs in the codec
> corresponding to AIF2 and AIF3.
>
> The generic ASoC OF code supports a #sound-dai-cells value of 0 or 1
> with no impact to the driver, so this is a backward-compatible change.
>
> Signed-off-by: Samuel Holland <samuel@sholland.org>
> ---
> .../devicetree/bindings/sound/allwinner,sun8i-a33-codec.yaml | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
My bot found errors running 'make dt_binding_check' on your patch:
yamllint warnings/errors:
dtschema/dtc warnings/errors:
/builds/robherring/linux-dt-review/Documentation/devicetree/bindings/sound/allwinner,sun8i-a33-codec.example.dt.yaml: audio-codec@1c22e00: #sound-dai-cells:0:0: 1 was expected
From schema: /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/sound/allwinner,sun8i-a33-codec.yaml
See https://patchwork.ozlabs.org/patch/1395481
The base for the patch is generally the last rc1. Any dependencies
should be noted.
If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure 'yamllint' is installed and dt-schema is up to
date:
pip3 install dtschema --upgrade
Please check and re-submit.
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2020-11-06 16:15 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-06 4:15 [PATCH 0/7] PinePhone BT audio bringup Samuel Holland
2020-11-06 4:15 ` Samuel Holland
2020-11-06 4:15 ` Samuel Holland
2020-11-06 4:15 ` [PATCH 1/7] ASoC: dt-bindings: sun8i-codec: Increase #sound-dai-cells Samuel Holland
2020-11-06 4:15 ` Samuel Holland
2020-11-06 4:15 ` Samuel Holland
2020-11-06 16:15 ` Rob Herring [this message]
2020-11-06 16:15 ` Rob Herring
2020-11-06 16:15 ` Rob Herring
2020-11-06 4:15 ` [PATCH 2/7] ARM: dts: sun8i-a33: Allow using multiple codec DAIs Samuel Holland
2020-11-06 4:15 ` Samuel Holland
2020-11-06 4:15 ` Samuel Holland
2020-11-06 4:15 ` [PATCH 3/7] arm64: dts: allwinner: a64: " Samuel Holland
2020-11-06 4:15 ` Samuel Holland
2020-11-06 4:15 ` Samuel Holland
2020-11-06 4:15 ` [PATCH 4/7] arm64: dts: allwinner: a64: Add pinmux nodes for AIF2/AIF3 Samuel Holland
2020-11-06 4:15 ` Samuel Holland
2020-11-06 4:15 ` Samuel Holland
2020-11-06 4:15 ` [PATCH 5/7] arm64: dts: allwinner: a64: Allow multiple DAI links Samuel Holland
2020-11-06 4:15 ` Samuel Holland
2020-11-06 4:15 ` Samuel Holland
2020-11-06 4:15 ` [PATCH 6/7] arm64: dts: allwinner: pinephone: Add support for Bluetooth audio Samuel Holland
2020-11-06 4:15 ` Samuel Holland
2020-11-06 4:15 ` Samuel Holland
2020-11-06 4:15 ` [PATCH 7/7] arm64: dts: allwinner: pinephone: Set audio card name Samuel Holland
2020-11-06 4:15 ` Samuel Holland
2020-11-06 4:15 ` Samuel Holland
2020-11-06 4:28 ` [PATCH 0/7] PinePhone BT audio bringup Chen-Yu Tsai
2020-11-06 4:28 ` Chen-Yu Tsai
2020-11-06 4:28 ` Chen-Yu Tsai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201106161539.GA3295779@bogus \
--to=robh@kernel.org \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=jernej.skrabec@siol.net \
--cc=lgirdwood@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mripard@kernel.org \
--cc=phone-devel@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=samuel@sholland.org \
--cc=wens@csie.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.