* [PATCH] migration/dirtyrate: simplify inlcudes in dirtyrate.c
@ 2020-10-30 3:58 Chuan Zheng
2020-10-30 14:09 ` Mark Kanda
2020-11-12 14:55 ` Dr. David Alan Gilbert
0 siblings, 2 replies; 5+ messages in thread
From: Chuan Zheng @ 2020-10-30 3:58 UTC (permalink / raw)
To: quintela, dgilbert
Cc: yubihong, zhang.zhanghailiang, qemu-devel, xiexiangyou,
alex.chen, wanghao232
Remove redundant blank line which is left by Commit 662770af7c6e8c,
also take this opportunity to remove redundant includes in dirtyrate.c.
Signed-off-by: Chuan Zheng <zhengchuan@huawei.com>
---
migration/dirtyrate.c | 5 -----
1 file changed, 5 deletions(-)
diff --git a/migration/dirtyrate.c b/migration/dirtyrate.c
index 8f728d2..ccb9814 100644
--- a/migration/dirtyrate.c
+++ b/migration/dirtyrate.c
@@ -11,17 +11,12 @@
*/
#include "qemu/osdep.h"
-
#include <zlib.h>
#include "qapi/error.h"
#include "cpu.h"
-#include "qemu/config-file.h"
-#include "exec/memory.h"
#include "exec/ramblock.h"
-#include "exec/target_page.h"
#include "qemu/rcu_queue.h"
#include "qapi/qapi-commands-migration.h"
-#include "migration.h"
#include "ram.h"
#include "trace.h"
#include "dirtyrate.h"
--
1.8.3.1
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH] migration/dirtyrate: simplify inlcudes in dirtyrate.c
2020-10-30 3:58 [PATCH] migration/dirtyrate: simplify inlcudes in dirtyrate.c Chuan Zheng
@ 2020-10-30 14:09 ` Mark Kanda
2020-11-06 6:24 ` Zheng Chuan
2020-11-12 14:55 ` Dr. David Alan Gilbert
1 sibling, 1 reply; 5+ messages in thread
From: Mark Kanda @ 2020-10-30 14:09 UTC (permalink / raw)
To: Chuan Zheng, quintela, dgilbert
Cc: yubihong, zhang.zhanghailiang, qemu-devel, xiexiangyou,
alex.chen, wanghao232
On 10/29/2020 10:58 PM, Chuan Zheng wrote:
> Remove redundant blank line which is left by Commit 662770af7c6e8c,
> also take this opportunity to remove redundant includes in dirtyrate.c.
>
> Signed-off-by: Chuan Zheng <zhengchuan@huawei.com>
Reviewed-by: Mark Kanda <mark.kanda@oracle.com>
> ---
> migration/dirtyrate.c | 5 -----
> 1 file changed, 5 deletions(-)
>
> diff --git a/migration/dirtyrate.c b/migration/dirtyrate.c
> index 8f728d2..ccb9814 100644
> --- a/migration/dirtyrate.c
> +++ b/migration/dirtyrate.c
> @@ -11,17 +11,12 @@
> */
>
> #include "qemu/osdep.h"
> -
> #include <zlib.h>
> #include "qapi/error.h"
> #include "cpu.h"
> -#include "qemu/config-file.h"
> -#include "exec/memory.h"
> #include "exec/ramblock.h"
> -#include "exec/target_page.h"
> #include "qemu/rcu_queue.h"
> #include "qapi/qapi-commands-migration.h"
> -#include "migration.h"
> #include "ram.h"
> #include "trace.h"
> #include "dirtyrate.h"
>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] migration/dirtyrate: simplify inlcudes in dirtyrate.c
2020-10-30 14:09 ` Mark Kanda
@ 2020-11-06 6:24 ` Zheng Chuan
2020-11-06 16:53 ` Dr. David Alan Gilbert
0 siblings, 1 reply; 5+ messages in thread
From: Zheng Chuan @ 2020-11-06 6:24 UTC (permalink / raw)
To: Mark Kanda, quintela, dgilbert
Cc: yubihong, zhang.zhanghailiang, qemu-devel, xiexiangyou,
alex.chen, wanghao232
Kindly ping for not forgetting this trivial fix:)
On 2020/10/30 22:09, Mark Kanda wrote:
> On 10/29/2020 10:58 PM, Chuan Zheng wrote:
>> Remove redundant blank line which is left by Commit 662770af7c6e8c,
>> also take this opportunity to remove redundant includes in dirtyrate.c.
>>
>> Signed-off-by: Chuan Zheng <zhengchuan@huawei.com>
>
> Reviewed-by: Mark Kanda <mark.kanda@oracle.com>
>
>> ---
>> migration/dirtyrate.c | 5 -----
>> 1 file changed, 5 deletions(-)
>>
>> diff --git a/migration/dirtyrate.c b/migration/dirtyrate.c
>> index 8f728d2..ccb9814 100644
>> --- a/migration/dirtyrate.c
>> +++ b/migration/dirtyrate.c
>> @@ -11,17 +11,12 @@
>> */
>> #include "qemu/osdep.h"
>> -
>> #include <zlib.h>
>> #include "qapi/error.h"
>> #include "cpu.h"
>> -#include "qemu/config-file.h"
>> -#include "exec/memory.h"
>> #include "exec/ramblock.h"
>> -#include "exec/target_page.h"
>> #include "qemu/rcu_queue.h"
>> #include "qapi/qapi-commands-migration.h"
>> -#include "migration.h"
>> #include "ram.h"
>> #include "trace.h"
>> #include "dirtyrate.h"
>>
--
Regards.
Chuan
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] migration/dirtyrate: simplify inlcudes in dirtyrate.c
2020-11-06 6:24 ` Zheng Chuan
@ 2020-11-06 16:53 ` Dr. David Alan Gilbert
0 siblings, 0 replies; 5+ messages in thread
From: Dr. David Alan Gilbert @ 2020-11-06 16:53 UTC (permalink / raw)
To: Zheng Chuan
Cc: yubihong, zhang.zhanghailiang, quintela, qemu-devel, xiexiangyou,
alex.chen, wanghao232
* Zheng Chuan (zhengchuan@huawei.com) wrote:
> Kindly ping for not forgetting this trivial fix:)
Yes but it's too late for the merge window, so it'll happen on the next
one, no rush!
Dave
> On 2020/10/30 22:09, Mark Kanda wrote:
> > On 10/29/2020 10:58 PM, Chuan Zheng wrote:
> >> Remove redundant blank line which is left by Commit 662770af7c6e8c,
> >> also take this opportunity to remove redundant includes in dirtyrate.c.
> >>
> >> Signed-off-by: Chuan Zheng <zhengchuan@huawei.com>
> >
> > Reviewed-by: Mark Kanda <mark.kanda@oracle.com>
> >
> >> ---
> >> Â migration/dirtyrate.c | 5 -----
> >> Â 1 file changed, 5 deletions(-)
> >>
> >> diff --git a/migration/dirtyrate.c b/migration/dirtyrate.c
> >> index 8f728d2..ccb9814 100644
> >> --- a/migration/dirtyrate.c
> >> +++ b/migration/dirtyrate.c
> >> @@ -11,17 +11,12 @@
> >> Â Â */
> >> Â Â #include "qemu/osdep.h"
> >> -
> >> Â #include <zlib.h>
> >> Â #include "qapi/error.h"
> >> Â #include "cpu.h"
> >> -#include "qemu/config-file.h"
> >> -#include "exec/memory.h"
> >> Â #include "exec/ramblock.h"
> >> -#include "exec/target_page.h"
> >> Â #include "qemu/rcu_queue.h"
> >> Â #include "qapi/qapi-commands-migration.h"
> >> -#include "migration.h"
> >> Â #include "ram.h"
> >> Â #include "trace.h"
> >> Â #include "dirtyrate.h"
> >>
>
> --
> Regards.
> Chuan
>
--
Dr. David Alan Gilbert / dgilbert@redhat.com / Manchester, UK
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] migration/dirtyrate: simplify inlcudes in dirtyrate.c
2020-10-30 3:58 [PATCH] migration/dirtyrate: simplify inlcudes in dirtyrate.c Chuan Zheng
2020-10-30 14:09 ` Mark Kanda
@ 2020-11-12 14:55 ` Dr. David Alan Gilbert
1 sibling, 0 replies; 5+ messages in thread
From: Dr. David Alan Gilbert @ 2020-11-12 14:55 UTC (permalink / raw)
To: Chuan Zheng
Cc: yubihong, zhang.zhanghailiang, quintela, qemu-devel, xiexiangyou,
alex.chen, wanghao232
* Chuan Zheng (zhengchuan@huawei.com) wrote:
> Remove redundant blank line which is left by Commit 662770af7c6e8c,
> also take this opportunity to remove redundant includes in dirtyrate.c.
>
> Signed-off-by: Chuan Zheng <zhengchuan@huawei.com>
and queued
Reviewed-by: Dr. David Alan Gilbert <dgilbert@redhat.com>
> ---
> migration/dirtyrate.c | 5 -----
> 1 file changed, 5 deletions(-)
>
> diff --git a/migration/dirtyrate.c b/migration/dirtyrate.c
> index 8f728d2..ccb9814 100644
> --- a/migration/dirtyrate.c
> +++ b/migration/dirtyrate.c
> @@ -11,17 +11,12 @@
> */
>
> #include "qemu/osdep.h"
> -
> #include <zlib.h>
> #include "qapi/error.h"
> #include "cpu.h"
> -#include "qemu/config-file.h"
> -#include "exec/memory.h"
> #include "exec/ramblock.h"
> -#include "exec/target_page.h"
> #include "qemu/rcu_queue.h"
> #include "qapi/qapi-commands-migration.h"
> -#include "migration.h"
> #include "ram.h"
> #include "trace.h"
> #include "dirtyrate.h"
> --
> 1.8.3.1
>
>
--
Dr. David Alan Gilbert / dgilbert@redhat.com / Manchester, UK
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2020-11-12 14:57 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-10-30 3:58 [PATCH] migration/dirtyrate: simplify inlcudes in dirtyrate.c Chuan Zheng
2020-10-30 14:09 ` Mark Kanda
2020-11-06 6:24 ` Zheng Chuan
2020-11-06 16:53 ` Dr. David Alan Gilbert
2020-11-12 14:55 ` Dr. David Alan Gilbert
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.