From: Jason Gunthorpe <jgg@ziepe.ca>
To: Logan Gunthorpe <logang@deltatee.com>
Cc: linux-kernel@vger.kernel.org, linux-nvme@lists.infradead.org,
linux-block@vger.kernel.org, linux-pci@vger.kernel.org,
linux-mm@kvack.org, iommu@lists.linux-foundation.org,
"Stephen Bates" <sbates@raithlin.com>,
"Christoph Hellwig" <hch@lst.de>,
"Dan Williams" <dan.j.williams@intel.com>,
"Christian König" <christian.koenig@amd.com>,
"Ira Weiny" <iweiny@intel.com>,
"John Hubbard" <jhubbard@nvidia.com>,
"Don Dutile" <ddutile@redhat.com>,
"Matthew Wilcox" <willy@infradead.org>,
"Daniel Vetter" <daniel.vetter@ffwll.ch>
Subject: Re: [RFC PATCH 14/15] PCI/P2PDMA: Introduce pci_mmap_p2pmem()
Date: Fri, 6 Nov 2020 15:30:24 -0400 [thread overview]
Message-ID: <20201106193024.GW36674@ziepe.ca> (raw)
In-Reply-To: <09885400-36f8-bc1d-27f0-a8adcf6104d4@deltatee.com>
On Fri, Nov 06, 2020 at 11:20:05AM -0700, Logan Gunthorpe wrote:
>
>
> On 2020-11-06 11:09 a.m., Jason Gunthorpe wrote:
> >> Ah, hmm, yes. I guess the pages have to be hooked and returned to the
> >> genalloc through free_devmap_managed_page().
> >
> > That sounds about right, but in this case it doesn't need the VMA
> > operations.
> >
> >> Seems like it might be doable... but it will complicate things for
> >> users that don't want to use the genpool (though no such users exist
> >> upstream).
> >
> > I would like to use this stuff in RDMA pretty much immediately and the
> > genpool is harmful for those cases, so please don't make decisions
> > that are tying thing to genpool
>
> I certainly can't make decisions for code that isn't currently
> upstream.
The rdma drivers are all upstream, what are you thinking about?
> Ultimately, if you aren't using the genpool you will have to implement
> your own mmap operation that somehow allocates the pages and your own
> page_free hook.
Sure, the mlx5 driver already has a specialized alloctor for it's BAR
pages.
> I also don't expect this to be going upstream in the near term so don't
> get too excited about using it.
I don't know, it is actually not that horrible, the GUP and IOMMU
related changes are simpler than I expected
Jason
WARNING: multiple messages have this Message-ID (diff)
From: Jason Gunthorpe <jgg@ziepe.ca>
To: Logan Gunthorpe <logang@deltatee.com>
Cc: "Christian König" <christian.koenig@amd.com>,
linux-pci@vger.kernel.org,
"Daniel Vetter" <daniel.vetter@ffwll.ch>,
"Ira Weiny" <iweiny@intel.com>,
linux-kernel@vger.kernel.org, linux-nvme@lists.infradead.org,
"Stephen Bates" <sbates@raithlin.com>,
linux-block@vger.kernel.org, linux-mm@kvack.org,
iommu@lists.linux-foundation.org,
"Don Dutile" <ddutile@redhat.com>,
"Matthew Wilcox" <willy@infradead.org>,
"John Hubbard" <jhubbard@nvidia.com>,
"Dan Williams" <dan.j.williams@intel.com>,
"Christoph Hellwig" <hch@lst.de>
Subject: Re: [RFC PATCH 14/15] PCI/P2PDMA: Introduce pci_mmap_p2pmem()
Date: Fri, 6 Nov 2020 15:30:24 -0400 [thread overview]
Message-ID: <20201106193024.GW36674@ziepe.ca> (raw)
In-Reply-To: <09885400-36f8-bc1d-27f0-a8adcf6104d4@deltatee.com>
On Fri, Nov 06, 2020 at 11:20:05AM -0700, Logan Gunthorpe wrote:
>
>
> On 2020-11-06 11:09 a.m., Jason Gunthorpe wrote:
> >> Ah, hmm, yes. I guess the pages have to be hooked and returned to the
> >> genalloc through free_devmap_managed_page().
> >
> > That sounds about right, but in this case it doesn't need the VMA
> > operations.
> >
> >> Seems like it might be doable... but it will complicate things for
> >> users that don't want to use the genpool (though no such users exist
> >> upstream).
> >
> > I would like to use this stuff in RDMA pretty much immediately and the
> > genpool is harmful for those cases, so please don't make decisions
> > that are tying thing to genpool
>
> I certainly can't make decisions for code that isn't currently
> upstream.
The rdma drivers are all upstream, what are you thinking about?
> Ultimately, if you aren't using the genpool you will have to implement
> your own mmap operation that somehow allocates the pages and your own
> page_free hook.
Sure, the mlx5 driver already has a specialized alloctor for it's BAR
pages.
> I also don't expect this to be going upstream in the near term so don't
> get too excited about using it.
I don't know, it is actually not that horrible, the GUP and IOMMU
related changes are simpler than I expected
Jason
_______________________________________________
Linux-nvme mailing list
Linux-nvme@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-nvme
WARNING: multiple messages have this Message-ID (diff)
From: Jason Gunthorpe <jgg@ziepe.ca>
To: Logan Gunthorpe <logang@deltatee.com>
Cc: "Christian König" <christian.koenig@amd.com>,
linux-pci@vger.kernel.org,
"Daniel Vetter" <daniel.vetter@ffwll.ch>,
"Ira Weiny" <iweiny@intel.com>,
linux-kernel@vger.kernel.org, linux-nvme@lists.infradead.org,
"Stephen Bates" <sbates@raithlin.com>,
linux-block@vger.kernel.org, linux-mm@kvack.org,
iommu@lists.linux-foundation.org,
"Matthew Wilcox" <willy@infradead.org>,
"John Hubbard" <jhubbard@nvidia.com>,
"Dan Williams" <dan.j.williams@intel.com>,
"Christoph Hellwig" <hch@lst.de>
Subject: Re: [RFC PATCH 14/15] PCI/P2PDMA: Introduce pci_mmap_p2pmem()
Date: Fri, 6 Nov 2020 15:30:24 -0400 [thread overview]
Message-ID: <20201106193024.GW36674@ziepe.ca> (raw)
In-Reply-To: <09885400-36f8-bc1d-27f0-a8adcf6104d4@deltatee.com>
On Fri, Nov 06, 2020 at 11:20:05AM -0700, Logan Gunthorpe wrote:
>
>
> On 2020-11-06 11:09 a.m., Jason Gunthorpe wrote:
> >> Ah, hmm, yes. I guess the pages have to be hooked and returned to the
> >> genalloc through free_devmap_managed_page().
> >
> > That sounds about right, but in this case it doesn't need the VMA
> > operations.
> >
> >> Seems like it might be doable... but it will complicate things for
> >> users that don't want to use the genpool (though no such users exist
> >> upstream).
> >
> > I would like to use this stuff in RDMA pretty much immediately and the
> > genpool is harmful for those cases, so please don't make decisions
> > that are tying thing to genpool
>
> I certainly can't make decisions for code that isn't currently
> upstream.
The rdma drivers are all upstream, what are you thinking about?
> Ultimately, if you aren't using the genpool you will have to implement
> your own mmap operation that somehow allocates the pages and your own
> page_free hook.
Sure, the mlx5 driver already has a specialized alloctor for it's BAR
pages.
> I also don't expect this to be going upstream in the near term so don't
> get too excited about using it.
I don't know, it is actually not that horrible, the GUP and IOMMU
related changes are simpler than I expected
Jason
_______________________________________________
iommu mailing list
iommu@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/iommu
next prev parent reply other threads:[~2020-11-06 19:30 UTC|newest]
Thread overview: 126+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-06 17:00 [RFC PATCH 00/15] Userspace P2PDMA with O_DIRECT NVMe devices Logan Gunthorpe
2020-11-06 17:00 ` Logan Gunthorpe
2020-11-06 17:00 ` Logan Gunthorpe
2020-11-06 17:00 ` [RFC PATCH 01/15] PCI/P2PDMA: Don't sleep in upstream_bridge_distance_warn() Logan Gunthorpe
2020-11-06 17:00 ` Logan Gunthorpe
2020-11-06 17:00 ` Logan Gunthorpe
2020-11-09 9:12 ` Christoph Hellwig
2020-11-09 9:12 ` Christoph Hellwig
2020-11-09 9:12 ` Christoph Hellwig
2020-11-06 17:00 ` [RFC PATCH 02/15] PCI/P2PDMA: Attempt to set map_type if it has not been set Logan Gunthorpe
2020-11-06 17:00 ` Logan Gunthorpe
2020-11-06 17:00 ` Logan Gunthorpe
2020-11-06 17:00 ` [RFC PATCH 03/15] PCI/P2PDMA: Introduce pci_p2pdma_should_map_bus() and pci_p2pdma_bus_offset() Logan Gunthorpe
2020-11-06 17:00 ` Logan Gunthorpe
2020-11-06 17:00 ` Logan Gunthorpe
2020-11-10 23:25 ` Bjorn Helgaas
2020-11-10 23:25 ` Bjorn Helgaas
2020-11-10 23:25 ` Bjorn Helgaas
2020-11-10 23:42 ` Logan Gunthorpe
2020-11-10 23:42 ` Logan Gunthorpe
2020-11-10 23:42 ` Logan Gunthorpe
2020-11-06 17:00 ` [RFC PATCH 04/15] lib/scatterlist: Add flag for indicating P2PDMA segments in an SGL Logan Gunthorpe
2020-11-06 17:00 ` Logan Gunthorpe
2020-11-06 17:00 ` Logan Gunthorpe
2020-11-09 9:12 ` Christoph Hellwig
2020-11-09 9:12 ` Christoph Hellwig
2020-11-09 9:12 ` Christoph Hellwig
2020-11-09 14:02 ` Robin Murphy
2020-11-09 14:02 ` Robin Murphy
2020-11-09 14:02 ` Robin Murphy
2020-11-09 16:47 ` Logan Gunthorpe
2020-11-09 16:47 ` Logan Gunthorpe
2020-11-09 16:47 ` Logan Gunthorpe
2020-12-10 1:22 ` Dan Williams
2020-12-10 1:22 ` Dan Williams
2020-12-10 1:22 ` Dan Williams
2020-12-10 2:06 ` Logan Gunthorpe
2020-12-10 2:06 ` Logan Gunthorpe
2020-12-10 2:06 ` Logan Gunthorpe
2020-12-10 4:04 ` Dan Williams
2020-12-10 4:04 ` Dan Williams
2020-12-10 4:04 ` Dan Williams
2020-12-10 16:44 ` Logan Gunthorpe
2020-12-10 16:44 ` Logan Gunthorpe
2020-12-10 16:44 ` Logan Gunthorpe
2020-11-06 17:00 ` [RFC PATCH 05/15] dma-direct: Support PCI P2PDMA pages in dma-direct map_sg Logan Gunthorpe
2020-11-06 17:00 ` Logan Gunthorpe
2020-11-06 17:00 ` Logan Gunthorpe
2020-11-06 17:00 ` [RFC PATCH 06/15] dma-mapping: Add flags to dma_map_ops to indicate PCI P2PDMA support Logan Gunthorpe
2020-11-06 17:00 ` Logan Gunthorpe
2020-11-06 17:00 ` Logan Gunthorpe
2020-11-06 17:00 ` [RFC PATCH 07/15] iommu/dma: Support PCI P2PDMA pages in dma-iommu map_sg Logan Gunthorpe
2020-11-06 17:00 ` Logan Gunthorpe
2020-11-06 17:00 ` Logan Gunthorpe
2020-11-06 17:00 ` [RFC PATCH 08/15] nvme-pci: Check DMA ops when indicating support for PCI P2PDMA Logan Gunthorpe
2020-11-06 17:00 ` Logan Gunthorpe
2020-11-06 17:00 ` Logan Gunthorpe
2020-11-06 17:00 ` [RFC PATCH 09/15] nvme-pci: Convert to using dma_map_sg for p2pdma pages Logan Gunthorpe
2020-11-06 17:00 ` Logan Gunthorpe
2020-11-06 17:00 ` Logan Gunthorpe
2020-11-06 17:00 ` [RFC PATCH 10/15] mm: Introduce FOLL_PCI_P2PDMA to gate getting PCI P2PDMA pages Logan Gunthorpe
2020-11-06 17:00 ` Logan Gunthorpe
2020-11-06 17:00 ` Logan Gunthorpe
2020-11-06 17:00 ` [RFC PATCH 11/15] iov_iter: Introduce iov_iter_get_pages_[alloc_]flags() Logan Gunthorpe
2020-11-06 17:00 ` Logan Gunthorpe
2020-11-06 17:00 ` Logan Gunthorpe
2020-11-06 17:00 ` [RFC PATCH 12/15] block: Set FOLL_PCI_P2PDMA in __bio_iov_iter_get_pages() Logan Gunthorpe
2020-11-06 17:00 ` Logan Gunthorpe
2020-11-06 17:00 ` Logan Gunthorpe
2020-11-06 17:00 ` [RFC PATCH 13/15] block: Set FOLL_PCI_P2PDMA in bio_map_user_iov() Logan Gunthorpe
2020-11-06 17:00 ` Logan Gunthorpe
2020-11-06 17:00 ` Logan Gunthorpe
2020-11-06 17:00 ` [RFC PATCH 14/15] PCI/P2PDMA: Introduce pci_mmap_p2pmem() Logan Gunthorpe
2020-11-06 17:00 ` Logan Gunthorpe
2020-11-06 17:00 ` Logan Gunthorpe
2020-11-06 17:22 ` Jason Gunthorpe
2020-11-06 17:22 ` Jason Gunthorpe
2020-11-06 17:22 ` Jason Gunthorpe
2020-11-06 17:28 ` Logan Gunthorpe
2020-11-06 17:28 ` Logan Gunthorpe
2020-11-06 17:28 ` Logan Gunthorpe
2020-11-06 17:42 ` Jason Gunthorpe
2020-11-06 17:42 ` Jason Gunthorpe
2020-11-06 17:42 ` Jason Gunthorpe
2020-11-06 17:53 ` Logan Gunthorpe
2020-11-06 17:53 ` Logan Gunthorpe
2020-11-06 17:53 ` Logan Gunthorpe
2020-11-06 18:09 ` Jason Gunthorpe
2020-11-06 18:09 ` Jason Gunthorpe
2020-11-06 18:09 ` Jason Gunthorpe
2020-11-06 18:20 ` Logan Gunthorpe
2020-11-06 18:20 ` Logan Gunthorpe
2020-11-06 18:20 ` Logan Gunthorpe
2020-11-06 19:30 ` Jason Gunthorpe [this message]
2020-11-06 19:30 ` Jason Gunthorpe
2020-11-06 19:30 ` Jason Gunthorpe
2020-11-06 19:44 ` Logan Gunthorpe
2020-11-06 19:44 ` Logan Gunthorpe
2020-11-06 19:44 ` Logan Gunthorpe
2020-11-06 19:53 ` Jason Gunthorpe
2020-11-06 19:53 ` Jason Gunthorpe
2020-11-06 19:53 ` Jason Gunthorpe
2020-11-06 20:03 ` Logan Gunthorpe
2020-11-06 20:03 ` Logan Gunthorpe
2020-11-06 20:03 ` Logan Gunthorpe
2020-11-07 0:14 ` Jason Gunthorpe
2020-11-07 0:14 ` Jason Gunthorpe
2020-11-07 0:14 ` Jason Gunthorpe
2020-11-07 2:50 ` Logan Gunthorpe
2020-11-07 2:50 ` Logan Gunthorpe
2020-11-07 2:50 ` Logan Gunthorpe
2020-11-06 17:00 ` [RFC PATCH 15/15] nvme-pci: Allow mmaping the CMB in userspace Logan Gunthorpe
2020-11-06 17:00 ` Logan Gunthorpe
2020-11-06 17:00 ` Logan Gunthorpe
2020-11-06 17:39 ` Jason Gunthorpe
2020-11-06 17:39 ` Jason Gunthorpe
2020-11-06 17:39 ` Jason Gunthorpe
2020-11-06 17:43 ` Logan Gunthorpe
2020-11-06 17:43 ` Logan Gunthorpe
2020-11-06 17:43 ` Logan Gunthorpe
2020-11-09 15:03 ` Keith Busch
2020-11-09 15:03 ` Keith Busch
2020-11-09 15:03 ` Keith Busch
2020-11-09 16:50 ` Logan Gunthorpe
2020-11-09 16:50 ` Logan Gunthorpe
2020-11-09 16:50 ` Logan Gunthorpe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201106193024.GW36674@ziepe.ca \
--to=jgg@ziepe.ca \
--cc=christian.koenig@amd.com \
--cc=dan.j.williams@intel.com \
--cc=daniel.vetter@ffwll.ch \
--cc=ddutile@redhat.com \
--cc=hch@lst.de \
--cc=iommu@lists.linux-foundation.org \
--cc=iweiny@intel.com \
--cc=jhubbard@nvidia.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux-nvme@lists.infradead.org \
--cc=linux-pci@vger.kernel.org \
--cc=logang@deltatee.com \
--cc=sbates@raithlin.com \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.