* [PATCH] driver core: export device_is_bound() to fix build failure
@ 2020-11-06 15:37 Sudip Mukherjee
2020-11-07 9:21 ` Greg Kroah-Hartman
2020-11-09 8:19 ` Christoph Hellwig
0 siblings, 2 replies; 3+ messages in thread
From: Sudip Mukherjee @ 2020-11-06 15:37 UTC (permalink / raw)
To: Greg Kroah-Hartman, Rafael J . Wysocki; +Cc: linux-kernel, Sudip Mukherjee
When CONFIG_MXC_CLK_SCU is configured as 'm' the build fails as it
is unable to find device_is_bound(). The error being:
ERROR: modpost: "device_is_bound" [drivers/clk/imx/clk-imx-scu.ko]
undefined!
Export the symbol so that the module finds it.
Signed-off-by: Sudip Mukherjee <sudipm.mukherjee@gmail.com>
---
drivers/base/dd.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/base/dd.c b/drivers/base/dd.c
index 148e81969e04..a796a57e5efb 100644
--- a/drivers/base/dd.c
+++ b/drivers/base/dd.c
@@ -353,6 +353,7 @@ bool device_is_bound(struct device *dev)
{
return dev->p && klist_node_attached(&dev->p->knode_driver);
}
+EXPORT_SYMBOL(device_is_bound);
static void driver_bound(struct device *dev)
{
--
2.11.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] driver core: export device_is_bound() to fix build failure
2020-11-06 15:37 [PATCH] driver core: export device_is_bound() to fix build failure Sudip Mukherjee
@ 2020-11-07 9:21 ` Greg Kroah-Hartman
2020-11-09 8:19 ` Christoph Hellwig
1 sibling, 0 replies; 3+ messages in thread
From: Greg Kroah-Hartman @ 2020-11-07 9:21 UTC (permalink / raw)
To: Sudip Mukherjee; +Cc: Rafael J . Wysocki, linux-kernel
On Fri, Nov 06, 2020 at 03:37:44PM +0000, Sudip Mukherjee wrote:
> When CONFIG_MXC_CLK_SCU is configured as 'm' the build fails as it
> is unable to find device_is_bound(). The error being:
> ERROR: modpost: "device_is_bound" [drivers/clk/imx/clk-imx-scu.ko]
> undefined!
>
> Export the symbol so that the module finds it.
>
> Signed-off-by: Sudip Mukherjee <sudipm.mukherjee@gmail.com>
> ---
What patch caused this problem? Can you resend this with a "Fixes:"
line so we know where to queue it up to?
thanks,
greg k-h
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] driver core: export device_is_bound() to fix build failure
2020-11-06 15:37 [PATCH] driver core: export device_is_bound() to fix build failure Sudip Mukherjee
2020-11-07 9:21 ` Greg Kroah-Hartman
@ 2020-11-09 8:19 ` Christoph Hellwig
1 sibling, 0 replies; 3+ messages in thread
From: Christoph Hellwig @ 2020-11-09 8:19 UTC (permalink / raw)
To: Sudip Mukherjee; +Cc: Greg Kroah-Hartman, Rafael J . Wysocki, linux-kernel
On Fri, Nov 06, 2020 at 03:37:44PM +0000, Sudip Mukherjee wrote:
> When CONFIG_MXC_CLK_SCU is configured as 'm' the build fails as it
> is unable to find device_is_bound(). The error being:
> ERROR: modpost: "device_is_bound" [drivers/clk/imx/clk-imx-scu.ko]
> undefined!
>
> Export the symbol so that the module finds it.
>
> Signed-off-by: Sudip Mukherjee <sudipm.mukherjee@gmail.com>
> ---
>
> drivers/base/dd.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/base/dd.c b/drivers/base/dd.c
> index 148e81969e04..a796a57e5efb 100644
> --- a/drivers/base/dd.c
> +++ b/drivers/base/dd.c
> @@ -353,6 +353,7 @@ bool device_is_bound(struct device *dev)
> {
> return dev->p && klist_node_attached(&dev->p->knode_driver);
> }
> +EXPORT_SYMBOL(device_is_bound);
Everything else in this file uses EXPORT_SYMBOL_GPL, so I don't see why
this would be special.
That being said a good rationale of why it is a good idea to use this in
drivers is also required.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-11-09 8:19 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-11-06 15:37 [PATCH] driver core: export device_is_bound() to fix build failure Sudip Mukherjee
2020-11-07 9:21 ` Greg Kroah-Hartman
2020-11-09 8:19 ` Christoph Hellwig
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.