* [MPTCP] [bug report] mptcp: retransmit ADD_ADDR when timeout
@ 2020-11-09 9:33 Dan Carpenter
0 siblings, 0 replies; only message in thread
From: Dan Carpenter @ 2020-11-09 9:33 UTC (permalink / raw)
To: mptcp
[-- Attachment #1: Type: text/plain, Size: 740 bytes --]
Hello Geliang Tang,
This is a semi-automatic email about new static checker warnings.
The patch 00cfd77b9063: "mptcp: retransmit ADD_ADDR when timeout"
from Sep 24, 2020, leads to the following Smatch complaint:
net/mptcp/pm_netlink.c:213 mptcp_pm_add_timer()
warn: variable dereferenced before check 'msk' (see line 208)
net/mptcp/pm_netlink.c
207 struct mptcp_sock *msk = entry->sock;
208 struct sock *sk = (struct sock *)msk;
209 struct net *net = sock_net(sk);
^^
"msk" dereferenced here.
210
211 pr_debug("msk=%p", msk);
212
213 if (!msk)
^^^^
Too late.
214 return;
215
regards,
dan carpenter
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2020-11-09 9:33 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-11-09 9:33 [MPTCP] [bug report] mptcp: retransmit ADD_ADDR when timeout Dan Carpenter
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.