* [PATCH net-next] net: phy: microchip_t1: Don't set .config_aneg
@ 2020-11-09 1:16 Jisheng Zhang
2020-11-09 17:36 ` Andrew Lunn
0 siblings, 1 reply; 3+ messages in thread
From: Jisheng Zhang @ 2020-11-09 1:16 UTC (permalink / raw)
To: Andrew Lunn, Florian Fainelli, Heiner Kallweit, David S. Miller
Cc: netdev, linux-kernel
The .config_aneg in microchip_t1 is genphy_config_aneg, so it's not
needed, because the phy core will call genphy_config_aneg() if the
.config_aneg is NULL.
Signed-off-by: Jisheng Zhang <Jisheng.Zhang@synaptics.com>
---
drivers/net/phy/microchip_t1.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/net/phy/microchip_t1.c b/drivers/net/phy/microchip_t1.c
index fed3e395f18e..1c9900162619 100644
--- a/drivers/net/phy/microchip_t1.c
+++ b/drivers/net/phy/microchip_t1.c
@@ -219,7 +219,6 @@ static struct phy_driver microchip_t1_phy_driver[] = {
.features = PHY_BASIC_T1_FEATURES,
.config_init = lan87xx_config_init,
- .config_aneg = genphy_config_aneg,
.ack_interrupt = lan87xx_phy_ack_interrupt,
.config_intr = lan87xx_phy_config_intr,
--
2.29.2
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH net-next] net: phy: microchip_t1: Don't set .config_aneg
2020-11-09 1:16 [PATCH net-next] net: phy: microchip_t1: Don't set .config_aneg Jisheng Zhang
@ 2020-11-09 17:36 ` Andrew Lunn
2020-11-10 1:41 ` Jakub Kicinski
0 siblings, 1 reply; 3+ messages in thread
From: Andrew Lunn @ 2020-11-09 17:36 UTC (permalink / raw)
To: Jisheng Zhang
Cc: Florian Fainelli, Heiner Kallweit, David S. Miller, netdev, linux-kernel
On Mon, Nov 09, 2020 at 09:16:05AM +0800, Jisheng Zhang wrote:
> The .config_aneg in microchip_t1 is genphy_config_aneg, so it's not
> needed, because the phy core will call genphy_config_aneg() if the
> .config_aneg is NULL.
>
> Signed-off-by: Jisheng Zhang <Jisheng.Zhang@synaptics.com>
Reviewed-by: Andrew Lunn <andrew@lunn.ch>
Andrew
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH net-next] net: phy: microchip_t1: Don't set .config_aneg
2020-11-09 17:36 ` Andrew Lunn
@ 2020-11-10 1:41 ` Jakub Kicinski
0 siblings, 0 replies; 3+ messages in thread
From: Jakub Kicinski @ 2020-11-10 1:41 UTC (permalink / raw)
To: Andrew Lunn
Cc: Jisheng Zhang, Florian Fainelli, Heiner Kallweit,
David S. Miller, netdev, linux-kernel
On Mon, 9 Nov 2020 18:36:22 +0100 Andrew Lunn wrote:
> On Mon, Nov 09, 2020 at 09:16:05AM +0800, Jisheng Zhang wrote:
> > The .config_aneg in microchip_t1 is genphy_config_aneg, so it's not
> > needed, because the phy core will call genphy_config_aneg() if the
> > .config_aneg is NULL.
> >
> > Signed-off-by: Jisheng Zhang <Jisheng.Zhang@synaptics.com>
>
> Reviewed-by: Andrew Lunn <andrew@lunn.ch>
Applied, thanks!
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-11-10 1:41 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-11-09 1:16 [PATCH net-next] net: phy: microchip_t1: Don't set .config_aneg Jisheng Zhang
2020-11-09 17:36 ` Andrew Lunn
2020-11-10 1:41 ` Jakub Kicinski
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.