From: Roman Gushchin <guro@fb.com>
To: Hui Su <sh_def@163.com>
Cc: <akpm@linux-foundation.org>, <hannes@cmpxchg.org>,
<mhocko@kernel.org>, <vdavydov.dev@gmail.com>,
<shakeelb@google.com>, <laoar.shao@gmail.com>,
<chris@chrisdown.name>, <linux-kernel@vger.kernel.org>,
<cgroups@vger.kernel.org>, <linux-mm@kvack.org>
Subject: Re: [PATCH v2] mm/memcontrol:rewrite mem_cgroup_page_lruvec()
Date: Mon, 9 Nov 2020 10:00:21 -0800 [thread overview]
Message-ID: <20201109180021.GC2285866@carbon.dhcp.thefacebook.com> (raw)
In-Reply-To: <20201108143731.GA74138@rlk>
On Sun, Nov 08, 2020 at 10:37:31PM +0800, Hui Su wrote:
> mem_cgroup_page_lruvec() in memcontrol.c and
> mem_cgroup_lruvec() in memcontrol.h is very similar
> except for the param(page and memcg) which also can be
> convert to each other.
>
> So rewrite mem_cgroup_page_lruvec() with mem_cgroup_lruvec().
>
> v1->v2:
> use page_memcg() instead of 'page->mem_cgroup'.
>
> Acked-by: Michal Hocko <mhocko@suse.com>
> Acked-by: Johannes Weiner <hannes@cmpxchg.org>
> Reviewed-by: Shakeel Butt <shakeelb@google.com>
> Signed-off-by: Hui Su <sh_def@163.com>
Acked-by: Roman Gushchin <guro@fb.com>
Thanks!
WARNING: multiple messages have this Message-ID (diff)
From: Roman Gushchin <guro@fb.com>
To: Hui Su <sh_def@163.com>
Cc: akpm@linux-foundation.org, hannes@cmpxchg.org, mhocko@kernel.org,
vdavydov.dev@gmail.com, shakeelb@google.com,
laoar.shao@gmail.com, chris@chrisdown.name,
linux-kernel@vger.kernel.org, cgroups@vger.kernel.org,
linux-mm@kvack.org
Subject: Re: [PATCH v2] mm/memcontrol:rewrite mem_cgroup_page_lruvec()
Date: Mon, 9 Nov 2020 10:00:21 -0800 [thread overview]
Message-ID: <20201109180021.GC2285866@carbon.dhcp.thefacebook.com> (raw)
In-Reply-To: <20201108143731.GA74138@rlk>
On Sun, Nov 08, 2020 at 10:37:31PM +0800, Hui Su wrote:
> mem_cgroup_page_lruvec() in memcontrol.c and
> mem_cgroup_lruvec() in memcontrol.h is very similar
> except for the param(page and memcg) which also can be
> convert to each other.
>
> So rewrite mem_cgroup_page_lruvec() with mem_cgroup_lruvec().
>
> v1->v2:
> use page_memcg() instead of 'page->mem_cgroup'.
>
> Acked-by: Michal Hocko <mhocko@suse.com>
> Acked-by: Johannes Weiner <hannes@cmpxchg.org>
> Reviewed-by: Shakeel Butt <shakeelb@google.com>
> Signed-off-by: Hui Su <sh_def@163.com>
Acked-by: Roman Gushchin <guro@fb.com>
Thanks!
next prev parent reply other threads:[~2020-11-09 18:00 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-08 14:37 [PATCH v2] mm/memcontrol:rewrite mem_cgroup_page_lruvec() Hui Su
2020-11-08 14:37 ` Hui Su
2020-11-09 18:00 ` Roman Gushchin [this message]
2020-11-09 18:00 ` Roman Gushchin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201109180021.GC2285866@carbon.dhcp.thefacebook.com \
--to=guro@fb.com \
--cc=akpm@linux-foundation.org \
--cc=cgroups@vger.kernel.org \
--cc=chris@chrisdown.name \
--cc=hannes@cmpxchg.org \
--cc=laoar.shao@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mhocko@kernel.org \
--cc=sh_def@163.com \
--cc=shakeelb@google.com \
--cc=vdavydov.dev@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.