All of lore.kernel.org
 help / color / mirror / Atom feed
From: Lee Jones <lee.jones@linaro.org>
To: lee.jones@linaro.org
Cc: linux-kernel@vger.kernel.org,
	"Alex Deucher" <alexander.deucher@amd.com>,
	"Christian König" <christian.koenig@amd.com>,
	"David Airlie" <airlied@linux.ie>,
	"Daniel Vetter" <daniel@ffwll.ch>,
	"Sumit Semwal" <sumit.semwal@linaro.org>,
	"report to" <xorg-driver-ati@lists.x.org>,
	amd-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org,
	linux-media@vger.kernel.org, linaro-mm-sig@lists.linaro.org
Subject: [PATCH 18/20] drm/radeon/radeon_display: Fix function doc formatting and missing param issues
Date: Mon,  9 Nov 2020 21:18:53 +0000	[thread overview]
Message-ID: <20201109211855.3340030-19-lee.jones@linaro.org> (raw)
In-Reply-To: <20201109211855.3340030-1-lee.jones@linaro.org>

Fixes the following W=1 kernel build warning(s):

 drivers/gpu/drm/radeon/radeon_display.c:264: warning: Function parameter or member '__work' not described in 'radeon_unpin_work_func'
 drivers/gpu/drm/radeon/radeon_display.c:406: warning: Function parameter or member '__work' not described in 'radeon_flip_work_func'
 drivers/gpu/drm/radeon/radeon_display.c:956: warning: Function parameter or member 'freq' not described in 'radeon_compute_pll_avivo'
 drivers/gpu/drm/radeon/radeon_display.c:956: warning: Function parameter or member 'fb_div_p' not described in 'radeon_compute_pll_avivo'
 drivers/gpu/drm/radeon/radeon_display.c:956: warning: Function parameter or member 'frac_fb_div_p' not described in 'radeon_compute_pll_avivo'
 drivers/gpu/drm/radeon/radeon_display.c:956: warning: Function parameter or member 'ref_div_p' not described in 'radeon_compute_pll_avivo'
 drivers/gpu/drm/radeon/radeon_display.c:956: warning: Function parameter or member 'post_div_p' not described in 'radeon_compute_pll_avivo'

Cc: Alex Deucher <alexander.deucher@amd.com>
Cc: "Christian König" <christian.koenig@amd.com>
Cc: David Airlie <airlied@linux.ie>
Cc: Daniel Vetter <daniel@ffwll.ch>
Cc: Sumit Semwal <sumit.semwal@linaro.org>
Cc: report to <xorg-driver-ati@lists.x.org>
Cc: amd-gfx@lists.freedesktop.org
Cc: dri-devel@lists.freedesktop.org
Cc: linux-media@vger.kernel.org
Cc: linaro-mm-sig@lists.linaro.org
Signed-off-by: Lee Jones <lee.jones@linaro.org>
---
 drivers/gpu/drm/radeon/radeon_display.c | 13 +++++++------
 1 file changed, 7 insertions(+), 6 deletions(-)

diff --git a/drivers/gpu/drm/radeon/radeon_display.c b/drivers/gpu/drm/radeon/radeon_display.c
index 78fceedfd9255..eb0d4cb95f0a6 100644
--- a/drivers/gpu/drm/radeon/radeon_display.c
+++ b/drivers/gpu/drm/radeon/radeon_display.c
@@ -256,7 +256,7 @@ static void radeon_crtc_destroy(struct drm_crtc *crtc)
 /**
  * radeon_unpin_work_func - unpin old buffer object
  *
- * @__work - kernel work item
+ * @__work: kernel work item
  *
  * Unpin the old frame buffer object outside of the interrupt handler
  */
@@ -398,7 +398,7 @@ void radeon_crtc_handle_flip(struct radeon_device *rdev, int crtc_id)
 /**
  * radeon_flip_work_func - page flip framebuffer
  *
- * @work - kernel work item
+ * @__work: kernel work item
  *
  * Wait for the buffer object to become idle and do the actual page flip
  */
@@ -937,11 +937,12 @@ static void avivo_get_fb_ref_div(unsigned nom, unsigned den, unsigned post_div,
  * radeon_compute_pll_avivo - compute PLL paramaters
  *
  * @pll: information about the PLL
+ * @freq: target frequency
  * @dot_clock_p: resulting pixel clock
- * fb_div_p: resulting feedback divider
- * frac_fb_div_p: fractional part of the feedback divider
- * ref_div_p: resulting reference divider
- * post_div_p: resulting reference divider
+ * @fb_div_p: resulting feedback divider
+ * @frac_fb_div_p: fractional part of the feedback divider
+ * @ref_div_p: resulting reference divider
+ * @post_div_p: resulting reference divider
  *
  * Try to calculate the PLL parameters to generate the given frequency:
  * dot_clock = (ref_freq * feedback_div) / (ref_div * post_div)
-- 
2.25.1


WARNING: multiple messages have this Message-ID (diff)
From: Lee Jones <lee.jones@linaro.org>
To: lee.jones@linaro.org
Cc: "David Airlie" <airlied@linux.ie>,
	linux-kernel@vger.kernel.org, amd-gfx@lists.freedesktop.org,
	"Christian König" <christian.koenig@amd.com>,
	linaro-mm-sig@lists.linaro.org, dri-devel@lists.freedesktop.org,
	"Alex Deucher" <alexander.deucher@amd.com>,
	"report to" <xorg-driver-ati@lists.x.org>,
	linux-media@vger.kernel.org
Subject: [PATCH 18/20] drm/radeon/radeon_display: Fix function doc formatting and missing param issues
Date: Mon,  9 Nov 2020 21:18:53 +0000	[thread overview]
Message-ID: <20201109211855.3340030-19-lee.jones@linaro.org> (raw)
In-Reply-To: <20201109211855.3340030-1-lee.jones@linaro.org>

Fixes the following W=1 kernel build warning(s):

 drivers/gpu/drm/radeon/radeon_display.c:264: warning: Function parameter or member '__work' not described in 'radeon_unpin_work_func'
 drivers/gpu/drm/radeon/radeon_display.c:406: warning: Function parameter or member '__work' not described in 'radeon_flip_work_func'
 drivers/gpu/drm/radeon/radeon_display.c:956: warning: Function parameter or member 'freq' not described in 'radeon_compute_pll_avivo'
 drivers/gpu/drm/radeon/radeon_display.c:956: warning: Function parameter or member 'fb_div_p' not described in 'radeon_compute_pll_avivo'
 drivers/gpu/drm/radeon/radeon_display.c:956: warning: Function parameter or member 'frac_fb_div_p' not described in 'radeon_compute_pll_avivo'
 drivers/gpu/drm/radeon/radeon_display.c:956: warning: Function parameter or member 'ref_div_p' not described in 'radeon_compute_pll_avivo'
 drivers/gpu/drm/radeon/radeon_display.c:956: warning: Function parameter or member 'post_div_p' not described in 'radeon_compute_pll_avivo'

Cc: Alex Deucher <alexander.deucher@amd.com>
Cc: "Christian König" <christian.koenig@amd.com>
Cc: David Airlie <airlied@linux.ie>
Cc: Daniel Vetter <daniel@ffwll.ch>
Cc: Sumit Semwal <sumit.semwal@linaro.org>
Cc: report to <xorg-driver-ati@lists.x.org>
Cc: amd-gfx@lists.freedesktop.org
Cc: dri-devel@lists.freedesktop.org
Cc: linux-media@vger.kernel.org
Cc: linaro-mm-sig@lists.linaro.org
Signed-off-by: Lee Jones <lee.jones@linaro.org>
---
 drivers/gpu/drm/radeon/radeon_display.c | 13 +++++++------
 1 file changed, 7 insertions(+), 6 deletions(-)

diff --git a/drivers/gpu/drm/radeon/radeon_display.c b/drivers/gpu/drm/radeon/radeon_display.c
index 78fceedfd9255..eb0d4cb95f0a6 100644
--- a/drivers/gpu/drm/radeon/radeon_display.c
+++ b/drivers/gpu/drm/radeon/radeon_display.c
@@ -256,7 +256,7 @@ static void radeon_crtc_destroy(struct drm_crtc *crtc)
 /**
  * radeon_unpin_work_func - unpin old buffer object
  *
- * @__work - kernel work item
+ * @__work: kernel work item
  *
  * Unpin the old frame buffer object outside of the interrupt handler
  */
@@ -398,7 +398,7 @@ void radeon_crtc_handle_flip(struct radeon_device *rdev, int crtc_id)
 /**
  * radeon_flip_work_func - page flip framebuffer
  *
- * @work - kernel work item
+ * @__work: kernel work item
  *
  * Wait for the buffer object to become idle and do the actual page flip
  */
@@ -937,11 +937,12 @@ static void avivo_get_fb_ref_div(unsigned nom, unsigned den, unsigned post_div,
  * radeon_compute_pll_avivo - compute PLL paramaters
  *
  * @pll: information about the PLL
+ * @freq: target frequency
  * @dot_clock_p: resulting pixel clock
- * fb_div_p: resulting feedback divider
- * frac_fb_div_p: fractional part of the feedback divider
- * ref_div_p: resulting reference divider
- * post_div_p: resulting reference divider
+ * @fb_div_p: resulting feedback divider
+ * @frac_fb_div_p: fractional part of the feedback divider
+ * @ref_div_p: resulting reference divider
+ * @post_div_p: resulting reference divider
  *
  * Try to calculate the PLL parameters to generate the given frequency:
  * dot_clock = (ref_freq * feedback_div) / (ref_div * post_div)
-- 
2.25.1

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

WARNING: multiple messages have this Message-ID (diff)
From: Lee Jones <lee.jones@linaro.org>
To: lee.jones@linaro.org
Cc: "David Airlie" <airlied@linux.ie>,
	linux-kernel@vger.kernel.org, amd-gfx@lists.freedesktop.org,
	"Christian König" <christian.koenig@amd.com>,
	linaro-mm-sig@lists.linaro.org, dri-devel@lists.freedesktop.org,
	"Daniel Vetter" <daniel@ffwll.ch>,
	"Alex Deucher" <alexander.deucher@amd.com>,
	"report to" <xorg-driver-ati@lists.x.org>,
	"Sumit Semwal" <sumit.semwal@linaro.org>,
	linux-media@vger.kernel.org
Subject: [PATCH 18/20] drm/radeon/radeon_display: Fix function doc formatting and missing param issues
Date: Mon,  9 Nov 2020 21:18:53 +0000	[thread overview]
Message-ID: <20201109211855.3340030-19-lee.jones@linaro.org> (raw)
In-Reply-To: <20201109211855.3340030-1-lee.jones@linaro.org>

Fixes the following W=1 kernel build warning(s):

 drivers/gpu/drm/radeon/radeon_display.c:264: warning: Function parameter or member '__work' not described in 'radeon_unpin_work_func'
 drivers/gpu/drm/radeon/radeon_display.c:406: warning: Function parameter or member '__work' not described in 'radeon_flip_work_func'
 drivers/gpu/drm/radeon/radeon_display.c:956: warning: Function parameter or member 'freq' not described in 'radeon_compute_pll_avivo'
 drivers/gpu/drm/radeon/radeon_display.c:956: warning: Function parameter or member 'fb_div_p' not described in 'radeon_compute_pll_avivo'
 drivers/gpu/drm/radeon/radeon_display.c:956: warning: Function parameter or member 'frac_fb_div_p' not described in 'radeon_compute_pll_avivo'
 drivers/gpu/drm/radeon/radeon_display.c:956: warning: Function parameter or member 'ref_div_p' not described in 'radeon_compute_pll_avivo'
 drivers/gpu/drm/radeon/radeon_display.c:956: warning: Function parameter or member 'post_div_p' not described in 'radeon_compute_pll_avivo'

Cc: Alex Deucher <alexander.deucher@amd.com>
Cc: "Christian König" <christian.koenig@amd.com>
Cc: David Airlie <airlied@linux.ie>
Cc: Daniel Vetter <daniel@ffwll.ch>
Cc: Sumit Semwal <sumit.semwal@linaro.org>
Cc: report to <xorg-driver-ati@lists.x.org>
Cc: amd-gfx@lists.freedesktop.org
Cc: dri-devel@lists.freedesktop.org
Cc: linux-media@vger.kernel.org
Cc: linaro-mm-sig@lists.linaro.org
Signed-off-by: Lee Jones <lee.jones@linaro.org>
---
 drivers/gpu/drm/radeon/radeon_display.c | 13 +++++++------
 1 file changed, 7 insertions(+), 6 deletions(-)

diff --git a/drivers/gpu/drm/radeon/radeon_display.c b/drivers/gpu/drm/radeon/radeon_display.c
index 78fceedfd9255..eb0d4cb95f0a6 100644
--- a/drivers/gpu/drm/radeon/radeon_display.c
+++ b/drivers/gpu/drm/radeon/radeon_display.c
@@ -256,7 +256,7 @@ static void radeon_crtc_destroy(struct drm_crtc *crtc)
 /**
  * radeon_unpin_work_func - unpin old buffer object
  *
- * @__work - kernel work item
+ * @__work: kernel work item
  *
  * Unpin the old frame buffer object outside of the interrupt handler
  */
@@ -398,7 +398,7 @@ void radeon_crtc_handle_flip(struct radeon_device *rdev, int crtc_id)
 /**
  * radeon_flip_work_func - page flip framebuffer
  *
- * @work - kernel work item
+ * @__work: kernel work item
  *
  * Wait for the buffer object to become idle and do the actual page flip
  */
@@ -937,11 +937,12 @@ static void avivo_get_fb_ref_div(unsigned nom, unsigned den, unsigned post_div,
  * radeon_compute_pll_avivo - compute PLL paramaters
  *
  * @pll: information about the PLL
+ * @freq: target frequency
  * @dot_clock_p: resulting pixel clock
- * fb_div_p: resulting feedback divider
- * frac_fb_div_p: fractional part of the feedback divider
- * ref_div_p: resulting reference divider
- * post_div_p: resulting reference divider
+ * @fb_div_p: resulting feedback divider
+ * @frac_fb_div_p: fractional part of the feedback divider
+ * @ref_div_p: resulting reference divider
+ * @post_div_p: resulting reference divider
  *
  * Try to calculate the PLL parameters to generate the given frequency:
  * dot_clock = (ref_freq * feedback_div) / (ref_div * post_div)
-- 
2.25.1

_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

  parent reply	other threads:[~2020-11-09 21:19 UTC|newest]

Thread overview: 123+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-11-09 21:18 [PATCH 00/20] [Set 3] Rid W=1 warnings from GPU Lee Jones
2020-11-09 21:18 ` Lee Jones
2020-11-09 21:18 ` Lee Jones
2020-11-09 21:18 ` [PATCH 01/20] drm/radeon/radeon_ttm: Place declaration of 'rdev' in same clause as its use Lee Jones
2020-11-09 21:18   ` Lee Jones
2020-11-09 21:18   ` Lee Jones
2020-11-10 22:05   ` Alex Deucher
2020-11-10 22:05     ` Alex Deucher
2020-11-10 22:05     ` Alex Deucher
2020-11-09 21:18 ` [PATCH 02/20] drm/radeon: Move radeon_ttm{init,fini} to shared location Lee Jones
2020-11-09 21:18   ` [PATCH 02/20] drm/radeon: Move radeon_ttm{init, fini} " Lee Jones
2020-11-09 21:18   ` Lee Jones
2020-11-09 21:18 ` [PATCH 03/20] drm/radeon/radeon_fence: Demote some non-conformant kernel-doc headers and fix another Lee Jones
2020-11-09 21:18   ` Lee Jones
2020-11-09 21:18   ` Lee Jones
2020-11-10 22:06   ` Alex Deucher
2020-11-10 22:06     ` Alex Deucher
2020-11-10 22:06     ` Alex Deucher
2020-11-09 21:18 ` [PATCH 04/20] drm/radeon: Move 'radeon_add_legacy_encoder' prototype to shared header Lee Jones
2020-11-09 21:18   ` Lee Jones
2020-11-09 21:18   ` Lee Jones
2020-11-09 21:18 ` [PATCH 05/20] drm/radeon: Move 'radeon_add_legacy_encoder's prototype to shared location Lee Jones
2020-11-09 21:18   ` Lee Jones
2020-11-09 21:18   ` Lee Jones
2020-11-09 21:18 ` [PATCH 06/20] drm/radeon/radeon_connectors: Strip out set but unused variable 'ret' Lee Jones
2020-11-09 21:18   ` Lee Jones
2020-11-09 21:18   ` Lee Jones
2020-11-10 22:08   ` Alex Deucher
2020-11-10 22:08     ` Alex Deucher
2020-11-10 22:08     ` Alex Deucher
2020-11-09 21:18 ` [PATCH 07/20] drm/radeon/radeon_display: Remove unused variable 'mod' Lee Jones
2020-11-09 21:18   ` Lee Jones
2020-11-09 21:18   ` Lee Jones
2020-11-10 22:09   ` Alex Deucher
2020-11-10 22:09     ` Alex Deucher
2020-11-10 22:09     ` Alex Deucher
2020-11-09 21:18 ` [PATCH 08/20] drm/radeon/radeon_i2c: Remove pointless function header Lee Jones
2020-11-09 21:18   ` Lee Jones
2020-11-09 21:18   ` Lee Jones
2020-11-10 22:10   ` Alex Deucher
2020-11-10 22:10     ` Alex Deucher
2020-11-10 22:10     ` Alex Deucher
2020-11-09 21:18 ` [PATCH 09/20] drm/radeon/radeon_irq_kms: Demote non-conformant kernel-doc fix another Lee Jones
2020-11-09 21:18   ` Lee Jones
2020-11-09 21:18   ` Lee Jones
2020-11-10 22:13   ` Alex Deucher
2020-11-10 22:13     ` Alex Deucher
2020-11-10 22:13     ` Alex Deucher
2020-11-09 21:18 ` [PATCH 10/20] drm/radeon/radeon_ring: Add missing function parameters 'rdev' and 'data' Lee Jones
2020-11-09 21:18   ` Lee Jones
2020-11-09 21:18   ` Lee Jones
2020-11-10 22:15   ` Alex Deucher
2020-11-10 22:15     ` Alex Deucher
2020-11-10 22:15     ` Alex Deucher
2020-11-09 21:18 ` [PATCH 11/20] drm/radeon/r600: Strip out set but unused 'tmp' variables Lee Jones
2020-11-09 21:18   ` Lee Jones
2020-11-09 21:18   ` Lee Jones
2020-11-10 22:17   ` Alex Deucher
2020-11-10 22:17     ` Alex Deucher
2020-11-10 22:17     ` Alex Deucher
2020-11-09 21:18 ` [PATCH 12/20] drm/radeon/radeon_cs: Fix a bunch of doc-rot issues Lee Jones
2020-11-09 21:18   ` Lee Jones
2020-11-09 21:18   ` Lee Jones
2020-11-10 22:41   ` Alex Deucher
2020-11-10 22:41     ` Alex Deucher
2020-11-10 22:41     ` Alex Deucher
2020-11-09 21:18 ` [PATCH 13/20] drm/radeon/evergreen: Move 'rv770_set_clk_bypass_mode' prototype to shared location Lee Jones
2020-11-09 21:18   ` Lee Jones
2020-11-09 21:18   ` Lee Jones
2020-11-09 21:18 ` [PATCH 14/20] drm/radeon: Move 'radeon_pm_acpi_event_handler' prototype into shared header Lee Jones
2020-11-09 21:18   ` Lee Jones
2020-11-09 21:18   ` Lee Jones
2020-11-09 21:18 ` [PATCH 15/20] drm/radeon/r600d: Move 'rc600_*' prototypes " Lee Jones
2020-11-09 21:18   ` Lee Jones
2020-11-09 21:18   ` Lee Jones
2020-11-09 22:20   ` Alex Deucher
2020-11-09 22:20     ` Alex Deucher
2020-11-09 22:20     ` Alex Deucher
2020-11-10  7:22     ` Lee Jones
2020-11-10  7:22       ` Lee Jones
2020-11-10  7:22       ` Lee Jones
2020-11-10  9:02       ` Sam Ravnborg
2020-11-10  9:02         ` Sam Ravnborg
2020-11-10  9:02         ` Sam Ravnborg
2020-11-10  9:41         ` Lee Jones
2020-11-10  9:41           ` Lee Jones
2020-11-10  9:41           ` Lee Jones
2020-11-10 20:08           ` Alex Deucher
2020-11-10 20:08             ` Alex Deucher
2020-11-10 20:08             ` Alex Deucher
2020-11-10 21:02             ` Lee Jones
2020-11-10 21:02               ` Lee Jones
2020-11-10 21:02               ` Lee Jones
2020-11-09 21:18 ` [PATCH 16/20] drm/radeon/radeon_audio: Move 'dce3_2_*' prototypes to shared location Lee Jones
2020-11-09 21:18   ` Lee Jones
2020-11-09 21:18   ` Lee Jones
2020-11-09 21:18 ` [PATCH 17/20] drm/radeon/evergreend: Move 'evergreen_*' and 'sumo_*' prototypes out " Lee Jones
2020-11-09 21:18   ` Lee Jones
2020-11-09 21:18   ` Lee Jones
2020-11-09 21:18 ` Lee Jones [this message]
2020-11-09 21:18   ` [PATCH 18/20] drm/radeon/radeon_display: Fix function doc formatting and missing param issues Lee Jones
2020-11-09 21:18   ` Lee Jones
2020-11-10 22:44   ` Alex Deucher
2020-11-10 22:44     ` Alex Deucher
2020-11-10 22:44     ` Alex Deucher
2020-11-09 21:18 ` [PATCH 19/20] drm/radeon/r600: Fix a misnamed parameter description and a formatting issue Lee Jones
2020-11-09 21:18   ` Lee Jones
2020-11-09 21:18   ` Lee Jones
2020-11-10 22:45   ` Alex Deucher
2020-11-10 22:45     ` Alex Deucher
2020-11-10 22:45     ` Alex Deucher
2020-11-09 21:18 ` [PATCH 20/20] drm/radeon/cik: Fix a bunch of function parameter descriptions Lee Jones
2020-11-09 21:18   ` Lee Jones
2020-11-09 21:18   ` Lee Jones
2020-11-10 22:48   ` Alex Deucher
2020-11-10 22:48     ` Alex Deucher
2020-11-10 22:48     ` Alex Deucher
2020-11-09 22:22 ` [PATCH 00/20] [Set 3] Rid W=1 warnings from GPU Alex Deucher
2020-11-09 22:22   ` Alex Deucher
2020-11-09 22:22   ` Alex Deucher
2020-11-10  7:20   ` Lee Jones
2020-11-10  7:20     ` Lee Jones
2020-11-10  7:20     ` Lee Jones

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20201109211855.3340030-19-lee.jones@linaro.org \
    --to=lee.jones@linaro.org \
    --cc=airlied@linux.ie \
    --cc=alexander.deucher@amd.com \
    --cc=amd-gfx@lists.freedesktop.org \
    --cc=christian.koenig@amd.com \
    --cc=daniel@ffwll.ch \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=linaro-mm-sig@lists.linaro.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-media@vger.kernel.org \
    --cc=sumit.semwal@linaro.org \
    --cc=xorg-driver-ati@lists.x.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.