From: Lee Jones <lee.jones@linaro.org> To: Bjorn Andersson <bjorn.andersson@linaro.org> Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Andy Gross <agross@kernel.org>, linux-arm-msm@vger.kernel.org Subject: Re: [PATCH 19/25] soc: qcom: smp2p: Remove unused struct attribute provide another Date: Wed, 11 Nov 2020 07:11:45 +0000 [thread overview] Message-ID: <20201111071145.GM2063125@dell> (raw) In-Reply-To: <20201111052038.GG173948@builder.lan> On Tue, 10 Nov 2020, Bjorn Andersson wrote: > On Tue 03 Nov 09:28 CST 2020, Lee Jones wrote: > > > Fixes the following W=1 kernel build warning(s): > > > > drivers/soc/qcom/smp2p.c:74: warning: Function parameter or member 'flags' not described in 'smp2p_smem_item' > > drivers/soc/qcom/smp2p.c:149: warning: Function parameter or member 'out' not described in 'qcom_smp2p' > > > > Cc: Andy Gross <agross@kernel.org> > > Cc: Bjorn Andersson <bjorn.andersson@linaro.org> > > Cc: linux-arm-msm@vger.kernel.org > > Signed-off-by: Lee Jones <lee.jones@linaro.org> > > --- > > drivers/soc/qcom/smp2p.c | 3 +-- > > 1 file changed, 1 insertion(+), 2 deletions(-) > > > > diff --git a/drivers/soc/qcom/smp2p.c b/drivers/soc/qcom/smp2p.c > > index a9709aae54abb..43df63419c327 100644 > > --- a/drivers/soc/qcom/smp2p.c > > +++ b/drivers/soc/qcom/smp2p.c > > @@ -52,7 +52,6 @@ > > * @remote_pid: processor id of receiving end > > * @total_entries: number of entries - always SMP2P_MAX_ENTRY > > * @valid_entries: number of allocated entries > > - * @flags: > > * @entries: individual communication entries > > * @name: name of the entry > > * @value: content of the entry > > @@ -65,7 +64,6 @@ struct smp2p_smem_item { > > u16 remote_pid; > > u16 total_entries; > > u16 valid_entries; > > - u32 flags; > > This struct describes the data shared between processors in the SoC and > as such these 32 bits are significant. I believe we have an incoming > patch that adds handling of some flag, so let's document it properly > at that time. Sounds reasonable. > I've applied the second half of the patch for now. Thanks. And for the other applied patches too. -- Lee Jones [李琼斯] Senior Technical Lead - Developer Services Linaro.org │ Open source software for Arm SoCs Follow Linaro: Facebook | Twitter | Blog
WARNING: multiple messages have this Message-ID (diff)
From: Lee Jones <lee.jones@linaro.org> To: Bjorn Andersson <bjorn.andersson@linaro.org> Cc: linux-arm-msm@vger.kernel.org, Andy Gross <agross@kernel.org>, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH 19/25] soc: qcom: smp2p: Remove unused struct attribute provide another Date: Wed, 11 Nov 2020 07:11:45 +0000 [thread overview] Message-ID: <20201111071145.GM2063125@dell> (raw) In-Reply-To: <20201111052038.GG173948@builder.lan> On Tue, 10 Nov 2020, Bjorn Andersson wrote: > On Tue 03 Nov 09:28 CST 2020, Lee Jones wrote: > > > Fixes the following W=1 kernel build warning(s): > > > > drivers/soc/qcom/smp2p.c:74: warning: Function parameter or member 'flags' not described in 'smp2p_smem_item' > > drivers/soc/qcom/smp2p.c:149: warning: Function parameter or member 'out' not described in 'qcom_smp2p' > > > > Cc: Andy Gross <agross@kernel.org> > > Cc: Bjorn Andersson <bjorn.andersson@linaro.org> > > Cc: linux-arm-msm@vger.kernel.org > > Signed-off-by: Lee Jones <lee.jones@linaro.org> > > --- > > drivers/soc/qcom/smp2p.c | 3 +-- > > 1 file changed, 1 insertion(+), 2 deletions(-) > > > > diff --git a/drivers/soc/qcom/smp2p.c b/drivers/soc/qcom/smp2p.c > > index a9709aae54abb..43df63419c327 100644 > > --- a/drivers/soc/qcom/smp2p.c > > +++ b/drivers/soc/qcom/smp2p.c > > @@ -52,7 +52,6 @@ > > * @remote_pid: processor id of receiving end > > * @total_entries: number of entries - always SMP2P_MAX_ENTRY > > * @valid_entries: number of allocated entries > > - * @flags: > > * @entries: individual communication entries > > * @name: name of the entry > > * @value: content of the entry > > @@ -65,7 +64,6 @@ struct smp2p_smem_item { > > u16 remote_pid; > > u16 total_entries; > > u16 valid_entries; > > - u32 flags; > > This struct describes the data shared between processors in the SoC and > as such these 32 bits are significant. I believe we have an incoming > patch that adds handling of some flag, so let's document it properly > at that time. Sounds reasonable. > I've applied the second half of the patch for now. Thanks. And for the other applied patches too. -- Lee Jones [李琼斯] Senior Technical Lead - Developer Services Linaro.org │ Open source software for Arm SoCs Follow Linaro: Facebook | Twitter | Blog _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2020-11-11 7:11 UTC|newest] Thread overview: 138+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-11-03 15:28 [PATCH 00/25] Rid W=1 warnings in SoC Lee Jones 2020-11-03 15:28 ` Lee Jones 2020-11-03 15:28 ` Lee Jones 2020-11-03 15:28 ` Lee Jones 2020-11-03 15:28 ` [PATCH 01/25] soc: bcm: brcmstb: pm: pm-arm: Provide prototype for brcmstb_pm_s3_finish() Lee Jones 2020-11-03 15:28 ` Lee Jones 2020-11-04 3:25 ` Florian Fainelli 2020-11-04 3:25 ` Florian Fainelli 2020-11-26 9:20 ` Lee Jones 2020-11-26 9:20 ` Lee Jones 2020-11-27 17:05 ` Florian Fainelli 2020-11-27 17:05 ` Florian Fainelli 2020-11-27 17:20 ` Lee Jones 2020-11-27 17:20 ` Lee Jones 2020-11-03 15:28 ` [PATCH 02/25] soc: qcom: qcom_aoss: Remove set but unused variable 'tlen' Lee Jones 2020-11-03 15:28 ` Lee Jones 2020-11-03 15:28 ` [PATCH 03/25] soc: qcom: qcom_aoss: Add missing description for 'cooling_devs' Lee Jones 2020-11-03 15:28 ` Lee Jones 2020-11-03 15:28 ` [PATCH 04/25] soc: fsl: dpio: qbman-portal: Fix a bunch of kernel-doc misdemeanours Lee Jones 2020-11-03 15:28 ` Lee Jones 2020-11-03 15:28 ` Lee Jones 2020-11-03 15:28 ` [PATCH 05/25] soc: rockchip: io-domain: Remove incorrect and incomplete comment header Lee Jones 2020-11-03 15:28 ` Lee Jones 2020-11-03 15:28 ` Lee Jones 2020-11-12 10:33 ` Lee Jones 2020-11-12 10:33 ` Lee Jones 2020-11-12 10:33 ` Lee Jones 2020-11-12 11:13 ` Heiko Stübner 2020-11-12 11:13 ` Heiko Stübner 2020-11-12 11:13 ` Heiko Stübner 2020-11-12 13:22 ` Lee Jones 2020-11-12 13:22 ` Lee Jones 2020-11-12 13:22 ` Lee Jones 2020-11-12 13:23 ` Heiko Stübner 2020-11-12 13:23 ` Heiko Stübner 2020-11-12 13:23 ` Heiko Stübner 2020-11-12 13:28 ` Lee Jones 2020-11-12 13:28 ` Lee Jones 2020-11-12 13:28 ` Lee Jones 2020-11-12 13:30 ` Heiko Stübner 2020-11-12 13:30 ` Heiko Stübner 2020-11-12 13:30 ` Heiko Stübner 2020-11-12 13:47 ` Lee Jones 2020-11-12 13:47 ` Lee Jones 2020-11-12 13:47 ` Lee Jones 2020-11-03 15:28 ` [PATCH 06/25] soc: ti: knav_qmss_queue: Remove set but unchecked variable 'ret' Lee Jones 2020-11-03 15:28 ` Lee Jones 2020-11-12 10:31 ` Lee Jones 2020-11-12 10:31 ` Lee Jones 2020-11-12 12:25 ` Tero Kristo 2020-11-12 12:25 ` Tero Kristo 2020-11-12 13:21 ` Lee Jones 2020-11-12 13:21 ` Lee Jones 2020-11-12 13:33 ` Tero Kristo 2020-11-12 13:33 ` Tero Kristo 2020-11-12 17:50 ` santosh.shilimkar 2020-11-12 17:50 ` santosh.shilimkar 2020-11-12 19:02 ` Lee Jones 2020-11-12 19:02 ` Lee Jones 2020-11-12 19:47 ` santosh.shilimkar 2020-11-12 19:47 ` santosh.shilimkar 2020-11-12 20:07 ` Lee Jones 2020-11-12 20:07 ` Lee Jones 2020-11-03 15:28 ` [PATCH 07/25] soc: ti: knav_qmss_queue: Fix a whole host of function documentation issues Lee Jones 2020-11-03 15:28 ` Lee Jones 2020-11-03 15:28 ` [PATCH 08/25] soc: ti: knav_dma: Fix a kernel function doc formatting issue Lee Jones 2020-11-03 15:28 ` Lee Jones 2020-11-03 15:28 ` [PATCH 09/25] soc: ti: pm33xx: Remove set but unused variable 'ret' Lee Jones 2020-11-03 15:28 ` Lee Jones 2020-11-03 15:28 ` [PATCH 10/25] soc: ti: wkup_m3_ipc: Document 'm3_ipc' parameter throughout Lee Jones 2020-11-03 15:28 ` Lee Jones 2020-11-03 15:28 ` [PATCH 11/25] soc: fsl: qe: qe_common: Fix misnamed function attribute 'addr' Lee Jones 2020-11-03 15:28 ` Lee Jones 2020-11-03 15:28 ` Lee Jones 2020-11-12 10:33 ` Lee Jones 2020-11-12 10:33 ` Lee Jones 2020-11-12 23:12 ` Leo Li 2020-11-12 23:12 ` Leo Li 2020-11-12 23:12 ` Leo Li 2020-11-13 7:15 ` Lee Jones 2020-11-13 7:15 ` Lee Jones 2020-11-13 7:15 ` Lee Jones 2020-11-03 15:28 ` [PATCH 12/25] soc: qcom: qcom-geni-se: Fix misnamed function parameter 'rx_rfr' Lee Jones 2020-11-03 15:28 ` Lee Jones 2020-11-03 15:28 ` [PATCH 13/25] soc: tegra: fuse: speedo-tegra124: Remove some set but unused variables Lee Jones 2020-11-03 15:28 ` Lee Jones 2020-11-10 19:39 ` Thierry Reding 2020-11-10 19:39 ` Thierry Reding 2020-11-03 15:28 ` [PATCH 14/25] soc: samsung: s3c-pm-check: Fix incorrectly named variable 'val' Lee Jones 2020-11-03 15:28 ` Lee Jones 2020-11-03 20:38 ` Krzysztof Kozlowski 2020-11-03 20:38 ` Krzysztof Kozlowski 2020-11-03 15:28 ` [PATCH 15/25] soc: qcom: rpmh: Fix possible doc-rot in rpmh_write()'s header Lee Jones 2020-11-03 15:28 ` Lee Jones 2020-11-03 15:28 ` [PATCH 16/25] soc: qcom: smem: Fix formatting and missing documentation issues Lee Jones 2020-11-03 15:28 ` Lee Jones 2020-11-03 15:28 ` [PATCH 17/25] soc: qcom: smsm: Fix some kernel-doc formatting and naming problems Lee Jones 2020-11-03 15:28 ` Lee Jones 2020-11-03 15:28 ` [PATCH 18/25] soc: qcom: wcnss_ctrl: Demote non-conformant struct header and fix function headers Lee Jones 2020-11-03 15:28 ` Lee Jones 2020-11-03 15:28 ` [PATCH 19/25] soc: qcom: smp2p: Remove unused struct attribute provide another Lee Jones 2020-11-03 15:28 ` Lee Jones 2020-11-11 5:20 ` Bjorn Andersson 2020-11-11 5:20 ` Bjorn Andersson 2020-11-11 7:11 ` Lee Jones [this message] 2020-11-11 7:11 ` Lee Jones 2020-11-03 15:28 ` [PATCH 20/25] soc: qcom: llcc-qcom: Fix expected kernel-doc formatting Lee Jones 2020-11-03 15:28 ` Lee Jones 2020-11-03 15:28 ` [PATCH 21/25] soc: qcom: rpmhpd: Provide some missing struct member descriptions Lee Jones 2020-11-03 15:28 ` Lee Jones 2020-11-03 15:28 ` [PATCH 22/25] soc: qcom: kryo-l2-accessors: Fix misnaming of 'val' Lee Jones 2020-11-03 15:28 ` Lee Jones 2020-11-03 15:28 ` [PATCH 23/25] soc: ti: k3-ringacc: Provide documentation for 'k3_ring's 'state' Lee Jones 2020-11-03 15:28 ` Lee Jones 2020-11-03 15:28 ` [PATCH 24/25] soc: tegra: fuse: speedo-tegra210: Remove a group of set but unused variables Lee Jones 2020-11-03 15:28 ` Lee Jones 2020-11-10 19:41 ` Thierry Reding 2020-11-10 19:41 ` Thierry Reding 2020-11-10 21:02 ` Lee Jones 2020-11-10 21:02 ` Lee Jones 2020-11-03 15:28 ` [PATCH 25/25] soc: fsl: qbman: qman: Remove unused variable 'dequeue_wq' Lee Jones 2020-11-03 15:28 ` Lee Jones 2020-11-03 15:28 ` Lee Jones 2020-11-24 0:49 ` Li Yang 2020-11-24 0:49 ` Li Yang 2020-11-24 0:49 ` Li Yang 2020-11-11 5:25 ` [PATCH 00/25] Rid W=1 warnings in SoC Bjorn Andersson 2020-11-11 5:25 ` Bjorn Andersson 2020-11-11 5:25 ` Bjorn Andersson 2020-11-11 5:25 ` Bjorn Andersson 2020-11-12 11:16 ` Heiko Stuebner 2020-11-12 11:16 ` Heiko Stuebner 2020-11-12 11:16 ` Heiko Stuebner 2020-11-12 11:16 ` Heiko Stuebner 2020-11-24 0:44 ` Li Yang 2020-11-24 0:44 ` Li Yang 2020-11-24 0:44 ` Li Yang 2020-11-24 0:44 ` Li Yang
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20201111071145.GM2063125@dell \ --to=lee.jones@linaro.org \ --cc=agross@kernel.org \ --cc=bjorn.andersson@linaro.org \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-arm-msm@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.