From: Christoph Hellwig <hch@lst.de>
To: Sagi Grimberg <sagi@grimberg.me>
Cc: "Keith Busch" <kbusch@kernel.org>,
javier@javigon.com, linux-nvme@lists.infradead.org,
linux-block@vger.kernel.org, hch@lst.de, axboe@kernel.dk,
joshi.k@samsung.com, k.jensen@samsung.com, Niklas.Cassel@wdc.com,
"Javier González" <javier.gonz@samsung.com>
Subject: Re: [PATCH V3] nvme: enable ro namespace for ZNS without append
Date: Wed, 11 Nov 2020 09:15:30 +0100 [thread overview]
Message-ID: <20201111081530.GB23062@lst.de> (raw)
In-Reply-To: <87931ded-b17b-90b2-c5b2-a1a465d109cc@grimberg.me>
On Tue, Nov 10, 2020 at 05:41:15PM -0800, Sagi Grimberg wrote:
>
>>> - if (id->nsattr & NVME_NS_ATTR_RO)
>>> + if (id->nsattr & NVME_NS_ATTR_RO || test_bit(NVME_NS_FORCE_RO, &ns->flags))
>>> set_disk_ro(disk, true);
>>
>> If the FORCE_RO flag is set, the disk is set to read-only. If that flag
>> is later cleared, nothing clears the disk's read-only setting.
>
> Yea, that is true also for the non-force case, but before it broke
> BLKROSET so I reverted that. We can use this FORCE_RO for BLKROSET as
> well I think...
Let me prioritize the hard r/o setting. mkp actually has an older patch
that did just that which I'll resurrect.
WARNING: multiple messages have this Message-ID (diff)
From: Christoph Hellwig <hch@lst.de>
To: Sagi Grimberg <sagi@grimberg.me>
Cc: axboe@kernel.dk, Niklas.Cassel@wdc.com, javier@javigon.com,
joshi.k@samsung.com, k.jensen@samsung.com,
linux-nvme@lists.infradead.org, linux-block@vger.kernel.org,
"Keith Busch" <kbusch@kernel.org>,
"Javier González" <javier.gonz@samsung.com>,
hch@lst.de
Subject: Re: [PATCH V3] nvme: enable ro namespace for ZNS without append
Date: Wed, 11 Nov 2020 09:15:30 +0100 [thread overview]
Message-ID: <20201111081530.GB23062@lst.de> (raw)
In-Reply-To: <87931ded-b17b-90b2-c5b2-a1a465d109cc@grimberg.me>
On Tue, Nov 10, 2020 at 05:41:15PM -0800, Sagi Grimberg wrote:
>
>>> - if (id->nsattr & NVME_NS_ATTR_RO)
>>> + if (id->nsattr & NVME_NS_ATTR_RO || test_bit(NVME_NS_FORCE_RO, &ns->flags))
>>> set_disk_ro(disk, true);
>>
>> If the FORCE_RO flag is set, the disk is set to read-only. If that flag
>> is later cleared, nothing clears the disk's read-only setting.
>
> Yea, that is true also for the non-force case, but before it broke
> BLKROSET so I reverted that. We can use this FORCE_RO for BLKROSET as
> well I think...
Let me prioritize the hard r/o setting. mkp actually has an older patch
that did just that which I'll resurrect.
_______________________________________________
Linux-nvme mailing list
Linux-nvme@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-nvme
next prev parent reply other threads:[~2020-11-11 8:15 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-10 21:07 [PATCH V3] nvme: enable ro namespace for ZNS without append javier
2020-11-10 21:07 ` javier
2020-11-10 22:09 ` Keith Busch
2020-11-10 22:09 ` Keith Busch
2020-11-11 1:41 ` Sagi Grimberg
2020-11-11 1:41 ` Sagi Grimberg
2020-11-11 8:15 ` Christoph Hellwig [this message]
2020-11-11 8:15 ` Christoph Hellwig
2020-11-11 8:36 ` Sagi Grimberg
2020-11-11 8:36 ` Sagi Grimberg
2020-11-11 9:21 ` Javier González
2020-11-11 9:21 ` Javier González
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201111081530.GB23062@lst.de \
--to=hch@lst.de \
--cc=Niklas.Cassel@wdc.com \
--cc=axboe@kernel.dk \
--cc=javier.gonz@samsung.com \
--cc=javier@javigon.com \
--cc=joshi.k@samsung.com \
--cc=k.jensen@samsung.com \
--cc=kbusch@kernel.org \
--cc=linux-block@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=sagi@grimberg.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.