include/asm-generic/qspinlock.h:99:9: sparse: sparse: context imbalance in 'lbmWrite' - unexpected unlock

include/asm-generic/qspinlock.h:99:9: sparse: sparse: context imbalance in 'lbmWrite' - unexpected unlock

[kernel test robot]

[-- Attachment #1: Type: text/plain, Size: 8307 bytes --]

CC: kbuild-all(a)lists.01.org
CC: linux-kernel(a)vger.kernel.org
TO: Nicholas Piggin <npiggin@gmail.com>
CC: Peter Zijlstra <peterz@infradead.org>
CC: "Steven Rostedt (VMware)" <rostedt@goodmis.org>
CC: Thomas Gleixner <tglx@linutronix.de>

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head:   eccc876724927ff3b9ff91f36f7b6b159e948f0c
commit: 044d0d6de9f50192f9697583504a382347ee95ca lockdep: Only trace IRQ edges
date:   3 months ago
:::::: branch date: 8 hours ago
:::::: commit date: 3 months ago
config: arm64-randconfig-s031-20201110 (attached as .config)
compiler: aarch64-linux-gcc (GCC) 9.3.0
reproduce:
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # apt-get install sparse
        # sparse version: v0.6.3-76-gf680124b-dirty
        # https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=044d0d6de9f50192f9697583504a382347ee95ca
        git remote add linus https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
        git fetch --no-tags linus master
        git checkout 044d0d6de9f50192f9697583504a382347ee95ca
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross C=1 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__' ARCH=arm64 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>


"sparse warnings: (new ones prefixed by >>)"
   fs/jfs/jfs_logmgr.c: note: in included file (through arch/arm64/include/generated/asm/qspinlock.h, arch/arm64/include/asm/spinlock.h, include/linux/spinlock.h, ...):
>> include/asm-generic/qspinlock.h:99:9: sparse: sparse: context imbalance in 'lbmWrite' - unexpected unlock
--
   drivers/block/null_blk_main.c: note: in included file (through arch/arm64/include/generated/asm/qspinlock.h, arch/arm64/include/asm/spinlock.h, include/linux/spinlock.h, ...):
>> include/asm-generic/qspinlock.h:99:9: sparse: sparse: context imbalance in 'null_make_cache_space' - unexpected unlock
--
   drivers/scsi/qla1280.c:2866:27: sparse: sparse: incorrect type in assignment (different base types) @@     expected restricted __le32 [usertype] *dword_ptr @@     got unsigned int [usertype] * @@
   drivers/scsi/qla1280.c:2866:27: sparse:     expected restricted __le32 [usertype] *dword_ptr
   drivers/scsi/qla1280.c:2866:27: sparse:     got unsigned int [usertype] *
   drivers/scsi/qla1280.c:2922:35: sparse: sparse: incorrect type in assignment (different base types) @@     expected restricted __le32 [usertype] *[assigned] dword_ptr @@     got unsigned int [usertype] * @@
   drivers/scsi/qla1280.c:2922:35: sparse:     expected restricted __le32 [usertype] *[assigned] dword_ptr
   drivers/scsi/qla1280.c:2922:35: sparse:     got unsigned int [usertype] *
   drivers/scsi/qla1280.c:2326:16: sparse: sparse: cast to restricted __le16
   drivers/scsi/qla1280.c:2326:16: sparse: sparse: cast to restricted __le16
   drivers/scsi/qla1280.c:2326:16: sparse: sparse: cast to restricted __le16
   drivers/scsi/qla1280.c:2326:16: sparse: sparse: cast to restricted __le16
   drivers/scsi/qla1280.c:645:27: sparse: sparse: incorrect type in assignment (different base types) @@     expected unsigned short [usertype] isp_parameter @@     got restricted __le16 [usertype] @@
   drivers/scsi/qla1280.c:645:27: sparse:     expected unsigned short [usertype] isp_parameter
   drivers/scsi/qla1280.c:645:27: sparse:     got restricted __le16 [usertype]
   drivers/scsi/qla1280.c:646:32: sparse: sparse: incorrect type in assignment (different base types) @@     expected unsigned short [usertype] w @@     got restricted __le16 [usertype] @@
   drivers/scsi/qla1280.c:646:32: sparse:     expected unsigned short [usertype] w
   drivers/scsi/qla1280.c:646:32: sparse:     got restricted __le16 [usertype]
   drivers/scsi/qla1280.c:648:46: sparse: sparse: incorrect type in assignment (different base types) @@     expected unsigned short [usertype] selection_timeout @@     got restricted __le16 [usertype] @@
   drivers/scsi/qla1280.c:648:46: sparse:     expected unsigned short [usertype] selection_timeout
   drivers/scsi/qla1280.c:648:46: sparse:     got restricted __le16 [usertype]
   drivers/scsi/qla1280.c:649:44: sparse: sparse: incorrect type in assignment (different base types) @@     expected unsigned short [usertype] max_queue_depth @@     got restricted __le16 [usertype] @@
   drivers/scsi/qla1280.c:649:44: sparse:     expected unsigned short [usertype] max_queue_depth
   drivers/scsi/qla1280.c:649:44: sparse:     got restricted __le16 [usertype]
>> drivers/scsi/qla1280.c:747:1: sparse: sparse: context imbalance in '_qla1280_wait_for_single_command' - unexpected unlock
   drivers/scsi/qla1280.c:1498:30: sparse: sparse: context imbalance in 'qla1280_request_firmware' - unexpected unlock
   drivers/scsi/qla1280.c:2460:9: sparse: sparse: context imbalance in 'qla1280_mailbox_command' - unexpected unlock
>> drivers/scsi/qla1280.c:2573:32: sparse: sparse: context imbalance in 'qla1280_bus_reset' - unexpected unlock
--
>> drivers/scsi/ipr.c:1068:13: sparse: sparse: context imbalance in 'ipr_send_blocking_cmd' - unexpected unlock
>> drivers/scsi/ipr.c:5381:17: sparse: sparse: context imbalance in '__ipr_eh_dev_reset' - unexpected unlock
--
   lib/percpu-refcount.c: note: in included file (through arch/arm64/include/generated/asm/qspinlock.h, arch/arm64/include/asm/spinlock.h, include/linux/spinlock.h, ...):
>> include/asm-generic/qspinlock.h:99:9: sparse: sparse: context imbalance in '__percpu_ref_switch_mode' - unexpected unlock
--
   kernel/locking/rtmutex.c: note: in included file (through arch/arm64/include/generated/asm/qspinlock.h, arch/arm64/include/asm/spinlock.h, include/linux/spinlock.h):
>> include/asm-generic/qspinlock.h:99:9: sparse: sparse: context imbalance in 'task_blocks_on_rt_mutex' - unexpected unlock
>> include/asm-generic/qspinlock.h:99:9: sparse: sparse: context imbalance in 'remove_waiter' - unexpected unlock
   kernel/locking/rtmutex.c:1190:17: sparse: sparse: context imbalance in '__rt_mutex_slowlock' - unexpected unlock
--
   kernel/sched/wait.c: note: in included file (through arch/arm64/include/generated/asm/qspinlock.h, arch/arm64/include/asm/spinlock.h, include/linux/spinlock.h, ...):
>> include/asm-generic/qspinlock.h:99:9: sparse: sparse: context imbalance in 'do_wait_intr_irq' - unexpected unlock
--
   kernel/time/timer.c: note: in included file (through arch/arm64/include/generated/asm/qspinlock.h, arch/arm64/include/asm/spinlock.h, include/linux/spinlock.h, ...):
>> include/asm-generic/qspinlock.h:99:9: sparse: sparse: context imbalance in 'expire_timers' - unexpected unlock

vim +/lbmWrite +99 include/asm-generic/qspinlock.h

a33fda35e3a7655 Waiman Long 2015-04-24   88  
a33fda35e3a7655 Waiman Long 2015-04-24   89  #ifndef queued_spin_unlock
a33fda35e3a7655 Waiman Long 2015-04-24   90  /**
a33fda35e3a7655 Waiman Long 2015-04-24   91   * queued_spin_unlock - release a queued spinlock
a33fda35e3a7655 Waiman Long 2015-04-24   92   * @lock : Pointer to queued spinlock structure
a33fda35e3a7655 Waiman Long 2015-04-24   93   */
a33fda35e3a7655 Waiman Long 2015-04-24   94  static __always_inline void queued_spin_unlock(struct qspinlock *lock)
a33fda35e3a7655 Waiman Long 2015-04-24   95  {
a33fda35e3a7655 Waiman Long 2015-04-24   96  	/*
ca50e426f96c905 Pan Xinhui  2016-06-03   97  	 * unlock() needs release semantics:
a33fda35e3a7655 Waiman Long 2015-04-24   98  	 */
626e5fbc1435890 Will Deacon 2018-04-26  @99  	smp_store_release(&lock->locked, 0);
a33fda35e3a7655 Waiman Long 2015-04-24  100  }
a33fda35e3a7655 Waiman Long 2015-04-24  101  #endif
a33fda35e3a7655 Waiman Long 2015-04-24  102  

:::::: The code at line 99 was first introduced by commit
:::::: 626e5fbc14358901ddaa90ce510e0fbeab310432 locking/qspinlock: Use smp_store_release() in queued_spin_unlock()

:::::: TO: Will Deacon <will.deacon@arm.com>
:::::: CC: Ingo Molnar <mingo@kernel.org>

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org

[-- Attachment #2: config.gz --]
[-- Type: application/gzip, Size: 40733 bytes --]