From: Daniel Vetter <daniel@ffwll.ch> To: Jianxin Xiong <jianxin.xiong@intel.com> Cc: linux-rdma@vger.kernel.org, dri-devel@lists.freedesktop.org, Leon Romanovsky <leon@kernel.org>, Jason Gunthorpe <jgg@ziepe.ca>, Doug Ledford <dledford@redhat.com>, Daniel Vetter <daniel.vetter@intel.com>, Christian Koenig <christian.koenig@amd.com> Subject: Re: [PATCH v10 6/6] dma-buf: Document that dma-buf size is fixed Date: Wed, 11 Nov 2020 17:33:23 +0100 [thread overview] Message-ID: <20201111163323.GP401619@phenom.ffwll.local> (raw) In-Reply-To: <1605044477-51833-7-git-send-email-jianxin.xiong@intel.com> On Tue, Nov 10, 2020 at 01:41:17PM -0800, Jianxin Xiong wrote: > The fact that the size of dma-buf is invariant over the lifetime of the > buffer is mentioned in the comment of 'dma_buf_ops.mmap', but is not > documented at where the info is defined. Add the missing documentation. > > Signed-off-by: Jianxin Xiong <jianxin.xiong@intel.com> Applied to drm-misc-next, thanks for your patch. For the preceeding dma-buf patch I'll wait for more review/acks before I apply it. Ack from Jason might also be good, since looks like this dma_virt_ops is only used in rdma. -Daniel > --- > include/linux/dma-buf.h | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/include/linux/dma-buf.h b/include/linux/dma-buf.h > index 9dcd569..92da98b 100644 > --- a/include/linux/dma-buf.h > +++ b/include/linux/dma-buf.h > @@ -272,7 +272,7 @@ struct dma_buf_ops { > > /** > * struct dma_buf - shared buffer object > - * @size: size of the buffer > + * @size: size of the buffer; invariant over the lifetime of the buffer. > * @file: file pointer used for sharing buffers across, and for refcounting. > * @attachments: list of dma_buf_attachment that denotes all devices attached, > * protected by dma_resv lock. > @@ -404,7 +404,7 @@ struct dma_buf_attachment { > * @exp_name: name of the exporter - useful for debugging. > * @owner: pointer to exporter module - used for refcounting kernel module > * @ops: Attach allocator-defined dma buf ops to the new buffer > - * @size: Size of the buffer > + * @size: Size of the buffer - invariant over the lifetime of the buffer > * @flags: mode flags for the file > * @resv: reservation-object, NULL to allocate default one > * @priv: Attach private data of allocator to this buffer > -- > 1.8.3.1 > > _______________________________________________ > dri-devel mailing list > dri-devel@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/dri-devel -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch
WARNING: multiple messages have this Message-ID (diff)
From: Daniel Vetter <daniel@ffwll.ch> To: Jianxin Xiong <jianxin.xiong@intel.com> Cc: Leon Romanovsky <leon@kernel.org>, linux-rdma@vger.kernel.org, dri-devel@lists.freedesktop.org, Jason Gunthorpe <jgg@ziepe.ca>, Doug Ledford <dledford@redhat.com>, Daniel Vetter <daniel.vetter@intel.com>, Christian Koenig <christian.koenig@amd.com> Subject: Re: [PATCH v10 6/6] dma-buf: Document that dma-buf size is fixed Date: Wed, 11 Nov 2020 17:33:23 +0100 [thread overview] Message-ID: <20201111163323.GP401619@phenom.ffwll.local> (raw) In-Reply-To: <1605044477-51833-7-git-send-email-jianxin.xiong@intel.com> On Tue, Nov 10, 2020 at 01:41:17PM -0800, Jianxin Xiong wrote: > The fact that the size of dma-buf is invariant over the lifetime of the > buffer is mentioned in the comment of 'dma_buf_ops.mmap', but is not > documented at where the info is defined. Add the missing documentation. > > Signed-off-by: Jianxin Xiong <jianxin.xiong@intel.com> Applied to drm-misc-next, thanks for your patch. For the preceeding dma-buf patch I'll wait for more review/acks before I apply it. Ack from Jason might also be good, since looks like this dma_virt_ops is only used in rdma. -Daniel > --- > include/linux/dma-buf.h | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/include/linux/dma-buf.h b/include/linux/dma-buf.h > index 9dcd569..92da98b 100644 > --- a/include/linux/dma-buf.h > +++ b/include/linux/dma-buf.h > @@ -272,7 +272,7 @@ struct dma_buf_ops { > > /** > * struct dma_buf - shared buffer object > - * @size: size of the buffer > + * @size: size of the buffer; invariant over the lifetime of the buffer. > * @file: file pointer used for sharing buffers across, and for refcounting. > * @attachments: list of dma_buf_attachment that denotes all devices attached, > * protected by dma_resv lock. > @@ -404,7 +404,7 @@ struct dma_buf_attachment { > * @exp_name: name of the exporter - useful for debugging. > * @owner: pointer to exporter module - used for refcounting kernel module > * @ops: Attach allocator-defined dma buf ops to the new buffer > - * @size: Size of the buffer > + * @size: Size of the buffer - invariant over the lifetime of the buffer > * @flags: mode flags for the file > * @resv: reservation-object, NULL to allocate default one > * @priv: Attach private data of allocator to this buffer > -- > 1.8.3.1 > > _______________________________________________ > dri-devel mailing list > dri-devel@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/dri-devel -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2020-11-11 16:33 UTC|newest] Thread overview: 40+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-11-10 21:41 [PATCH v10 0/6] RDMA: Add dma-buf support Jianxin Xiong 2020-11-10 21:41 ` Jianxin Xiong 2020-11-10 21:41 ` [PATCH v10 1/6] RDMA/umem: Support importing dma-buf as user memory region Jianxin Xiong 2020-11-10 21:41 ` Jianxin Xiong 2020-11-13 0:30 ` Jason Gunthorpe 2020-11-13 0:30 ` Jason Gunthorpe 2020-11-13 3:30 ` Xiong, Jianxin 2020-11-13 3:30 ` Xiong, Jianxin 2020-11-13 12:49 ` Jason Gunthorpe 2020-11-13 12:49 ` Jason Gunthorpe 2020-11-10 21:41 ` [PATCH v10 2/6] RDMA/core: Add device method for registering dma-buf based " Jianxin Xiong 2020-11-10 21:41 ` Jianxin Xiong 2020-11-10 21:41 ` [PATCH v10 3/6] RDMA/uverbs: Add uverbs command for dma-buf based MR registration Jianxin Xiong 2020-11-10 21:41 ` Jianxin Xiong 2020-11-13 0:33 ` Jason Gunthorpe 2020-11-13 0:33 ` Jason Gunthorpe 2020-11-13 4:02 ` Xiong, Jianxin 2020-11-13 4:02 ` Xiong, Jianxin 2020-11-10 21:41 ` [PATCH v10 4/6] RDMA/mlx5: Support dma-buf based userspace memory region Jianxin Xiong 2020-11-10 21:41 ` Jianxin Xiong 2020-11-13 0:39 ` Jason Gunthorpe 2020-11-13 0:39 ` Jason Gunthorpe 2020-11-13 3:51 ` Xiong, Jianxin 2020-11-13 3:51 ` Xiong, Jianxin 2020-11-13 13:06 ` Jason Gunthorpe 2020-11-13 13:06 ` Jason Gunthorpe 2020-11-13 17:28 ` Xiong, Jianxin 2020-11-13 17:28 ` Xiong, Jianxin 2020-11-10 21:41 ` [PATCH v10 5/6] dma-buf: Reject attach request from importers that use dma_virt_ops Jianxin Xiong 2020-11-10 21:41 ` Jianxin Xiong 2020-11-10 21:41 ` [PATCH v10 6/6] dma-buf: Document that dma-buf size is fixed Jianxin Xiong 2020-11-10 21:41 ` Jianxin Xiong 2020-11-11 16:33 ` Daniel Vetter [this message] 2020-11-11 16:33 ` Daniel Vetter 2020-11-12 13:25 ` Jason Gunthorpe 2020-11-12 13:25 ` Jason Gunthorpe 2020-11-13 20:41 ` Daniel Vetter 2020-11-13 20:41 ` Daniel Vetter 2020-11-13 0:42 ` [PATCH v10 0/6] RDMA: Add dma-buf support Jason Gunthorpe 2020-11-13 0:42 ` Jason Gunthorpe
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20201111163323.GP401619@phenom.ffwll.local \ --to=daniel@ffwll.ch \ --cc=christian.koenig@amd.com \ --cc=daniel.vetter@intel.com \ --cc=dledford@redhat.com \ --cc=dri-devel@lists.freedesktop.org \ --cc=jgg@ziepe.ca \ --cc=jianxin.xiong@intel.com \ --cc=leon@kernel.org \ --cc=linux-rdma@vger.kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.