* [intel-linux-intel-lts:5.4/yocto 3846/12652] drivers/net/ethernet/stmicro/stmmac/stmmac_main.c:540:7: warning: variable 'xmac' set but not used
@ 2020-11-12 2:30 kernel test robot
0 siblings, 0 replies; 2+ messages in thread
From: kernel test robot @ 2020-11-12 2:30 UTC (permalink / raw)
To: kbuild-all
[-- Attachment #1: Type: text/plain, Size: 22498 bytes --]
Hi Vee,
FYI, the error/warning still remains.
tree: https://github.com/intel/linux-intel-lts.git 5.4/yocto
head: be0f563c86400c13b89cfd69a1cd7ca33f21ed54
commit: 91c9a87a5d240e8b419bf735286ce4cfcea30c34 [3846/12652] net: stmmac: Init PTP clock with system clock
config: arm-randconfig-r034-20201111 (attached as .config)
compiler: arm-linux-gnueabi-gcc (GCC) 9.3.0
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# https://github.com/intel/linux-intel-lts/commit/91c9a87a5d240e8b419bf735286ce4cfcea30c34
git remote add intel-linux-intel-lts https://github.com/intel/linux-intel-lts.git
git fetch --no-tags intel-linux-intel-lts 5.4/yocto
git checkout 91c9a87a5d240e8b419bf735286ce4cfcea30c34
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=arm
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
All warnings (new ones prefixed by >>):
drivers/net/ethernet/stmicro/stmmac/stmmac_main.c: In function 'stmmac_hwtstamp_set':
>> drivers/net/ethernet/stmicro/stmmac/stmmac_main.c:540:7: warning: variable 'xmac' set but not used [-Wunused-but-set-variable]
540 | bool xmac;
| ^~~~
drivers/net/ethernet/stmicro/stmmac/stmmac_main.c: At top level:
drivers/net/ethernet/stmicro/stmmac/stmmac_main.c:1388:6: warning: no previous prototype for 'stmmac_alloc_rx_buffers' [-Wmissing-prototypes]
1388 | bool stmmac_alloc_rx_buffers(struct stmmac_rx_queue *rx_q, u32 count)
| ^~~~~~~~~~~~~~~~~~~~~~~
drivers/net/ethernet/stmicro/stmmac/stmmac_main.c: In function 'stmmac_alloc_rx_buffers':
drivers/net/ethernet/stmicro/stmmac/stmmac_main.c:1414:13: warning: comparison of unsigned expression >= 0 is always true [-Wtype-limits]
1414 | while (--i >= 0)
| ^~
drivers/net/ethernet/stmicro/stmmac/stmmac_main.c: In function 'init_dma_rx_desc_rings':
drivers/net/ethernet/stmicro/stmmac/stmmac_main.c:1522:15: warning: comparison of unsigned expression >= 0 is always true [-Wtype-limits]
1522 | while (queue >= 0) {
| ^~
In file included from include/net/sock.h:46,
from include/linux/tcp.h:19,
from drivers/net/ethernet/stmicro/stmmac/stmmac_main.c:21:
drivers/net/ethernet/stmicro/stmmac/stmmac_main.c: In function 'stmmac_rx':
drivers/net/ethernet/stmicro/stmmac/stmmac_main.c:4623:27: warning: format '%llx' expects argument of type 'long long unsigned int', but argument 6 has type 'dma_addr_t' {aka 'unsigned int'} [-Wformat=]
4623 | netdev_dbg(priv->dev, "\tdesc: %p [entry %d] buff=0x%llx\n",
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
4624 | p, entry, buf->addr);
| ~~~~~~~~~
| |
| dma_addr_t {aka unsigned int}
include/linux/netdevice.h:4767:36: note: in definition of macro 'netdev_dbg'
4767 | netdev_printk(KERN_DEBUG, __dev, format, ##args); \
| ^~~~~~
drivers/net/ethernet/stmicro/stmmac/stmmac_main.c:4623:60: note: format string is defined here
4623 | netdev_dbg(priv->dev, "\tdesc: %p [entry %d] buff=0x%llx\n",
| ~~~^
| |
| long long unsigned int
| %x
drivers/net/ethernet/stmicro/stmmac/stmmac_main.c: At top level:
drivers/net/ethernet/stmicro/stmmac/stmmac_main.c:5601:5: warning: no previous prototype for 'stmmac_xdp_xmit' [-Wmissing-prototypes]
5601 | int stmmac_xdp_xmit(struct net_device *dev, int n, struct xdp_frame **frames,
| ^~~~~~~~~~~~~~~
vim +/xmac +540 drivers/net/ethernet/stmicro/stmmac/stmmac_main.c
891434b18ec0a21 Rayagond Kokatanur 2013-03-26 515
891434b18ec0a21 Rayagond Kokatanur 2013-03-26 516 /**
d6228b7cdd6e790 Artem Panfilov 2019-01-20 517 * stmmac_hwtstamp_set - control hardware timestamping.
891434b18ec0a21 Rayagond Kokatanur 2013-03-26 518 * @dev: device pointer.
8d45e42babb1c7b LABBE Corentin 2017-02-08 519 * @ifr: An IOCTL specific structure, that can contain a pointer to
891434b18ec0a21 Rayagond Kokatanur 2013-03-26 520 * a proprietary structure used to pass information to the driver.
891434b18ec0a21 Rayagond Kokatanur 2013-03-26 521 * Description:
891434b18ec0a21 Rayagond Kokatanur 2013-03-26 522 * This function configures the MAC to enable/disable both outgoing(TX)
891434b18ec0a21 Rayagond Kokatanur 2013-03-26 523 * and incoming(RX) packets time stamping based on user input.
891434b18ec0a21 Rayagond Kokatanur 2013-03-26 524 * Return Value:
891434b18ec0a21 Rayagond Kokatanur 2013-03-26 525 * 0 on success and an appropriate -ve integer on failure.
891434b18ec0a21 Rayagond Kokatanur 2013-03-26 526 */
d6228b7cdd6e790 Artem Panfilov 2019-01-20 527 static int stmmac_hwtstamp_set(struct net_device *dev, struct ifreq *ifr)
891434b18ec0a21 Rayagond Kokatanur 2013-03-26 528 {
891434b18ec0a21 Rayagond Kokatanur 2013-03-26 529 struct stmmac_priv *priv = netdev_priv(dev);
891434b18ec0a21 Rayagond Kokatanur 2013-03-26 530 struct hwtstamp_config config;
891434b18ec0a21 Rayagond Kokatanur 2013-03-26 531 u32 ptp_v2 = 0;
891434b18ec0a21 Rayagond Kokatanur 2013-03-26 532 u32 tstamp_all = 0;
891434b18ec0a21 Rayagond Kokatanur 2013-03-26 533 u32 ptp_over_ipv4_udp = 0;
891434b18ec0a21 Rayagond Kokatanur 2013-03-26 534 u32 ptp_over_ipv6_udp = 0;
891434b18ec0a21 Rayagond Kokatanur 2013-03-26 535 u32 ptp_over_ethernet = 0;
891434b18ec0a21 Rayagond Kokatanur 2013-03-26 536 u32 snap_type_sel = 0;
891434b18ec0a21 Rayagond Kokatanur 2013-03-26 537 u32 ts_master_en = 0;
891434b18ec0a21 Rayagond Kokatanur 2013-03-26 538 u32 ts_event_en = 0;
891434b18ec0a21 Rayagond Kokatanur 2013-03-26 539 u32 value = 0;
7d9e6c5afab6bfb Jose Abreu 2018-08-08 @540 bool xmac;
7d9e6c5afab6bfb Jose Abreu 2018-08-08 541
7d9e6c5afab6bfb Jose Abreu 2018-08-08 542 xmac = priv->plat->has_gmac4 || priv->plat->has_xgmac;
891434b18ec0a21 Rayagond Kokatanur 2013-03-26 543
891434b18ec0a21 Rayagond Kokatanur 2013-03-26 544 if (!(priv->dma_cap.time_stamp || priv->adv_ts)) {
891434b18ec0a21 Rayagond Kokatanur 2013-03-26 545 netdev_alert(priv->dev, "No support for HW time stamping\n");
891434b18ec0a21 Rayagond Kokatanur 2013-03-26 546 priv->hwts_tx_en = 0;
891434b18ec0a21 Rayagond Kokatanur 2013-03-26 547 priv->hwts_rx_en = 0;
891434b18ec0a21 Rayagond Kokatanur 2013-03-26 548
891434b18ec0a21 Rayagond Kokatanur 2013-03-26 549 return -EOPNOTSUPP;
891434b18ec0a21 Rayagond Kokatanur 2013-03-26 550 }
891434b18ec0a21 Rayagond Kokatanur 2013-03-26 551
891434b18ec0a21 Rayagond Kokatanur 2013-03-26 552 if (copy_from_user(&config, ifr->ifr_data,
d6228b7cdd6e790 Artem Panfilov 2019-01-20 553 sizeof(config)))
891434b18ec0a21 Rayagond Kokatanur 2013-03-26 554 return -EFAULT;
891434b18ec0a21 Rayagond Kokatanur 2013-03-26 555
38ddc59d65b6d97 LABBE Corentin 2016-11-16 556 netdev_dbg(priv->dev, "%s config flags:0x%x, tx_type:0x%x, rx_filter:0x%x\n",
891434b18ec0a21 Rayagond Kokatanur 2013-03-26 557 __func__, config.flags, config.tx_type, config.rx_filter);
891434b18ec0a21 Rayagond Kokatanur 2013-03-26 558
891434b18ec0a21 Rayagond Kokatanur 2013-03-26 559 /* reserved for future extensions */
891434b18ec0a21 Rayagond Kokatanur 2013-03-26 560 if (config.flags)
891434b18ec0a21 Rayagond Kokatanur 2013-03-26 561 return -EINVAL;
891434b18ec0a21 Rayagond Kokatanur 2013-03-26 562
5f3da3281932a79 Ben Hutchings 2013-11-14 563 if (config.tx_type != HWTSTAMP_TX_OFF &&
5f3da3281932a79 Ben Hutchings 2013-11-14 564 config.tx_type != HWTSTAMP_TX_ON)
891434b18ec0a21 Rayagond Kokatanur 2013-03-26 565 return -ERANGE;
891434b18ec0a21 Rayagond Kokatanur 2013-03-26 566
891434b18ec0a21 Rayagond Kokatanur 2013-03-26 567 if (priv->adv_ts) {
891434b18ec0a21 Rayagond Kokatanur 2013-03-26 568 switch (config.rx_filter) {
891434b18ec0a21 Rayagond Kokatanur 2013-03-26 569 case HWTSTAMP_FILTER_NONE:
ceb694997e1b5d4 Giuseppe CAVALLARO 2013-04-08 570 /* time stamp no incoming packet at all */
891434b18ec0a21 Rayagond Kokatanur 2013-03-26 571 config.rx_filter = HWTSTAMP_FILTER_NONE;
891434b18ec0a21 Rayagond Kokatanur 2013-03-26 572 break;
891434b18ec0a21 Rayagond Kokatanur 2013-03-26 573
891434b18ec0a21 Rayagond Kokatanur 2013-03-26 574 case HWTSTAMP_FILTER_PTP_V1_L4_EVENT:
ceb694997e1b5d4 Giuseppe CAVALLARO 2013-04-08 575 /* PTP v1, UDP, any kind of event packet */
891434b18ec0a21 Rayagond Kokatanur 2013-03-26 576 config.rx_filter = HWTSTAMP_FILTER_PTP_V1_L4_EVENT;
7d8e249f393a1ac Ilias Apalodimas 2019-02-05 577 /* 'xmac' hardware can support Sync, Pdelay_Req and
7d8e249f393a1ac Ilias Apalodimas 2019-02-05 578 * Pdelay_resp by setting bit14 and bits17/16 to 01
7d8e249f393a1ac Ilias Apalodimas 2019-02-05 579 * This leaves Delay_Req timestamps out.
7d8e249f393a1ac Ilias Apalodimas 2019-02-05 580 * Enable all events *and* general purpose message
7d8e249f393a1ac Ilias Apalodimas 2019-02-05 581 * timestamping
7d8e249f393a1ac Ilias Apalodimas 2019-02-05 582 */
891434b18ec0a21 Rayagond Kokatanur 2013-03-26 583 snap_type_sel = PTP_TCR_SNAPTYPSEL_1;
891434b18ec0a21 Rayagond Kokatanur 2013-03-26 584 ptp_over_ipv4_udp = PTP_TCR_TSIPV4ENA;
891434b18ec0a21 Rayagond Kokatanur 2013-03-26 585 ptp_over_ipv6_udp = PTP_TCR_TSIPV6ENA;
891434b18ec0a21 Rayagond Kokatanur 2013-03-26 586 break;
891434b18ec0a21 Rayagond Kokatanur 2013-03-26 587
891434b18ec0a21 Rayagond Kokatanur 2013-03-26 588 case HWTSTAMP_FILTER_PTP_V1_L4_SYNC:
ceb694997e1b5d4 Giuseppe CAVALLARO 2013-04-08 589 /* PTP v1, UDP, Sync packet */
891434b18ec0a21 Rayagond Kokatanur 2013-03-26 590 config.rx_filter = HWTSTAMP_FILTER_PTP_V1_L4_SYNC;
891434b18ec0a21 Rayagond Kokatanur 2013-03-26 591 /* take time stamp for SYNC messages only */
891434b18ec0a21 Rayagond Kokatanur 2013-03-26 592 ts_event_en = PTP_TCR_TSEVNTENA;
891434b18ec0a21 Rayagond Kokatanur 2013-03-26 593
891434b18ec0a21 Rayagond Kokatanur 2013-03-26 594 ptp_over_ipv4_udp = PTP_TCR_TSIPV4ENA;
891434b18ec0a21 Rayagond Kokatanur 2013-03-26 595 ptp_over_ipv6_udp = PTP_TCR_TSIPV6ENA;
891434b18ec0a21 Rayagond Kokatanur 2013-03-26 596 break;
891434b18ec0a21 Rayagond Kokatanur 2013-03-26 597
891434b18ec0a21 Rayagond Kokatanur 2013-03-26 598 case HWTSTAMP_FILTER_PTP_V1_L4_DELAY_REQ:
ceb694997e1b5d4 Giuseppe CAVALLARO 2013-04-08 599 /* PTP v1, UDP, Delay_req packet */
891434b18ec0a21 Rayagond Kokatanur 2013-03-26 600 config.rx_filter = HWTSTAMP_FILTER_PTP_V1_L4_DELAY_REQ;
891434b18ec0a21 Rayagond Kokatanur 2013-03-26 601 /* take time stamp for Delay_Req messages only */
891434b18ec0a21 Rayagond Kokatanur 2013-03-26 602 ts_master_en = PTP_TCR_TSMSTRENA;
891434b18ec0a21 Rayagond Kokatanur 2013-03-26 603 ts_event_en = PTP_TCR_TSEVNTENA;
891434b18ec0a21 Rayagond Kokatanur 2013-03-26 604
891434b18ec0a21 Rayagond Kokatanur 2013-03-26 605 ptp_over_ipv4_udp = PTP_TCR_TSIPV4ENA;
891434b18ec0a21 Rayagond Kokatanur 2013-03-26 606 ptp_over_ipv6_udp = PTP_TCR_TSIPV6ENA;
891434b18ec0a21 Rayagond Kokatanur 2013-03-26 607 break;
891434b18ec0a21 Rayagond Kokatanur 2013-03-26 608
891434b18ec0a21 Rayagond Kokatanur 2013-03-26 609 case HWTSTAMP_FILTER_PTP_V2_L4_EVENT:
ceb694997e1b5d4 Giuseppe CAVALLARO 2013-04-08 610 /* PTP v2, UDP, any kind of event packet */
891434b18ec0a21 Rayagond Kokatanur 2013-03-26 611 config.rx_filter = HWTSTAMP_FILTER_PTP_V2_L4_EVENT;
891434b18ec0a21 Rayagond Kokatanur 2013-03-26 612 ptp_v2 = PTP_TCR_TSVER2ENA;
891434b18ec0a21 Rayagond Kokatanur 2013-03-26 613 /* take time stamp for all event messages */
891434b18ec0a21 Rayagond Kokatanur 2013-03-26 614 snap_type_sel = PTP_TCR_SNAPTYPSEL_1;
891434b18ec0a21 Rayagond Kokatanur 2013-03-26 615
891434b18ec0a21 Rayagond Kokatanur 2013-03-26 616 ptp_over_ipv4_udp = PTP_TCR_TSIPV4ENA;
891434b18ec0a21 Rayagond Kokatanur 2013-03-26 617 ptp_over_ipv6_udp = PTP_TCR_TSIPV6ENA;
891434b18ec0a21 Rayagond Kokatanur 2013-03-26 618 break;
891434b18ec0a21 Rayagond Kokatanur 2013-03-26 619
891434b18ec0a21 Rayagond Kokatanur 2013-03-26 620 case HWTSTAMP_FILTER_PTP_V2_L4_SYNC:
ceb694997e1b5d4 Giuseppe CAVALLARO 2013-04-08 621 /* PTP v2, UDP, Sync packet */
891434b18ec0a21 Rayagond Kokatanur 2013-03-26 622 config.rx_filter = HWTSTAMP_FILTER_PTP_V2_L4_SYNC;
891434b18ec0a21 Rayagond Kokatanur 2013-03-26 623 ptp_v2 = PTP_TCR_TSVER2ENA;
891434b18ec0a21 Rayagond Kokatanur 2013-03-26 624 /* take time stamp for SYNC messages only */
891434b18ec0a21 Rayagond Kokatanur 2013-03-26 625 ts_event_en = PTP_TCR_TSEVNTENA;
891434b18ec0a21 Rayagond Kokatanur 2013-03-26 626
891434b18ec0a21 Rayagond Kokatanur 2013-03-26 627 ptp_over_ipv4_udp = PTP_TCR_TSIPV4ENA;
891434b18ec0a21 Rayagond Kokatanur 2013-03-26 628 ptp_over_ipv6_udp = PTP_TCR_TSIPV6ENA;
891434b18ec0a21 Rayagond Kokatanur 2013-03-26 629 break;
891434b18ec0a21 Rayagond Kokatanur 2013-03-26 630
891434b18ec0a21 Rayagond Kokatanur 2013-03-26 631 case HWTSTAMP_FILTER_PTP_V2_L4_DELAY_REQ:
ceb694997e1b5d4 Giuseppe CAVALLARO 2013-04-08 632 /* PTP v2, UDP, Delay_req packet */
891434b18ec0a21 Rayagond Kokatanur 2013-03-26 633 config.rx_filter = HWTSTAMP_FILTER_PTP_V2_L4_DELAY_REQ;
891434b18ec0a21 Rayagond Kokatanur 2013-03-26 634 ptp_v2 = PTP_TCR_TSVER2ENA;
891434b18ec0a21 Rayagond Kokatanur 2013-03-26 635 /* take time stamp for Delay_Req messages only */
891434b18ec0a21 Rayagond Kokatanur 2013-03-26 636 ts_master_en = PTP_TCR_TSMSTRENA;
891434b18ec0a21 Rayagond Kokatanur 2013-03-26 637 ts_event_en = PTP_TCR_TSEVNTENA;
891434b18ec0a21 Rayagond Kokatanur 2013-03-26 638
891434b18ec0a21 Rayagond Kokatanur 2013-03-26 639 ptp_over_ipv4_udp = PTP_TCR_TSIPV4ENA;
891434b18ec0a21 Rayagond Kokatanur 2013-03-26 640 ptp_over_ipv6_udp = PTP_TCR_TSIPV6ENA;
891434b18ec0a21 Rayagond Kokatanur 2013-03-26 641 break;
891434b18ec0a21 Rayagond Kokatanur 2013-03-26 642
891434b18ec0a21 Rayagond Kokatanur 2013-03-26 643 case HWTSTAMP_FILTER_PTP_V2_EVENT:
ceb694997e1b5d4 Giuseppe CAVALLARO 2013-04-08 644 /* PTP v2/802.AS1 any layer, any kind of event packet */
891434b18ec0a21 Rayagond Kokatanur 2013-03-26 645 config.rx_filter = HWTSTAMP_FILTER_PTP_V2_EVENT;
891434b18ec0a21 Rayagond Kokatanur 2013-03-26 646 ptp_v2 = PTP_TCR_TSVER2ENA;
891434b18ec0a21 Rayagond Kokatanur 2013-03-26 647 snap_type_sel = PTP_TCR_SNAPTYPSEL_1;
14f347334bf2320 Jose Abreu 2019-09-30 648 ts_event_en = PTP_TCR_TSEVNTENA;
891434b18ec0a21 Rayagond Kokatanur 2013-03-26 649 ptp_over_ipv4_udp = PTP_TCR_TSIPV4ENA;
891434b18ec0a21 Rayagond Kokatanur 2013-03-26 650 ptp_over_ipv6_udp = PTP_TCR_TSIPV6ENA;
891434b18ec0a21 Rayagond Kokatanur 2013-03-26 651 ptp_over_ethernet = PTP_TCR_TSIPENA;
891434b18ec0a21 Rayagond Kokatanur 2013-03-26 652 break;
891434b18ec0a21 Rayagond Kokatanur 2013-03-26 653
891434b18ec0a21 Rayagond Kokatanur 2013-03-26 654 case HWTSTAMP_FILTER_PTP_V2_SYNC:
ceb694997e1b5d4 Giuseppe CAVALLARO 2013-04-08 655 /* PTP v2/802.AS1, any layer, Sync packet */
891434b18ec0a21 Rayagond Kokatanur 2013-03-26 656 config.rx_filter = HWTSTAMP_FILTER_PTP_V2_SYNC;
891434b18ec0a21 Rayagond Kokatanur 2013-03-26 657 ptp_v2 = PTP_TCR_TSVER2ENA;
891434b18ec0a21 Rayagond Kokatanur 2013-03-26 658 /* take time stamp for SYNC messages only */
891434b18ec0a21 Rayagond Kokatanur 2013-03-26 659 ts_event_en = PTP_TCR_TSEVNTENA;
891434b18ec0a21 Rayagond Kokatanur 2013-03-26 660
891434b18ec0a21 Rayagond Kokatanur 2013-03-26 661 ptp_over_ipv4_udp = PTP_TCR_TSIPV4ENA;
891434b18ec0a21 Rayagond Kokatanur 2013-03-26 662 ptp_over_ipv6_udp = PTP_TCR_TSIPV6ENA;
891434b18ec0a21 Rayagond Kokatanur 2013-03-26 663 ptp_over_ethernet = PTP_TCR_TSIPENA;
891434b18ec0a21 Rayagond Kokatanur 2013-03-26 664 break;
891434b18ec0a21 Rayagond Kokatanur 2013-03-26 665
891434b18ec0a21 Rayagond Kokatanur 2013-03-26 666 case HWTSTAMP_FILTER_PTP_V2_DELAY_REQ:
ceb694997e1b5d4 Giuseppe CAVALLARO 2013-04-08 667 /* PTP v2/802.AS1, any layer, Delay_req packet */
891434b18ec0a21 Rayagond Kokatanur 2013-03-26 668 config.rx_filter = HWTSTAMP_FILTER_PTP_V2_DELAY_REQ;
891434b18ec0a21 Rayagond Kokatanur 2013-03-26 669 ptp_v2 = PTP_TCR_TSVER2ENA;
891434b18ec0a21 Rayagond Kokatanur 2013-03-26 670 /* take time stamp for Delay_Req messages only */
891434b18ec0a21 Rayagond Kokatanur 2013-03-26 671 ts_master_en = PTP_TCR_TSMSTRENA;
891434b18ec0a21 Rayagond Kokatanur 2013-03-26 672 ts_event_en = PTP_TCR_TSEVNTENA;
891434b18ec0a21 Rayagond Kokatanur 2013-03-26 673
891434b18ec0a21 Rayagond Kokatanur 2013-03-26 674 ptp_over_ipv4_udp = PTP_TCR_TSIPV4ENA;
891434b18ec0a21 Rayagond Kokatanur 2013-03-26 675 ptp_over_ipv6_udp = PTP_TCR_TSIPV6ENA;
891434b18ec0a21 Rayagond Kokatanur 2013-03-26 676 ptp_over_ethernet = PTP_TCR_TSIPENA;
891434b18ec0a21 Rayagond Kokatanur 2013-03-26 677 break;
891434b18ec0a21 Rayagond Kokatanur 2013-03-26 678
e3412575488ac24 Miroslav Lichvar 2017-05-19 679 case HWTSTAMP_FILTER_NTP_ALL:
891434b18ec0a21 Rayagond Kokatanur 2013-03-26 680 case HWTSTAMP_FILTER_ALL:
ceb694997e1b5d4 Giuseppe CAVALLARO 2013-04-08 681 /* time stamp any incoming packet */
891434b18ec0a21 Rayagond Kokatanur 2013-03-26 682 config.rx_filter = HWTSTAMP_FILTER_ALL;
065911d32306992 Wong, Vincent Por Yin 2019-12-26 683 priv->hwts_all = HWTSTAMP_FILTER_ALL;
891434b18ec0a21 Rayagond Kokatanur 2013-03-26 684 tstamp_all = PTP_TCR_TSENALL;
891434b18ec0a21 Rayagond Kokatanur 2013-03-26 685 break;
891434b18ec0a21 Rayagond Kokatanur 2013-03-26 686
891434b18ec0a21 Rayagond Kokatanur 2013-03-26 687 default:
891434b18ec0a21 Rayagond Kokatanur 2013-03-26 688 return -ERANGE;
891434b18ec0a21 Rayagond Kokatanur 2013-03-26 689 }
891434b18ec0a21 Rayagond Kokatanur 2013-03-26 690 } else {
891434b18ec0a21 Rayagond Kokatanur 2013-03-26 691 switch (config.rx_filter) {
891434b18ec0a21 Rayagond Kokatanur 2013-03-26 692 case HWTSTAMP_FILTER_NONE:
891434b18ec0a21 Rayagond Kokatanur 2013-03-26 693 config.rx_filter = HWTSTAMP_FILTER_NONE;
891434b18ec0a21 Rayagond Kokatanur 2013-03-26 694 break;
891434b18ec0a21 Rayagond Kokatanur 2013-03-26 695 default:
891434b18ec0a21 Rayagond Kokatanur 2013-03-26 696 /* PTP v1, UDP, any kind of event packet */
891434b18ec0a21 Rayagond Kokatanur 2013-03-26 697 config.rx_filter = HWTSTAMP_FILTER_PTP_V1_L4_EVENT;
891434b18ec0a21 Rayagond Kokatanur 2013-03-26 698 break;
891434b18ec0a21 Rayagond Kokatanur 2013-03-26 699 }
891434b18ec0a21 Rayagond Kokatanur 2013-03-26 700 }
891434b18ec0a21 Rayagond Kokatanur 2013-03-26 701 priv->hwts_rx_en = ((config.rx_filter == HWTSTAMP_FILTER_NONE) ? 0 : 1);
5f3da3281932a79 Ben Hutchings 2013-11-14 702 priv->hwts_tx_en = config.tx_type == HWTSTAMP_TX_ON;
891434b18ec0a21 Rayagond Kokatanur 2013-03-26 703
891434b18ec0a21 Rayagond Kokatanur 2013-03-26 704 if (!priv->hwts_tx_en && !priv->hwts_rx_en)
cc4c9001ce31e0c Jose Abreu 2018-04-16 705 stmmac_config_hw_tstamping(priv, priv->ptpaddr, 0);
891434b18ec0a21 Rayagond Kokatanur 2013-03-26 706 else {
891434b18ec0a21 Rayagond Kokatanur 2013-03-26 707 value = (PTP_TCR_TSENA | PTP_TCR_TSCFUPDT | PTP_TCR_TSCTRLSSR |
891434b18ec0a21 Rayagond Kokatanur 2013-03-26 708 tstamp_all | ptp_v2 | ptp_over_ethernet |
891434b18ec0a21 Rayagond Kokatanur 2013-03-26 709 ptp_over_ipv6_udp | ptp_over_ipv4_udp | ts_event_en |
891434b18ec0a21 Rayagond Kokatanur 2013-03-26 710 ts_master_en | snap_type_sel);
0a6241551d20e98 Arnd Bergmann 2015-09-30 711
91c9a87a5d240e8 Wong, Vee Khee 2020-01-31 712 stmmac_config_hw_tstamping(priv, priv->ptpaddr, value);
891434b18ec0a21 Rayagond Kokatanur 2013-03-26 713 }
891434b18ec0a21 Rayagond Kokatanur 2013-03-26 714
d6228b7cdd6e790 Artem Panfilov 2019-01-20 715 memcpy(&priv->tstamp_config, &config, sizeof(config));
d6228b7cdd6e790 Artem Panfilov 2019-01-20 716
891434b18ec0a21 Rayagond Kokatanur 2013-03-26 717 return copy_to_user(ifr->ifr_data, &config,
d6228b7cdd6e790 Artem Panfilov 2019-01-20 718 sizeof(config)) ? -EFAULT : 0;
d6228b7cdd6e790 Artem Panfilov 2019-01-20 719 }
d6228b7cdd6e790 Artem Panfilov 2019-01-20 720
:::::: The code at line 540 was first introduced by commit
:::::: 7d9e6c5afab6bfb932acaef93111448bb876911c net: stmmac: Integrate XGMAC into main driver flow
:::::: TO: Jose Abreu <Jose.Abreu@synopsys.com>
:::::: CC: David S. Miller <davem@davemloft.net>
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org
[-- Attachment #2: config.gz --]
[-- Type: application/gzip, Size: 43762 bytes --]
^ permalink raw reply [flat|nested] 2+ messages in thread
* [intel-linux-intel-lts:5.4/yocto 3846/12652] drivers/net/ethernet/stmicro/stmmac/stmmac_main.c:540:7: warning: variable 'xmac' set but not used
@ 2020-11-12 1:04 kernel test robot
0 siblings, 0 replies; 2+ messages in thread
From: kernel test robot @ 2020-11-12 1:04 UTC (permalink / raw)
To: kbuild-all
[-- Attachment #1: Type: text/plain, Size: 22240 bytes --]
tree: https://github.com/intel/linux-intel-lts.git 5.4/yocto
head: be0f563c86400c13b89cfd69a1cd7ca33f21ed54
commit: 91c9a87a5d240e8b419bf735286ce4cfcea30c34 [3846/12652] net: stmmac: Init PTP clock with system clock
config: arm-randconfig-r034-20201111 (attached as .config)
compiler: arm-linux-gnueabi-gcc (GCC) 9.3.0
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# https://github.com/intel/linux-intel-lts/commit/91c9a87a5d240e8b419bf735286ce4cfcea30c34
git remote add intel-linux-intel-lts https://github.com/intel/linux-intel-lts.git
git fetch --no-tags intel-linux-intel-lts 5.4/yocto
git checkout 91c9a87a5d240e8b419bf735286ce4cfcea30c34
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=arm
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
All warnings (new ones prefixed by >>):
drivers/net/ethernet/stmicro/stmmac/stmmac_main.c: In function 'stmmac_hwtstamp_set':
>> drivers/net/ethernet/stmicro/stmmac/stmmac_main.c:540:7: warning: variable 'xmac' set but not used [-Wunused-but-set-variable]
540 | bool xmac;
| ^~~~
drivers/net/ethernet/stmicro/stmmac/stmmac_main.c: At top level:
drivers/net/ethernet/stmicro/stmmac/stmmac_main.c:1388:6: warning: no previous prototype for 'stmmac_alloc_rx_buffers' [-Wmissing-prototypes]
1388 | bool stmmac_alloc_rx_buffers(struct stmmac_rx_queue *rx_q, u32 count)
| ^~~~~~~~~~~~~~~~~~~~~~~
drivers/net/ethernet/stmicro/stmmac/stmmac_main.c: In function 'stmmac_alloc_rx_buffers':
drivers/net/ethernet/stmicro/stmmac/stmmac_main.c:1414:13: warning: comparison of unsigned expression >= 0 is always true [-Wtype-limits]
1414 | while (--i >= 0)
| ^~
drivers/net/ethernet/stmicro/stmmac/stmmac_main.c: In function 'init_dma_rx_desc_rings':
drivers/net/ethernet/stmicro/stmmac/stmmac_main.c:1522:15: warning: comparison of unsigned expression >= 0 is always true [-Wtype-limits]
1522 | while (queue >= 0) {
| ^~
In file included from include/net/sock.h:46,
from include/linux/tcp.h:19,
from drivers/net/ethernet/stmicro/stmmac/stmmac_main.c:21:
drivers/net/ethernet/stmicro/stmmac/stmmac_main.c: In function 'stmmac_rx':
drivers/net/ethernet/stmicro/stmmac/stmmac_main.c:4623:27: warning: format '%llx' expects argument of type 'long long unsigned int', but argument 6 has type 'dma_addr_t' {aka 'unsigned int'} [-Wformat=]
4623 | netdev_dbg(priv->dev, "\tdesc: %p [entry %d] buff=0x%llx\n",
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
4624 | p, entry, buf->addr);
| ~~~~~~~~~
| |
| dma_addr_t {aka unsigned int}
include/linux/netdevice.h:4767:36: note: in definition of macro 'netdev_dbg'
4767 | netdev_printk(KERN_DEBUG, __dev, format, ##args); \
| ^~~~~~
drivers/net/ethernet/stmicro/stmmac/stmmac_main.c:4623:60: note: format string is defined here
4623 | netdev_dbg(priv->dev, "\tdesc: %p [entry %d] buff=0x%llx\n",
| ~~~^
| |
| long long unsigned int
| %x
drivers/net/ethernet/stmicro/stmmac/stmmac_main.c: At top level:
drivers/net/ethernet/stmicro/stmmac/stmmac_main.c:5601:5: warning: no previous prototype for 'stmmac_xdp_xmit' [-Wmissing-prototypes]
5601 | int stmmac_xdp_xmit(struct net_device *dev, int n, struct xdp_frame **frames,
| ^~~~~~~~~~~~~~~
vim +/xmac +540 drivers/net/ethernet/stmicro/stmmac/stmmac_main.c
891434b18ec0a2 Rayagond Kokatanur 2013-03-26 515
891434b18ec0a2 Rayagond Kokatanur 2013-03-26 516 /**
d6228b7cdd6e79 Artem Panfilov 2019-01-20 517 * stmmac_hwtstamp_set - control hardware timestamping.
891434b18ec0a2 Rayagond Kokatanur 2013-03-26 518 * @dev: device pointer.
8d45e42babb1c7 LABBE Corentin 2017-02-08 519 * @ifr: An IOCTL specific structure, that can contain a pointer to
891434b18ec0a2 Rayagond Kokatanur 2013-03-26 520 * a proprietary structure used to pass information to the driver.
891434b18ec0a2 Rayagond Kokatanur 2013-03-26 521 * Description:
891434b18ec0a2 Rayagond Kokatanur 2013-03-26 522 * This function configures the MAC to enable/disable both outgoing(TX)
891434b18ec0a2 Rayagond Kokatanur 2013-03-26 523 * and incoming(RX) packets time stamping based on user input.
891434b18ec0a2 Rayagond Kokatanur 2013-03-26 524 * Return Value:
891434b18ec0a2 Rayagond Kokatanur 2013-03-26 525 * 0 on success and an appropriate -ve integer on failure.
891434b18ec0a2 Rayagond Kokatanur 2013-03-26 526 */
d6228b7cdd6e79 Artem Panfilov 2019-01-20 527 static int stmmac_hwtstamp_set(struct net_device *dev, struct ifreq *ifr)
891434b18ec0a2 Rayagond Kokatanur 2013-03-26 528 {
891434b18ec0a2 Rayagond Kokatanur 2013-03-26 529 struct stmmac_priv *priv = netdev_priv(dev);
891434b18ec0a2 Rayagond Kokatanur 2013-03-26 530 struct hwtstamp_config config;
891434b18ec0a2 Rayagond Kokatanur 2013-03-26 531 u32 ptp_v2 = 0;
891434b18ec0a2 Rayagond Kokatanur 2013-03-26 532 u32 tstamp_all = 0;
891434b18ec0a2 Rayagond Kokatanur 2013-03-26 533 u32 ptp_over_ipv4_udp = 0;
891434b18ec0a2 Rayagond Kokatanur 2013-03-26 534 u32 ptp_over_ipv6_udp = 0;
891434b18ec0a2 Rayagond Kokatanur 2013-03-26 535 u32 ptp_over_ethernet = 0;
891434b18ec0a2 Rayagond Kokatanur 2013-03-26 536 u32 snap_type_sel = 0;
891434b18ec0a2 Rayagond Kokatanur 2013-03-26 537 u32 ts_master_en = 0;
891434b18ec0a2 Rayagond Kokatanur 2013-03-26 538 u32 ts_event_en = 0;
891434b18ec0a2 Rayagond Kokatanur 2013-03-26 539 u32 value = 0;
7d9e6c5afab6bf Jose Abreu 2018-08-08 @540 bool xmac;
7d9e6c5afab6bf Jose Abreu 2018-08-08 541
7d9e6c5afab6bf Jose Abreu 2018-08-08 542 xmac = priv->plat->has_gmac4 || priv->plat->has_xgmac;
891434b18ec0a2 Rayagond Kokatanur 2013-03-26 543
891434b18ec0a2 Rayagond Kokatanur 2013-03-26 544 if (!(priv->dma_cap.time_stamp || priv->adv_ts)) {
891434b18ec0a2 Rayagond Kokatanur 2013-03-26 545 netdev_alert(priv->dev, "No support for HW time stamping\n");
891434b18ec0a2 Rayagond Kokatanur 2013-03-26 546 priv->hwts_tx_en = 0;
891434b18ec0a2 Rayagond Kokatanur 2013-03-26 547 priv->hwts_rx_en = 0;
891434b18ec0a2 Rayagond Kokatanur 2013-03-26 548
891434b18ec0a2 Rayagond Kokatanur 2013-03-26 549 return -EOPNOTSUPP;
891434b18ec0a2 Rayagond Kokatanur 2013-03-26 550 }
891434b18ec0a2 Rayagond Kokatanur 2013-03-26 551
891434b18ec0a2 Rayagond Kokatanur 2013-03-26 552 if (copy_from_user(&config, ifr->ifr_data,
d6228b7cdd6e79 Artem Panfilov 2019-01-20 553 sizeof(config)))
891434b18ec0a2 Rayagond Kokatanur 2013-03-26 554 return -EFAULT;
891434b18ec0a2 Rayagond Kokatanur 2013-03-26 555
38ddc59d65b6d9 LABBE Corentin 2016-11-16 556 netdev_dbg(priv->dev, "%s config flags:0x%x, tx_type:0x%x, rx_filter:0x%x\n",
891434b18ec0a2 Rayagond Kokatanur 2013-03-26 557 __func__, config.flags, config.tx_type, config.rx_filter);
891434b18ec0a2 Rayagond Kokatanur 2013-03-26 558
891434b18ec0a2 Rayagond Kokatanur 2013-03-26 559 /* reserved for future extensions */
891434b18ec0a2 Rayagond Kokatanur 2013-03-26 560 if (config.flags)
891434b18ec0a2 Rayagond Kokatanur 2013-03-26 561 return -EINVAL;
891434b18ec0a2 Rayagond Kokatanur 2013-03-26 562
5f3da3281932a7 Ben Hutchings 2013-11-14 563 if (config.tx_type != HWTSTAMP_TX_OFF &&
5f3da3281932a7 Ben Hutchings 2013-11-14 564 config.tx_type != HWTSTAMP_TX_ON)
891434b18ec0a2 Rayagond Kokatanur 2013-03-26 565 return -ERANGE;
891434b18ec0a2 Rayagond Kokatanur 2013-03-26 566
891434b18ec0a2 Rayagond Kokatanur 2013-03-26 567 if (priv->adv_ts) {
891434b18ec0a2 Rayagond Kokatanur 2013-03-26 568 switch (config.rx_filter) {
891434b18ec0a2 Rayagond Kokatanur 2013-03-26 569 case HWTSTAMP_FILTER_NONE:
ceb694997e1b5d Giuseppe CAVALLARO 2013-04-08 570 /* time stamp no incoming packet at all */
891434b18ec0a2 Rayagond Kokatanur 2013-03-26 571 config.rx_filter = HWTSTAMP_FILTER_NONE;
891434b18ec0a2 Rayagond Kokatanur 2013-03-26 572 break;
891434b18ec0a2 Rayagond Kokatanur 2013-03-26 573
891434b18ec0a2 Rayagond Kokatanur 2013-03-26 574 case HWTSTAMP_FILTER_PTP_V1_L4_EVENT:
ceb694997e1b5d Giuseppe CAVALLARO 2013-04-08 575 /* PTP v1, UDP, any kind of event packet */
891434b18ec0a2 Rayagond Kokatanur 2013-03-26 576 config.rx_filter = HWTSTAMP_FILTER_PTP_V1_L4_EVENT;
7d8e249f393a1a Ilias Apalodimas 2019-02-05 577 /* 'xmac' hardware can support Sync, Pdelay_Req and
7d8e249f393a1a Ilias Apalodimas 2019-02-05 578 * Pdelay_resp by setting bit14 and bits17/16 to 01
7d8e249f393a1a Ilias Apalodimas 2019-02-05 579 * This leaves Delay_Req timestamps out.
7d8e249f393a1a Ilias Apalodimas 2019-02-05 580 * Enable all events *and* general purpose message
7d8e249f393a1a Ilias Apalodimas 2019-02-05 581 * timestamping
7d8e249f393a1a Ilias Apalodimas 2019-02-05 582 */
891434b18ec0a2 Rayagond Kokatanur 2013-03-26 583 snap_type_sel = PTP_TCR_SNAPTYPSEL_1;
891434b18ec0a2 Rayagond Kokatanur 2013-03-26 584 ptp_over_ipv4_udp = PTP_TCR_TSIPV4ENA;
891434b18ec0a2 Rayagond Kokatanur 2013-03-26 585 ptp_over_ipv6_udp = PTP_TCR_TSIPV6ENA;
891434b18ec0a2 Rayagond Kokatanur 2013-03-26 586 break;
891434b18ec0a2 Rayagond Kokatanur 2013-03-26 587
891434b18ec0a2 Rayagond Kokatanur 2013-03-26 588 case HWTSTAMP_FILTER_PTP_V1_L4_SYNC:
ceb694997e1b5d Giuseppe CAVALLARO 2013-04-08 589 /* PTP v1, UDP, Sync packet */
891434b18ec0a2 Rayagond Kokatanur 2013-03-26 590 config.rx_filter = HWTSTAMP_FILTER_PTP_V1_L4_SYNC;
891434b18ec0a2 Rayagond Kokatanur 2013-03-26 591 /* take time stamp for SYNC messages only */
891434b18ec0a2 Rayagond Kokatanur 2013-03-26 592 ts_event_en = PTP_TCR_TSEVNTENA;
891434b18ec0a2 Rayagond Kokatanur 2013-03-26 593
891434b18ec0a2 Rayagond Kokatanur 2013-03-26 594 ptp_over_ipv4_udp = PTP_TCR_TSIPV4ENA;
891434b18ec0a2 Rayagond Kokatanur 2013-03-26 595 ptp_over_ipv6_udp = PTP_TCR_TSIPV6ENA;
891434b18ec0a2 Rayagond Kokatanur 2013-03-26 596 break;
891434b18ec0a2 Rayagond Kokatanur 2013-03-26 597
891434b18ec0a2 Rayagond Kokatanur 2013-03-26 598 case HWTSTAMP_FILTER_PTP_V1_L4_DELAY_REQ:
ceb694997e1b5d Giuseppe CAVALLARO 2013-04-08 599 /* PTP v1, UDP, Delay_req packet */
891434b18ec0a2 Rayagond Kokatanur 2013-03-26 600 config.rx_filter = HWTSTAMP_FILTER_PTP_V1_L4_DELAY_REQ;
891434b18ec0a2 Rayagond Kokatanur 2013-03-26 601 /* take time stamp for Delay_Req messages only */
891434b18ec0a2 Rayagond Kokatanur 2013-03-26 602 ts_master_en = PTP_TCR_TSMSTRENA;
891434b18ec0a2 Rayagond Kokatanur 2013-03-26 603 ts_event_en = PTP_TCR_TSEVNTENA;
891434b18ec0a2 Rayagond Kokatanur 2013-03-26 604
891434b18ec0a2 Rayagond Kokatanur 2013-03-26 605 ptp_over_ipv4_udp = PTP_TCR_TSIPV4ENA;
891434b18ec0a2 Rayagond Kokatanur 2013-03-26 606 ptp_over_ipv6_udp = PTP_TCR_TSIPV6ENA;
891434b18ec0a2 Rayagond Kokatanur 2013-03-26 607 break;
891434b18ec0a2 Rayagond Kokatanur 2013-03-26 608
891434b18ec0a2 Rayagond Kokatanur 2013-03-26 609 case HWTSTAMP_FILTER_PTP_V2_L4_EVENT:
ceb694997e1b5d Giuseppe CAVALLARO 2013-04-08 610 /* PTP v2, UDP, any kind of event packet */
891434b18ec0a2 Rayagond Kokatanur 2013-03-26 611 config.rx_filter = HWTSTAMP_FILTER_PTP_V2_L4_EVENT;
891434b18ec0a2 Rayagond Kokatanur 2013-03-26 612 ptp_v2 = PTP_TCR_TSVER2ENA;
891434b18ec0a2 Rayagond Kokatanur 2013-03-26 613 /* take time stamp for all event messages */
891434b18ec0a2 Rayagond Kokatanur 2013-03-26 614 snap_type_sel = PTP_TCR_SNAPTYPSEL_1;
891434b18ec0a2 Rayagond Kokatanur 2013-03-26 615
891434b18ec0a2 Rayagond Kokatanur 2013-03-26 616 ptp_over_ipv4_udp = PTP_TCR_TSIPV4ENA;
891434b18ec0a2 Rayagond Kokatanur 2013-03-26 617 ptp_over_ipv6_udp = PTP_TCR_TSIPV6ENA;
891434b18ec0a2 Rayagond Kokatanur 2013-03-26 618 break;
891434b18ec0a2 Rayagond Kokatanur 2013-03-26 619
891434b18ec0a2 Rayagond Kokatanur 2013-03-26 620 case HWTSTAMP_FILTER_PTP_V2_L4_SYNC:
ceb694997e1b5d Giuseppe CAVALLARO 2013-04-08 621 /* PTP v2, UDP, Sync packet */
891434b18ec0a2 Rayagond Kokatanur 2013-03-26 622 config.rx_filter = HWTSTAMP_FILTER_PTP_V2_L4_SYNC;
891434b18ec0a2 Rayagond Kokatanur 2013-03-26 623 ptp_v2 = PTP_TCR_TSVER2ENA;
891434b18ec0a2 Rayagond Kokatanur 2013-03-26 624 /* take time stamp for SYNC messages only */
891434b18ec0a2 Rayagond Kokatanur 2013-03-26 625 ts_event_en = PTP_TCR_TSEVNTENA;
891434b18ec0a2 Rayagond Kokatanur 2013-03-26 626
891434b18ec0a2 Rayagond Kokatanur 2013-03-26 627 ptp_over_ipv4_udp = PTP_TCR_TSIPV4ENA;
891434b18ec0a2 Rayagond Kokatanur 2013-03-26 628 ptp_over_ipv6_udp = PTP_TCR_TSIPV6ENA;
891434b18ec0a2 Rayagond Kokatanur 2013-03-26 629 break;
891434b18ec0a2 Rayagond Kokatanur 2013-03-26 630
891434b18ec0a2 Rayagond Kokatanur 2013-03-26 631 case HWTSTAMP_FILTER_PTP_V2_L4_DELAY_REQ:
ceb694997e1b5d Giuseppe CAVALLARO 2013-04-08 632 /* PTP v2, UDP, Delay_req packet */
891434b18ec0a2 Rayagond Kokatanur 2013-03-26 633 config.rx_filter = HWTSTAMP_FILTER_PTP_V2_L4_DELAY_REQ;
891434b18ec0a2 Rayagond Kokatanur 2013-03-26 634 ptp_v2 = PTP_TCR_TSVER2ENA;
891434b18ec0a2 Rayagond Kokatanur 2013-03-26 635 /* take time stamp for Delay_Req messages only */
891434b18ec0a2 Rayagond Kokatanur 2013-03-26 636 ts_master_en = PTP_TCR_TSMSTRENA;
891434b18ec0a2 Rayagond Kokatanur 2013-03-26 637 ts_event_en = PTP_TCR_TSEVNTENA;
891434b18ec0a2 Rayagond Kokatanur 2013-03-26 638
891434b18ec0a2 Rayagond Kokatanur 2013-03-26 639 ptp_over_ipv4_udp = PTP_TCR_TSIPV4ENA;
891434b18ec0a2 Rayagond Kokatanur 2013-03-26 640 ptp_over_ipv6_udp = PTP_TCR_TSIPV6ENA;
891434b18ec0a2 Rayagond Kokatanur 2013-03-26 641 break;
891434b18ec0a2 Rayagond Kokatanur 2013-03-26 642
891434b18ec0a2 Rayagond Kokatanur 2013-03-26 643 case HWTSTAMP_FILTER_PTP_V2_EVENT:
ceb694997e1b5d Giuseppe CAVALLARO 2013-04-08 644 /* PTP v2/802.AS1 any layer, any kind of event packet */
891434b18ec0a2 Rayagond Kokatanur 2013-03-26 645 config.rx_filter = HWTSTAMP_FILTER_PTP_V2_EVENT;
891434b18ec0a2 Rayagond Kokatanur 2013-03-26 646 ptp_v2 = PTP_TCR_TSVER2ENA;
891434b18ec0a2 Rayagond Kokatanur 2013-03-26 647 snap_type_sel = PTP_TCR_SNAPTYPSEL_1;
14f347334bf232 Jose Abreu 2019-09-30 648 ts_event_en = PTP_TCR_TSEVNTENA;
891434b18ec0a2 Rayagond Kokatanur 2013-03-26 649 ptp_over_ipv4_udp = PTP_TCR_TSIPV4ENA;
891434b18ec0a2 Rayagond Kokatanur 2013-03-26 650 ptp_over_ipv6_udp = PTP_TCR_TSIPV6ENA;
891434b18ec0a2 Rayagond Kokatanur 2013-03-26 651 ptp_over_ethernet = PTP_TCR_TSIPENA;
891434b18ec0a2 Rayagond Kokatanur 2013-03-26 652 break;
891434b18ec0a2 Rayagond Kokatanur 2013-03-26 653
891434b18ec0a2 Rayagond Kokatanur 2013-03-26 654 case HWTSTAMP_FILTER_PTP_V2_SYNC:
ceb694997e1b5d Giuseppe CAVALLARO 2013-04-08 655 /* PTP v2/802.AS1, any layer, Sync packet */
891434b18ec0a2 Rayagond Kokatanur 2013-03-26 656 config.rx_filter = HWTSTAMP_FILTER_PTP_V2_SYNC;
891434b18ec0a2 Rayagond Kokatanur 2013-03-26 657 ptp_v2 = PTP_TCR_TSVER2ENA;
891434b18ec0a2 Rayagond Kokatanur 2013-03-26 658 /* take time stamp for SYNC messages only */
891434b18ec0a2 Rayagond Kokatanur 2013-03-26 659 ts_event_en = PTP_TCR_TSEVNTENA;
891434b18ec0a2 Rayagond Kokatanur 2013-03-26 660
891434b18ec0a2 Rayagond Kokatanur 2013-03-26 661 ptp_over_ipv4_udp = PTP_TCR_TSIPV4ENA;
891434b18ec0a2 Rayagond Kokatanur 2013-03-26 662 ptp_over_ipv6_udp = PTP_TCR_TSIPV6ENA;
891434b18ec0a2 Rayagond Kokatanur 2013-03-26 663 ptp_over_ethernet = PTP_TCR_TSIPENA;
891434b18ec0a2 Rayagond Kokatanur 2013-03-26 664 break;
891434b18ec0a2 Rayagond Kokatanur 2013-03-26 665
891434b18ec0a2 Rayagond Kokatanur 2013-03-26 666 case HWTSTAMP_FILTER_PTP_V2_DELAY_REQ:
ceb694997e1b5d Giuseppe CAVALLARO 2013-04-08 667 /* PTP v2/802.AS1, any layer, Delay_req packet */
891434b18ec0a2 Rayagond Kokatanur 2013-03-26 668 config.rx_filter = HWTSTAMP_FILTER_PTP_V2_DELAY_REQ;
891434b18ec0a2 Rayagond Kokatanur 2013-03-26 669 ptp_v2 = PTP_TCR_TSVER2ENA;
891434b18ec0a2 Rayagond Kokatanur 2013-03-26 670 /* take time stamp for Delay_Req messages only */
891434b18ec0a2 Rayagond Kokatanur 2013-03-26 671 ts_master_en = PTP_TCR_TSMSTRENA;
891434b18ec0a2 Rayagond Kokatanur 2013-03-26 672 ts_event_en = PTP_TCR_TSEVNTENA;
891434b18ec0a2 Rayagond Kokatanur 2013-03-26 673
891434b18ec0a2 Rayagond Kokatanur 2013-03-26 674 ptp_over_ipv4_udp = PTP_TCR_TSIPV4ENA;
891434b18ec0a2 Rayagond Kokatanur 2013-03-26 675 ptp_over_ipv6_udp = PTP_TCR_TSIPV6ENA;
891434b18ec0a2 Rayagond Kokatanur 2013-03-26 676 ptp_over_ethernet = PTP_TCR_TSIPENA;
891434b18ec0a2 Rayagond Kokatanur 2013-03-26 677 break;
891434b18ec0a2 Rayagond Kokatanur 2013-03-26 678
e3412575488ac2 Miroslav Lichvar 2017-05-19 679 case HWTSTAMP_FILTER_NTP_ALL:
891434b18ec0a2 Rayagond Kokatanur 2013-03-26 680 case HWTSTAMP_FILTER_ALL:
ceb694997e1b5d Giuseppe CAVALLARO 2013-04-08 681 /* time stamp any incoming packet */
891434b18ec0a2 Rayagond Kokatanur 2013-03-26 682 config.rx_filter = HWTSTAMP_FILTER_ALL;
065911d3230699 Wong, Vincent Por Yin 2019-12-26 683 priv->hwts_all = HWTSTAMP_FILTER_ALL;
891434b18ec0a2 Rayagond Kokatanur 2013-03-26 684 tstamp_all = PTP_TCR_TSENALL;
891434b18ec0a2 Rayagond Kokatanur 2013-03-26 685 break;
891434b18ec0a2 Rayagond Kokatanur 2013-03-26 686
891434b18ec0a2 Rayagond Kokatanur 2013-03-26 687 default:
891434b18ec0a2 Rayagond Kokatanur 2013-03-26 688 return -ERANGE;
891434b18ec0a2 Rayagond Kokatanur 2013-03-26 689 }
891434b18ec0a2 Rayagond Kokatanur 2013-03-26 690 } else {
891434b18ec0a2 Rayagond Kokatanur 2013-03-26 691 switch (config.rx_filter) {
891434b18ec0a2 Rayagond Kokatanur 2013-03-26 692 case HWTSTAMP_FILTER_NONE:
891434b18ec0a2 Rayagond Kokatanur 2013-03-26 693 config.rx_filter = HWTSTAMP_FILTER_NONE;
891434b18ec0a2 Rayagond Kokatanur 2013-03-26 694 break;
891434b18ec0a2 Rayagond Kokatanur 2013-03-26 695 default:
891434b18ec0a2 Rayagond Kokatanur 2013-03-26 696 /* PTP v1, UDP, any kind of event packet */
891434b18ec0a2 Rayagond Kokatanur 2013-03-26 697 config.rx_filter = HWTSTAMP_FILTER_PTP_V1_L4_EVENT;
891434b18ec0a2 Rayagond Kokatanur 2013-03-26 698 break;
891434b18ec0a2 Rayagond Kokatanur 2013-03-26 699 }
891434b18ec0a2 Rayagond Kokatanur 2013-03-26 700 }
891434b18ec0a2 Rayagond Kokatanur 2013-03-26 701 priv->hwts_rx_en = ((config.rx_filter == HWTSTAMP_FILTER_NONE) ? 0 : 1);
5f3da3281932a7 Ben Hutchings 2013-11-14 702 priv->hwts_tx_en = config.tx_type == HWTSTAMP_TX_ON;
891434b18ec0a2 Rayagond Kokatanur 2013-03-26 703
891434b18ec0a2 Rayagond Kokatanur 2013-03-26 704 if (!priv->hwts_tx_en && !priv->hwts_rx_en)
cc4c9001ce31e0 Jose Abreu 2018-04-16 705 stmmac_config_hw_tstamping(priv, priv->ptpaddr, 0);
891434b18ec0a2 Rayagond Kokatanur 2013-03-26 706 else {
891434b18ec0a2 Rayagond Kokatanur 2013-03-26 707 value = (PTP_TCR_TSENA | PTP_TCR_TSCFUPDT | PTP_TCR_TSCTRLSSR |
891434b18ec0a2 Rayagond Kokatanur 2013-03-26 708 tstamp_all | ptp_v2 | ptp_over_ethernet |
891434b18ec0a2 Rayagond Kokatanur 2013-03-26 709 ptp_over_ipv6_udp | ptp_over_ipv4_udp | ts_event_en |
891434b18ec0a2 Rayagond Kokatanur 2013-03-26 710 ts_master_en | snap_type_sel);
0a6241551d20e9 Arnd Bergmann 2015-09-30 711
91c9a87a5d240e Wong, Vee Khee 2020-01-31 712 stmmac_config_hw_tstamping(priv, priv->ptpaddr, value);
891434b18ec0a2 Rayagond Kokatanur 2013-03-26 713 }
891434b18ec0a2 Rayagond Kokatanur 2013-03-26 714
d6228b7cdd6e79 Artem Panfilov 2019-01-20 715 memcpy(&priv->tstamp_config, &config, sizeof(config));
d6228b7cdd6e79 Artem Panfilov 2019-01-20 716
891434b18ec0a2 Rayagond Kokatanur 2013-03-26 717 return copy_to_user(ifr->ifr_data, &config,
d6228b7cdd6e79 Artem Panfilov 2019-01-20 718 sizeof(config)) ? -EFAULT : 0;
d6228b7cdd6e79 Artem Panfilov 2019-01-20 719 }
d6228b7cdd6e79 Artem Panfilov 2019-01-20 720
:::::: The code at line 540 was first introduced by commit
:::::: 7d9e6c5afab6bfb932acaef93111448bb876911c net: stmmac: Integrate XGMAC into main driver flow
:::::: TO: Jose Abreu <Jose.Abreu@synopsys.com>
:::::: CC: David S. Miller <davem@davemloft.net>
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org
[-- Attachment #2: config.gz --]
[-- Type: application/gzip, Size: 43762 bytes --]
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-11-12 2:30 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-11-12 2:30 [intel-linux-intel-lts:5.4/yocto 3846/12652] drivers/net/ethernet/stmicro/stmmac/stmmac_main.c:540:7: warning: variable 'xmac' set but not used kernel test robot
-- strict thread matches above, loose matches on Subject: below --
2020-11-12 1:04 kernel test robot
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.