* [PATCH v3 0/4] Categorize some uncategorized devices
@ 2020-11-12 12:58 Gan Qixin
2020-11-12 12:58 ` [PATCH v3 1/4] ssd0323: put it into the 'display' category Gan Qixin
` (3 more replies)
0 siblings, 4 replies; 11+ messages in thread
From: Gan Qixin @ 2020-11-12 12:58 UTC (permalink / raw)
To: qemu-devel, qemu-trivial
Cc: thuth, zhang.zhanghailiang, mst, laurent, armbru, Gan Qixin,
kuhn.chenqun, philmd
v1->v2:
Correct some spelling errors and limit commit message line length
to around 70.
v2->v3:
Changes suggested by Peter Maydell:
ads7846 is a touch-screen controller, so put it into the 'input'
category instead of 'display' category.
Gan Qixin (4):
ssd0323: put it into the 'display' category
ads7846: put it into the 'input' category
nand: put it into the 'storage' category
max111x: put it into the 'misc' category
hw/block/nand.c | 1 +
hw/display/ads7846.c | 2 ++
hw/display/ssd0323.c | 1 +
hw/misc/max111x.c | 1 +
4 files changed, 5 insertions(+)
--
2.23.0
^ permalink raw reply [flat|nested] 11+ messages in thread
* [PATCH v3 1/4] ssd0323: put it into the 'display' category
2020-11-12 12:58 [PATCH v3 0/4] Categorize some uncategorized devices Gan Qixin
@ 2020-11-12 12:58 ` Gan Qixin
2020-11-16 12:45 ` Philippe Mathieu-Daudé
2020-11-12 12:58 ` [PATCH v3 2/4] ads7846: put it into the 'input' category Gan Qixin
` (2 subsequent siblings)
3 siblings, 1 reply; 11+ messages in thread
From: Gan Qixin @ 2020-11-12 12:58 UTC (permalink / raw)
To: qemu-devel, qemu-trivial
Cc: thuth, zhang.zhanghailiang, mst, laurent, armbru, Gan Qixin,
kuhn.chenqun, philmd
The category of the ssd0323 device is not set, put it into the 'display'
category.
Signed-off-by: Gan Qixin <ganqixin@huawei.com>
Reviewed-by: Thomas Huth <thuth@redhat.com>
---
hw/display/ssd0323.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/hw/display/ssd0323.c b/hw/display/ssd0323.c
index 17d4b32ae3..cbfd21dfd5 100644
--- a/hw/display/ssd0323.c
+++ b/hw/display/ssd0323.c
@@ -370,6 +370,7 @@ static void ssd0323_class_init(ObjectClass *klass, void *data)
k->transfer = ssd0323_transfer;
k->cs_polarity = SSI_CS_HIGH;
dc->vmsd = &vmstate_ssd0323;
+ set_bit(DEVICE_CATEGORY_DISPLAY, dc->categories);
}
static const TypeInfo ssd0323_info = {
--
2.23.0
^ permalink raw reply related [flat|nested] 11+ messages in thread
* [PATCH v3 2/4] ads7846: put it into the 'input' category
2020-11-12 12:58 [PATCH v3 0/4] Categorize some uncategorized devices Gan Qixin
2020-11-12 12:58 ` [PATCH v3 1/4] ssd0323: put it into the 'display' category Gan Qixin
@ 2020-11-12 12:58 ` Gan Qixin
2020-11-13 10:12 ` Peter Maydell
2020-11-16 12:46 ` Philippe Mathieu-Daudé
2020-11-12 12:58 ` [PATCH v3 3/4] nand: put it into the 'storage' category Gan Qixin
2020-11-12 12:58 ` [PATCH v3 4/4] max111x: put it into the 'misc' category Gan Qixin
3 siblings, 2 replies; 11+ messages in thread
From: Gan Qixin @ 2020-11-12 12:58 UTC (permalink / raw)
To: qemu-devel, qemu-trivial
Cc: Peter Maydell, thuth, zhang.zhanghailiang, mst, laurent, armbru,
Gan Qixin, kuhn.chenqun, philmd
The category of the ads7846 device is not set, put it into the 'input'
category.
Signed-off-by: Gan Qixin <ganqixin@huawei.com>
---
Cc: Peter Maydell <peter.maydell@linaro.org>
---
hw/display/ads7846.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/hw/display/ads7846.c b/hw/display/ads7846.c
index 023165b2a3..cb3a431cfd 100644
--- a/hw/display/ads7846.c
+++ b/hw/display/ads7846.c
@@ -163,10 +163,12 @@ static void ads7846_realize(SSISlave *d, Error **errp)
static void ads7846_class_init(ObjectClass *klass, void *data)
{
+ DeviceClass *dc = DEVICE_CLASS(klass);
SSISlaveClass *k = SSI_SLAVE_CLASS(klass);
k->realize = ads7846_realize;
k->transfer = ads7846_transfer;
+ set_bit(DEVICE_CATEGORY_INPUT, dc->categories);
}
static const TypeInfo ads7846_info = {
--
2.23.0
^ permalink raw reply related [flat|nested] 11+ messages in thread
* [PATCH v3 3/4] nand: put it into the 'storage' category
2020-11-12 12:58 [PATCH v3 0/4] Categorize some uncategorized devices Gan Qixin
2020-11-12 12:58 ` [PATCH v3 1/4] ssd0323: put it into the 'display' category Gan Qixin
2020-11-12 12:58 ` [PATCH v3 2/4] ads7846: put it into the 'input' category Gan Qixin
@ 2020-11-12 12:58 ` Gan Qixin
2020-11-16 12:45 ` Philippe Mathieu-Daudé
2020-11-12 12:58 ` [PATCH v3 4/4] max111x: put it into the 'misc' category Gan Qixin
3 siblings, 1 reply; 11+ messages in thread
From: Gan Qixin @ 2020-11-12 12:58 UTC (permalink / raw)
To: qemu-devel, qemu-trivial
Cc: thuth, zhang.zhanghailiang, mst, laurent, armbru, Gan Qixin,
kuhn.chenqun, philmd
The category of the nand device is not set, put it into the 'storage'
category.
Signed-off-by: Gan Qixin <ganqixin@huawei.com>
Reviewed-by: Thomas Huth <thuth@redhat.com>
---
hw/block/nand.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/hw/block/nand.c b/hw/block/nand.c
index bcceb64ebb..1d7a48a2ec 100644
--- a/hw/block/nand.c
+++ b/hw/block/nand.c
@@ -449,6 +449,7 @@ static void nand_class_init(ObjectClass *klass, void *data)
dc->reset = nand_reset;
dc->vmsd = &vmstate_nand;
device_class_set_props(dc, nand_properties);
+ set_bit(DEVICE_CATEGORY_STORAGE, dc->categories);
}
static const TypeInfo nand_info = {
--
2.23.0
^ permalink raw reply related [flat|nested] 11+ messages in thread
* [PATCH v3 4/4] max111x: put it into the 'misc' category
2020-11-12 12:58 [PATCH v3 0/4] Categorize some uncategorized devices Gan Qixin
` (2 preceding siblings ...)
2020-11-12 12:58 ` [PATCH v3 3/4] nand: put it into the 'storage' category Gan Qixin
@ 2020-11-12 12:58 ` Gan Qixin
2020-11-13 7:14 ` Thomas Huth
3 siblings, 1 reply; 11+ messages in thread
From: Gan Qixin @ 2020-11-12 12:58 UTC (permalink / raw)
To: qemu-devel, qemu-trivial
Cc: thuth, zhang.zhanghailiang, mst, laurent, armbru, Gan Qixin,
kuhn.chenqun, philmd
The category of the max111x device is not set, put it into the 'misc'
category.
Signed-off-by: Gan Qixin <ganqixin@huawei.com>
---
hw/misc/max111x.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/hw/misc/max111x.c b/hw/misc/max111x.c
index 7e6723f343..eae0f9b598 100644
--- a/hw/misc/max111x.c
+++ b/hw/misc/max111x.c
@@ -185,6 +185,7 @@ static void max111x_class_init(ObjectClass *klass, void *data)
k->transfer = max111x_transfer;
dc->reset = max111x_reset;
dc->vmsd = &vmstate_max111x;
+ set_bit(DEVICE_CATEGORY_MISC, dc->categories);
}
static const TypeInfo max111x_info = {
--
2.23.0
^ permalink raw reply related [flat|nested] 11+ messages in thread
* Re: [PATCH v3 4/4] max111x: put it into the 'misc' category
2020-11-12 12:58 ` [PATCH v3 4/4] max111x: put it into the 'misc' category Gan Qixin
@ 2020-11-13 7:14 ` Thomas Huth
0 siblings, 0 replies; 11+ messages in thread
From: Thomas Huth @ 2020-11-13 7:14 UTC (permalink / raw)
To: Gan Qixin, qemu-devel, qemu-trivial
Cc: zhang.zhanghailiang, mst, laurent, armbru, kuhn.chenqun, philmd
On 12/11/2020 13.58, Gan Qixin wrote:
> The category of the max111x device is not set, put it into the 'misc'
> category.
>
> Signed-off-by: Gan Qixin <ganqixin@huawei.com>
> ---
> hw/misc/max111x.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/hw/misc/max111x.c b/hw/misc/max111x.c
> index 7e6723f343..eae0f9b598 100644
> --- a/hw/misc/max111x.c
> +++ b/hw/misc/max111x.c
> @@ -185,6 +185,7 @@ static void max111x_class_init(ObjectClass *klass, void *data)
> k->transfer = max111x_transfer;
> dc->reset = max111x_reset;
> dc->vmsd = &vmstate_max111x;
> + set_bit(DEVICE_CATEGORY_MISC, dc->categories);
> }
>
> static const TypeInfo max111x_info = {
>
Reviewed-by: Thomas Huth <thuth@redhat.com>
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH v3 2/4] ads7846: put it into the 'input' category
2020-11-12 12:58 ` [PATCH v3 2/4] ads7846: put it into the 'input' category Gan Qixin
@ 2020-11-13 10:12 ` Peter Maydell
2020-11-13 11:14 ` ganqixin
2020-11-16 12:46 ` Philippe Mathieu-Daudé
1 sibling, 1 reply; 11+ messages in thread
From: Peter Maydell @ 2020-11-13 10:12 UTC (permalink / raw)
To: Gan Qixin
Cc: Thomas Huth, zhanghailiang, Michael S. Tsirkin, QEMU Trivial,
Markus Armbruster, QEMU Developers, Chenqun (kuhn),
Philippe Mathieu-Daudé,
Laurent Vivier
On Fri, 13 Nov 2020 at 03:32, Gan Qixin <ganqixin@huawei.com> wrote:
>
> The category of the ads7846 device is not set, put it into the 'input'
> category.
>
> Signed-off-by: Gan Qixin <ganqixin@huawei.com>
> ---
> Cc: Peter Maydell <peter.maydell@linaro.org>
> ---
> hw/display/ads7846.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/hw/display/ads7846.c b/hw/display/ads7846.c
> index 023165b2a3..cb3a431cfd 100644
> --- a/hw/display/ads7846.c
> +++ b/hw/display/ads7846.c
> @@ -163,10 +163,12 @@ static void ads7846_realize(SSISlave *d, Error **errp)
>
> static void ads7846_class_init(ObjectClass *klass, void *data)
> {
> + DeviceClass *dc = DEVICE_CLASS(klass);
> SSISlaveClass *k = SSI_SLAVE_CLASS(klass);
>
> k->realize = ads7846_realize;
> k->transfer = ads7846_transfer;
> + set_bit(DEVICE_CATEGORY_INPUT, dc->categories);
> }
>
> static const TypeInfo ads7846_info = {
Reviewed-by: Peter Maydell <peter.maydell@linaro.org>
Really we should move the file too...
thanks
-- PMM
^ permalink raw reply [flat|nested] 11+ messages in thread
* RE: [PATCH v3 2/4] ads7846: put it into the 'input' category
2020-11-13 10:12 ` Peter Maydell
@ 2020-11-13 11:14 ` ganqixin
0 siblings, 0 replies; 11+ messages in thread
From: ganqixin @ 2020-11-13 11:14 UTC (permalink / raw)
To: Peter Maydell
Cc: Thomas Huth, Zhanghailiang, Michael S. Tsirkin, QEMU Trivial,
Markus Armbruster, QEMU Developers, Chenqun (kuhn),
Philippe Mathieu-Daudé,
Laurent Vivier
> -----Original Message-----
> From: Peter Maydell [mailto:peter.maydell@linaro.org]
> Sent: Friday, November 13, 2020 6:13 PM
> To: ganqixin <ganqixin@huawei.com>
> Cc: QEMU Developers <qemu-devel@nongnu.org>; QEMU Trivial
> <qemu-trivial@nongnu.org>; Thomas Huth <thuth@redhat.com>; Laurent
> Vivier <laurent@vivier.eu>; Philippe Mathieu-Daudé <philmd@redhat.com>;
> Markus Armbruster <armbru@redhat.com>; Michael S. Tsirkin
> <mst@redhat.com>; Chenqun (kuhn) <kuhn.chenqun@huawei.com>;
> Zhanghailiang <zhang.zhanghailiang@huawei.com>
> Subject: Re: [PATCH v3 2/4] ads7846: put it into the 'input' category
>
> On Fri, 13 Nov 2020 at 03:32, Gan Qixin <ganqixin@huawei.com> wrote:
> >
> > The category of the ads7846 device is not set, put it into the 'input'
> > category.
> >
> > Signed-off-by: Gan Qixin <ganqixin@huawei.com>
> > ---
> > Cc: Peter Maydell <peter.maydell@linaro.org>
> > ---
> > hw/display/ads7846.c | 2 ++
> > 1 file changed, 2 insertions(+)
> >
> > diff --git a/hw/display/ads7846.c b/hw/display/ads7846.c index
> > 023165b2a3..cb3a431cfd 100644
> > --- a/hw/display/ads7846.c
> > +++ b/hw/display/ads7846.c
> > @@ -163,10 +163,12 @@ static void ads7846_realize(SSISlave *d, Error
> > **errp)
> >
> > static void ads7846_class_init(ObjectClass *klass, void *data) {
> > + DeviceClass *dc = DEVICE_CLASS(klass);
> > SSISlaveClass *k = SSI_SLAVE_CLASS(klass);
> >
> > k->realize = ads7846_realize;
> > k->transfer = ads7846_transfer;
> > + set_bit(DEVICE_CATEGORY_INPUT, dc->categories);
> > }
> >
> > static const TypeInfo ads7846_info = {
>
> Reviewed-by: Peter Maydell <peter.maydell@linaro.org>
>
> Really we should move the file too...
>
OK, I will try to move the file to the correct folder:)
Gan Qixin
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH v3 1/4] ssd0323: put it into the 'display' category
2020-11-12 12:58 ` [PATCH v3 1/4] ssd0323: put it into the 'display' category Gan Qixin
@ 2020-11-16 12:45 ` Philippe Mathieu-Daudé
0 siblings, 0 replies; 11+ messages in thread
From: Philippe Mathieu-Daudé @ 2020-11-16 12:45 UTC (permalink / raw)
To: Gan Qixin, qemu-devel, qemu-trivial
Cc: thuth, zhang.zhanghailiang, mst, laurent, armbru, kuhn.chenqun
On 11/12/20 1:58 PM, Gan Qixin wrote:
> The category of the ssd0323 device is not set, put it into the 'display'
> category.
>
> Signed-off-by: Gan Qixin <ganqixin@huawei.com>
> Reviewed-by: Thomas Huth <thuth@redhat.com>
> ---
> hw/display/ssd0323.c | 1 +
> 1 file changed, 1 insertion(+)
Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH v3 3/4] nand: put it into the 'storage' category
2020-11-12 12:58 ` [PATCH v3 3/4] nand: put it into the 'storage' category Gan Qixin
@ 2020-11-16 12:45 ` Philippe Mathieu-Daudé
0 siblings, 0 replies; 11+ messages in thread
From: Philippe Mathieu-Daudé @ 2020-11-16 12:45 UTC (permalink / raw)
To: Gan Qixin, qemu-devel, qemu-trivial
Cc: thuth, zhang.zhanghailiang, mst, laurent, armbru, kuhn.chenqun
On 11/12/20 1:58 PM, Gan Qixin wrote:
> The category of the nand device is not set, put it into the 'storage'
> category.
>
> Signed-off-by: Gan Qixin <ganqixin@huawei.com>
> Reviewed-by: Thomas Huth <thuth@redhat.com>
> ---
> hw/block/nand.c | 1 +
> 1 file changed, 1 insertion(+)
Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH v3 2/4] ads7846: put it into the 'input' category
2020-11-12 12:58 ` [PATCH v3 2/4] ads7846: put it into the 'input' category Gan Qixin
2020-11-13 10:12 ` Peter Maydell
@ 2020-11-16 12:46 ` Philippe Mathieu-Daudé
1 sibling, 0 replies; 11+ messages in thread
From: Philippe Mathieu-Daudé @ 2020-11-16 12:46 UTC (permalink / raw)
To: Gan Qixin, qemu-devel, qemu-trivial
Cc: Peter Maydell, thuth, zhang.zhanghailiang, mst, laurent, armbru,
kuhn.chenqun
On 11/12/20 1:58 PM, Gan Qixin wrote:
> The category of the ads7846 device is not set, put it into the 'input'
> category.
>
> Signed-off-by: Gan Qixin <ganqixin@huawei.com>
> ---
> Cc: Peter Maydell <peter.maydell@linaro.org>
> ---
> hw/display/ads7846.c | 2 ++
> 1 file changed, 2 insertions(+)
Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
^ permalink raw reply [flat|nested] 11+ messages in thread
end of thread, other threads:[~2020-11-16 12:49 UTC | newest]
Thread overview: 11+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-11-12 12:58 [PATCH v3 0/4] Categorize some uncategorized devices Gan Qixin
2020-11-12 12:58 ` [PATCH v3 1/4] ssd0323: put it into the 'display' category Gan Qixin
2020-11-16 12:45 ` Philippe Mathieu-Daudé
2020-11-12 12:58 ` [PATCH v3 2/4] ads7846: put it into the 'input' category Gan Qixin
2020-11-13 10:12 ` Peter Maydell
2020-11-13 11:14 ` ganqixin
2020-11-16 12:46 ` Philippe Mathieu-Daudé
2020-11-12 12:58 ` [PATCH v3 3/4] nand: put it into the 'storage' category Gan Qixin
2020-11-16 12:45 ` Philippe Mathieu-Daudé
2020-11-12 12:58 ` [PATCH v3 4/4] max111x: put it into the 'misc' category Gan Qixin
2020-11-13 7:14 ` Thomas Huth
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.