All of lore.kernel.org
 help / color / mirror / Atom feed
From: kernel test robot <lkp@intel.com>
To: wenxu@ucloud.cn, kuba@kernel.org, marcelo.leitner@gmail.com,
	vladbu@nvidia.com
Cc: kbuild-all@lists.01.org, netdev@vger.kernel.org
Subject: Re: [PATCH v8 net-next 3/3] net/sched: act_frag: add implict packet fragment support.
Date: Thu, 12 Nov 2020 23:05:22 +0800	[thread overview]
Message-ID: <20201112150522.GC21214@xsang-OptiPlex-9020> (raw)
In-Reply-To: <1605076100-21782-4-git-send-email-wenxu@ucloud.cn>

[-- Attachment #1: Type: text/plain, Size: 4921 bytes --]

Hi,

Thank you for the patch! Perhaps something to improve:

[auto build test WARNING on net-next/master]

url:    https://github.com/0day-ci/linux/commits/wenxu-ucloud-cn/net-sched-fix-over-mtu-packet-of-defrag-in/20201111-143001
base:   https://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next.git 70408949a35f1a31c327c69b6a187635cb0305fa
:::::: branch date: 3 hours ago
:::::: commit date: 3 hours ago
config: x86_64-randconfig-s021-20201111 (attached as .config)
compiler: gcc-9 (Debian 9.3.0-15) 9.3.0
reproduce:
        # apt-get install sparse
        # sparse version: v0.6.3-106-gd020cf33-dirty
        # https://github.com/0day-ci/linux/commit/a551316818f8b3f9164d7a734538decca3762fda
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review wenxu-ucloud-cn/net-sched-fix-over-mtu-packet-of-defrag-in/20201111-143001
        git checkout a551316818f8b3f9164d7a734538decca3762fda
        # save the attached .config to linux build tree
        make W=1 C=1 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__' ARCH=x86_64 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>


"sparse warnings: (new ones prefixed by >>)"
   net/sched/act_api.c:30:5: sparse: sparse: symbol 'tcf_set_xmit_hook' redeclared with different type (incompatible argument 1 (different address spaces)):
>> net/sched/act_api.c:30:5: sparse:    int extern [addressable] [signed] [toplevel] tcf_set_xmit_hook( ... )
   net/sched/act_api.c: note: in included file (through include/net/pkt_cls.h):
   include/net/act_api.h:244:5: sparse: note: previously declared as:
>> include/net/act_api.h:244:5: sparse:    int extern [addressable] [signed] [toplevel] tcf_set_xmit_hook( ... )
>> net/sched/act_api.c:64:19: sparse: sparse: incorrect type in assignment (different address spaces) @@     expected int ( [noderef] __rcu *xmit_hook )( ... ) @@     got int ( [noderef] * )( ... ) @@
>> net/sched/act_api.c:64:19: sparse:     expected int ( [noderef] __rcu *xmit_hook )( ... )
   net/sched/act_api.c:64:19: sparse:     got int ( [noderef] * )( ... )

vim +30 net/sched/act_api.c

a551316818f8b3f wenxu 2020-11-11  29  
a551316818f8b3f wenxu 2020-11-11 @30  int tcf_set_xmit_hook(int (__rcu *xmit_hook)(struct sk_buff *skb,
a551316818f8b3f wenxu 2020-11-11  31  					     int (*xmit)(struct sk_buff *skb)))
a551316818f8b3f wenxu 2020-11-11  32  {
a551316818f8b3f wenxu 2020-11-11  33  	spin_lock(&tcf_xmit_hook_lock);
a551316818f8b3f wenxu 2020-11-11  34  	if (!tcf_xmit_hook_count) {
a551316818f8b3f wenxu 2020-11-11  35  		rcu_assign_pointer(tcf_xmit_hook, xmit_hook);
a551316818f8b3f wenxu 2020-11-11  36  	} else if (xmit_hook != tcf_xmit_hook) {
a551316818f8b3f wenxu 2020-11-11  37  		spin_unlock(&tcf_xmit_hook_lock);
a551316818f8b3f wenxu 2020-11-11  38  		return -EBUSY;
a551316818f8b3f wenxu 2020-11-11  39  	}
a551316818f8b3f wenxu 2020-11-11  40  
a551316818f8b3f wenxu 2020-11-11  41  	tcf_xmit_hook_count++;
a551316818f8b3f wenxu 2020-11-11  42  	spin_unlock(&tcf_xmit_hook_lock);
a551316818f8b3f wenxu 2020-11-11  43  
a551316818f8b3f wenxu 2020-11-11  44  	return 0;
a551316818f8b3f wenxu 2020-11-11  45  }
a551316818f8b3f wenxu 2020-11-11  46  EXPORT_SYMBOL_GPL(tcf_set_xmit_hook);
a551316818f8b3f wenxu 2020-11-11  47  
a551316818f8b3f wenxu 2020-11-11  48  void tcf_clear_xmit_hook(void)
a551316818f8b3f wenxu 2020-11-11  49  {
a551316818f8b3f wenxu 2020-11-11  50  	spin_lock(&tcf_xmit_hook_lock);
a551316818f8b3f wenxu 2020-11-11  51  	if (--tcf_xmit_hook_count == 0)
a551316818f8b3f wenxu 2020-11-11  52  		rcu_assign_pointer(tcf_xmit_hook, NULL);
a551316818f8b3f wenxu 2020-11-11  53  	spin_unlock(&tcf_xmit_hook_lock);
a551316818f8b3f wenxu 2020-11-11  54  
a551316818f8b3f wenxu 2020-11-11  55  	synchronize_rcu();
a551316818f8b3f wenxu 2020-11-11  56  }
a551316818f8b3f wenxu 2020-11-11  57  EXPORT_SYMBOL_GPL(tcf_clear_xmit_hook);
a551316818f8b3f wenxu 2020-11-11  58  
a551316818f8b3f wenxu 2020-11-11  59  int tcf_dev_queue_xmit(struct sk_buff *skb, int (*xmit)(struct sk_buff *skb))
a551316818f8b3f wenxu 2020-11-11  60  {
a551316818f8b3f wenxu 2020-11-11  61  	int (__rcu *xmit_hook)(struct sk_buff *skb,
a551316818f8b3f wenxu 2020-11-11  62  			       int (*xmit)(struct sk_buff *skb));
a551316818f8b3f wenxu 2020-11-11  63  
a551316818f8b3f wenxu 2020-11-11 @64  	xmit_hook = rcu_dereference(tcf_xmit_hook);
a551316818f8b3f wenxu 2020-11-11  65  	if (xmit_hook)
a551316818f8b3f wenxu 2020-11-11  66  		return xmit_hook(skb, xmit);
a551316818f8b3f wenxu 2020-11-11  67  	else
a551316818f8b3f wenxu 2020-11-11  68  		return xmit(skb);
a551316818f8b3f wenxu 2020-11-11  69  }
a551316818f8b3f wenxu 2020-11-11  70  EXPORT_SYMBOL_GPL(tcf_dev_queue_xmit);
a551316818f8b3f wenxu 2020-11-11  71  

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 39761 bytes --]

WARNING: multiple messages have this Message-ID (diff)
From: kernel test robot <lkp@intel.com>
To: kbuild-all@lists.01.org
Subject: Re: [PATCH v8 net-next 3/3] net/sched: act_frag: add implict packet fragment support.
Date: Thu, 12 Nov 2020 23:05:22 +0800	[thread overview]
Message-ID: <20201112150522.GC21214@xsang-OptiPlex-9020> (raw)
In-Reply-To: <1605076100-21782-4-git-send-email-wenxu@ucloud.cn>

[-- Attachment #1: Type: text/plain, Size: 5008 bytes --]

Hi,

Thank you for the patch! Perhaps something to improve:

[auto build test WARNING on net-next/master]

url:    https://github.com/0day-ci/linux/commits/wenxu-ucloud-cn/net-sched-fix-over-mtu-packet-of-defrag-in/20201111-143001
base:   https://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next.git 70408949a35f1a31c327c69b6a187635cb0305fa
:::::: branch date: 3 hours ago
:::::: commit date: 3 hours ago
config: x86_64-randconfig-s021-20201111 (attached as .config)
compiler: gcc-9 (Debian 9.3.0-15) 9.3.0
reproduce:
        # apt-get install sparse
        # sparse version: v0.6.3-106-gd020cf33-dirty
        # https://github.com/0day-ci/linux/commit/a551316818f8b3f9164d7a734538decca3762fda
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review wenxu-ucloud-cn/net-sched-fix-over-mtu-packet-of-defrag-in/20201111-143001
        git checkout a551316818f8b3f9164d7a734538decca3762fda
        # save the attached .config to linux build tree
        make W=1 C=1 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__' ARCH=x86_64 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>


"sparse warnings: (new ones prefixed by >>)"
   net/sched/act_api.c:30:5: sparse: sparse: symbol 'tcf_set_xmit_hook' redeclared with different type (incompatible argument 1 (different address spaces)):
>> net/sched/act_api.c:30:5: sparse:    int extern [addressable] [signed] [toplevel] tcf_set_xmit_hook( ... )
   net/sched/act_api.c: note: in included file (through include/net/pkt_cls.h):
   include/net/act_api.h:244:5: sparse: note: previously declared as:
>> include/net/act_api.h:244:5: sparse:    int extern [addressable] [signed] [toplevel] tcf_set_xmit_hook( ... )
>> net/sched/act_api.c:64:19: sparse: sparse: incorrect type in assignment (different address spaces) @@     expected int ( [noderef] __rcu *xmit_hook )( ... ) @@     got int ( [noderef] * )( ... ) @@
>> net/sched/act_api.c:64:19: sparse:     expected int ( [noderef] __rcu *xmit_hook )( ... )
   net/sched/act_api.c:64:19: sparse:     got int ( [noderef] * )( ... )

vim +30 net/sched/act_api.c

a551316818f8b3f wenxu 2020-11-11  29  
a551316818f8b3f wenxu 2020-11-11 @30  int tcf_set_xmit_hook(int (__rcu *xmit_hook)(struct sk_buff *skb,
a551316818f8b3f wenxu 2020-11-11  31  					     int (*xmit)(struct sk_buff *skb)))
a551316818f8b3f wenxu 2020-11-11  32  {
a551316818f8b3f wenxu 2020-11-11  33  	spin_lock(&tcf_xmit_hook_lock);
a551316818f8b3f wenxu 2020-11-11  34  	if (!tcf_xmit_hook_count) {
a551316818f8b3f wenxu 2020-11-11  35  		rcu_assign_pointer(tcf_xmit_hook, xmit_hook);
a551316818f8b3f wenxu 2020-11-11  36  	} else if (xmit_hook != tcf_xmit_hook) {
a551316818f8b3f wenxu 2020-11-11  37  		spin_unlock(&tcf_xmit_hook_lock);
a551316818f8b3f wenxu 2020-11-11  38  		return -EBUSY;
a551316818f8b3f wenxu 2020-11-11  39  	}
a551316818f8b3f wenxu 2020-11-11  40  
a551316818f8b3f wenxu 2020-11-11  41  	tcf_xmit_hook_count++;
a551316818f8b3f wenxu 2020-11-11  42  	spin_unlock(&tcf_xmit_hook_lock);
a551316818f8b3f wenxu 2020-11-11  43  
a551316818f8b3f wenxu 2020-11-11  44  	return 0;
a551316818f8b3f wenxu 2020-11-11  45  }
a551316818f8b3f wenxu 2020-11-11  46  EXPORT_SYMBOL_GPL(tcf_set_xmit_hook);
a551316818f8b3f wenxu 2020-11-11  47  
a551316818f8b3f wenxu 2020-11-11  48  void tcf_clear_xmit_hook(void)
a551316818f8b3f wenxu 2020-11-11  49  {
a551316818f8b3f wenxu 2020-11-11  50  	spin_lock(&tcf_xmit_hook_lock);
a551316818f8b3f wenxu 2020-11-11  51  	if (--tcf_xmit_hook_count == 0)
a551316818f8b3f wenxu 2020-11-11  52  		rcu_assign_pointer(tcf_xmit_hook, NULL);
a551316818f8b3f wenxu 2020-11-11  53  	spin_unlock(&tcf_xmit_hook_lock);
a551316818f8b3f wenxu 2020-11-11  54  
a551316818f8b3f wenxu 2020-11-11  55  	synchronize_rcu();
a551316818f8b3f wenxu 2020-11-11  56  }
a551316818f8b3f wenxu 2020-11-11  57  EXPORT_SYMBOL_GPL(tcf_clear_xmit_hook);
a551316818f8b3f wenxu 2020-11-11  58  
a551316818f8b3f wenxu 2020-11-11  59  int tcf_dev_queue_xmit(struct sk_buff *skb, int (*xmit)(struct sk_buff *skb))
a551316818f8b3f wenxu 2020-11-11  60  {
a551316818f8b3f wenxu 2020-11-11  61  	int (__rcu *xmit_hook)(struct sk_buff *skb,
a551316818f8b3f wenxu 2020-11-11  62  			       int (*xmit)(struct sk_buff *skb));
a551316818f8b3f wenxu 2020-11-11  63  
a551316818f8b3f wenxu 2020-11-11 @64  	xmit_hook = rcu_dereference(tcf_xmit_hook);
a551316818f8b3f wenxu 2020-11-11  65  	if (xmit_hook)
a551316818f8b3f wenxu 2020-11-11  66  		return xmit_hook(skb, xmit);
a551316818f8b3f wenxu 2020-11-11  67  	else
a551316818f8b3f wenxu 2020-11-11  68  		return xmit(skb);
a551316818f8b3f wenxu 2020-11-11  69  }
a551316818f8b3f wenxu 2020-11-11  70  EXPORT_SYMBOL_GPL(tcf_dev_queue_xmit);
a551316818f8b3f wenxu 2020-11-11  71  

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org

[-- Attachment #2: config.gz --]
[-- Type: application/gzip, Size: 39761 bytes --]

  reply	other threads:[~2020-11-12 14:51 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-11-11  6:28 [PATCH v8 net-next 0/3] net/sched: fix over mtu packet of defrag in wenxu
2020-11-11  6:28 ` [PATCH v8 net-next 1/3] net/sched: fix miss init the mru in qdisc_skb_cb wenxu
2020-11-11  6:28 ` [PATCH v8 net-next 2/3] net/sched: act_mirred: refactor the handle of xmit wenxu
2020-11-11  6:28 ` [PATCH v8 net-next 3/3] net/sched: act_frag: add implict packet fragment support wenxu
2020-11-12 15:05   ` kernel test robot [this message]
2020-11-12 15:05     ` kernel test robot
2020-11-11  9:42 kernel test robot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20201112150522.GC21214@xsang-OptiPlex-9020 \
    --to=lkp@intel.com \
    --cc=kbuild-all@lists.01.org \
    --cc=kuba@kernel.org \
    --cc=marcelo.leitner@gmail.com \
    --cc=netdev@vger.kernel.org \
    --cc=vladbu@nvidia.com \
    --cc=wenxu@ucloud.cn \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.