* [PATCH REPOST] media: omap3isp: Remove misleading comment
@ 2020-11-13 14:28 Sebastian Andrzej Siewior
2020-11-16 9:23 ` Laurent Pinchart
0 siblings, 1 reply; 4+ messages in thread
From: Sebastian Andrzej Siewior @ 2020-11-13 14:28 UTC (permalink / raw)
To: linux-media
Cc: Thomas Gleixner, Sebastian Andrzej Siewior, Laurent Pinchart,
Mauro Carvalho Chehab
From: Thomas Gleixner <tglx@linutronix.de>
in_interrupt() covers hard and soft interrupt servicing and bottom half
disabled contexts, which is semantically undefined and useless.
The comment for __ccdc_lsc_configure() "Context: in_interrupt()" is
therefore as useful as "Context: unknown'. Remove it.
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Signed-off-by: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Cc: Mauro Carvalho Chehab <mchehab@kernel.org>
Cc: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Cc: linux-media@vger.kernel.org
---
Repost of https://lore.kernel.org/linux-media/20201013143731.704783731@linutronix.de/
The other patches in this thread were applied.
drivers/media/platform/omap3isp/ispccdc.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/drivers/media/platform/omap3isp/ispccdc.c b/drivers/media/platform/omap3isp/ispccdc.c
index 0fbb2aa6dd2c0..4e8905ef362f2 100644
--- a/drivers/media/platform/omap3isp/ispccdc.c
+++ b/drivers/media/platform/omap3isp/ispccdc.c
@@ -299,11 +299,10 @@ static int ccdc_lsc_busy(struct isp_ccdc_device *ccdc)
ISPCCDC_LSC_BUSY;
}
-/* __ccdc_lsc_configure - Apply a new configuration to the LSC engine
+/*
+ * __ccdc_lsc_configure - Apply a new configuration to the LSC engine
* @ccdc: Pointer to ISP CCDC device
* @req: New configuration request
- *
- * context: in_interrupt()
*/
static int __ccdc_lsc_configure(struct isp_ccdc_device *ccdc,
struct ispccdc_lsc_config_req *req)
--
2.29.2
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH REPOST] media: omap3isp: Remove misleading comment
2020-11-13 14:28 [PATCH REPOST] media: omap3isp: Remove misleading comment Sebastian Andrzej Siewior
@ 2020-11-16 9:23 ` Laurent Pinchart
2020-11-25 21:01 ` Sebastian Andrzej Siewior
0 siblings, 1 reply; 4+ messages in thread
From: Laurent Pinchart @ 2020-11-16 9:23 UTC (permalink / raw)
To: Sebastian Andrzej Siewior
Cc: linux-media, Thomas Gleixner, Mauro Carvalho Chehab, Sakari Ailus
Hi Sebastian,
Thank you for the patch.
CC'ing Sakari.
Sakari, could you please pick this one up ?
On Fri, Nov 13, 2020 at 03:28:31PM +0100, Sebastian Andrzej Siewior wrote:
> From: Thomas Gleixner <tglx@linutronix.de>
>
> in_interrupt() covers hard and soft interrupt servicing and bottom half
> disabled contexts, which is semantically undefined and useless.
>
> The comment for __ccdc_lsc_configure() "Context: in_interrupt()" is
> therefore as useful as "Context: unknown'. Remove it.
>
> Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
> Signed-off-by: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
> Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> Cc: Mauro Carvalho Chehab <mchehab@kernel.org>
> Cc: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> Cc: linux-media@vger.kernel.org
> ---
> Repost of https://lore.kernel.org/linux-media/20201013143731.704783731@linutronix.de/
> The other patches in this thread were applied.
>
> drivers/media/platform/omap3isp/ispccdc.c | 5 ++---
> 1 file changed, 2 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/media/platform/omap3isp/ispccdc.c b/drivers/media/platform/omap3isp/ispccdc.c
> index 0fbb2aa6dd2c0..4e8905ef362f2 100644
> --- a/drivers/media/platform/omap3isp/ispccdc.c
> +++ b/drivers/media/platform/omap3isp/ispccdc.c
> @@ -299,11 +299,10 @@ static int ccdc_lsc_busy(struct isp_ccdc_device *ccdc)
> ISPCCDC_LSC_BUSY;
> }
>
> -/* __ccdc_lsc_configure - Apply a new configuration to the LSC engine
> +/*
> + * __ccdc_lsc_configure - Apply a new configuration to the LSC engine
> * @ccdc: Pointer to ISP CCDC device
> * @req: New configuration request
> - *
> - * context: in_interrupt()
> */
> static int __ccdc_lsc_configure(struct isp_ccdc_device *ccdc,
> struct ispccdc_lsc_config_req *req)
--
Regards,
Laurent Pinchart
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH REPOST] media: omap3isp: Remove misleading comment
2020-11-16 9:23 ` Laurent Pinchart
@ 2020-11-25 21:01 ` Sebastian Andrzej Siewior
2020-11-25 21:30 ` Sakari Ailus
0 siblings, 1 reply; 4+ messages in thread
From: Sebastian Andrzej Siewior @ 2020-11-25 21:01 UTC (permalink / raw)
To: Laurent Pinchart, Sakari Ailus
Cc: linux-media, Thomas Gleixner, Mauro Carvalho Chehab
On 2020-11-16 11:23:54 [+0200], Laurent Pinchart wrote:
> Hi Sebastian,
Hi,
> Thank you for the patch.
>
> CC'ing Sakari.
>
> Sakari, could you please pick this one up ?
Sakari, does this work for you?
Sebastian
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH REPOST] media: omap3isp: Remove misleading comment
2020-11-25 21:01 ` Sebastian Andrzej Siewior
@ 2020-11-25 21:30 ` Sakari Ailus
0 siblings, 0 replies; 4+ messages in thread
From: Sakari Ailus @ 2020-11-25 21:30 UTC (permalink / raw)
To: Sebastian Andrzej Siewior
Cc: Laurent Pinchart, linux-media, Thomas Gleixner, Mauro Carvalho Chehab
On Wed, Nov 25, 2020 at 10:01:54PM +0100, Sebastian Andrzej Siewior wrote:
> On 2020-11-16 11:23:54 [+0200], Laurent Pinchart wrote:
> > Hi Sebastian,
> Hi,
>
> > Thank you for the patch.
> >
> > CC'ing Sakari.
> >
> > Sakari, could you please pick this one up ?
>
> Sakari, does this work for you?
Oops... this one had slipped through. It's in my tree now.
--
Regards,
Sakari Ailus
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2020-11-25 21:31 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-11-13 14:28 [PATCH REPOST] media: omap3isp: Remove misleading comment Sebastian Andrzej Siewior
2020-11-16 9:23 ` Laurent Pinchart
2020-11-25 21:01 ` Sebastian Andrzej Siewior
2020-11-25 21:30 ` Sakari Ailus
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.