All of lore.kernel.org
 help / color / mirror / Atom feed
* ./include/generated/autoconf.h:1601:33: fatal error: mach/debug-macro.S: No such file or directory
@ 2020-11-11  6:17 ` kernel test robot
  0 siblings, 0 replies; 14+ messages in thread
From: kernel test robot @ 2020-11-11  6:17 UTC (permalink / raw)
  To: Linus Walleij; +Cc: kbuild-all, linux-kernel, Russell King

[-- Attachment #1: Type: text/plain, Size: 1603 bytes --]

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head:   eccc876724927ff3b9ff91f36f7b6b159e948f0c
commit: 2596a72d338481b49a678ab880338fd5a661e663 ARM: 9009/1: uncompress: Enable debug in head.S
date:   8 weeks ago
config: arm-randconfig-c004-20201109 (attached as .config)
compiler: arm-linux-gnueabi-gcc (GCC) 9.3.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=2596a72d338481b49a678ab880338fd5a661e663
        git remote add linus https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
        git fetch --no-tags linus master
        git checkout 2596a72d338481b49a678ab880338fd5a661e663
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=arm 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

All errors (new ones prefixed by >>):

   In file included from include/linux/kconfig.h:7,
                    from <command-line>:
>> ./include/generated/autoconf.h:1601:33: fatal error: mach/debug-macro.S: No such file or directory
    1601 | #define CONFIG_DEBUG_LL_INCLUDE "mach/debug-macro.S"
         |                                 ^~~~~~~~~~~~~~~~~~~~
   compilation terminated.

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 27839 bytes --]

^ permalink raw reply	[flat|nested] 14+ messages in thread

* ./include/generated/autoconf.h:1601:33: fatal error: mach/debug-macro.S: No such file or directory
@ 2020-11-11  6:17 ` kernel test robot
  0 siblings, 0 replies; 14+ messages in thread
From: kernel test robot @ 2020-11-11  6:17 UTC (permalink / raw)
  To: kbuild-all

[-- Attachment #1: Type: text/plain, Size: 1636 bytes --]

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head:   eccc876724927ff3b9ff91f36f7b6b159e948f0c
commit: 2596a72d338481b49a678ab880338fd5a661e663 ARM: 9009/1: uncompress: Enable debug in head.S
date:   8 weeks ago
config: arm-randconfig-c004-20201109 (attached as .config)
compiler: arm-linux-gnueabi-gcc (GCC) 9.3.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=2596a72d338481b49a678ab880338fd5a661e663
        git remote add linus https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
        git fetch --no-tags linus master
        git checkout 2596a72d338481b49a678ab880338fd5a661e663
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=arm 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

All errors (new ones prefixed by >>):

   In file included from include/linux/kconfig.h:7,
                    from <command-line>:
>> ./include/generated/autoconf.h:1601:33: fatal error: mach/debug-macro.S: No such file or directory
    1601 | #define CONFIG_DEBUG_LL_INCLUDE "mach/debug-macro.S"
         |                                 ^~~~~~~~~~~~~~~~~~~~
   compilation terminated.

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org

[-- Attachment #2: config.gz --]
[-- Type: application/gzip, Size: 27839 bytes --]

^ permalink raw reply	[flat|nested] 14+ messages in thread

* Re: ./include/generated/autoconf.h:1601:33: fatal error: mach/debug-macro.S: No such file or directory
  2020-11-11  6:17 ` kernel test robot
  (?)
@ 2020-11-11  8:51   ` Linus Walleij
  -1 siblings, 0 replies; 14+ messages in thread
From: Linus Walleij @ 2020-11-11  8:51 UTC (permalink / raw)
  To: kernel test robot, Arnd Bergmann, Nicolas Ferre, Olof Johansson
  Cc: kbuild-all, linux-kernel, Russell King, Linux ARM,
	Claudiu Beznea, Alexandre Belloni, Ludovic Desroches

On Wed, Nov 11, 2020 at 7:18 AM kernel test robot <lkp@intel.com> wrote:

>    In file included from include/linux/kconfig.h:7,
>                     from <command-line>:
> >> ./include/generated/autoconf.h:1601:33: fatal error: mach/debug-macro.S: No such file or directory
>     1601 | #define CONFIG_DEBUG_LL_INCLUDE "mach/debug-macro.S"
>          |                                 ^~~~~~~~~~~~~~~~~~~~
>    compilation terminated.

This is an interesting one!

It happens when CONFIG_DEBUG_LL_INCLUDE does not have a custom
debug header for the platform under arch/arm/include/debug and the
KConfig falls through to the default value, which is <mach/debug-macro.S>.

Only that the majority is not using <mach/*> anymore.

I feel a bit like setting the default to debug/8250.S or something.

Suggestions?

Then the actual bug exposed:

The config tested by the robot is using
CONFIG_ARCH_AT91=y
CONFIG_SOC_SAMV7=y

When I look into Kconfig.debug it seems that this will define
DEBUG_AT91_SAMV7_USART1 but only a physical address,
no virtual address and and actually no debug header. It seems
LL_DEBUG is broken on SAMV7 and never really worked
so now that crops up.

Nicolas, something that should be fixed, I think?

Yours,
Linus Walleij

^ permalink raw reply	[flat|nested] 14+ messages in thread

* Re: ./include/generated/autoconf.h:1601:33: fatal error: mach/debug-macro.S: No such file or directory
@ 2020-11-11  8:51   ` Linus Walleij
  0 siblings, 0 replies; 14+ messages in thread
From: Linus Walleij @ 2020-11-11  8:51 UTC (permalink / raw)
  To: kernel test robot, Arnd Bergmann, Nicolas Ferre, Olof Johansson
  Cc: Alexandre Belloni, kbuild-all, linux-kernel, Russell King,
	Ludovic Desroches, Claudiu Beznea, Linux ARM

On Wed, Nov 11, 2020 at 7:18 AM kernel test robot <lkp@intel.com> wrote:

>    In file included from include/linux/kconfig.h:7,
>                     from <command-line>:
> >> ./include/generated/autoconf.h:1601:33: fatal error: mach/debug-macro.S: No such file or directory
>     1601 | #define CONFIG_DEBUG_LL_INCLUDE "mach/debug-macro.S"
>          |                                 ^~~~~~~~~~~~~~~~~~~~
>    compilation terminated.

This is an interesting one!

It happens when CONFIG_DEBUG_LL_INCLUDE does not have a custom
debug header for the platform under arch/arm/include/debug and the
KConfig falls through to the default value, which is <mach/debug-macro.S>.

Only that the majority is not using <mach/*> anymore.

I feel a bit like setting the default to debug/8250.S or something.

Suggestions?

Then the actual bug exposed:

The config tested by the robot is using
CONFIG_ARCH_AT91=y
CONFIG_SOC_SAMV7=y

When I look into Kconfig.debug it seems that this will define
DEBUG_AT91_SAMV7_USART1 but only a physical address,
no virtual address and and actually no debug header. It seems
LL_DEBUG is broken on SAMV7 and never really worked
so now that crops up.

Nicolas, something that should be fixed, I think?

Yours,
Linus Walleij

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 14+ messages in thread

* Re: ./include/generated/autoconf.h:1601:33: fatal error: mach/debug-macro.S: No such file or directory
@ 2020-11-11  8:51   ` Linus Walleij
  0 siblings, 0 replies; 14+ messages in thread
From: Linus Walleij @ 2020-11-11  8:51 UTC (permalink / raw)
  To: kbuild-all

[-- Attachment #1: Type: text/plain, Size: 1278 bytes --]

On Wed, Nov 11, 2020 at 7:18 AM kernel test robot <lkp@intel.com> wrote:

>    In file included from include/linux/kconfig.h:7,
>                     from <command-line>:
> >> ./include/generated/autoconf.h:1601:33: fatal error: mach/debug-macro.S: No such file or directory
>     1601 | #define CONFIG_DEBUG_LL_INCLUDE "mach/debug-macro.S"
>          |                                 ^~~~~~~~~~~~~~~~~~~~
>    compilation terminated.

This is an interesting one!

It happens when CONFIG_DEBUG_LL_INCLUDE does not have a custom
debug header for the platform under arch/arm/include/debug and the
KConfig falls through to the default value, which is <mach/debug-macro.S>.

Only that the majority is not using <mach/*> anymore.

I feel a bit like setting the default to debug/8250.S or something.

Suggestions?

Then the actual bug exposed:

The config tested by the robot is using
CONFIG_ARCH_AT91=y
CONFIG_SOC_SAMV7=y

When I look into Kconfig.debug it seems that this will define
DEBUG_AT91_SAMV7_USART1 but only a physical address,
no virtual address and and actually no debug header. It seems
LL_DEBUG is broken on SAMV7 and never really worked
so now that crops up.

Nicolas, something that should be fixed, I think?

Yours,
Linus Walleij

^ permalink raw reply	[flat|nested] 14+ messages in thread

* Re: ./include/generated/autoconf.h:1601:33: fatal error: mach/debug-macro.S: No such file or directory
  2020-11-11  8:51   ` Linus Walleij
  (?)
@ 2020-11-13 23:28     ` Alexandre Belloni
  -1 siblings, 0 replies; 14+ messages in thread
From: Alexandre Belloni @ 2020-11-13 23:28 UTC (permalink / raw)
  To: Linus Walleij
  Cc: kernel test robot, Arnd Bergmann, Nicolas Ferre, Olof Johansson,
	kbuild-all, linux-kernel, Russell King, Linux ARM,
	Claudiu Beznea, Ludovic Desroches

On 11/11/2020 09:51:26+0100, Linus Walleij wrote:
> On Wed, Nov 11, 2020 at 7:18 AM kernel test robot <lkp@intel.com> wrote:
> 
> >    In file included from include/linux/kconfig.h:7,
> >                     from <command-line>:
> > >> ./include/generated/autoconf.h:1601:33: fatal error: mach/debug-macro.S: No such file or directory
> >     1601 | #define CONFIG_DEBUG_LL_INCLUDE "mach/debug-macro.S"
> >          |                                 ^~~~~~~~~~~~~~~~~~~~
> >    compilation terminated.
> 
> This is an interesting one!
> 
> It happens when CONFIG_DEBUG_LL_INCLUDE does not have a custom
> debug header for the platform under arch/arm/include/debug and the
> KConfig falls through to the default value, which is <mach/debug-macro.S>.
> 
> Only that the majority is not using <mach/*> anymore.
> 
> I feel a bit like setting the default to debug/8250.S or something.
> 
> Suggestions?
> 
> Then the actual bug exposed:
> 
> The config tested by the robot is using
> CONFIG_ARCH_AT91=y
> CONFIG_SOC_SAMV7=y
> 
> When I look into Kconfig.debug it seems that this will define
> DEBUG_AT91_SAMV7_USART1 but only a physical address,
> no virtual address and and actually no debug header. It seems
> LL_DEBUG is broken on SAMV7 and never really worked
> so now that crops up.
> 
> Nicolas, something that should be fixed, I think?
> 

This is what the platforms without an MMU are doing. I don't think there
is anything platform specific to fix.

^ permalink raw reply	[flat|nested] 14+ messages in thread

* Re: ./include/generated/autoconf.h:1601:33: fatal error: mach/debug-macro.S: No such file or directory
@ 2020-11-13 23:28     ` Alexandre Belloni
  0 siblings, 0 replies; 14+ messages in thread
From: Alexandre Belloni @ 2020-11-13 23:28 UTC (permalink / raw)
  To: Linus Walleij
  Cc: kbuild-all, kernel test robot, Arnd Bergmann, linux-kernel,
	Russell King, Ludovic Desroches, Olof Johansson, Claudiu Beznea,
	Linux ARM

On 11/11/2020 09:51:26+0100, Linus Walleij wrote:
> On Wed, Nov 11, 2020 at 7:18 AM kernel test robot <lkp@intel.com> wrote:
> 
> >    In file included from include/linux/kconfig.h:7,
> >                     from <command-line>:
> > >> ./include/generated/autoconf.h:1601:33: fatal error: mach/debug-macro.S: No such file or directory
> >     1601 | #define CONFIG_DEBUG_LL_INCLUDE "mach/debug-macro.S"
> >          |                                 ^~~~~~~~~~~~~~~~~~~~
> >    compilation terminated.
> 
> This is an interesting one!
> 
> It happens when CONFIG_DEBUG_LL_INCLUDE does not have a custom
> debug header for the platform under arch/arm/include/debug and the
> KConfig falls through to the default value, which is <mach/debug-macro.S>.
> 
> Only that the majority is not using <mach/*> anymore.
> 
> I feel a bit like setting the default to debug/8250.S or something.
> 
> Suggestions?
> 
> Then the actual bug exposed:
> 
> The config tested by the robot is using
> CONFIG_ARCH_AT91=y
> CONFIG_SOC_SAMV7=y
> 
> When I look into Kconfig.debug it seems that this will define
> DEBUG_AT91_SAMV7_USART1 but only a physical address,
> no virtual address and and actually no debug header. It seems
> LL_DEBUG is broken on SAMV7 and never really worked
> so now that crops up.
> 
> Nicolas, something that should be fixed, I think?
> 

This is what the platforms without an MMU are doing. I don't think there
is anything platform specific to fix.

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 14+ messages in thread

* Re: ./include/generated/autoconf.h:1601:33: fatal error: mach/debug-macro.S: No such file or directory
@ 2020-11-13 23:28     ` Alexandre Belloni
  0 siblings, 0 replies; 14+ messages in thread
From: Alexandre Belloni @ 2020-11-13 23:28 UTC (permalink / raw)
  To: kbuild-all

[-- Attachment #1: Type: text/plain, Size: 1491 bytes --]

On 11/11/2020 09:51:26+0100, Linus Walleij wrote:
> On Wed, Nov 11, 2020 at 7:18 AM kernel test robot <lkp@intel.com> wrote:
> 
> >    In file included from include/linux/kconfig.h:7,
> >                     from <command-line>:
> > >> ./include/generated/autoconf.h:1601:33: fatal error: mach/debug-macro.S: No such file or directory
> >     1601 | #define CONFIG_DEBUG_LL_INCLUDE "mach/debug-macro.S"
> >          |                                 ^~~~~~~~~~~~~~~~~~~~
> >    compilation terminated.
> 
> This is an interesting one!
> 
> It happens when CONFIG_DEBUG_LL_INCLUDE does not have a custom
> debug header for the platform under arch/arm/include/debug and the
> KConfig falls through to the default value, which is <mach/debug-macro.S>.
> 
> Only that the majority is not using <mach/*> anymore.
> 
> I feel a bit like setting the default to debug/8250.S or something.
> 
> Suggestions?
> 
> Then the actual bug exposed:
> 
> The config tested by the robot is using
> CONFIG_ARCH_AT91=y
> CONFIG_SOC_SAMV7=y
> 
> When I look into Kconfig.debug it seems that this will define
> DEBUG_AT91_SAMV7_USART1 but only a physical address,
> no virtual address and and actually no debug header. It seems
> LL_DEBUG is broken on SAMV7 and never really worked
> so now that crops up.
> 
> Nicolas, something that should be fixed, I think?
> 

This is what the platforms without an MMU are doing. I don't think there
is anything platform specific to fix.

^ permalink raw reply	[flat|nested] 14+ messages in thread

* Re: ./include/generated/autoconf.h:1601:33: fatal error: mach/debug-macro.S: No such file or directory
  2020-11-11  8:51   ` Linus Walleij
  (?)
@ 2020-11-13 23:58     ` Alexandre Belloni
  -1 siblings, 0 replies; 14+ messages in thread
From: Alexandre Belloni @ 2020-11-13 23:58 UTC (permalink / raw)
  To: Linus Walleij
  Cc: kernel test robot, Arnd Bergmann, Nicolas Ferre, Olof Johansson,
	kbuild-all, linux-kernel, Russell King, Linux ARM,
	Claudiu Beznea, Ludovic Desroches

On 11/11/2020 09:51:26+0100, Linus Walleij wrote:
> On Wed, Nov 11, 2020 at 7:18 AM kernel test robot <lkp@intel.com> wrote:
> 
> >    In file included from include/linux/kconfig.h:7,
> >                     from <command-line>:
> > >> ./include/generated/autoconf.h:1601:33: fatal error: mach/debug-macro.S: No such file or directory
> >     1601 | #define CONFIG_DEBUG_LL_INCLUDE "mach/debug-macro.S"
> >          |                                 ^~~~~~~~~~~~~~~~~~~~
> >    compilation terminated.
> 
> This is an interesting one!
> 
> It happens when CONFIG_DEBUG_LL_INCLUDE does not have a custom
> debug header for the platform under arch/arm/include/debug and the
> KConfig falls through to the default value, which is <mach/debug-macro.S>.
> 
> Only that the majority is not using <mach/*> anymore.
> 
> I feel a bit like setting the default to debug/8250.S or something.
> 
> Suggestions?
> 
> Then the actual bug exposed:
> 
> The config tested by the robot is using
> CONFIG_ARCH_AT91=y
> CONFIG_SOC_SAMV7=y
> 
> When I look into Kconfig.debug it seems that this will define
> DEBUG_AT91_SAMV7_USART1 but only a physical address,
> no virtual address and and actually no debug header. It seems
> LL_DEBUG is broken on SAMV7 and never really worked
> so now that crops up.
> 
> Nicolas, something that should be fixed, I think?
> 

I confirm DEBUG_LL is not broken on SAMV7. The config used by lkp doen't
define DEBUG_AT91_SAMV7_USART1, it is not the culprit. Select it and the
problem is gone since DEBUG_AT91_SAMV7_USART1 selects DEBUG_AT91_UART
and DEBUG_LL_INCLUDE has:
default "debug/at91.S" if DEBUG_AT91_UART

Your issue is CONFIG_DEBUG_SEMIHOSTING


^ permalink raw reply	[flat|nested] 14+ messages in thread

* Re: ./include/generated/autoconf.h:1601:33: fatal error: mach/debug-macro.S: No such file or directory
@ 2020-11-13 23:58     ` Alexandre Belloni
  0 siblings, 0 replies; 14+ messages in thread
From: Alexandre Belloni @ 2020-11-13 23:58 UTC (permalink / raw)
  To: Linus Walleij
  Cc: kbuild-all, kernel test robot, Arnd Bergmann, linux-kernel,
	Russell King, Ludovic Desroches, Olof Johansson, Claudiu Beznea,
	Linux ARM

On 11/11/2020 09:51:26+0100, Linus Walleij wrote:
> On Wed, Nov 11, 2020 at 7:18 AM kernel test robot <lkp@intel.com> wrote:
> 
> >    In file included from include/linux/kconfig.h:7,
> >                     from <command-line>:
> > >> ./include/generated/autoconf.h:1601:33: fatal error: mach/debug-macro.S: No such file or directory
> >     1601 | #define CONFIG_DEBUG_LL_INCLUDE "mach/debug-macro.S"
> >          |                                 ^~~~~~~~~~~~~~~~~~~~
> >    compilation terminated.
> 
> This is an interesting one!
> 
> It happens when CONFIG_DEBUG_LL_INCLUDE does not have a custom
> debug header for the platform under arch/arm/include/debug and the
> KConfig falls through to the default value, which is <mach/debug-macro.S>.
> 
> Only that the majority is not using <mach/*> anymore.
> 
> I feel a bit like setting the default to debug/8250.S or something.
> 
> Suggestions?
> 
> Then the actual bug exposed:
> 
> The config tested by the robot is using
> CONFIG_ARCH_AT91=y
> CONFIG_SOC_SAMV7=y
> 
> When I look into Kconfig.debug it seems that this will define
> DEBUG_AT91_SAMV7_USART1 but only a physical address,
> no virtual address and and actually no debug header. It seems
> LL_DEBUG is broken on SAMV7 and never really worked
> so now that crops up.
> 
> Nicolas, something that should be fixed, I think?
> 

I confirm DEBUG_LL is not broken on SAMV7. The config used by lkp doen't
define DEBUG_AT91_SAMV7_USART1, it is not the culprit. Select it and the
problem is gone since DEBUG_AT91_SAMV7_USART1 selects DEBUG_AT91_UART
and DEBUG_LL_INCLUDE has:
default "debug/at91.S" if DEBUG_AT91_UART

Your issue is CONFIG_DEBUG_SEMIHOSTING


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 14+ messages in thread

* Re: ./include/generated/autoconf.h:1601:33: fatal error: mach/debug-macro.S: No such file or directory
@ 2020-11-13 23:58     ` Alexandre Belloni
  0 siblings, 0 replies; 14+ messages in thread
From: Alexandre Belloni @ 2020-11-13 23:58 UTC (permalink / raw)
  To: kbuild-all

[-- Attachment #1: Type: text/plain, Size: 1711 bytes --]

On 11/11/2020 09:51:26+0100, Linus Walleij wrote:
> On Wed, Nov 11, 2020 at 7:18 AM kernel test robot <lkp@intel.com> wrote:
> 
> >    In file included from include/linux/kconfig.h:7,
> >                     from <command-line>:
> > >> ./include/generated/autoconf.h:1601:33: fatal error: mach/debug-macro.S: No such file or directory
> >     1601 | #define CONFIG_DEBUG_LL_INCLUDE "mach/debug-macro.S"
> >          |                                 ^~~~~~~~~~~~~~~~~~~~
> >    compilation terminated.
> 
> This is an interesting one!
> 
> It happens when CONFIG_DEBUG_LL_INCLUDE does not have a custom
> debug header for the platform under arch/arm/include/debug and the
> KConfig falls through to the default value, which is <mach/debug-macro.S>.
> 
> Only that the majority is not using <mach/*> anymore.
> 
> I feel a bit like setting the default to debug/8250.S or something.
> 
> Suggestions?
> 
> Then the actual bug exposed:
> 
> The config tested by the robot is using
> CONFIG_ARCH_AT91=y
> CONFIG_SOC_SAMV7=y
> 
> When I look into Kconfig.debug it seems that this will define
> DEBUG_AT91_SAMV7_USART1 but only a physical address,
> no virtual address and and actually no debug header. It seems
> LL_DEBUG is broken on SAMV7 and never really worked
> so now that crops up.
> 
> Nicolas, something that should be fixed, I think?
> 

I confirm DEBUG_LL is not broken on SAMV7. The config used by lkp doen't
define DEBUG_AT91_SAMV7_USART1, it is not the culprit. Select it and the
problem is gone since DEBUG_AT91_SAMV7_USART1 selects DEBUG_AT91_UART
and DEBUG_LL_INCLUDE has:
default "debug/at91.S" if DEBUG_AT91_UART

Your issue is CONFIG_DEBUG_SEMIHOSTING

^ permalink raw reply	[flat|nested] 14+ messages in thread

* Re: ./include/generated/autoconf.h:1601:33: fatal error: mach/debug-macro.S: No such file or directory
  2020-11-13 23:58     ` Alexandre Belloni
  (?)
@ 2020-11-17 13:58       ` Arnd Bergmann
  -1 siblings, 0 replies; 14+ messages in thread
From: Arnd Bergmann @ 2020-11-17 13:58 UTC (permalink / raw)
  To: Alexandre Belloni
  Cc: Linus Walleij, kernel test robot, Arnd Bergmann, Nicolas Ferre,
	Olof Johansson, kbuild-all, linux-kernel, Russell King,
	Linux ARM, Claudiu Beznea, Ludovic Desroches

On Sat, Nov 14, 2020 at 12:58 AM Alexandre Belloni
<alexandre.belloni@bootlin.com> wrote:
> On 11/11/2020 09:51:26+0100, Linus Walleij wrote:
> > On Wed, Nov 11, 2020 at 7:18 AM kernel test robot <lkp@intel.com> wrote:
> >
> > >    In file included from include/linux/kconfig.h:7,
> > >                     from <command-line>:
> > > >> ./include/generated/autoconf.h:1601:33: fatal error: mach/debug-macro.S: No such file or directory
> > >     1601 | #define CONFIG_DEBUG_LL_INCLUDE "mach/debug-macro.S"
> > >          |                                 ^~~~~~~~~~~~~~~~~~~~
> > >    compilation terminated.
> >
> > This is an interesting one!
> >
> > It happens when CONFIG_DEBUG_LL_INCLUDE does not have a custom
> > debug header for the platform under arch/arm/include/debug and the
> > KConfig falls through to the default value, which is <mach/debug-macro.S>.
> >
> > Only that the majority is not using <mach/*> anymore.
> >
> > I feel a bit like setting the default to debug/8250.S or something.
> >
> > Suggestions?
> >
> > Then the actual bug exposed:
> >
> > The config tested by the robot is using
> > CONFIG_ARCH_AT91=y
> > CONFIG_SOC_SAMV7=y
> >
> > When I look into Kconfig.debug it seems that this will define
> > DEBUG_AT91_SAMV7_USART1 but only a physical address,
> > no virtual address and and actually no debug header. It seems
> > LL_DEBUG is broken on SAMV7 and never really worked
> > so now that crops up.

The last mach/debug-macro.S file was apparently removed in 2015,
in commit 0045c0dd2f64 ("ARM: debug-ll: rework footbridge handling").
At that point we should have changed the fallback

> > Nicolas, something that should be fixed, I think?
> >
>
> I confirm DEBUG_LL is not broken on SAMV7. The config used by lkp doen't
> define DEBUG_AT91_SAMV7_USART1, it is not the culprit. Select it and the
> problem is gone since DEBUG_AT91_SAMV7_USART1 selects DEBUG_AT91_UART
> and DEBUG_LL_INCLUDE has:
> default "debug/at91.S" if DEBUG_AT91_UART
>
> Your issue is CONFIG_DEBUG_SEMIHOSTING

Right, in particular, semihosting is not handled in
arch/arm/boot/compressed/head.S the way it is handled in
arch/arm/boot/compressed/debug.S, arch/arm/kernel/debug.S
and arch/arm/kernel/head.S.

I wonder if we should move the semihosting code into a separate
arch/arm/include/debug/semihosting.S to make the generic
code treat it the same as all the other options.

Alternatively, disabling CONFIG_DEBUG_UNCOMPRESS
when SEMIHOSTING is set would be the cheapest workaround
for the particular build failure.

      Arnd

^ permalink raw reply	[flat|nested] 14+ messages in thread

* Re: ./include/generated/autoconf.h:1601:33: fatal error: mach/debug-macro.S: No such file or directory
@ 2020-11-17 13:58       ` Arnd Bergmann
  0 siblings, 0 replies; 14+ messages in thread
From: Arnd Bergmann @ 2020-11-17 13:58 UTC (permalink / raw)
  To: Alexandre Belloni
  Cc: kbuild-all, kernel test robot, Arnd Bergmann, Linus Walleij,
	linux-kernel, Russell King, Ludovic Desroches, Olof Johansson,
	Claudiu Beznea, Linux ARM

On Sat, Nov 14, 2020 at 12:58 AM Alexandre Belloni
<alexandre.belloni@bootlin.com> wrote:
> On 11/11/2020 09:51:26+0100, Linus Walleij wrote:
> > On Wed, Nov 11, 2020 at 7:18 AM kernel test robot <lkp@intel.com> wrote:
> >
> > >    In file included from include/linux/kconfig.h:7,
> > >                     from <command-line>:
> > > >> ./include/generated/autoconf.h:1601:33: fatal error: mach/debug-macro.S: No such file or directory
> > >     1601 | #define CONFIG_DEBUG_LL_INCLUDE "mach/debug-macro.S"
> > >          |                                 ^~~~~~~~~~~~~~~~~~~~
> > >    compilation terminated.
> >
> > This is an interesting one!
> >
> > It happens when CONFIG_DEBUG_LL_INCLUDE does not have a custom
> > debug header for the platform under arch/arm/include/debug and the
> > KConfig falls through to the default value, which is <mach/debug-macro.S>.
> >
> > Only that the majority is not using <mach/*> anymore.
> >
> > I feel a bit like setting the default to debug/8250.S or something.
> >
> > Suggestions?
> >
> > Then the actual bug exposed:
> >
> > The config tested by the robot is using
> > CONFIG_ARCH_AT91=y
> > CONFIG_SOC_SAMV7=y
> >
> > When I look into Kconfig.debug it seems that this will define
> > DEBUG_AT91_SAMV7_USART1 but only a physical address,
> > no virtual address and and actually no debug header. It seems
> > LL_DEBUG is broken on SAMV7 and never really worked
> > so now that crops up.

The last mach/debug-macro.S file was apparently removed in 2015,
in commit 0045c0dd2f64 ("ARM: debug-ll: rework footbridge handling").
At that point we should have changed the fallback

> > Nicolas, something that should be fixed, I think?
> >
>
> I confirm DEBUG_LL is not broken on SAMV7. The config used by lkp doen't
> define DEBUG_AT91_SAMV7_USART1, it is not the culprit. Select it and the
> problem is gone since DEBUG_AT91_SAMV7_USART1 selects DEBUG_AT91_UART
> and DEBUG_LL_INCLUDE has:
> default "debug/at91.S" if DEBUG_AT91_UART
>
> Your issue is CONFIG_DEBUG_SEMIHOSTING

Right, in particular, semihosting is not handled in
arch/arm/boot/compressed/head.S the way it is handled in
arch/arm/boot/compressed/debug.S, arch/arm/kernel/debug.S
and arch/arm/kernel/head.S.

I wonder if we should move the semihosting code into a separate
arch/arm/include/debug/semihosting.S to make the generic
code treat it the same as all the other options.

Alternatively, disabling CONFIG_DEBUG_UNCOMPRESS
when SEMIHOSTING is set would be the cheapest workaround
for the particular build failure.

      Arnd

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 14+ messages in thread

* Re: ./include/generated/autoconf.h:1601:33: fatal error: mach/debug-macro.S: No such file or directory
@ 2020-11-17 13:58       ` Arnd Bergmann
  0 siblings, 0 replies; 14+ messages in thread
From: Arnd Bergmann @ 2020-11-17 13:58 UTC (permalink / raw)
  To: kbuild-all

[-- Attachment #1: Type: text/plain, Size: 2598 bytes --]

On Sat, Nov 14, 2020 at 12:58 AM Alexandre Belloni
<alexandre.belloni@bootlin.com> wrote:
> On 11/11/2020 09:51:26+0100, Linus Walleij wrote:
> > On Wed, Nov 11, 2020 at 7:18 AM kernel test robot <lkp@intel.com> wrote:
> >
> > >    In file included from include/linux/kconfig.h:7,
> > >                     from <command-line>:
> > > >> ./include/generated/autoconf.h:1601:33: fatal error: mach/debug-macro.S: No such file or directory
> > >     1601 | #define CONFIG_DEBUG_LL_INCLUDE "mach/debug-macro.S"
> > >          |                                 ^~~~~~~~~~~~~~~~~~~~
> > >    compilation terminated.
> >
> > This is an interesting one!
> >
> > It happens when CONFIG_DEBUG_LL_INCLUDE does not have a custom
> > debug header for the platform under arch/arm/include/debug and the
> > KConfig falls through to the default value, which is <mach/debug-macro.S>.
> >
> > Only that the majority is not using <mach/*> anymore.
> >
> > I feel a bit like setting the default to debug/8250.S or something.
> >
> > Suggestions?
> >
> > Then the actual bug exposed:
> >
> > The config tested by the robot is using
> > CONFIG_ARCH_AT91=y
> > CONFIG_SOC_SAMV7=y
> >
> > When I look into Kconfig.debug it seems that this will define
> > DEBUG_AT91_SAMV7_USART1 but only a physical address,
> > no virtual address and and actually no debug header. It seems
> > LL_DEBUG is broken on SAMV7 and never really worked
> > so now that crops up.

The last mach/debug-macro.S file was apparently removed in 2015,
in commit 0045c0dd2f64 ("ARM: debug-ll: rework footbridge handling").
At that point we should have changed the fallback

> > Nicolas, something that should be fixed, I think?
> >
>
> I confirm DEBUG_LL is not broken on SAMV7. The config used by lkp doen't
> define DEBUG_AT91_SAMV7_USART1, it is not the culprit. Select it and the
> problem is gone since DEBUG_AT91_SAMV7_USART1 selects DEBUG_AT91_UART
> and DEBUG_LL_INCLUDE has:
> default "debug/at91.S" if DEBUG_AT91_UART
>
> Your issue is CONFIG_DEBUG_SEMIHOSTING

Right, in particular, semihosting is not handled in
arch/arm/boot/compressed/head.S the way it is handled in
arch/arm/boot/compressed/debug.S, arch/arm/kernel/debug.S
and arch/arm/kernel/head.S.

I wonder if we should move the semihosting code into a separate
arch/arm/include/debug/semihosting.S to make the generic
code treat it the same as all the other options.

Alternatively, disabling CONFIG_DEBUG_UNCOMPRESS
when SEMIHOSTING is set would be the cheapest workaround
for the particular build failure.

      Arnd

^ permalink raw reply	[flat|nested] 14+ messages in thread

end of thread, other threads:[~2020-11-17 14:00 UTC | newest]

Thread overview: 14+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-11-11  6:17 ./include/generated/autoconf.h:1601:33: fatal error: mach/debug-macro.S: No such file or directory kernel test robot
2020-11-11  6:17 ` kernel test robot
2020-11-11  8:51 ` Linus Walleij
2020-11-11  8:51   ` Linus Walleij
2020-11-11  8:51   ` Linus Walleij
2020-11-13 23:28   ` Alexandre Belloni
2020-11-13 23:28     ` Alexandre Belloni
2020-11-13 23:28     ` Alexandre Belloni
2020-11-13 23:58   ` Alexandre Belloni
2020-11-13 23:58     ` Alexandre Belloni
2020-11-13 23:58     ` Alexandre Belloni
2020-11-17 13:58     ` Arnd Bergmann
2020-11-17 13:58       ` Arnd Bergmann
2020-11-17 13:58       ` Arnd Bergmann

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.