All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] memory: tegra20-emc: remove redundant error message
@ 2020-11-14  5:12 ` Nigel Christian
  0 siblings, 0 replies; 6+ messages in thread
From: Nigel Christian @ 2020-11-14  5:12 UTC (permalink / raw)
  To: krzk; +Cc: thierry.reding, jonathanh, digetx, linux-tegra, kernel-janitors

There is no need for dev_err() since irq already prints an error. 
Eliminate unnecessary curly braces for single statement block.

Signed-off-by: Nigel Christian <nigel.l.christian@gmail.com>
---
 drivers/memory/tegra/tegra20-emc.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/drivers/memory/tegra/tegra20-emc.c b/drivers/memory/tegra/tegra20-emc.c
index 5e10aa97809f..181a360d7d6b 100644
--- a/drivers/memory/tegra/tegra20-emc.c
+++ b/drivers/memory/tegra/tegra20-emc.c
@@ -959,10 +959,8 @@ static int tegra_emc_probe(struct platform_device *pdev)
 	int irq, err;
 
 	irq = platform_get_irq(pdev, 0);
-	if (irq < 0) {
-		dev_err(&pdev->dev, "please update your device tree\n");
+	if (irq < 0)
 		return irq;
-	}
 
 	emc = devm_kzalloc(&pdev->dev, sizeof(*emc), GFP_KERNEL);
 	if (!emc)
-- 
2.28.0


^ permalink raw reply related	[flat|nested] 6+ messages in thread
* [PATCH] memory: tegra20-emc: remove redundant error message
@ 2020-11-14  5:12 ` Nigel Christian
  0 siblings, 0 replies; 6+ messages in thread
From: Nigel Christian @ 2020-11-14  5:12 UTC (permalink / raw)
  To: krzk; +Cc: thierry.reding, jonathanh, digetx, linux-tegra, kernel-janitors

There is no need for dev_err() since irq already prints an error. 
Eliminate unnecessary curly braces for single statement block.

Signed-off-by: Nigel Christian <nigel.l.christian@gmail.com>
---
 drivers/memory/tegra/tegra20-emc.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/drivers/memory/tegra/tegra20-emc.c b/drivers/memory/tegra/tegra20-emc.c
index 5e10aa97809f..181a360d7d6b 100644
--- a/drivers/memory/tegra/tegra20-emc.c
+++ b/drivers/memory/tegra/tegra20-emc.c
@@ -959,10 +959,8 @@ static int tegra_emc_probe(struct platform_device *pdev)
 	int irq, err;
 
 	irq = platform_get_irq(pdev, 0);
-	if (irq < 0) {
-		dev_err(&pdev->dev, "please update your device tree\n");
+	if (irq < 0)
 		return irq;
-	}
 
 	emc = devm_kzalloc(&pdev->dev, sizeof(*emc), GFP_KERNEL);
 	if (!emc)
-- 
2.28.0

^ permalink raw reply related	[flat|nested] 6+ messages in thread
* Re: [PATCH] memory: tegra20-emc: remove redundant error message
  2020-11-14  5:12 ` Nigel Christian
@ 2020-11-14  5:33   ` Dmitry Osipenko
  -1 siblings, 0 replies; 6+ messages in thread
From: Dmitry Osipenko @ 2020-11-14  5:33 UTC (permalink / raw)
  To: Nigel Christian, krzk
  Cc: thierry.reding, jonathanh, linux-tegra, kernel-janitors

14.11.2020 08:12, Nigel Christian пишет:
> There is no need for dev_err() since irq already prints an error. 
> Eliminate unnecessary curly braces for single statement block.
> 
> Signed-off-by: Nigel Christian <nigel.l.christian@gmail.com>
> ---
>  drivers/memory/tegra/tegra20-emc.c | 4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)
> 
> diff --git a/drivers/memory/tegra/tegra20-emc.c b/drivers/memory/tegra/tegra20-emc.c
> index 5e10aa97809f..181a360d7d6b 100644
> --- a/drivers/memory/tegra/tegra20-emc.c
> +++ b/drivers/memory/tegra/tegra20-emc.c
> @@ -959,10 +959,8 @@ static int tegra_emc_probe(struct platform_device *pdev)
>  	int irq, err;
>  
>  	irq = platform_get_irq(pdev, 0);
> -	if (irq < 0) {
> -		dev_err(&pdev->dev, "please update your device tree\n");
> +	if (irq < 0)
>  		return irq;
> -	}
>  
>  	emc = devm_kzalloc(&pdev->dev, sizeof(*emc), GFP_KERNEL);
>  	if (!emc)
> 

This message has a special purpose, it shouldn't be removed. Please
always check what auto-generated patches actually do.

^ permalink raw reply	[flat|nested] 6+ messages in thread
* Re: [PATCH] memory: tegra20-emc: remove redundant error message
@ 2020-11-14  5:33   ` Dmitry Osipenko
  0 siblings, 0 replies; 6+ messages in thread
From: Dmitry Osipenko @ 2020-11-14  5:33 UTC (permalink / raw)
  To: Nigel Christian, krzk
  Cc: thierry.reding, jonathanh, linux-tegra, kernel-janitors

14.11.2020 08:12, Nigel Christian пишет:
> There is no need for dev_err() since irq already prints an error. 
> Eliminate unnecessary curly braces for single statement block.
> 
> Signed-off-by: Nigel Christian <nigel.l.christian@gmail.com>
> ---
>  drivers/memory/tegra/tegra20-emc.c | 4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)
> 
> diff --git a/drivers/memory/tegra/tegra20-emc.c b/drivers/memory/tegra/tegra20-emc.c
> index 5e10aa97809f..181a360d7d6b 100644
> --- a/drivers/memory/tegra/tegra20-emc.c
> +++ b/drivers/memory/tegra/tegra20-emc.c
> @@ -959,10 +959,8 @@ static int tegra_emc_probe(struct platform_device *pdev)
>  	int irq, err;
>  
>  	irq = platform_get_irq(pdev, 0);
> -	if (irq < 0) {
> -		dev_err(&pdev->dev, "please update your device tree\n");
> +	if (irq < 0)
>  		return irq;
> -	}
>  
>  	emc = devm_kzalloc(&pdev->dev, sizeof(*emc), GFP_KERNEL);
>  	if (!emc)
> 

This message has a special purpose, it shouldn't be removed. Please
always check what auto-generated patches actually do.

^ permalink raw reply	[flat|nested] 6+ messages in thread
* Re: [PATCH] memory: tegra20-emc: remove redundant error message
  2020-11-14  5:33   ` Dmitry Osipenko
@ 2020-11-14  5:55     ` Nigel Christian
  -1 siblings, 0 replies; 6+ messages in thread
From: Nigel Christian @ 2020-11-14  5:55 UTC (permalink / raw)
  To: Dmitry Osipenko
  Cc: krzk, thierry.reding, jonathanh, kernel-janitors, linux-tegra

On Sat, Nov 14, 2020 at 08:33:47AM +0300, Dmitry Osipenko wrote:
> 14.11.2020 08:12, Nigel Christian пишет:
> > There is no need for dev_err() since irq already prints an error. 
> > Eliminate unnecessary curly braces for single statement block.
> > 
> > Signed-off-by: Nigel Christian <nigel.l.christian@gmail.com>
> > ---
> >  drivers/memory/tegra/tegra20-emc.c | 4 +---
> >  1 file changed, 1 insertion(+), 3 deletions(-)
> > 
> > diff --git a/drivers/memory/tegra/tegra20-emc.c b/drivers/memory/tegra/tegra20-emc.c
> > index 5e10aa97809f..181a360d7d6b 100644
> > --- a/drivers/memory/tegra/tegra20-emc.c
> > +++ b/drivers/memory/tegra/tegra20-emc.c
> > @@ -959,10 +959,8 @@ static int tegra_emc_probe(struct platform_device *pdev)
> >  	int irq, err;
> >  
> >  	irq = platform_get_irq(pdev, 0);
> > -	if (irq < 0) {
> > -		dev_err(&pdev->dev, "please update your device tree\n");
> > +	if (irq < 0)
> >  		return irq;
> > -	}
> >  
> >  	emc = devm_kzalloc(&pdev->dev, sizeof(*emc), GFP_KERNEL);
> >  	if (!emc)
> > 
> 
> This message has a special purpose, it shouldn't be removed. Please
> always check what auto-generated patches actually do.

Apologies, understood. Thank you for your time.

^ permalink raw reply	[flat|nested] 6+ messages in thread
* Re: [PATCH] memory: tegra20-emc: remove redundant error message
@ 2020-11-14  5:55     ` Nigel Christian
  0 siblings, 0 replies; 6+ messages in thread
From: Nigel Christian @ 2020-11-14  5:55 UTC (permalink / raw)
  To: Dmitry Osipenko
  Cc: krzk, thierry.reding, jonathanh, kernel-janitors, linux-tegra

On Sat, Nov 14, 2020 at 08:33:47AM +0300, Dmitry Osipenko wrote:
> 14.11.2020 08:12, Nigel Christian пишет:
> > There is no need for dev_err() since irq already prints an error. 
> > Eliminate unnecessary curly braces for single statement block.
> > 
> > Signed-off-by: Nigel Christian <nigel.l.christian@gmail.com>
> > ---
> >  drivers/memory/tegra/tegra20-emc.c | 4 +---
> >  1 file changed, 1 insertion(+), 3 deletions(-)
> > 
> > diff --git a/drivers/memory/tegra/tegra20-emc.c b/drivers/memory/tegra/tegra20-emc.c
> > index 5e10aa97809f..181a360d7d6b 100644
> > --- a/drivers/memory/tegra/tegra20-emc.c
> > +++ b/drivers/memory/tegra/tegra20-emc.c
> > @@ -959,10 +959,8 @@ static int tegra_emc_probe(struct platform_device *pdev)
> >  	int irq, err;
> >  
> >  	irq = platform_get_irq(pdev, 0);
> > -	if (irq < 0) {
> > -		dev_err(&pdev->dev, "please update your device tree\n");
> > +	if (irq < 0)
> >  		return irq;
> > -	}
> >  
> >  	emc = devm_kzalloc(&pdev->dev, sizeof(*emc), GFP_KERNEL);
> >  	if (!emc)
> > 
> 
> This message has a special purpose, it shouldn't be removed. Please
> always check what auto-generated patches actually do.

Apologies, understood. Thank you for your time.

^ permalink raw reply	[flat|nested] 6+ messages in thread
end of thread, other threads:[~2020-11-14  5:56 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-11-14  5:12 [PATCH] memory: tegra20-emc: remove redundant error message Nigel Christian
2020-11-14  5:12 ` Nigel Christian
2020-11-14  5:33 ` Dmitry Osipenko
2020-11-14  5:33   ` Dmitry Osipenko
2020-11-14  5:55   ` Nigel Christian
2020-11-14  5:55     ` Nigel Christian

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.