All of lore.kernel.org
 help / color / mirror / Atom feed
From: Sam Ravnborg <sam@ravnborg.org>
To: Lee Jones <lee.jones@linaro.org>, Eric Anholt <eric@anholt.net>
Cc: David Airlie <airlied@linux.ie>,
	dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 12/40] drm/pl111/pl111_display: Make local function static
Date: Sat, 14 Nov 2020 20:11:27 +0100	[thread overview]
Message-ID: <20201114191127.GB3797389@ravnborg.org> (raw)
In-Reply-To: <20201113134938.4004947-13-lee.jones@linaro.org>

Hi Lee,
On Fri, Nov 13, 2020 at 01:49:10PM +0000, Lee Jones wrote:
> Fixes the following W=1 kernel build warning(s):
> 
>  drivers/gpu/drm/pl111/pl111_display.c:356:6: warning: no previous prototype for ‘pl111_display_disable’ [-Wmissing-prototypes]
> 
> Cc: Eric Anholt <eric@anholt.net>
> Cc: David Airlie <airlied@linux.ie>
> Cc: Daniel Vetter <daniel@ffwll.ch>
> Cc: dri-devel@lists.freedesktop.org
> Signed-off-by: Lee Jones <lee.jones@linaro.org>

Eric's was not copied on this or the other pl111 patch.
Added Eric so he can be aware of this fix.

	Sam

> ---
>  drivers/gpu/drm/pl111/pl111_display.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/pl111/pl111_display.c b/drivers/gpu/drm/pl111/pl111_display.c
> index b3e8697cafcf1..69c02e7c82b7e 100644
> --- a/drivers/gpu/drm/pl111/pl111_display.c
> +++ b/drivers/gpu/drm/pl111/pl111_display.c
> @@ -353,7 +353,7 @@ static void pl111_display_enable(struct drm_simple_display_pipe *pipe,
>  		drm_crtc_vblank_on(crtc);
>  }
>  
> -void pl111_display_disable(struct drm_simple_display_pipe *pipe)
> +static void pl111_display_disable(struct drm_simple_display_pipe *pipe)
>  {
>  	struct drm_crtc *crtc = &pipe->crtc;
>  	struct drm_device *drm = crtc->dev;
> -- 
> 2.25.1
> 
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel

WARNING: multiple messages have this Message-ID (diff)
From: Sam Ravnborg <sam@ravnborg.org>
To: Lee Jones <lee.jones@linaro.org>, Eric Anholt <eric@anholt.net>
Cc: David Airlie <airlied@linux.ie>,
	linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org
Subject: Re: [PATCH 12/40] drm/pl111/pl111_display: Make local function static
Date: Sat, 14 Nov 2020 20:11:27 +0100	[thread overview]
Message-ID: <20201114191127.GB3797389@ravnborg.org> (raw)
In-Reply-To: <20201113134938.4004947-13-lee.jones@linaro.org>

Hi Lee,
On Fri, Nov 13, 2020 at 01:49:10PM +0000, Lee Jones wrote:
> Fixes the following W=1 kernel build warning(s):
> 
>  drivers/gpu/drm/pl111/pl111_display.c:356:6: warning: no previous prototype for ‘pl111_display_disable’ [-Wmissing-prototypes]
> 
> Cc: Eric Anholt <eric@anholt.net>
> Cc: David Airlie <airlied@linux.ie>
> Cc: Daniel Vetter <daniel@ffwll.ch>
> Cc: dri-devel@lists.freedesktop.org
> Signed-off-by: Lee Jones <lee.jones@linaro.org>

Eric's was not copied on this or the other pl111 patch.
Added Eric so he can be aware of this fix.

	Sam

> ---
>  drivers/gpu/drm/pl111/pl111_display.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/pl111/pl111_display.c b/drivers/gpu/drm/pl111/pl111_display.c
> index b3e8697cafcf1..69c02e7c82b7e 100644
> --- a/drivers/gpu/drm/pl111/pl111_display.c
> +++ b/drivers/gpu/drm/pl111/pl111_display.c
> @@ -353,7 +353,7 @@ static void pl111_display_enable(struct drm_simple_display_pipe *pipe,
>  		drm_crtc_vblank_on(crtc);
>  }
>  
> -void pl111_display_disable(struct drm_simple_display_pipe *pipe)
> +static void pl111_display_disable(struct drm_simple_display_pipe *pipe)
>  {
>  	struct drm_crtc *crtc = &pipe->crtc;
>  	struct drm_device *drm = crtc->dev;
> -- 
> 2.25.1
> 
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

  reply	other threads:[~2020-11-14 19:11 UTC|newest]

Thread overview: 246+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-11-13 13:48 [PATCH 00/40] [Set 7] Rid W=1 warnings from GPU Lee Jones
2020-11-13 13:48 ` Lee Jones
2020-11-13 13:48 ` Lee Jones
2020-11-13 13:48 ` Lee Jones
2020-11-13 13:48 ` Lee Jones
2020-11-13 13:48 ` Lee Jones
2020-11-13 13:48 ` [PATCH 01/40] drm/amd/include/vega10_ip_offset: Mark _BASE structs as __maybe_unused Lee Jones
2020-11-13 13:48   ` Lee Jones
2020-11-13 13:48   ` Lee Jones
2020-11-13 15:16   ` Alex Deucher
2020-11-13 15:16     ` Alex Deucher
2020-11-13 15:16     ` Alex Deucher
2020-11-15 23:12   ` Joe Perches
2020-11-15 23:12     ` Joe Perches
2020-11-15 23:12     ` Joe Perches
2020-11-13 13:49 ` [PATCH 02/40] drm/amd/display/dc/core/dc_link_dp: Move DP_VGA_LVDS_CONVERTER_ID_{2,3} to where they're used Lee Jones
2020-11-13 13:49   ` [PATCH 02/40] drm/amd/display/dc/core/dc_link_dp: Move DP_VGA_LVDS_CONVERTER_ID_{2, 3} " Lee Jones
2020-11-13 13:49   ` Lee Jones
2020-11-13 15:23   ` Alex Deucher
2020-11-13 15:23     ` Alex Deucher
2020-11-13 15:23     ` Alex Deucher
2020-11-13 15:26     ` Alex Deucher
2020-11-13 15:26       ` Alex Deucher
2020-11-13 15:26       ` Alex Deucher
2020-11-13 15:45     ` Lee Jones
2020-11-13 15:45       ` Lee Jones
2020-11-13 15:45       ` Lee Jones
2020-11-13 15:27   ` Alex Deucher
2020-11-13 15:27     ` Alex Deucher
2020-11-13 15:27     ` Alex Deucher
2020-11-13 13:49 ` [PATCH 03/40] drm/amd/display/dc/core/dc_link_ddc: Move DP_DVI_CONVERTER_ID_{4,5} " Lee Jones
2020-11-13 13:49   ` [PATCH 03/40] drm/amd/display/dc/core/dc_link_ddc: Move DP_DVI_CONVERTER_ID_{4, 5} " Lee Jones
2020-11-13 13:49   ` Lee Jones
2020-11-13 15:28   ` Alex Deucher
2020-11-13 15:28     ` Alex Deucher
2020-11-13 15:28     ` Alex Deucher
2020-11-13 13:49 ` [PATCH 04/40] drm/amd/amdgpu/amdgpu_drv: Move 'amdgpu_info_ioctl()'s prototype to shared header Lee Jones
2020-11-13 13:49   ` Lee Jones
2020-11-13 13:49   ` Lee Jones
2020-11-13 15:44   ` Alex Deucher
2020-11-13 15:44     ` Alex Deucher
2020-11-13 15:44     ` Alex Deucher
2020-11-18 10:24     ` Lee Jones
2020-11-18 10:24       ` Lee Jones
2020-11-18 10:24       ` Lee Jones
2020-11-13 13:49 ` [PATCH 05/40] drm/amd/amdgpu/amdgpu_ring: Fix misnaming of param 'max_dw' Lee Jones
2020-11-13 13:49   ` Lee Jones
2020-11-13 13:49   ` Lee Jones
2020-11-13 17:12   ` Alex Deucher
2020-11-13 17:12     ` Alex Deucher
2020-11-13 17:12     ` Alex Deucher
2020-11-13 13:49 ` [PATCH 06/40] drm/msm/adreno/a6xx_gpu: Staticise local function 'a6xx_idle' Lee Jones
2020-11-13 13:49   ` Lee Jones
2020-11-13 15:30   ` [Freedreno] " Jordan Crouse
2020-11-13 15:30     ` Jordan Crouse
2020-11-13 13:49 ` [PATCH 07/40] drm/mediatek/mtk_disp_rdma: Fix formatting and supply missing struct member description Lee Jones
2020-11-13 13:49   ` Lee Jones
2020-11-13 13:49   ` Lee Jones
2020-11-13 13:49   ` Lee Jones
2020-11-23 14:30   ` Chun-Kuang Hu
2020-11-23 14:30     ` Chun-Kuang Hu
2020-11-23 14:30     ` Chun-Kuang Hu
2020-11-23 14:30     ` Chun-Kuang Hu
2020-11-13 13:49 ` [PATCH 08/40] drm/amd/amdgpu/amdgpu_ib: Fix some incorrect/incomplete function documentation Lee Jones
2020-11-13 13:49   ` Lee Jones
2020-11-13 13:49   ` Lee Jones
2020-11-13 17:16   ` Alex Deucher
2020-11-13 17:16     ` Alex Deucher
2020-11-13 17:16     ` Alex Deucher
2020-11-13 13:49 ` [PATCH 09/40] drm/mediatek/mtk_drm_crtc: Demote seriously out-of-date struct header Lee Jones
2020-11-13 13:49   ` Lee Jones
2020-11-13 13:49   ` Lee Jones
2020-11-13 13:49   ` Lee Jones
2020-11-13 13:49 ` [PATCH 10/40] drm/mediatek/mtk_drm_drv: Staticise local function invoked by reference Lee Jones
2020-11-13 13:49   ` Lee Jones
2020-11-13 13:49   ` Lee Jones
2020-11-13 13:49   ` Lee Jones
2020-11-23 14:30   ` Chun-Kuang Hu
2020-11-23 14:30     ` Chun-Kuang Hu
2020-11-23 14:30     ` Chun-Kuang Hu
2020-11-23 14:30     ` Chun-Kuang Hu
2020-11-13 13:49 ` [PATCH 11/40] drm/amd/amdgpu/amdgpu_pll: Fix kernel-doc formatting, missing and extra params Lee Jones
2020-11-13 13:49   ` Lee Jones
2020-11-13 13:49   ` Lee Jones
2020-11-13 17:17   ` Alex Deucher
2020-11-13 17:17     ` Alex Deucher
2020-11-13 17:17     ` Alex Deucher
2020-11-13 13:49 ` [PATCH 12/40] drm/pl111/pl111_display: Make local function static Lee Jones
2020-11-13 13:49   ` Lee Jones
2020-11-14 19:11   ` Sam Ravnborg [this message]
2020-11-14 19:11     ` Sam Ravnborg
2020-11-16  8:40     ` Lee Jones
2020-11-16  8:40       ` Lee Jones
2020-11-16 10:17       ` Sam Ravnborg
2020-11-16 10:17         ` Sam Ravnborg
2020-11-16 10:25         ` Lee Jones
2020-11-16 10:25           ` Lee Jones
2020-11-16 11:18           ` Sam Ravnborg
2020-11-16 11:18             ` Sam Ravnborg
2020-11-13 13:49 ` [PATCH 13/40] drm/panel/panel-tpo-tpg110: Correct misnaming and supply missing param description Lee Jones
2020-11-13 13:49   ` Lee Jones
2020-11-14 19:27   ` Sam Ravnborg
2020-11-14 19:27     ` Sam Ravnborg
2020-11-13 13:49 ` [PATCH 14/40] drm/meson/meson_venc: Make local function 'meson_venc_hdmi_get_dmt_vmode' static Lee Jones
2020-11-13 13:49   ` Lee Jones
2020-11-13 13:49   ` Lee Jones
2020-11-13 13:49   ` Lee Jones
2020-11-16  8:48   ` Neil Armstrong
2020-11-16  8:48     ` Neil Armstrong
2020-11-16  8:48     ` Neil Armstrong
2020-11-16  8:48     ` Neil Armstrong
2020-11-13 13:49 ` [PATCH 15/40] drm/lima/lima_drv: Demote kernel-doc formatting abuse Lee Jones
2020-11-13 13:49   ` Lee Jones
2020-11-16  0:24   ` Qiang Yu
2020-11-16  0:24     ` Qiang Yu
2020-11-13 13:49 ` [PATCH 16/40] drm/amd/amdgpu/amdgpu_sync: Fix misnamed, missing and extra param descriptions Lee Jones
2020-11-13 13:49   ` Lee Jones
2020-11-13 13:49   ` Lee Jones
2020-11-13 17:18   ` Alex Deucher
2020-11-13 17:18     ` Alex Deucher
2020-11-13 17:18     ` Alex Deucher
2020-11-13 13:49 ` [PATCH 17/40] drm/meson/meson_vclk: Make two local functions static Lee Jones
2020-11-13 13:49   ` Lee Jones
2020-11-13 13:49   ` Lee Jones
2020-11-13 13:49   ` Lee Jones
2020-11-16  8:49   ` Neil Armstrong
2020-11-16  8:49     ` Neil Armstrong
2020-11-16  8:49     ` Neil Armstrong
2020-11-16  8:49     ` Neil Armstrong
2020-11-13 13:49 ` [PATCH 18/40] drm/mediatek/mtk_dpi: Remove unused struct definition 'mtk_dpi_encoder_funcs' Lee Jones
2020-11-13 13:49   ` Lee Jones
2020-11-13 13:49   ` Lee Jones
2020-11-13 13:49   ` Lee Jones
2020-11-23 14:36   ` Chun-Kuang Hu
2020-11-23 14:36     ` Chun-Kuang Hu
2020-11-23 14:36     ` Chun-Kuang Hu
2020-11-23 14:36     ` Chun-Kuang Hu
2020-11-13 13:49 ` [PATCH 19/40] drm/amd/amdgpu/amdgpu_vram_mgr: Add missing descriptions for 'dev' and 'dir' Lee Jones
2020-11-13 13:49   ` Lee Jones
2020-11-13 13:49   ` Lee Jones
2020-11-13 17:20   ` Alex Deucher
2020-11-13 17:20     ` Alex Deucher
2020-11-13 17:20     ` Alex Deucher
2020-11-13 13:49 ` [PATCH 20/40] drm/pl111/pl111_debugfs: Make local function 'pl111_debugfs_regs()' static Lee Jones
2020-11-13 13:49   ` Lee Jones
2020-11-13 13:49 ` [PATCH 21/40] drm/amd/amdgpu/amdgpu_virt: Make local function 'amdgpu_virt_update_vf2pf_work_item()' static Lee Jones
2020-11-13 13:49   ` Lee Jones
2020-11-13 13:49   ` Lee Jones
2020-11-13 17:21   ` Alex Deucher
2020-11-13 17:21     ` Alex Deucher
2020-11-13 17:21     ` Alex Deucher
2020-11-13 13:49 ` [PATCH 22/40] drm/amd/amdgpu/amdgpu_sched: Consume our own header containing prototypes Lee Jones
2020-11-13 13:49   ` Lee Jones
2020-11-13 13:49   ` Lee Jones
2020-11-13 17:24   ` Alex Deucher
2020-11-13 17:24     ` Alex Deucher
2020-11-13 17:24     ` Alex Deucher
2020-11-13 13:49 ` [PATCH 23/40] drm/lima/lima_sched: Remove unused and unnecessary variable 'ret' Lee Jones
2020-11-13 13:49   ` Lee Jones
2020-11-16  0:24   ` Qiang Yu
2020-11-16  0:24     ` Qiang Yu
2020-11-13 13:49 ` [PATCH 24/40] drm/amd/amdgpu/amdgpu_ids: Supply missing docs for 'id' and 'vmhub' Lee Jones
2020-11-13 13:49   ` Lee Jones
2020-11-13 13:49   ` Lee Jones
2020-11-13 17:26   ` Alex Deucher
2020-11-13 17:26     ` Alex Deucher
2020-11-13 17:26     ` Alex Deucher
2020-11-13 13:49 ` [PATCH 25/40] drm/amd/amdgpu/amdgpu_debugfs: Demote obvious abuse of kernel-doc formatting Lee Jones
2020-11-13 13:49   ` Lee Jones
2020-11-13 13:49   ` Lee Jones
2020-11-13 17:27   ` Alex Deucher
2020-11-13 17:27     ` Alex Deucher
2020-11-13 17:27     ` Alex Deucher
2020-11-13 13:49 ` [PATCH 26/40] drm/amd/amdgpu/amdgpu_gmc: Demote one and fix another function header Lee Jones
2020-11-13 13:49   ` Lee Jones
2020-11-13 13:49   ` Lee Jones
2020-11-13 17:28   ` Alex Deucher
2020-11-13 17:28     ` Alex Deucher
2020-11-13 17:28     ` Alex Deucher
2020-11-13 13:49 ` [PATCH 27/40] drm/amd/amdgpu/amdgpu_ras: Remove unused function 'amdgpu_ras_error_cure' Lee Jones
2020-11-13 13:49   ` Lee Jones
2020-11-13 13:49   ` Lee Jones
2020-11-13 17:29   ` Alex Deucher
2020-11-13 17:29     ` Alex Deucher
2020-11-13 17:29     ` Alex Deucher
2020-11-13 13:49 ` [PATCH 28/40] drm/amd/amdgpu/amdgpu_ras: Make local function 'amdgpu_ras_error_status_query' static Lee Jones
2020-11-13 13:49   ` Lee Jones
2020-11-13 13:49   ` Lee Jones
2020-11-13 13:49 ` [PATCH 29/40] drm/amd/amdgpu/amdgpu_csa: Remove set but unused variable 'r' Lee Jones
2020-11-13 13:49   ` Lee Jones
2020-11-13 13:49   ` Lee Jones
2020-11-13 17:23   ` Alex Deucher
2020-11-13 17:23     ` Alex Deucher
2020-11-13 17:23     ` Alex Deucher
2020-11-13 13:49 ` [PATCH 30/40] drm/amd/amdgpu/amdgpu_vm_cpu: Fix 'amdgpu_vm_cpu_prepare()'s doc-rot Lee Jones
2020-11-13 13:49   ` Lee Jones
2020-11-13 13:49   ` Lee Jones
2020-11-13 17:31   ` Alex Deucher
2020-11-13 17:31     ` Alex Deucher
2020-11-13 17:31     ` Alex Deucher
2020-11-13 13:49 ` [PATCH 31/40] drm/amd/amdgpu/amdgpu_vm_sdma: Fix 'amdgpu_vm_sdma_prepare()'s doc-rot Lee Jones
2020-11-13 13:49   ` Lee Jones
2020-11-13 13:49   ` Lee Jones
2020-11-13 17:32   ` Alex Deucher
2020-11-13 17:32     ` Alex Deucher
2020-11-13 17:32     ` Alex Deucher
2020-11-13 13:49 ` [PATCH 32/40] drm/msm/disp/mdp5/mdp5_crtc: Make local function 'mdp5_crtc_setup_pipeline()' static Lee Jones
2020-11-13 13:49   ` Lee Jones
2020-11-13 19:43   ` abhinavk
2020-11-13 19:43     ` abhinavk
2020-11-13 13:49 ` [PATCH 33/40] drm/drm_dp_mst_topology: Remove set but never used variable 'len' Lee Jones
2020-11-13 13:49   ` Lee Jones
2020-11-13 13:49 ` [PATCH 34/40] drm/msm/disp/mdp5/mdp5_ctl: Demote non-conformant kernel-doc headers Lee Jones
2020-11-13 13:49   ` Lee Jones
2020-11-13 19:45   ` [Freedreno] " abhinavk
2020-11-13 19:45     ` abhinavk
2020-11-13 13:49 ` [PATCH 35/40] drm/msm/disp/mdp5/mdp5_kms: Make local functions 'mdp5_{en,dis}able()' static Lee Jones
2020-11-13 13:49   ` [PATCH 35/40] drm/msm/disp/mdp5/mdp5_kms: Make local functions 'mdp5_{en, dis}able()' static Lee Jones
2020-11-13 19:46   ` abhinavk
2020-11-13 19:46     ` abhinavk
2020-11-13 13:49 ` [PATCH 36/40] drm/amd/amdgpu/amdgpu_fw_attestation: Consume our own header containing prototypes Lee Jones
2020-11-13 13:49   ` Lee Jones
2020-11-13 13:49   ` Lee Jones
2020-11-13 17:33   ` Alex Deucher
2020-11-13 17:33     ` Alex Deucher
2020-11-13 17:33     ` Alex Deucher
2020-11-13 13:49 ` [PATCH 37/40] drm/amd/amdgpu/smu_v11_0_i2c: Provide descriptions for 'control' and 'data' params Lee Jones
2020-11-13 13:49   ` Lee Jones
2020-11-13 13:49   ` Lee Jones
2020-11-13 17:34   ` Alex Deucher
2020-11-13 17:34     ` Alex Deucher
2020-11-13 17:34     ` Alex Deucher
2020-11-13 13:49 ` [PATCH 38/40] drm/msm/disp/dpu1/dpu_core_perf: Remove set but unused variable 'dpu_cstate' Lee Jones
2020-11-13 13:49   ` Lee Jones
2020-11-13 19:42   ` [Freedreno] " abhinavk
2020-11-13 19:42     ` abhinavk
2020-11-13 13:49 ` [PATCH 39/40] drm/msm/disp/dpu1/dpu_encoder: Remove a bunch of unused variables Lee Jones
2020-11-13 13:49   ` Lee Jones
2020-11-13 19:42   ` [Freedreno] " abhinavk
2020-11-13 19:42     ` abhinavk
2020-11-13 13:49 ` [PATCH 40/40] drm/amd/amdgpu/gfx_v7_0: Remove unused struct definition Lee Jones
2020-11-13 13:49   ` Lee Jones
2020-11-13 13:49   ` Lee Jones
2020-11-13 17:35   ` Alex Deucher
2020-11-13 17:35     ` Alex Deucher
2020-11-13 17:35     ` Alex Deucher

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20201114191127.GB3797389@ravnborg.org \
    --to=sam@ravnborg.org \
    --cc=airlied@linux.ie \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=eric@anholt.net \
    --cc=lee.jones@linaro.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.