All of lore.kernel.org
 help / color / mirror / Atom feed
From: kernel test robot <lkp@intel.com>
To: kbuild@lists.01.org
Subject: Re: [Intel-gfx] [PATCH 08/27] drm/i915/pxp: Read register to check hardware session state
Date: Sun, 15 Nov 2020 01:12:07 +0800	[thread overview]
Message-ID: <202011150112.YEXiqsaU-lkp@intel.com> (raw)

[-- Attachment #1: Type: text/plain, Size: 4237 bytes --]

CC: kbuild-all(a)lists.01.org
In-Reply-To: <20201114014537.25495-8-sean.z.huang@intel.com>
References: <20201114014537.25495-8-sean.z.huang@intel.com>
TO: Sean Z Huang <sean.z.huang@intel.com>
TO: Intel-gfx(a)lists.freedesktop.org
CC: "Huang, Sean Z" <sean.z.huang@intel.com>

Hi Sean,

Thank you for the patch! Perhaps something to improve:

[auto build test WARNING on next-20201113]
[also build test WARNING on v5.10-rc3]
[cannot apply to drm-intel/for-linux-next char-misc/char-misc-testing v5.10-rc3 v5.10-rc2 v5.10-rc1]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/0day-ci/linux/commits/Sean-Z-Huang/drm-i915-pxp-Introduce-Intel-PXP-component/20201114-094926
base:    92edc4aef86780a8ad01b092c6d6630bb3cb423d
:::::: branch date: 15 hours ago
:::::: commit date: 15 hours ago
config: i386-randconfig-c001-20201113 (attached as .config)
compiler: gcc-9 (Debian 9.3.0-15) 9.3.0

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
Reported-by: Julia Lawall <julia.lawall@lip6.fr>


"coccinelle warnings: (new ones prefixed by >>)"
>> drivers/gpu/drm/i915/pxp/intel_pxp_sm.c:203:17-20: ERROR: i915 is NULL but dereferenced.
   drivers/gpu/drm/i915/pxp/intel_pxp_sm.c:97:17-20: ERROR: i915 is NULL but dereferenced.
   drivers/gpu/drm/i915/pxp/intel_pxp_sm.c:123:17-20: ERROR: i915 is NULL but dereferenced.
   drivers/gpu/drm/i915/pxp/intel_pxp_sm.c:171:17-20: ERROR: i915 is NULL but dereferenced.

vim +203 drivers/gpu/drm/i915/pxp/intel_pxp_sm.c

c0c82470e52f958 Huang, Sean Z 2020-11-13  188  
c0c82470e52f958 Huang, Sean Z 2020-11-13  189  /**
c0c82470e52f958 Huang, Sean Z 2020-11-13  190   * check_if_protected_type0_sessions_are_attacked - To check if type0 active sessions are attacked.
c0c82470e52f958 Huang, Sean Z 2020-11-13  191   * @i915: i915 device handle.
c0c82470e52f958 Huang, Sean Z 2020-11-13  192   *
c0c82470e52f958 Huang, Sean Z 2020-11-13  193   * Return: true if HW shows protected sessions are attacked, false otherwise.
c0c82470e52f958 Huang, Sean Z 2020-11-13  194   */
c0c82470e52f958 Huang, Sean Z 2020-11-13  195  static bool check_if_protected_type0_sessions_are_attacked(struct drm_i915_private *i915)
c0c82470e52f958 Huang, Sean Z 2020-11-13  196  {
c0c82470e52f958 Huang, Sean Z 2020-11-13  197  	i915_reg_t kcr_status_reg = KCR_STATUS_1;
c0c82470e52f958 Huang, Sean Z 2020-11-13  198  	u32 reg_value = 0;
c0c82470e52f958 Huang, Sean Z 2020-11-13  199  	u32 mask = 0x80000000;
c0c82470e52f958 Huang, Sean Z 2020-11-13  200  	int ret;
c0c82470e52f958 Huang, Sean Z 2020-11-13  201  
c0c82470e52f958 Huang, Sean Z 2020-11-13  202  	if (!i915) {
c0c82470e52f958 Huang, Sean Z 2020-11-13 @203  		drm_dbg(&i915->drm, "Failed to %s, bad params\n", __func__);
c0c82470e52f958 Huang, Sean Z 2020-11-13  204  		goto end;
c0c82470e52f958 Huang, Sean Z 2020-11-13  205  	}
c0c82470e52f958 Huang, Sean Z 2020-11-13  206  
c0c82470e52f958 Huang, Sean Z 2020-11-13  207  	if (i915->pxp.r0ctx->global_state_attacked)
c0c82470e52f958 Huang, Sean Z 2020-11-13  208  		return true;
c0c82470e52f958 Huang, Sean Z 2020-11-13  209  
c0c82470e52f958 Huang, Sean Z 2020-11-13  210  	ret = pxp_sm_reg_read(i915, kcr_status_reg.reg, &reg_value);
c0c82470e52f958 Huang, Sean Z 2020-11-13  211  	if (ret) {
c0c82470e52f958 Huang, Sean Z 2020-11-13  212  		drm_dbg(&i915->drm, "Failed to pxp_sm_reg_read\n");
c0c82470e52f958 Huang, Sean Z 2020-11-13  213  		goto end;
c0c82470e52f958 Huang, Sean Z 2020-11-13  214  	}
c0c82470e52f958 Huang, Sean Z 2020-11-13  215  
c0c82470e52f958 Huang, Sean Z 2020-11-13  216  	if (reg_value & mask)
c0c82470e52f958 Huang, Sean Z 2020-11-13  217  		return true;
c0c82470e52f958 Huang, Sean Z 2020-11-13  218  end:
c0c82470e52f958 Huang, Sean Z 2020-11-13  219  	return false;
c0c82470e52f958 Huang, Sean Z 2020-11-13  220  }
c0c82470e52f958 Huang, Sean Z 2020-11-13  221  

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org

[-- Attachment #2: config.gz --]
[-- Type: application/gzip, Size: 36612 bytes --]

             reply	other threads:[~2020-11-14 17:12 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-11-14 17:12 kernel test robot [this message]
  -- strict thread matches above, loose matches on Subject: below --
2020-11-15 21:07 [Intel-gfx] [PATCH 01/27] drm/i915/pxp: Introduce Intel PXP component Huang, Sean Z
2020-11-15 21:07 ` [Intel-gfx] [PATCH 08/27] drm/i915/pxp: Read register to check hardware session state Huang, Sean Z
2020-11-15 20:23 [Intel-gfx] [PATCH 01/27] drm/i915/pxp: Introduce Intel PXP component Huang, Sean Z
2020-11-15 20:23 ` [Intel-gfx] [PATCH 08/27] drm/i915/pxp: Read register to check hardware session state Huang, Sean Z
2020-11-14  1:45 [Intel-gfx] [PATCH 01/27] drm/i915/pxp: Introduce Intel PXP component Sean Z Huang
2020-11-14  1:45 ` [Intel-gfx] [PATCH 08/27] drm/i915/pxp: Read register to check hardware session state Sean Z Huang
2020-11-14  5:04   ` kernel test robot
2020-11-14  5:04     ` kernel test robot
2020-11-14  5:14   ` kernel test robot
2020-11-14  5:14     ` kernel test robot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=202011150112.YEXiqsaU-lkp@intel.com \
    --to=lkp@intel.com \
    --cc=kbuild@lists.01.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.