From: Christoph Hellwig <hch@lst.de>
To: "Song Bao Hua (Barry Song)" <song.bao.hua@hisilicon.com>
Cc: Christoph Hellwig <hch@lst.de>,
"iommu@lists.linux-foundation.org"
<iommu@lists.linux-foundation.org>,
"robin.murphy@arm.com" <robin.murphy@arm.com>,
"m.szyprowski@samsung.com" <m.szyprowski@samsung.com>,
Linuxarm <linuxarm@huawei.com>,
"linux-kselftest@vger.kernel.org"
<linux-kselftest@vger.kernel.org>,
"xuwei (O)" <xuwei5@huawei.com>, Joerg Roedel <joro@8bytes.org>,
Will Deacon <will@kernel.org>, Shuah Khan <shuah@kernel.org>
Subject: Re: [PATCH v3 1/2] dma-mapping: add benchmark support for streaming DMA APIs
Date: Sun, 15 Nov 2020 09:45:15 +0100 [thread overview]
Message-ID: <20201115084515.GA18411@lst.de> (raw)
In-Reply-To: <5c4488dd28fc4869b7e67dd842ffa208@hisilicon.com>
On Sun, Nov 15, 2020 at 12:11:15AM +0000, Song Bao Hua (Barry Song) wrote:
>
> Checkpatch has changed 80 to 100. That's probably why my local checkpatch didn't report any warning:
> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=bdc48fa11e46f867ea4d
>
> I am happy to change them to be less than 80 if you like.
Don't rely on checkpath, is is broken. Look at the codingstyle document.
> > I think this needs to set a dma mask as behavior for unlimited dma
> > mask vs the default 32-bit one can be very different.
>
> I actually prefer users bind real devices with real dma_mask to test rather than force to change
> the dma_mask in this benchmark.
The mask is set by the driver, not the device. So you need to set when
when you bind, real device or not.
WARNING: multiple messages have this Message-ID (diff)
From: Christoph Hellwig <hch@lst.de>
To: "Song Bao Hua (Barry Song)" <song.bao.hua@hisilicon.com>
Cc: Shuah Khan <shuah@kernel.org>, "xuwei \(O\)" <xuwei5@huawei.com>,
Will Deacon <will@kernel.org>, Linuxarm <linuxarm@huawei.com>,
"iommu@lists.linux-foundation.org"
<iommu@lists.linux-foundation.org>,
"linux-kselftest@vger.kernel.org"
<linux-kselftest@vger.kernel.org>,
"robin.murphy@arm.com" <robin.murphy@arm.com>,
Christoph Hellwig <hch@lst.de>
Subject: Re: [PATCH v3 1/2] dma-mapping: add benchmark support for streaming DMA APIs
Date: Sun, 15 Nov 2020 09:45:15 +0100 [thread overview]
Message-ID: <20201115084515.GA18411@lst.de> (raw)
In-Reply-To: <5c4488dd28fc4869b7e67dd842ffa208@hisilicon.com>
On Sun, Nov 15, 2020 at 12:11:15AM +0000, Song Bao Hua (Barry Song) wrote:
>
> Checkpatch has changed 80 to 100. That's probably why my local checkpatch didn't report any warning:
> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=bdc48fa11e46f867ea4d
>
> I am happy to change them to be less than 80 if you like.
Don't rely on checkpath, is is broken. Look at the codingstyle document.
> > I think this needs to set a dma mask as behavior for unlimited dma
> > mask vs the default 32-bit one can be very different.
>
> I actually prefer users bind real devices with real dma_mask to test rather than force to change
> the dma_mask in this benchmark.
The mask is set by the driver, not the device. So you need to set when
when you bind, real device or not.
_______________________________________________
iommu mailing list
iommu@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/iommu
next prev parent reply other threads:[~2020-11-15 8:45 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-02 8:06 [PATCH v3 0/2] dma-mapping: provide a benchmark for streaming DMA mapping Barry Song
2020-11-02 8:06 ` Barry Song
2020-11-02 8:06 ` [PATCH v3 1/2] dma-mapping: add benchmark support for streaming DMA APIs Barry Song
2020-11-02 8:06 ` Barry Song
2020-11-02 9:18 ` John Garry
2020-11-02 9:18 ` John Garry
2020-11-02 9:37 ` Song Bao Hua (Barry Song)
2020-11-02 9:37 ` Song Bao Hua (Barry Song)
2020-11-10 8:10 ` Song Bao Hua (Barry Song)
2020-11-10 8:10 ` Song Bao Hua (Barry Song)
2020-11-10 8:38 ` John Garry
2020-11-10 8:38 ` John Garry
2020-11-11 1:29 ` Song Bao Hua (Barry Song)
2020-11-11 1:29 ` Song Bao Hua (Barry Song)
[not found] ` <51f0c148-e2e3-e084-4021-ec5883919436@huawei.com>
2020-11-11 9:42 ` Song Bao Hua (Barry Song)
2020-11-11 9:42 ` Song Bao Hua (Barry Song)
2020-11-14 16:53 ` Christoph Hellwig
2020-11-14 16:53 ` Christoph Hellwig
2020-11-15 0:11 ` Song Bao Hua (Barry Song)
2020-11-15 0:11 ` Song Bao Hua (Barry Song)
2020-11-15 8:45 ` Christoph Hellwig [this message]
2020-11-15 8:45 ` Christoph Hellwig
2020-11-15 21:54 ` Song Bao Hua (Barry Song)
2020-11-15 21:54 ` Song Bao Hua (Barry Song)
2020-11-02 8:06 ` [PATCH v3 2/2] selftests/dma: add test application for DMA_MAP_BENCHMARK Barry Song
2020-11-02 8:06 ` Barry Song
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201115084515.GA18411@lst.de \
--to=hch@lst.de \
--cc=iommu@lists.linux-foundation.org \
--cc=joro@8bytes.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=linuxarm@huawei.com \
--cc=m.szyprowski@samsung.com \
--cc=robin.murphy@arm.com \
--cc=shuah@kernel.org \
--cc=song.bao.hua@hisilicon.com \
--cc=will@kernel.org \
--cc=xuwei5@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.