* [Intel-gfx] [PATCH] drm/i915/lspcon: enter standby mode to enhance power saving
@ 2020-11-16 13:59 Lee Shawn C
2020-11-16 15:20 ` [Intel-gfx] ✓ Fi.CI.BAT: success for " Patchwork
` (9 more replies)
0 siblings, 10 replies; 12+ messages in thread
From: Lee Shawn C @ 2020-11-16 13:59 UTC (permalink / raw)
To: intel-gfx; +Cc: Cooper Chiou
After system boot up, LSPCON will be configured as PCON mode.
But it never go into power saving state. Source driver can
do the following. Then LSPCON can enter standby mode
automatically to save more power.
1. At PCON mode, source driver write 0x2 to DPCD 600h.
2. At LS mode, try to disable DP_DUAL_MODE_TMDS_OEN.
Cc: Ville Syrjälä <ville.syrjala@linux.intel.com>
Cc: Jani Nikula <jani.nikula@linux.intel.com>
Cc: Uma Shankar <uma.shankar@intel.com>
Cc: Cooper Chiou <cooper.chiou@intel.com>
Cc: Khaled Almahallawy <khaled.almahallawy@intel.com>
Signed-off-by: Lee Shawn C <shawn.c.lee@intel.com>
---
drivers/gpu/drm/i915/display/intel_dp.c | 7 ++++++-
drivers/gpu/drm/i915/display/intel_lspcon.c | 8 ++++++++
drivers/gpu/drm/i915/display/intel_lspcon.h | 1 +
3 files changed, 15 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/i915/display/intel_dp.c b/drivers/gpu/drm/i915/display/intel_dp.c
index ec8359f03aaf..7dd16d6bd5ba 100644
--- a/drivers/gpu/drm/i915/display/intel_dp.c
+++ b/drivers/gpu/drm/i915/display/intel_dp.c
@@ -6536,6 +6536,7 @@ intel_dp_detect(struct drm_connector *connector,
struct drm_i915_private *dev_priv = to_i915(connector->dev);
struct intel_dp *intel_dp = intel_attached_dp(to_intel_connector(connector));
struct intel_digital_port *dig_port = dp_to_dig_port(intel_dp);
+ struct intel_lspcon *lspcon = dp_to_lspcon(intel_dp);
struct intel_encoder *encoder = &dig_port->base;
enum drm_connector_status status;
@@ -6632,9 +6633,13 @@ intel_dp_detect(struct drm_connector *connector,
intel_dp_check_service_irq(intel_dp);
out:
- if (status != connector_status_connected && !intel_dp->is_mst)
+ if (status != connector_status_connected && !intel_dp->is_mst) {
intel_dp_unset_edid(intel_dp);
+ if (lspcon && lspcon->active)
+ lspcon_standby(dp_to_dig_port(intel_dp));
+ }
+
/*
* Make sure the refs for power wells enabled during detect are
* dropped to avoid a new detect cycle triggered by HPD polling.
diff --git a/drivers/gpu/drm/i915/display/intel_lspcon.c b/drivers/gpu/drm/i915/display/intel_lspcon.c
index e37d45e531df..4913ff20d7b4 100644
--- a/drivers/gpu/drm/i915/display/intel_lspcon.c
+++ b/drivers/gpu/drm/i915/display/intel_lspcon.c
@@ -550,6 +550,14 @@ static bool lspcon_init(struct intel_digital_port *dig_port)
return true;
}
+void lspcon_standby(struct intel_digital_port *dig_port)
+{
+ struct intel_dp *dp = &dig_port->dp;
+
+ if (drm_dp_dpcd_writeb(&dp->aux, DP_SET_POWER, DP_SET_POWER_D3) <= 0)
+ DRM_DEBUG_KMS("Failed to write EDID checksum\n");
+}
+
void lspcon_resume(struct intel_digital_port *dig_port)
{
struct intel_lspcon *lspcon = &dig_port->lspcon;
diff --git a/drivers/gpu/drm/i915/display/intel_lspcon.h b/drivers/gpu/drm/i915/display/intel_lspcon.h
index b03dcb7076d8..658a2e5b22db 100644
--- a/drivers/gpu/drm/i915/display/intel_lspcon.h
+++ b/drivers/gpu/drm/i915/display/intel_lspcon.h
@@ -16,6 +16,7 @@ struct intel_encoder;
struct intel_lspcon;
void lspcon_resume(struct intel_digital_port *dig_port);
+void lspcon_standby(struct intel_digital_port *dig_port);
void lspcon_wait_pcon_mode(struct intel_lspcon *lspcon);
void lspcon_write_infoframe(struct intel_encoder *encoder,
const struct intel_crtc_state *crtc_state,
--
2.17.1
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply related [flat|nested] 12+ messages in thread
* [Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/lspcon: enter standby mode to enhance power saving
2020-11-16 13:59 [Intel-gfx] [PATCH] drm/i915/lspcon: enter standby mode to enhance power saving Lee Shawn C
@ 2020-11-16 15:20 ` Patchwork
2020-11-16 20:40 ` [Intel-gfx] ✗ Fi.CI.IGT: failure " Patchwork
` (8 subsequent siblings)
9 siblings, 0 replies; 12+ messages in thread
From: Patchwork @ 2020-11-16 15:20 UTC (permalink / raw)
To: Lee Shawn C; +Cc: intel-gfx
[-- Attachment #1.1: Type: text/plain, Size: 6033 bytes --]
== Series Details ==
Series: drm/i915/lspcon: enter standby mode to enhance power saving
URL : https://patchwork.freedesktop.org/series/83886/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_9337 -> Patchwork_18913
====================================================
Summary
-------
**WARNING**
Minor unknown changes coming with Patchwork_18913 need to be verified
manually.
If you think the reported changes have nothing to do with the changes
introduced in Patchwork_18913, please notify your bug team to allow them
to document this new failure mode, which will reduce false positives in CI.
External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18913/index.html
Possible new issues
-------------------
Here are the unknown changes that may have been introduced in Patchwork_18913:
### IGT changes ###
#### Warnings ####
* igt@i915_selftest@live@gt_pm:
- fi-tgl-y: [DMESG-FAIL][1] ([i915#1759]) -> [DMESG-FAIL][2]
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9337/fi-tgl-y/igt@i915_selftest@live@gt_pm.html
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18913/fi-tgl-y/igt@i915_selftest@live@gt_pm.html
New tests
---------
New tests have been introduced between CI_DRM_9337 and Patchwork_18913:
### New CI tests (1) ###
* boot:
- Statuses : 40 pass(s)
- Exec time: [0.0] s
Known issues
------------
Here are the changes found in Patchwork_18913 that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@gem_flink_basic@double-flink:
- fi-tgl-y: [PASS][3] -> [DMESG-WARN][4] ([i915#402]) +1 similar issue
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9337/fi-tgl-y/igt@gem_flink_basic@double-flink.html
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18913/fi-tgl-y/igt@gem_flink_basic@double-flink.html
* igt@i915_module_load@reload:
- fi-icl-y: [PASS][5] -> [DMESG-WARN][6] ([i915#1982])
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9337/fi-icl-y/igt@i915_module_load@reload.html
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18913/fi-icl-y/igt@i915_module_load@reload.html
* igt@kms_cursor_legacy@basic-busy-flip-before-cursor-atomic:
- fi-bsw-kefka: [PASS][7] -> [DMESG-WARN][8] ([i915#1982]) +1 similar issue
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9337/fi-bsw-kefka/igt@kms_cursor_legacy@basic-busy-flip-before-cursor-atomic.html
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18913/fi-bsw-kefka/igt@kms_cursor_legacy@basic-busy-flip-before-cursor-atomic.html
* igt@kms_cursor_legacy@basic-busy-flip-before-cursor-legacy:
- fi-icl-u2: [PASS][9] -> [DMESG-WARN][10] ([i915#1982]) +2 similar issues
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9337/fi-icl-u2/igt@kms_cursor_legacy@basic-busy-flip-before-cursor-legacy.html
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18913/fi-icl-u2/igt@kms_cursor_legacy@basic-busy-flip-before-cursor-legacy.html
* igt@kms_pipe_crc_basic@read-crc-pipe-c:
- fi-tgl-y: [PASS][11] -> [DMESG-WARN][12] ([i915#1982]) +1 similar issue
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9337/fi-tgl-y/igt@kms_pipe_crc_basic@read-crc-pipe-c.html
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18913/fi-tgl-y/igt@kms_pipe_crc_basic@read-crc-pipe-c.html
#### Possible fixes ####
* igt@gem_exec_suspend@basic-s0:
- fi-glk-dsi: [DMESG-WARN][13] ([i915#1982]) -> [PASS][14]
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9337/fi-glk-dsi/igt@gem_exec_suspend@basic-s0.html
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18913/fi-glk-dsi/igt@gem_exec_suspend@basic-s0.html
* igt@kms_busy@basic@flip:
- {fi-kbl-7560u}: [DMESG-WARN][15] ([i915#1982]) -> [PASS][16]
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9337/fi-kbl-7560u/igt@kms_busy@basic@flip.html
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18913/fi-kbl-7560u/igt@kms_busy@basic@flip.html
* igt@kms_cursor_legacy@basic-flip-after-cursor-atomic:
- fi-icl-u2: [DMESG-WARN][17] ([i915#1982]) -> [PASS][18]
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9337/fi-icl-u2/igt@kms_cursor_legacy@basic-flip-after-cursor-atomic.html
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18913/fi-icl-u2/igt@kms_cursor_legacy@basic-flip-after-cursor-atomic.html
* igt@prime_vgem@basic-fence-flip:
- fi-tgl-y: [DMESG-WARN][19] ([i915#402]) -> [PASS][20] +1 similar issue
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9337/fi-tgl-y/igt@prime_vgem@basic-fence-flip.html
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18913/fi-tgl-y/igt@prime_vgem@basic-fence-flip.html
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[i915#1759]: https://gitlab.freedesktop.org/drm/intel/issues/1759
[i915#1982]: https://gitlab.freedesktop.org/drm/intel/issues/1982
[i915#2524]: https://gitlab.freedesktop.org/drm/intel/issues/2524
[i915#402]: https://gitlab.freedesktop.org/drm/intel/issues/402
Participating hosts (46 -> 40)
------------------------------
Missing (6): fi-ilk-m540 fi-hsw-4200u fi-byt-j1900 fi-bsw-cyan fi-ctg-p8600 fi-bdw-samus
Build changes
-------------
* Linux: CI_DRM_9337 -> Patchwork_18913
CI-20190529: 20190529
CI_DRM_9337: 85c17640f343b06686aa677896856f2dc1388c21 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_5853: cbe997b92e4b96f8c29b5e2d49fb2ed88e1de3e2 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_18913: 61bc6a16e0c6b0ad9403620e943bee2cd302533b @ git://anongit.freedesktop.org/gfx-ci/linux
== Linux commits ==
61bc6a16e0c6 drm/i915/lspcon: enter standby mode to enhance power saving
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18913/index.html
[-- Attachment #1.2: Type: text/html, Size: 7336 bytes --]
[-- Attachment #2: Type: text/plain, Size: 160 bytes --]
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 12+ messages in thread
* [Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915/lspcon: enter standby mode to enhance power saving
2020-11-16 13:59 [Intel-gfx] [PATCH] drm/i915/lspcon: enter standby mode to enhance power saving Lee Shawn C
2020-11-16 15:20 ` [Intel-gfx] ✓ Fi.CI.BAT: success for " Patchwork
@ 2020-11-16 20:40 ` Patchwork
2020-11-17 16:29 ` [Intel-gfx] [PATCH] " Ville Syrjälä
` (7 subsequent siblings)
9 siblings, 0 replies; 12+ messages in thread
From: Patchwork @ 2020-11-16 20:40 UTC (permalink / raw)
To: Lee Shawn C; +Cc: intel-gfx
[-- Attachment #1.1: Type: text/plain, Size: 18577 bytes --]
== Series Details ==
Series: drm/i915/lspcon: enter standby mode to enhance power saving
URL : https://patchwork.freedesktop.org/series/83886/
State : failure
== Summary ==
CI Bug Log - changes from CI_DRM_9337_full -> Patchwork_18913_full
====================================================
Summary
-------
**FAILURE**
Serious unknown changes coming with Patchwork_18913_full absolutely need to be
verified manually.
If you think the reported changes have nothing to do with the changes
introduced in Patchwork_18913_full, please notify your bug team to allow them
to document this new failure mode, which will reduce false positives in CI.
Possible new issues
-------------------
Here are the unknown changes that may have been introduced in Patchwork_18913_full:
### IGT changes ###
#### Possible regressions ####
* igt@kms_flip@plain-flip-ts-check-interruptible@b-vga1:
- shard-hsw: NOTRUN -> [INCOMPLETE][1]
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18913/shard-hsw2/igt@kms_flip@plain-flip-ts-check-interruptible@b-vga1.html
#### Warnings ####
* igt@gem_exec_whisper@basic-contexts-all:
- shard-glk: [INCOMPLETE][2] -> [FAIL][3]
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9337/shard-glk3/igt@gem_exec_whisper@basic-contexts-all.html
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18913/shard-glk6/igt@gem_exec_whisper@basic-contexts-all.html
#### Suppressed ####
The following results come from untrusted machines, tests, or statuses.
They do not affect the overall result.
* {igt@kms_plane_scaling@scaler-with-clipping-clamping@pipe-b-scaler-with-rotation}:
- shard-skl: NOTRUN -> [INCOMPLETE][4]
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18913/shard-skl4/igt@kms_plane_scaling@scaler-with-clipping-clamping@pipe-b-scaler-with-rotation.html
New tests
---------
New tests have been introduced between CI_DRM_9337_full and Patchwork_18913_full:
### New CI tests (1) ###
* boot:
- Statuses : 200 pass(s)
- Exec time: [0.0] s
Known issues
------------
Here are the changes found in Patchwork_18913_full that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@gem_exec_suspend@basic-s3:
- shard-kbl: [PASS][5] -> [DMESG-WARN][6] ([i915#180])
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9337/shard-kbl1/igt@gem_exec_suspend@basic-s3.html
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18913/shard-kbl7/igt@gem_exec_suspend@basic-s3.html
* igt@gem_exec_whisper@basic-fds-forked:
- shard-glk: [PASS][7] -> [DMESG-WARN][8] ([i915#118] / [i915#95])
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9337/shard-glk8/igt@gem_exec_whisper@basic-fds-forked.html
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18913/shard-glk3/igt@gem_exec_whisper@basic-fds-forked.html
* igt@i915_pm_rpm@i2c:
- shard-skl: [PASS][9] -> [DMESG-WARN][10] ([i915#1982]) +7 similar issues
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9337/shard-skl8/igt@i915_pm_rpm@i2c.html
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18913/shard-skl5/igt@i915_pm_rpm@i2c.html
* igt@kms_big_fb@linear-64bpp-rotate-180:
- shard-kbl: [PASS][11] -> [DMESG-WARN][12] ([i915#1982]) +1 similar issue
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9337/shard-kbl2/igt@kms_big_fb@linear-64bpp-rotate-180.html
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18913/shard-kbl6/igt@kms_big_fb@linear-64bpp-rotate-180.html
* igt@kms_cursor_crc@pipe-b-cursor-256x256-offscreen:
- shard-skl: [PASS][13] -> [FAIL][14] ([i915#54]) +2 similar issues
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9337/shard-skl4/igt@kms_cursor_crc@pipe-b-cursor-256x256-offscreen.html
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18913/shard-skl8/igt@kms_cursor_crc@pipe-b-cursor-256x256-offscreen.html
* igt@kms_cursor_legacy@cursor-vs-flip-atomic-transitions:
- shard-skl: [PASS][15] -> [DMESG-WARN][16] ([i915#1982] / [i915#2295])
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9337/shard-skl7/igt@kms_cursor_legacy@cursor-vs-flip-atomic-transitions.html
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18913/shard-skl5/igt@kms_cursor_legacy@cursor-vs-flip-atomic-transitions.html
* igt@kms_cursor_legacy@flip-vs-cursor-atomic:
- shard-skl: [PASS][17] -> [FAIL][18] ([i915#2346])
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9337/shard-skl9/igt@kms_cursor_legacy@flip-vs-cursor-atomic.html
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18913/shard-skl3/igt@kms_cursor_legacy@flip-vs-cursor-atomic.html
* igt@kms_cursor_legacy@flip-vs-cursor-varying-size:
- shard-tglb: [PASS][19] -> [FAIL][20] ([i915#2346])
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9337/shard-tglb8/igt@kms_cursor_legacy@flip-vs-cursor-varying-size.html
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18913/shard-tglb5/igt@kms_cursor_legacy@flip-vs-cursor-varying-size.html
* igt@kms_flip@2x-busy-flip@ab-hdmi-a1-hdmi-a2:
- shard-glk: [PASS][21] -> [DMESG-WARN][22] ([i915#1982])
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9337/shard-glk9/igt@kms_flip@2x-busy-flip@ab-hdmi-a1-hdmi-a2.html
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18913/shard-glk9/igt@kms_flip@2x-busy-flip@ab-hdmi-a1-hdmi-a2.html
* igt@kms_frontbuffer_tracking@fbc-1p-offscren-pri-shrfb-draw-mmap-cpu:
- shard-snb: [PASS][23] -> [FAIL][24] ([i915#2546])
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9337/shard-snb2/igt@kms_frontbuffer_tracking@fbc-1p-offscren-pri-shrfb-draw-mmap-cpu.html
[24]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18913/shard-snb7/igt@kms_frontbuffer_tracking@fbc-1p-offscren-pri-shrfb-draw-mmap-cpu.html
* igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-pri-shrfb-draw-blt:
- shard-tglb: [PASS][25] -> [DMESG-WARN][26] ([i915#1982])
[25]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9337/shard-tglb7/igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-pri-shrfb-draw-blt.html
[26]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18913/shard-tglb8/igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-pri-shrfb-draw-blt.html
* igt@kms_plane_alpha_blend@pipe-a-constant-alpha-min:
- shard-skl: [PASS][27] -> [FAIL][28] ([fdo#108145] / [i915#265])
[27]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9337/shard-skl7/igt@kms_plane_alpha_blend@pipe-a-constant-alpha-min.html
[28]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18913/shard-skl5/igt@kms_plane_alpha_blend@pipe-a-constant-alpha-min.html
* igt@kms_psr@psr2_sprite_plane_move:
- shard-iclb: [PASS][29] -> [SKIP][30] ([fdo#109441]) +1 similar issue
[29]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9337/shard-iclb2/igt@kms_psr@psr2_sprite_plane_move.html
[30]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18913/shard-iclb6/igt@kms_psr@psr2_sprite_plane_move.html
#### Possible fixes ####
* igt@core_hotunplug@hotrebind-lateclose:
- shard-snb: [INCOMPLETE][31] ([i915#1037]) -> [PASS][32]
[31]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9337/shard-snb6/igt@core_hotunplug@hotrebind-lateclose.html
[32]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18913/shard-snb4/igt@core_hotunplug@hotrebind-lateclose.html
* igt@core_hotunplug@unbind-rebind:
- shard-skl: [DMESG-WARN][33] ([i915#1982]) -> [PASS][34] +6 similar issues
[33]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9337/shard-skl2/igt@core_hotunplug@unbind-rebind.html
[34]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18913/shard-skl1/igt@core_hotunplug@unbind-rebind.html
* igt@gem_blits@basic:
- shard-skl: [TIMEOUT][35] ([i915#2502]) -> [PASS][36]
[35]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9337/shard-skl4/igt@gem_blits@basic.html
[36]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18913/shard-skl10/igt@gem_blits@basic.html
* igt@gem_partial_pwrite_pread@write:
- shard-hsw: [INCOMPLETE][37] -> [PASS][38]
[37]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9337/shard-hsw6/igt@gem_partial_pwrite_pread@write.html
[38]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18913/shard-hsw2/igt@gem_partial_pwrite_pread@write.html
* igt@i915_module_load@reload-with-fault-injection:
- shard-iclb: [DMESG-WARN][39] ([i915#1982]) -> [PASS][40]
[39]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9337/shard-iclb3/igt@i915_module_load@reload-with-fault-injection.html
[40]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18913/shard-iclb3/igt@i915_module_load@reload-with-fault-injection.html
* igt@kms_cursor_crc@pipe-b-cursor-64x21-sliding:
- shard-skl: [FAIL][41] ([i915#54]) -> [PASS][42] +6 similar issues
[41]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9337/shard-skl9/igt@kms_cursor_crc@pipe-b-cursor-64x21-sliding.html
[42]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18913/shard-skl3/igt@kms_cursor_crc@pipe-b-cursor-64x21-sliding.html
* igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions-varying-size:
- shard-skl: [FAIL][43] ([i915#2346]) -> [PASS][44]
[43]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9337/shard-skl1/igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions-varying-size.html
[44]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18913/shard-skl2/igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions-varying-size.html
* igt@kms_flip@flip-vs-expired-vblank-interruptible@a-dp1:
- shard-apl: [FAIL][45] ([i915#1635] / [i915#79]) -> [PASS][46]
[45]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9337/shard-apl4/igt@kms_flip@flip-vs-expired-vblank-interruptible@a-dp1.html
[46]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18913/shard-apl2/igt@kms_flip@flip-vs-expired-vblank-interruptible@a-dp1.html
* igt@kms_flip@plain-flip-ts-check-interruptible@a-edp1:
- shard-skl: [FAIL][47] ([i915#2122]) -> [PASS][48] +1 similar issue
[47]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9337/shard-skl4/igt@kms_flip@plain-flip-ts-check-interruptible@a-edp1.html
[48]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18913/shard-skl8/igt@kms_flip@plain-flip-ts-check-interruptible@a-edp1.html
* igt@kms_frontbuffer_tracking@basic:
- shard-apl: [DMESG-WARN][49] ([i915#1635] / [i915#1982]) -> [PASS][50] +2 similar issues
[49]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9337/shard-apl7/igt@kms_frontbuffer_tracking@basic.html
[50]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18913/shard-apl1/igt@kms_frontbuffer_tracking@basic.html
* igt@kms_frontbuffer_tracking@fbcpsr-1p-offscren-pri-shrfb-draw-pwrite:
- shard-tglb: [DMESG-WARN][51] ([i915#1982]) -> [PASS][52] +1 similar issue
[51]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9337/shard-tglb5/igt@kms_frontbuffer_tracking@fbcpsr-1p-offscren-pri-shrfb-draw-pwrite.html
[52]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18913/shard-tglb5/igt@kms_frontbuffer_tracking@fbcpsr-1p-offscren-pri-shrfb-draw-pwrite.html
* igt@kms_hdr@bpc-switch-suspend:
- shard-skl: [INCOMPLETE][53] ([i915#198]) -> [PASS][54]
[53]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9337/shard-skl8/igt@kms_hdr@bpc-switch-suspend.html
[54]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18913/shard-skl8/igt@kms_hdr@bpc-switch-suspend.html
* igt@kms_plane_alpha_blend@pipe-c-coverage-7efc:
- shard-skl: [FAIL][55] ([fdo#108145] / [i915#265]) -> [PASS][56] +1 similar issue
[55]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9337/shard-skl4/igt@kms_plane_alpha_blend@pipe-c-coverage-7efc.html
[56]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18913/shard-skl10/igt@kms_plane_alpha_blend@pipe-c-coverage-7efc.html
* igt@kms_psr@psr2_sprite_render:
- shard-iclb: [SKIP][57] ([fdo#109441]) -> [PASS][58]
[57]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9337/shard-iclb1/igt@kms_psr@psr2_sprite_render.html
[58]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18913/shard-iclb2/igt@kms_psr@psr2_sprite_render.html
* igt@perf_pmu@busy-check-all@rcs0:
- shard-snb: [FAIL][59] ([i915#2037]) -> [PASS][60]
[59]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9337/shard-snb2/igt@perf_pmu@busy-check-all@rcs0.html
[60]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18913/shard-snb7/igt@perf_pmu@busy-check-all@rcs0.html
* igt@perf_pmu@busy-check-all@vcs0:
- shard-snb: [FAIL][61] ([i915#1820]) -> [PASS][62] +1 similar issue
[61]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9337/shard-snb2/igt@perf_pmu@busy-check-all@vcs0.html
[62]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18913/shard-snb7/igt@perf_pmu@busy-check-all@vcs0.html
* igt@perf_pmu@module-unload:
- shard-apl: [DMESG-WARN][63] ([i915#1635] / [i915#1982] / [i915#262]) -> [PASS][64]
[63]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9337/shard-apl1/igt@perf_pmu@module-unload.html
[64]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18913/shard-apl6/igt@perf_pmu@module-unload.html
#### Warnings ####
* igt@kms_dp_dsc@basic-dsc-enable-edp:
- shard-iclb: [DMESG-WARN][65] ([i915#1226]) -> [SKIP][66] ([fdo#109349])
[65]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9337/shard-iclb2/igt@kms_dp_dsc@basic-dsc-enable-edp.html
[66]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18913/shard-iclb1/igt@kms_dp_dsc@basic-dsc-enable-edp.html
* igt@kms_pipe_crc_basic@suspend-read-crc-pipe-c:
- shard-tglb: [DMESG-WARN][67] ([i915#2411]) -> [INCOMPLETE][68] ([i915#1436] / [i915#1798] / [i915#1982] / [i915#456])
[67]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9337/shard-tglb7/igt@kms_pipe_crc_basic@suspend-read-crc-pipe-c.html
[68]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18913/shard-tglb8/igt@kms_pipe_crc_basic@suspend-read-crc-pipe-c.html
* igt@kms_psr@psr2_suspend:
- shard-tglb: [INCOMPLETE][69] ([i915#1436] / [i915#456]) -> [DMESG-WARN][70] ([i915#1436])
[69]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9337/shard-tglb7/igt@kms_psr@psr2_suspend.html
[70]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18913/shard-tglb6/igt@kms_psr@psr2_suspend.html
* igt@runner@aborted:
- shard-glk: ([FAIL][71], [FAIL][72]) ([i915#1611] / [i915#2263] / [i915#2295] / [i915#2439] / [i915#483] / [k.org#202321]) -> [FAIL][73] ([i915#1611] / [i915#2295] / [i915#2439] / [k.org#202321])
[71]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9337/shard-glk3/igt@runner@aborted.html
[72]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9337/shard-glk3/igt@runner@aborted.html
[73]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18913/shard-glk1/igt@runner@aborted.html
- shard-skl: [FAIL][74] ([i915#1611] / [i915#2295] / [i915#2439]) -> [FAIL][75] ([i915#1611] / [i915#2295] / [i915#2439] / [i915#483])
[74]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9337/shard-skl6/igt@runner@aborted.html
[75]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18913/shard-skl9/igt@runner@aborted.html
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[fdo#108145]: https://bugs.freedesktop.org/show_bug.cgi?id=108145
[fdo#109349]: https://bugs.freedesktop.org/show_bug.cgi?id=109349
[fdo#109441]: https://bugs.freedesktop.org/show_bug.cgi?id=109441
[i915#1037]: https://gitlab.freedesktop.org/drm/intel/issues/1037
[i915#118]: https://gitlab.freedesktop.org/drm/intel/issues/118
[i915#1226]: https://gitlab.freedesktop.org/drm/intel/issues/1226
[i915#1436]: https://gitlab.freedesktop.org/drm/intel/issues/1436
[i915#1611]: https://gitlab.freedesktop.org/drm/intel/issues/1611
[i915#1635]: https://gitlab.freedesktop.org/drm/intel/issues/1635
[i915#1798]: https://gitlab.freedesktop.org/drm/intel/issues/1798
[i915#180]: https://gitlab.freedesktop.org/drm/intel/issues/180
[i915#1820]: https://gitlab.freedesktop.org/drm/intel/issues/1820
[i915#198]: https://gitlab.freedesktop.org/drm/intel/issues/198
[i915#1982]: https://gitlab.freedesktop.org/drm/intel/issues/1982
[i915#2037]: https://gitlab.freedesktop.org/drm/intel/issues/2037
[i915#2122]: https://gitlab.freedesktop.org/drm/intel/issues/2122
[i915#2263]: https://gitlab.freedesktop.org/drm/intel/issues/2263
[i915#2295]: https://gitlab.freedesktop.org/drm/intel/issues/2295
[i915#2346]: https://gitlab.freedesktop.org/drm/intel/issues/2346
[i915#2411]: https://gitlab.freedesktop.org/drm/intel/issues/2411
[i915#2439]: https://gitlab.freedesktop.org/drm/intel/issues/2439
[i915#2502]: https://gitlab.freedesktop.org/drm/intel/issues/2502
[i915#2521]: https://gitlab.freedesktop.org/drm/intel/issues/2521
[i915#2546]: https://gitlab.freedesktop.org/drm/intel/issues/2546
[i915#262]: https://gitlab.freedesktop.org/drm/intel/issues/262
[i915#265]: https://gitlab.freedesktop.org/drm/intel/issues/265
[i915#456]: https://gitlab.freedesktop.org/drm/intel/issues/456
[i915#483]: https://gitlab.freedesktop.org/drm/intel/issues/483
[i915#54]: https://gitlab.freedesktop.org/drm/intel/issues/54
[i915#79]: https://gitlab.freedesktop.org/drm/intel/issues/79
[i915#95]: https://gitlab.freedesktop.org/drm/intel/issues/95
[k.org#202321]: https://bugzilla.kernel.org/show_bug.cgi?id=202321
Participating hosts (10 -> 10)
------------------------------
No changes in participating hosts
Build changes
-------------
* Linux: CI_DRM_9337 -> Patchwork_18913
CI-20190529: 20190529
CI_DRM_9337: 85c17640f343b06686aa677896856f2dc1388c21 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_5853: cbe997b92e4b96f8c29b5e2d49fb2ed88e1de3e2 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_18913: 61bc6a16e0c6b0ad9403620e943bee2cd302533b @ git://anongit.freedesktop.org/gfx-ci/linux
piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18913/index.html
[-- Attachment #1.2: Type: text/html, Size: 22565 bytes --]
[-- Attachment #2: Type: text/plain, Size: 160 bytes --]
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [Intel-gfx] [PATCH] drm/i915/lspcon: enter standby mode to enhance power saving
2020-11-16 13:59 [Intel-gfx] [PATCH] drm/i915/lspcon: enter standby mode to enhance power saving Lee Shawn C
2020-11-16 15:20 ` [Intel-gfx] ✓ Fi.CI.BAT: success for " Patchwork
2020-11-16 20:40 ` [Intel-gfx] ✗ Fi.CI.IGT: failure " Patchwork
@ 2020-11-17 16:29 ` Ville Syrjälä
2020-11-18 3:10 ` Lee, Shawn C
2020-11-18 3:30 ` [Intel-gfx] [PATCH v2] " Lee Shawn C
` (6 subsequent siblings)
9 siblings, 1 reply; 12+ messages in thread
From: Ville Syrjälä @ 2020-11-17 16:29 UTC (permalink / raw)
To: Lee Shawn C; +Cc: Cooper Chiou, intel-gfx
On Mon, Nov 16, 2020 at 09:59:13PM +0800, Lee Shawn C wrote:
> After system boot up, LSPCON will be configured as PCON mode.
> But it never go into power saving state. Source driver can
> do the following. Then LSPCON can enter standby mode
> automatically to save more power.
>
> 1. At PCON mode, source driver write 0x2 to DPCD 600h.
> 2. At LS mode, try to disable DP_DUAL_MODE_TMDS_OEN.
>
> Cc: Ville Syrjälä <ville.syrjala@linux.intel.com>
> Cc: Jani Nikula <jani.nikula@linux.intel.com>
> Cc: Uma Shankar <uma.shankar@intel.com>
> Cc: Cooper Chiou <cooper.chiou@intel.com>
> Cc: Khaled Almahallawy <khaled.almahallawy@intel.com>
> Signed-off-by: Lee Shawn C <shawn.c.lee@intel.com>
> ---
> drivers/gpu/drm/i915/display/intel_dp.c | 7 ++++++-
> drivers/gpu/drm/i915/display/intel_lspcon.c | 8 ++++++++
> drivers/gpu/drm/i915/display/intel_lspcon.h | 1 +
> 3 files changed, 15 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/i915/display/intel_dp.c b/drivers/gpu/drm/i915/display/intel_dp.c
> index ec8359f03aaf..7dd16d6bd5ba 100644
> --- a/drivers/gpu/drm/i915/display/intel_dp.c
> +++ b/drivers/gpu/drm/i915/display/intel_dp.c
> @@ -6536,6 +6536,7 @@ intel_dp_detect(struct drm_connector *connector,
> struct drm_i915_private *dev_priv = to_i915(connector->dev);
> struct intel_dp *intel_dp = intel_attached_dp(to_intel_connector(connector));
> struct intel_digital_port *dig_port = dp_to_dig_port(intel_dp);
> + struct intel_lspcon *lspcon = dp_to_lspcon(intel_dp);
> struct intel_encoder *encoder = &dig_port->base;
> enum drm_connector_status status;
>
> @@ -6632,9 +6633,13 @@ intel_dp_detect(struct drm_connector *connector,
> intel_dp_check_service_irq(intel_dp);
>
> out:
> - if (status != connector_status_connected && !intel_dp->is_mst)
> + if (status != connector_status_connected && !intel_dp->is_mst) {
> intel_dp_unset_edid(intel_dp);
>
> + if (lspcon && lspcon->active)
> + lspcon_standby(dp_to_dig_port(intel_dp));
We should proably just do this for all DP devices. But I'm not sure if
we can just do it uncoditionally like this. We should perhaps first check
that the connector is not in use. So doing this sort of stuff as part
of the normal init/resume sanitization process might be the better option.
> + }
> +
> /*
> * Make sure the refs for power wells enabled during detect are
> * dropped to avoid a new detect cycle triggered by HPD polling.
> diff --git a/drivers/gpu/drm/i915/display/intel_lspcon.c b/drivers/gpu/drm/i915/display/intel_lspcon.c
> index e37d45e531df..4913ff20d7b4 100644
> --- a/drivers/gpu/drm/i915/display/intel_lspcon.c
> +++ b/drivers/gpu/drm/i915/display/intel_lspcon.c
> @@ -550,6 +550,14 @@ static bool lspcon_init(struct intel_digital_port *dig_port)
> return true;
> }
>
> +void lspcon_standby(struct intel_digital_port *dig_port)
> +{
> + struct intel_dp *dp = &dig_port->dp;
> +
> + if (drm_dp_dpcd_writeb(&dp->aux, DP_SET_POWER, DP_SET_POWER_D3) <= 0)
> + DRM_DEBUG_KMS("Failed to write EDID checksum\n");
Eh?
> +}
> +
> void lspcon_resume(struct intel_digital_port *dig_port)
> {
> struct intel_lspcon *lspcon = &dig_port->lspcon;
> diff --git a/drivers/gpu/drm/i915/display/intel_lspcon.h b/drivers/gpu/drm/i915/display/intel_lspcon.h
> index b03dcb7076d8..658a2e5b22db 100644
> --- a/drivers/gpu/drm/i915/display/intel_lspcon.h
> +++ b/drivers/gpu/drm/i915/display/intel_lspcon.h
> @@ -16,6 +16,7 @@ struct intel_encoder;
> struct intel_lspcon;
>
> void lspcon_resume(struct intel_digital_port *dig_port);
> +void lspcon_standby(struct intel_digital_port *dig_port);
> void lspcon_wait_pcon_mode(struct intel_lspcon *lspcon);
> void lspcon_write_infoframe(struct intel_encoder *encoder,
> const struct intel_crtc_state *crtc_state,
> --
> 2.17.1
--
Ville Syrjälä
Intel
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [Intel-gfx] [PATCH] drm/i915/lspcon: enter standby mode to enhance power saving
2020-11-17 16:29 ` [Intel-gfx] [PATCH] " Ville Syrjälä
@ 2020-11-18 3:10 ` Lee, Shawn C
0 siblings, 0 replies; 12+ messages in thread
From: Lee, Shawn C @ 2020-11-18 3:10 UTC (permalink / raw)
To: intel-gfx, Ville Syrjälä; +Cc: Chiou, Cooper
On Tue, Nov. 17, 2020, 4:29 p.m., Ville Syrjälä wrote:
>On Mon, Nov 16, 2020 at 09:59:13PM +0800, Lee Shawn C wrote:
>> After system boot up, LSPCON will be configured as PCON mode.
>> But it never go into power saving state. Source driver can do the
>> following. Then LSPCON can enter standby mode automatically to save
>> more power.
>>
>> 1. At PCON mode, source driver write 0x2 to DPCD 600h.
>> 2. At LS mode, try to disable DP_DUAL_MODE_TMDS_OEN.
>>
>> Cc: Ville Syrjälä <ville.syrjala@linux.intel.com>
>> Cc: Jani Nikula <jani.nikula@linux.intel.com>
>> Cc: Uma Shankar <uma.shankar@intel.com>
>> Cc: Cooper Chiou <cooper.chiou@intel.com>
>> Cc: Khaled Almahallawy <khaled.almahallawy@intel.com>
>> Signed-off-by: Lee Shawn C <shawn.c.lee@intel.com>
>> ---
>> drivers/gpu/drm/i915/display/intel_dp.c | 7 ++++++-
>> drivers/gpu/drm/i915/display/intel_lspcon.c | 8 ++++++++
>> drivers/gpu/drm/i915/display/intel_lspcon.h | 1 +
>> 3 files changed, 15 insertions(+), 1 deletion(-)
>>
>> diff --git a/drivers/gpu/drm/i915/display/intel_dp.c
>> b/drivers/gpu/drm/i915/display/intel_dp.c
>> index ec8359f03aaf..7dd16d6bd5ba 100644
>> --- a/drivers/gpu/drm/i915/display/intel_dp.c
>> +++ b/drivers/gpu/drm/i915/display/intel_dp.c
>> @@ -6536,6 +6536,7 @@ intel_dp_detect(struct drm_connector *connector,
>> struct drm_i915_private *dev_priv = to_i915(connector->dev);
>> struct intel_dp *intel_dp = intel_attached_dp(to_intel_connector(connector));
>> struct intel_digital_port *dig_port = dp_to_dig_port(intel_dp);
>> + struct intel_lspcon *lspcon = dp_to_lspcon(intel_dp);
>> struct intel_encoder *encoder = &dig_port->base;
>> enum drm_connector_status status;
>>
>> @@ -6632,9 +6633,13 @@ intel_dp_detect(struct drm_connector *connector,
>> intel_dp_check_service_irq(intel_dp);
>>
>> out:
>> - if (status != connector_status_connected && !intel_dp->is_mst)
>> + if (status != connector_status_connected && !intel_dp->is_mst) {
>> intel_dp_unset_edid(intel_dp);
>>
>> + if (lspcon && lspcon->active)
>> + lspcon_standby(dp_to_dig_port(intel_dp));
>
>We should proably just do this for all DP devices. But I'm not sure if we can just do it uncoditionally like this. We should perhaps first check that the connector is not in use. So doing this sort of stuff as part of the normal init/resume sanitization process might be the better option.
>
Source driver already set sink power state to D3 in intel_ddi_post_disable_dp().
We learned from LSPCON vendor that configure power state to D3 must be the latest AUX command.
Any aux communication after that, LSPCON will be wake up until source set it to D3 next time.
Some user space application (ex: chrome os) used IOCTL to monitor external display's connection.
intel_dp_detect() will be called and try to read sink's info via AUX. In this case, LSPCON will
be active again. If we found there is LSPCON on this port and no more sink connected.
Source driver set power state to D3 here to make LSPCON enter standby mode.
>> + }
>> +
>> /*
>> * Make sure the refs for power wells enabled during detect are
>> * dropped to avoid a new detect cycle triggered by HPD polling.
>> diff --git a/drivers/gpu/drm/i915/display/intel_lspcon.c
>> b/drivers/gpu/drm/i915/display/intel_lspcon.c
>> index e37d45e531df..4913ff20d7b4 100644
>> --- a/drivers/gpu/drm/i915/display/intel_lspcon.c
>> +++ b/drivers/gpu/drm/i915/display/intel_lspcon.c
>> @@ -550,6 +550,14 @@ static bool lspcon_init(struct intel_digital_port *dig_port)
>> return true;
>> }
>>
>> +void lspcon_standby(struct intel_digital_port *dig_port) {
>> + struct intel_dp *dp = &dig_port->dp;
>> +
>> + if (drm_dp_dpcd_writeb(&dp->aux, DP_SET_POWER, DP_SET_POWER_D3) <= 0)
>> + DRM_DEBUG_KMS("Failed to write EDID checksum\n");
>
>Eh?
>
Sorry I miss to modify the error messages here. I will fix it later.
>> +}
>> +
>> void lspcon_resume(struct intel_digital_port *dig_port) {
>> struct intel_lspcon *lspcon = &dig_port->lspcon; diff --git
>> a/drivers/gpu/drm/i915/display/intel_lspcon.h
>> b/drivers/gpu/drm/i915/display/intel_lspcon.h
>> index b03dcb7076d8..658a2e5b22db 100644
>> --- a/drivers/gpu/drm/i915/display/intel_lspcon.h
>> +++ b/drivers/gpu/drm/i915/display/intel_lspcon.h
>> @@ -16,6 +16,7 @@ struct intel_encoder; struct intel_lspcon;
>>
>> void lspcon_resume(struct intel_digital_port *dig_port);
>> +void lspcon_standby(struct intel_digital_port *dig_port);
>> void lspcon_wait_pcon_mode(struct intel_lspcon *lspcon); void
>> lspcon_write_infoframe(struct intel_encoder *encoder,
>> const struct intel_crtc_state *crtc_state,
>> --
>> 2.17.1
>
>--
>Ville Syrjälä
>Intel
>
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 12+ messages in thread
* [Intel-gfx] [PATCH v2] drm/i915/lspcon: enter standby mode to enhance power saving
2020-11-16 13:59 [Intel-gfx] [PATCH] drm/i915/lspcon: enter standby mode to enhance power saving Lee Shawn C
` (2 preceding siblings ...)
2020-11-17 16:29 ` [Intel-gfx] [PATCH] " Ville Syrjälä
@ 2020-11-18 3:30 ` Lee Shawn C
2020-11-18 4:27 ` [Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/lspcon: enter standby mode to enhance power saving (rev2) Patchwork
` (5 subsequent siblings)
9 siblings, 0 replies; 12+ messages in thread
From: Lee Shawn C @ 2020-11-18 3:30 UTC (permalink / raw)
To: intel-gfx; +Cc: Cooper Chiou
After system boot up, LSPCON will be configured as PCON mode.
But it never go into power saving state. Source driver can
do the following. Then LSPCON can enter standby mode
automatically to save more power.
1. At PCON mode, source driver write 0x2 to DPCD 600h.
2. At LS mode, try to disable DP_DUAL_MODE_TMDS_OEN.
v2: fix typo
Cc: Ville Syrjälä <ville.syrjala@linux.intel.com>
Cc: Jani Nikula <jani.nikula@linux.intel.com>
Cc: Uma Shankar <uma.shankar@intel.com>
Cc: Cooper Chiou <cooper.chiou@intel.com>
Cc: Khaled Almahallawy <khaled.almahallawy@intel.com>
Signed-off-by: Lee Shawn C <shawn.c.lee@intel.com>
---
drivers/gpu/drm/i915/display/intel_dp.c | 7 ++++++-
drivers/gpu/drm/i915/display/intel_lspcon.c | 8 ++++++++
drivers/gpu/drm/i915/display/intel_lspcon.h | 1 +
3 files changed, 15 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/i915/display/intel_dp.c b/drivers/gpu/drm/i915/display/intel_dp.c
index ec8359f03aaf..7dd16d6bd5ba 100644
--- a/drivers/gpu/drm/i915/display/intel_dp.c
+++ b/drivers/gpu/drm/i915/display/intel_dp.c
@@ -6536,6 +6536,7 @@ intel_dp_detect(struct drm_connector *connector,
struct drm_i915_private *dev_priv = to_i915(connector->dev);
struct intel_dp *intel_dp = intel_attached_dp(to_intel_connector(connector));
struct intel_digital_port *dig_port = dp_to_dig_port(intel_dp);
+ struct intel_lspcon *lspcon = dp_to_lspcon(intel_dp);
struct intel_encoder *encoder = &dig_port->base;
enum drm_connector_status status;
@@ -6632,9 +6633,13 @@ intel_dp_detect(struct drm_connector *connector,
intel_dp_check_service_irq(intel_dp);
out:
- if (status != connector_status_connected && !intel_dp->is_mst)
+ if (status != connector_status_connected && !intel_dp->is_mst) {
intel_dp_unset_edid(intel_dp);
+ if (lspcon && lspcon->active)
+ lspcon_standby(dp_to_dig_port(intel_dp));
+ }
+
/*
* Make sure the refs for power wells enabled during detect are
* dropped to avoid a new detect cycle triggered by HPD polling.
diff --git a/drivers/gpu/drm/i915/display/intel_lspcon.c b/drivers/gpu/drm/i915/display/intel_lspcon.c
index e37d45e531df..d9bc052d3bde 100644
--- a/drivers/gpu/drm/i915/display/intel_lspcon.c
+++ b/drivers/gpu/drm/i915/display/intel_lspcon.c
@@ -550,6 +550,14 @@ static bool lspcon_init(struct intel_digital_port *dig_port)
return true;
}
+void lspcon_standby(struct intel_digital_port *dig_port)
+{
+ struct intel_dp *dp = &dig_port->dp;
+
+ if (drm_dp_dpcd_writeb(&dp->aux, DP_SET_POWER, DP_SET_POWER_D3) <= 0)
+ DRM_DEBUG_KMS("LSPCON failed to write power state to D3\n");
+}
+
void lspcon_resume(struct intel_digital_port *dig_port)
{
struct intel_lspcon *lspcon = &dig_port->lspcon;
diff --git a/drivers/gpu/drm/i915/display/intel_lspcon.h b/drivers/gpu/drm/i915/display/intel_lspcon.h
index b03dcb7076d8..658a2e5b22db 100644
--- a/drivers/gpu/drm/i915/display/intel_lspcon.h
+++ b/drivers/gpu/drm/i915/display/intel_lspcon.h
@@ -16,6 +16,7 @@ struct intel_encoder;
struct intel_lspcon;
void lspcon_resume(struct intel_digital_port *dig_port);
+void lspcon_standby(struct intel_digital_port *dig_port);
void lspcon_wait_pcon_mode(struct intel_lspcon *lspcon);
void lspcon_write_infoframe(struct intel_encoder *encoder,
const struct intel_crtc_state *crtc_state,
--
2.17.1
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply related [flat|nested] 12+ messages in thread
* [Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/lspcon: enter standby mode to enhance power saving (rev2)
2020-11-16 13:59 [Intel-gfx] [PATCH] drm/i915/lspcon: enter standby mode to enhance power saving Lee Shawn C
` (3 preceding siblings ...)
2020-11-18 3:30 ` [Intel-gfx] [PATCH v2] " Lee Shawn C
@ 2020-11-18 4:27 ` Patchwork
2020-11-18 11:51 ` [Intel-gfx] ✗ Fi.CI.IGT: failure " Patchwork
` (4 subsequent siblings)
9 siblings, 0 replies; 12+ messages in thread
From: Patchwork @ 2020-11-18 4:27 UTC (permalink / raw)
To: Lee Shawn C; +Cc: intel-gfx
[-- Attachment #1.1: Type: text/plain, Size: 5736 bytes --]
== Series Details ==
Series: drm/i915/lspcon: enter standby mode to enhance power saving (rev2)
URL : https://patchwork.freedesktop.org/series/83886/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_9350 -> Patchwork_18931
====================================================
Summary
-------
**SUCCESS**
No regressions found.
External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18931/index.html
New tests
---------
New tests have been introduced between CI_DRM_9350 and Patchwork_18931:
### New CI tests (1) ###
* boot:
- Statuses : 41 pass(s)
- Exec time: [0.0] s
Known issues
------------
Here are the changes found in Patchwork_18931 that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@i915_module_load@reload:
- fi-tgl-u2: [PASS][1] -> [DMESG-WARN][2] ([i915#1982] / [k.org#205379])
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9350/fi-tgl-u2/igt@i915_module_load@reload.html
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18931/fi-tgl-u2/igt@i915_module_load@reload.html
* igt@i915_pm_rpm@basic-pci-d3-state:
- fi-apl-guc: [PASS][3] -> [DMESG-WARN][4] ([i915#1635] / [i915#1982])
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9350/fi-apl-guc/igt@i915_pm_rpm@basic-pci-d3-state.html
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18931/fi-apl-guc/igt@i915_pm_rpm@basic-pci-d3-state.html
* igt@i915_selftest@live@execlists:
- fi-skl-6600u: [PASS][5] -> [INCOMPLETE][6] ([CI#80] / [i915#1037])
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9350/fi-skl-6600u/igt@i915_selftest@live@execlists.html
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18931/fi-skl-6600u/igt@i915_selftest@live@execlists.html
* igt@kms_cursor_legacy@basic-flip-after-cursor-atomic:
- fi-icl-u2: [PASS][7] -> [DMESG-WARN][8] ([i915#1982])
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9350/fi-icl-u2/igt@kms_cursor_legacy@basic-flip-after-cursor-atomic.html
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18931/fi-icl-u2/igt@kms_cursor_legacy@basic-flip-after-cursor-atomic.html
* igt@prime_vgem@basic-fence-flip:
- fi-tgl-y: [PASS][9] -> [DMESG-WARN][10] ([i915#402]) +1 similar issue
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9350/fi-tgl-y/igt@prime_vgem@basic-fence-flip.html
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18931/fi-tgl-y/igt@prime_vgem@basic-fence-flip.html
#### Possible fixes ####
* igt@kms_chamelium@dp-crc-fast:
- fi-cml-u2: [DMESG-WARN][11] ([i915#1982]) -> [PASS][12]
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9350/fi-cml-u2/igt@kms_chamelium@dp-crc-fast.html
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18931/fi-cml-u2/igt@kms_chamelium@dp-crc-fast.html
* igt@kms_cursor_legacy@basic-busy-flip-before-cursor-atomic:
- fi-byt-j1900: [DMESG-WARN][13] ([i915#1982]) -> [PASS][14]
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9350/fi-byt-j1900/igt@kms_cursor_legacy@basic-busy-flip-before-cursor-atomic.html
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18931/fi-byt-j1900/igt@kms_cursor_legacy@basic-busy-flip-before-cursor-atomic.html
- fi-bsw-kefka: [DMESG-WARN][15] ([i915#1982]) -> [PASS][16]
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9350/fi-bsw-kefka/igt@kms_cursor_legacy@basic-busy-flip-before-cursor-atomic.html
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18931/fi-bsw-kefka/igt@kms_cursor_legacy@basic-busy-flip-before-cursor-atomic.html
* igt@kms_pipe_crc_basic@read-crc-pipe-c:
- fi-tgl-y: [DMESG-WARN][17] ([i915#1982]) -> [PASS][18] +1 similar issue
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9350/fi-tgl-y/igt@kms_pipe_crc_basic@read-crc-pipe-c.html
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18931/fi-tgl-y/igt@kms_pipe_crc_basic@read-crc-pipe-c.html
* igt@vgem_basic@setversion:
- fi-tgl-y: [DMESG-WARN][19] ([i915#402]) -> [PASS][20] +2 similar issues
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9350/fi-tgl-y/igt@vgem_basic@setversion.html
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18931/fi-tgl-y/igt@vgem_basic@setversion.html
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[CI#80]: https://gitlab.freedesktop.org/gfx-ci/i915-infra/issues/80
[i915#1037]: https://gitlab.freedesktop.org/drm/intel/issues/1037
[i915#1635]: https://gitlab.freedesktop.org/drm/intel/issues/1635
[i915#1982]: https://gitlab.freedesktop.org/drm/intel/issues/1982
[i915#2411]: https://gitlab.freedesktop.org/drm/intel/issues/2411
[i915#402]: https://gitlab.freedesktop.org/drm/intel/issues/402
[k.org#205379]: https://bugzilla.kernel.org/show_bug.cgi?id=205379
Participating hosts (45 -> 41)
------------------------------
Missing (4): fi-ilk-m540 fi-bsw-cyan fi-bdw-samus fi-hsw-4200u
Build changes
-------------
* Linux: CI_DRM_9350 -> Patchwork_18931
CI-20190529: 20190529
CI_DRM_9350: 3161d1b26b7e1a7cb9146e3f8bd613f901ff5b38 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_5855: d9b3c7058efe41e5224dd1e43fac05dc6d049380 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_18931: 9d5e0d57c51ef9defbd54de063107ad7b1330f50 @ git://anongit.freedesktop.org/gfx-ci/linux
== Linux commits ==
9d5e0d57c51e drm/i915/lspcon: enter standby mode to enhance power saving
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18931/index.html
[-- Attachment #1.2: Type: text/html, Size: 7016 bytes --]
[-- Attachment #2: Type: text/plain, Size: 160 bytes --]
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 12+ messages in thread
* [Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915/lspcon: enter standby mode to enhance power saving (rev2)
2020-11-16 13:59 [Intel-gfx] [PATCH] drm/i915/lspcon: enter standby mode to enhance power saving Lee Shawn C
` (4 preceding siblings ...)
2020-11-18 4:27 ` [Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/lspcon: enter standby mode to enhance power saving (rev2) Patchwork
@ 2020-11-18 11:51 ` Patchwork
2020-11-18 13:21 ` [Intel-gfx] [PATCH v3] drm/i915/lspcon: enter standby mode to enhance power saving Lee Shawn C
` (3 subsequent siblings)
9 siblings, 0 replies; 12+ messages in thread
From: Patchwork @ 2020-11-18 11:51 UTC (permalink / raw)
To: Lee Shawn C; +Cc: intel-gfx
[-- Attachment #1.1: Type: text/plain, Size: 21774 bytes --]
== Series Details ==
Series: drm/i915/lspcon: enter standby mode to enhance power saving (rev2)
URL : https://patchwork.freedesktop.org/series/83886/
State : failure
== Summary ==
CI Bug Log - changes from CI_DRM_9350_full -> Patchwork_18931_full
====================================================
Summary
-------
**FAILURE**
Serious unknown changes coming with Patchwork_18931_full absolutely need to be
verified manually.
If you think the reported changes have nothing to do with the changes
introduced in Patchwork_18931_full, please notify your bug team to allow them
to document this new failure mode, which will reduce false positives in CI.
Possible new issues
-------------------
Here are the unknown changes that may have been introduced in Patchwork_18931_full:
### IGT changes ###
#### Possible regressions ####
* igt@gem_caching@read-writes:
- shard-hsw: [PASS][1] -> [FAIL][2] +1 similar issue
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9350/shard-hsw2/igt@gem_caching@read-writes.html
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18931/shard-hsw5/igt@gem_caching@read-writes.html
* igt@gem_exec_schedule@manyslice@rcs0:
- shard-skl: [PASS][3] -> [INCOMPLETE][4]
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9350/shard-skl1/igt@gem_exec_schedule@manyslice@rcs0.html
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18931/shard-skl8/igt@gem_exec_schedule@manyslice@rcs0.html
New tests
---------
New tests have been introduced between CI_DRM_9350_full and Patchwork_18931_full:
### New CI tests (1) ###
* boot:
- Statuses : 200 pass(s)
- Exec time: [0.0] s
Known issues
------------
Here are the changes found in Patchwork_18931_full that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@gem_exec_suspend@basic-s3:
- shard-hsw: [PASS][5] -> [FAIL][6] ([i915#1888])
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9350/shard-hsw2/igt@gem_exec_suspend@basic-s3.html
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18931/shard-hsw5/igt@gem_exec_suspend@basic-s3.html
* igt@gem_workarounds@suspend-resume:
- shard-apl: [PASS][7] -> [INCOMPLETE][8] ([i915#1635])
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9350/shard-apl3/igt@gem_workarounds@suspend-resume.html
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18931/shard-apl3/igt@gem_workarounds@suspend-resume.html
* igt@kms_cursor_crc@pipe-c-cursor-128x42-random:
- shard-skl: [PASS][9] -> [FAIL][10] ([i915#54]) +1 similar issue
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9350/shard-skl5/igt@kms_cursor_crc@pipe-c-cursor-128x42-random.html
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18931/shard-skl5/igt@kms_cursor_crc@pipe-c-cursor-128x42-random.html
* igt@kms_cursor_crc@pipe-c-cursor-suspend:
- shard-skl: [PASS][11] -> [INCOMPLETE][12] ([i915#300])
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9350/shard-skl1/igt@kms_cursor_crc@pipe-c-cursor-suspend.html
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18931/shard-skl1/igt@kms_cursor_crc@pipe-c-cursor-suspend.html
* igt@kms_cursor_legacy@cursor-vs-flip-atomic-transitions:
- shard-skl: [PASS][13] -> [DMESG-WARN][14] ([i915#1982] / [i915#2295])
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9350/shard-skl7/igt@kms_cursor_legacy@cursor-vs-flip-atomic-transitions.html
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18931/shard-skl1/igt@kms_cursor_legacy@cursor-vs-flip-atomic-transitions.html
* igt@kms_cursor_legacy@flip-vs-cursor-legacy:
- shard-tglb: [PASS][15] -> [FAIL][16] ([i915#2346])
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9350/shard-tglb5/igt@kms_cursor_legacy@flip-vs-cursor-legacy.html
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18931/shard-tglb7/igt@kms_cursor_legacy@flip-vs-cursor-legacy.html
* igt@kms_draw_crc@draw-method-rgb565-pwrite-untiled:
- shard-skl: [PASS][17] -> [DMESG-WARN][18] ([i915#1982]) +4 similar issues
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9350/shard-skl7/igt@kms_draw_crc@draw-method-rgb565-pwrite-untiled.html
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18931/shard-skl2/igt@kms_draw_crc@draw-method-rgb565-pwrite-untiled.html
* igt@kms_flip@2x-plain-flip-ts-check-interruptible@ab-vga1-hdmi-a1:
- shard-hsw: [PASS][19] -> [DMESG-WARN][20] ([i915#1982])
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9350/shard-hsw7/igt@kms_flip@2x-plain-flip-ts-check-interruptible@ab-vga1-hdmi-a1.html
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18931/shard-hsw1/igt@kms_flip@2x-plain-flip-ts-check-interruptible@ab-vga1-hdmi-a1.html
* igt@kms_flip@flip-vs-blocking-wf-vblank@c-edp1:
- shard-skl: [PASS][21] -> [FAIL][22] ([i915#2122])
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9350/shard-skl2/igt@kms_flip@flip-vs-blocking-wf-vblank@c-edp1.html
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18931/shard-skl6/igt@kms_flip@flip-vs-blocking-wf-vblank@c-edp1.html
* igt@kms_flip@flip-vs-expired-vblank@a-edp1:
- shard-skl: [PASS][23] -> [FAIL][24] ([i915#79])
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9350/shard-skl10/igt@kms_flip@flip-vs-expired-vblank@a-edp1.html
[24]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18931/shard-skl5/igt@kms_flip@flip-vs-expired-vblank@a-edp1.html
* igt@kms_frontbuffer_tracking@fbc-1p-pri-indfb-multidraw:
- shard-apl: [PASS][25] -> [DMESG-WARN][26] ([i915#1635] / [i915#1982]) +4 similar issues
[25]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9350/shard-apl8/igt@kms_frontbuffer_tracking@fbc-1p-pri-indfb-multidraw.html
[26]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18931/shard-apl3/igt@kms_frontbuffer_tracking@fbc-1p-pri-indfb-multidraw.html
- shard-glk: [PASS][27] -> [DMESG-WARN][28] ([i915#1982]) +2 similar issues
[27]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9350/shard-glk5/igt@kms_frontbuffer_tracking@fbc-1p-pri-indfb-multidraw.html
[28]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18931/shard-glk1/igt@kms_frontbuffer_tracking@fbc-1p-pri-indfb-multidraw.html
- shard-tglb: [PASS][29] -> [DMESG-WARN][30] ([i915#1982]) +1 similar issue
[29]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9350/shard-tglb6/igt@kms_frontbuffer_tracking@fbc-1p-pri-indfb-multidraw.html
[30]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18931/shard-tglb6/igt@kms_frontbuffer_tracking@fbc-1p-pri-indfb-multidraw.html
* igt@kms_frontbuffer_tracking@fbc-shrfb-scaledprimary:
- shard-kbl: [PASS][31] -> [DMESG-WARN][32] ([i915#1982]) +3 similar issues
[31]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9350/shard-kbl6/igt@kms_frontbuffer_tracking@fbc-shrfb-scaledprimary.html
[32]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18931/shard-kbl7/igt@kms_frontbuffer_tracking@fbc-shrfb-scaledprimary.html
* igt@kms_frontbuffer_tracking@psr-1p-primscrn-pri-shrfb-draw-pwrite:
- shard-skl: [PASS][33] -> [FAIL][34] ([i915#49])
[33]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9350/shard-skl1/igt@kms_frontbuffer_tracking@psr-1p-primscrn-pri-shrfb-draw-pwrite.html
[34]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18931/shard-skl3/igt@kms_frontbuffer_tracking@psr-1p-primscrn-pri-shrfb-draw-pwrite.html
* igt@kms_hdr@bpc-switch-suspend:
- shard-skl: [PASS][35] -> [FAIL][36] ([i915#1188])
[35]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9350/shard-skl9/igt@kms_hdr@bpc-switch-suspend.html
[36]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18931/shard-skl7/igt@kms_hdr@bpc-switch-suspend.html
* igt@kms_plane@plane-position-covered-pipe-b-planes:
- shard-skl: [PASS][37] -> [FAIL][38] ([i915#247])
[37]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9350/shard-skl9/igt@kms_plane@plane-position-covered-pipe-b-planes.html
[38]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18931/shard-skl7/igt@kms_plane@plane-position-covered-pipe-b-planes.html
* igt@kms_psr2_su@frontbuffer:
- shard-iclb: [PASS][39] -> [SKIP][40] ([fdo#109642] / [fdo#111068])
[39]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9350/shard-iclb2/igt@kms_psr2_su@frontbuffer.html
[40]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18931/shard-iclb8/igt@kms_psr2_su@frontbuffer.html
* igt@kms_psr@psr2_cursor_render:
- shard-iclb: [PASS][41] -> [SKIP][42] ([fdo#109441])
[41]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9350/shard-iclb2/igt@kms_psr@psr2_cursor_render.html
[42]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18931/shard-iclb7/igt@kms_psr@psr2_cursor_render.html
* igt@kms_vblank@pipe-b-accuracy-idle:
- shard-glk: [PASS][43] -> [FAIL][44] ([i915#43])
[43]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9350/shard-glk2/igt@kms_vblank@pipe-b-accuracy-idle.html
[44]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18931/shard-glk3/igt@kms_vblank@pipe-b-accuracy-idle.html
* igt@perf_pmu@module-unload:
- shard-iclb: [PASS][45] -> [DMESG-WARN][46] ([i915#1982] / [i915#262])
[45]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9350/shard-iclb7/igt@perf_pmu@module-unload.html
[46]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18931/shard-iclb7/igt@perf_pmu@module-unload.html
#### Possible fixes ####
* igt@gem_exec_reloc@basic-many-active@rcs0:
- shard-glk: [FAIL][47] ([i915#2389]) -> [PASS][48]
[47]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9350/shard-glk3/igt@gem_exec_reloc@basic-many-active@rcs0.html
[48]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18931/shard-glk9/igt@gem_exec_reloc@basic-many-active@rcs0.html
* igt@gem_exec_suspend@basic-s3:
- shard-glk: [FAIL][49] -> [PASS][50] +1 similar issue
[49]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9350/shard-glk6/igt@gem_exec_suspend@basic-s3.html
[50]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18931/shard-glk5/igt@gem_exec_suspend@basic-s3.html
- shard-kbl: [DMESG-WARN][51] ([i915#180]) -> [PASS][52]
[51]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9350/shard-kbl2/igt@gem_exec_suspend@basic-s3.html
[52]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18931/shard-kbl2/igt@gem_exec_suspend@basic-s3.html
* igt@i915_pm_rpm@i2c:
- shard-skl: [DMESG-WARN][53] ([i915#1982]) -> [PASS][54] +2 similar issues
[53]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9350/shard-skl9/igt@i915_pm_rpm@i2c.html
[54]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18931/shard-skl7/igt@i915_pm_rpm@i2c.html
* igt@i915_pm_rpm@modeset-non-lpsp-stress-no-wait:
- shard-glk: [DMESG-WARN][55] ([i915#1982]) -> [PASS][56]
[55]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9350/shard-glk1/igt@i915_pm_rpm@modeset-non-lpsp-stress-no-wait.html
[56]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18931/shard-glk7/igt@i915_pm_rpm@modeset-non-lpsp-stress-no-wait.html
* igt@kms_big_fb@y-tiled-64bpp-rotate-0:
- shard-kbl: [DMESG-WARN][57] ([i915#1982]) -> [PASS][58]
[57]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9350/shard-kbl1/igt@kms_big_fb@y-tiled-64bpp-rotate-0.html
[58]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18931/shard-kbl4/igt@kms_big_fb@y-tiled-64bpp-rotate-0.html
* igt@kms_cursor_crc@pipe-b-cursor-256x85-random:
- shard-skl: [FAIL][59] ([i915#54]) -> [PASS][60] +2 similar issues
[59]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9350/shard-skl4/igt@kms_cursor_crc@pipe-b-cursor-256x85-random.html
[60]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18931/shard-skl10/igt@kms_cursor_crc@pipe-b-cursor-256x85-random.html
* igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions-varying-size:
- shard-skl: [FAIL][61] ([i915#2346]) -> [PASS][62]
[61]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9350/shard-skl6/igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions-varying-size.html
[62]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18931/shard-skl4/igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions-varying-size.html
* igt@kms_cursor_legacy@short-flip-after-cursor-atomic-transitions:
- shard-snb: [FAIL][63] -> [PASS][64]
[63]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9350/shard-snb6/igt@kms_cursor_legacy@short-flip-after-cursor-atomic-transitions.html
[64]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18931/shard-snb6/igt@kms_cursor_legacy@short-flip-after-cursor-atomic-transitions.html
* igt@kms_draw_crc@draw-method-xrgb2101010-mmap-gtt-ytiled:
- shard-apl: [DMESG-WARN][65] ([i915#1635] / [i915#1982]) -> [PASS][66] +3 similar issues
[65]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9350/shard-apl6/igt@kms_draw_crc@draw-method-xrgb2101010-mmap-gtt-ytiled.html
[66]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18931/shard-apl2/igt@kms_draw_crc@draw-method-xrgb2101010-mmap-gtt-ytiled.html
* igt@kms_flip@dpms-off-confusion@a-vga1:
- shard-hsw: [DMESG-WARN][67] ([i915#1982]) -> [PASS][68] +1 similar issue
[67]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9350/shard-hsw6/igt@kms_flip@dpms-off-confusion@a-vga1.html
[68]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18931/shard-hsw8/igt@kms_flip@dpms-off-confusion@a-vga1.html
* igt@kms_frontbuffer_tracking@fbc-badstride:
- shard-iclb: [DMESG-WARN][69] ([i915#1982]) -> [PASS][70] +1 similar issue
[69]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9350/shard-iclb3/igt@kms_frontbuffer_tracking@fbc-badstride.html
[70]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18931/shard-iclb4/igt@kms_frontbuffer_tracking@fbc-badstride.html
* igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-shrfb-plflip-blt:
- shard-tglb: [DMESG-WARN][71] ([i915#1982]) -> [PASS][72] +2 similar issues
[71]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9350/shard-tglb5/igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-shrfb-plflip-blt.html
[72]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18931/shard-tglb7/igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-shrfb-plflip-blt.html
* igt@kms_hdr@bpc-switch-dpms:
- shard-skl: [FAIL][73] ([i915#1188]) -> [PASS][74]
[73]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9350/shard-skl9/igt@kms_hdr@bpc-switch-dpms.html
[74]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18931/shard-skl7/igt@kms_hdr@bpc-switch-dpms.html
* igt@kms_plane_alpha_blend@pipe-b-coverage-7efc:
- shard-skl: [FAIL][75] ([fdo#108145] / [i915#265]) -> [PASS][76]
[75]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9350/shard-skl10/igt@kms_plane_alpha_blend@pipe-b-coverage-7efc.html
[76]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18931/shard-skl1/igt@kms_plane_alpha_blend@pipe-b-coverage-7efc.html
* igt@kms_psr@psr2_sprite_blt:
- shard-iclb: [SKIP][77] ([fdo#109441]) -> [PASS][78] +2 similar issues
[77]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9350/shard-iclb1/igt@kms_psr@psr2_sprite_blt.html
[78]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18931/shard-iclb2/igt@kms_psr@psr2_sprite_blt.html
* igt@perf_pmu@module-unload:
- shard-skl: [DMESG-WARN][79] ([i915#1982] / [i915#262]) -> [PASS][80]
[79]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9350/shard-skl10/igt@perf_pmu@module-unload.html
[80]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18931/shard-skl1/igt@perf_pmu@module-unload.html
#### Warnings ####
* igt@gem_softpin@noreloc-s3:
- shard-tglb: [DMESG-WARN][81] ([i915#1436]) -> [INCOMPLETE][82] ([i915#1373] / [i915#1436] / [i915#456])
[81]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9350/shard-tglb7/igt@gem_softpin@noreloc-s3.html
[82]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18931/shard-tglb3/igt@gem_softpin@noreloc-s3.html
* igt@kms_dp_dsc@basic-dsc-enable-edp:
- shard-iclb: [DMESG-WARN][83] ([i915#1226]) -> [SKIP][84] ([fdo#109349])
[83]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9350/shard-iclb2/igt@kms_dp_dsc@basic-dsc-enable-edp.html
[84]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18931/shard-iclb7/igt@kms_dp_dsc@basic-dsc-enable-edp.html
* igt@runner@aborted:
- shard-hsw: [FAIL][85] ([i915#2295] / [i915#2439] / [i915#483]) -> [FAIL][86] ([i915#2295] / [i915#2439])
[85]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9350/shard-hsw1/igt@runner@aborted.html
[86]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18931/shard-hsw7/igt@runner@aborted.html
- shard-iclb: ([FAIL][87], [FAIL][88]) ([i915#2295] / [i915#2439] / [i915#483]) -> ([FAIL][89], [FAIL][90]) ([i915#2295] / [i915#2439])
[87]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9350/shard-iclb5/igt@runner@aborted.html
[88]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9350/shard-iclb4/igt@runner@aborted.html
[89]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18931/shard-iclb2/igt@runner@aborted.html
[90]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18931/shard-iclb3/igt@runner@aborted.html
- shard-glk: ([FAIL][91], [FAIL][92]) ([i915#1611] / [i915#2295] / [i915#2439] / [i915#86] / [k.org#202321]) -> ([FAIL][93], [FAIL][94]) ([i915#1611] / [i915#2295] / [i915#2439] / [i915#483] / [i915#86] / [k.org#202321])
[91]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9350/shard-glk2/igt@runner@aborted.html
[92]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9350/shard-glk6/igt@runner@aborted.html
[93]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18931/shard-glk3/igt@runner@aborted.html
[94]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18931/shard-glk6/igt@runner@aborted.html
- shard-skl: [FAIL][95] ([i915#1611] / [i915#2295] / [i915#2439]) -> ([FAIL][96], [FAIL][97]) ([i915#1611] / [i915#1909] / [i915#2295] / [i915#2439])
[95]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9350/shard-skl6/igt@runner@aborted.html
[96]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18931/shard-skl8/igt@runner@aborted.html
[97]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18931/shard-skl8/igt@runner@aborted.html
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[fdo#108145]: https://bugs.freedesktop.org/show_bug.cgi?id=108145
[fdo#109349]: https://bugs.freedesktop.org/show_bug.cgi?id=109349
[fdo#109441]: https://bugs.freedesktop.org/show_bug.cgi?id=109441
[fdo#109642]: https://bugs.freedesktop.org/show_bug.cgi?id=109642
[fdo#111068]: https://bugs.freedesktop.org/show_bug.cgi?id=111068
[i915#1188]: https://gitlab.freedesktop.org/drm/intel/issues/1188
[i915#1226]: https://gitlab.freedesktop.org/drm/intel/issues/1226
[i915#1373]: https://gitlab.freedesktop.org/drm/intel/issues/1373
[i915#1436]: https://gitlab.freedesktop.org/drm/intel/issues/1436
[i915#1611]: https://gitlab.freedesktop.org/drm/intel/issues/1611
[i915#1635]: https://gitlab.freedesktop.org/drm/intel/issues/1635
[i915#180]: https://gitlab.freedesktop.org/drm/intel/issues/180
[i915#1888]: https://gitlab.freedesktop.org/drm/intel/issues/1888
[i915#1909]: https://gitlab.freedesktop.org/drm/intel/issues/1909
[i915#1982]: https://gitlab.freedesktop.org/drm/intel/issues/1982
[i915#2122]: https://gitlab.freedesktop.org/drm/intel/issues/2122
[i915#2295]: https://gitlab.freedesktop.org/drm/intel/issues/2295
[i915#2346]: https://gitlab.freedesktop.org/drm/intel/issues/2346
[i915#2389]: https://gitlab.freedesktop.org/drm/intel/issues/2389
[i915#2439]: https://gitlab.freedesktop.org/drm/intel/issues/2439
[i915#247]: https://gitlab.freedesktop.org/drm/intel/issues/247
[i915#2521]: https://gitlab.freedesktop.org/drm/intel/issues/2521
[i915#262]: https://gitlab.freedesktop.org/drm/intel/issues/262
[i915#265]: https://gitlab.freedesktop.org/drm/intel/issues/265
[i915#300]: https://gitlab.freedesktop.org/drm/intel/issues/300
[i915#43]: https://gitlab.freedesktop.org/drm/intel/issues/43
[i915#456]: https://gitlab.freedesktop.org/drm/intel/issues/456
[i915#483]: https://gitlab.freedesktop.org/drm/intel/issues/483
[i915#49]: https://gitlab.freedesktop.org/drm/intel/issues/49
[i915#54]: https://gitlab.freedesktop.org/drm/intel/issues/54
[i915#79]: https://gitlab.freedesktop.org/drm/intel/issues/79
[i915#86]: https://gitlab.freedesktop.org/drm/intel/issues/86
[k.org#202321]: https://bugzilla.kernel.org/show_bug.cgi?id=202321
Participating hosts (10 -> 10)
------------------------------
No changes in participating hosts
Build changes
-------------
* Linux: CI_DRM_9350 -> Patchwork_18931
CI-20190529: 20190529
CI_DRM_9350: 3161d1b26b7e1a7cb9146e3f8bd613f901ff5b38 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_5855: d9b3c7058efe41e5224dd1e43fac05dc6d049380 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_18931: 9d5e0d57c51ef9defbd54de063107ad7b1330f50 @ git://anongit.freedesktop.org/gfx-ci/linux
piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18931/index.html
[-- Attachment #1.2: Type: text/html, Size: 26741 bytes --]
[-- Attachment #2: Type: text/plain, Size: 160 bytes --]
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 12+ messages in thread
* [Intel-gfx] [PATCH v3] drm/i915/lspcon: enter standby mode to enhance power saving
2020-11-16 13:59 [Intel-gfx] [PATCH] drm/i915/lspcon: enter standby mode to enhance power saving Lee Shawn C
` (5 preceding siblings ...)
2020-11-18 11:51 ` [Intel-gfx] ✗ Fi.CI.IGT: failure " Patchwork
@ 2020-11-18 13:21 ` Lee Shawn C
2020-11-18 14:26 ` [Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915/lspcon: enter standby mode to enhance power saving (rev3) Patchwork
` (2 subsequent siblings)
9 siblings, 0 replies; 12+ messages in thread
From: Lee Shawn C @ 2020-11-18 13:21 UTC (permalink / raw)
To: intel-gfx; +Cc: Cooper Chiou
After system boot up, LSPCON will be configured as PCON mode.
But it never go into power saving state. Source driver can
do the following. Then LSPCON can enter standby mode
automatically to save more power.
1. At PCON mode, source driver write 0x2 to DPCD 600h.
2. At LS mode, try to disable DP_DUAL_MODE_TMDS_OEN.
v2: fix typo
v3: After turn main lin off, found particular monitor
trigger HPD to LSPCON. Then short HPD would forward
to source. If driver did not enable display output
when received this HPD. Source should request LSPCON to
enter standby mode again.
Cc: Ville Syrjälä <ville.syrjala@linux.intel.com>
Cc: Jani Nikula <jani.nikula@linux.intel.com>
Cc: Uma Shankar <uma.shankar@intel.com>
Cc: Cooper Chiou <cooper.chiou@intel.com>
Cc: Khaled Almahallawy <khaled.almahallawy@intel.com>
Signed-off-by: Lee Shawn C <shawn.c.lee@intel.com>
---
drivers/gpu/drm/i915/display/intel_dp.c | 11 +++++++-
drivers/gpu/drm/i915/display/intel_lspcon.c | 30 +++++++++++++++++++++
drivers/gpu/drm/i915/display/intel_lspcon.h | 1 +
3 files changed, 41 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/i915/display/intel_dp.c b/drivers/gpu/drm/i915/display/intel_dp.c
index ec8359f03aaf..7876d785b50f 100644
--- a/drivers/gpu/drm/i915/display/intel_dp.c
+++ b/drivers/gpu/drm/i915/display/intel_dp.c
@@ -6184,6 +6184,7 @@ static bool
intel_dp_short_pulse(struct intel_dp *intel_dp)
{
struct drm_i915_private *dev_priv = dp_to_i915(intel_dp);
+ struct intel_lspcon *lspcon = dp_to_lspcon(intel_dp);
u8 old_sink_count = intel_dp->sink_count;
bool ret;
@@ -6211,6 +6212,9 @@ intel_dp_short_pulse(struct intel_dp *intel_dp)
/* Handle CEC interrupts, if any */
drm_dp_cec_irq(&intel_dp->aux);
+ if (lspcon && lspcon->active)
+ lspcon_standby(dp_to_dig_port(intel_dp));
+
/* defer to the hotplug work for link retraining if needed */
if (intel_dp_needs_link_retrain(intel_dp))
return false;
@@ -6536,6 +6540,7 @@ intel_dp_detect(struct drm_connector *connector,
struct drm_i915_private *dev_priv = to_i915(connector->dev);
struct intel_dp *intel_dp = intel_attached_dp(to_intel_connector(connector));
struct intel_digital_port *dig_port = dp_to_dig_port(intel_dp);
+ struct intel_lspcon *lspcon = dp_to_lspcon(intel_dp);
struct intel_encoder *encoder = &dig_port->base;
enum drm_connector_status status;
@@ -6632,9 +6637,13 @@ intel_dp_detect(struct drm_connector *connector,
intel_dp_check_service_irq(intel_dp);
out:
- if (status != connector_status_connected && !intel_dp->is_mst)
+ if (status != connector_status_connected && !intel_dp->is_mst) {
intel_dp_unset_edid(intel_dp);
+ if (lspcon && lspcon->active)
+ lspcon_standby(dp_to_dig_port(intel_dp));
+ }
+
/*
* Make sure the refs for power wells enabled during detect are
* dropped to avoid a new detect cycle triggered by HPD polling.
diff --git a/drivers/gpu/drm/i915/display/intel_lspcon.c b/drivers/gpu/drm/i915/display/intel_lspcon.c
index e37d45e531df..700f5604d9f6 100644
--- a/drivers/gpu/drm/i915/display/intel_lspcon.c
+++ b/drivers/gpu/drm/i915/display/intel_lspcon.c
@@ -550,6 +550,36 @@ static bool lspcon_init(struct intel_digital_port *dig_port)
return true;
}
+void lspcon_standby(struct intel_digital_port *dig_port)
+{
+ struct intel_dp *dp = &dig_port->dp;
+ u8 align_status = 0xff, training_pattern = 0xff;
+
+ if (drm_dp_dpcd_readb(&dp->aux, DP_LANE_ALIGN_STATUS_UPDATED, &align_status) <= 0) {
+ DRM_ERROR("LSPCON failed to read align status\n");
+ return;
+ }
+
+ if (drm_dp_dpcd_readb(&dp->aux, DP_TRAINING_PATTERN_SET, &training_pattern) <= 0) {
+ DRM_ERROR("LSPCON failed to read training pattern set\n");
+ return;
+ }
+
+ /*
+ * If link trainig is ongoing. Or sink updated link align status.
+ * Source driver should not set LSPCON power state to D3.
+ */
+ if (align_status || training_pattern) {
+ DRM_DEBUG_KMS("LSPCON link training or display is working\n");
+ DRM_DEBUG_KMS("LSPCON DPCD register 0102h = %x, 0204h = 0x%x\n",
+ training_pattern, align_status);
+ return;
+ }
+
+ if (drm_dp_dpcd_writeb(&dp->aux, DP_SET_POWER, DP_SET_POWER_D3) <= 0)
+ DRM_DEBUG_KMS("LSPCON failed to write power state to D3\n");
+}
+
void lspcon_resume(struct intel_digital_port *dig_port)
{
struct intel_lspcon *lspcon = &dig_port->lspcon;
diff --git a/drivers/gpu/drm/i915/display/intel_lspcon.h b/drivers/gpu/drm/i915/display/intel_lspcon.h
index b03dcb7076d8..658a2e5b22db 100644
--- a/drivers/gpu/drm/i915/display/intel_lspcon.h
+++ b/drivers/gpu/drm/i915/display/intel_lspcon.h
@@ -16,6 +16,7 @@ struct intel_encoder;
struct intel_lspcon;
void lspcon_resume(struct intel_digital_port *dig_port);
+void lspcon_standby(struct intel_digital_port *dig_port);
void lspcon_wait_pcon_mode(struct intel_lspcon *lspcon);
void lspcon_write_infoframe(struct intel_encoder *encoder,
const struct intel_crtc_state *crtc_state,
--
2.17.1
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply related [flat|nested] 12+ messages in thread
* [Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915/lspcon: enter standby mode to enhance power saving (rev3)
2020-11-16 13:59 [Intel-gfx] [PATCH] drm/i915/lspcon: enter standby mode to enhance power saving Lee Shawn C
` (6 preceding siblings ...)
2020-11-18 13:21 ` [Intel-gfx] [PATCH v3] drm/i915/lspcon: enter standby mode to enhance power saving Lee Shawn C
@ 2020-11-18 14:26 ` Patchwork
2020-11-19 7:29 ` [Intel-gfx] [PATCH v4] drm/i915/lspcon: enter standby mode to enhance power saving Lee Shawn C
2020-11-19 13:30 ` [Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915/lspcon: enter standby mode to enhance power saving (rev4) Patchwork
9 siblings, 0 replies; 12+ messages in thread
From: Patchwork @ 2020-11-18 14:26 UTC (permalink / raw)
To: Lee Shawn C; +Cc: intel-gfx
[-- Attachment #1.1: Type: text/plain, Size: 5203 bytes --]
== Series Details ==
Series: drm/i915/lspcon: enter standby mode to enhance power saving (rev3)
URL : https://patchwork.freedesktop.org/series/83886/
State : failure
== Summary ==
CI Bug Log - changes from CI_DRM_9351 -> Patchwork_18934
====================================================
Summary
-------
**FAILURE**
Serious unknown changes coming with Patchwork_18934 absolutely need to be
verified manually.
If you think the reported changes have nothing to do with the changes
introduced in Patchwork_18934, please notify your bug team to allow them
to document this new failure mode, which will reduce false positives in CI.
External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18934/index.html
Possible new issues
-------------------
Here are the unknown changes that may have been introduced in Patchwork_18934:
### IGT changes ###
#### Possible regressions ####
* igt@kms_chamelium@common-hpd-after-suspend:
- fi-kbl-7500u: [PASS][1] -> [DMESG-WARN][2]
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9351/fi-kbl-7500u/igt@kms_chamelium@common-hpd-after-suspend.html
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18934/fi-kbl-7500u/igt@kms_chamelium@common-hpd-after-suspend.html
New tests
---------
New tests have been introduced between CI_DRM_9351 and Patchwork_18934:
### New CI tests (1) ###
* boot:
- Statuses : 38 pass(s)
- Exec time: [0.0] s
Known issues
------------
Here are the changes found in Patchwork_18934 that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@kms_chamelium@hdmi-hpd-fast:
- fi-kbl-7500u: [PASS][3] -> [FAIL][4] ([i915#227])
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9351/fi-kbl-7500u/igt@kms_chamelium@hdmi-hpd-fast.html
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18934/fi-kbl-7500u/igt@kms_chamelium@hdmi-hpd-fast.html
* igt@kms_cursor_legacy@basic-busy-flip-before-cursor-atomic:
- fi-byt-j1900: [PASS][5] -> [DMESG-WARN][6] ([i915#1982])
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9351/fi-byt-j1900/igt@kms_cursor_legacy@basic-busy-flip-before-cursor-atomic.html
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18934/fi-byt-j1900/igt@kms_cursor_legacy@basic-busy-flip-before-cursor-atomic.html
* igt@kms_flip@basic-flip-vs-wf_vblank@b-dp1:
- fi-skl-lmem: [PASS][7] -> [FAIL][8] ([i915#2122])
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9351/fi-skl-lmem/igt@kms_flip@basic-flip-vs-wf_vblank@b-dp1.html
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18934/fi-skl-lmem/igt@kms_flip@basic-flip-vs-wf_vblank@b-dp1.html
#### Possible fixes ####
* igt@i915_selftest@live@gt_heartbeat:
- fi-kbl-soraka: [INCOMPLETE][9] -> [PASS][10]
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9351/fi-kbl-soraka/igt@i915_selftest@live@gt_heartbeat.html
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18934/fi-kbl-soraka/igt@i915_selftest@live@gt_heartbeat.html
* igt@kms_chamelium@dp-crc-fast:
- fi-kbl-7500u: [FAIL][11] ([i915#1161] / [i915#262]) -> [PASS][12]
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9351/fi-kbl-7500u/igt@kms_chamelium@dp-crc-fast.html
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18934/fi-kbl-7500u/igt@kms_chamelium@dp-crc-fast.html
* igt@kms_cursor_legacy@basic-flip-before-cursor-atomic:
- fi-icl-u2: [DMESG-WARN][13] ([i915#1982]) -> [PASS][14] +2 similar issues
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9351/fi-icl-u2/igt@kms_cursor_legacy@basic-flip-before-cursor-atomic.html
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18934/fi-icl-u2/igt@kms_cursor_legacy@basic-flip-before-cursor-atomic.html
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[i915#1161]: https://gitlab.freedesktop.org/drm/intel/issues/1161
[i915#1982]: https://gitlab.freedesktop.org/drm/intel/issues/1982
[i915#2122]: https://gitlab.freedesktop.org/drm/intel/issues/2122
[i915#227]: https://gitlab.freedesktop.org/drm/intel/issues/227
[i915#2411]: https://gitlab.freedesktop.org/drm/intel/issues/2411
[i915#262]: https://gitlab.freedesktop.org/drm/intel/issues/262
Participating hosts (41 -> 38)
------------------------------
Additional (3): fi-hsw-4770 fi-blb-e6850 fi-tgl-u2
Missing (6): fi-ilk-m540 fi-hsw-4200u fi-bsw-cyan fi-ctg-p8600 fi-tgl-y fi-bdw-samus
Build changes
-------------
* Linux: CI_DRM_9351 -> Patchwork_18934
CI-20190529: 20190529
CI_DRM_9351: b676373b31de969a7296a8eaecc8ceab600dd655 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_5856: d9b09131eaeed3f3bf5b68d8b5f18516b1659b1d @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_18934: c7319b1722f19aabfed7cc24ebb5de9e4ca9d875 @ git://anongit.freedesktop.org/gfx-ci/linux
== Linux commits ==
c7319b1722f1 drm/i915/lspcon: enter standby mode to enhance power saving
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18934/index.html
[-- Attachment #1.2: Type: text/html, Size: 6034 bytes --]
[-- Attachment #2: Type: text/plain, Size: 160 bytes --]
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 12+ messages in thread
* [Intel-gfx] [PATCH v4] drm/i915/lspcon: enter standby mode to enhance power saving
2020-11-16 13:59 [Intel-gfx] [PATCH] drm/i915/lspcon: enter standby mode to enhance power saving Lee Shawn C
` (7 preceding siblings ...)
2020-11-18 14:26 ` [Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915/lspcon: enter standby mode to enhance power saving (rev3) Patchwork
@ 2020-11-19 7:29 ` Lee Shawn C
2020-11-19 13:30 ` [Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915/lspcon: enter standby mode to enhance power saving (rev4) Patchwork
9 siblings, 0 replies; 12+ messages in thread
From: Lee Shawn C @ 2020-11-19 7:29 UTC (permalink / raw)
To: intel-gfx; +Cc: Cooper Chiou
After system boot up, LSPCON will be configured as PCON mode.
But it never go into power saving state. Source driver can
do the following. Then LSPCON can enter standby mode
automatically to save more power.
1. At PCON mode, source driver write 0x2 to DPCD 600h.
2. At LS mode, try to disable DP_DUAL_MODE_TMDS_OEN.
v2: fix typo
v3: Found particular monitor trigger HPD to LSPCON
after main link stopped. If driver did not enable
display output. Source should request LSPCON to
enter standby mode again.
v4: Before enter D3, make sure display output is not
active. And source/sink are not doing link training.
Cc: Ville Syrjälä <ville.syrjala@linux.intel.com>
Cc: Jani Nikula <jani.nikula@linux.intel.com>
Cc: Uma Shankar <uma.shankar@intel.com>
Cc: Cooper Chiou <cooper.chiou@intel.com>
Cc: Khaled Almahallawy <khaled.almahallawy@intel.com>
Signed-off-by: Lee Shawn C <shawn.c.lee@intel.com>
---
drivers/gpu/drm/i915/display/intel_dp.c | 13 ++++++-
drivers/gpu/drm/i915/display/intel_lspcon.c | 38 +++++++++++++++++++++
drivers/gpu/drm/i915/display/intel_lspcon.h | 1 +
3 files changed, 51 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/i915/display/intel_dp.c b/drivers/gpu/drm/i915/display/intel_dp.c
index ec8359f03aaf..d2567dc3bc5e 100644
--- a/drivers/gpu/drm/i915/display/intel_dp.c
+++ b/drivers/gpu/drm/i915/display/intel_dp.c
@@ -6184,6 +6184,7 @@ static bool
intel_dp_short_pulse(struct intel_dp *intel_dp)
{
struct drm_i915_private *dev_priv = dp_to_i915(intel_dp);
+ struct intel_lspcon *lspcon = dp_to_lspcon(intel_dp);
u8 old_sink_count = intel_dp->sink_count;
bool ret;
@@ -6211,6 +6212,11 @@ intel_dp_short_pulse(struct intel_dp *intel_dp)
/* Handle CEC interrupts, if any */
drm_dp_cec_irq(&intel_dp->aux);
+ /* If LSPCON connected, try to set lspcon power state to D3 */
+ if (lspcon && lspcon->active)
+ lspcon_standby(dp_to_dig_port(intel_dp),
+ intel_digital_port_connected(&dp_to_dig_port(intel_dp)->base));
+
/* defer to the hotplug work for link retraining if needed */
if (intel_dp_needs_link_retrain(intel_dp))
return false;
@@ -6536,6 +6542,7 @@ intel_dp_detect(struct drm_connector *connector,
struct drm_i915_private *dev_priv = to_i915(connector->dev);
struct intel_dp *intel_dp = intel_attached_dp(to_intel_connector(connector));
struct intel_digital_port *dig_port = dp_to_dig_port(intel_dp);
+ struct intel_lspcon *lspcon = dp_to_lspcon(intel_dp);
struct intel_encoder *encoder = &dig_port->base;
enum drm_connector_status status;
@@ -6632,9 +6639,13 @@ intel_dp_detect(struct drm_connector *connector,
intel_dp_check_service_irq(intel_dp);
out:
- if (status != connector_status_connected && !intel_dp->is_mst)
+ if (status != connector_status_connected && !intel_dp->is_mst) {
intel_dp_unset_edid(intel_dp);
+ if (lspcon && lspcon->active)
+ lspcon_standby(dp_to_dig_port(intel_dp), false);
+ }
+
/*
* Make sure the refs for power wells enabled during detect are
* dropped to avoid a new detect cycle triggered by HPD polling.
diff --git a/drivers/gpu/drm/i915/display/intel_lspcon.c b/drivers/gpu/drm/i915/display/intel_lspcon.c
index e37d45e531df..99eb67272552 100644
--- a/drivers/gpu/drm/i915/display/intel_lspcon.c
+++ b/drivers/gpu/drm/i915/display/intel_lspcon.c
@@ -550,6 +550,44 @@ static bool lspcon_init(struct intel_digital_port *dig_port)
return true;
}
+void lspcon_standby(struct intel_digital_port *dig_port, bool connected)
+{
+ struct intel_dp *dp = &dig_port->dp;
+ u8 align_status = 0, training_pattern = 0, i;
+
+ if (connected) {
+ for (i = 0; i < 3; i++) {
+ usleep_range(10000, 11000);
+
+ if (drm_dp_dpcd_readb(&dp->aux, DP_LANE_ALIGN_STATUS_UPDATED,
+ &align_status) <= 0) {
+ DRM_DEBUG_KMS("LSPCON failed to read align status\n");
+ return;
+ }
+
+ if (drm_dp_dpcd_readb(&dp->aux, DP_TRAINING_PATTERN_SET,
+ &training_pattern) <= 0) {
+ DRM_DEBUG_KMS("LSPCON failed to read training pattern set\n");
+ return;
+ }
+
+ /*
+ * If link trainig is ongoing. Or sink updated link align status.
+ * Source driver should not set lspcon power state to D3.
+ */
+ if (align_status || training_pattern) {
+ DRM_DEBUG_KMS("LSPCON link training or display is working\n");
+ DRM_DEBUG_KMS("LSPCON DPCD register 0102h = %x, 0204h = 0x%x\n",
+ training_pattern, align_status);
+ return;
+ }
+ }
+ }
+
+ if (drm_dp_dpcd_writeb(&dp->aux, DP_SET_POWER, DP_SET_POWER_D3) <= 0)
+ DRM_DEBUG_KMS("LSPCON failed to write power state to D3\n");
+}
+
void lspcon_resume(struct intel_digital_port *dig_port)
{
struct intel_lspcon *lspcon = &dig_port->lspcon;
diff --git a/drivers/gpu/drm/i915/display/intel_lspcon.h b/drivers/gpu/drm/i915/display/intel_lspcon.h
index b03dcb7076d8..eef0e69bff32 100644
--- a/drivers/gpu/drm/i915/display/intel_lspcon.h
+++ b/drivers/gpu/drm/i915/display/intel_lspcon.h
@@ -16,6 +16,7 @@ struct intel_encoder;
struct intel_lspcon;
void lspcon_resume(struct intel_digital_port *dig_port);
+void lspcon_standby(struct intel_digital_port *dig_port, bool connected);
void lspcon_wait_pcon_mode(struct intel_lspcon *lspcon);
void lspcon_write_infoframe(struct intel_encoder *encoder,
const struct intel_crtc_state *crtc_state,
--
2.17.1
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply related [flat|nested] 12+ messages in thread
* [Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915/lspcon: enter standby mode to enhance power saving (rev4)
2020-11-16 13:59 [Intel-gfx] [PATCH] drm/i915/lspcon: enter standby mode to enhance power saving Lee Shawn C
` (8 preceding siblings ...)
2020-11-19 7:29 ` [Intel-gfx] [PATCH v4] drm/i915/lspcon: enter standby mode to enhance power saving Lee Shawn C
@ 2020-11-19 13:30 ` Patchwork
9 siblings, 0 replies; 12+ messages in thread
From: Patchwork @ 2020-11-19 13:30 UTC (permalink / raw)
To: Lee Shawn C; +Cc: intel-gfx
[-- Attachment #1.1: Type: text/plain, Size: 8221 bytes --]
== Series Details ==
Series: drm/i915/lspcon: enter standby mode to enhance power saving (rev4)
URL : https://patchwork.freedesktop.org/series/83886/
State : failure
== Summary ==
CI Bug Log - changes from CI_DRM_9360 -> Patchwork_18938
====================================================
Summary
-------
**FAILURE**
Serious unknown changes coming with Patchwork_18938 absolutely need to be
verified manually.
If you think the reported changes have nothing to do with the changes
introduced in Patchwork_18938, please notify your bug team to allow them
to document this new failure mode, which will reduce false positives in CI.
External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18938/index.html
Possible new issues
-------------------
Here are the unknown changes that may have been introduced in Patchwork_18938:
### IGT changes ###
#### Possible regressions ####
* igt@gem_exec_suspend@basic-s0:
- fi-glk-dsi: NOTRUN -> [INCOMPLETE][1]
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18938/fi-glk-dsi/igt@gem_exec_suspend@basic-s0.html
* igt@i915_selftest@live@hugepages:
- fi-cfl-8109u: NOTRUN -> [DMESG-FAIL][2]
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18938/fi-cfl-8109u/igt@i915_selftest@live@hugepages.html
New tests
---------
New tests have been introduced between CI_DRM_9360 and Patchwork_18938:
### New CI tests (1) ###
* boot:
- Statuses : 1 fail(s) 39 pass(s)
- Exec time: [0.0] s
Known issues
------------
Here are the changes found in Patchwork_18938 that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@i915_module_load@reload:
- fi-byt-j1900: [PASS][3] -> [DMESG-WARN][4] ([i915#1982])
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9360/fi-byt-j1900/igt@i915_module_load@reload.html
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18938/fi-byt-j1900/igt@i915_module_load@reload.html
- fi-bsw-n3050: [PASS][5] -> [DMESG-WARN][6] ([i915#1982])
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9360/fi-bsw-n3050/igt@i915_module_load@reload.html
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18938/fi-bsw-n3050/igt@i915_module_load@reload.html
* igt@i915_pm_rpm@basic-pci-d3-state:
- fi-kbl-7500u: [PASS][7] -> [SKIP][8] ([fdo#109271])
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9360/fi-kbl-7500u/igt@i915_pm_rpm@basic-pci-d3-state.html
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18938/fi-kbl-7500u/igt@i915_pm_rpm@basic-pci-d3-state.html
* igt@i915_selftest@live@gt_heartbeat:
- fi-kbl-soraka: [PASS][9] -> [DMESG-FAIL][10] ([i915#541])
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9360/fi-kbl-soraka/igt@i915_selftest@live@gt_heartbeat.html
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18938/fi-kbl-soraka/igt@i915_selftest@live@gt_heartbeat.html
- fi-tgl-y: [PASS][11] -> [DMESG-FAIL][12] ([i915#2601] / [i915#541])
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9360/fi-tgl-y/igt@i915_selftest@live@gt_heartbeat.html
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18938/fi-tgl-y/igt@i915_selftest@live@gt_heartbeat.html
* igt@kms_chamelium@dp-crc-fast:
- fi-cml-u2: [PASS][13] -> [DMESG-WARN][14] ([i915#1982])
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9360/fi-cml-u2/igt@kms_chamelium@dp-crc-fast.html
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18938/fi-cml-u2/igt@kms_chamelium@dp-crc-fast.html
* igt@kms_chamelium@hdmi-hpd-fast:
- fi-kbl-7500u: [PASS][15] -> [FAIL][16] ([i915#227])
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9360/fi-kbl-7500u/igt@kms_chamelium@hdmi-hpd-fast.html
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18938/fi-kbl-7500u/igt@kms_chamelium@hdmi-hpd-fast.html
* igt@kms_cursor_legacy@basic-busy-flip-before-cursor-atomic:
- fi-bsw-kefka: [PASS][17] -> [DMESG-WARN][18] ([i915#1982])
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9360/fi-bsw-kefka/igt@kms_cursor_legacy@basic-busy-flip-before-cursor-atomic.html
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18938/fi-bsw-kefka/igt@kms_cursor_legacy@basic-busy-flip-before-cursor-atomic.html
* igt@kms_cursor_legacy@basic-flip-before-cursor-legacy:
- fi-icl-u2: [PASS][19] -> [DMESG-WARN][20] ([i915#1982])
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9360/fi-icl-u2/igt@kms_cursor_legacy@basic-flip-before-cursor-legacy.html
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18938/fi-icl-u2/igt@kms_cursor_legacy@basic-flip-before-cursor-legacy.html
* igt@prime_self_import@basic-with_one_bo:
- fi-tgl-y: [PASS][21] -> [DMESG-WARN][22] ([i915#402]) +1 similar issue
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9360/fi-tgl-y/igt@prime_self_import@basic-with_one_bo.html
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18938/fi-tgl-y/igt@prime_self_import@basic-with_one_bo.html
#### Possible fixes ####
* igt@gem_ctx_exec@basic:
- fi-tgl-y: [DMESG-WARN][23] ([i915#1982]) -> [PASS][24]
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9360/fi-tgl-y/igt@gem_ctx_exec@basic.html
[24]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18938/fi-tgl-y/igt@gem_ctx_exec@basic.html
* igt@gem_flink_basic@double-flink:
- fi-tgl-y: [DMESG-WARN][25] ([i915#402]) -> [PASS][26] +2 similar issues
[25]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9360/fi-tgl-y/igt@gem_flink_basic@double-flink.html
[26]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18938/fi-tgl-y/igt@gem_flink_basic@double-flink.html
* igt@i915_pm_rpm@basic-pci-d3-state:
- fi-bsw-kefka: [DMESG-WARN][27] ([i915#1982]) -> [PASS][28]
[27]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9360/fi-bsw-kefka/igt@i915_pm_rpm@basic-pci-d3-state.html
[28]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18938/fi-bsw-kefka/igt@i915_pm_rpm@basic-pci-d3-state.html
* igt@kms_cursor_legacy@basic-flip-before-cursor-atomic:
- fi-icl-u2: [DMESG-WARN][29] ([i915#1982]) -> [PASS][30] +3 similar issues
[29]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9360/fi-icl-u2/igt@kms_cursor_legacy@basic-flip-before-cursor-atomic.html
[30]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18938/fi-icl-u2/igt@kms_cursor_legacy@basic-flip-before-cursor-atomic.html
#### Warnings ####
* igt@gem_exec_suspend@basic-s3:
- fi-tgl-y: [DMESG-WARN][31] ([i915#2411]) -> [DMESG-WARN][32] ([i915#2411] / [i915#402])
[31]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9360/fi-tgl-y/igt@gem_exec_suspend@basic-s3.html
[32]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18938/fi-tgl-y/igt@gem_exec_suspend@basic-s3.html
[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[i915#1982]: https://gitlab.freedesktop.org/drm/intel/issues/1982
[i915#227]: https://gitlab.freedesktop.org/drm/intel/issues/227
[i915#2411]: https://gitlab.freedesktop.org/drm/intel/issues/2411
[i915#2601]: https://gitlab.freedesktop.org/drm/intel/issues/2601
[i915#402]: https://gitlab.freedesktop.org/drm/intel/issues/402
[i915#541]: https://gitlab.freedesktop.org/drm/intel/issues/541
Participating hosts (40 -> 40)
------------------------------
Additional (4): fi-cfl-8109u fi-glk-dsi fi-cfl-8700k fi-cml-s
Missing (4): fi-ilk-m540 fi-bsw-cyan fi-bdw-samus fi-hsw-4200u
Build changes
-------------
* Linux: CI_DRM_9360 -> Patchwork_18938
CI-20190529: 20190529
CI_DRM_9360: 0422f113c6d1612d145fbca35db5329689bf0884 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_5858: 300ee395f5c0ed53ab0757d9c5b311f9c1f641c8 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_18938: bbe92e375cd1c003aed2e18263ffa4842d1ac721 @ git://anongit.freedesktop.org/gfx-ci/linux
== Linux commits ==
bbe92e375cd1 drm/i915/lspcon: enter standby mode to enhance power saving
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18938/index.html
[-- Attachment #1.2: Type: text/html, Size: 10027 bytes --]
[-- Attachment #2: Type: text/plain, Size: 160 bytes --]
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 12+ messages in thread
end of thread, other threads:[~2020-11-19 13:30 UTC | newest]
Thread overview: 12+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-11-16 13:59 [Intel-gfx] [PATCH] drm/i915/lspcon: enter standby mode to enhance power saving Lee Shawn C
2020-11-16 15:20 ` [Intel-gfx] ✓ Fi.CI.BAT: success for " Patchwork
2020-11-16 20:40 ` [Intel-gfx] ✗ Fi.CI.IGT: failure " Patchwork
2020-11-17 16:29 ` [Intel-gfx] [PATCH] " Ville Syrjälä
2020-11-18 3:10 ` Lee, Shawn C
2020-11-18 3:30 ` [Intel-gfx] [PATCH v2] " Lee Shawn C
2020-11-18 4:27 ` [Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/lspcon: enter standby mode to enhance power saving (rev2) Patchwork
2020-11-18 11:51 ` [Intel-gfx] ✗ Fi.CI.IGT: failure " Patchwork
2020-11-18 13:21 ` [Intel-gfx] [PATCH v3] drm/i915/lspcon: enter standby mode to enhance power saving Lee Shawn C
2020-11-18 14:26 ` [Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915/lspcon: enter standby mode to enhance power saving (rev3) Patchwork
2020-11-19 7:29 ` [Intel-gfx] [PATCH v4] drm/i915/lspcon: enter standby mode to enhance power saving Lee Shawn C
2020-11-19 13:30 ` [Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915/lspcon: enter standby mode to enhance power saving (rev4) Patchwork
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.