All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] io_uring: do not use pointer after free
@ 2020-11-13 15:41 Paolo Bonzini
  2020-11-16 12:03 ` [PATCH-for-5.2] " Philippe Mathieu-Daudé
  2020-11-16 14:50 ` [PATCH] " Kevin Wolf
  0 siblings, 2 replies; 3+ messages in thread
From: Paolo Bonzini @ 2020-11-13 15:41 UTC (permalink / raw)
  To: qemu-devel; +Cc: Stefan Hajnoczi, qemu-block

Even though only the pointer value is only printed, it is untidy
and Coverity complains.

Cc: Stefan Hajnoczi <stefanha@redhat.com>
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
---
 block/io_uring.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/block/io_uring.c b/block/io_uring.c
index 037af09471..00a3ee9fb8 100644
--- a/block/io_uring.c
+++ b/block/io_uring.c
@@ -425,6 +425,6 @@ LuringState *luring_init(Error **errp)
 void luring_cleanup(LuringState *s)
 {
     io_uring_queue_exit(&s->ring);
-    g_free(s);
     trace_luring_cleanup_state(s);
+    g_free(s);
 }
-- 
2.26.2



^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH-for-5.2] io_uring: do not use pointer after free
  2020-11-13 15:41 [PATCH] io_uring: do not use pointer after free Paolo Bonzini
@ 2020-11-16 12:03 ` Philippe Mathieu-Daudé
  2020-11-16 14:50 ` [PATCH] " Kevin Wolf
  1 sibling, 0 replies; 3+ messages in thread
From: Philippe Mathieu-Daudé @ 2020-11-16 12:03 UTC (permalink / raw)
  To: Paolo Bonzini, qemu-devel; +Cc: qemu-block, Stefan Hajnoczi

On 11/13/20 4:41 PM, Paolo Bonzini wrote:
> Even though only the pointer value is only printed, it is untidy
> and Coverity complains.
> 
> Cc: Stefan Hajnoczi <stefanha@redhat.com>
> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
> ---
>  block/io_uring.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>



^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] io_uring: do not use pointer after free
  2020-11-13 15:41 [PATCH] io_uring: do not use pointer after free Paolo Bonzini
  2020-11-16 12:03 ` [PATCH-for-5.2] " Philippe Mathieu-Daudé
@ 2020-11-16 14:50 ` Kevin Wolf
  1 sibling, 0 replies; 3+ messages in thread
From: Kevin Wolf @ 2020-11-16 14:50 UTC (permalink / raw)
  To: Paolo Bonzini; +Cc: qemu-block, qemu-devel, Stefan Hajnoczi

Am 13.11.2020 um 16:41 hat Paolo Bonzini geschrieben:
> Even though only the pointer value is only printed, it is untidy
> and Coverity complains.
> 
> Cc: Stefan Hajnoczi <stefanha@redhat.com>
> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>

Thanks, applied to the block branch.

Kevin



^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2020-11-16 14:52 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-11-13 15:41 [PATCH] io_uring: do not use pointer after free Paolo Bonzini
2020-11-16 12:03 ` [PATCH-for-5.2] " Philippe Mathieu-Daudé
2020-11-16 14:50 ` [PATCH] " Kevin Wolf

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.