All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] ARM64: tegra: Disable the ACONNECT for Jetson TX2
@ 2020-11-16 16:20 Jon Hunter
  2020-11-16 16:28 ` Thierry Reding
  0 siblings, 1 reply; 2+ messages in thread
From: Jon Hunter @ 2020-11-16 16:20 UTC (permalink / raw)
  To: Thierry Reding; +Cc: devicetree, linux-tegra, Sameer Pujar, Jon Hunter

Commit ff4c371d2bc0 ("arm64: defconfig: Build ADMA and ACONNECT driver")
enable the Tegra ADMA and ACONNECT drivers and this is causing resume
from system suspend to fail on Jetson TX2. Resume is failing because the
ACONNECT driver is being resumed before the BPMP driver, and the ACONNECT
driver is attempting to power on a power-domain that is provided by the
BPMP. While a proper fix for the resume sequencing problem is identified,
disable the ACONNECT for Jetson TX2 temporarily to avoid breaking system
suspend.

Please note that ACONNECT driver is used by the Audio Processing Engine
(APE) on Tegra, but because there is no mainline support for APE on
Jetson TX2 currently, disabling the ACONNECT does not disable any useful
feature at the moment.

Signed-off-by: Jon Hunter <jonathanh@nvidia.com>
---
 arch/arm64/boot/dts/nvidia/tegra186-p2771-0000.dts | 12 ------------
 1 file changed, 12 deletions(-)

diff --git a/arch/arm64/boot/dts/nvidia/tegra186-p2771-0000.dts b/arch/arm64/boot/dts/nvidia/tegra186-p2771-0000.dts
index 381a84912ba8..c28d51cc5797 100644
--- a/arch/arm64/boot/dts/nvidia/tegra186-p2771-0000.dts
+++ b/arch/arm64/boot/dts/nvidia/tegra186-p2771-0000.dts
@@ -10,18 +10,6 @@
 	model = "NVIDIA Jetson TX2 Developer Kit";
 	compatible = "nvidia,p2771-0000", "nvidia,tegra186";
 
-	aconnect {
-		status = "okay";
-
-		dma-controller@2930000 {
-			status = "okay";
-		};
-
-		interrupt-controller@2a40000 {
-			status = "okay";
-		};
-	};
-
 	i2c@3160000 {
 		power-monitor@42 {
 			compatible = "ti,ina3221";
-- 
2.17.1


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] ARM64: tegra: Disable the ACONNECT for Jetson TX2
  2020-11-16 16:20 [PATCH] ARM64: tegra: Disable the ACONNECT for Jetson TX2 Jon Hunter
@ 2020-11-16 16:28 ` Thierry Reding
  0 siblings, 0 replies; 2+ messages in thread
From: Thierry Reding @ 2020-11-16 16:28 UTC (permalink / raw)
  To: Jon Hunter; +Cc: devicetree, linux-tegra, Sameer Pujar

[-- Attachment #1: Type: text/plain, Size: 1058 bytes --]

On Mon, Nov 16, 2020 at 04:20:26PM +0000, Jon Hunter wrote:
> Commit ff4c371d2bc0 ("arm64: defconfig: Build ADMA and ACONNECT driver")
> enable the Tegra ADMA and ACONNECT drivers and this is causing resume
> from system suspend to fail on Jetson TX2. Resume is failing because the
> ACONNECT driver is being resumed before the BPMP driver, and the ACONNECT
> driver is attempting to power on a power-domain that is provided by the
> BPMP. While a proper fix for the resume sequencing problem is identified,
> disable the ACONNECT for Jetson TX2 temporarily to avoid breaking system
> suspend.
> 
> Please note that ACONNECT driver is used by the Audio Processing Engine
> (APE) on Tegra, but because there is no mainline support for APE on
> Jetson TX2 currently, disabling the ACONNECT does not disable any useful
> feature at the moment.
> 
> Signed-off-by: Jon Hunter <jonathanh@nvidia.com>
> ---
>  arch/arm64/boot/dts/nvidia/tegra186-p2771-0000.dts | 12 ------------
>  1 file changed, 12 deletions(-)

Applied, thanks.

Thierry

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2020-11-16 16:28 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-11-16 16:20 [PATCH] ARM64: tegra: Disable the ACONNECT for Jetson TX2 Jon Hunter
2020-11-16 16:28 ` Thierry Reding

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.