* [Intel-gfx] [PATCH i-g-t 1/5] intel_gpu_top: User friendly device listing
@ 2020-11-16 17:26 ` Tvrtko Ursulin
0 siblings, 0 replies; 17+ messages in thread
From: Tvrtko Ursulin @ 2020-11-16 17:26 UTC (permalink / raw)
To: igt-dev; +Cc: Intel-gfx
From: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
Adding a new device selection print type suitable for user-facing
use cases like intel_gpu_top -L and later lsgpu.
Instead of:
sys:/sys/devices/pci0000:00/0000:00:02.0/drm/card0
subsystem : drm
drm card : /dev/dri/card0
parent : sys:/sys/devices/pci0000:00/0000:00:02.0
sys:/sys/devices/pci0000:00/0000:00:02.0/drm/renderD128
subsystem : drm
drm render : /dev/dri/renderD128
parent : sys:/sys/devices/pci0000:00/0000:00:02.0
sys:/sys/devices/pci0000:00/0000:00:02.0
subsystem : pci
drm card : /dev/dri/card0
drm render : /dev/dri/renderD128
vendor : 8086
device : 193B
New format looks like:
card0 8086:193B drm:/dev/dri/card0
└─renderD128 drm:/dev/dri/renderD128
Advantages are more compact, more readable, one entry per GPU, shorter
string to copy and paste to intel_gpu_top -d, or respective usage.
v2:
* Increase stack filter size. (Zbigniew)
Signed-off-by: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
Cc: Petri Latvala <petri.latvala@intel.com>
Cc: Zbigniew Kempczyński <zbigniew.kempczynski@intel.com>
Reviewed-by: Zbigniew Kempczyński <zbigniew.kempczynski@intel.com>
---
lib/igt_device_scan.c | 109 +++++++++++++++++++++++++++++++++++++-----
lib/igt_device_scan.h | 1 +
tools/intel_gpu_top.c | 3 +-
3 files changed, 100 insertions(+), 13 deletions(-)
diff --git a/lib/igt_device_scan.c b/lib/igt_device_scan.c
index c581a31ae55e..c0cd6757fc27 100644
--- a/lib/igt_device_scan.c
+++ b/lib/igt_device_scan.c
@@ -735,18 +735,26 @@ static inline void _pr_simple2(const char *k, const char *v1, const char *v2)
printf(" %-16s: %s:%s\n", k, v1, v2);
}
-static void igt_devs_print_simple(struct igt_list_head *view)
+static bool __check_empty(struct igt_list_head *view)
{
- struct igt_device *dev;
-
if (!view)
- return;
+ return true;
if (igt_list_empty(view)) {
printf("No GPU devices found\n");
- return;
+ return true;
}
+ return false;
+}
+
+static void igt_devs_print_simple(struct igt_list_head *view)
+{
+ struct igt_device *dev;
+
+ if (__check_empty(view))
+ return;
+
igt_list_for_each_entry(dev, view, link) {
printf("sys:%s\n", dev->syspath);
if (dev->subsystem)
@@ -768,6 +776,89 @@ static void igt_devs_print_simple(struct igt_list_head *view)
}
}
+static struct igt_device *
+__find_pci(struct igt_list_head *view, const char *drm)
+{
+ struct igt_device *dev;
+
+ igt_list_for_each_entry(dev, view, link) {
+ if (!is_pci_subsystem(dev) || !dev->drm_card)
+ continue;
+
+ if (!strcmp(dev->drm_card, drm))
+ return dev;
+ }
+
+ return NULL;
+}
+
+static void igt_devs_print_user(struct igt_list_head *view)
+{
+ struct igt_device *dev;
+
+ if (__check_empty(view))
+ return;
+
+ igt_list_for_each_entry(dev, view, link) {
+ unsigned int i, num_children;
+ struct igt_device *pci_dev;
+ struct igt_device *dev2;
+ char filter[256];
+ char *drm_name;
+ int ret;
+
+ if (!is_drm_subsystem(dev))
+ continue;
+ if (!dev->drm_card || dev->drm_render)
+ continue;
+
+ drm_name = rindex(dev->drm_card, '/');
+ if (!drm_name || !*++drm_name)
+ continue;
+
+ ret = snprintf(filter, sizeof(filter), "drm:%s", dev->drm_card);
+ igt_assert(ret < sizeof(filter));
+
+ pci_dev = __find_pci(view, dev->drm_card);
+ if (pci_dev)
+ printf("%-24s%4s:%4s %s\n",
+ drm_name, pci_dev->vendor, pci_dev->device,
+ filter);
+ else
+ printf("%-24s %s\n", drm_name, filter);
+
+ num_children = 0;
+ igt_list_for_each_entry(dev2, view, link) {
+ if (!is_drm_subsystem(dev2) || !dev2->drm_render)
+ continue;
+ if (strcmp(dev2->parent->syspath, dev->parent->syspath))
+ continue;
+
+ num_children++;
+ }
+
+ i = 0;
+ igt_list_for_each_entry(dev2, view, link) {
+ if (!is_drm_subsystem(dev2) || !dev2->drm_render)
+ continue;
+ if (strcmp(dev2->parent->syspath, dev->parent->syspath))
+ continue;
+
+ drm_name = rindex(dev2->drm_render, '/');
+ if (!drm_name || !*++drm_name)
+ continue;
+
+ ret = snprintf(filter, sizeof(filter), "drm:%s",
+ dev2->drm_render);
+ igt_assert(ret < sizeof(filter));
+
+ printf("%s%-22s %s\n",
+ (++i == num_children) ? "└─" : "├─",
+ drm_name, filter);
+ }
+ }
+}
+
static inline void _print_key_value(const char* k, const char *v)
{
printf("%-32s: %s\n", k, v);
@@ -792,14 +883,9 @@ static void igt_devs_print_detail(struct igt_list_head *view)
{
struct igt_device *dev;
- if (!view)
+ if (__check_empty(view))
return;
- if (igt_list_empty(view)) {
- printf("No GPU devices found\n");
- return;
- }
-
igt_list_for_each_entry(dev, view, link) {
printf("========== %s:%s ==========\n",
dev->subsystem, dev->syspath);
@@ -821,6 +907,7 @@ static struct print_func {
} print_functions[] = {
[IGT_PRINT_SIMPLE] = { .prn = igt_devs_print_simple },
[IGT_PRINT_DETAIL] = { .prn = igt_devs_print_detail },
+ [IGT_PRINT_USER] = { .prn = igt_devs_print_user },
};
/**
diff --git a/lib/igt_device_scan.h b/lib/igt_device_scan.h
index 99daee0c52d6..9822c22cb69c 100644
--- a/lib/igt_device_scan.h
+++ b/lib/igt_device_scan.h
@@ -37,6 +37,7 @@
enum igt_devices_print_type {
IGT_PRINT_SIMPLE,
IGT_PRINT_DETAIL,
+ IGT_PRINT_USER, /* End user friendly. */
};
#define INTEGRATED_I915_GPU_PCI_ID "0000:00:02.0"
diff --git a/tools/intel_gpu_top.c b/tools/intel_gpu_top.c
index 298defa4e6ed..5230472d2af4 100644
--- a/tools/intel_gpu_top.c
+++ b/tools/intel_gpu_top.c
@@ -1313,7 +1313,6 @@ int main(int argc, char **argv)
unsigned int i;
int ret = 0, ch;
bool list_device = false;
- enum igt_devices_print_type printtype = IGT_PRINT_SIMPLE;
char *pmu_device, *opt_device = NULL;
struct igt_device_card card;
@@ -1388,7 +1387,7 @@ int main(int argc, char **argv)
igt_devices_scan(false);
if (list_device) {
- igt_devices_print(printtype);
+ igt_devices_print(IGT_PRINT_USER);
goto exit;
}
--
2.25.1
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply related [flat|nested] 17+ messages in thread
* [igt-dev] [PATCH i-g-t 1/5] intel_gpu_top: User friendly device listing
@ 2020-11-16 17:26 ` Tvrtko Ursulin
0 siblings, 0 replies; 17+ messages in thread
From: Tvrtko Ursulin @ 2020-11-16 17:26 UTC (permalink / raw)
To: igt-dev; +Cc: Intel-gfx, Petri Latvala, Tvrtko Ursulin
From: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
Adding a new device selection print type suitable for user-facing
use cases like intel_gpu_top -L and later lsgpu.
Instead of:
sys:/sys/devices/pci0000:00/0000:00:02.0/drm/card0
subsystem : drm
drm card : /dev/dri/card0
parent : sys:/sys/devices/pci0000:00/0000:00:02.0
sys:/sys/devices/pci0000:00/0000:00:02.0/drm/renderD128
subsystem : drm
drm render : /dev/dri/renderD128
parent : sys:/sys/devices/pci0000:00/0000:00:02.0
sys:/sys/devices/pci0000:00/0000:00:02.0
subsystem : pci
drm card : /dev/dri/card0
drm render : /dev/dri/renderD128
vendor : 8086
device : 193B
New format looks like:
card0 8086:193B drm:/dev/dri/card0
└─renderD128 drm:/dev/dri/renderD128
Advantages are more compact, more readable, one entry per GPU, shorter
string to copy and paste to intel_gpu_top -d, or respective usage.
v2:
* Increase stack filter size. (Zbigniew)
Signed-off-by: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
Cc: Petri Latvala <petri.latvala@intel.com>
Cc: Zbigniew Kempczyński <zbigniew.kempczynski@intel.com>
Reviewed-by: Zbigniew Kempczyński <zbigniew.kempczynski@intel.com>
---
lib/igt_device_scan.c | 109 +++++++++++++++++++++++++++++++++++++-----
lib/igt_device_scan.h | 1 +
tools/intel_gpu_top.c | 3 +-
3 files changed, 100 insertions(+), 13 deletions(-)
diff --git a/lib/igt_device_scan.c b/lib/igt_device_scan.c
index c581a31ae55e..c0cd6757fc27 100644
--- a/lib/igt_device_scan.c
+++ b/lib/igt_device_scan.c
@@ -735,18 +735,26 @@ static inline void _pr_simple2(const char *k, const char *v1, const char *v2)
printf(" %-16s: %s:%s\n", k, v1, v2);
}
-static void igt_devs_print_simple(struct igt_list_head *view)
+static bool __check_empty(struct igt_list_head *view)
{
- struct igt_device *dev;
-
if (!view)
- return;
+ return true;
if (igt_list_empty(view)) {
printf("No GPU devices found\n");
- return;
+ return true;
}
+ return false;
+}
+
+static void igt_devs_print_simple(struct igt_list_head *view)
+{
+ struct igt_device *dev;
+
+ if (__check_empty(view))
+ return;
+
igt_list_for_each_entry(dev, view, link) {
printf("sys:%s\n", dev->syspath);
if (dev->subsystem)
@@ -768,6 +776,89 @@ static void igt_devs_print_simple(struct igt_list_head *view)
}
}
+static struct igt_device *
+__find_pci(struct igt_list_head *view, const char *drm)
+{
+ struct igt_device *dev;
+
+ igt_list_for_each_entry(dev, view, link) {
+ if (!is_pci_subsystem(dev) || !dev->drm_card)
+ continue;
+
+ if (!strcmp(dev->drm_card, drm))
+ return dev;
+ }
+
+ return NULL;
+}
+
+static void igt_devs_print_user(struct igt_list_head *view)
+{
+ struct igt_device *dev;
+
+ if (__check_empty(view))
+ return;
+
+ igt_list_for_each_entry(dev, view, link) {
+ unsigned int i, num_children;
+ struct igt_device *pci_dev;
+ struct igt_device *dev2;
+ char filter[256];
+ char *drm_name;
+ int ret;
+
+ if (!is_drm_subsystem(dev))
+ continue;
+ if (!dev->drm_card || dev->drm_render)
+ continue;
+
+ drm_name = rindex(dev->drm_card, '/');
+ if (!drm_name || !*++drm_name)
+ continue;
+
+ ret = snprintf(filter, sizeof(filter), "drm:%s", dev->drm_card);
+ igt_assert(ret < sizeof(filter));
+
+ pci_dev = __find_pci(view, dev->drm_card);
+ if (pci_dev)
+ printf("%-24s%4s:%4s %s\n",
+ drm_name, pci_dev->vendor, pci_dev->device,
+ filter);
+ else
+ printf("%-24s %s\n", drm_name, filter);
+
+ num_children = 0;
+ igt_list_for_each_entry(dev2, view, link) {
+ if (!is_drm_subsystem(dev2) || !dev2->drm_render)
+ continue;
+ if (strcmp(dev2->parent->syspath, dev->parent->syspath))
+ continue;
+
+ num_children++;
+ }
+
+ i = 0;
+ igt_list_for_each_entry(dev2, view, link) {
+ if (!is_drm_subsystem(dev2) || !dev2->drm_render)
+ continue;
+ if (strcmp(dev2->parent->syspath, dev->parent->syspath))
+ continue;
+
+ drm_name = rindex(dev2->drm_render, '/');
+ if (!drm_name || !*++drm_name)
+ continue;
+
+ ret = snprintf(filter, sizeof(filter), "drm:%s",
+ dev2->drm_render);
+ igt_assert(ret < sizeof(filter));
+
+ printf("%s%-22s %s\n",
+ (++i == num_children) ? "└─" : "├─",
+ drm_name, filter);
+ }
+ }
+}
+
static inline void _print_key_value(const char* k, const char *v)
{
printf("%-32s: %s\n", k, v);
@@ -792,14 +883,9 @@ static void igt_devs_print_detail(struct igt_list_head *view)
{
struct igt_device *dev;
- if (!view)
+ if (__check_empty(view))
return;
- if (igt_list_empty(view)) {
- printf("No GPU devices found\n");
- return;
- }
-
igt_list_for_each_entry(dev, view, link) {
printf("========== %s:%s ==========\n",
dev->subsystem, dev->syspath);
@@ -821,6 +907,7 @@ static struct print_func {
} print_functions[] = {
[IGT_PRINT_SIMPLE] = { .prn = igt_devs_print_simple },
[IGT_PRINT_DETAIL] = { .prn = igt_devs_print_detail },
+ [IGT_PRINT_USER] = { .prn = igt_devs_print_user },
};
/**
diff --git a/lib/igt_device_scan.h b/lib/igt_device_scan.h
index 99daee0c52d6..9822c22cb69c 100644
--- a/lib/igt_device_scan.h
+++ b/lib/igt_device_scan.h
@@ -37,6 +37,7 @@
enum igt_devices_print_type {
IGT_PRINT_SIMPLE,
IGT_PRINT_DETAIL,
+ IGT_PRINT_USER, /* End user friendly. */
};
#define INTEGRATED_I915_GPU_PCI_ID "0000:00:02.0"
diff --git a/tools/intel_gpu_top.c b/tools/intel_gpu_top.c
index 298defa4e6ed..5230472d2af4 100644
--- a/tools/intel_gpu_top.c
+++ b/tools/intel_gpu_top.c
@@ -1313,7 +1313,6 @@ int main(int argc, char **argv)
unsigned int i;
int ret = 0, ch;
bool list_device = false;
- enum igt_devices_print_type printtype = IGT_PRINT_SIMPLE;
char *pmu_device, *opt_device = NULL;
struct igt_device_card card;
@@ -1388,7 +1387,7 @@ int main(int argc, char **argv)
igt_devices_scan(false);
if (list_device) {
- igt_devices_print(printtype);
+ igt_devices_print(IGT_PRINT_USER);
goto exit;
}
--
2.25.1
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply related [flat|nested] 17+ messages in thread
* [Intel-gfx] [PATCH i-g-t 2/5] lsgpu: User friendly device listing
2020-11-16 17:26 ` [igt-dev] " Tvrtko Ursulin
(?)
@ 2020-11-16 17:26 ` Tvrtko Ursulin
-1 siblings, 0 replies; 17+ messages in thread
From: Tvrtko Ursulin @ 2020-11-16 17:26 UTC (permalink / raw)
To: igt-dev; +Cc: Intel-gfx
From: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
New default user frindly device listing mode which replaces:
sys:/sys/devices/pci0000:00/0000:00:02.0/drm/card0
subsystem : drm
drm card : /dev/dri/card0
parent : sys:/sys/devices/pci0000:00/0000:00:02.0
sys:/sys/devices/pci0000:00/0000:00:02.0/drm/renderD128
subsystem : drm
drm render : /dev/dri/renderD128
parent : sys:/sys/devices/pci0000:00/0000:00:02.0
sys:/sys/devices/pci0000:00/0000:00:02.0
subsystem : pci
drm card : /dev/dri/card0
drm render : /dev/dri/renderD128
vendor : 8086
device : 193B
With:
card0 8086:193B drm:/dev/dri/card0
└─renderD128 drm:/dev/dri/renderD128
Advantages are more compact, more readable, one entry per GPU.
Legacy format can be chose using the -s / --print-simple command line
switches.
Signed-off-by: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
Cc: Petri Latvala <petri.latvala@intel.com>
Cc: Zbigniew Kempczyński <zbigniew.kempczynski@intel.com>
Reviewed-by: Zbigniew Kempczyński <zbigniew.kempczynski@intel.com>
---
tools/lsgpu.c | 10 ++++++++--
1 file changed, 8 insertions(+), 2 deletions(-)
diff --git a/tools/lsgpu.c b/tools/lsgpu.c
index 2541d1c24e66..3b234b73361a 100644
--- a/tools/lsgpu.c
+++ b/tools/lsgpu.c
@@ -70,6 +70,7 @@
*/
enum {
+ OPT_PRINT_SIMPLE = 's',
OPT_PRINT_DETAIL = 'p',
OPT_LIST_VENDORS = 'v',
OPT_LIST_FILTERS = 'l',
@@ -85,6 +86,7 @@ static char *igt_device;
static const char *usage_str =
"usage: lsgpu [options]\n\n"
"Options:\n"
+ " -s, --print-simple Print simple (legacy) device details\n"
" -p, --print-details Print devices with details\n"
" -v, --list-vendors List recognized vendors\n"
" -l, --list-filter-types List registered device filters types\n"
@@ -151,6 +153,7 @@ static char *get_device_from_rc(void)
int main(int argc, char *argv[])
{
static struct option long_options[] = {
+ {"print-simple", no_argument, NULL, OPT_PRINT_SIMPLE},
{"print-detail", no_argument, NULL, OPT_PRINT_DETAIL},
{"list-vendors", no_argument, NULL, OPT_LIST_VENDORS},
{"list-filter-types", no_argument, NULL, OPT_LIST_FILTERS},
@@ -160,12 +163,15 @@ int main(int argc, char *argv[])
};
int c, index = 0;
char *env_device = NULL, *opt_device = NULL, *rc_device = NULL;
- enum igt_devices_print_type printtype = IGT_PRINT_SIMPLE;
+ enum igt_devices_print_type printtype = IGT_PRINT_USER;
- while ((c = getopt_long(argc, argv, "pvld:h",
+ while ((c = getopt_long(argc, argv, "spvld:h",
long_options, &index)) != -1) {
switch(c) {
+ case OPT_PRINT_SIMPLE:
+ printtype = IGT_PRINT_SIMPLE;
+ break;
case OPT_PRINT_DETAIL:
printtype = IGT_PRINT_DETAIL;
break;
--
2.25.1
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply related [flat|nested] 17+ messages in thread
* [Intel-gfx] [PATCH i-g-t 3/5] lib/igt_device_scan: Remember PCI card index after scanning
2020-11-16 17:26 ` [igt-dev] " Tvrtko Ursulin
@ 2020-11-16 17:26 ` Tvrtko Ursulin
-1 siblings, 0 replies; 17+ messages in thread
From: Tvrtko Ursulin @ 2020-11-16 17:26 UTC (permalink / raw)
To: igt-dev; +Cc: Intel-gfx
From: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
After devices are sorted post scanning, assing a card index to each so it
can be easily accessed if PCI filter for a card needs to be printed out.
v2:
* Preserve existing pci:..card=N behaviour. (Zbigniew)
Signed-off-by: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
Cc: Petri Latvala <petri.latvala@intel.com>
Cc: Zbigniew Kempczyński <zbigniew.kempczynski@intel.com>
---
lib/igt_device_scan.c | 29 +++++++++++++++++++++++++++++
1 file changed, 29 insertions(+)
diff --git a/lib/igt_device_scan.c b/lib/igt_device_scan.c
index c0cd6757fc27..ecb8db297f86 100644
--- a/lib/igt_device_scan.c
+++ b/lib/igt_device_scan.c
@@ -166,6 +166,7 @@ struct igt_device {
char *vendor;
char *device;
char *pci_slot_name;
+ int gpu_index; /* For more than one GPU with same vendor and device. */
struct igt_list_head link;
};
@@ -601,6 +602,33 @@ static void sort_all_devices(void)
free(devs);
}
+static void index_pci_devices(void)
+{
+ struct igt_device *dev;
+
+ igt_list_for_each_entry(dev, &igt_devs.all, link) {
+ struct igt_device *dev2;
+ int index = 0;
+
+ if (!is_pci_subsystem(dev))
+ continue;
+
+ igt_list_for_each_entry(dev2, &igt_devs.all, link) {
+ if (!is_pci_subsystem(dev2))
+ continue;
+
+ if (dev2 == dev)
+ break;
+
+ if (!strcasecmp(dev->vendor, dev2->vendor) &&
+ !strcasecmp(dev->device, dev2->device))
+ index++;
+ }
+
+ dev->gpu_index = index;
+ }
+}
+
/* Core scanning function.
*
* All scanned devices are kept inside igt_devs.all pointer array.
@@ -657,6 +685,7 @@ static void scan_drm_devices(void)
udev_unref(udev);
sort_all_devices();
+ index_pci_devices();
igt_list_for_each_entry(dev, &igt_devs.all, link) {
struct igt_device *dev_dup = duplicate_device(dev);
--
2.25.1
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply related [flat|nested] 17+ messages in thread
* [igt-dev] [PATCH i-g-t 3/5] lib/igt_device_scan: Remember PCI card index after scanning
@ 2020-11-16 17:26 ` Tvrtko Ursulin
0 siblings, 0 replies; 17+ messages in thread
From: Tvrtko Ursulin @ 2020-11-16 17:26 UTC (permalink / raw)
To: igt-dev; +Cc: Intel-gfx, Petri Latvala, Tvrtko Ursulin
From: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
After devices are sorted post scanning, assing a card index to each so it
can be easily accessed if PCI filter for a card needs to be printed out.
v2:
* Preserve existing pci:..card=N behaviour. (Zbigniew)
Signed-off-by: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
Cc: Petri Latvala <petri.latvala@intel.com>
Cc: Zbigniew Kempczyński <zbigniew.kempczynski@intel.com>
---
lib/igt_device_scan.c | 29 +++++++++++++++++++++++++++++
1 file changed, 29 insertions(+)
diff --git a/lib/igt_device_scan.c b/lib/igt_device_scan.c
index c0cd6757fc27..ecb8db297f86 100644
--- a/lib/igt_device_scan.c
+++ b/lib/igt_device_scan.c
@@ -166,6 +166,7 @@ struct igt_device {
char *vendor;
char *device;
char *pci_slot_name;
+ int gpu_index; /* For more than one GPU with same vendor and device. */
struct igt_list_head link;
};
@@ -601,6 +602,33 @@ static void sort_all_devices(void)
free(devs);
}
+static void index_pci_devices(void)
+{
+ struct igt_device *dev;
+
+ igt_list_for_each_entry(dev, &igt_devs.all, link) {
+ struct igt_device *dev2;
+ int index = 0;
+
+ if (!is_pci_subsystem(dev))
+ continue;
+
+ igt_list_for_each_entry(dev2, &igt_devs.all, link) {
+ if (!is_pci_subsystem(dev2))
+ continue;
+
+ if (dev2 == dev)
+ break;
+
+ if (!strcasecmp(dev->vendor, dev2->vendor) &&
+ !strcasecmp(dev->device, dev2->device))
+ index++;
+ }
+
+ dev->gpu_index = index;
+ }
+}
+
/* Core scanning function.
*
* All scanned devices are kept inside igt_devs.all pointer array.
@@ -657,6 +685,7 @@ static void scan_drm_devices(void)
udev_unref(udev);
sort_all_devices();
+ index_pci_devices();
igt_list_for_each_entry(dev, &igt_devs.all, link) {
struct igt_device *dev_dup = duplicate_device(dev);
--
2.25.1
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply related [flat|nested] 17+ messages in thread
* [Intel-gfx] [PATCH i-g-t 4/5] lsgpu: Add filter type print-out selection
2020-11-16 17:26 ` [igt-dev] " Tvrtko Ursulin
@ 2020-11-16 17:26 ` Tvrtko Ursulin
-1 siblings, 0 replies; 17+ messages in thread
From: Tvrtko Ursulin @ 2020-11-16 17:26 UTC (permalink / raw)
To: igt-dev; +Cc: Intel-gfx
From: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
In the previous patch we switched the lsgpu output to a short and user
friendly format but some users will need a shorthand for getting other
types of device selection filters than the defaut drm.
Add some command line switches to enable this:
$ lsgpu
card0 8086:193B drm:/dev/dri/card0
└─renderD128 drm:/dev/dri/renderD128
$ lsgpu --sysfs
card0 8086:193B sys:/sys/devices/pci0000:00/0000:00:02.0/drm/card0
└─renderD128 sys:/sys/devices/pci0000:00/0000:00:02.0/drm/renderD128
$ lsgpu --pci
card0 8086:193B pci:vendor=8086,device=193B,card=0
└─renderD128
v2:
* Fix pci filter format.
Signed-off-by: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
Suggested-by: Zbigniew Kempczyński <zbigniew.kempczynski@intel.com>
Cc: Petri Latvala <petri.latvala@intel.com>
---
lib/igt_device_scan.c | 83 ++++++++++++++++++++++++++++++++-----------
lib/igt_device_scan.h | 15 ++++++--
tools/intel_gpu_top.c | 6 +++-
tools/lsgpu.c | 32 +++++++++++++----
4 files changed, 106 insertions(+), 30 deletions(-)
diff --git a/lib/igt_device_scan.c b/lib/igt_device_scan.c
index ecb8db297f86..e97f7163ba70 100644
--- a/lib/igt_device_scan.c
+++ b/lib/igt_device_scan.c
@@ -777,7 +777,9 @@ static bool __check_empty(struct igt_list_head *view)
return false;
}
-static void igt_devs_print_simple(struct igt_list_head *view)
+static void
+igt_devs_print_simple(struct igt_list_head *view,
+ const struct igt_devices_print_format *fmt)
{
struct igt_device *dev;
@@ -821,7 +823,38 @@ __find_pci(struct igt_list_head *view, const char *drm)
return NULL;
}
-static void igt_devs_print_user(struct igt_list_head *view)
+static void __print_filter(char *buf, int len,
+ const struct igt_devices_print_format *fmt,
+ struct igt_device *dev,
+ bool render)
+{
+ int ret;
+
+ switch (fmt->option) {
+ case IGT_PRINT_DRM:
+ ret = snprintf(buf, len, "drm:%s",
+ render ? dev->drm_render : dev->drm_card);
+ igt_assert(ret < len);
+ break;
+ case IGT_PRINT_SYSFS:
+ ret = snprintf(buf, len, "sys:%s", dev->syspath);
+ igt_assert(ret < len);
+ break;
+ case IGT_PRINT_PCI:
+ if (!render) {
+ ret = snprintf(buf, len,
+ "pci:vendor=%s,device=%s,card=%d",
+ dev->vendor, dev->device,
+ dev->gpu_index);
+ igt_assert(ret < len);
+ }
+ break;
+ };
+}
+
+static void
+igt_devs_print_user(struct igt_list_head *view,
+ const struct igt_devices_print_format *fmt)
{
struct igt_device *dev;
@@ -834,7 +867,6 @@ static void igt_devs_print_user(struct igt_list_head *view)
struct igt_device *dev2;
char filter[256];
char *drm_name;
- int ret;
if (!is_drm_subsystem(dev))
continue;
@@ -845,16 +877,21 @@ static void igt_devs_print_user(struct igt_list_head *view)
if (!drm_name || !*++drm_name)
continue;
- ret = snprintf(filter, sizeof(filter), "drm:%s", dev->drm_card);
- igt_assert(ret < sizeof(filter));
-
pci_dev = __find_pci(view, dev->drm_card);
- if (pci_dev)
+
+ if (fmt->option == IGT_PRINT_PCI && !pci_dev)
+ continue;
+
+ if (pci_dev) {
+ __print_filter(filter, sizeof(filter), fmt, pci_dev,
+ false);
printf("%-24s%4s:%4s %s\n",
drm_name, pci_dev->vendor, pci_dev->device,
filter);
- else
+ } else {
+ __print_filter(filter, sizeof(filter), fmt, dev, false);
printf("%-24s %s\n", drm_name, filter);
+ }
num_children = 0;
igt_list_for_each_entry(dev2, view, link) {
@@ -877,13 +914,15 @@ static void igt_devs_print_user(struct igt_list_head *view)
if (!drm_name || !*++drm_name)
continue;
- ret = snprintf(filter, sizeof(filter), "drm:%s",
- dev2->drm_render);
- igt_assert(ret < sizeof(filter));
-
- printf("%s%-22s %s\n",
- (++i == num_children) ? "└─" : "├─",
- drm_name, filter);
+ printf("%s%-22s",
+ (++i == num_children) ? "└─" : "├─", drm_name);
+ if (fmt->option != IGT_PRINT_PCI) {
+ __print_filter(filter, sizeof(filter), fmt,
+ dev2, true);
+ printf(" %s\n", filter);
+ } else {
+ printf("\n");
+ }
}
}
}
@@ -908,7 +947,10 @@ static void print_ht(GHashTable *ht)
g_list_free(keys);
}
-static void igt_devs_print_detail(struct igt_list_head *view)
+static void
+igt_devs_print_detail(struct igt_list_head *view,
+ const struct igt_devices_print_format *fmt)
+
{
struct igt_device *dev;
@@ -932,7 +974,8 @@ static void igt_devs_print_detail(struct igt_list_head *view)
}
static struct print_func {
- void (*prn)(struct igt_list_head *view);
+ void (*prn)(struct igt_list_head *view,
+ const struct igt_devices_print_format *);
} print_functions[] = {
[IGT_PRINT_SIMPLE] = { .prn = igt_devs_print_simple },
[IGT_PRINT_DETAIL] = { .prn = igt_devs_print_detail },
@@ -941,15 +984,15 @@ static struct print_func {
/**
* igt_devices_print
- * @printtype: IGT_PRINT_SIMPLE or IGT_PRINT_DETAIL
+ * @fmt: Print format as specified by struct igt_devices_print_format
*
* Function can be used by external tool to print device array in simple
* or detailed form. This function is added here to avoid exposing
* internal implementation data structures.
*/
-void igt_devices_print(enum igt_devices_print_type printtype)
+void igt_devices_print(const struct igt_devices_print_format *fmt)
{
- print_functions[printtype].prn(&igt_devs.filtered);
+ print_functions[fmt->type].prn(&igt_devs.filtered, fmt);
}
/**
diff --git a/lib/igt_device_scan.h b/lib/igt_device_scan.h
index 9822c22cb69c..bb4be72345fb 100644
--- a/lib/igt_device_scan.h
+++ b/lib/igt_device_scan.h
@@ -35,11 +35,22 @@
#include <unistd.h>
enum igt_devices_print_type {
- IGT_PRINT_SIMPLE,
+ IGT_PRINT_SIMPLE = 0,
IGT_PRINT_DETAIL,
IGT_PRINT_USER, /* End user friendly. */
};
+enum igt_devices_print_option {
+ IGT_PRINT_DRM = 0,
+ IGT_PRINT_SYSFS,
+ IGT_PRINT_PCI,
+};
+
+struct igt_devices_print_format {
+ enum igt_devices_print_type type;
+ enum igt_devices_print_option option;
+};
+
#define INTEGRATED_I915_GPU_PCI_ID "0000:00:02.0"
#define PCI_SLOT_NAME_SIZE 12
struct igt_device_card {
@@ -51,7 +62,7 @@ struct igt_device_card {
void igt_devices_scan(bool force);
-void igt_devices_print(enum igt_devices_print_type printtype);
+void igt_devices_print(const struct igt_devices_print_format *fmt);
void igt_devices_print_vendors(void);
void igt_device_print_filter_types(void);
diff --git a/tools/intel_gpu_top.c b/tools/intel_gpu_top.c
index 5230472d2af4..07f88d555dc8 100644
--- a/tools/intel_gpu_top.c
+++ b/tools/intel_gpu_top.c
@@ -1387,7 +1387,11 @@ int main(int argc, char **argv)
igt_devices_scan(false);
if (list_device) {
- igt_devices_print(IGT_PRINT_USER);
+ struct igt_devices_print_format fmt = {
+ .type = IGT_PRINT_USER
+ };
+
+ igt_devices_print(&fmt);
goto exit;
}
diff --git a/tools/lsgpu.c b/tools/lsgpu.c
index 3b234b73361a..169ab0c29e50 100644
--- a/tools/lsgpu.c
+++ b/tools/lsgpu.c
@@ -91,7 +91,11 @@ static const char *usage_str =
" -v, --list-vendors List recognized vendors\n"
" -l, --list-filter-types List registered device filters types\n"
" -d, --device filter Device filter, can be given multiple times\n"
- " -h, --help Show this help message and exit\n";
+ " -h, --help Show this help message and exit\n"
+ "\nOptions valid for default print out mode only:\n"
+ " --drm Show DRM filters (default) for each device\n"
+ " --sysfs Show sysfs filters for each device\n"
+ " --pci Show PCI filters for each device\n";
static void test_device_open(struct igt_device_card *card)
{
@@ -153,6 +157,9 @@ static char *get_device_from_rc(void)
int main(int argc, char *argv[])
{
static struct option long_options[] = {
+ {"drm", no_argument, NULL, 0},
+ {"sysfs", no_argument, NULL, 1},
+ {"pci", no_argument, NULL, 2},
{"print-simple", no_argument, NULL, OPT_PRINT_SIMPLE},
{"print-detail", no_argument, NULL, OPT_PRINT_DETAIL},
{"list-vendors", no_argument, NULL, OPT_LIST_VENDORS},
@@ -163,17 +170,19 @@ int main(int argc, char *argv[])
};
int c, index = 0;
char *env_device = NULL, *opt_device = NULL, *rc_device = NULL;
- enum igt_devices_print_type printtype = IGT_PRINT_USER;
+ struct igt_devices_print_format fmt = {
+ .type = IGT_PRINT_USER,
+ };
while ((c = getopt_long(argc, argv, "spvld:h",
long_options, &index)) != -1) {
switch(c) {
case OPT_PRINT_SIMPLE:
- printtype = IGT_PRINT_SIMPLE;
+ fmt.type = IGT_PRINT_SIMPLE;
break;
case OPT_PRINT_DETAIL:
- printtype = IGT_PRINT_DETAIL;
+ fmt.type = IGT_PRINT_DETAIL;
break;
case OPT_LIST_VENDORS:
g_show_vendors = true;
@@ -187,6 +196,15 @@ int main(int argc, char *argv[])
case OPT_HELP:
g_help = true;
break;
+ case 0:
+ fmt.option = IGT_PRINT_DRM;
+ break;
+ case 1:
+ fmt.option = IGT_PRINT_SYSFS;
+ break;
+ case 2:
+ fmt.option = IGT_PRINT_PCI;
+ break;
}
}
@@ -239,14 +257,14 @@ int main(int argc, char *argv[])
printf("Device detail:\n");
print_card(&card);
test_device_open(&card);
- if (printtype == IGT_PRINT_DETAIL) {
+ if (fmt.type == IGT_PRINT_DETAIL) {
printf("\n");
- igt_devices_print(printtype);
+ igt_devices_print(&fmt);
}
printf("-------------------------------------------\n");
} else {
- igt_devices_print(printtype);
+ igt_devices_print(&fmt);
}
free(rc_device);
--
2.25.1
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply related [flat|nested] 17+ messages in thread
* [igt-dev] [PATCH i-g-t 4/5] lsgpu: Add filter type print-out selection
@ 2020-11-16 17:26 ` Tvrtko Ursulin
0 siblings, 0 replies; 17+ messages in thread
From: Tvrtko Ursulin @ 2020-11-16 17:26 UTC (permalink / raw)
To: igt-dev; +Cc: Intel-gfx, Petri Latvala, Tvrtko Ursulin
From: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
In the previous patch we switched the lsgpu output to a short and user
friendly format but some users will need a shorthand for getting other
types of device selection filters than the defaut drm.
Add some command line switches to enable this:
$ lsgpu
card0 8086:193B drm:/dev/dri/card0
└─renderD128 drm:/dev/dri/renderD128
$ lsgpu --sysfs
card0 8086:193B sys:/sys/devices/pci0000:00/0000:00:02.0/drm/card0
└─renderD128 sys:/sys/devices/pci0000:00/0000:00:02.0/drm/renderD128
$ lsgpu --pci
card0 8086:193B pci:vendor=8086,device=193B,card=0
└─renderD128
v2:
* Fix pci filter format.
Signed-off-by: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
Suggested-by: Zbigniew Kempczyński <zbigniew.kempczynski@intel.com>
Cc: Petri Latvala <petri.latvala@intel.com>
---
lib/igt_device_scan.c | 83 ++++++++++++++++++++++++++++++++-----------
lib/igt_device_scan.h | 15 ++++++--
tools/intel_gpu_top.c | 6 +++-
tools/lsgpu.c | 32 +++++++++++++----
4 files changed, 106 insertions(+), 30 deletions(-)
diff --git a/lib/igt_device_scan.c b/lib/igt_device_scan.c
index ecb8db297f86..e97f7163ba70 100644
--- a/lib/igt_device_scan.c
+++ b/lib/igt_device_scan.c
@@ -777,7 +777,9 @@ static bool __check_empty(struct igt_list_head *view)
return false;
}
-static void igt_devs_print_simple(struct igt_list_head *view)
+static void
+igt_devs_print_simple(struct igt_list_head *view,
+ const struct igt_devices_print_format *fmt)
{
struct igt_device *dev;
@@ -821,7 +823,38 @@ __find_pci(struct igt_list_head *view, const char *drm)
return NULL;
}
-static void igt_devs_print_user(struct igt_list_head *view)
+static void __print_filter(char *buf, int len,
+ const struct igt_devices_print_format *fmt,
+ struct igt_device *dev,
+ bool render)
+{
+ int ret;
+
+ switch (fmt->option) {
+ case IGT_PRINT_DRM:
+ ret = snprintf(buf, len, "drm:%s",
+ render ? dev->drm_render : dev->drm_card);
+ igt_assert(ret < len);
+ break;
+ case IGT_PRINT_SYSFS:
+ ret = snprintf(buf, len, "sys:%s", dev->syspath);
+ igt_assert(ret < len);
+ break;
+ case IGT_PRINT_PCI:
+ if (!render) {
+ ret = snprintf(buf, len,
+ "pci:vendor=%s,device=%s,card=%d",
+ dev->vendor, dev->device,
+ dev->gpu_index);
+ igt_assert(ret < len);
+ }
+ break;
+ };
+}
+
+static void
+igt_devs_print_user(struct igt_list_head *view,
+ const struct igt_devices_print_format *fmt)
{
struct igt_device *dev;
@@ -834,7 +867,6 @@ static void igt_devs_print_user(struct igt_list_head *view)
struct igt_device *dev2;
char filter[256];
char *drm_name;
- int ret;
if (!is_drm_subsystem(dev))
continue;
@@ -845,16 +877,21 @@ static void igt_devs_print_user(struct igt_list_head *view)
if (!drm_name || !*++drm_name)
continue;
- ret = snprintf(filter, sizeof(filter), "drm:%s", dev->drm_card);
- igt_assert(ret < sizeof(filter));
-
pci_dev = __find_pci(view, dev->drm_card);
- if (pci_dev)
+
+ if (fmt->option == IGT_PRINT_PCI && !pci_dev)
+ continue;
+
+ if (pci_dev) {
+ __print_filter(filter, sizeof(filter), fmt, pci_dev,
+ false);
printf("%-24s%4s:%4s %s\n",
drm_name, pci_dev->vendor, pci_dev->device,
filter);
- else
+ } else {
+ __print_filter(filter, sizeof(filter), fmt, dev, false);
printf("%-24s %s\n", drm_name, filter);
+ }
num_children = 0;
igt_list_for_each_entry(dev2, view, link) {
@@ -877,13 +914,15 @@ static void igt_devs_print_user(struct igt_list_head *view)
if (!drm_name || !*++drm_name)
continue;
- ret = snprintf(filter, sizeof(filter), "drm:%s",
- dev2->drm_render);
- igt_assert(ret < sizeof(filter));
-
- printf("%s%-22s %s\n",
- (++i == num_children) ? "└─" : "├─",
- drm_name, filter);
+ printf("%s%-22s",
+ (++i == num_children) ? "└─" : "├─", drm_name);
+ if (fmt->option != IGT_PRINT_PCI) {
+ __print_filter(filter, sizeof(filter), fmt,
+ dev2, true);
+ printf(" %s\n", filter);
+ } else {
+ printf("\n");
+ }
}
}
}
@@ -908,7 +947,10 @@ static void print_ht(GHashTable *ht)
g_list_free(keys);
}
-static void igt_devs_print_detail(struct igt_list_head *view)
+static void
+igt_devs_print_detail(struct igt_list_head *view,
+ const struct igt_devices_print_format *fmt)
+
{
struct igt_device *dev;
@@ -932,7 +974,8 @@ static void igt_devs_print_detail(struct igt_list_head *view)
}
static struct print_func {
- void (*prn)(struct igt_list_head *view);
+ void (*prn)(struct igt_list_head *view,
+ const struct igt_devices_print_format *);
} print_functions[] = {
[IGT_PRINT_SIMPLE] = { .prn = igt_devs_print_simple },
[IGT_PRINT_DETAIL] = { .prn = igt_devs_print_detail },
@@ -941,15 +984,15 @@ static struct print_func {
/**
* igt_devices_print
- * @printtype: IGT_PRINT_SIMPLE or IGT_PRINT_DETAIL
+ * @fmt: Print format as specified by struct igt_devices_print_format
*
* Function can be used by external tool to print device array in simple
* or detailed form. This function is added here to avoid exposing
* internal implementation data structures.
*/
-void igt_devices_print(enum igt_devices_print_type printtype)
+void igt_devices_print(const struct igt_devices_print_format *fmt)
{
- print_functions[printtype].prn(&igt_devs.filtered);
+ print_functions[fmt->type].prn(&igt_devs.filtered, fmt);
}
/**
diff --git a/lib/igt_device_scan.h b/lib/igt_device_scan.h
index 9822c22cb69c..bb4be72345fb 100644
--- a/lib/igt_device_scan.h
+++ b/lib/igt_device_scan.h
@@ -35,11 +35,22 @@
#include <unistd.h>
enum igt_devices_print_type {
- IGT_PRINT_SIMPLE,
+ IGT_PRINT_SIMPLE = 0,
IGT_PRINT_DETAIL,
IGT_PRINT_USER, /* End user friendly. */
};
+enum igt_devices_print_option {
+ IGT_PRINT_DRM = 0,
+ IGT_PRINT_SYSFS,
+ IGT_PRINT_PCI,
+};
+
+struct igt_devices_print_format {
+ enum igt_devices_print_type type;
+ enum igt_devices_print_option option;
+};
+
#define INTEGRATED_I915_GPU_PCI_ID "0000:00:02.0"
#define PCI_SLOT_NAME_SIZE 12
struct igt_device_card {
@@ -51,7 +62,7 @@ struct igt_device_card {
void igt_devices_scan(bool force);
-void igt_devices_print(enum igt_devices_print_type printtype);
+void igt_devices_print(const struct igt_devices_print_format *fmt);
void igt_devices_print_vendors(void);
void igt_device_print_filter_types(void);
diff --git a/tools/intel_gpu_top.c b/tools/intel_gpu_top.c
index 5230472d2af4..07f88d555dc8 100644
--- a/tools/intel_gpu_top.c
+++ b/tools/intel_gpu_top.c
@@ -1387,7 +1387,11 @@ int main(int argc, char **argv)
igt_devices_scan(false);
if (list_device) {
- igt_devices_print(IGT_PRINT_USER);
+ struct igt_devices_print_format fmt = {
+ .type = IGT_PRINT_USER
+ };
+
+ igt_devices_print(&fmt);
goto exit;
}
diff --git a/tools/lsgpu.c b/tools/lsgpu.c
index 3b234b73361a..169ab0c29e50 100644
--- a/tools/lsgpu.c
+++ b/tools/lsgpu.c
@@ -91,7 +91,11 @@ static const char *usage_str =
" -v, --list-vendors List recognized vendors\n"
" -l, --list-filter-types List registered device filters types\n"
" -d, --device filter Device filter, can be given multiple times\n"
- " -h, --help Show this help message and exit\n";
+ " -h, --help Show this help message and exit\n"
+ "\nOptions valid for default print out mode only:\n"
+ " --drm Show DRM filters (default) for each device\n"
+ " --sysfs Show sysfs filters for each device\n"
+ " --pci Show PCI filters for each device\n";
static void test_device_open(struct igt_device_card *card)
{
@@ -153,6 +157,9 @@ static char *get_device_from_rc(void)
int main(int argc, char *argv[])
{
static struct option long_options[] = {
+ {"drm", no_argument, NULL, 0},
+ {"sysfs", no_argument, NULL, 1},
+ {"pci", no_argument, NULL, 2},
{"print-simple", no_argument, NULL, OPT_PRINT_SIMPLE},
{"print-detail", no_argument, NULL, OPT_PRINT_DETAIL},
{"list-vendors", no_argument, NULL, OPT_LIST_VENDORS},
@@ -163,17 +170,19 @@ int main(int argc, char *argv[])
};
int c, index = 0;
char *env_device = NULL, *opt_device = NULL, *rc_device = NULL;
- enum igt_devices_print_type printtype = IGT_PRINT_USER;
+ struct igt_devices_print_format fmt = {
+ .type = IGT_PRINT_USER,
+ };
while ((c = getopt_long(argc, argv, "spvld:h",
long_options, &index)) != -1) {
switch(c) {
case OPT_PRINT_SIMPLE:
- printtype = IGT_PRINT_SIMPLE;
+ fmt.type = IGT_PRINT_SIMPLE;
break;
case OPT_PRINT_DETAIL:
- printtype = IGT_PRINT_DETAIL;
+ fmt.type = IGT_PRINT_DETAIL;
break;
case OPT_LIST_VENDORS:
g_show_vendors = true;
@@ -187,6 +196,15 @@ int main(int argc, char *argv[])
case OPT_HELP:
g_help = true;
break;
+ case 0:
+ fmt.option = IGT_PRINT_DRM;
+ break;
+ case 1:
+ fmt.option = IGT_PRINT_SYSFS;
+ break;
+ case 2:
+ fmt.option = IGT_PRINT_PCI;
+ break;
}
}
@@ -239,14 +257,14 @@ int main(int argc, char *argv[])
printf("Device detail:\n");
print_card(&card);
test_device_open(&card);
- if (printtype == IGT_PRINT_DETAIL) {
+ if (fmt.type == IGT_PRINT_DETAIL) {
printf("\n");
- igt_devices_print(printtype);
+ igt_devices_print(&fmt);
}
printf("-------------------------------------------\n");
} else {
- igt_devices_print(printtype);
+ igt_devices_print(&fmt);
}
free(rc_device);
--
2.25.1
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply related [flat|nested] 17+ messages in thread
* [Intel-gfx] [PATCH i-g-t 5/5] intel_gpu_top: Default GPU list to PCI mode
2020-11-16 17:26 ` [igt-dev] " Tvrtko Ursulin
@ 2020-11-16 17:26 ` Tvrtko Ursulin
-1 siblings, 0 replies; 17+ messages in thread
From: Tvrtko Ursulin @ 2020-11-16 17:26 UTC (permalink / raw)
To: igt-dev; +Cc: Intel-gfx
From: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
It is more obvious for the user to only shows filters for DRM master
nodes since those are the ones that intel_gpu_top monitors.
v2:
* Filter prefix needs to be sys: when listing PCI devices.
Signed-off-by: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
---
tools/intel_gpu_top.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/tools/intel_gpu_top.c b/tools/intel_gpu_top.c
index 07f88d555dc8..37b2141e784d 100644
--- a/tools/intel_gpu_top.c
+++ b/tools/intel_gpu_top.c
@@ -1388,7 +1388,8 @@ int main(int argc, char **argv)
if (list_device) {
struct igt_devices_print_format fmt = {
- .type = IGT_PRINT_USER
+ .type = IGT_PRINT_USER,
+ .option = IGT_PRINT_PCI,
};
igt_devices_print(&fmt);
--
2.25.1
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply related [flat|nested] 17+ messages in thread
* [igt-dev] [PATCH i-g-t 5/5] intel_gpu_top: Default GPU list to PCI mode
@ 2020-11-16 17:26 ` Tvrtko Ursulin
0 siblings, 0 replies; 17+ messages in thread
From: Tvrtko Ursulin @ 2020-11-16 17:26 UTC (permalink / raw)
To: igt-dev; +Cc: Intel-gfx, Tvrtko Ursulin
From: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
It is more obvious for the user to only shows filters for DRM master
nodes since those are the ones that intel_gpu_top monitors.
v2:
* Filter prefix needs to be sys: when listing PCI devices.
Signed-off-by: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
---
tools/intel_gpu_top.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/tools/intel_gpu_top.c b/tools/intel_gpu_top.c
index 07f88d555dc8..37b2141e784d 100644
--- a/tools/intel_gpu_top.c
+++ b/tools/intel_gpu_top.c
@@ -1388,7 +1388,8 @@ int main(int argc, char **argv)
if (list_device) {
struct igt_devices_print_format fmt = {
- .type = IGT_PRINT_USER
+ .type = IGT_PRINT_USER,
+ .option = IGT_PRINT_PCI,
};
igt_devices_print(&fmt);
--
2.25.1
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply related [flat|nested] 17+ messages in thread
* Re: [Intel-gfx] [PATCH i-g-t 3/5] lib/igt_device_scan: Remember PCI card index after scanning
2020-11-16 17:26 ` [igt-dev] " Tvrtko Ursulin
@ 2020-11-16 17:58 ` Zbigniew Kempczyński
-1 siblings, 0 replies; 17+ messages in thread
From: Zbigniew Kempczyński @ 2020-11-16 17:58 UTC (permalink / raw)
To: Tvrtko Ursulin; +Cc: igt-dev, Intel-gfx
On Mon, Nov 16, 2020 at 05:26:51PM +0000, Tvrtko Ursulin wrote:
> From: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
>
> After devices are sorted post scanning, assing a card index to each so it
> can be easily accessed if PCI filter for a card needs to be printed out.
>
> v2:
> * Preserve existing pci:..card=N behaviour. (Zbigniew)
>
> Signed-off-by: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
> Cc: Petri Latvala <petri.latvala@intel.com>
> Cc: Zbigniew Kempczyński <zbigniew.kempczynski@intel.com>
> ---
> lib/igt_device_scan.c | 29 +++++++++++++++++++++++++++++
> 1 file changed, 29 insertions(+)
>
> diff --git a/lib/igt_device_scan.c b/lib/igt_device_scan.c
> index c0cd6757fc27..ecb8db297f86 100644
> --- a/lib/igt_device_scan.c
> +++ b/lib/igt_device_scan.c
> @@ -166,6 +166,7 @@ struct igt_device {
> char *vendor;
> char *device;
> char *pci_slot_name;
> + int gpu_index; /* For more than one GPU with same vendor and device. */
>
> struct igt_list_head link;
> };
> @@ -601,6 +602,33 @@ static void sort_all_devices(void)
> free(devs);
> }
>
> +static void index_pci_devices(void)
> +{
> + struct igt_device *dev;
> +
> + igt_list_for_each_entry(dev, &igt_devs.all, link) {
> + struct igt_device *dev2;
> + int index = 0;
> +
> + if (!is_pci_subsystem(dev))
> + continue;
> +
> + igt_list_for_each_entry(dev2, &igt_devs.all, link) {
> + if (!is_pci_subsystem(dev2))
> + continue;
> +
> + if (dev2 == dev)
> + break;
> +
> + if (!strcasecmp(dev->vendor, dev2->vendor) &&
> + !strcasecmp(dev->device, dev2->device))
> + index++;
> + }
> +
> + dev->gpu_index = index;
> + }
> +}
> +
> /* Core scanning function.
> *
> * All scanned devices are kept inside igt_devs.all pointer array.
> @@ -657,6 +685,7 @@ static void scan_drm_devices(void)
> udev_unref(udev);
>
> sort_all_devices();
> + index_pci_devices();
>
> igt_list_for_each_entry(dev, &igt_devs.all, link) {
> struct igt_device *dev_dup = duplicate_device(dev);
> --
> 2.25.1
>
Yes, it is ok now.
Reviewed-by: Zbigniew Kempczyński <zbigniew.kempczynski@intel.com>
--
Zbigniew
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 17+ messages in thread
* Re: [igt-dev] [PATCH i-g-t 3/5] lib/igt_device_scan: Remember PCI card index after scanning
@ 2020-11-16 17:58 ` Zbigniew Kempczyński
0 siblings, 0 replies; 17+ messages in thread
From: Zbigniew Kempczyński @ 2020-11-16 17:58 UTC (permalink / raw)
To: Tvrtko Ursulin; +Cc: igt-dev, Intel-gfx, Petri Latvala, Tvrtko Ursulin
On Mon, Nov 16, 2020 at 05:26:51PM +0000, Tvrtko Ursulin wrote:
> From: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
>
> After devices are sorted post scanning, assing a card index to each so it
> can be easily accessed if PCI filter for a card needs to be printed out.
>
> v2:
> * Preserve existing pci:..card=N behaviour. (Zbigniew)
>
> Signed-off-by: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
> Cc: Petri Latvala <petri.latvala@intel.com>
> Cc: Zbigniew Kempczyński <zbigniew.kempczynski@intel.com>
> ---
> lib/igt_device_scan.c | 29 +++++++++++++++++++++++++++++
> 1 file changed, 29 insertions(+)
>
> diff --git a/lib/igt_device_scan.c b/lib/igt_device_scan.c
> index c0cd6757fc27..ecb8db297f86 100644
> --- a/lib/igt_device_scan.c
> +++ b/lib/igt_device_scan.c
> @@ -166,6 +166,7 @@ struct igt_device {
> char *vendor;
> char *device;
> char *pci_slot_name;
> + int gpu_index; /* For more than one GPU with same vendor and device. */
>
> struct igt_list_head link;
> };
> @@ -601,6 +602,33 @@ static void sort_all_devices(void)
> free(devs);
> }
>
> +static void index_pci_devices(void)
> +{
> + struct igt_device *dev;
> +
> + igt_list_for_each_entry(dev, &igt_devs.all, link) {
> + struct igt_device *dev2;
> + int index = 0;
> +
> + if (!is_pci_subsystem(dev))
> + continue;
> +
> + igt_list_for_each_entry(dev2, &igt_devs.all, link) {
> + if (!is_pci_subsystem(dev2))
> + continue;
> +
> + if (dev2 == dev)
> + break;
> +
> + if (!strcasecmp(dev->vendor, dev2->vendor) &&
> + !strcasecmp(dev->device, dev2->device))
> + index++;
> + }
> +
> + dev->gpu_index = index;
> + }
> +}
> +
> /* Core scanning function.
> *
> * All scanned devices are kept inside igt_devs.all pointer array.
> @@ -657,6 +685,7 @@ static void scan_drm_devices(void)
> udev_unref(udev);
>
> sort_all_devices();
> + index_pci_devices();
>
> igt_list_for_each_entry(dev, &igt_devs.all, link) {
> struct igt_device *dev_dup = duplicate_device(dev);
> --
> 2.25.1
>
Yes, it is ok now.
Reviewed-by: Zbigniew Kempczyński <zbigniew.kempczynski@intel.com>
--
Zbigniew
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply [flat|nested] 17+ messages in thread
* Re: [Intel-gfx] [igt-dev] [PATCH i-g-t 5/5] intel_gpu_top: Default GPU list to PCI mode
2020-11-16 17:26 ` [igt-dev] " Tvrtko Ursulin
@ 2020-11-16 18:40 ` Zbigniew Kempczyński
-1 siblings, 0 replies; 17+ messages in thread
From: Zbigniew Kempczyński @ 2020-11-16 18:40 UTC (permalink / raw)
To: Tvrtko Ursulin; +Cc: igt-dev, Intel-gfx
On Mon, Nov 16, 2020 at 05:26:53PM +0000, Tvrtko Ursulin wrote:
> From: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
>
> It is more obvious for the user to only shows filters for DRM master
> nodes since those are the ones that intel_gpu_top monitors.
>
> v2:
> * Filter prefix needs to be sys: when listing PCI devices.
>
> Signed-off-by: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
> ---
> tools/intel_gpu_top.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/tools/intel_gpu_top.c b/tools/intel_gpu_top.c
> index 07f88d555dc8..37b2141e784d 100644
> --- a/tools/intel_gpu_top.c
> +++ b/tools/intel_gpu_top.c
> @@ -1388,7 +1388,8 @@ int main(int argc, char **argv)
>
> if (list_device) {
> struct igt_devices_print_format fmt = {
> - .type = IGT_PRINT_USER
> + .type = IGT_PRINT_USER,
> + .option = IGT_PRINT_PCI,
> };
>
> igt_devices_print(&fmt);
> --
> 2.25.1
>
> _______________________________________________
> igt-dev mailing list
> igt-dev@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/igt-dev
Looks ok.
Reviewed-by: Zbigniew Kempczyński <zbigniew.kempczynski@intel.com>
--
Zbigniew
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 17+ messages in thread
* Re: [igt-dev] [PATCH i-g-t 5/5] intel_gpu_top: Default GPU list to PCI mode
@ 2020-11-16 18:40 ` Zbigniew Kempczyński
0 siblings, 0 replies; 17+ messages in thread
From: Zbigniew Kempczyński @ 2020-11-16 18:40 UTC (permalink / raw)
To: Tvrtko Ursulin; +Cc: igt-dev, Intel-gfx, Tvrtko Ursulin
On Mon, Nov 16, 2020 at 05:26:53PM +0000, Tvrtko Ursulin wrote:
> From: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
>
> It is more obvious for the user to only shows filters for DRM master
> nodes since those are the ones that intel_gpu_top monitors.
>
> v2:
> * Filter prefix needs to be sys: when listing PCI devices.
>
> Signed-off-by: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
> ---
> tools/intel_gpu_top.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/tools/intel_gpu_top.c b/tools/intel_gpu_top.c
> index 07f88d555dc8..37b2141e784d 100644
> --- a/tools/intel_gpu_top.c
> +++ b/tools/intel_gpu_top.c
> @@ -1388,7 +1388,8 @@ int main(int argc, char **argv)
>
> if (list_device) {
> struct igt_devices_print_format fmt = {
> - .type = IGT_PRINT_USER
> + .type = IGT_PRINT_USER,
> + .option = IGT_PRINT_PCI,
> };
>
> igt_devices_print(&fmt);
> --
> 2.25.1
>
> _______________________________________________
> igt-dev mailing list
> igt-dev@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/igt-dev
Looks ok.
Reviewed-by: Zbigniew Kempczyński <zbigniew.kempczynski@intel.com>
--
Zbigniew
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply [flat|nested] 17+ messages in thread
* [igt-dev] ✓ Fi.CI.BAT: success for series starting with [i-g-t,1/5] intel_gpu_top: User friendly device listing
2020-11-16 17:26 ` [igt-dev] " Tvrtko Ursulin
` (4 preceding siblings ...)
(?)
@ 2020-11-16 18:42 ` Patchwork
-1 siblings, 0 replies; 17+ messages in thread
From: Patchwork @ 2020-11-16 18:42 UTC (permalink / raw)
To: Tvrtko Ursulin; +Cc: igt-dev
[-- Attachment #1.1: Type: text/plain, Size: 5295 bytes --]
== Series Details ==
Series: series starting with [i-g-t,1/5] intel_gpu_top: User friendly device listing
URL : https://patchwork.freedesktop.org/series/83893/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_9338 -> IGTPW_5173
====================================================
Summary
-------
**WARNING**
Minor unknown changes coming with IGTPW_5173 need to be verified
manually.
If you think the reported changes have nothing to do with the changes
introduced in IGTPW_5173, please notify your bug team to allow them
to document this new failure mode, which will reduce false positives in CI.
External URL: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5173/index.html
Possible new issues
-------------------
Here are the unknown changes that may have been introduced in IGTPW_5173:
### IGT changes ###
#### Warnings ####
* igt@i915_selftest@live@gt_pm:
- fi-tgl-y: [DMESG-FAIL][1] ([i915#1759]) -> [DMESG-FAIL][2]
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9338/fi-tgl-y/igt@i915_selftest@live@gt_pm.html
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5173/fi-tgl-y/igt@i915_selftest@live@gt_pm.html
Known issues
------------
Here are the changes found in IGTPW_5173 that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@gem_huc_copy@huc-copy:
- fi-tgl-y: [PASS][3] -> [DMESG-WARN][4] ([i915#402])
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9338/fi-tgl-y/igt@gem_huc_copy@huc-copy.html
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5173/fi-tgl-y/igt@gem_huc_copy@huc-copy.html
* igt@i915_module_load@reload:
- fi-skl-lmem: [PASS][5] -> [DMESG-WARN][6] ([i915#2605])
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9338/fi-skl-lmem/igt@i915_module_load@reload.html
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5173/fi-skl-lmem/igt@i915_module_load@reload.html
* igt@i915_pm_rpm@basic-pci-d3-state:
- fi-bsw-kefka: [PASS][7] -> [DMESG-WARN][8] ([i915#1982])
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9338/fi-bsw-kefka/igt@i915_pm_rpm@basic-pci-d3-state.html
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5173/fi-bsw-kefka/igt@i915_pm_rpm@basic-pci-d3-state.html
* igt@kms_cursor_legacy@basic-flip-after-cursor-atomic:
- fi-icl-u2: [PASS][9] -> [DMESG-WARN][10] ([i915#1982]) +2 similar issues
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9338/fi-icl-u2/igt@kms_cursor_legacy@basic-flip-after-cursor-atomic.html
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5173/fi-icl-u2/igt@kms_cursor_legacy@basic-flip-after-cursor-atomic.html
#### Possible fixes ####
* igt@gem_close_race@basic-threads:
- fi-tgl-y: [DMESG-WARN][11] ([i915#402]) -> [PASS][12] +1 similar issue
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9338/fi-tgl-y/igt@gem_close_race@basic-threads.html
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5173/fi-tgl-y/igt@gem_close_race@basic-threads.html
* igt@i915_selftest@live@gt_heartbeat:
- {fi-tgl-dsi}: [DMESG-FAIL][13] ([i915#2601]) -> [PASS][14]
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9338/fi-tgl-dsi/igt@i915_selftest@live@gt_heartbeat.html
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5173/fi-tgl-dsi/igt@i915_selftest@live@gt_heartbeat.html
* igt@kms_busy@basic@flip:
- {fi-tgl-dsi}: [DMESG-WARN][15] ([i915#1982]) -> [PASS][16]
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9338/fi-tgl-dsi/igt@kms_busy@basic@flip.html
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5173/fi-tgl-dsi/igt@kms_busy@basic@flip.html
* igt@kms_cursor_legacy@basic-busy-flip-before-cursor-atomic:
- fi-byt-j1900: [DMESG-WARN][17] ([i915#1982]) -> [PASS][18] +1 similar issue
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9338/fi-byt-j1900/igt@kms_cursor_legacy@basic-busy-flip-before-cursor-atomic.html
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5173/fi-byt-j1900/igt@kms_cursor_legacy@basic-busy-flip-before-cursor-atomic.html
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[i915#1759]: https://gitlab.freedesktop.org/drm/intel/issues/1759
[i915#1982]: https://gitlab.freedesktop.org/drm/intel/issues/1982
[i915#2601]: https://gitlab.freedesktop.org/drm/intel/issues/2601
[i915#2605]: https://gitlab.freedesktop.org/drm/intel/issues/2605
[i915#402]: https://gitlab.freedesktop.org/drm/intel/issues/402
Participating hosts (46 -> 40)
------------------------------
Missing (6): fi-kbl-soraka fi-ilk-m540 fi-hsw-4200u fi-bsw-cyan fi-ctg-p8600 fi-bdw-samus
Build changes
-------------
* CI: CI-20190529 -> None
* IGT: IGT_5854 -> IGTPW_5173
CI-20190529: 20190529
CI_DRM_9338: 994881297675ccca3caf7348ee0dc36cdbd47cef @ git://anongit.freedesktop.org/gfx-ci/linux
IGTPW_5173: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5173/index.html
IGT_5854: 5155c2bd05e03fec86fb9c97d65a4f69b44c3678 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5173/index.html
[-- Attachment #1.2: Type: text/html, Size: 6399 bytes --]
[-- Attachment #2: Type: text/plain, Size: 154 bytes --]
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply [flat|nested] 17+ messages in thread
* Re: [Intel-gfx] [PATCH i-g-t 4/5] lsgpu: Add filter type print-out selection
2020-11-16 17:26 ` [igt-dev] " Tvrtko Ursulin
@ 2020-11-16 18:45 ` Zbigniew Kempczyński
-1 siblings, 0 replies; 17+ messages in thread
From: Zbigniew Kempczyński @ 2020-11-16 18:45 UTC (permalink / raw)
To: Tvrtko Ursulin; +Cc: igt-dev, Intel-gfx
On Mon, Nov 16, 2020 at 05:26:52PM +0000, Tvrtko Ursulin wrote:
> From: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
>
> In the previous patch we switched the lsgpu output to a short and user
> friendly format but some users will need a shorthand for getting other
> types of device selection filters than the defaut drm.
>
> Add some command line switches to enable this:
>
> $ lsgpu
> card0 8086:193B drm:/dev/dri/card0
> └─renderD128 drm:/dev/dri/renderD128
>
> $ lsgpu --sysfs
> card0 8086:193B sys:/sys/devices/pci0000:00/0000:00:02.0/drm/card0
> └─renderD128 sys:/sys/devices/pci0000:00/0000:00:02.0/drm/renderD128
>
> $ lsgpu --pci
> card0 8086:193B pci:vendor=8086,device=193B,card=0
> └─renderD128
>
> v2:
> * Fix pci filter format.
>
> Signed-off-by: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
> Suggested-by: Zbigniew Kempczyński <zbigniew.kempczynski@intel.com>
> Cc: Petri Latvala <petri.latvala@intel.com>
> ---
> lib/igt_device_scan.c | 83 ++++++++++++++++++++++++++++++++-----------
> lib/igt_device_scan.h | 15 ++++++--
> tools/intel_gpu_top.c | 6 +++-
> tools/lsgpu.c | 32 +++++++++++++----
> 4 files changed, 106 insertions(+), 30 deletions(-)
>
> diff --git a/lib/igt_device_scan.c b/lib/igt_device_scan.c
> index ecb8db297f86..e97f7163ba70 100644
> --- a/lib/igt_device_scan.c
> +++ b/lib/igt_device_scan.c
> @@ -777,7 +777,9 @@ static bool __check_empty(struct igt_list_head *view)
> return false;
> }
>
> -static void igt_devs_print_simple(struct igt_list_head *view)
> +static void
> +igt_devs_print_simple(struct igt_list_head *view,
> + const struct igt_devices_print_format *fmt)
> {
> struct igt_device *dev;
>
> @@ -821,7 +823,38 @@ __find_pci(struct igt_list_head *view, const char *drm)
> return NULL;
> }
>
> -static void igt_devs_print_user(struct igt_list_head *view)
> +static void __print_filter(char *buf, int len,
> + const struct igt_devices_print_format *fmt,
> + struct igt_device *dev,
> + bool render)
> +{
> + int ret;
> +
> + switch (fmt->option) {
> + case IGT_PRINT_DRM:
> + ret = snprintf(buf, len, "drm:%s",
> + render ? dev->drm_render : dev->drm_card);
> + igt_assert(ret < len);
> + break;
> + case IGT_PRINT_SYSFS:
> + ret = snprintf(buf, len, "sys:%s", dev->syspath);
> + igt_assert(ret < len);
> + break;
> + case IGT_PRINT_PCI:
> + if (!render) {
> + ret = snprintf(buf, len,
> + "pci:vendor=%s,device=%s,card=%d",
> + dev->vendor, dev->device,
> + dev->gpu_index);
> + igt_assert(ret < len);
> + }
> + break;
> + };
You could leave single assert after the switch but this is minor nit.
> +}
> +
> +static void
> +igt_devs_print_user(struct igt_list_head *view,
> + const struct igt_devices_print_format *fmt)
> {
> struct igt_device *dev;
>
> @@ -834,7 +867,6 @@ static void igt_devs_print_user(struct igt_list_head *view)
> struct igt_device *dev2;
> char filter[256];
> char *drm_name;
> - int ret;
>
> if (!is_drm_subsystem(dev))
> continue;
> @@ -845,16 +877,21 @@ static void igt_devs_print_user(struct igt_list_head *view)
> if (!drm_name || !*++drm_name)
> continue;
>
> - ret = snprintf(filter, sizeof(filter), "drm:%s", dev->drm_card);
> - igt_assert(ret < sizeof(filter));
> -
> pci_dev = __find_pci(view, dev->drm_card);
> - if (pci_dev)
> +
> + if (fmt->option == IGT_PRINT_PCI && !pci_dev)
> + continue;
> +
> + if (pci_dev) {
> + __print_filter(filter, sizeof(filter), fmt, pci_dev,
> + false);
> printf("%-24s%4s:%4s %s\n",
> drm_name, pci_dev->vendor, pci_dev->device,
> filter);
> - else
> + } else {
> + __print_filter(filter, sizeof(filter), fmt, dev, false);
> printf("%-24s %s\n", drm_name, filter);
> + }
>
> num_children = 0;
> igt_list_for_each_entry(dev2, view, link) {
> @@ -877,13 +914,15 @@ static void igt_devs_print_user(struct igt_list_head *view)
> if (!drm_name || !*++drm_name)
> continue;
>
> - ret = snprintf(filter, sizeof(filter), "drm:%s",
> - dev2->drm_render);
> - igt_assert(ret < sizeof(filter));
> -
> - printf("%s%-22s %s\n",
> - (++i == num_children) ? "└─" : "├─",
> - drm_name, filter);
> + printf("%s%-22s",
> + (++i == num_children) ? "└─" : "├─", drm_name);
> + if (fmt->option != IGT_PRINT_PCI) {
> + __print_filter(filter, sizeof(filter), fmt,
> + dev2, true);
> + printf(" %s\n", filter);
> + } else {
> + printf("\n");
> + }
> }
> }
> }
> @@ -908,7 +947,10 @@ static void print_ht(GHashTable *ht)
> g_list_free(keys);
> }
>
> -static void igt_devs_print_detail(struct igt_list_head *view)
> +static void
> +igt_devs_print_detail(struct igt_list_head *view,
> + const struct igt_devices_print_format *fmt)
> +
> {
> struct igt_device *dev;
>
> @@ -932,7 +974,8 @@ static void igt_devs_print_detail(struct igt_list_head *view)
> }
>
> static struct print_func {
> - void (*prn)(struct igt_list_head *view);
> + void (*prn)(struct igt_list_head *view,
> + const struct igt_devices_print_format *);
> } print_functions[] = {
> [IGT_PRINT_SIMPLE] = { .prn = igt_devs_print_simple },
> [IGT_PRINT_DETAIL] = { .prn = igt_devs_print_detail },
> @@ -941,15 +984,15 @@ static struct print_func {
>
> /**
> * igt_devices_print
> - * @printtype: IGT_PRINT_SIMPLE or IGT_PRINT_DETAIL
> + * @fmt: Print format as specified by struct igt_devices_print_format
> *
> * Function can be used by external tool to print device array in simple
> * or detailed form. This function is added here to avoid exposing
> * internal implementation data structures.
> */
> -void igt_devices_print(enum igt_devices_print_type printtype)
> +void igt_devices_print(const struct igt_devices_print_format *fmt)
> {
> - print_functions[printtype].prn(&igt_devs.filtered);
> + print_functions[fmt->type].prn(&igt_devs.filtered, fmt);
> }
>
> /**
> diff --git a/lib/igt_device_scan.h b/lib/igt_device_scan.h
> index 9822c22cb69c..bb4be72345fb 100644
> --- a/lib/igt_device_scan.h
> +++ b/lib/igt_device_scan.h
> @@ -35,11 +35,22 @@
> #include <unistd.h>
>
> enum igt_devices_print_type {
> - IGT_PRINT_SIMPLE,
> + IGT_PRINT_SIMPLE = 0,
> IGT_PRINT_DETAIL,
> IGT_PRINT_USER, /* End user friendly. */
> };
>
> +enum igt_devices_print_option {
> + IGT_PRINT_DRM = 0,
> + IGT_PRINT_SYSFS,
> + IGT_PRINT_PCI,
> +};
> +
> +struct igt_devices_print_format {
> + enum igt_devices_print_type type;
> + enum igt_devices_print_option option;
> +};
> +
> #define INTEGRATED_I915_GPU_PCI_ID "0000:00:02.0"
> #define PCI_SLOT_NAME_SIZE 12
> struct igt_device_card {
> @@ -51,7 +62,7 @@ struct igt_device_card {
>
> void igt_devices_scan(bool force);
>
> -void igt_devices_print(enum igt_devices_print_type printtype);
> +void igt_devices_print(const struct igt_devices_print_format *fmt);
> void igt_devices_print_vendors(void);
> void igt_device_print_filter_types(void);
>
> diff --git a/tools/intel_gpu_top.c b/tools/intel_gpu_top.c
> index 5230472d2af4..07f88d555dc8 100644
> --- a/tools/intel_gpu_top.c
> +++ b/tools/intel_gpu_top.c
> @@ -1387,7 +1387,11 @@ int main(int argc, char **argv)
> igt_devices_scan(false);
>
> if (list_device) {
> - igt_devices_print(IGT_PRINT_USER);
> + struct igt_devices_print_format fmt = {
> + .type = IGT_PRINT_USER
> + };
> +
> + igt_devices_print(&fmt);
> goto exit;
> }
>
> diff --git a/tools/lsgpu.c b/tools/lsgpu.c
> index 3b234b73361a..169ab0c29e50 100644
> --- a/tools/lsgpu.c
> +++ b/tools/lsgpu.c
> @@ -91,7 +91,11 @@ static const char *usage_str =
> " -v, --list-vendors List recognized vendors\n"
> " -l, --list-filter-types List registered device filters types\n"
> " -d, --device filter Device filter, can be given multiple times\n"
> - " -h, --help Show this help message and exit\n";
> + " -h, --help Show this help message and exit\n"
> + "\nOptions valid for default print out mode only:\n"
> + " --drm Show DRM filters (default) for each device\n"
> + " --sysfs Show sysfs filters for each device\n"
> + " --pci Show PCI filters for each device\n";
>
> static void test_device_open(struct igt_device_card *card)
> {
> @@ -153,6 +157,9 @@ static char *get_device_from_rc(void)
> int main(int argc, char *argv[])
> {
> static struct option long_options[] = {
> + {"drm", no_argument, NULL, 0},
> + {"sysfs", no_argument, NULL, 1},
> + {"pci", no_argument, NULL, 2},
> {"print-simple", no_argument, NULL, OPT_PRINT_SIMPLE},
> {"print-detail", no_argument, NULL, OPT_PRINT_DETAIL},
> {"list-vendors", no_argument, NULL, OPT_LIST_VENDORS},
> @@ -163,17 +170,19 @@ int main(int argc, char *argv[])
> };
> int c, index = 0;
> char *env_device = NULL, *opt_device = NULL, *rc_device = NULL;
> - enum igt_devices_print_type printtype = IGT_PRINT_USER;
> + struct igt_devices_print_format fmt = {
> + .type = IGT_PRINT_USER,
> + };
>
> while ((c = getopt_long(argc, argv, "spvld:h",
> long_options, &index)) != -1) {
> switch(c) {
>
> case OPT_PRINT_SIMPLE:
> - printtype = IGT_PRINT_SIMPLE;
> + fmt.type = IGT_PRINT_SIMPLE;
> break;
> case OPT_PRINT_DETAIL:
> - printtype = IGT_PRINT_DETAIL;
> + fmt.type = IGT_PRINT_DETAIL;
> break;
> case OPT_LIST_VENDORS:
> g_show_vendors = true;
> @@ -187,6 +196,15 @@ int main(int argc, char *argv[])
> case OPT_HELP:
> g_help = true;
> break;
> + case 0:
> + fmt.option = IGT_PRINT_DRM;
> + break;
> + case 1:
> + fmt.option = IGT_PRINT_SYSFS;
> + break;
> + case 2:
> + fmt.option = IGT_PRINT_PCI;
> + break;
> }
> }
>
> @@ -239,14 +257,14 @@ int main(int argc, char *argv[])
> printf("Device detail:\n");
> print_card(&card);
> test_device_open(&card);
> - if (printtype == IGT_PRINT_DETAIL) {
> + if (fmt.type == IGT_PRINT_DETAIL) {
> printf("\n");
> - igt_devices_print(printtype);
> + igt_devices_print(&fmt);
> }
> printf("-------------------------------------------\n");
>
> } else {
> - igt_devices_print(printtype);
> + igt_devices_print(&fmt);
> }
>
> free(rc_device);
> --
> 2.25.1
>
Ok, haven't tracked other issues and LGTM:
Reviewed-by: Zbigniew Kempczyński <zbigniew.kempczynski@intel.com>
--
Zbigniew
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 17+ messages in thread
* Re: [igt-dev] [PATCH i-g-t 4/5] lsgpu: Add filter type print-out selection
@ 2020-11-16 18:45 ` Zbigniew Kempczyński
0 siblings, 0 replies; 17+ messages in thread
From: Zbigniew Kempczyński @ 2020-11-16 18:45 UTC (permalink / raw)
To: Tvrtko Ursulin; +Cc: igt-dev, Intel-gfx, Petri Latvala, Tvrtko Ursulin
On Mon, Nov 16, 2020 at 05:26:52PM +0000, Tvrtko Ursulin wrote:
> From: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
>
> In the previous patch we switched the lsgpu output to a short and user
> friendly format but some users will need a shorthand for getting other
> types of device selection filters than the defaut drm.
>
> Add some command line switches to enable this:
>
> $ lsgpu
> card0 8086:193B drm:/dev/dri/card0
> └─renderD128 drm:/dev/dri/renderD128
>
> $ lsgpu --sysfs
> card0 8086:193B sys:/sys/devices/pci0000:00/0000:00:02.0/drm/card0
> └─renderD128 sys:/sys/devices/pci0000:00/0000:00:02.0/drm/renderD128
>
> $ lsgpu --pci
> card0 8086:193B pci:vendor=8086,device=193B,card=0
> └─renderD128
>
> v2:
> * Fix pci filter format.
>
> Signed-off-by: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
> Suggested-by: Zbigniew Kempczyński <zbigniew.kempczynski@intel.com>
> Cc: Petri Latvala <petri.latvala@intel.com>
> ---
> lib/igt_device_scan.c | 83 ++++++++++++++++++++++++++++++++-----------
> lib/igt_device_scan.h | 15 ++++++--
> tools/intel_gpu_top.c | 6 +++-
> tools/lsgpu.c | 32 +++++++++++++----
> 4 files changed, 106 insertions(+), 30 deletions(-)
>
> diff --git a/lib/igt_device_scan.c b/lib/igt_device_scan.c
> index ecb8db297f86..e97f7163ba70 100644
> --- a/lib/igt_device_scan.c
> +++ b/lib/igt_device_scan.c
> @@ -777,7 +777,9 @@ static bool __check_empty(struct igt_list_head *view)
> return false;
> }
>
> -static void igt_devs_print_simple(struct igt_list_head *view)
> +static void
> +igt_devs_print_simple(struct igt_list_head *view,
> + const struct igt_devices_print_format *fmt)
> {
> struct igt_device *dev;
>
> @@ -821,7 +823,38 @@ __find_pci(struct igt_list_head *view, const char *drm)
> return NULL;
> }
>
> -static void igt_devs_print_user(struct igt_list_head *view)
> +static void __print_filter(char *buf, int len,
> + const struct igt_devices_print_format *fmt,
> + struct igt_device *dev,
> + bool render)
> +{
> + int ret;
> +
> + switch (fmt->option) {
> + case IGT_PRINT_DRM:
> + ret = snprintf(buf, len, "drm:%s",
> + render ? dev->drm_render : dev->drm_card);
> + igt_assert(ret < len);
> + break;
> + case IGT_PRINT_SYSFS:
> + ret = snprintf(buf, len, "sys:%s", dev->syspath);
> + igt_assert(ret < len);
> + break;
> + case IGT_PRINT_PCI:
> + if (!render) {
> + ret = snprintf(buf, len,
> + "pci:vendor=%s,device=%s,card=%d",
> + dev->vendor, dev->device,
> + dev->gpu_index);
> + igt_assert(ret < len);
> + }
> + break;
> + };
You could leave single assert after the switch but this is minor nit.
> +}
> +
> +static void
> +igt_devs_print_user(struct igt_list_head *view,
> + const struct igt_devices_print_format *fmt)
> {
> struct igt_device *dev;
>
> @@ -834,7 +867,6 @@ static void igt_devs_print_user(struct igt_list_head *view)
> struct igt_device *dev2;
> char filter[256];
> char *drm_name;
> - int ret;
>
> if (!is_drm_subsystem(dev))
> continue;
> @@ -845,16 +877,21 @@ static void igt_devs_print_user(struct igt_list_head *view)
> if (!drm_name || !*++drm_name)
> continue;
>
> - ret = snprintf(filter, sizeof(filter), "drm:%s", dev->drm_card);
> - igt_assert(ret < sizeof(filter));
> -
> pci_dev = __find_pci(view, dev->drm_card);
> - if (pci_dev)
> +
> + if (fmt->option == IGT_PRINT_PCI && !pci_dev)
> + continue;
> +
> + if (pci_dev) {
> + __print_filter(filter, sizeof(filter), fmt, pci_dev,
> + false);
> printf("%-24s%4s:%4s %s\n",
> drm_name, pci_dev->vendor, pci_dev->device,
> filter);
> - else
> + } else {
> + __print_filter(filter, sizeof(filter), fmt, dev, false);
> printf("%-24s %s\n", drm_name, filter);
> + }
>
> num_children = 0;
> igt_list_for_each_entry(dev2, view, link) {
> @@ -877,13 +914,15 @@ static void igt_devs_print_user(struct igt_list_head *view)
> if (!drm_name || !*++drm_name)
> continue;
>
> - ret = snprintf(filter, sizeof(filter), "drm:%s",
> - dev2->drm_render);
> - igt_assert(ret < sizeof(filter));
> -
> - printf("%s%-22s %s\n",
> - (++i == num_children) ? "└─" : "├─",
> - drm_name, filter);
> + printf("%s%-22s",
> + (++i == num_children) ? "└─" : "├─", drm_name);
> + if (fmt->option != IGT_PRINT_PCI) {
> + __print_filter(filter, sizeof(filter), fmt,
> + dev2, true);
> + printf(" %s\n", filter);
> + } else {
> + printf("\n");
> + }
> }
> }
> }
> @@ -908,7 +947,10 @@ static void print_ht(GHashTable *ht)
> g_list_free(keys);
> }
>
> -static void igt_devs_print_detail(struct igt_list_head *view)
> +static void
> +igt_devs_print_detail(struct igt_list_head *view,
> + const struct igt_devices_print_format *fmt)
> +
> {
> struct igt_device *dev;
>
> @@ -932,7 +974,8 @@ static void igt_devs_print_detail(struct igt_list_head *view)
> }
>
> static struct print_func {
> - void (*prn)(struct igt_list_head *view);
> + void (*prn)(struct igt_list_head *view,
> + const struct igt_devices_print_format *);
> } print_functions[] = {
> [IGT_PRINT_SIMPLE] = { .prn = igt_devs_print_simple },
> [IGT_PRINT_DETAIL] = { .prn = igt_devs_print_detail },
> @@ -941,15 +984,15 @@ static struct print_func {
>
> /**
> * igt_devices_print
> - * @printtype: IGT_PRINT_SIMPLE or IGT_PRINT_DETAIL
> + * @fmt: Print format as specified by struct igt_devices_print_format
> *
> * Function can be used by external tool to print device array in simple
> * or detailed form. This function is added here to avoid exposing
> * internal implementation data structures.
> */
> -void igt_devices_print(enum igt_devices_print_type printtype)
> +void igt_devices_print(const struct igt_devices_print_format *fmt)
> {
> - print_functions[printtype].prn(&igt_devs.filtered);
> + print_functions[fmt->type].prn(&igt_devs.filtered, fmt);
> }
>
> /**
> diff --git a/lib/igt_device_scan.h b/lib/igt_device_scan.h
> index 9822c22cb69c..bb4be72345fb 100644
> --- a/lib/igt_device_scan.h
> +++ b/lib/igt_device_scan.h
> @@ -35,11 +35,22 @@
> #include <unistd.h>
>
> enum igt_devices_print_type {
> - IGT_PRINT_SIMPLE,
> + IGT_PRINT_SIMPLE = 0,
> IGT_PRINT_DETAIL,
> IGT_PRINT_USER, /* End user friendly. */
> };
>
> +enum igt_devices_print_option {
> + IGT_PRINT_DRM = 0,
> + IGT_PRINT_SYSFS,
> + IGT_PRINT_PCI,
> +};
> +
> +struct igt_devices_print_format {
> + enum igt_devices_print_type type;
> + enum igt_devices_print_option option;
> +};
> +
> #define INTEGRATED_I915_GPU_PCI_ID "0000:00:02.0"
> #define PCI_SLOT_NAME_SIZE 12
> struct igt_device_card {
> @@ -51,7 +62,7 @@ struct igt_device_card {
>
> void igt_devices_scan(bool force);
>
> -void igt_devices_print(enum igt_devices_print_type printtype);
> +void igt_devices_print(const struct igt_devices_print_format *fmt);
> void igt_devices_print_vendors(void);
> void igt_device_print_filter_types(void);
>
> diff --git a/tools/intel_gpu_top.c b/tools/intel_gpu_top.c
> index 5230472d2af4..07f88d555dc8 100644
> --- a/tools/intel_gpu_top.c
> +++ b/tools/intel_gpu_top.c
> @@ -1387,7 +1387,11 @@ int main(int argc, char **argv)
> igt_devices_scan(false);
>
> if (list_device) {
> - igt_devices_print(IGT_PRINT_USER);
> + struct igt_devices_print_format fmt = {
> + .type = IGT_PRINT_USER
> + };
> +
> + igt_devices_print(&fmt);
> goto exit;
> }
>
> diff --git a/tools/lsgpu.c b/tools/lsgpu.c
> index 3b234b73361a..169ab0c29e50 100644
> --- a/tools/lsgpu.c
> +++ b/tools/lsgpu.c
> @@ -91,7 +91,11 @@ static const char *usage_str =
> " -v, --list-vendors List recognized vendors\n"
> " -l, --list-filter-types List registered device filters types\n"
> " -d, --device filter Device filter, can be given multiple times\n"
> - " -h, --help Show this help message and exit\n";
> + " -h, --help Show this help message and exit\n"
> + "\nOptions valid for default print out mode only:\n"
> + " --drm Show DRM filters (default) for each device\n"
> + " --sysfs Show sysfs filters for each device\n"
> + " --pci Show PCI filters for each device\n";
>
> static void test_device_open(struct igt_device_card *card)
> {
> @@ -153,6 +157,9 @@ static char *get_device_from_rc(void)
> int main(int argc, char *argv[])
> {
> static struct option long_options[] = {
> + {"drm", no_argument, NULL, 0},
> + {"sysfs", no_argument, NULL, 1},
> + {"pci", no_argument, NULL, 2},
> {"print-simple", no_argument, NULL, OPT_PRINT_SIMPLE},
> {"print-detail", no_argument, NULL, OPT_PRINT_DETAIL},
> {"list-vendors", no_argument, NULL, OPT_LIST_VENDORS},
> @@ -163,17 +170,19 @@ int main(int argc, char *argv[])
> };
> int c, index = 0;
> char *env_device = NULL, *opt_device = NULL, *rc_device = NULL;
> - enum igt_devices_print_type printtype = IGT_PRINT_USER;
> + struct igt_devices_print_format fmt = {
> + .type = IGT_PRINT_USER,
> + };
>
> while ((c = getopt_long(argc, argv, "spvld:h",
> long_options, &index)) != -1) {
> switch(c) {
>
> case OPT_PRINT_SIMPLE:
> - printtype = IGT_PRINT_SIMPLE;
> + fmt.type = IGT_PRINT_SIMPLE;
> break;
> case OPT_PRINT_DETAIL:
> - printtype = IGT_PRINT_DETAIL;
> + fmt.type = IGT_PRINT_DETAIL;
> break;
> case OPT_LIST_VENDORS:
> g_show_vendors = true;
> @@ -187,6 +196,15 @@ int main(int argc, char *argv[])
> case OPT_HELP:
> g_help = true;
> break;
> + case 0:
> + fmt.option = IGT_PRINT_DRM;
> + break;
> + case 1:
> + fmt.option = IGT_PRINT_SYSFS;
> + break;
> + case 2:
> + fmt.option = IGT_PRINT_PCI;
> + break;
> }
> }
>
> @@ -239,14 +257,14 @@ int main(int argc, char *argv[])
> printf("Device detail:\n");
> print_card(&card);
> test_device_open(&card);
> - if (printtype == IGT_PRINT_DETAIL) {
> + if (fmt.type == IGT_PRINT_DETAIL) {
> printf("\n");
> - igt_devices_print(printtype);
> + igt_devices_print(&fmt);
> }
> printf("-------------------------------------------\n");
>
> } else {
> - igt_devices_print(printtype);
> + igt_devices_print(&fmt);
> }
>
> free(rc_device);
> --
> 2.25.1
>
Ok, haven't tracked other issues and LGTM:
Reviewed-by: Zbigniew Kempczyński <zbigniew.kempczynski@intel.com>
--
Zbigniew
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply [flat|nested] 17+ messages in thread
* [igt-dev] ✗ Fi.CI.IGT: failure for series starting with [i-g-t,1/5] intel_gpu_top: User friendly device listing
2020-11-16 17:26 ` [igt-dev] " Tvrtko Ursulin
` (5 preceding siblings ...)
(?)
@ 2020-11-17 0:14 ` Patchwork
-1 siblings, 0 replies; 17+ messages in thread
From: Patchwork @ 2020-11-17 0:14 UTC (permalink / raw)
To: Tvrtko Ursulin; +Cc: igt-dev
[-- Attachment #1.1: Type: text/plain, Size: 24116 bytes --]
== Series Details ==
Series: series starting with [i-g-t,1/5] intel_gpu_top: User friendly device listing
URL : https://patchwork.freedesktop.org/series/83893/
State : failure
== Summary ==
CI Bug Log - changes from CI_DRM_9338_full -> IGTPW_5173_full
====================================================
Summary
-------
**FAILURE**
Serious unknown changes coming with IGTPW_5173_full absolutely need to be
verified manually.
If you think the reported changes have nothing to do with the changes
introduced in IGTPW_5173_full, please notify your bug team to allow them
to document this new failure mode, which will reduce false positives in CI.
External URL: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5173/index.html
Possible new issues
-------------------
Here are the unknown changes that may have been introduced in IGTPW_5173_full:
### IGT changes ###
#### Possible regressions ####
* igt@gem_exec_nop@basic-sequential:
- shard-hsw: [PASS][1] -> [FAIL][2]
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9338/shard-hsw2/igt@gem_exec_nop@basic-sequential.html
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5173/shard-hsw6/igt@gem_exec_nop@basic-sequential.html
#### Warnings ####
* igt@runner@aborted:
- shard-hsw: [FAIL][3] ([i915#2295]) -> ([FAIL][4], [FAIL][5]) ([fdo#109271] / [i915#2295])
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9338/shard-hsw2/igt@runner@aborted.html
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5173/shard-hsw6/igt@runner@aborted.html
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5173/shard-hsw2/igt@runner@aborted.html
Known issues
------------
Here are the changes found in IGTPW_5173_full that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@core_hotunplug@hotrebind-lateclose:
- shard-snb: [PASS][6] -> [INCOMPLETE][7] ([i915#1037])
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9338/shard-snb6/igt@core_hotunplug@hotrebind-lateclose.html
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5173/shard-snb5/igt@core_hotunplug@hotrebind-lateclose.html
* igt@gem_exec_reloc@basic-many-active@rcs0:
- shard-glk: [PASS][8] -> [FAIL][9] ([i915#2389])
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9338/shard-glk1/igt@gem_exec_reloc@basic-many-active@rcs0.html
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5173/shard-glk8/igt@gem_exec_reloc@basic-many-active@rcs0.html
* igt@gem_exec_whisper@basic-contexts-all:
- shard-glk: [PASS][10] -> [DMESG-WARN][11] ([i915#118] / [i915#95]) +1 similar issue
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9338/shard-glk2/igt@gem_exec_whisper@basic-contexts-all.html
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5173/shard-glk8/igt@gem_exec_whisper@basic-contexts-all.html
* igt@kms_big_fb@linear-64bpp-rotate-180:
- shard-kbl: [PASS][12] -> [DMESG-WARN][13] ([i915#1982]) +2 similar issues
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9338/shard-kbl7/igt@kms_big_fb@linear-64bpp-rotate-180.html
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5173/shard-kbl7/igt@kms_big_fb@linear-64bpp-rotate-180.html
* igt@kms_cursor_edge_walk@pipe-c-256x256-right-edge:
- shard-apl: [PASS][14] -> [DMESG-WARN][15] ([i915#1635] / [i915#1982]) +4 similar issues
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9338/shard-apl7/igt@kms_cursor_edge_walk@pipe-c-256x256-right-edge.html
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5173/shard-apl6/igt@kms_cursor_edge_walk@pipe-c-256x256-right-edge.html
* igt@kms_cursor_legacy@2x-long-flip-vs-cursor-legacy:
- shard-glk: [PASS][16] -> [DMESG-WARN][17] ([i915#1982]) +6 similar issues
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9338/shard-glk3/igt@kms_cursor_legacy@2x-long-flip-vs-cursor-legacy.html
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5173/shard-glk3/igt@kms_cursor_legacy@2x-long-flip-vs-cursor-legacy.html
* igt@kms_cursor_legacy@flip-vs-cursor-crc-legacy:
- shard-tglb: [PASS][18] -> [FAIL][19] ([i915#2346])
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9338/shard-tglb3/igt@kms_cursor_legacy@flip-vs-cursor-crc-legacy.html
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5173/shard-tglb7/igt@kms_cursor_legacy@flip-vs-cursor-crc-legacy.html
* igt@kms_fbcon_fbt@fbc-suspend:
- shard-apl: [PASS][20] -> [INCOMPLETE][21] ([i915#1635] / [i915#1982] / [i915#2635])
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9338/shard-apl1/igt@kms_fbcon_fbt@fbc-suspend.html
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5173/shard-apl7/igt@kms_fbcon_fbt@fbc-suspend.html
- shard-glk: [PASS][22] -> [INCOMPLETE][23] ([i915#2635])
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9338/shard-glk3/igt@kms_fbcon_fbt@fbc-suspend.html
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5173/shard-glk5/igt@kms_fbcon_fbt@fbc-suspend.html
* igt@kms_flip@2x-flip-vs-suspend-interruptible@ab-vga1-hdmi-a1:
- shard-hsw: [PASS][24] -> [INCOMPLETE][25] ([i915#2637]) +1 similar issue
[24]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9338/shard-hsw4/igt@kms_flip@2x-flip-vs-suspend-interruptible@ab-vga1-hdmi-a1.html
[25]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5173/shard-hsw2/igt@kms_flip@2x-flip-vs-suspend-interruptible@ab-vga1-hdmi-a1.html
* igt@kms_frontbuffer_tracking@fbc-suspend:
- shard-kbl: [PASS][26] -> [DMESG-WARN][27] ([i915#180]) +1 similar issue
[26]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9338/shard-kbl7/igt@kms_frontbuffer_tracking@fbc-suspend.html
[27]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5173/shard-kbl4/igt@kms_frontbuffer_tracking@fbc-suspend.html
* igt@kms_frontbuffer_tracking@fbcpsr-1p-rte:
- shard-tglb: [PASS][28] -> [DMESG-WARN][29] ([i915#1982]) +3 similar issues
[28]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9338/shard-tglb3/igt@kms_frontbuffer_tracking@fbcpsr-1p-rte.html
[29]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5173/shard-tglb6/igt@kms_frontbuffer_tracking@fbcpsr-1p-rte.html
* igt@kms_pipe_crc_basic@suspend-read-crc-pipe-c:
- shard-iclb: [PASS][30] -> [INCOMPLETE][31] ([i915#1185]) +1 similar issue
[30]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9338/shard-iclb7/igt@kms_pipe_crc_basic@suspend-read-crc-pipe-c.html
[31]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5173/shard-iclb3/igt@kms_pipe_crc_basic@suspend-read-crc-pipe-c.html
- shard-glk: [PASS][32] -> [DMESG-WARN][33] ([i915#2635])
[32]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9338/shard-glk7/igt@kms_pipe_crc_basic@suspend-read-crc-pipe-c.html
[33]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5173/shard-glk5/igt@kms_pipe_crc_basic@suspend-read-crc-pipe-c.html
- shard-apl: [PASS][34] -> [INCOMPLETE][35] ([i915#1635] / [i915#2635])
[34]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9338/shard-apl4/igt@kms_pipe_crc_basic@suspend-read-crc-pipe-c.html
[35]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5173/shard-apl4/igt@kms_pipe_crc_basic@suspend-read-crc-pipe-c.html
- shard-kbl: [PASS][36] -> [INCOMPLETE][37] ([i915#155]) +1 similar issue
[36]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9338/shard-kbl6/igt@kms_pipe_crc_basic@suspend-read-crc-pipe-c.html
[37]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5173/shard-kbl7/igt@kms_pipe_crc_basic@suspend-read-crc-pipe-c.html
* igt@kms_psr2_su@frontbuffer:
- shard-iclb: [PASS][38] -> [SKIP][39] ([fdo#109642] / [fdo#111068])
[38]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9338/shard-iclb2/igt@kms_psr2_su@frontbuffer.html
[39]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5173/shard-iclb4/igt@kms_psr2_su@frontbuffer.html
* igt@kms_psr@psr2_sprite_plane_move:
- shard-iclb: [PASS][40] -> [SKIP][41] ([fdo#109441]) +2 similar issues
[40]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9338/shard-iclb2/igt@kms_psr@psr2_sprite_plane_move.html
[41]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5173/shard-iclb1/igt@kms_psr@psr2_sprite_plane_move.html
#### Possible fixes ####
* igt@gem_exec_suspend@basic-s4-devices:
- shard-snb: [FAIL][42] -> [PASS][43] +1 similar issue
[42]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9338/shard-snb7/igt@gem_exec_suspend@basic-s4-devices.html
[43]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5173/shard-snb2/igt@gem_exec_suspend@basic-s4-devices.html
* igt@gem_exec_whisper@basic-contexts-forked:
- shard-hsw: [FAIL][44] -> [PASS][45]
[44]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9338/shard-hsw8/igt@gem_exec_whisper@basic-contexts-forked.html
[45]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5173/shard-hsw4/igt@gem_exec_whisper@basic-contexts-forked.html
* igt@gem_exec_whisper@basic-queues-forked-all:
- shard-glk: [DMESG-WARN][46] ([i915#118] / [i915#95]) -> [PASS][47]
[46]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9338/shard-glk1/igt@gem_exec_whisper@basic-queues-forked-all.html
[47]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5173/shard-glk2/igt@gem_exec_whisper@basic-queues-forked-all.html
* {igt@kms_async_flips@async-flip-with-page-flip-events}:
- shard-iclb: [FAIL][48] ([i915#2521]) -> [PASS][49]
[48]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9338/shard-iclb2/igt@kms_async_flips@async-flip-with-page-flip-events.html
[49]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5173/shard-iclb5/igt@kms_async_flips@async-flip-with-page-flip-events.html
- shard-apl: [FAIL][50] ([i915#1635] / [i915#2521]) -> [PASS][51]
[50]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9338/shard-apl8/igt@kms_async_flips@async-flip-with-page-flip-events.html
[51]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5173/shard-apl3/igt@kms_async_flips@async-flip-with-page-flip-events.html
* igt@kms_cursor_edge_walk@pipe-b-128x128-right-edge:
- shard-tglb: [DMESG-WARN][52] ([i915#1982]) -> [PASS][53] +5 similar issues
[52]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9338/shard-tglb8/igt@kms_cursor_edge_walk@pipe-b-128x128-right-edge.html
[53]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5173/shard-tglb1/igt@kms_cursor_edge_walk@pipe-b-128x128-right-edge.html
* igt@kms_cursor_edge_walk@pipe-c-256x256-bottom-edge:
- shard-apl: [DMESG-WARN][54] ([i915#1635] / [i915#1982]) -> [PASS][55] +5 similar issues
[54]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9338/shard-apl4/igt@kms_cursor_edge_walk@pipe-c-256x256-bottom-edge.html
[55]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5173/shard-apl3/igt@kms_cursor_edge_walk@pipe-c-256x256-bottom-edge.html
* igt@kms_cursor_legacy@cursor-vs-flip-atomic-transitions:
- shard-glk: [DMESG-WARN][56] ([i915#1982] / [i915#2295]) -> [PASS][57]
[56]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9338/shard-glk4/igt@kms_cursor_legacy@cursor-vs-flip-atomic-transitions.html
[57]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5173/shard-glk6/igt@kms_cursor_legacy@cursor-vs-flip-atomic-transitions.html
* igt@kms_draw_crc@draw-method-xrgb8888-render-xtiled:
- shard-glk: [DMESG-WARN][58] ([i915#1982]) -> [PASS][59] +4 similar issues
[58]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9338/shard-glk2/igt@kms_draw_crc@draw-method-xrgb8888-render-xtiled.html
[59]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5173/shard-glk2/igt@kms_draw_crc@draw-method-xrgb8888-render-xtiled.html
* {igt@kms_flip_tiling@flip-to-x-tiled@dp-1-pipe-a}:
- shard-kbl: [DMESG-WARN][60] ([i915#1982]) -> [PASS][61] +2 similar issues
[60]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9338/shard-kbl6/igt@kms_flip_tiling@flip-to-x-tiled@dp-1-pipe-a.html
[61]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5173/shard-kbl2/igt@kms_flip_tiling@flip-to-x-tiled@dp-1-pipe-a.html
* igt@kms_frontbuffer_tracking@fbc-2p-primscrn-cur-indfb-draw-pwrite:
- shard-glk: [FAIL][62] ([i915#49]) -> [PASS][63]
[62]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9338/shard-glk9/igt@kms_frontbuffer_tracking@fbc-2p-primscrn-cur-indfb-draw-pwrite.html
[63]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5173/shard-glk1/igt@kms_frontbuffer_tracking@fbc-2p-primscrn-cur-indfb-draw-pwrite.html
* igt@kms_frontbuffer_tracking@fbc-rgb565-draw-mmap-cpu:
- shard-snb: [FAIL][64] ([i915#2546]) -> [PASS][65] +1 similar issue
[64]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9338/shard-snb6/igt@kms_frontbuffer_tracking@fbc-rgb565-draw-mmap-cpu.html
[65]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5173/shard-snb7/igt@kms_frontbuffer_tracking@fbc-rgb565-draw-mmap-cpu.html
* igt@kms_hdr@bpc-switch:
- shard-kbl: [DMESG-WARN][66] ([i915#165] / [i915#78]) -> [PASS][67]
[66]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9338/shard-kbl2/igt@kms_hdr@bpc-switch.html
[67]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5173/shard-kbl7/igt@kms_hdr@bpc-switch.html
* igt@kms_plane@plane-panning-bottom-right-suspend-pipe-a-planes:
- shard-glk: [INCOMPLETE][68] ([i915#2635]) -> [PASS][69]
[68]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9338/shard-glk1/igt@kms_plane@plane-panning-bottom-right-suspend-pipe-a-planes.html
[69]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5173/shard-glk5/igt@kms_plane@plane-panning-bottom-right-suspend-pipe-a-planes.html
- shard-apl: [INCOMPLETE][70] ([i915#1635] / [i915#2635]) -> [PASS][71]
[70]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9338/shard-apl7/igt@kms_plane@plane-panning-bottom-right-suspend-pipe-a-planes.html
[71]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5173/shard-apl7/igt@kms_plane@plane-panning-bottom-right-suspend-pipe-a-planes.html
- shard-kbl: [INCOMPLETE][72] ([i915#155] / [i915#648]) -> [PASS][73]
[72]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9338/shard-kbl7/igt@kms_plane@plane-panning-bottom-right-suspend-pipe-a-planes.html
[73]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5173/shard-kbl1/igt@kms_plane@plane-panning-bottom-right-suspend-pipe-a-planes.html
- shard-iclb: [INCOMPLETE][74] ([i915#1185] / [i915#250]) -> [PASS][75]
[74]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9338/shard-iclb6/igt@kms_plane@plane-panning-bottom-right-suspend-pipe-a-planes.html
[75]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5173/shard-iclb6/igt@kms_plane@plane-panning-bottom-right-suspend-pipe-a-planes.html
- shard-hsw: [INCOMPLETE][76] ([i915#2637]) -> [PASS][77]
[76]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9338/shard-hsw2/igt@kms_plane@plane-panning-bottom-right-suspend-pipe-a-planes.html
[77]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5173/shard-hsw2/igt@kms_plane@plane-panning-bottom-right-suspend-pipe-a-planes.html
* igt@kms_plane_cursor@pipe-a-overlay-size-256:
- shard-glk: [FAIL][78] ([i915#2657]) -> [PASS][79]
[78]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9338/shard-glk9/igt@kms_plane_cursor@pipe-a-overlay-size-256.html
[79]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5173/shard-glk3/igt@kms_plane_cursor@pipe-a-overlay-size-256.html
* igt@kms_plane_cursor@pipe-a-viewport-size-64:
- shard-snb: [SKIP][80] ([fdo#109271]) -> [PASS][81]
[80]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9338/shard-snb2/igt@kms_plane_cursor@pipe-a-viewport-size-64.html
[81]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5173/shard-snb7/igt@kms_plane_cursor@pipe-a-viewport-size-64.html
* igt@kms_plane_cursor@pipe-b-primary-size-128:
- shard-kbl: [DMESG-WARN][82] ([i915#78]) -> [PASS][83]
[82]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9338/shard-kbl2/igt@kms_plane_cursor@pipe-b-primary-size-128.html
[83]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5173/shard-kbl1/igt@kms_plane_cursor@pipe-b-primary-size-128.html
* igt@kms_psr@psr2_cursor_render:
- shard-iclb: [SKIP][84] ([fdo#109441]) -> [PASS][85] +2 similar issues
[84]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9338/shard-iclb7/igt@kms_psr@psr2_cursor_render.html
[85]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5173/shard-iclb2/igt@kms_psr@psr2_cursor_render.html
* igt@kms_universal_plane@universal-plane-gen9-features-pipe-a:
- shard-iclb: [DMESG-WARN][86] ([i915#1982]) -> [PASS][87] +1 similar issue
[86]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9338/shard-iclb7/igt@kms_universal_plane@universal-plane-gen9-features-pipe-a.html
[87]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5173/shard-iclb6/igt@kms_universal_plane@universal-plane-gen9-features-pipe-a.html
#### Warnings ####
* igt@i915_pm_rpm@pm-tiling:
- shard-tglb: [DMESG-WARN][88] ([i915#1982] / [i915#2411]) -> [DMESG-WARN][89] ([i915#2411])
[88]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9338/shard-tglb6/igt@i915_pm_rpm@pm-tiling.html
[89]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5173/shard-tglb1/igt@i915_pm_rpm@pm-tiling.html
* igt@kms_fbcon_fbt@fbc-suspend:
- shard-tglb: [DMESG-WARN][90] ([i915#2411]) -> [INCOMPLETE][91] ([i915#1436] / [i915#456])
[90]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9338/shard-tglb7/igt@kms_fbcon_fbt@fbc-suspend.html
[91]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5173/shard-tglb2/igt@kms_fbcon_fbt@fbc-suspend.html
* igt@kms_plane@plane-panning-bottom-right-suspend-pipe-a-planes:
- shard-tglb: [INCOMPLETE][92] ([i915#1436] / [i915#456]) -> [DMESG-WARN][93] ([i915#2411])
[92]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9338/shard-tglb2/igt@kms_plane@plane-panning-bottom-right-suspend-pipe-a-planes.html
[93]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5173/shard-tglb2/igt@kms_plane@plane-panning-bottom-right-suspend-pipe-a-planes.html
* igt@kms_plane_alpha_blend@pipe-a-alpha-7efc:
- shard-apl: [DMESG-FAIL][94] ([fdo#108145] / [i915#1635] / [i915#1982]) -> [FAIL][95] ([fdo#108145] / [i915#1635] / [i915#265])
[94]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9338/shard-apl6/igt@kms_plane_alpha_blend@pipe-a-alpha-7efc.html
[95]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5173/shard-apl4/igt@kms_plane_alpha_blend@pipe-a-alpha-7efc.html
* igt@runner@aborted:
- shard-kbl: ([FAIL][96], [FAIL][97]) ([i915#1611] / [i915#1814] / [i915#2295] / [i915#2439]) -> ([FAIL][98], [FAIL][99], [FAIL][100]) ([i915#1611] / [i915#1814] / [i915#2295] / [i915#2439] / [i915#483] / [i915#92])
[96]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9338/shard-kbl7/igt@runner@aborted.html
[97]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9338/shard-kbl7/igt@runner@aborted.html
[98]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5173/shard-kbl1/igt@runner@aborted.html
[99]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5173/shard-kbl7/igt@runner@aborted.html
[100]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5173/shard-kbl1/igt@runner@aborted.html
- shard-apl: ([FAIL][101], [FAIL][102]) ([i915#1611] / [i915#1635] / [i915#1814] / [i915#2295] / [i915#2439] / [i915#62]) -> ([FAIL][103], [FAIL][104], [FAIL][105]) ([fdo#109271] / [i915#1611] / [i915#1635] / [i915#1814] / [i915#2295] / [i915#2439])
[101]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9338/shard-apl7/igt@runner@aborted.html
[102]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9338/shard-apl7/igt@runner@aborted.html
[103]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5173/shard-apl3/igt@runner@aborted.html
[104]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5173/shard-apl7/igt@runner@aborted.html
[105]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5173/shard-apl4/igt@runner@aborted.html
- shard-tglb: ([FAIL][106], [FAIL][107]) ([i915#1814] / [i915#2295] / [i915#2439]) -> ([FAIL][108], [FAIL][109]) ([i915#1602] / [i915#2295] / [i915#2439])
[106]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9338/shard-tglb2/igt@runner@aborted.html
[107]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9338/shard-tglb2/igt@runner@aborted.html
[108]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5173/shard-tglb2/igt@runner@aborted.html
[109]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5173/shard-tglb1/igt@runner@aborted.html
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[fdo#108145]: https://bugs.freedesktop.org/show_bug.cgi?id=108145
[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[fdo#109441]: https://bugs.freedesktop.org/show_bug.cgi?id=109441
[fdo#109642]: https://bugs.freedesktop.org/show_bug.cgi?id=109642
[fdo#111068]: https://bugs.freedesktop.org/show_bug.cgi?id=111068
[i915#1037]: https://gitlab.freedesktop.org/drm/intel/issues/1037
[i915#118]: https://gitlab.freedesktop.org/drm/intel/issues/118
[i915#1185]: https://gitlab.freedesktop.org/drm/intel/issues/1185
[i915#1436]: https://gitlab.freedesktop.org/drm/intel/issues/1436
[i915#155]: https://gitlab.freedesktop.org/drm/intel/issues/155
[i915#1602]: https://gitlab.freedesktop.org/drm/intel/issues/1602
[i915#1611]: https://gitlab.freedesktop.org/drm/intel/issues/1611
[i915#1635]: https://gitlab.freedesktop.org/drm/intel/issues/1635
[i915#165]: https://gitlab.freedesktop.org/drm/intel/issues/165
[i915#180]: https://gitlab.freedesktop.org/drm/intel/issues/180
[i915#1814]: https://gitlab.freedesktop.org/drm/intel/issues/1814
[i915#1982]: https://gitlab.freedesktop.org/drm/intel/issues/1982
[i915#2295]: https://gitlab.freedesktop.org/drm/intel/issues/2295
[i915#2346]: https://gitlab.freedesktop.org/drm/intel/issues/2346
[i915#2389]: https://gitlab.freedesktop.org/drm/intel/issues/2389
[i915#2411]: https://gitlab.freedesktop.org/drm/intel/issues/2411
[i915#2439]: https://gitlab.freedesktop.org/drm/intel/issues/2439
[i915#250]: https://gitlab.freedesktop.org/drm/intel/issues/250
[i915#2521]: https://gitlab.freedesktop.org/drm/intel/issues/2521
[i915#2546]: https://gitlab.freedesktop.org/drm/intel/issues/2546
[i915#2635]: https://gitlab.freedesktop.org/drm/intel/issues/2635
[i915#2637]: https://gitlab.freedesktop.org/drm/intel/issues/2637
[i915#265]: https://gitlab.freedesktop.org/drm/intel/issues/265
[i915#2657]: https://gitlab.freedesktop.org/drm/intel/issues/2657
[i915#456]: https://gitlab.freedesktop.org/drm/intel/issues/456
[i915#483]: https://gitlab.freedesktop.org/drm/intel/issues/483
[i915#49]: https://gitlab.freedesktop.org/drm/intel/issues/49
[i915#62]: https://gitlab.freedesktop.org/drm/intel/issues/62
[i915#648]: https://gitlab.freedesktop.org/drm/intel/issues/648
[i915#78]: https://gitlab.freedesktop.org/drm/intel/issues/78
[i915#92]: https://gitlab.freedesktop.org/drm/intel/issues/92
[i915#95]: https://gitlab.freedesktop.org/drm/intel/issues/95
Participating hosts (10 -> 8)
------------------------------
Missing (2): pig-skl-6260u pig-glk-j5005
Build changes
-------------
* CI: CI-20190529 -> None
* IGT: IGT_5854 -> IGTPW_5173
* Piglit: piglit_4509 -> None
CI-20190529: 20190529
CI_DRM_9338: 994881297675ccca3caf7348ee0dc36cdbd47cef @ git://anongit.freedesktop.org/gfx-ci/linux
IGTPW_5173: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5173/index.html
IGT_5854: 5155c2bd05e03fec86fb9c97d65a4f69b44c3678 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5173/index.html
[-- Attachment #1.2: Type: text/html, Size: 30258 bytes --]
[-- Attachment #2: Type: text/plain, Size: 154 bytes --]
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply [flat|nested] 17+ messages in thread
end of thread, other threads:[~2020-11-17 0:14 UTC | newest]
Thread overview: 17+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-11-16 17:26 [Intel-gfx] [PATCH i-g-t 1/5] intel_gpu_top: User friendly device listing Tvrtko Ursulin
2020-11-16 17:26 ` [igt-dev] " Tvrtko Ursulin
2020-11-16 17:26 ` [Intel-gfx] [PATCH i-g-t 2/5] lsgpu: " Tvrtko Ursulin
2020-11-16 17:26 ` [Intel-gfx] [PATCH i-g-t 3/5] lib/igt_device_scan: Remember PCI card index after scanning Tvrtko Ursulin
2020-11-16 17:26 ` [igt-dev] " Tvrtko Ursulin
2020-11-16 17:58 ` [Intel-gfx] " Zbigniew Kempczyński
2020-11-16 17:58 ` [igt-dev] " Zbigniew Kempczyński
2020-11-16 17:26 ` [Intel-gfx] [PATCH i-g-t 4/5] lsgpu: Add filter type print-out selection Tvrtko Ursulin
2020-11-16 17:26 ` [igt-dev] " Tvrtko Ursulin
2020-11-16 18:45 ` [Intel-gfx] " Zbigniew Kempczyński
2020-11-16 18:45 ` [igt-dev] " Zbigniew Kempczyński
2020-11-16 17:26 ` [Intel-gfx] [PATCH i-g-t 5/5] intel_gpu_top: Default GPU list to PCI mode Tvrtko Ursulin
2020-11-16 17:26 ` [igt-dev] " Tvrtko Ursulin
2020-11-16 18:40 ` [Intel-gfx] " Zbigniew Kempczyński
2020-11-16 18:40 ` Zbigniew Kempczyński
2020-11-16 18:42 ` [igt-dev] ✓ Fi.CI.BAT: success for series starting with [i-g-t,1/5] intel_gpu_top: User friendly device listing Patchwork
2020-11-17 0:14 ` [igt-dev] ✗ Fi.CI.IGT: failure " Patchwork
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.