From: Richard Cochran <richardcochran@gmail.com> To: Vinicius Costa Gomes <vinicius.gomes@intel.com> Cc: Miroslav Lichvar <mlichvar@redhat.com>, intel-wired-lan@lists.osuosl.org, andre.guedes@intel.com, linux-pci@vger.kernel.org, netdev@vger.kernel.org, bhelgaas@google.com Subject: Re: [Intel-wired-lan] [PATCH next-queue v2 3/3] igc: Add support for PTP getcrosststamp() Date: Mon, 16 Nov 2020 17:49:26 -0800 [thread overview] Message-ID: <20201117014926.GA26272@hoboy.vegasvil.org> (raw) In-Reply-To: <874klo7pwp.fsf@intel.com> On Mon, Nov 16, 2020 at 05:06:30PM -0800, Vinicius Costa Gomes wrote: > The PTM dialogs are a pair of messages: a Request from the endpoint (in > my case, the NIC) to the PCIe root (or switch), and a Response from the > other side (this message includes the Master Root Time, and the > calculated propagation delay). > > The interface exposed by the NIC I have allows basically to start/stop > these PTM dialogs (I was calling them PTM cycles) and to configure the > interval between each cycle (~1ms - ~512ms). Ah, now I am starting to understand... Just to be clear, this is yet another time measurement over PCIe, different than the cross time stamp that we already have, right? Also, what is the point of providing time measurements every 1 millisecond? > Another thing of note, is that trying to start the PTM dialogs "on > demand" syncronously with the ioctl() doesn't seem too reliable, it > seems to want to be kept running for a longer time. So, I think the simplest thing would be to have a one-shot measurement, if possible. Then you could use the existing API and let the user space trigger the time stamps. Thanks, Richard
WARNING: multiple messages have this Message-ID (diff)
From: Richard Cochran <richardcochran@gmail.com> To: intel-wired-lan@osuosl.org Subject: [Intel-wired-lan] [PATCH next-queue v2 3/3] igc: Add support for PTP getcrosststamp() Date: Mon, 16 Nov 2020 17:49:26 -0800 [thread overview] Message-ID: <20201117014926.GA26272@hoboy.vegasvil.org> (raw) In-Reply-To: <874klo7pwp.fsf@intel.com> On Mon, Nov 16, 2020 at 05:06:30PM -0800, Vinicius Costa Gomes wrote: > The PTM dialogs are a pair of messages: a Request from the endpoint (in > my case, the NIC) to the PCIe root (or switch), and a Response from the > other side (this message includes the Master Root Time, and the > calculated propagation delay). > > The interface exposed by the NIC I have allows basically to start/stop > these PTM dialogs (I was calling them PTM cycles) and to configure the > interval between each cycle (~1ms - ~512ms). Ah, now I am starting to understand... Just to be clear, this is yet another time measurement over PCIe, different than the cross time stamp that we already have, right? Also, what is the point of providing time measurements every 1 millisecond? > Another thing of note, is that trying to start the PTM dialogs "on > demand" syncronously with the ioctl() doesn't seem too reliable, it > seems to want to be kept running for a longer time. So, I think the simplest thing would be to have a one-shot measurement, if possible. Then you could use the existing API and let the user space trigger the time stamps. Thanks, Richard
next prev parent reply other threads:[~2020-11-17 1:49 UTC|newest] Thread overview: 52+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-11-10 6:10 [PATCH next-queue v2 0/3] igc: Add support for PCIe PTM Vinicius Costa Gomes 2020-11-10 6:10 ` [Intel-wired-lan] " Vinicius Costa Gomes 2020-11-10 6:10 ` [PATCH next-queue v2 1/3] Revert "PCI: Make pci_enable_ptm() private" Vinicius Costa Gomes 2020-11-10 6:10 ` [Intel-wired-lan] " Vinicius Costa Gomes 2020-11-10 6:10 ` [PATCH next-queue v2 2/3] igc: Enable PCIe PTM Vinicius Costa Gomes 2020-11-10 6:10 ` [Intel-wired-lan] " Vinicius Costa Gomes 2020-11-10 6:10 ` [PATCH next-queue v2 3/3] igc: Add support for PTP getcrosststamp() Vinicius Costa Gomes 2020-11-10 6:10 ` [Intel-wired-lan] " Vinicius Costa Gomes 2020-11-10 18:07 ` Miroslav Lichvar 2020-11-10 18:07 ` Miroslav Lichvar 2020-11-10 19:06 ` Vinicius Costa Gomes 2020-11-10 19:06 ` Vinicius Costa Gomes 2020-11-11 9:33 ` Miroslav Lichvar 2020-11-11 9:33 ` Miroslav Lichvar 2020-11-11 22:23 ` Vinicius Costa Gomes 2020-11-11 22:23 ` Vinicius Costa Gomes 2020-11-12 9:32 ` Miroslav Lichvar 2020-11-12 9:32 ` Miroslav Lichvar 2020-11-12 23:46 ` Vinicius Costa Gomes 2020-11-12 23:46 ` Vinicius Costa Gomes 2020-11-13 3:24 ` Richard Cochran 2020-11-13 3:24 ` Richard Cochran 2020-11-13 19:10 ` Vinicius Costa Gomes 2020-11-13 19:10 ` Vinicius Costa Gomes 2020-11-14 2:57 ` Richard Cochran 2020-11-14 2:57 ` Richard Cochran 2020-11-17 1:06 ` Vinicius Costa Gomes 2020-11-17 1:06 ` Vinicius Costa Gomes 2020-11-17 1:49 ` Richard Cochran [this message] 2020-11-17 1:49 ` Richard Cochran 2020-11-18 1:21 ` Vinicius Costa Gomes 2020-11-18 1:21 ` Vinicius Costa Gomes 2020-11-18 12:54 ` Richard Cochran 2020-11-18 12:54 ` Richard Cochran 2020-11-19 0:22 ` Vinicius Costa Gomes 2020-11-19 0:22 ` Vinicius Costa Gomes 2020-11-20 14:16 ` Richard Cochran 2020-11-20 14:16 ` Richard Cochran 2020-11-20 17:58 ` Vinicius Costa Gomes 2020-11-20 17:58 ` Vinicius Costa Gomes 2021-03-22 15:36 ` Vinicius Costa Gomes 2021-03-22 15:36 ` Vinicius Costa Gomes 2021-03-23 4:17 ` Richard Cochran 2021-03-23 4:17 ` Richard Cochran 2020-11-18 15:55 ` Jakub Kicinski 2020-11-18 15:55 ` Jakub Kicinski 2020-11-20 19:07 ` Vinicius Costa Gomes 2020-11-20 19:07 ` Vinicius Costa Gomes 2020-11-12 0:38 ` Vinicius Costa Gomes 2020-11-12 0:38 ` Vinicius Costa Gomes 2021-03-22 15:47 ` Vinicius Costa Gomes 2021-03-22 15:47 ` Vinicius Costa Gomes
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20201117014926.GA26272@hoboy.vegasvil.org \ --to=richardcochran@gmail.com \ --cc=andre.guedes@intel.com \ --cc=bhelgaas@google.com \ --cc=intel-wired-lan@lists.osuosl.org \ --cc=linux-pci@vger.kernel.org \ --cc=mlichvar@redhat.com \ --cc=netdev@vger.kernel.org \ --cc=vinicius.gomes@intel.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.