From: Andrew Lunn <andrew@lunn.ch>
To: Martin Blumenstingl <martin.blumenstingl@googlemail.com>
Cc: davem@davemloft.net, kuba@kernel.org,
linux-amlogic@lists.infradead.org, devicetree@vger.kernel.org,
robh+dt@kernel.org, netdev@vger.kernel.org,
jianxin.pan@amlogic.com, linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, khilman@baylibre.com,
narmstrong@baylibre.com, jbrunet@baylibre.com,
f.fainelli@gmail.com
Subject: Re: [PATCH RFC v2 4/5] net: stmmac: dwmac-meson8b: move RGMII delays into a separate function
Date: Tue, 17 Nov 2020 03:05:14 +0100 [thread overview]
Message-ID: <20201117020514.GD1752213@lunn.ch> (raw)
In-Reply-To: <20201115185210.573739-5-martin.blumenstingl@googlemail.com>
On Sun, Nov 15, 2020 at 07:52:09PM +0100, Martin Blumenstingl wrote:
> Newer SoCs starting with the Amlogic Meson G12A have more a precise
> RGMII RX delay configuration register. This means more complexity in the
> code. Extract the existing RGMII delay configuration code into a
> separate function to make it easier to read/understand even when adding
> more logic in the future.
>
> Signed-off-by: Martin Blumenstingl <martin.blumenstingl@googlemail.com>
Reviewed-by: Andrew Lunn <andrew@lunn.ch>
Andrew
WARNING: multiple messages have this Message-ID (diff)
From: Andrew Lunn <andrew@lunn.ch>
To: Martin Blumenstingl <martin.blumenstingl@googlemail.com>
Cc: devicetree@vger.kernel.org, f.fainelli@gmail.com,
jianxin.pan@amlogic.com, narmstrong@baylibre.com,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
robh+dt@kernel.org, khilman@baylibre.com,
linux-amlogic@lists.infradead.org, kuba@kernel.org,
davem@davemloft.net, linux-arm-kernel@lists.infradead.org,
jbrunet@baylibre.com
Subject: Re: [PATCH RFC v2 4/5] net: stmmac: dwmac-meson8b: move RGMII delays into a separate function
Date: Tue, 17 Nov 2020 03:05:14 +0100 [thread overview]
Message-ID: <20201117020514.GD1752213@lunn.ch> (raw)
In-Reply-To: <20201115185210.573739-5-martin.blumenstingl@googlemail.com>
On Sun, Nov 15, 2020 at 07:52:09PM +0100, Martin Blumenstingl wrote:
> Newer SoCs starting with the Amlogic Meson G12A have more a precise
> RGMII RX delay configuration register. This means more complexity in the
> code. Extract the existing RGMII delay configuration code into a
> separate function to make it easier to read/understand even when adding
> more logic in the future.
>
> Signed-off-by: Martin Blumenstingl <martin.blumenstingl@googlemail.com>
Reviewed-by: Andrew Lunn <andrew@lunn.ch>
Andrew
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
WARNING: multiple messages have this Message-ID (diff)
From: Andrew Lunn <andrew@lunn.ch>
To: Martin Blumenstingl <martin.blumenstingl@googlemail.com>
Cc: devicetree@vger.kernel.org, f.fainelli@gmail.com,
jianxin.pan@amlogic.com, narmstrong@baylibre.com,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
robh+dt@kernel.org, khilman@baylibre.com,
linux-amlogic@lists.infradead.org, kuba@kernel.org,
davem@davemloft.net, linux-arm-kernel@lists.infradead.org,
jbrunet@baylibre.com
Subject: Re: [PATCH RFC v2 4/5] net: stmmac: dwmac-meson8b: move RGMII delays into a separate function
Date: Tue, 17 Nov 2020 03:05:14 +0100 [thread overview]
Message-ID: <20201117020514.GD1752213@lunn.ch> (raw)
In-Reply-To: <20201115185210.573739-5-martin.blumenstingl@googlemail.com>
On Sun, Nov 15, 2020 at 07:52:09PM +0100, Martin Blumenstingl wrote:
> Newer SoCs starting with the Amlogic Meson G12A have more a precise
> RGMII RX delay configuration register. This means more complexity in the
> code. Extract the existing RGMII delay configuration code into a
> separate function to make it easier to read/understand even when adding
> more logic in the future.
>
> Signed-off-by: Martin Blumenstingl <martin.blumenstingl@googlemail.com>
Reviewed-by: Andrew Lunn <andrew@lunn.ch>
Andrew
_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic
next prev parent reply other threads:[~2020-11-17 2:05 UTC|newest]
Thread overview: 63+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-15 18:52 [PATCH RFC v2 0/5] dwmac-meson8b: picosecond precision RX delay support Martin Blumenstingl
2020-11-15 18:52 ` Martin Blumenstingl
2020-11-15 18:52 ` Martin Blumenstingl
2020-11-15 18:52 ` [PATCH RFC v2 1/5] dt-bindings: net: dwmac-meson: use picoseconds for the RGMII RX delay Martin Blumenstingl
2020-11-15 18:52 ` Martin Blumenstingl
2020-11-15 18:52 ` Martin Blumenstingl
2020-11-17 2:01 ` Andrew Lunn
2020-11-17 2:01 ` Andrew Lunn
2020-11-17 2:01 ` Andrew Lunn
2020-11-17 18:32 ` Florian Fainelli
2020-11-17 18:32 ` Florian Fainelli
2020-11-17 18:32 ` Florian Fainelli
2020-12-07 19:17 ` Rob Herring
2020-12-07 19:17 ` Rob Herring
2020-12-07 19:17 ` Rob Herring
2020-12-13 16:59 ` Martin Blumenstingl
2020-12-13 16:59 ` Martin Blumenstingl
2020-12-13 16:59 ` Martin Blumenstingl
2020-12-15 13:40 ` Rob Herring
2020-12-15 13:40 ` Rob Herring
2020-12-15 13:40 ` Rob Herring
2020-11-15 18:52 ` [PATCH RFC v2 2/5] net: stmmac: dwmac-meson8b: fix enabling the timing-adjustment clock Martin Blumenstingl
2020-11-15 18:52 ` Martin Blumenstingl
2020-11-15 18:52 ` Martin Blumenstingl
2020-11-17 2:02 ` Andrew Lunn
2020-11-17 2:02 ` Andrew Lunn
2020-11-17 2:02 ` Andrew Lunn
2020-11-17 18:34 ` Florian Fainelli
2020-11-17 18:34 ` Florian Fainelli
2020-11-17 18:34 ` Florian Fainelli
2020-11-15 18:52 ` [PATCH RFC v2 3/5] net: stmmac: dwmac-meson8b: use picoseconds for the RGMII RX delay Martin Blumenstingl
2020-11-15 18:52 ` Martin Blumenstingl
2020-11-15 18:52 ` Martin Blumenstingl
2020-11-17 2:04 ` Andrew Lunn
2020-11-17 2:04 ` Andrew Lunn
2020-11-17 2:04 ` Andrew Lunn
2020-11-17 18:36 ` Florian Fainelli
2020-11-17 18:36 ` Florian Fainelli
2020-11-17 18:36 ` Florian Fainelli
2020-11-17 22:50 ` Martin Blumenstingl
2020-11-17 22:50 ` Martin Blumenstingl
2020-11-17 22:50 ` Martin Blumenstingl
2020-11-15 18:52 ` [PATCH RFC v2 4/5] net: stmmac: dwmac-meson8b: move RGMII delays into a separate function Martin Blumenstingl
2020-11-15 18:52 ` Martin Blumenstingl
2020-11-15 18:52 ` Martin Blumenstingl
2020-11-17 2:05 ` Andrew Lunn [this message]
2020-11-17 2:05 ` Andrew Lunn
2020-11-17 2:05 ` Andrew Lunn
2020-11-17 18:36 ` Florian Fainelli
2020-11-17 18:36 ` Florian Fainelli
2020-11-17 18:36 ` Florian Fainelli
2020-11-15 18:52 ` [PATCH RFC v2 5/5] net: stmmac: dwmac-meson8b: add support for the RGMII RX delay on G12A Martin Blumenstingl
2020-11-15 18:52 ` Martin Blumenstingl
2020-11-15 18:52 ` Martin Blumenstingl
2020-11-17 2:06 ` Andrew Lunn
2020-11-17 2:06 ` Andrew Lunn
2020-11-17 2:06 ` Andrew Lunn
2020-11-17 18:37 ` Florian Fainelli
2020-11-17 18:37 ` Florian Fainelli
2020-11-17 18:37 ` Florian Fainelli
2020-11-17 22:55 ` [PATCH RFC v2 0/5] dwmac-meson8b: picosecond precision RX delay support Martin Blumenstingl
2020-11-17 22:55 ` Martin Blumenstingl
2020-11-17 22:55 ` Martin Blumenstingl
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201117020514.GD1752213@lunn.ch \
--to=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=f.fainelli@gmail.com \
--cc=jbrunet@baylibre.com \
--cc=jianxin.pan@amlogic.com \
--cc=khilman@baylibre.com \
--cc=kuba@kernel.org \
--cc=linux-amlogic@lists.infradead.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=martin.blumenstingl@googlemail.com \
--cc=narmstrong@baylibre.com \
--cc=netdev@vger.kernel.org \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.