From: Stefan Hajnoczi <stefanha@redhat.com>
To: Mike Christie <michael.christie@oracle.com>
Cc: qemu-devel@nongnu.org, fam@euphon.net,
linux-scsi@vger.kernel.org, target-devel@vger.kernel.org,
mst@redhat.com, jasowang@redhat.com, pbonzini@redhat.com,
virtualization@lists.linux-foundation.org
Subject: Re: [PATCH 02/10] vhost scsi: remove extra flushes
Date: Tue, 17 Nov 2020 13:07:22 +0000 [thread overview]
Message-ID: <20201117130722.GL131917@stefanha-x1.localdomain> (raw)
In-Reply-To: <1605223150-10888-4-git-send-email-michael.christie@oracle.com>
[-- Attachment #1: Type: text/plain, Size: 642 bytes --]
On Thu, Nov 12, 2020 at 05:19:02PM -0600, Mike Christie wrote:
> The vhost work flush function was flushing the entire work queue, so
> there is no need for the double vhost_work_dev_flush calls in
> vhost_scsi_flush.
>
> And we do not need to call vhost_poll_flush for each poller because
> that call also ends up flushing the same work queue thread the
> vhost_work_dev_flush call flushed.
>
> Signed-off-by: Mike Christie <michael.christie@oracle.com>
> ---
> drivers/vhost/scsi.c | 8 --------
> 1 file changed, 8 deletions(-)
Ah, this was done as a separate step:
Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: Stefan Hajnoczi <stefanha@redhat.com>
To: Mike Christie <michael.christie@oracle.com>
Cc: fam@euphon.net, linux-scsi@vger.kernel.org, mst@redhat.com,
jasowang@redhat.com, qemu-devel@nongnu.org,
virtualization@lists.linux-foundation.org,
target-devel@vger.kernel.org, pbonzini@redhat.com
Subject: Re: [PATCH 02/10] vhost scsi: remove extra flushes
Date: Tue, 17 Nov 2020 13:07:22 +0000 [thread overview]
Message-ID: <20201117130722.GL131917@stefanha-x1.localdomain> (raw)
In-Reply-To: <1605223150-10888-4-git-send-email-michael.christie@oracle.com>
[-- Attachment #1: Type: text/plain, Size: 642 bytes --]
On Thu, Nov 12, 2020 at 05:19:02PM -0600, Mike Christie wrote:
> The vhost work flush function was flushing the entire work queue, so
> there is no need for the double vhost_work_dev_flush calls in
> vhost_scsi_flush.
>
> And we do not need to call vhost_poll_flush for each poller because
> that call also ends up flushing the same work queue thread the
> vhost_work_dev_flush call flushed.
>
> Signed-off-by: Mike Christie <michael.christie@oracle.com>
> ---
> drivers/vhost/scsi.c | 8 --------
> 1 file changed, 8 deletions(-)
Ah, this was done as a separate step:
Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: Stefan Hajnoczi <stefanha@redhat.com>
To: Mike Christie <michael.christie@oracle.com>
Cc: fam@euphon.net, linux-scsi@vger.kernel.org, mst@redhat.com,
qemu-devel@nongnu.org, virtualization@lists.linux-foundation.org,
target-devel@vger.kernel.org, pbonzini@redhat.com
Subject: Re: [PATCH 02/10] vhost scsi: remove extra flushes
Date: Tue, 17 Nov 2020 13:07:22 +0000 [thread overview]
Message-ID: <20201117130722.GL131917@stefanha-x1.localdomain> (raw)
In-Reply-To: <1605223150-10888-4-git-send-email-michael.christie@oracle.com>
[-- Attachment #1.1: Type: text/plain, Size: 642 bytes --]
On Thu, Nov 12, 2020 at 05:19:02PM -0600, Mike Christie wrote:
> The vhost work flush function was flushing the entire work queue, so
> there is no need for the double vhost_work_dev_flush calls in
> vhost_scsi_flush.
>
> And we do not need to call vhost_poll_flush for each poller because
> that call also ends up flushing the same work queue thread the
> vhost_work_dev_flush call flushed.
>
> Signed-off-by: Mike Christie <michael.christie@oracle.com>
> ---
> drivers/vhost/scsi.c | 8 --------
> 1 file changed, 8 deletions(-)
Ah, this was done as a separate step:
Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
[-- Attachment #2: Type: text/plain, Size: 183 bytes --]
_______________________________________________
Virtualization mailing list
Virtualization@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/virtualization
next prev parent reply other threads:[~2020-11-17 14:07 UTC|newest]
Thread overview: 114+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-12 23:18 [PATCH 00/10] vhost/qemu: thread per IO SCSI vq Mike Christie
2020-11-12 23:18 ` Mike Christie
2020-11-12 23:19 ` [PATCH 1/1] qemu vhost scsi: add VHOST_SET_VRING_ENABLE support Mike Christie
2020-11-12 23:19 ` Mike Christie
2020-11-17 11:53 ` Stefan Hajnoczi
2020-11-17 11:53 ` Stefan Hajnoczi
2020-11-17 11:53 ` Stefan Hajnoczi
2020-12-02 9:59 ` Michael S. Tsirkin
2020-12-02 9:59 ` Michael S. Tsirkin
2020-12-02 9:59 ` Michael S. Tsirkin
2020-12-02 16:05 ` Michael Christie
2020-12-02 16:05 ` Michael Christie
2020-11-12 23:19 ` [PATCH 01/10] vhost: remove work arg from vhost_work_flush Mike Christie
2020-11-12 23:19 ` Mike Christie
2020-11-17 13:04 ` Stefan Hajnoczi
2020-11-17 13:04 ` Stefan Hajnoczi
2020-11-17 13:04 ` Stefan Hajnoczi
2020-11-12 23:19 ` [PATCH 02/10] vhost scsi: remove extra flushes Mike Christie
2020-11-12 23:19 ` Mike Christie
2020-11-17 13:07 ` Stefan Hajnoczi [this message]
2020-11-17 13:07 ` Stefan Hajnoczi
2020-11-17 13:07 ` Stefan Hajnoczi
2020-11-12 23:19 ` [PATCH 03/10] vhost poll: fix coding style Mike Christie
2020-11-12 23:19 ` Mike Christie
2020-11-17 13:07 ` Stefan Hajnoczi
2020-11-17 13:07 ` Stefan Hajnoczi
2020-11-17 13:07 ` Stefan Hajnoczi
2020-11-12 23:19 ` [PATCH 04/10] vhost: support multiple worker threads Mike Christie
2020-11-12 23:19 ` Mike Christie
2020-11-12 23:19 ` [PATCH 05/10] vhost: poll support support multiple workers Mike Christie
2020-11-12 23:19 ` Mike Christie
2020-11-17 15:32 ` Stefan Hajnoczi
2020-11-17 15:32 ` Stefan Hajnoczi
2020-11-17 15:32 ` Stefan Hajnoczi
2020-11-12 23:19 ` [PATCH 06/10] vhost scsi: make SCSI cmd completion per vq Mike Christie
2020-11-12 23:19 ` Mike Christie
2020-11-17 16:04 ` Stefan Hajnoczi
2020-11-17 16:04 ` Stefan Hajnoczi
2020-11-17 16:04 ` Stefan Hajnoczi
2020-11-12 23:19 ` [PATCH 07/10] vhost, vhost-scsi: flush IO vqs then send TMF rsp Mike Christie
2020-11-12 23:19 ` Mike Christie
2020-11-17 16:05 ` Stefan Hajnoczi
2020-11-17 16:05 ` Stefan Hajnoczi
2020-11-17 16:05 ` Stefan Hajnoczi
2020-11-12 23:19 ` [PATCH 08/10] vhost: move msg_handler to new ops struct Mike Christie
2020-11-12 23:19 ` Mike Christie
2020-11-17 16:08 ` Stefan Hajnoczi
2020-11-17 16:08 ` Stefan Hajnoczi
2020-11-17 16:08 ` Stefan Hajnoczi
2020-11-12 23:19 ` [PATCH 09/10] vhost: add VHOST_SET_VRING_ENABLE support Mike Christie
2020-11-12 23:19 ` Mike Christie
2020-11-17 16:14 ` Stefan Hajnoczi
2020-11-17 16:14 ` Stefan Hajnoczi
2020-11-17 16:14 ` Stefan Hajnoczi
2020-11-12 23:19 ` [PATCH 10/10] vhost-scsi: create a woker per IO vq Mike Christie
2020-11-12 23:19 ` Mike Christie
2020-11-17 16:40 ` [PATCH 00/10] vhost/qemu: thread per IO SCSI vq Stefan Hajnoczi
2020-11-17 16:40 ` Stefan Hajnoczi
2020-11-17 16:40 ` Stefan Hajnoczi
2020-11-17 19:13 ` Mike Christie
2020-11-17 19:13 ` Mike Christie
2020-11-18 9:54 ` Michael S. Tsirkin
2020-11-18 9:54 ` Michael S. Tsirkin
2020-11-18 9:54 ` Michael S. Tsirkin
2020-11-19 14:00 ` Stefan Hajnoczi
2020-11-19 14:00 ` Stefan Hajnoczi
2020-11-19 14:00 ` Stefan Hajnoczi
2020-11-18 11:31 ` Stefan Hajnoczi
2020-11-18 11:31 ` Stefan Hajnoczi
2020-11-18 11:31 ` Stefan Hajnoczi
2020-11-19 14:46 ` Michael S. Tsirkin
2020-11-19 14:46 ` Michael S. Tsirkin
2020-11-19 14:46 ` Michael S. Tsirkin
2020-11-19 16:11 ` Mike Christie
2020-11-19 16:11 ` Mike Christie
2020-11-19 16:24 ` Stefan Hajnoczi
2020-11-19 16:24 ` Stefan Hajnoczi
2020-11-19 16:24 ` Stefan Hajnoczi
2020-11-19 16:43 ` Mike Christie
2020-11-19 16:43 ` Mike Christie
2020-11-19 17:08 ` Stefan Hajnoczi
2020-11-19 17:08 ` Stefan Hajnoczi
2020-11-19 17:08 ` Stefan Hajnoczi
2020-11-20 8:45 ` Stefan Hajnoczi
2020-11-20 8:45 ` Stefan Hajnoczi
2020-11-20 8:45 ` Stefan Hajnoczi
2020-11-20 12:31 ` Michael S. Tsirkin
2020-11-20 12:31 ` Michael S. Tsirkin
2020-11-20 12:31 ` Michael S. Tsirkin
2020-12-01 12:59 ` Stefan Hajnoczi
2020-12-01 12:59 ` Stefan Hajnoczi
2020-12-01 12:59 ` Stefan Hajnoczi
2020-12-01 13:45 ` Stefano Garzarella
2020-12-01 13:45 ` Stefano Garzarella
2020-12-01 13:45 ` Stefano Garzarella
2020-12-01 17:43 ` Stefan Hajnoczi
2020-12-01 17:43 ` Stefan Hajnoczi
2020-12-01 17:43 ` Stefan Hajnoczi
2020-12-02 10:35 ` Stefano Garzarella
2020-12-02 10:35 ` Stefano Garzarella
2020-12-02 10:35 ` Stefano Garzarella
2020-11-23 15:17 ` Stefano Garzarella
2020-11-23 15:17 ` Stefano Garzarella
2020-11-23 15:17 ` Stefano Garzarella
2020-11-18 5:17 ` Jason Wang
2020-11-18 5:17 ` Jason Wang
2020-11-18 6:57 ` Mike Christie
2020-11-18 7:19 ` Mike Christie
2020-11-18 7:54 ` Jason Wang
2020-11-18 7:54 ` Jason Wang
2020-11-18 20:06 ` Mike Christie
2020-11-19 4:35 ` Jason Wang
2020-11-19 4:35 ` Jason Wang
2020-11-19 15:49 ` Mike Christie
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201117130722.GL131917@stefanha-x1.localdomain \
--to=stefanha@redhat.com \
--cc=fam@euphon.net \
--cc=jasowang@redhat.com \
--cc=linux-scsi@vger.kernel.org \
--cc=michael.christie@oracle.com \
--cc=mst@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=target-devel@vger.kernel.org \
--cc=virtualization@lists.linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.