From: Satya Tangirala <satyat@google.com> To: "Theodore Y . Ts'o" <tytso@mit.edu>, Jaegeuk Kim <jaegeuk@kernel.org>, Eric Biggers <ebiggers@kernel.org>, Chao Yu <chao@kernel.org>, Jens Axboe <axboe@kernel.dk>, "Darrick J . Wong" <darrick.wong@oracle.com> Cc: linux-kernel@vger.kernel.org, linux-fscrypt@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net, linux-xfs@vger.kernel.org, linux-block@vger.kernel.org, linux-ext4@vger.kernel.org, Eric Biggers <ebiggers@google.com>, Satya Tangirala <satyat@google.com> Subject: [PATCH v7 7/8] f2fs: support direct I/O with fscrypt using blk-crypto Date: Tue, 17 Nov 2020 14:07:07 +0000 [thread overview] Message-ID: <20201117140708.1068688-8-satyat@google.com> (raw) In-Reply-To: <20201117140708.1068688-1-satyat@google.com> From: Eric Biggers <ebiggers@google.com> Wire up f2fs with fscrypt direct I/O support. direct I/O with fscrypt is only supported through blk-crypto (i.e. CONFIG_BLK_INLINE_ENCRYPTION must have been enabled, the 'inlinecrypt' mount option must have been specified, and either hardware inline encryption support must be present or CONFIG_BLK_INLINE_ENCYRPTION_FALLBACK must have been enabled). Further, direct I/O on encrypted files is only supported when the *length* of the I/O is aligned to the filesystem block size (which is *not* necessarily the same as the block device's block size). Signed-off-by: Eric Biggers <ebiggers@google.com> Co-developed-by: Satya Tangirala <satyat@google.com> Signed-off-by: Satya Tangirala <satyat@google.com> Acked-by: Jaegeuk Kim <jaegeuk@kernel.org> --- fs/f2fs/f2fs.h | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/fs/f2fs/f2fs.h b/fs/f2fs/f2fs.h index cb700d797296..d518e668618e 100644 --- a/fs/f2fs/f2fs.h +++ b/fs/f2fs/f2fs.h @@ -4120,7 +4120,11 @@ static inline bool f2fs_force_buffered_io(struct inode *inode, struct f2fs_sb_info *sbi = F2FS_I_SB(inode); int rw = iov_iter_rw(iter); - if (f2fs_post_read_required(inode)) + if (!fscrypt_dio_supported(iocb, iter)) + return true; + if (fsverity_active(inode)) + return true; + if (f2fs_compressed_file(inode)) return true; if (f2fs_is_multi_device(sbi)) return true; -- 2.29.2.299.gdc1121823c-goog
WARNING: multiple messages have this Message-ID (diff)
From: Satya Tangirala via Linux-f2fs-devel <linux-f2fs-devel@lists.sourceforge.net> To: "Theodore Y . Ts'o" <tytso@mit.edu>, Jaegeuk Kim <jaegeuk@kernel.org>, Eric Biggers <ebiggers@kernel.org>, Chao Yu <chao@kernel.org>, Jens Axboe <axboe@kernel.dk>, "Darrick J . Wong" <darrick.wong@oracle.com> Cc: linux-block@vger.kernel.org, Eric Biggers <ebiggers@google.com>, linux-kernel@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net, linux-xfs@vger.kernel.org, linux-fscrypt@vger.kernel.org, Satya Tangirala <satyat@google.com>, linux-ext4@vger.kernel.org Subject: [f2fs-dev] [PATCH v7 7/8] f2fs: support direct I/O with fscrypt using blk-crypto Date: Tue, 17 Nov 2020 14:07:07 +0000 [thread overview] Message-ID: <20201117140708.1068688-8-satyat@google.com> (raw) In-Reply-To: <20201117140708.1068688-1-satyat@google.com> From: Eric Biggers <ebiggers@google.com> Wire up f2fs with fscrypt direct I/O support. direct I/O with fscrypt is only supported through blk-crypto (i.e. CONFIG_BLK_INLINE_ENCRYPTION must have been enabled, the 'inlinecrypt' mount option must have been specified, and either hardware inline encryption support must be present or CONFIG_BLK_INLINE_ENCYRPTION_FALLBACK must have been enabled). Further, direct I/O on encrypted files is only supported when the *length* of the I/O is aligned to the filesystem block size (which is *not* necessarily the same as the block device's block size). Signed-off-by: Eric Biggers <ebiggers@google.com> Co-developed-by: Satya Tangirala <satyat@google.com> Signed-off-by: Satya Tangirala <satyat@google.com> Acked-by: Jaegeuk Kim <jaegeuk@kernel.org> --- fs/f2fs/f2fs.h | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/fs/f2fs/f2fs.h b/fs/f2fs/f2fs.h index cb700d797296..d518e668618e 100644 --- a/fs/f2fs/f2fs.h +++ b/fs/f2fs/f2fs.h @@ -4120,7 +4120,11 @@ static inline bool f2fs_force_buffered_io(struct inode *inode, struct f2fs_sb_info *sbi = F2FS_I_SB(inode); int rw = iov_iter_rw(iter); - if (f2fs_post_read_required(inode)) + if (!fscrypt_dio_supported(iocb, iter)) + return true; + if (fsverity_active(inode)) + return true; + if (f2fs_compressed_file(inode)) return true; if (f2fs_is_multi_device(sbi)) return true; -- 2.29.2.299.gdc1121823c-goog _______________________________________________ Linux-f2fs-devel mailing list Linux-f2fs-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel
next prev parent reply other threads:[~2020-11-17 14:08 UTC|newest] Thread overview: 42+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-11-17 14:07 [PATCH v7 0/8] add support for direct I/O with fscrypt using blk-crypto Satya Tangirala 2020-11-17 14:07 ` [f2fs-dev] " Satya Tangirala via Linux-f2fs-devel 2020-11-17 14:07 ` [PATCH v7 1/8] block: ensure bios are not split in middle of crypto data unit Satya Tangirala 2020-11-17 14:07 ` [f2fs-dev] " Satya Tangirala via Linux-f2fs-devel 2020-11-17 23:31 ` Eric Biggers 2020-11-17 23:31 ` [f2fs-dev] " Eric Biggers 2020-11-18 0:38 ` Satya Tangirala 2020-11-18 0:38 ` [f2fs-dev] " Satya Tangirala via Linux-f2fs-devel 2020-11-25 22:12 ` Eric Biggers 2020-11-25 22:12 ` [f2fs-dev] " Eric Biggers 2020-12-02 22:52 ` Satya Tangirala 2020-12-02 22:52 ` [f2fs-dev] " Satya Tangirala via Linux-f2fs-devel 2020-11-25 22:15 ` Eric Biggers 2020-11-25 22:15 ` [f2fs-dev] " Eric Biggers 2020-11-17 14:07 ` [PATCH v7 2/8] blk-crypto: don't require user buffer alignment Satya Tangirala 2020-11-17 14:07 ` [f2fs-dev] " Satya Tangirala via Linux-f2fs-devel 2020-11-17 23:51 ` Eric Biggers 2020-11-17 23:51 ` [f2fs-dev] " Eric Biggers 2020-11-17 14:07 ` [PATCH v7 3/8] fscrypt: add functions for direct I/O support Satya Tangirala 2020-11-17 14:07 ` [f2fs-dev] " Satya Tangirala via Linux-f2fs-devel 2020-11-17 14:07 ` [PATCH v7 4/8] direct-io: add support for fscrypt using blk-crypto Satya Tangirala 2020-11-17 14:07 ` [f2fs-dev] " Satya Tangirala via Linux-f2fs-devel 2020-11-17 14:07 ` [PATCH v7 5/8] iomap: support direct I/O with " Satya Tangirala 2020-11-17 14:07 ` [f2fs-dev] " Satya Tangirala via Linux-f2fs-devel 2020-11-17 14:07 ` [PATCH v7 6/8] ext4: " Satya Tangirala 2020-11-17 14:07 ` [f2fs-dev] " Satya Tangirala via Linux-f2fs-devel 2020-12-03 13:45 ` Theodore Y. Ts'o 2020-12-03 13:45 ` [f2fs-dev] " Theodore Y. Ts'o 2020-11-17 14:07 ` Satya Tangirala [this message] 2020-11-17 14:07 ` [f2fs-dev] [PATCH v7 7/8] f2fs: " Satya Tangirala via Linux-f2fs-devel 2020-11-17 14:07 ` [PATCH v7 8/8] fscrypt: update documentation for direct I/O support Satya Tangirala 2020-11-17 14:07 ` [f2fs-dev] " Satya Tangirala via Linux-f2fs-devel 2020-11-18 2:38 ` Eric Biggers 2020-11-18 2:38 ` [f2fs-dev] " Eric Biggers 2020-11-17 17:15 ` [PATCH v7 0/8] add support for direct I/O with fscrypt using blk-crypto Theodore Y. Ts'o 2020-11-17 17:15 ` [f2fs-dev] " Theodore Y. Ts'o 2020-11-17 17:20 ` Darrick J. Wong 2020-11-17 17:20 ` [f2fs-dev] " Darrick J. Wong 2020-12-03 23:57 ` Satya Tangirala 2020-12-03 23:57 ` [f2fs-dev] " Satya Tangirala via Linux-f2fs-devel 2020-11-18 2:51 ` Eric Biggers 2020-11-18 2:51 ` [f2fs-dev] " Eric Biggers
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20201117140708.1068688-8-satyat@google.com \ --to=satyat@google.com \ --cc=axboe@kernel.dk \ --cc=chao@kernel.org \ --cc=darrick.wong@oracle.com \ --cc=ebiggers@google.com \ --cc=ebiggers@kernel.org \ --cc=jaegeuk@kernel.org \ --cc=linux-block@vger.kernel.org \ --cc=linux-ext4@vger.kernel.org \ --cc=linux-f2fs-devel@lists.sourceforge.net \ --cc=linux-fscrypt@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-xfs@vger.kernel.org \ --cc=tytso@mit.edu \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.