* [igt-dev] [PATCH i-g-t 0/2] tests/kms_addfb_basic: Nouveau support
@ 2020-11-13 16:49 Jeremy Cline
2020-11-13 16:49 ` [igt-dev] [PATCH i-g-t 1/2] tests/kms_addfb_basic: Mark Intel-only tests as such Jeremy Cline
` (4 more replies)
0 siblings, 5 replies; 25+ messages in thread
From: Jeremy Cline @ 2020-11-13 16:49 UTC (permalink / raw)
To: IGT GPU Tools
Hi folks,
I've been going through IGT's existing tests and seeing what they
uncover when pointed at nouveau. The kms_addfb_basic tests appear to be
largely vendor-agnostic, but there's a few simple cases that need fixing
for the test suite to pass with Nouveau.
The two issues are that there are a few tests that are specifically for
Intel GPUs, and there's some minor error code differences between i915
and nouveau (which both seem to be okay based on the API docs I could
find).
I considered breaking out the vendor-specific tests into a separate
file, but decided to start with a less-invasive change first and see
what people think.
Jeremy Cline (2):
tests/kms_addfb_basic: Mark Intel-only tests as such
tests/kms_addfb_basic: Relax errno assertions
tests/kms_addfb_basic.c | 19 +++++++++++--------
1 file changed, 11 insertions(+), 8 deletions(-)
--
2.28.0
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply [flat|nested] 25+ messages in thread
* [igt-dev] [PATCH i-g-t 1/2] tests/kms_addfb_basic: Mark Intel-only tests as such
2020-11-13 16:49 [igt-dev] [PATCH i-g-t 0/2] tests/kms_addfb_basic: Nouveau support Jeremy Cline
@ 2020-11-13 16:49 ` Jeremy Cline
2020-11-13 19:00 ` Lyude Paul
2020-11-13 16:49 ` [igt-dev] [PATCH i-g-t 2/2] tests/kms_addfb_basic: Relax errno assertions Jeremy Cline
` (3 subsequent siblings)
4 siblings, 1 reply; 25+ messages in thread
From: Jeremy Cline @ 2020-11-13 16:49 UTC (permalink / raw)
To: IGT GPU Tools
Several tests in the addfb suite only apply to i915 devices. Mark them
as such so these tests are skipped on non-Intel devices.
Signed-off-by: Jeremy Cline <jcline@redhat.com>
---
tests/kms_addfb_basic.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/tests/kms_addfb_basic.c b/tests/kms_addfb_basic.c
index 9455909c..0ec583fe 100644
--- a/tests/kms_addfb_basic.c
+++ b/tests/kms_addfb_basic.c
@@ -572,6 +572,7 @@ static void addfb25_ytile(int fd)
igt_subtest("addfb25-y-tiled-legacy") {
igt_require_fb_modifiers(fd);
+ igt_require_intel(fd);
f.modifier[0] = LOCAL_I915_FORMAT_MOD_Y_TILED;
igt_assert(drmIoctl(fd, LOCAL_DRM_IOCTL_MODE_ADDFB2, &f) ==
@@ -583,6 +584,7 @@ static void addfb25_ytile(int fd)
igt_subtest("addfb25-yf-tiled-legacy") {
igt_require_fb_modifiers(fd);
+ igt_require_intel(fd);
f.modifier[0] = LOCAL_I915_FORMAT_MOD_Yf_TILED;
igt_assert(drmIoctl(fd, LOCAL_DRM_IOCTL_MODE_ADDFB2, &f) ==
@@ -594,6 +596,7 @@ static void addfb25_ytile(int fd)
igt_subtest("addfb25-y-tiled-small-legacy") {
igt_require_fb_modifiers(fd);
+ igt_require_intel(fd);
gen = intel_gen(intel_get_drm_devid(fd));
igt_require(gen >= 9);
--
2.28.0
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply related [flat|nested] 25+ messages in thread
* [igt-dev] [PATCH i-g-t 2/2] tests/kms_addfb_basic: Relax errno assertions
2020-11-13 16:49 [igt-dev] [PATCH i-g-t 0/2] tests/kms_addfb_basic: Nouveau support Jeremy Cline
2020-11-13 16:49 ` [igt-dev] [PATCH i-g-t 1/2] tests/kms_addfb_basic: Mark Intel-only tests as such Jeremy Cline
@ 2020-11-13 16:49 ` Jeremy Cline
2020-11-13 18:59 ` Lyude Paul
2020-11-13 20:27 ` [igt-dev] ✓ Fi.CI.BAT: success for tests/kms_addfb_basic: Nouveau support Patchwork
` (2 subsequent siblings)
4 siblings, 1 reply; 25+ messages in thread
From: Jeremy Cline @ 2020-11-13 16:49 UTC (permalink / raw)
To: IGT GPU Tools
This adjusts the check on failed calls to DRM_IOCTL_MODE_ADDFB2 in
various scenarios. According to the kernel's
drm_mode_config_funcs.fb_create documentation, a negative return code is
all that is required to signal failure, and different drivers return
different errors in these scenarios.
Particularly, Nouveau returns -ERANGE rather than -EINVAL in scenarios
where the buffer is too small for the proposed configuration.
Signed-off-by: Jeremy Cline <jcline@redhat.com>
---
tests/kms_addfb_basic.c | 16 ++++++++--------
1 file changed, 8 insertions(+), 8 deletions(-)
diff --git a/tests/kms_addfb_basic.c b/tests/kms_addfb_basic.c
index 0ec583fe..b284bfc1 100644
--- a/tests/kms_addfb_basic.c
+++ b/tests/kms_addfb_basic.c
@@ -282,7 +282,7 @@ static void pitch_tests(int fd)
igt_subtest_f("bad-pitch-%i", bad_pitches[i]) {
f.pitches[0] = bad_pitches[i];
igt_assert(drmIoctl(fd, DRM_IOCTL_MODE_ADDFB2, &f) == -1 &&
- errno == EINVAL);
+ errno != 0);
}
}
@@ -413,11 +413,11 @@ static void size_tests(int fd)
f_8.width++;
igt_subtest("too-wide") {
igt_assert(drmIoctl(fd, DRM_IOCTL_MODE_ADDFB2, &f) == -1 &&
- errno == EINVAL);
+ errno != 0);
igt_assert(drmIoctl(fd, DRM_IOCTL_MODE_ADDFB2, &f_16) == -1 &&
- errno == EINVAL);
+ errno != 0);
igt_assert(drmIoctl(fd, DRM_IOCTL_MODE_ADDFB2, &f_8) == -1 &&
- errno == EINVAL);
+ errno != 0);
}
f.width--;
f_16.width--;
@@ -427,17 +427,17 @@ static void size_tests(int fd)
f_8.height++;
igt_subtest("too-high") {
igt_assert(drmIoctl(fd, DRM_IOCTL_MODE_ADDFB2, &f) == -1 &&
- errno == EINVAL);
+ errno != 0);
igt_assert(drmIoctl(fd, DRM_IOCTL_MODE_ADDFB2, &f_16) == -1 &&
- errno == EINVAL);
+ errno != 0);
igt_assert(drmIoctl(fd, DRM_IOCTL_MODE_ADDFB2, &f_8) == -1 &&
- errno == EINVAL);
+ errno != 0);
}
f.handles[0] = gem_bo_small;
igt_subtest("bo-too-small") {
igt_assert(drmIoctl(fd, DRM_IOCTL_MODE_ADDFB2, &f) == -1 &&
- errno == EINVAL);
+ errno != 0);
}
/* Just to check that the parameters would work. */
--
2.28.0
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply related [flat|nested] 25+ messages in thread
* Re: [igt-dev] [PATCH i-g-t 2/2] tests/kms_addfb_basic: Relax errno assertions
2020-11-13 16:49 ` [igt-dev] [PATCH i-g-t 2/2] tests/kms_addfb_basic: Relax errno assertions Jeremy Cline
@ 2020-11-13 18:59 ` Lyude Paul
2020-11-13 21:41 ` Jeremy Cline
0 siblings, 1 reply; 25+ messages in thread
From: Lyude Paul @ 2020-11-13 18:59 UTC (permalink / raw)
To: Jeremy Cline, IGT GPU Tools
On Fri, 2020-11-13 at 11:49 -0500, Jeremy Cline wrote:
> This adjusts the check on failed calls to DRM_IOCTL_MODE_ADDFB2 in
> various scenarios. According to the kernel's
> drm_mode_config_funcs.fb_create documentation, a negative return code is
> all that is required to signal failure, and different drivers return
> different errors in these scenarios.
>
> Particularly, Nouveau returns -ERANGE rather than -EINVAL in scenarios
> where the buffer is too small for the proposed configuration.
>
> Signed-off-by: Jeremy Cline <jcline@redhat.com>
> ---
> tests/kms_addfb_basic.c | 16 ++++++++--------
> 1 file changed, 8 insertions(+), 8 deletions(-)
>
> diff --git a/tests/kms_addfb_basic.c b/tests/kms_addfb_basic.c
> index 0ec583fe..b284bfc1 100644
> --- a/tests/kms_addfb_basic.c
> +++ b/tests/kms_addfb_basic.c
> @@ -282,7 +282,7 @@ static void pitch_tests(int fd)
> igt_subtest_f("bad-pitch-%i", bad_pitches[i]) {
> f.pitches[0] = bad_pitches[i];
> igt_assert(drmIoctl(fd, DRM_IOCTL_MODE_ADDFB2, &f) ==
> -1 &&
> - errno == EINVAL);
> + errno != 0);
> }
> }
>
> @@ -413,11 +413,11 @@ static void size_tests(int fd)
> f_8.width++;
> igt_subtest("too-wide") {
> igt_assert(drmIoctl(fd, DRM_IOCTL_MODE_ADDFB2, &f) == -1 &&
> - errno == EINVAL);
> + errno != 0);
> igt_assert(drmIoctl(fd, DRM_IOCTL_MODE_ADDFB2, &f_16) == -1 &&
> - errno == EINVAL);
> + errno != 0);
> igt_assert(drmIoctl(fd, DRM_IOCTL_MODE_ADDFB2, &f_8) == -1 &&
> - errno == EINVAL);
> + errno != 0);
> }
> f.width--;
> f_16.width--;
> @@ -427,17 +427,17 @@ static void size_tests(int fd)
> f_8.height++;
> igt_subtest("too-high") {
> igt_assert(drmIoctl(fd, DRM_IOCTL_MODE_ADDFB2, &f) == -1 &&
> - errno == EINVAL);
> + errno != 0);
> igt_assert(drmIoctl(fd, DRM_IOCTL_MODE_ADDFB2, &f_16) == -1 &&
> - errno == EINVAL);
> + errno != 0);
> igt_assert(drmIoctl(fd, DRM_IOCTL_MODE_ADDFB2, &f_8) == -1 &&
> - errno == EINVAL);
> + errno != 0);
> }
>
> f.handles[0] = gem_bo_small;
> igt_subtest("bo-too-small") {
> igt_assert(drmIoctl(fd, DRM_IOCTL_MODE_ADDFB2, &f) == -1 &&
> - errno == EINVAL);
> + errno != 0);
Probably should be do_ioctl_err() instead. JFYI too, there's an old outdated
cocci file for converting things like this automatically that I meant to update.
I made some progress, but had to put it on the backburner because of time
constraints.
> }
>
> /* Just to check that the parameters would work. */
--
Sincerely,
Lyude Paul (she/her)
Software Engineer at Red Hat
Note: I deal with a lot of emails and have a lot of bugs on my plate. If you've
asked me a question, are waiting for a review/merge on a patch, etc. and I
haven't responded in a while, please feel free to send me another email to check
on my status. I don't bite!
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply [flat|nested] 25+ messages in thread
* Re: [igt-dev] [PATCH i-g-t 1/2] tests/kms_addfb_basic: Mark Intel-only tests as such
2020-11-13 16:49 ` [igt-dev] [PATCH i-g-t 1/2] tests/kms_addfb_basic: Mark Intel-only tests as such Jeremy Cline
@ 2020-11-13 19:00 ` Lyude Paul
0 siblings, 0 replies; 25+ messages in thread
From: Lyude Paul @ 2020-11-13 19:00 UTC (permalink / raw)
To: Jeremy Cline, IGT GPU Tools
Reviewed-by: Lyude Paul <lyude@redhat.com>
On Fri, 2020-11-13 at 11:49 -0500, Jeremy Cline wrote:
> Several tests in the addfb suite only apply to i915 devices. Mark them
> as such so these tests are skipped on non-Intel devices.
>
> Signed-off-by: Jeremy Cline <jcline@redhat.com>
> ---
> tests/kms_addfb_basic.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/tests/kms_addfb_basic.c b/tests/kms_addfb_basic.c
> index 9455909c..0ec583fe 100644
> --- a/tests/kms_addfb_basic.c
> +++ b/tests/kms_addfb_basic.c
> @@ -572,6 +572,7 @@ static void addfb25_ytile(int fd)
>
> igt_subtest("addfb25-y-tiled-legacy") {
> igt_require_fb_modifiers(fd);
> + igt_require_intel(fd);
>
> f.modifier[0] = LOCAL_I915_FORMAT_MOD_Y_TILED;
> igt_assert(drmIoctl(fd, LOCAL_DRM_IOCTL_MODE_ADDFB2, &f) ==
> @@ -583,6 +584,7 @@ static void addfb25_ytile(int fd)
>
> igt_subtest("addfb25-yf-tiled-legacy") {
> igt_require_fb_modifiers(fd);
> + igt_require_intel(fd);
>
> f.modifier[0] = LOCAL_I915_FORMAT_MOD_Yf_TILED;
> igt_assert(drmIoctl(fd, LOCAL_DRM_IOCTL_MODE_ADDFB2, &f) ==
> @@ -594,6 +596,7 @@ static void addfb25_ytile(int fd)
>
> igt_subtest("addfb25-y-tiled-small-legacy") {
> igt_require_fb_modifiers(fd);
> + igt_require_intel(fd);
>
> gen = intel_gen(intel_get_drm_devid(fd));
> igt_require(gen >= 9);
--
Sincerely,
Lyude Paul (she/her)
Software Engineer at Red Hat
Note: I deal with a lot of emails and have a lot of bugs on my plate. If you've
asked me a question, are waiting for a review/merge on a patch, etc. and I
haven't responded in a while, please feel free to send me another email to check
on my status. I don't bite!
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply [flat|nested] 25+ messages in thread
* [igt-dev] ✓ Fi.CI.BAT: success for tests/kms_addfb_basic: Nouveau support
2020-11-13 16:49 [igt-dev] [PATCH i-g-t 0/2] tests/kms_addfb_basic: Nouveau support Jeremy Cline
2020-11-13 16:49 ` [igt-dev] [PATCH i-g-t 1/2] tests/kms_addfb_basic: Mark Intel-only tests as such Jeremy Cline
2020-11-13 16:49 ` [igt-dev] [PATCH i-g-t 2/2] tests/kms_addfb_basic: Relax errno assertions Jeremy Cline
@ 2020-11-13 20:27 ` Patchwork
2020-11-14 0:30 ` [igt-dev] ✗ Fi.CI.IGT: failure " Patchwork
2020-11-16 22:18 ` [igt-dev] [PATCH i-g-t v2 0/2] " Jeremy Cline
4 siblings, 0 replies; 25+ messages in thread
From: Patchwork @ 2020-11-13 20:27 UTC (permalink / raw)
To: Jeremy Cline; +Cc: igt-dev
[-- Attachment #1.1: Type: text/plain, Size: 6350 bytes --]
== Series Details ==
Series: tests/kms_addfb_basic: Nouveau support
URL : https://patchwork.freedesktop.org/series/83822/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_9326 -> IGTPW_5170
====================================================
Summary
-------
**SUCCESS**
No regressions found.
External URL: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5170/index.html
Known issues
------------
Here are the changes found in IGTPW_5170 that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@core_hotunplug@unbind-rebind:
- fi-tgl-u2: [PASS][1] -> [DMESG-WARN][2] ([i915#1982])
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9326/fi-tgl-u2/igt@core_hotunplug@unbind-rebind.html
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5170/fi-tgl-u2/igt@core_hotunplug@unbind-rebind.html
* igt@gem_mmap_gtt@basic:
- fi-tgl-y: [PASS][3] -> [DMESG-WARN][4] ([i915#402])
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9326/fi-tgl-y/igt@gem_mmap_gtt@basic.html
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5170/fi-tgl-y/igt@gem_mmap_gtt@basic.html
* igt@i915_module_load@reload:
- fi-byt-j1900: [PASS][5] -> [DMESG-WARN][6] ([i915#1982]) +1 similar issue
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9326/fi-byt-j1900/igt@i915_module_load@reload.html
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5170/fi-byt-j1900/igt@i915_module_load@reload.html
- fi-apl-guc: [PASS][7] -> [DMESG-WARN][8] ([i915#1635] / [i915#203] / [i915#62]) +1 similar issue
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9326/fi-apl-guc/igt@i915_module_load@reload.html
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5170/fi-apl-guc/igt@i915_module_load@reload.html
- fi-tgl-u2: [PASS][9] -> [DMESG-WARN][10] ([i915#1982] / [k.org#205379])
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9326/fi-tgl-u2/igt@i915_module_load@reload.html
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5170/fi-tgl-u2/igt@i915_module_load@reload.html
- fi-icl-y: [PASS][11] -> [DMESG-WARN][12] ([i915#1982])
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9326/fi-icl-y/igt@i915_module_load@reload.html
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5170/fi-icl-y/igt@i915_module_load@reload.html
* igt@i915_pm_rpm@basic-pci-d3-state:
- fi-bsw-kefka: [PASS][13] -> [DMESG-WARN][14] ([i915#1982])
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9326/fi-bsw-kefka/igt@i915_pm_rpm@basic-pci-d3-state.html
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5170/fi-bsw-kefka/igt@i915_pm_rpm@basic-pci-d3-state.html
#### Possible fixes ####
* igt@kms_chamelium@dp-crc-fast:
- fi-cml-u2: [FAIL][15] ([i915#1161] / [i915#262]) -> [PASS][16]
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9326/fi-cml-u2/igt@kms_chamelium@dp-crc-fast.html
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5170/fi-cml-u2/igt@kms_chamelium@dp-crc-fast.html
* igt@kms_cursor_legacy@basic-busy-flip-before-cursor-atomic:
- fi-byt-j1900: [DMESG-WARN][17] ([i915#1982]) -> [PASS][18]
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9326/fi-byt-j1900/igt@kms_cursor_legacy@basic-busy-flip-before-cursor-atomic.html
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5170/fi-byt-j1900/igt@kms_cursor_legacy@basic-busy-flip-before-cursor-atomic.html
* igt@kms_cursor_legacy@basic-busy-flip-before-cursor-legacy:
- fi-icl-u2: [DMESG-WARN][19] ([i915#1982]) -> [PASS][20]
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9326/fi-icl-u2/igt@kms_cursor_legacy@basic-busy-flip-before-cursor-legacy.html
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5170/fi-icl-u2/igt@kms_cursor_legacy@basic-busy-flip-before-cursor-legacy.html
* igt@kms_pipe_crc_basic@read-crc-pipe-c:
- fi-tgl-y: [DMESG-WARN][21] ([i915#1982]) -> [PASS][22]
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9326/fi-tgl-y/igt@kms_pipe_crc_basic@read-crc-pipe-c.html
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5170/fi-tgl-y/igt@kms_pipe_crc_basic@read-crc-pipe-c.html
* igt@prime_vgem@basic-read:
- fi-tgl-y: [DMESG-WARN][23] ([i915#402]) -> [PASS][24] +2 similar issues
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9326/fi-tgl-y/igt@prime_vgem@basic-read.html
[24]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5170/fi-tgl-y/igt@prime_vgem@basic-read.html
#### Warnings ####
* igt@gem_exec_suspend@basic-s3:
- fi-tgl-y: [DMESG-WARN][25] ([i915#2411]) -> [DMESG-WARN][26] ([i915#2411] / [i915#402])
[25]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9326/fi-tgl-y/igt@gem_exec_suspend@basic-s3.html
[26]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5170/fi-tgl-y/igt@gem_exec_suspend@basic-s3.html
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[i915#1161]: https://gitlab.freedesktop.org/drm/intel/issues/1161
[i915#1635]: https://gitlab.freedesktop.org/drm/intel/issues/1635
[i915#1982]: https://gitlab.freedesktop.org/drm/intel/issues/1982
[i915#203]: https://gitlab.freedesktop.org/drm/intel/issues/203
[i915#2411]: https://gitlab.freedesktop.org/drm/intel/issues/2411
[i915#262]: https://gitlab.freedesktop.org/drm/intel/issues/262
[i915#402]: https://gitlab.freedesktop.org/drm/intel/issues/402
[i915#62]: https://gitlab.freedesktop.org/drm/intel/issues/62
[k.org#205379]: https://bugzilla.kernel.org/show_bug.cgi?id=205379
Participating hosts (46 -> 41)
------------------------------
Missing (5): fi-ilk-m540 fi-hsw-4200u fi-bsw-cyan fi-ctg-p8600 fi-bdw-samus
Build changes
-------------
* CI: CI-20190529 -> None
* IGT: IGT_5850 -> IGTPW_5170
CI-20190529: 20190529
CI_DRM_9326: 3048c2a1dcf02422e89930148ffad9e91d690499 @ git://anongit.freedesktop.org/gfx-ci/linux
IGTPW_5170: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5170/index.html
IGT_5850: 9748a4a0f93d108955d374a866e60cb962da9b5d @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5170/index.html
[-- Attachment #1.2: Type: text/html, Size: 7896 bytes --]
[-- Attachment #2: Type: text/plain, Size: 154 bytes --]
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply [flat|nested] 25+ messages in thread
* Re: [igt-dev] [PATCH i-g-t 2/2] tests/kms_addfb_basic: Relax errno assertions
2020-11-13 18:59 ` Lyude Paul
@ 2020-11-13 21:41 ` Jeremy Cline
2020-11-16 11:14 ` Petri Latvala
0 siblings, 1 reply; 25+ messages in thread
From: Jeremy Cline @ 2020-11-13 21:41 UTC (permalink / raw)
To: Lyude Paul; +Cc: IGT GPU Tools
On Fri, Nov 13, 2020 at 01:59:55PM -0500, Lyude Paul wrote:
> On Fri, 2020-11-13 at 11:49 -0500, Jeremy Cline wrote:
> > This adjusts the check on failed calls to DRM_IOCTL_MODE_ADDFB2 in
> > various scenarios. According to the kernel's
> > drm_mode_config_funcs.fb_create documentation, a negative return code is
> > all that is required to signal failure, and different drivers return
> > different errors in these scenarios.
> >
> > Particularly, Nouveau returns -ERANGE rather than -EINVAL in scenarios
> > where the buffer is too small for the proposed configuration.
> >
> > Signed-off-by: Jeremy Cline <jcline@redhat.com>
> > ---
> > tests/kms_addfb_basic.c | 16 ++++++++--------
> > 1 file changed, 8 insertions(+), 8 deletions(-)
> >
> > diff --git a/tests/kms_addfb_basic.c b/tests/kms_addfb_basic.c
> > index 0ec583fe..b284bfc1 100644
> > --- a/tests/kms_addfb_basic.c
> > +++ b/tests/kms_addfb_basic.c
> > @@ -282,7 +282,7 @@ static void pitch_tests(int fd)
> > igt_subtest_f("bad-pitch-%i", bad_pitches[i]) {
> > f.pitches[0] = bad_pitches[i];
> > igt_assert(drmIoctl(fd, DRM_IOCTL_MODE_ADDFB2, &f) ==
> > -1 &&
> > - errno == EINVAL);
> > + errno != 0);
> > }
> > }
> >
> > @@ -413,11 +413,11 @@ static void size_tests(int fd)
> > f_8.width++;
> > igt_subtest("too-wide") {
> > igt_assert(drmIoctl(fd, DRM_IOCTL_MODE_ADDFB2, &f) == -1 &&
> > - errno == EINVAL);
> > + errno != 0);
> > igt_assert(drmIoctl(fd, DRM_IOCTL_MODE_ADDFB2, &f_16) == -1 &&
> > - errno == EINVAL);
> > + errno != 0);
> > igt_assert(drmIoctl(fd, DRM_IOCTL_MODE_ADDFB2, &f_8) == -1 &&
> > - errno == EINVAL);
> > + errno != 0);
> > }
> > f.width--;
> > f_16.width--;
> > @@ -427,17 +427,17 @@ static void size_tests(int fd)
> > f_8.height++;
> > igt_subtest("too-high") {
> > igt_assert(drmIoctl(fd, DRM_IOCTL_MODE_ADDFB2, &f) == -1 &&
> > - errno == EINVAL);
> > + errno != 0);
> > igt_assert(drmIoctl(fd, DRM_IOCTL_MODE_ADDFB2, &f_16) == -1 &&
> > - errno == EINVAL);
> > + errno != 0);
> > igt_assert(drmIoctl(fd, DRM_IOCTL_MODE_ADDFB2, &f_8) == -1 &&
> > - errno == EINVAL);
> > + errno != 0);
> > }
> >
> > f.handles[0] = gem_bo_small;
> > igt_subtest("bo-too-small") {
> > igt_assert(drmIoctl(fd, DRM_IOCTL_MODE_ADDFB2, &f) == -1 &&
> > - errno == EINVAL);
> > + errno != 0);
>
> Probably should be do_ioctl_err() instead. JFYI too, there's an old outdated
> cocci file for converting things like this automatically that I meant to update.
> I made some progress, but had to put it on the backburner because of time
> constraints.
Ah, neat, thanks for the pointer. It looks like the macro wants one to
provide the exact error. It seems like breaking this out into
vendor-specific tests where it checks for EINVAL for Intel and ERANGE
for Nouveau would be better in any case. Assuming I do that, would it be
good to leave this here for generic "at least don't succeed" testing for
any additional vendors?
- Jeremy
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply [flat|nested] 25+ messages in thread
* [igt-dev] ✗ Fi.CI.IGT: failure for tests/kms_addfb_basic: Nouveau support
2020-11-13 16:49 [igt-dev] [PATCH i-g-t 0/2] tests/kms_addfb_basic: Nouveau support Jeremy Cline
` (2 preceding siblings ...)
2020-11-13 20:27 ` [igt-dev] ✓ Fi.CI.BAT: success for tests/kms_addfb_basic: Nouveau support Patchwork
@ 2020-11-14 0:30 ` Patchwork
2020-11-16 22:18 ` [igt-dev] [PATCH i-g-t v2 0/2] " Jeremy Cline
4 siblings, 0 replies; 25+ messages in thread
From: Patchwork @ 2020-11-14 0:30 UTC (permalink / raw)
To: Jeremy Cline; +Cc: igt-dev
[-- Attachment #1.1: Type: text/plain, Size: 27136 bytes --]
== Series Details ==
Series: tests/kms_addfb_basic: Nouveau support
URL : https://patchwork.freedesktop.org/series/83822/
State : failure
== Summary ==
CI Bug Log - changes from CI_DRM_9326_full -> IGTPW_5170_full
====================================================
Summary
-------
**FAILURE**
Serious unknown changes coming with IGTPW_5170_full absolutely need to be
verified manually.
If you think the reported changes have nothing to do with the changes
introduced in IGTPW_5170_full, please notify your bug team to allow them
to document this new failure mode, which will reduce false positives in CI.
External URL: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5170/index.html
Possible new issues
-------------------
Here are the unknown changes that may have been introduced in IGTPW_5170_full:
### IGT changes ###
#### Possible regressions ####
* igt@gem_exec_flush@basic-wb-ro-before-default:
- shard-snb: [PASS][1] -> [FAIL][2]
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9326/shard-snb7/igt@gem_exec_flush@basic-wb-ro-before-default.html
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5170/shard-snb7/igt@gem_exec_flush@basic-wb-ro-before-default.html
* igt@kms_flip@flip-vs-suspend-interruptible@b-hdmi-a1:
- shard-hsw: [PASS][3] -> [INCOMPLETE][4]
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9326/shard-hsw4/igt@kms_flip@flip-vs-suspend-interruptible@b-hdmi-a1.html
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5170/shard-hsw8/igt@kms_flip@flip-vs-suspend-interruptible@b-hdmi-a1.html
#### Warnings ####
* igt@i915_pm_rc6_residency@rc6-fence:
- shard-iclb: [WARN][5] ([i915#1515]) -> [WARN][6] +1 similar issue
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9326/shard-iclb4/igt@i915_pm_rc6_residency@rc6-fence.html
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5170/shard-iclb6/igt@i915_pm_rc6_residency@rc6-fence.html
Known issues
------------
Here are the changes found in IGTPW_5170_full that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@core_hotunplug@hotrebind-lateclose:
- shard-glk: [PASS][7] -> [INCOMPLETE][8] ([i915#2643])
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9326/shard-glk2/igt@core_hotunplug@hotrebind-lateclose.html
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5170/shard-glk9/igt@core_hotunplug@hotrebind-lateclose.html
- shard-kbl: [PASS][9] -> [INCOMPLETE][10] ([i915#2643])
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9326/shard-kbl4/igt@core_hotunplug@hotrebind-lateclose.html
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5170/shard-kbl6/igt@core_hotunplug@hotrebind-lateclose.html
* igt@gem_exec_reloc@basic-many-active@rcs0:
- shard-glk: [PASS][11] -> [FAIL][12] ([i915#2389])
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9326/shard-glk7/igt@gem_exec_reloc@basic-many-active@rcs0.html
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5170/shard-glk2/igt@gem_exec_reloc@basic-many-active@rcs0.html
* igt@i915_pm_rpm@cursor:
- shard-iclb: [PASS][13] -> [SKIP][14] ([i915#579])
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9326/shard-iclb2/igt@i915_pm_rpm@cursor.html
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5170/shard-iclb7/igt@i915_pm_rpm@cursor.html
* igt@kms_cursor_legacy@cursora-vs-flipa-atomic-transitions-varying-size:
- shard-glk: [PASS][15] -> [DMESG-WARN][16] ([i915#1982]) +4 similar issues
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9326/shard-glk3/igt@kms_cursor_legacy@cursora-vs-flipa-atomic-transitions-varying-size.html
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5170/shard-glk8/igt@kms_cursor_legacy@cursora-vs-flipa-atomic-transitions-varying-size.html
* igt@kms_draw_crc@draw-method-xrgb2101010-mmap-cpu-ytiled:
- shard-apl: [PASS][17] -> [DMESG-WARN][18] ([i915#1635] / [i915#1982]) +2 similar issues
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9326/shard-apl4/igt@kms_draw_crc@draw-method-xrgb2101010-mmap-cpu-ytiled.html
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5170/shard-apl7/igt@kms_draw_crc@draw-method-xrgb2101010-mmap-cpu-ytiled.html
* igt@kms_flip@2x-flip-vs-panning-interruptible@ab-vga1-hdmi-a1:
- shard-hsw: [PASS][19] -> [DMESG-WARN][20] ([i915#1982])
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9326/shard-hsw1/igt@kms_flip@2x-flip-vs-panning-interruptible@ab-vga1-hdmi-a1.html
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5170/shard-hsw6/igt@kms_flip@2x-flip-vs-panning-interruptible@ab-vga1-hdmi-a1.html
* igt@kms_flip@2x-flip-vs-suspend@bc-vga1-hdmi-a1:
- shard-hsw: [PASS][21] -> [INCOMPLETE][22] ([i915#2055])
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9326/shard-hsw2/igt@kms_flip@2x-flip-vs-suspend@bc-vga1-hdmi-a1.html
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5170/shard-hsw1/igt@kms_flip@2x-flip-vs-suspend@bc-vga1-hdmi-a1.html
* igt@kms_flip@plain-flip-ts-check@c-hdmi-a2:
- shard-glk: [PASS][23] -> [FAIL][24] ([i915#2122])
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9326/shard-glk7/igt@kms_flip@plain-flip-ts-check@c-hdmi-a2.html
[24]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5170/shard-glk3/igt@kms_flip@plain-flip-ts-check@c-hdmi-a2.html
* igt@kms_frontbuffer_tracking@fbc-1p-offscren-pri-indfb-draw-render:
- shard-kbl: [PASS][25] -> [DMESG-WARN][26] ([i915#1982]) +1 similar issue
[25]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9326/shard-kbl4/igt@kms_frontbuffer_tracking@fbc-1p-offscren-pri-indfb-draw-render.html
[26]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5170/shard-kbl2/igt@kms_frontbuffer_tracking@fbc-1p-offscren-pri-indfb-draw-render.html
* igt@kms_frontbuffer_tracking@fbc-1p-primscrn-cur-indfb-draw-blt:
- shard-snb: [PASS][27] -> [FAIL][28] ([i915#2546])
[27]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9326/shard-snb5/igt@kms_frontbuffer_tracking@fbc-1p-primscrn-cur-indfb-draw-blt.html
[28]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5170/shard-snb7/igt@kms_frontbuffer_tracking@fbc-1p-primscrn-cur-indfb-draw-blt.html
* igt@kms_frontbuffer_tracking@fbc-badstride:
- shard-iclb: [PASS][29] -> [DMESG-WARN][30] ([i915#1982])
[29]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9326/shard-iclb2/igt@kms_frontbuffer_tracking@fbc-badstride.html
[30]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5170/shard-iclb5/igt@kms_frontbuffer_tracking@fbc-badstride.html
* igt@kms_psr@psr2_basic:
- shard-iclb: [PASS][31] -> [SKIP][32] ([fdo#109441]) +1 similar issue
[31]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9326/shard-iclb2/igt@kms_psr@psr2_basic.html
[32]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5170/shard-iclb3/igt@kms_psr@psr2_basic.html
* igt@kms_vblank@pipe-a-wait-busy:
- shard-tglb: [PASS][33] -> [DMESG-WARN][34] ([i915#1982]) +3 similar issues
[33]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9326/shard-tglb6/igt@kms_vblank@pipe-a-wait-busy.html
[34]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5170/shard-tglb2/igt@kms_vblank@pipe-a-wait-busy.html
* igt@kms_vblank@pipe-c-ts-continuation-modeset-rpm:
- shard-hsw: [PASS][35] -> [SKIP][36] ([fdo#109271]) +3 similar issues
[35]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9326/shard-hsw8/igt@kms_vblank@pipe-c-ts-continuation-modeset-rpm.html
[36]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5170/shard-hsw1/igt@kms_vblank@pipe-c-ts-continuation-modeset-rpm.html
- shard-kbl: [PASS][37] -> [SKIP][38] ([fdo#109271]) +1 similar issue
[37]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9326/shard-kbl1/igt@kms_vblank@pipe-c-ts-continuation-modeset-rpm.html
[38]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5170/shard-kbl3/igt@kms_vblank@pipe-c-ts-continuation-modeset-rpm.html
- shard-apl: [PASS][39] -> [SKIP][40] ([fdo#109271] / [i915#1635]) +1 similar issue
[39]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9326/shard-apl1/igt@kms_vblank@pipe-c-ts-continuation-modeset-rpm.html
[40]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5170/shard-apl2/igt@kms_vblank@pipe-c-ts-continuation-modeset-rpm.html
- shard-glk: [PASS][41] -> [SKIP][42] ([fdo#109271]) +1 similar issue
[41]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9326/shard-glk7/igt@kms_vblank@pipe-c-ts-continuation-modeset-rpm.html
[42]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5170/shard-glk2/igt@kms_vblank@pipe-c-ts-continuation-modeset-rpm.html
- shard-iclb: [PASS][43] -> [SKIP][44] ([fdo#109278])
[43]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9326/shard-iclb4/igt@kms_vblank@pipe-c-ts-continuation-modeset-rpm.html
[44]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5170/shard-iclb7/igt@kms_vblank@pipe-c-ts-continuation-modeset-rpm.html
* igt@perf@disabled-read-error:
- shard-glk: [PASS][45] -> [SKIP][46] ([fdo#109271] / [i915#1354]) +1 similar issue
[45]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9326/shard-glk3/igt@perf@disabled-read-error.html
[46]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5170/shard-glk8/igt@perf@disabled-read-error.html
- shard-apl: [PASS][47] -> [SKIP][48] ([fdo#109271] / [i915#1354] / [i915#1635]) +1 similar issue
[47]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9326/shard-apl2/igt@perf@disabled-read-error.html
[48]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5170/shard-apl4/igt@perf@disabled-read-error.html
- shard-tglb: [PASS][49] -> [SKIP][50] ([i915#1354]) +1 similar issue
[49]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9326/shard-tglb6/igt@perf@disabled-read-error.html
[50]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5170/shard-tglb3/igt@perf@disabled-read-error.html
* igt@perf@stress-open-close:
- shard-kbl: [PASS][51] -> [SKIP][52] ([fdo#109271] / [i915#1354]) +1 similar issue
[51]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9326/shard-kbl4/igt@perf@stress-open-close.html
[52]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5170/shard-kbl6/igt@perf@stress-open-close.html
- shard-iclb: [PASS][53] -> [SKIP][54] ([i915#1354]) +1 similar issue
[53]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9326/shard-iclb5/igt@perf@stress-open-close.html
[54]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5170/shard-iclb4/igt@perf@stress-open-close.html
#### Possible fixes ####
* igt@gem_exec_whisper@basic-queues-priority:
- shard-glk: [DMESG-WARN][55] ([i915#118] / [i915#95]) -> [PASS][56]
[55]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9326/shard-glk1/igt@gem_exec_whisper@basic-queues-priority.html
[56]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5170/shard-glk7/igt@gem_exec_whisper@basic-queues-priority.html
* igt@gem_softpin@noreloc-s3:
- shard-iclb: [INCOMPLETE][57] ([i915#1373]) -> [PASS][58]
[57]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9326/shard-iclb8/igt@gem_softpin@noreloc-s3.html
[58]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5170/shard-iclb4/igt@gem_softpin@noreloc-s3.html
- shard-apl: [INCOMPLETE][59] ([i915#1635] / [i915#2635]) -> [PASS][60] +1 similar issue
[59]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9326/shard-apl4/igt@gem_softpin@noreloc-s3.html
[60]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5170/shard-apl4/igt@gem_softpin@noreloc-s3.html
- shard-glk: [INCOMPLETE][61] ([i915#2199] / [i915#2635]) -> [PASS][62]
[61]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9326/shard-glk8/igt@gem_softpin@noreloc-s3.html
[62]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5170/shard-glk8/igt@gem_softpin@noreloc-s3.html
- shard-hsw: [INCOMPLETE][63] ([i915#2637]) -> [PASS][64]
[63]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9326/shard-hsw5/igt@gem_softpin@noreloc-s3.html
[64]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5170/shard-hsw6/igt@gem_softpin@noreloc-s3.html
- shard-kbl: [INCOMPLETE][65] -> [PASS][66]
[65]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9326/shard-kbl6/igt@gem_softpin@noreloc-s3.html
[66]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5170/shard-kbl6/igt@gem_softpin@noreloc-s3.html
* igt@i915_module_load@reload:
- shard-iclb: [DMESG-WARN][67] ([i915#1982]) -> [PASS][68]
[67]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9326/shard-iclb2/igt@i915_module_load@reload.html
[68]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5170/shard-iclb8/igt@i915_module_load@reload.html
* igt@i915_pm_rpm@i2c:
- shard-glk: [DMESG-WARN][69] ([i915#1982]) -> [PASS][70] +7 similar issues
[69]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9326/shard-glk9/igt@i915_pm_rpm@i2c.html
[70]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5170/shard-glk4/igt@i915_pm_rpm@i2c.html
* igt@kms_cursor_legacy@2x-long-cursor-vs-flip-atomic:
- shard-hsw: [FAIL][71] ([i915#96]) -> [PASS][72]
[71]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9326/shard-hsw8/igt@kms_cursor_legacy@2x-long-cursor-vs-flip-atomic.html
[72]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5170/shard-hsw2/igt@kms_cursor_legacy@2x-long-cursor-vs-flip-atomic.html
* igt@kms_cursor_legacy@basic-flip-before-cursor-legacy:
- shard-kbl: [DMESG-WARN][73] ([i915#1982]) -> [PASS][74] +2 similar issues
[73]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9326/shard-kbl1/igt@kms_cursor_legacy@basic-flip-before-cursor-legacy.html
[74]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5170/shard-kbl6/igt@kms_cursor_legacy@basic-flip-before-cursor-legacy.html
* igt@kms_draw_crc@draw-method-xrgb2101010-mmap-wc-ytiled:
- shard-apl: [DMESG-WARN][75] ([i915#1635] / [i915#1982]) -> [PASS][76] +5 similar issues
[75]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9326/shard-apl6/igt@kms_draw_crc@draw-method-xrgb2101010-mmap-wc-ytiled.html
[76]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5170/shard-apl8/igt@kms_draw_crc@draw-method-xrgb2101010-mmap-wc-ytiled.html
* igt@kms_draw_crc@draw-method-xrgb8888-blt-untiled:
- shard-snb: [FAIL][77] ([i915#54]) -> [PASS][78]
[77]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9326/shard-snb5/igt@kms_draw_crc@draw-method-xrgb8888-blt-untiled.html
[78]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5170/shard-snb4/igt@kms_draw_crc@draw-method-xrgb8888-blt-untiled.html
* igt@kms_frontbuffer_tracking@fbcpsr-1p-offscren-pri-shrfb-draw-pwrite:
- shard-tglb: [DMESG-WARN][79] ([i915#1982]) -> [PASS][80] +1 similar issue
[79]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9326/shard-tglb8/igt@kms_frontbuffer_tracking@fbcpsr-1p-offscren-pri-shrfb-draw-pwrite.html
[80]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5170/shard-tglb6/igt@kms_frontbuffer_tracking@fbcpsr-1p-offscren-pri-shrfb-draw-pwrite.html
* igt@kms_pipe_crc_basic@suspend-read-crc-pipe-a:
- shard-hsw: [INCOMPLETE][81] ([i915#2055] / [i915#2637]) -> [PASS][82]
[81]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9326/shard-hsw2/igt@kms_pipe_crc_basic@suspend-read-crc-pipe-a.html
[82]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5170/shard-hsw4/igt@kms_pipe_crc_basic@suspend-read-crc-pipe-a.html
- shard-kbl: [INCOMPLETE][83] ([i915#155]) -> [PASS][84]
[83]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9326/shard-kbl6/igt@kms_pipe_crc_basic@suspend-read-crc-pipe-a.html
[84]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5170/shard-kbl7/igt@kms_pipe_crc_basic@suspend-read-crc-pipe-a.html
- shard-glk: [INCOMPLETE][85] ([i915#2635]) -> [PASS][86]
[85]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9326/shard-glk8/igt@kms_pipe_crc_basic@suspend-read-crc-pipe-a.html
[86]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5170/shard-glk7/igt@kms_pipe_crc_basic@suspend-read-crc-pipe-a.html
- shard-iclb: [INCOMPLETE][87] ([i915#1185]) -> [PASS][88]
[87]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9326/shard-iclb5/igt@kms_pipe_crc_basic@suspend-read-crc-pipe-a.html
[88]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5170/shard-iclb3/igt@kms_pipe_crc_basic@suspend-read-crc-pipe-a.html
* igt@kms_psr@psr2_sprite_mmap_gtt:
- shard-iclb: [SKIP][89] ([fdo#109441]) -> [PASS][90] +1 similar issue
[89]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9326/shard-iclb1/igt@kms_psr@psr2_sprite_mmap_gtt.html
[90]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5170/shard-iclb2/igt@kms_psr@psr2_sprite_mmap_gtt.html
* igt@kms_setmode@basic:
- shard-hsw: [FAIL][91] ([i915#31]) -> [PASS][92]
[91]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9326/shard-hsw2/igt@kms_setmode@basic.html
[92]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5170/shard-hsw6/igt@kms_setmode@basic.html
* igt@perf@polling-parameterized:
- shard-hsw: [FAIL][93] ([i915#1542]) -> [PASS][94]
[93]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9326/shard-hsw6/igt@perf@polling-parameterized.html
[94]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5170/shard-hsw4/igt@perf@polling-parameterized.html
#### Warnings ####
* igt@core_hotunplug@hotrebind-lateclose:
- shard-apl: [DMESG-WARN][95] ([i915#1635] / [i915#1982]) -> [INCOMPLETE][96] ([i915#1635] / [i915#2643])
[95]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9326/shard-apl7/igt@core_hotunplug@hotrebind-lateclose.html
[96]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5170/shard-apl4/igt@core_hotunplug@hotrebind-lateclose.html
* igt@gem_softpin@noreloc-s3:
- shard-tglb: [DMESG-WARN][97] ([i915#1436]) -> [DMESG-WARN][98] ([i915#2411])
[97]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9326/shard-tglb5/igt@gem_softpin@noreloc-s3.html
[98]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5170/shard-tglb3/igt@gem_softpin@noreloc-s3.html
* igt@i915_pm_rpm@cursor:
- shard-tglb: [DMESG-WARN][99] ([i915#2411]) -> [SKIP][100] ([i915#579])
[99]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9326/shard-tglb1/igt@i915_pm_rpm@cursor.html
[100]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5170/shard-tglb2/igt@i915_pm_rpm@cursor.html
* igt@kms_dp_dsc@basic-dsc-enable-edp:
- shard-iclb: [DMESG-WARN][101] ([i915#1226]) -> [SKIP][102] ([fdo#109349])
[101]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9326/shard-iclb2/igt@kms_dp_dsc@basic-dsc-enable-edp.html
[102]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5170/shard-iclb6/igt@kms_dp_dsc@basic-dsc-enable-edp.html
* igt@kms_pipe_crc_basic@suspend-read-crc-pipe-a:
- shard-tglb: [INCOMPLETE][103] ([i915#1436] / [i915#456]) -> [DMESG-WARN][104] ([i915#2411])
[103]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9326/shard-tglb6/igt@kms_pipe_crc_basic@suspend-read-crc-pipe-a.html
[104]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5170/shard-tglb1/igt@kms_pipe_crc_basic@suspend-read-crc-pipe-a.html
* igt@kms_vblank@pipe-c-ts-continuation-modeset-rpm:
- shard-tglb: [DMESG-WARN][105] ([i915#2411]) -> [SKIP][106] ([i915#2648])
[105]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9326/shard-tglb3/igt@kms_vblank@pipe-c-ts-continuation-modeset-rpm.html
[106]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5170/shard-tglb2/igt@kms_vblank@pipe-c-ts-continuation-modeset-rpm.html
* igt@runner@aborted:
- shard-hsw: ([FAIL][107], [FAIL][108]) ([fdo#109271] / [i915#2295] / [i915#2439]) -> [FAIL][109] ([i915#2295])
[107]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9326/shard-hsw5/igt@runner@aborted.html
[108]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9326/shard-hsw2/igt@runner@aborted.html
[109]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5170/shard-hsw8/igt@runner@aborted.html
- shard-kbl: [FAIL][110] ([i915#1611] / [i915#2295] / [i915#2439]) -> ([FAIL][111], [FAIL][112]) ([i915#1611] / [i915#2295] / [i915#2439] / [i915#483])
[110]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9326/shard-kbl7/igt@runner@aborted.html
[111]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5170/shard-kbl1/igt@runner@aborted.html
[112]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5170/shard-kbl6/igt@runner@aborted.html
- shard-iclb: ([FAIL][113], [FAIL][114], [FAIL][115]) ([i915#1814] / [i915#2295] / [i915#2439] / [i915#483]) -> ([FAIL][116], [FAIL][117]) ([i915#2295] / [i915#2439] / [i915#483])
[113]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9326/shard-iclb5/igt@runner@aborted.html
[114]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9326/shard-iclb6/igt@runner@aborted.html
[115]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9326/shard-iclb8/igt@runner@aborted.html
[116]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5170/shard-iclb7/igt@runner@aborted.html
[117]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5170/shard-iclb4/igt@runner@aborted.html
- shard-apl: ([FAIL][118], [FAIL][119], [FAIL][120]) ([fdo#109271] / [i915#1611] / [i915#1635] / [i915#1814] / [i915#2295] / [i915#2439]) -> ([FAIL][121], [FAIL][122]) ([i915#1611] / [i915#1635] / [i915#2295] / [i915#2439])
[118]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9326/shard-apl4/igt@runner@aborted.html
[119]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9326/shard-apl2/igt@runner@aborted.html
[120]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9326/shard-apl2/igt@runner@aborted.html
[121]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5170/shard-apl4/igt@runner@aborted.html
[122]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5170/shard-apl2/igt@runner@aborted.html
- shard-glk: ([FAIL][123], [FAIL][124], [FAIL][125]) ([i915#1611] / [i915#1814] / [i915#2295] / [i915#2439] / [i915#86] / [k.org#202321]) -> ([FAIL][126], [FAIL][127]) ([i915#1611] / [i915#2295] / [i915#2439] / [k.org#202321])
[123]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9326/shard-glk8/igt@runner@aborted.html
[124]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9326/shard-glk8/igt@runner@aborted.html
[125]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9326/shard-glk1/igt@runner@aborted.html
[126]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5170/shard-glk9/igt@runner@aborted.html
[127]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5170/shard-glk4/igt@runner@aborted.html
- shard-tglb: ([FAIL][128], [FAIL][129], [FAIL][130]) ([i915#1602] / [i915#2295] / [i915#2439] / [i915#456]) -> ([FAIL][131], [FAIL][132]) ([i915#1602] / [i915#2295] / [i915#2439])
[128]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9326/shard-tglb6/igt@runner@aborted.html
[129]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9326/shard-tglb3/igt@runner@aborted.html
[130]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9326/shard-tglb5/igt@runner@aborted.html
[131]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5170/shard-tglb1/igt@runner@aborted.html
[132]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5170/shard-tglb3/igt@runner@aborted.html
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[fdo#109278]: https://bugs.freedesktop.org/show_bug.cgi?id=109278
[fdo#109349]: https://bugs.freedesktop.org/show_bug.cgi?id=109349
[fdo#109441]: https://bugs.freedesktop.org/show_bug.cgi?id=109441
[i915#118]: https://gitlab.freedesktop.org/drm/intel/issues/118
[i915#1185]: https://gitlab.freedesktop.org/drm/intel/issues/1185
[i915#1226]: https://gitlab.freedesktop.org/drm/intel/issues/1226
[i915#1354]: https://gitlab.freedesktop.org/drm/intel/issues/1354
[i915#1373]: https://gitlab.freedesktop.org/drm/intel/issues/1373
[i915#1436]: https://gitlab.freedesktop.org/drm/intel/issues/1436
[i915#1515]: https://gitlab.freedesktop.org/drm/intel/issues/1515
[i915#1542]: https://gitlab.freedesktop.org/drm/intel/issues/1542
[i915#155]: https://gitlab.freedesktop.org/drm/intel/issues/155
[i915#1602]: https://gitlab.freedesktop.org/drm/intel/issues/1602
[i915#1611]: https://gitlab.freedesktop.org/drm/intel/issues/1611
[i915#1635]: https://gitlab.freedesktop.org/drm/intel/issues/1635
[i915#1814]: https://gitlab.freedesktop.org/drm/intel/issues/1814
[i915#1982]: https://gitlab.freedesktop.org/drm/intel/issues/1982
[i915#2055]: https://gitlab.freedesktop.org/drm/intel/issues/2055
[i915#2122]: https://gitlab.freedesktop.org/drm/intel/issues/2122
[i915#2199]: https://gitlab.freedesktop.org/drm/intel/issues/2199
[i915#2295]: https://gitlab.freedesktop.org/drm/intel/issues/2295
[i915#2389]: https://gitlab.freedesktop.org/drm/intel/issues/2389
[i915#2411]: https://gitlab.freedesktop.org/drm/intel/issues/2411
[i915#2439]: https://gitlab.freedesktop.org/drm/intel/issues/2439
[i915#2546]: https://gitlab.freedesktop.org/drm/intel/issues/2546
[i915#2597]: https://gitlab.freedesktop.org/drm/intel/issues/2597
[i915#2635]: https://gitlab.freedesktop.org/drm/intel/issues/2635
[i915#2637]: https://gitlab.freedesktop.org/drm/intel/issues/2637
[i915#2643]: https://gitlab.freedesktop.org/drm/intel/issues/2643
[i915#2648]: https://gitlab.freedesktop.org/drm/intel/issues/2648
[i915#31]: https://gitlab.freedesktop.org/drm/intel/issues/31
[i915#456]: https://gitlab.freedesktop.org/drm/intel/issues/456
[i915#483]: https://gitlab.freedesktop.org/drm/intel/issues/483
[i915#54]: https://gitlab.freedesktop.org/drm/intel/issues/54
[i915#579]: https://gitlab.freedesktop.org/drm/intel/issues/579
[i915#86]: https://gitlab.freedesktop.org/drm/intel/issues/86
[i915#95]: https://gitlab.freedesktop.org/drm/intel/issues/95
[i915#96]: https://gitlab.freedesktop.org/drm/intel/issues/96
[k.org#202321]: https://bugzilla.kernel.org/show_bug.cgi?id=202321
Participating hosts (11 -> 8)
------------------------------
Missing (3): pig-skl-6260u pig-glk-j5005 pig-icl-1065g7
Build changes
-------------
* CI: CI-20190529 -> None
* IGT: IGT_5850 -> IGTPW_5170
* Piglit: piglit_4509 -> None
CI-20190529: 20190529
CI_DRM_9326: 3048c2a1dcf02422e89930148ffad9e91d690499 @ git://anongit.freedesktop.org/gfx-ci/linux
IGTPW_5170: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5170/index.html
IGT_5850: 9748a4a0f93d108955d374a866e60cb962da9b5d @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5170/index.html
[-- Attachment #1.2: Type: text/html, Size: 34230 bytes --]
[-- Attachment #2: Type: text/plain, Size: 154 bytes --]
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply [flat|nested] 25+ messages in thread
* Re: [igt-dev] [PATCH i-g-t 2/2] tests/kms_addfb_basic: Relax errno assertions
2020-11-13 21:41 ` Jeremy Cline
@ 2020-11-16 11:14 ` Petri Latvala
0 siblings, 0 replies; 25+ messages in thread
From: Petri Latvala @ 2020-11-16 11:14 UTC (permalink / raw)
To: Jeremy Cline; +Cc: IGT GPU Tools
On Fri, Nov 13, 2020 at 04:41:16PM -0500, Jeremy Cline wrote:
> On Fri, Nov 13, 2020 at 01:59:55PM -0500, Lyude Paul wrote:
> > On Fri, 2020-11-13 at 11:49 -0500, Jeremy Cline wrote:
> > > This adjusts the check on failed calls to DRM_IOCTL_MODE_ADDFB2 in
> > > various scenarios. According to the kernel's
> > > drm_mode_config_funcs.fb_create documentation, a negative return code is
> > > all that is required to signal failure, and different drivers return
> > > different errors in these scenarios.
> > >
> > > Particularly, Nouveau returns -ERANGE rather than -EINVAL in scenarios
> > > where the buffer is too small for the proposed configuration.
> > >
> > > Signed-off-by: Jeremy Cline <jcline@redhat.com>
> > > ---
> > > tests/kms_addfb_basic.c | 16 ++++++++--------
> > > 1 file changed, 8 insertions(+), 8 deletions(-)
> > >
> > > diff --git a/tests/kms_addfb_basic.c b/tests/kms_addfb_basic.c
> > > index 0ec583fe..b284bfc1 100644
> > > --- a/tests/kms_addfb_basic.c
> > > +++ b/tests/kms_addfb_basic.c
> > > @@ -282,7 +282,7 @@ static void pitch_tests(int fd)
> > > igt_subtest_f("bad-pitch-%i", bad_pitches[i]) {
> > > f.pitches[0] = bad_pitches[i];
> > > igt_assert(drmIoctl(fd, DRM_IOCTL_MODE_ADDFB2, &f) ==
> > > -1 &&
> > > - errno == EINVAL);
> > > + errno != 0);
> > > }
> > > }
> > >
> > > @@ -413,11 +413,11 @@ static void size_tests(int fd)
> > > f_8.width++;
> > > igt_subtest("too-wide") {
> > > igt_assert(drmIoctl(fd, DRM_IOCTL_MODE_ADDFB2, &f) == -1 &&
> > > - errno == EINVAL);
> > > + errno != 0);
> > > igt_assert(drmIoctl(fd, DRM_IOCTL_MODE_ADDFB2, &f_16) == -1 &&
> > > - errno == EINVAL);
> > > + errno != 0);
> > > igt_assert(drmIoctl(fd, DRM_IOCTL_MODE_ADDFB2, &f_8) == -1 &&
> > > - errno == EINVAL);
> > > + errno != 0);
> > > }
> > > f.width--;
> > > f_16.width--;
> > > @@ -427,17 +427,17 @@ static void size_tests(int fd)
> > > f_8.height++;
> > > igt_subtest("too-high") {
> > > igt_assert(drmIoctl(fd, DRM_IOCTL_MODE_ADDFB2, &f) == -1 &&
> > > - errno == EINVAL);
> > > + errno != 0);
> > > igt_assert(drmIoctl(fd, DRM_IOCTL_MODE_ADDFB2, &f_16) == -1 &&
> > > - errno == EINVAL);
> > > + errno != 0);
> > > igt_assert(drmIoctl(fd, DRM_IOCTL_MODE_ADDFB2, &f_8) == -1 &&
> > > - errno == EINVAL);
> > > + errno != 0);
> > > }
> > >
> > > f.handles[0] = gem_bo_small;
> > > igt_subtest("bo-too-small") {
> > > igt_assert(drmIoctl(fd, DRM_IOCTL_MODE_ADDFB2, &f) == -1 &&
> > > - errno == EINVAL);
> > > + errno != 0);
> >
> > Probably should be do_ioctl_err() instead. JFYI too, there's an old outdated
> > cocci file for converting things like this automatically that I meant to update.
> > I made some progress, but had to put it on the backburner because of time
> > constraints.
>
> Ah, neat, thanks for the pointer. It looks like the macro wants one to
> provide the exact error. It seems like breaking this out into
> vendor-specific tests where it checks for EINVAL for Intel and ERANGE
> for Nouveau would be better in any case. Assuming I do that, would it be
> good to leave this here for generic "at least don't succeed" testing for
> any additional vendors?
Yeah, +1 for vendor-specific error code checks, +1 for fallback to
"any error". Also add an igt_info() in the fallback that tells what
the error code was.
--
Petri Latvala
>
> - Jeremy
>
> _______________________________________________
> igt-dev mailing list
> igt-dev@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/igt-dev
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply [flat|nested] 25+ messages in thread
* [igt-dev] [PATCH i-g-t v2 0/2] tests/kms_addfb_basic: Nouveau support
2020-11-13 16:49 [igt-dev] [PATCH i-g-t 0/2] tests/kms_addfb_basic: Nouveau support Jeremy Cline
` (3 preceding siblings ...)
2020-11-14 0:30 ` [igt-dev] ✗ Fi.CI.IGT: failure " Patchwork
@ 2020-11-16 22:18 ` Jeremy Cline
2020-11-16 22:18 ` [igt-dev] [PATCH i-g-t v2 1/2] tests/kms_addfb_basic: Mark Intel-only tests as such Jeremy Cline
` (4 more replies)
4 siblings, 5 replies; 25+ messages in thread
From: Jeremy Cline @ 2020-11-16 22:18 UTC (permalink / raw)
To: IGT GPU Tools; +Cc: Petri Latvala
Hi folks,
I've been going through IGT's existing tests and seeing what they
uncover when pointed at nouveau. The kms_addfb_basic tests appear to be
largely vendor-agnostic, but there's a few simple cases that need fixing
for the test suite to pass with Nouveau.
The two issues are that there are a few tests that are specifically for
Intel GPUs, and there's some minor error code differences between i915
and nouveau (which both seem to be okay based on the API docs I could
find).
Changes since the first version (thanks for the reviews and
suggestions!):
* Where the error code differences occur, I've added vendor-specific
assertions in addition to the generic assertions of a non-zero errno.
Since the divergence is currently quite small, I've left them inline
with the generic tests, but they're labeled so they could be easily
broken out into separate files if necessary.
* Some igt_info statements have been added to the generic assertions.
Jeremy Cline (2):
tests/kms_addfb_basic: Mark Intel-only tests as such
tests/kms_addfb_basic: add vendor-specific errno assertions
tests/kms_addfb_basic.c | 66 +++++++++++++++++++++++++++++++++++++----
1 file changed, 60 insertions(+), 6 deletions(-)
--
2.28.0
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply [flat|nested] 25+ messages in thread
* [igt-dev] [PATCH i-g-t v2 1/2] tests/kms_addfb_basic: Mark Intel-only tests as such
2020-11-16 22:18 ` [igt-dev] [PATCH i-g-t v2 0/2] " Jeremy Cline
@ 2020-11-16 22:18 ` Jeremy Cline
2020-11-16 22:18 ` [igt-dev] [PATCH i-g-t v2 2/2] tests/kms_addfb_basic: add vendor-specific errno assertions Jeremy Cline
` (3 subsequent siblings)
4 siblings, 0 replies; 25+ messages in thread
From: Jeremy Cline @ 2020-11-16 22:18 UTC (permalink / raw)
To: IGT GPU Tools; +Cc: Petri Latvala
Several tests in the addfb suite only apply to i915 devices. Mark them
as such so these tests are skipped on non-Intel devices.
Reviewed-by: Lyude Paul <lyude@redhat.com>
Signed-off-by: Jeremy Cline <jcline@redhat.com>
---
tests/kms_addfb_basic.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/tests/kms_addfb_basic.c b/tests/kms_addfb_basic.c
index 9455909c..0ec583fe 100644
--- a/tests/kms_addfb_basic.c
+++ b/tests/kms_addfb_basic.c
@@ -572,6 +572,7 @@ static void addfb25_ytile(int fd)
igt_subtest("addfb25-y-tiled-legacy") {
igt_require_fb_modifiers(fd);
+ igt_require_intel(fd);
f.modifier[0] = LOCAL_I915_FORMAT_MOD_Y_TILED;
igt_assert(drmIoctl(fd, LOCAL_DRM_IOCTL_MODE_ADDFB2, &f) ==
@@ -583,6 +584,7 @@ static void addfb25_ytile(int fd)
igt_subtest("addfb25-yf-tiled-legacy") {
igt_require_fb_modifiers(fd);
+ igt_require_intel(fd);
f.modifier[0] = LOCAL_I915_FORMAT_MOD_Yf_TILED;
igt_assert(drmIoctl(fd, LOCAL_DRM_IOCTL_MODE_ADDFB2, &f) ==
@@ -594,6 +596,7 @@ static void addfb25_ytile(int fd)
igt_subtest("addfb25-y-tiled-small-legacy") {
igt_require_fb_modifiers(fd);
+ igt_require_intel(fd);
gen = intel_gen(intel_get_drm_devid(fd));
igt_require(gen >= 9);
--
2.28.0
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply related [flat|nested] 25+ messages in thread
* [igt-dev] [PATCH i-g-t v2 2/2] tests/kms_addfb_basic: add vendor-specific errno assertions
2020-11-16 22:18 ` [igt-dev] [PATCH i-g-t v2 0/2] " Jeremy Cline
2020-11-16 22:18 ` [igt-dev] [PATCH i-g-t v2 1/2] tests/kms_addfb_basic: Mark Intel-only tests as such Jeremy Cline
@ 2020-11-16 22:18 ` Jeremy Cline
2020-11-17 7:31 ` Petri Latvala
2020-11-17 20:02 ` [igt-dev] [PATCH i-g-t v3 0/2] tests/kms_addfb_basic: Nouveau support Jeremy Cline
` (2 subsequent siblings)
4 siblings, 1 reply; 25+ messages in thread
From: Jeremy Cline @ 2020-11-16 22:18 UTC (permalink / raw)
To: IGT GPU Tools; +Cc: Petri Latvala
This adjusts the check on failed calls to DRM_IOCTL_MODE_ADDFB2 in
various scenarios. According to the kernel's
drm_mode_config_funcs.fb_create documentation, a negative return code is
all that is required to signal failure, and different drivers return
different errors in these scenarios.
Particularly, Nouveau returns -ERANGE rather than -EINVAL in scenarios
where the buffer is too small for the proposed configuration.
In situations where Nouveau and Intel return codes diverge, this splits
up the test into a generic test asserting a non-zero error code,
followed by some vendor-specific assertions about its exact value.
Signed-off-by: Jeremy Cline <jcline@redhat.com>
---
Changes since v1:
- Added vendor-specific assertions for exact error numbers
- Added igt_info statements to the generic test cases
- Made use of do_ioctl_err() macro when possible
tests/kms_addfb_basic.c | 64 +++++++++++++++++++++++++++++++++++++----
1 file changed, 58 insertions(+), 6 deletions(-)
diff --git a/tests/kms_addfb_basic.c b/tests/kms_addfb_basic.c
index 0ec583fe..9b936584 100644
--- a/tests/kms_addfb_basic.c
+++ b/tests/kms_addfb_basic.c
@@ -278,11 +278,35 @@ static void pitch_tests(int fd)
f.fb_id = 0;
}
+ /* Generic invalid pitch tests; error numbers are driver-dependent */
for (i = 0; i < ARRAY_SIZE(bad_pitches); i++) {
- igt_subtest_f("bad-pitch-%i", bad_pitches[i]) {
+ igt_subtest_f("generic-bad-pitch-%i", bad_pitches[i]) {
f.pitches[0] = bad_pitches[i];
igt_assert(drmIoctl(fd, DRM_IOCTL_MODE_ADDFB2, &f) == -1 &&
- errno == EINVAL);
+ errno != 0);
+ igt_info("invalid pitch %i resulted in errno %i\n",
+ bad_pitches[i], errno);
+ }
+ }
+
+ /* Intel returns EINVAL in all invalid pitch scenarios */
+ for (i = 0; i < ARRAY_SIZE(bad_pitches); i++) {
+ igt_subtest_f("intel-bad-pitch-%i", bad_pitches[i]) {
+ igt_require_intel(fd);
+ f.pitches[0] = bad_pitches[i];
+ do_ioctl_err(fd, DRM_IOCTL_MODE_ADDFB2, &f, EINVAL);
+ }
+ }
+
+ /* Nouveau returns ERANGE for pitches that are too big */
+ for (i = 0; i < ARRAY_SIZE(bad_pitches); i++) {
+ igt_subtest_f("nouveau-bad-pitch-%i", bad_pitches[i]) {
+ igt_require_nouveau(fd);
+ f.pitches[0] = bad_pitches[i];
+ if (bad_pitches[i] > 4 * 1024)
+ do_ioctl_err(fd, DRM_IOCTL_MODE_ADDFB2, &f, ERANGE);
+ else
+ do_ioctl_err(fd, DRM_IOCTL_MODE_ADDFB2, &f, EINVAL);
}
}
@@ -427,17 +451,45 @@ static void size_tests(int fd)
f_8.height++;
igt_subtest("too-high") {
igt_assert(drmIoctl(fd, DRM_IOCTL_MODE_ADDFB2, &f) == -1 &&
- errno == EINVAL);
+ errno != 0);
+ igt_info("driver returned errno %i for framebuffer f\n", errno);
igt_assert(drmIoctl(fd, DRM_IOCTL_MODE_ADDFB2, &f_16) == -1 &&
- errno == EINVAL);
+ errno != 0);
+ igt_info("driver returned errno %i for framebuffer f_16\n", errno);
igt_assert(drmIoctl(fd, DRM_IOCTL_MODE_ADDFB2, &f_8) == -1 &&
- errno == EINVAL);
+ errno != 0);
+ igt_info("driver returned errno %i for framebuffer f_8\n", errno);
+ }
+
+ igt_subtest("intel-too-high") {
+ igt_require_intel(fd);
+ do_ioctl_err(fd, DRM_IOCTL_MODE_ADDFB2, &f, EINVAL);
+ do_ioctl_err(fd, DRM_IOCTL_MODE_ADDFB2, &f_16, EINVAL);
+ do_ioctl_err(fd, DRM_IOCTL_MODE_ADDFB2, &f_8, EINVAL);
+ }
+
+ igt_subtest("nouveau-too-high") {
+ igt_require_nouveau(fd);
+ do_ioctl_err(fd, DRM_IOCTL_MODE_ADDFB2, &f, ERANGE);
+ do_ioctl_err(fd, DRM_IOCTL_MODE_ADDFB2, &f_16, ERANGE);
+ do_ioctl_err(fd, DRM_IOCTL_MODE_ADDFB2, &f_8, ERANGE);
}
f.handles[0] = gem_bo_small;
igt_subtest("bo-too-small") {
igt_assert(drmIoctl(fd, DRM_IOCTL_MODE_ADDFB2, &f) == -1 &&
- errno == EINVAL);
+ errno != 0);
+ igt_info("driver returned errno %i\n", errno);
+ }
+
+ igt_subtest("intel-bo-too-small") {
+ igt_require_intel(fd);
+ do_ioctl_err(fd, DRM_IOCTL_MODE_ADDFB2, &f, EINVAL);
+ }
+
+ igt_subtest("nouveau-bo-too-small") {
+ igt_require_nouveau(fd);
+ do_ioctl_err(fd, DRM_IOCTL_MODE_ADDFB2, &f, ERANGE);
}
/* Just to check that the parameters would work. */
--
2.28.0
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply related [flat|nested] 25+ messages in thread
* Re: [igt-dev] [PATCH i-g-t v2 2/2] tests/kms_addfb_basic: add vendor-specific errno assertions
2020-11-16 22:18 ` [igt-dev] [PATCH i-g-t v2 2/2] tests/kms_addfb_basic: add vendor-specific errno assertions Jeremy Cline
@ 2020-11-17 7:31 ` Petri Latvala
0 siblings, 0 replies; 25+ messages in thread
From: Petri Latvala @ 2020-11-17 7:31 UTC (permalink / raw)
To: Jeremy Cline; +Cc: IGT GPU Tools
On Mon, Nov 16, 2020 at 05:18:44PM -0500, Jeremy Cline wrote:
> This adjusts the check on failed calls to DRM_IOCTL_MODE_ADDFB2 in
> various scenarios. According to the kernel's
> drm_mode_config_funcs.fb_create documentation, a negative return code is
> all that is required to signal failure, and different drivers return
> different errors in these scenarios.
>
> Particularly, Nouveau returns -ERANGE rather than -EINVAL in scenarios
> where the buffer is too small for the proposed configuration.
>
> In situations where Nouveau and Intel return codes diverge, this splits
> up the test into a generic test asserting a non-zero error code,
> followed by some vendor-specific assertions about its exact value.
>
> Signed-off-by: Jeremy Cline <jcline@redhat.com>
> ---
> Changes since v1:
> - Added vendor-specific assertions for exact error numbers
> - Added igt_info statements to the generic test cases
> - Made use of do_ioctl_err() macro when possible
>
> tests/kms_addfb_basic.c | 64 +++++++++++++++++++++++++++++++++++++----
> 1 file changed, 58 insertions(+), 6 deletions(-)
I was thinking more on the lines of
igt_subtest("bad-pitch") {
igt_assert_f(drmIoctl(fd, y, z) == -1, "this should have failed");
if (is_i915_device(fd))
igt_assert_eq(errno, EINVAL);
else if (is_nouveau_device(fd))
igt_assert_eq(errno, ERANGE);
else {
igt_info("Unknown vendor, can't check which error value this should be, but it was %d", errno);
}
}
That method unfortunately prevents the use of do_ioctl_err. Hmm.
shouldbe = get_proper_error_code_for_device(fd);
if (shouldbe != 0) {
do_ioctl_err(fd, x, y, z, shouldbe);
} else {
igt_assert(drmIoctl(fd, x, y, z) == -1);
igt_info("Unknown vendor, can't check which error value this should be but it was %d", errno);
}
Anyway, don't split these to vendor-specific subtests. Subtests should
be split based on the operation tested, as a very loose thumb rule.
--
Petri Latvala
>
> diff --git a/tests/kms_addfb_basic.c b/tests/kms_addfb_basic.c
> index 0ec583fe..9b936584 100644
> --- a/tests/kms_addfb_basic.c
> +++ b/tests/kms_addfb_basic.c
> @@ -278,11 +278,35 @@ static void pitch_tests(int fd)
> f.fb_id = 0;
> }
>
> + /* Generic invalid pitch tests; error numbers are driver-dependent */
> for (i = 0; i < ARRAY_SIZE(bad_pitches); i++) {
> - igt_subtest_f("bad-pitch-%i", bad_pitches[i]) {
> + igt_subtest_f("generic-bad-pitch-%i", bad_pitches[i]) {
> f.pitches[0] = bad_pitches[i];
> igt_assert(drmIoctl(fd, DRM_IOCTL_MODE_ADDFB2, &f) == -1 &&
> - errno == EINVAL);
> + errno != 0);
> + igt_info("invalid pitch %i resulted in errno %i\n",
> + bad_pitches[i], errno);
> + }
> + }
> +
> + /* Intel returns EINVAL in all invalid pitch scenarios */
> + for (i = 0; i < ARRAY_SIZE(bad_pitches); i++) {
> + igt_subtest_f("intel-bad-pitch-%i", bad_pitches[i]) {
> + igt_require_intel(fd);
> + f.pitches[0] = bad_pitches[i];
> + do_ioctl_err(fd, DRM_IOCTL_MODE_ADDFB2, &f, EINVAL);
> + }
> + }
> +
> + /* Nouveau returns ERANGE for pitches that are too big */
> + for (i = 0; i < ARRAY_SIZE(bad_pitches); i++) {
> + igt_subtest_f("nouveau-bad-pitch-%i", bad_pitches[i]) {
> + igt_require_nouveau(fd);
> + f.pitches[0] = bad_pitches[i];
> + if (bad_pitches[i] > 4 * 1024)
> + do_ioctl_err(fd, DRM_IOCTL_MODE_ADDFB2, &f, ERANGE);
> + else
> + do_ioctl_err(fd, DRM_IOCTL_MODE_ADDFB2, &f, EINVAL);
> }
> }
>
> @@ -427,17 +451,45 @@ static void size_tests(int fd)
> f_8.height++;
> igt_subtest("too-high") {
> igt_assert(drmIoctl(fd, DRM_IOCTL_MODE_ADDFB2, &f) == -1 &&
> - errno == EINVAL);
> + errno != 0);
> + igt_info("driver returned errno %i for framebuffer f\n", errno);
> igt_assert(drmIoctl(fd, DRM_IOCTL_MODE_ADDFB2, &f_16) == -1 &&
> - errno == EINVAL);
> + errno != 0);
> + igt_info("driver returned errno %i for framebuffer f_16\n", errno);
> igt_assert(drmIoctl(fd, DRM_IOCTL_MODE_ADDFB2, &f_8) == -1 &&
> - errno == EINVAL);
> + errno != 0);
> + igt_info("driver returned errno %i for framebuffer f_8\n", errno);
> + }
> +
> + igt_subtest("intel-too-high") {
> + igt_require_intel(fd);
> + do_ioctl_err(fd, DRM_IOCTL_MODE_ADDFB2, &f, EINVAL);
> + do_ioctl_err(fd, DRM_IOCTL_MODE_ADDFB2, &f_16, EINVAL);
> + do_ioctl_err(fd, DRM_IOCTL_MODE_ADDFB2, &f_8, EINVAL);
> + }
> +
> + igt_subtest("nouveau-too-high") {
> + igt_require_nouveau(fd);
> + do_ioctl_err(fd, DRM_IOCTL_MODE_ADDFB2, &f, ERANGE);
> + do_ioctl_err(fd, DRM_IOCTL_MODE_ADDFB2, &f_16, ERANGE);
> + do_ioctl_err(fd, DRM_IOCTL_MODE_ADDFB2, &f_8, ERANGE);
> }
>
> f.handles[0] = gem_bo_small;
> igt_subtest("bo-too-small") {
> igt_assert(drmIoctl(fd, DRM_IOCTL_MODE_ADDFB2, &f) == -1 &&
> - errno == EINVAL);
> + errno != 0);
> + igt_info("driver returned errno %i\n", errno);
> + }
> +
> + igt_subtest("intel-bo-too-small") {
> + igt_require_intel(fd);
> + do_ioctl_err(fd, DRM_IOCTL_MODE_ADDFB2, &f, EINVAL);
> + }
> +
> + igt_subtest("nouveau-bo-too-small") {
> + igt_require_nouveau(fd);
> + do_ioctl_err(fd, DRM_IOCTL_MODE_ADDFB2, &f, ERANGE);
> }
>
> /* Just to check that the parameters would work. */
> --
> 2.28.0
>
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply [flat|nested] 25+ messages in thread
* [igt-dev] [PATCH i-g-t v3 0/2] tests/kms_addfb_basic: Nouveau support
2020-11-16 22:18 ` [igt-dev] [PATCH i-g-t v2 0/2] " Jeremy Cline
2020-11-16 22:18 ` [igt-dev] [PATCH i-g-t v2 1/2] tests/kms_addfb_basic: Mark Intel-only tests as such Jeremy Cline
2020-11-16 22:18 ` [igt-dev] [PATCH i-g-t v2 2/2] tests/kms_addfb_basic: add vendor-specific errno assertions Jeremy Cline
@ 2020-11-17 20:02 ` Jeremy Cline
2020-11-17 20:02 ` [igt-dev] [PATCH i-g-t v3 1/2] tests/kms_addfb_basic: Mark Intel-only tests as such Jeremy Cline
` (4 more replies)
2020-11-17 21:02 ` [igt-dev] ✓ Fi.CI.BAT: success for series starting with [i-g-t,v3,1/2] " Patchwork
2020-11-18 1:14 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork
4 siblings, 5 replies; 25+ messages in thread
From: Jeremy Cline @ 2020-11-17 20:02 UTC (permalink / raw)
To: IGT GPU Tools; +Cc: Petri Latvala
Hi folks,
I've been going through IGT's existing tests and seeing what they
uncover when pointed at nouveau. The kms_addfb_basic tests appear to be
largely vendor-agnostic, but there's a few simple cases that need fixing
for the test suite to pass with Nouveau.
The two issues are that there are a few tests that are specifically for
Intel GPUs, and there's some minor error code differences between i915
and nouveau (which both seem to be okay based on the API docs I could
find).
Changes from v2:
* Use if statements rather than breaking out differences into subtests
Jeremy Cline (2):
tests/kms_addfb_basic: Mark Intel-only tests as such
tests/kms_addfb_basic: add vendor-specific errno assertions
tests/kms_addfb_basic.c | 48 ++++++++++++++++++++++++++++++++---------
1 file changed, 38 insertions(+), 10 deletions(-)
--
2.28.0
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply [flat|nested] 25+ messages in thread
* [igt-dev] [PATCH i-g-t v3 1/2] tests/kms_addfb_basic: Mark Intel-only tests as such
2020-11-17 20:02 ` [igt-dev] [PATCH i-g-t v3 0/2] tests/kms_addfb_basic: Nouveau support Jeremy Cline
@ 2020-11-17 20:02 ` Jeremy Cline
2020-11-17 20:02 ` [igt-dev] [PATCH i-g-t v3 2/2] tests/kms_addfb_basic: add vendor-specific errno assertions Jeremy Cline
` (3 subsequent siblings)
4 siblings, 0 replies; 25+ messages in thread
From: Jeremy Cline @ 2020-11-17 20:02 UTC (permalink / raw)
To: IGT GPU Tools; +Cc: Petri Latvala
Several tests in the addfb suite only apply to i915 devices. Mark them
as such so these tests are skipped on non-Intel devices.
Reviewed-by: Lyude Paul <lyude@redhat.com>
Signed-off-by: Jeremy Cline <jcline@redhat.com>
---
tests/kms_addfb_basic.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/tests/kms_addfb_basic.c b/tests/kms_addfb_basic.c
index 9455909c..0ec583fe 100644
--- a/tests/kms_addfb_basic.c
+++ b/tests/kms_addfb_basic.c
@@ -572,6 +572,7 @@ static void addfb25_ytile(int fd)
igt_subtest("addfb25-y-tiled-legacy") {
igt_require_fb_modifiers(fd);
+ igt_require_intel(fd);
f.modifier[0] = LOCAL_I915_FORMAT_MOD_Y_TILED;
igt_assert(drmIoctl(fd, LOCAL_DRM_IOCTL_MODE_ADDFB2, &f) ==
@@ -583,6 +584,7 @@ static void addfb25_ytile(int fd)
igt_subtest("addfb25-yf-tiled-legacy") {
igt_require_fb_modifiers(fd);
+ igt_require_intel(fd);
f.modifier[0] = LOCAL_I915_FORMAT_MOD_Yf_TILED;
igt_assert(drmIoctl(fd, LOCAL_DRM_IOCTL_MODE_ADDFB2, &f) ==
@@ -594,6 +596,7 @@ static void addfb25_ytile(int fd)
igt_subtest("addfb25-y-tiled-small-legacy") {
igt_require_fb_modifiers(fd);
+ igt_require_intel(fd);
gen = intel_gen(intel_get_drm_devid(fd));
igt_require(gen >= 9);
--
2.28.0
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply related [flat|nested] 25+ messages in thread
* [igt-dev] [PATCH i-g-t v3 2/2] tests/kms_addfb_basic: add vendor-specific errno assertions
2020-11-17 20:02 ` [igt-dev] [PATCH i-g-t v3 0/2] tests/kms_addfb_basic: Nouveau support Jeremy Cline
2020-11-17 20:02 ` [igt-dev] [PATCH i-g-t v3 1/2] tests/kms_addfb_basic: Mark Intel-only tests as such Jeremy Cline
@ 2020-11-17 20:02 ` Jeremy Cline
2020-11-18 9:12 ` Petri Latvala
2020-11-18 15:23 ` [igt-dev] [PATCH i-g-t v4 0/2] tests/kms_addfb_basic: Nouveau support Jeremy Cline
` (2 subsequent siblings)
4 siblings, 1 reply; 25+ messages in thread
From: Jeremy Cline @ 2020-11-17 20:02 UTC (permalink / raw)
To: IGT GPU Tools; +Cc: Petri Latvala
This adjusts the check on failed calls to DRM_IOCTL_MODE_ADDFB2 in
various scenarios. According to the kernel's
drm_mode_config_funcs.fb_create documentation, a negative return code is
all that is required to signal failure, and different drivers return
different errors in these scenarios.
Particularly, Nouveau returns -ERANGE rather than -EINVAL in scenarios
where the buffer is too small for the proposed configuration.
In situations where Nouveau and Intel return codes diverge, split out
the errno assertions into device-specific blocks.
Signed-off-by: Jeremy Cline <jcline@redhat.com>
---
Changes since v2:
- Remove vendor-specific subtests.
tests/kms_addfb_basic.c | 45 ++++++++++++++++++++++++++++++++---------
1 file changed, 35 insertions(+), 10 deletions(-)
diff --git a/tests/kms_addfb_basic.c b/tests/kms_addfb_basic.c
index 0ec583fe..0e5e3aeb 100644
--- a/tests/kms_addfb_basic.c
+++ b/tests/kms_addfb_basic.c
@@ -281,8 +281,19 @@ static void pitch_tests(int fd)
for (i = 0; i < ARRAY_SIZE(bad_pitches); i++) {
igt_subtest_f("bad-pitch-%i", bad_pitches[i]) {
f.pitches[0] = bad_pitches[i];
- igt_assert(drmIoctl(fd, DRM_IOCTL_MODE_ADDFB2, &f) == -1 &&
- errno == EINVAL);
+ igt_assert_eq(igt_ioctl(fd, DRM_IOCTL_MODE_ADDFB2, &f), -1);
+ igt_assert(errno != 0);
+ if (is_i915_device(fd)) {
+ igt_assert_eq(errno, EINVAL);
+ } else if (is_nouveau_device(fd)) {
+ if (bad_pitches[i] > 4 * 1024)
+ igt_assert_eq(errno, ERANGE);
+ else
+ igt_assert_eq(errno, EINVAL);
+ } else {
+ igt_info("Unknown vendor; errno unchecked (returned %i)", errno);
+ }
+ errno = 0;
}
}
@@ -367,6 +378,8 @@ static void size_tests(int fd)
struct drm_mode_fb_cmd2 f = {};
struct drm_mode_fb_cmd2 f_16 = {};
struct drm_mode_fb_cmd2 f_8 = {};
+ struct drm_mode_fb_cmd2 *framebuffers[] = {&f, &f_16, &f_8};
+ int i;
f.width = 1024;
f.height = 1024;
@@ -426,18 +439,30 @@ static void size_tests(int fd)
f_16.height++;
f_8.height++;
igt_subtest("too-high") {
- igt_assert(drmIoctl(fd, DRM_IOCTL_MODE_ADDFB2, &f) == -1 &&
- errno == EINVAL);
- igt_assert(drmIoctl(fd, DRM_IOCTL_MODE_ADDFB2, &f_16) == -1 &&
- errno == EINVAL);
- igt_assert(drmIoctl(fd, DRM_IOCTL_MODE_ADDFB2, &f_8) == -1 &&
- errno == EINVAL);
+ for (i = 0; i < ARRAY_SIZE(framebuffers); i++) {
+ igt_assert_eq(igt_ioctl(fd, DRM_IOCTL_MODE_ADDFB2, framebuffers[i]), -1);
+ igt_assert(errno != 0);
+ if (is_i915_device(fd))
+ igt_assert_eq(errno, EINVAL);
+ else if (is_nouveau_device(fd))
+ igt_assert_eq(errno, ERANGE);
+ else
+ igt_info("Unknown vendor; errno unchecked (returned %i)", errno);
+ errno = 0;
+ }
}
f.handles[0] = gem_bo_small;
igt_subtest("bo-too-small") {
- igt_assert(drmIoctl(fd, DRM_IOCTL_MODE_ADDFB2, &f) == -1 &&
- errno == EINVAL);
+ igt_assert_eq(igt_ioctl(fd, DRM_IOCTL_MODE_ADDFB2, &f), -1);
+ igt_assert(errno != 0);
+ if (is_i915_device(fd))
+ igt_assert_eq(errno, EINVAL);
+ else if (is_nouveau_device(fd))
+ igt_assert_eq(errno, ERANGE);
+ else
+ igt_info("Unknown vendor; errno unchecked (returned %i)", errno);
+ errno = 0;
}
/* Just to check that the parameters would work. */
--
2.28.0
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply related [flat|nested] 25+ messages in thread
* [igt-dev] ✓ Fi.CI.BAT: success for series starting with [i-g-t,v3,1/2] tests/kms_addfb_basic: Mark Intel-only tests as such
2020-11-16 22:18 ` [igt-dev] [PATCH i-g-t v2 0/2] " Jeremy Cline
` (2 preceding siblings ...)
2020-11-17 20:02 ` [igt-dev] [PATCH i-g-t v3 0/2] tests/kms_addfb_basic: Nouveau support Jeremy Cline
@ 2020-11-17 21:02 ` Patchwork
2020-11-18 1:14 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork
4 siblings, 0 replies; 25+ messages in thread
From: Patchwork @ 2020-11-17 21:02 UTC (permalink / raw)
To: Jeremy Cline; +Cc: igt-dev
[-- Attachment #1.1: Type: text/plain, Size: 4747 bytes --]
== Series Details ==
Series: series starting with [i-g-t,v3,1/2] tests/kms_addfb_basic: Mark Intel-only tests as such
URL : https://patchwork.freedesktop.org/series/83991/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_9350 -> IGTPW_5182
====================================================
Summary
-------
**SUCCESS**
No regressions found.
External URL: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5182/index.html
Known issues
------------
Here are the changes found in IGTPW_5182 that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@core_hotunplug@unbind-rebind:
- fi-skl-lmem: [PASS][1] -> [DMESG-WARN][2] ([i915#2605])
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9350/fi-skl-lmem/igt@core_hotunplug@unbind-rebind.html
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5182/fi-skl-lmem/igt@core_hotunplug@unbind-rebind.html
* igt@gem_flink_basic@basic:
- fi-tgl-y: [PASS][3] -> [DMESG-WARN][4] ([i915#402]) +1 similar issue
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9350/fi-tgl-y/igt@gem_flink_basic@basic.html
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5182/fi-tgl-y/igt@gem_flink_basic@basic.html
* igt@i915_module_load@reload:
- fi-icl-u2: [PASS][5] -> [DMESG-WARN][6] ([i915#1982]) +2 similar issues
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9350/fi-icl-u2/igt@i915_module_load@reload.html
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5182/fi-icl-u2/igt@i915_module_load@reload.html
* igt@kms_busy@basic@flip:
- fi-kbl-soraka: [PASS][7] -> [DMESG-WARN][8] ([i915#1982])
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9350/fi-kbl-soraka/igt@kms_busy@basic@flip.html
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5182/fi-kbl-soraka/igt@kms_busy@basic@flip.html
* igt@kms_cursor_legacy@basic-busy-flip-before-cursor-atomic:
- fi-bxt-dsi: [PASS][9] -> [DMESG-WARN][10] ([i915#1635] / [i915#1982])
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9350/fi-bxt-dsi/igt@kms_cursor_legacy@basic-busy-flip-before-cursor-atomic.html
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5182/fi-bxt-dsi/igt@kms_cursor_legacy@basic-busy-flip-before-cursor-atomic.html
#### Possible fixes ####
* igt@kms_chamelium@dp-crc-fast:
- fi-cml-u2: [DMESG-WARN][11] ([i915#1982]) -> [PASS][12]
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9350/fi-cml-u2/igt@kms_chamelium@dp-crc-fast.html
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5182/fi-cml-u2/igt@kms_chamelium@dp-crc-fast.html
* igt@kms_cursor_legacy@basic-busy-flip-before-cursor-atomic:
- fi-byt-j1900: [DMESG-WARN][13] ([i915#1982]) -> [PASS][14]
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9350/fi-byt-j1900/igt@kms_cursor_legacy@basic-busy-flip-before-cursor-atomic.html
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5182/fi-byt-j1900/igt@kms_cursor_legacy@basic-busy-flip-before-cursor-atomic.html
* igt@vgem_basic@setversion:
- fi-tgl-y: [DMESG-WARN][15] ([i915#402]) -> [PASS][16] +2 similar issues
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9350/fi-tgl-y/igt@vgem_basic@setversion.html
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5182/fi-tgl-y/igt@vgem_basic@setversion.html
#### Warnings ####
* igt@i915_pm_rpm@basic-pci-d3-state:
- fi-tgl-y: [DMESG-WARN][17] ([i915#2411]) -> [DMESG-WARN][18] ([i915#1982] / [i915#2411])
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9350/fi-tgl-y/igt@i915_pm_rpm@basic-pci-d3-state.html
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5182/fi-tgl-y/igt@i915_pm_rpm@basic-pci-d3-state.html
[i915#1635]: https://gitlab.freedesktop.org/drm/intel/issues/1635
[i915#1982]: https://gitlab.freedesktop.org/drm/intel/issues/1982
[i915#2411]: https://gitlab.freedesktop.org/drm/intel/issues/2411
[i915#2605]: https://gitlab.freedesktop.org/drm/intel/issues/2605
[i915#402]: https://gitlab.freedesktop.org/drm/intel/issues/402
Participating hosts (45 -> 41)
------------------------------
Missing (4): fi-ilk-m540 fi-bsw-cyan fi-bdw-samus fi-hsw-4200u
Build changes
-------------
* CI: CI-20190529 -> None
* IGT: IGT_5855 -> IGTPW_5182
CI-20190529: 20190529
CI_DRM_9350: 3161d1b26b7e1a7cb9146e3f8bd613f901ff5b38 @ git://anongit.freedesktop.org/gfx-ci/linux
IGTPW_5182: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5182/index.html
IGT_5855: d9b3c7058efe41e5224dd1e43fac05dc6d049380 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5182/index.html
[-- Attachment #1.2: Type: text/html, Size: 6024 bytes --]
[-- Attachment #2: Type: text/plain, Size: 154 bytes --]
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply [flat|nested] 25+ messages in thread
* [igt-dev] ✓ Fi.CI.IGT: success for series starting with [i-g-t,v3,1/2] tests/kms_addfb_basic: Mark Intel-only tests as such
2020-11-16 22:18 ` [igt-dev] [PATCH i-g-t v2 0/2] " Jeremy Cline
` (3 preceding siblings ...)
2020-11-17 21:02 ` [igt-dev] ✓ Fi.CI.BAT: success for series starting with [i-g-t,v3,1/2] " Patchwork
@ 2020-11-18 1:14 ` Patchwork
4 siblings, 0 replies; 25+ messages in thread
From: Patchwork @ 2020-11-18 1:14 UTC (permalink / raw)
To: Jeremy Cline; +Cc: igt-dev
[-- Attachment #1.1: Type: text/plain, Size: 19027 bytes --]
== Series Details ==
Series: series starting with [i-g-t,v3,1/2] tests/kms_addfb_basic: Mark Intel-only tests as such
URL : https://patchwork.freedesktop.org/series/83991/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_9350_full -> IGTPW_5182_full
====================================================
Summary
-------
**SUCCESS**
No regressions found.
External URL: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5182/index.html
Known issues
------------
Here are the changes found in IGTPW_5182_full that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@device_reset@unbind-reset-rebind:
- shard-apl: [PASS][1] -> [DMESG-WARN][2] ([i915#1635] / [i915#1982]) +7 similar issues
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9350/shard-apl7/igt@device_reset@unbind-reset-rebind.html
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5182/shard-apl4/igt@device_reset@unbind-reset-rebind.html
* igt@gem_exec_reloc@basic-many-active@rcs0:
- shard-hsw: [PASS][3] -> [FAIL][4] ([i915#2389])
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9350/shard-hsw8/igt@gem_exec_reloc@basic-many-active@rcs0.html
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5182/shard-hsw1/igt@gem_exec_reloc@basic-many-active@rcs0.html
* igt@gem_exec_whisper@basic-contexts-all:
- shard-glk: [PASS][5] -> [DMESG-WARN][6] ([i915#118] / [i915#95])
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9350/shard-glk8/igt@gem_exec_whisper@basic-contexts-all.html
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5182/shard-glk8/igt@gem_exec_whisper@basic-contexts-all.html
* igt@kms_cursor_edge_walk@pipe-c-128x128-bottom-edge:
- shard-hsw: [PASS][7] -> [DMESG-WARN][8] ([i915#1982])
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9350/shard-hsw2/igt@kms_cursor_edge_walk@pipe-c-128x128-bottom-edge.html
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5182/shard-hsw8/igt@kms_cursor_edge_walk@pipe-c-128x128-bottom-edge.html
* igt@kms_cursor_legacy@2x-long-cursor-vs-flip-atomic:
- shard-hsw: [PASS][9] -> [FAIL][10] ([i915#96])
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9350/shard-hsw6/igt@kms_cursor_legacy@2x-long-cursor-vs-flip-atomic.html
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5182/shard-hsw7/igt@kms_cursor_legacy@2x-long-cursor-vs-flip-atomic.html
* igt@kms_cursor_legacy@flip-vs-cursor-legacy:
- shard-tglb: [PASS][11] -> [FAIL][12] ([i915#2346])
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9350/shard-tglb5/igt@kms_cursor_legacy@flip-vs-cursor-legacy.html
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5182/shard-tglb2/igt@kms_cursor_legacy@flip-vs-cursor-legacy.html
* igt@kms_flip@2x-flip-vs-absolute-wf_vblank@ab-hdmi-a1-hdmi-a2:
- shard-glk: [PASS][13] -> [DMESG-WARN][14] ([i915#1982]) +8 similar issues
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9350/shard-glk7/igt@kms_flip@2x-flip-vs-absolute-wf_vblank@ab-hdmi-a1-hdmi-a2.html
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5182/shard-glk8/igt@kms_flip@2x-flip-vs-absolute-wf_vblank@ab-hdmi-a1-hdmi-a2.html
* igt@kms_flip@flip-vs-suspend-interruptible@c-vga1:
- shard-hsw: [PASS][15] -> [INCOMPLETE][16] ([i915#2055])
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9350/shard-hsw2/igt@kms_flip@flip-vs-suspend-interruptible@c-vga1.html
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5182/shard-hsw4/igt@kms_flip@flip-vs-suspend-interruptible@c-vga1.html
* igt@kms_flip@plain-flip-fb-recreate-interruptible@b-edp1:
- shard-tglb: [PASS][17] -> [FAIL][18] ([i915#2122])
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9350/shard-tglb1/igt@kms_flip@plain-flip-fb-recreate-interruptible@b-edp1.html
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5182/shard-tglb7/igt@kms_flip@plain-flip-fb-recreate-interruptible@b-edp1.html
* igt@kms_frontbuffer_tracking@fbc-1p-offscren-pri-shrfb-draw-blt:
- shard-tglb: [PASS][19] -> [DMESG-WARN][20] ([i915#1982]) +4 similar issues
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9350/shard-tglb6/igt@kms_frontbuffer_tracking@fbc-1p-offscren-pri-shrfb-draw-blt.html
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5182/shard-tglb7/igt@kms_frontbuffer_tracking@fbc-1p-offscren-pri-shrfb-draw-blt.html
* igt@kms_frontbuffer_tracking@fbc-2p-primscrn-pri-indfb-draw-mmap-cpu:
- shard-glk: [PASS][21] -> [FAIL][22] ([i915#49])
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9350/shard-glk2/igt@kms_frontbuffer_tracking@fbc-2p-primscrn-pri-indfb-draw-mmap-cpu.html
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5182/shard-glk6/igt@kms_frontbuffer_tracking@fbc-2p-primscrn-pri-indfb-draw-mmap-cpu.html
* igt@kms_psr2_su@frontbuffer:
- shard-iclb: [PASS][23] -> [SKIP][24] ([fdo#109642] / [fdo#111068])
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9350/shard-iclb2/igt@kms_psr2_su@frontbuffer.html
[24]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5182/shard-iclb8/igt@kms_psr2_su@frontbuffer.html
* igt@kms_psr@psr2_cursor_render:
- shard-iclb: [PASS][25] -> [SKIP][26] ([fdo#109441])
[25]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9350/shard-iclb2/igt@kms_psr@psr2_cursor_render.html
[26]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5182/shard-iclb6/igt@kms_psr@psr2_cursor_render.html
* igt@kms_universal_plane@universal-plane-gen9-features-pipe-a:
- shard-kbl: [PASS][27] -> [DMESG-WARN][28] ([i915#1982]) +2 similar issues
[27]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9350/shard-kbl6/igt@kms_universal_plane@universal-plane-gen9-features-pipe-a.html
[28]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5182/shard-kbl6/igt@kms_universal_plane@universal-plane-gen9-features-pipe-a.html
- shard-iclb: [PASS][29] -> [DMESG-WARN][30] ([i915#1982]) +1 similar issue
[29]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9350/shard-iclb5/igt@kms_universal_plane@universal-plane-gen9-features-pipe-a.html
[30]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5182/shard-iclb3/igt@kms_universal_plane@universal-plane-gen9-features-pipe-a.html
#### Possible fixes ####
* igt@gem_eio@kms:
- shard-hsw: [INCOMPLETE][31] ([i915#1888] / [i915#2244]) -> [PASS][32]
[31]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9350/shard-hsw2/igt@gem_eio@kms.html
[32]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5182/shard-hsw8/igt@gem_eio@kms.html
* igt@gem_exec_suspend@basic-s3:
- shard-glk: [FAIL][33] -> [PASS][34] +1 similar issue
[33]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9350/shard-glk6/igt@gem_exec_suspend@basic-s3.html
[34]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5182/shard-glk1/igt@gem_exec_suspend@basic-s3.html
- shard-kbl: [DMESG-WARN][35] ([i915#180]) -> [PASS][36]
[35]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9350/shard-kbl2/igt@gem_exec_suspend@basic-s3.html
[36]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5182/shard-kbl6/igt@gem_exec_suspend@basic-s3.html
* igt@gem_softpin@noreloc-s3:
- shard-iclb: [INCOMPLETE][37] ([i915#1373] / [i915#2405]) -> [PASS][38]
[37]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9350/shard-iclb4/igt@gem_softpin@noreloc-s3.html
[38]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5182/shard-iclb4/igt@gem_softpin@noreloc-s3.html
- shard-apl: [INCOMPLETE][39] ([i915#1635] / [i915#2405] / [i915#2635]) -> [PASS][40]
[39]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9350/shard-apl4/igt@gem_softpin@noreloc-s3.html
[40]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5182/shard-apl8/igt@gem_softpin@noreloc-s3.html
- shard-glk: [INCOMPLETE][41] ([i915#2199] / [i915#2405] / [i915#2635]) -> [PASS][42]
[41]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9350/shard-glk6/igt@gem_softpin@noreloc-s3.html
[42]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5182/shard-glk5/igt@gem_softpin@noreloc-s3.html
- shard-hsw: [INCOMPLETE][43] ([i915#2405] / [i915#2637]) -> [PASS][44]
[43]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9350/shard-hsw1/igt@gem_softpin@noreloc-s3.html
[44]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5182/shard-hsw7/igt@gem_softpin@noreloc-s3.html
- shard-kbl: [INCOMPLETE][45] ([i915#2405]) -> [PASS][46]
[45]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9350/shard-kbl1/igt@gem_softpin@noreloc-s3.html
[46]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5182/shard-kbl3/igt@gem_softpin@noreloc-s3.html
* igt@kms_big_fb@y-tiled-64bpp-rotate-0:
- shard-kbl: [DMESG-WARN][47] ([i915#1982]) -> [PASS][48]
[47]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9350/shard-kbl1/igt@kms_big_fb@y-tiled-64bpp-rotate-0.html
[48]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5182/shard-kbl6/igt@kms_big_fb@y-tiled-64bpp-rotate-0.html
* igt@kms_cursor_legacy@short-flip-after-cursor-atomic-transitions:
- shard-snb: [FAIL][49] -> [PASS][50]
[49]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9350/shard-snb6/igt@kms_cursor_legacy@short-flip-after-cursor-atomic-transitions.html
[50]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5182/shard-snb2/igt@kms_cursor_legacy@short-flip-after-cursor-atomic-transitions.html
* igt@kms_draw_crc@draw-method-xrgb2101010-mmap-gtt-untiled:
- shard-apl: [DMESG-WARN][51] ([i915#1635] / [i915#1982]) -> [PASS][52] +6 similar issues
[51]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9350/shard-apl7/igt@kms_draw_crc@draw-method-xrgb2101010-mmap-gtt-untiled.html
[52]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5182/shard-apl7/igt@kms_draw_crc@draw-method-xrgb2101010-mmap-gtt-untiled.html
- shard-glk: [DMESG-WARN][53] ([i915#1982]) -> [PASS][54] +5 similar issues
[53]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9350/shard-glk6/igt@kms_draw_crc@draw-method-xrgb2101010-mmap-gtt-untiled.html
[54]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5182/shard-glk3/igt@kms_draw_crc@draw-method-xrgb2101010-mmap-gtt-untiled.html
* igt@kms_flip@dpms-off-confusion@a-vga1:
- shard-hsw: [DMESG-WARN][55] ([i915#1982]) -> [PASS][56] +1 similar issue
[55]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9350/shard-hsw6/igt@kms_flip@dpms-off-confusion@a-vga1.html
[56]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5182/shard-hsw7/igt@kms_flip@dpms-off-confusion@a-vga1.html
* igt@kms_frontbuffer_tracking@fbc-badstride:
- shard-iclb: [DMESG-WARN][57] ([i915#1982]) -> [PASS][58] +1 similar issue
[57]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9350/shard-iclb3/igt@kms_frontbuffer_tracking@fbc-badstride.html
[58]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5182/shard-iclb1/igt@kms_frontbuffer_tracking@fbc-badstride.html
* igt@kms_frontbuffer_tracking@psr-rgb101010-draw-blt:
- shard-tglb: [DMESG-WARN][59] ([i915#1982]) -> [PASS][60] +3 similar issues
[59]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9350/shard-tglb2/igt@kms_frontbuffer_tracking@psr-rgb101010-draw-blt.html
[60]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5182/shard-tglb5/igt@kms_frontbuffer_tracking@psr-rgb101010-draw-blt.html
* igt@kms_hdmi_inject@inject-audio:
- shard-tglb: [SKIP][61] ([i915#433]) -> [PASS][62]
[61]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9350/shard-tglb5/igt@kms_hdmi_inject@inject-audio.html
[62]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5182/shard-tglb7/igt@kms_hdmi_inject@inject-audio.html
* igt@kms_plane@plane-position-hole-dpms-pipe-b-planes:
- shard-kbl: [FAIL][63] ([i915#2472]) -> [PASS][64]
[63]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9350/shard-kbl3/igt@kms_plane@plane-position-hole-dpms-pipe-b-planes.html
[64]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5182/shard-kbl4/igt@kms_plane@plane-position-hole-dpms-pipe-b-planes.html
- shard-apl: [FAIL][65] ([i915#1635] / [i915#2472]) -> [PASS][66]
[65]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9350/shard-apl3/igt@kms_plane@plane-position-hole-dpms-pipe-b-planes.html
[66]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5182/shard-apl2/igt@kms_plane@plane-position-hole-dpms-pipe-b-planes.html
* igt@kms_psr@psr2_no_drrs:
- shard-iclb: [SKIP][67] ([fdo#109441]) -> [PASS][68] +2 similar issues
[67]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9350/shard-iclb5/igt@kms_psr@psr2_no_drrs.html
[68]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5182/shard-iclb2/igt@kms_psr@psr2_no_drrs.html
* igt@perf@oa-exponents:
- shard-tglb: [SKIP][69] ([i915#1354]) -> [PASS][70]
[69]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9350/shard-tglb8/igt@perf@oa-exponents.html
[70]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5182/shard-tglb7/igt@perf@oa-exponents.html
- shard-glk: [SKIP][71] ([fdo#109271] / [i915#1354]) -> [PASS][72]
[71]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9350/shard-glk5/igt@perf@oa-exponents.html
[72]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5182/shard-glk9/igt@perf@oa-exponents.html
- shard-apl: [SKIP][73] ([fdo#109271] / [i915#1354] / [i915#1635]) -> [PASS][74]
[73]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9350/shard-apl8/igt@perf@oa-exponents.html
[74]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5182/shard-apl7/igt@perf@oa-exponents.html
- shard-kbl: [SKIP][75] ([fdo#109271] / [i915#1354]) -> [PASS][76]
[75]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9350/shard-kbl1/igt@perf@oa-exponents.html
[76]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5182/shard-kbl4/igt@perf@oa-exponents.html
- shard-iclb: [SKIP][77] ([i915#1354]) -> [PASS][78]
[77]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9350/shard-iclb5/igt@perf@oa-exponents.html
[78]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5182/shard-iclb2/igt@perf@oa-exponents.html
- shard-hsw: [SKIP][79] ([fdo#109271]) -> [PASS][80]
[79]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9350/shard-hsw6/igt@perf@oa-exponents.html
[80]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5182/shard-hsw7/igt@perf@oa-exponents.html
#### Warnings ####
* igt@gem_softpin@noreloc-s3:
- shard-tglb: [DMESG-WARN][81] ([i915#1436]) -> [DMESG-WARN][82] ([i915#2411])
[81]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9350/shard-tglb7/igt@gem_softpin@noreloc-s3.html
[82]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5182/shard-tglb5/igt@gem_softpin@noreloc-s3.html
* igt@kms_dp_dsc@basic-dsc-enable-edp:
- shard-iclb: [DMESG-WARN][83] ([i915#1226]) -> [SKIP][84] ([fdo#109349])
[83]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9350/shard-iclb2/igt@kms_dp_dsc@basic-dsc-enable-edp.html
[84]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5182/shard-iclb4/igt@kms_dp_dsc@basic-dsc-enable-edp.html
* igt@runner@aborted:
- shard-glk: ([FAIL][85], [FAIL][86]) ([i915#1611] / [i915#2295] / [i915#2439] / [i915#86] / [k.org#202321]) -> [FAIL][87] ([i915#1611] / [i915#2295] / [i915#2439] / [k.org#202321])
[85]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9350/shard-glk2/igt@runner@aborted.html
[86]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9350/shard-glk6/igt@runner@aborted.html
[87]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5182/shard-glk4/igt@runner@aborted.html
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[fdo#109349]: https://bugs.freedesktop.org/show_bug.cgi?id=109349
[fdo#109441]: https://bugs.freedesktop.org/show_bug.cgi?id=109441
[fdo#109642]: https://bugs.freedesktop.org/show_bug.cgi?id=109642
[fdo#111068]: https://bugs.freedesktop.org/show_bug.cgi?id=111068
[i915#118]: https://gitlab.freedesktop.org/drm/intel/issues/118
[i915#1226]: https://gitlab.freedesktop.org/drm/intel/issues/1226
[i915#1354]: https://gitlab.freedesktop.org/drm/intel/issues/1354
[i915#1373]: https://gitlab.freedesktop.org/drm/intel/issues/1373
[i915#1436]: https://gitlab.freedesktop.org/drm/intel/issues/1436
[i915#1611]: https://gitlab.freedesktop.org/drm/intel/issues/1611
[i915#1635]: https://gitlab.freedesktop.org/drm/intel/issues/1635
[i915#180]: https://gitlab.freedesktop.org/drm/intel/issues/180
[i915#1888]: https://gitlab.freedesktop.org/drm/intel/issues/1888
[i915#1982]: https://gitlab.freedesktop.org/drm/intel/issues/1982
[i915#2055]: https://gitlab.freedesktop.org/drm/intel/issues/2055
[i915#2122]: https://gitlab.freedesktop.org/drm/intel/issues/2122
[i915#2199]: https://gitlab.freedesktop.org/drm/intel/issues/2199
[i915#2244]: https://gitlab.freedesktop.org/drm/intel/issues/2244
[i915#2295]: https://gitlab.freedesktop.org/drm/intel/issues/2295
[i915#2346]: https://gitlab.freedesktop.org/drm/intel/issues/2346
[i915#2389]: https://gitlab.freedesktop.org/drm/intel/issues/2389
[i915#2405]: https://gitlab.freedesktop.org/drm/intel/issues/2405
[i915#2411]: https://gitlab.freedesktop.org/drm/intel/issues/2411
[i915#2439]: https://gitlab.freedesktop.org/drm/intel/issues/2439
[i915#2472]: https://gitlab.freedesktop.org/drm/intel/issues/2472
[i915#2521]: https://gitlab.freedesktop.org/drm/intel/issues/2521
[i915#2635]: https://gitlab.freedesktop.org/drm/intel/issues/2635
[i915#2637]: https://gitlab.freedesktop.org/drm/intel/issues/2637
[i915#433]: https://gitlab.freedesktop.org/drm/intel/issues/433
[i915#49]: https://gitlab.freedesktop.org/drm/intel/issues/49
[i915#86]: https://gitlab.freedesktop.org/drm/intel/issues/86
[i915#95]: https://gitlab.freedesktop.org/drm/intel/issues/95
[i915#96]: https://gitlab.freedesktop.org/drm/intel/issues/96
[k.org#202321]: https://bugzilla.kernel.org/show_bug.cgi?id=202321
Participating hosts (10 -> 8)
------------------------------
Missing (2): pig-skl-6260u pig-glk-j5005
Build changes
-------------
* CI: CI-20190529 -> None
* IGT: IGT_5855 -> IGTPW_5182
* Piglit: piglit_4509 -> None
CI-20190529: 20190529
CI_DRM_9350: 3161d1b26b7e1a7cb9146e3f8bd613f901ff5b38 @ git://anongit.freedesktop.org/gfx-ci/linux
IGTPW_5182: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5182/index.html
IGT_5855: d9b3c7058efe41e5224dd1e43fac05dc6d049380 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5182/index.html
[-- Attachment #1.2: Type: text/html, Size: 22969 bytes --]
[-- Attachment #2: Type: text/plain, Size: 154 bytes --]
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply [flat|nested] 25+ messages in thread
* Re: [igt-dev] [PATCH i-g-t v3 2/2] tests/kms_addfb_basic: add vendor-specific errno assertions
2020-11-17 20:02 ` [igt-dev] [PATCH i-g-t v3 2/2] tests/kms_addfb_basic: add vendor-specific errno assertions Jeremy Cline
@ 2020-11-18 9:12 ` Petri Latvala
0 siblings, 0 replies; 25+ messages in thread
From: Petri Latvala @ 2020-11-18 9:12 UTC (permalink / raw)
To: Jeremy Cline; +Cc: IGT GPU Tools
On Tue, Nov 17, 2020 at 03:02:07PM -0500, Jeremy Cline wrote:
> This adjusts the check on failed calls to DRM_IOCTL_MODE_ADDFB2 in
> various scenarios. According to the kernel's
> drm_mode_config_funcs.fb_create documentation, a negative return code is
> all that is required to signal failure, and different drivers return
> different errors in these scenarios.
>
> Particularly, Nouveau returns -ERANGE rather than -EINVAL in scenarios
> where the buffer is too small for the proposed configuration.
>
> In situations where Nouveau and Intel return codes diverge, split out
> the errno assertions into device-specific blocks.
>
> Signed-off-by: Jeremy Cline <jcline@redhat.com>
> ---
Looks good. Just a minor nit below:
> Changes since v2:
> - Remove vendor-specific subtests.
>
> tests/kms_addfb_basic.c | 45 ++++++++++++++++++++++++++++++++---------
> 1 file changed, 35 insertions(+), 10 deletions(-)
>
> diff --git a/tests/kms_addfb_basic.c b/tests/kms_addfb_basic.c
> index 0ec583fe..0e5e3aeb 100644
> --- a/tests/kms_addfb_basic.c
> +++ b/tests/kms_addfb_basic.c
> @@ -281,8 +281,19 @@ static void pitch_tests(int fd)
> for (i = 0; i < ARRAY_SIZE(bad_pitches); i++) {
> igt_subtest_f("bad-pitch-%i", bad_pitches[i]) {
> f.pitches[0] = bad_pitches[i];
> - igt_assert(drmIoctl(fd, DRM_IOCTL_MODE_ADDFB2, &f) == -1 &&
> - errno == EINVAL);
> + igt_assert_eq(igt_ioctl(fd, DRM_IOCTL_MODE_ADDFB2, &f), -1);
> + igt_assert(errno != 0);
> + if (is_i915_device(fd)) {
> + igt_assert_eq(errno, EINVAL);
> + } else if (is_nouveau_device(fd)) {
> + if (bad_pitches[i] > 4 * 1024)
> + igt_assert_eq(errno, ERANGE);
> + else
> + igt_assert_eq(errno, EINVAL);
> + } else {
> + igt_info("Unknown vendor; errno unchecked (returned %i)", errno);
> + }
> + errno = 0;
> }
> }
>
> @@ -367,6 +378,8 @@ static void size_tests(int fd)
> struct drm_mode_fb_cmd2 f = {};
> struct drm_mode_fb_cmd2 f_16 = {};
> struct drm_mode_fb_cmd2 f_8 = {};
> + struct drm_mode_fb_cmd2 *framebuffers[] = {&f, &f_16, &f_8};
> + int i;
>
> f.width = 1024;
> f.height = 1024;
> @@ -426,18 +439,30 @@ static void size_tests(int fd)
> f_16.height++;
> f_8.height++;
> igt_subtest("too-high") {
> - igt_assert(drmIoctl(fd, DRM_IOCTL_MODE_ADDFB2, &f) == -1 &&
> - errno == EINVAL);
> - igt_assert(drmIoctl(fd, DRM_IOCTL_MODE_ADDFB2, &f_16) == -1 &&
> - errno == EINVAL);
> - igt_assert(drmIoctl(fd, DRM_IOCTL_MODE_ADDFB2, &f_8) == -1 &&
> - errno == EINVAL);
> + for (i = 0; i < ARRAY_SIZE(framebuffers); i++) {
If any of the asserts trigger in this for-loop, the failure will just
say "assertion failed, errno xyz instead of EINVAL" etc, losing the
information which fb it was we failed on. Add a igt_debug line right
here:
igt_debug("Checking framebuffer %i\n", i);
With that added,
Reviewed-by: Petri Latvala <petri.latvala@intel.com>
> + igt_assert_eq(igt_ioctl(fd, DRM_IOCTL_MODE_ADDFB2, framebuffers[i]), -1);
> + igt_assert(errno != 0);
> + if (is_i915_device(fd))
> + igt_assert_eq(errno, EINVAL);
> + else if (is_nouveau_device(fd))
> + igt_assert_eq(errno, ERANGE);
> + else
> + igt_info("Unknown vendor; errno unchecked (returned %i)", errno);
> + errno = 0;
> + }
> }
>
> f.handles[0] = gem_bo_small;
> igt_subtest("bo-too-small") {
> - igt_assert(drmIoctl(fd, DRM_IOCTL_MODE_ADDFB2, &f) == -1 &&
> - errno == EINVAL);
> + igt_assert_eq(igt_ioctl(fd, DRM_IOCTL_MODE_ADDFB2, &f), -1);
> + igt_assert(errno != 0);
> + if (is_i915_device(fd))
> + igt_assert_eq(errno, EINVAL);
> + else if (is_nouveau_device(fd))
> + igt_assert_eq(errno, ERANGE);
> + else
> + igt_info("Unknown vendor; errno unchecked (returned %i)", errno);
> + errno = 0;
> }
>
> /* Just to check that the parameters would work. */
> --
> 2.28.0
>
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply [flat|nested] 25+ messages in thread
* [igt-dev] [PATCH i-g-t v4 0/2] tests/kms_addfb_basic: Nouveau support
2020-11-17 20:02 ` [igt-dev] [PATCH i-g-t v3 0/2] tests/kms_addfb_basic: Nouveau support Jeremy Cline
2020-11-17 20:02 ` [igt-dev] [PATCH i-g-t v3 1/2] tests/kms_addfb_basic: Mark Intel-only tests as such Jeremy Cline
2020-11-17 20:02 ` [igt-dev] [PATCH i-g-t v3 2/2] tests/kms_addfb_basic: add vendor-specific errno assertions Jeremy Cline
@ 2020-11-18 15:23 ` Jeremy Cline
2020-11-18 15:23 ` [igt-dev] [PATCH i-g-t v4 1/2] tests/kms_addfb_basic: Mark Intel-only tests as such Jeremy Cline
2020-11-18 15:23 ` [igt-dev] [PATCH i-g-t v4 2/2] tests/kms_addfb_basic: add vendor-specific errno assertions Jeremy Cline
2020-11-18 17:00 ` [igt-dev] ✓ Fi.CI.BAT: success for series starting with [i-g-t,v4,1/2] tests/kms_addfb_basic: Mark Intel-only tests as such Patchwork
2020-11-19 1:39 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork
4 siblings, 2 replies; 25+ messages in thread
From: Jeremy Cline @ 2020-11-18 15:23 UTC (permalink / raw)
To: IGT GPU Tools; +Cc: Petri Latvala
Hi folks,
I've been going through IGT's existing tests and seeing what they
uncover when pointed at nouveau. The kms_addfb_basic tests appear to be
largely vendor-agnostic, but there's a few simple cases that need fixing
for the test suite to pass with Nouveau.
The two issues are that there are a few tests that are specifically for
Intel GPUs, and there's some minor error code differences between i915
and nouveau (which both seem to be okay based on the API docs I could
find).
Changes from v3:
* Add debug log to indicate which framebuffer is being tested in the
"too-high" subtest. Thanks to Petri Latvala for the feedback!
Jeremy Cline (2):
tests/kms_addfb_basic: Mark Intel-only tests as such
tests/kms_addfb_basic: add vendor-specific errno assertions
tests/kms_addfb_basic.c | 49 ++++++++++++++++++++++++++++++++---------
1 file changed, 39 insertions(+), 10 deletions(-)
--
2.28.0
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply [flat|nested] 25+ messages in thread
* [igt-dev] [PATCH i-g-t v4 1/2] tests/kms_addfb_basic: Mark Intel-only tests as such
2020-11-18 15:23 ` [igt-dev] [PATCH i-g-t v4 0/2] tests/kms_addfb_basic: Nouveau support Jeremy Cline
@ 2020-11-18 15:23 ` Jeremy Cline
2020-11-18 15:23 ` [igt-dev] [PATCH i-g-t v4 2/2] tests/kms_addfb_basic: add vendor-specific errno assertions Jeremy Cline
1 sibling, 0 replies; 25+ messages in thread
From: Jeremy Cline @ 2020-11-18 15:23 UTC (permalink / raw)
To: IGT GPU Tools; +Cc: Petri Latvala
Several tests in the addfb suite only apply to i915 devices. Mark them
as such so these tests are skipped on non-Intel devices.
Reviewed-by: Lyude Paul <lyude@redhat.com>
Signed-off-by: Jeremy Cline <jcline@redhat.com>
---
No changes from v3.
tests/kms_addfb_basic.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/tests/kms_addfb_basic.c b/tests/kms_addfb_basic.c
index 9455909c..0ec583fe 100644
--- a/tests/kms_addfb_basic.c
+++ b/tests/kms_addfb_basic.c
@@ -572,6 +572,7 @@ static void addfb25_ytile(int fd)
igt_subtest("addfb25-y-tiled-legacy") {
igt_require_fb_modifiers(fd);
+ igt_require_intel(fd);
f.modifier[0] = LOCAL_I915_FORMAT_MOD_Y_TILED;
igt_assert(drmIoctl(fd, LOCAL_DRM_IOCTL_MODE_ADDFB2, &f) ==
@@ -583,6 +584,7 @@ static void addfb25_ytile(int fd)
igt_subtest("addfb25-yf-tiled-legacy") {
igt_require_fb_modifiers(fd);
+ igt_require_intel(fd);
f.modifier[0] = LOCAL_I915_FORMAT_MOD_Yf_TILED;
igt_assert(drmIoctl(fd, LOCAL_DRM_IOCTL_MODE_ADDFB2, &f) ==
@@ -594,6 +596,7 @@ static void addfb25_ytile(int fd)
igt_subtest("addfb25-y-tiled-small-legacy") {
igt_require_fb_modifiers(fd);
+ igt_require_intel(fd);
gen = intel_gen(intel_get_drm_devid(fd));
igt_require(gen >= 9);
--
2.28.0
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply related [flat|nested] 25+ messages in thread
* [igt-dev] [PATCH i-g-t v4 2/2] tests/kms_addfb_basic: add vendor-specific errno assertions
2020-11-18 15:23 ` [igt-dev] [PATCH i-g-t v4 0/2] tests/kms_addfb_basic: Nouveau support Jeremy Cline
2020-11-18 15:23 ` [igt-dev] [PATCH i-g-t v4 1/2] tests/kms_addfb_basic: Mark Intel-only tests as such Jeremy Cline
@ 2020-11-18 15:23 ` Jeremy Cline
2020-11-18 21:23 ` Lyude Paul
1 sibling, 1 reply; 25+ messages in thread
From: Jeremy Cline @ 2020-11-18 15:23 UTC (permalink / raw)
To: IGT GPU Tools; +Cc: Petri Latvala
This adjusts the check on failed calls to DRM_IOCTL_MODE_ADDFB2 in
various scenarios. According to the kernel's
drm_mode_config_funcs.fb_create documentation, a negative return code is
all that is required to signal failure, and different drivers return
different errors in these scenarios.
Particularly, Nouveau returns -ERANGE rather than -EINVAL in scenarios
where the buffer is too small for the proposed configuration.
In situations where Nouveau and Intel return codes diverge, split out
the errno assertions into device-specific blocks.
Reviewed-by: Petri Latvala <petri.latvala@intel.com>
Signed-off-by: Jeremy Cline <jcline@redhat.com>
---
Changes since v3:
- Debug statement in the loop testing too-high framebuffers.
tests/kms_addfb_basic.c | 46 ++++++++++++++++++++++++++++++++---------
1 file changed, 36 insertions(+), 10 deletions(-)
diff --git a/tests/kms_addfb_basic.c b/tests/kms_addfb_basic.c
index 0ec583fe..090abe7f 100644
--- a/tests/kms_addfb_basic.c
+++ b/tests/kms_addfb_basic.c
@@ -281,8 +281,19 @@ static void pitch_tests(int fd)
for (i = 0; i < ARRAY_SIZE(bad_pitches); i++) {
igt_subtest_f("bad-pitch-%i", bad_pitches[i]) {
f.pitches[0] = bad_pitches[i];
- igt_assert(drmIoctl(fd, DRM_IOCTL_MODE_ADDFB2, &f) == -1 &&
- errno == EINVAL);
+ igt_assert_eq(igt_ioctl(fd, DRM_IOCTL_MODE_ADDFB2, &f), -1);
+ igt_assert(errno != 0);
+ if (is_i915_device(fd)) {
+ igt_assert_eq(errno, EINVAL);
+ } else if (is_nouveau_device(fd)) {
+ if (bad_pitches[i] > 4 * 1024)
+ igt_assert_eq(errno, ERANGE);
+ else
+ igt_assert_eq(errno, EINVAL);
+ } else {
+ igt_info("Unknown vendor; errno unchecked (returned %i)", errno);
+ }
+ errno = 0;
}
}
@@ -367,6 +378,8 @@ static void size_tests(int fd)
struct drm_mode_fb_cmd2 f = {};
struct drm_mode_fb_cmd2 f_16 = {};
struct drm_mode_fb_cmd2 f_8 = {};
+ struct drm_mode_fb_cmd2 *framebuffers[] = {&f, &f_16, &f_8};
+ int i;
f.width = 1024;
f.height = 1024;
@@ -426,18 +439,31 @@ static void size_tests(int fd)
f_16.height++;
f_8.height++;
igt_subtest("too-high") {
- igt_assert(drmIoctl(fd, DRM_IOCTL_MODE_ADDFB2, &f) == -1 &&
- errno == EINVAL);
- igt_assert(drmIoctl(fd, DRM_IOCTL_MODE_ADDFB2, &f_16) == -1 &&
- errno == EINVAL);
- igt_assert(drmIoctl(fd, DRM_IOCTL_MODE_ADDFB2, &f_8) == -1 &&
- errno == EINVAL);
+ for (i = 0; i < ARRAY_SIZE(framebuffers); i++) {
+ igt_debug("Checking framebuffer %i\n", i);
+ igt_assert_eq(igt_ioctl(fd, DRM_IOCTL_MODE_ADDFB2, framebuffers[i]), -1);
+ igt_assert(errno != 0);
+ if (is_i915_device(fd))
+ igt_assert_eq(errno, EINVAL);
+ else if (is_nouveau_device(fd))
+ igt_assert_eq(errno, ERANGE);
+ else
+ igt_info("Unknown vendor; errno unchecked (returned %i)", errno);
+ errno = 0;
+ }
}
f.handles[0] = gem_bo_small;
igt_subtest("bo-too-small") {
- igt_assert(drmIoctl(fd, DRM_IOCTL_MODE_ADDFB2, &f) == -1 &&
- errno == EINVAL);
+ igt_assert_eq(igt_ioctl(fd, DRM_IOCTL_MODE_ADDFB2, &f), -1);
+ igt_assert(errno != 0);
+ if (is_i915_device(fd))
+ igt_assert_eq(errno, EINVAL);
+ else if (is_nouveau_device(fd))
+ igt_assert_eq(errno, ERANGE);
+ else
+ igt_info("Unknown vendor; errno unchecked (returned %i)", errno);
+ errno = 0;
}
/* Just to check that the parameters would work. */
--
2.28.0
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply related [flat|nested] 25+ messages in thread
* [igt-dev] ✓ Fi.CI.BAT: success for series starting with [i-g-t,v4,1/2] tests/kms_addfb_basic: Mark Intel-only tests as such
2020-11-17 20:02 ` [igt-dev] [PATCH i-g-t v3 0/2] tests/kms_addfb_basic: Nouveau support Jeremy Cline
` (2 preceding siblings ...)
2020-11-18 15:23 ` [igt-dev] [PATCH i-g-t v4 0/2] tests/kms_addfb_basic: Nouveau support Jeremy Cline
@ 2020-11-18 17:00 ` Patchwork
2020-11-19 1:39 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork
4 siblings, 0 replies; 25+ messages in thread
From: Patchwork @ 2020-11-18 17:00 UTC (permalink / raw)
To: Jeremy Cline; +Cc: igt-dev
[-- Attachment #1.1: Type: text/plain, Size: 3845 bytes --]
== Series Details ==
Series: series starting with [i-g-t,v4,1/2] tests/kms_addfb_basic: Mark Intel-only tests as such
URL : https://patchwork.freedesktop.org/series/84026/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_9353 -> IGTPW_5188
====================================================
Summary
-------
**SUCCESS**
No regressions found.
External URL: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5188/index.html
Known issues
------------
Here are the changes found in IGTPW_5188 that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@kms_busy@basic@flip:
- fi-kbl-soraka: [PASS][1] -> [DMESG-WARN][2] ([i915#1982]) +1 similar issue
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9353/fi-kbl-soraka/igt@kms_busy@basic@flip.html
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5188/fi-kbl-soraka/igt@kms_busy@basic@flip.html
#### Possible fixes ####
* igt@i915_module_load@reload:
- fi-icl-y: [DMESG-WARN][3] ([i915#1982]) -> [PASS][4]
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9353/fi-icl-y/igt@i915_module_load@reload.html
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5188/fi-icl-y/igt@i915_module_load@reload.html
* igt@i915_pm_rpm@basic-pci-d3-state:
- fi-byt-j1900: [DMESG-WARN][5] ([i915#1982]) -> [PASS][6]
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9353/fi-byt-j1900/igt@i915_pm_rpm@basic-pci-d3-state.html
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5188/fi-byt-j1900/igt@i915_pm_rpm@basic-pci-d3-state.html
- fi-apl-guc: [DMESG-WARN][7] ([i915#1635] / [i915#1982]) -> [PASS][8]
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9353/fi-apl-guc/igt@i915_pm_rpm@basic-pci-d3-state.html
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5188/fi-apl-guc/igt@i915_pm_rpm@basic-pci-d3-state.html
* igt@kms_busy@basic@flip:
- {fi-kbl-7560u}: [DMESG-WARN][9] ([i915#1982]) -> [PASS][10]
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9353/fi-kbl-7560u/igt@kms_busy@basic@flip.html
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5188/fi-kbl-7560u/igt@kms_busy@basic@flip.html
* igt@kms_chamelium@dp-crc-fast:
- fi-cml-u2: [DMESG-WARN][11] ([i915#1982]) -> [PASS][12]
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9353/fi-cml-u2/igt@kms_chamelium@dp-crc-fast.html
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5188/fi-cml-u2/igt@kms_chamelium@dp-crc-fast.html
* igt@kms_flip@basic-flip-vs-wf_vblank@b-edp1:
- fi-icl-u2: [DMESG-WARN][13] ([i915#1982]) -> [PASS][14] +2 similar issues
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9353/fi-icl-u2/igt@kms_flip@basic-flip-vs-wf_vblank@b-edp1.html
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5188/fi-icl-u2/igt@kms_flip@basic-flip-vs-wf_vblank@b-edp1.html
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[i915#1635]: https://gitlab.freedesktop.org/drm/intel/issues/1635
[i915#1982]: https://gitlab.freedesktop.org/drm/intel/issues/1982
Participating hosts (43 -> 37)
------------------------------
Missing (6): fi-ilk-m540 fi-hsw-4200u fi-bsw-cyan fi-dg1-1 fi-tgl-y fi-bdw-samus
Build changes
-------------
* CI: CI-20190529 -> None
* IGT: IGT_5857 -> IGTPW_5188
CI-20190529: 20190529
CI_DRM_9353: e55d6f83211ce8ecc6785980381c5fc196fed9bb @ git://anongit.freedesktop.org/gfx-ci/linux
IGTPW_5188: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5188/index.html
IGT_5857: 0e3ec8945fd30fe8e4a38ec3d7acacc0268b225c @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5188/index.html
[-- Attachment #1.2: Type: text/html, Size: 5008 bytes --]
[-- Attachment #2: Type: text/plain, Size: 154 bytes --]
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply [flat|nested] 25+ messages in thread
* Re: [igt-dev] [PATCH i-g-t v4 2/2] tests/kms_addfb_basic: add vendor-specific errno assertions
2020-11-18 15:23 ` [igt-dev] [PATCH i-g-t v4 2/2] tests/kms_addfb_basic: add vendor-specific errno assertions Jeremy Cline
@ 2020-11-18 21:23 ` Lyude Paul
0 siblings, 0 replies; 25+ messages in thread
From: Lyude Paul @ 2020-11-18 21:23 UTC (permalink / raw)
To: Jeremy Cline, IGT GPU Tools; +Cc: Petri Latvala
Reviewed-by: Lyude Paul <lyude@redhat.com>
I'll go ahead and push this, thanks!
On Wed, 2020-11-18 at 10:23 -0500, Jeremy Cline wrote:
> This adjusts the check on failed calls to DRM_IOCTL_MODE_ADDFB2 in
> various scenarios. According to the kernel's
> drm_mode_config_funcs.fb_create documentation, a negative return code is
> all that is required to signal failure, and different drivers return
> different errors in these scenarios.
>
> Particularly, Nouveau returns -ERANGE rather than -EINVAL in scenarios
> where the buffer is too small for the proposed configuration.
>
> In situations where Nouveau and Intel return codes diverge, split out
> the errno assertions into device-specific blocks.
>
> Reviewed-by: Petri Latvala <petri.latvala@intel.com>
> Signed-off-by: Jeremy Cline <jcline@redhat.com>
> ---
> Changes since v3:
> - Debug statement in the loop testing too-high framebuffers.
>
> tests/kms_addfb_basic.c | 46 ++++++++++++++++++++++++++++++++---------
> 1 file changed, 36 insertions(+), 10 deletions(-)
>
> diff --git a/tests/kms_addfb_basic.c b/tests/kms_addfb_basic.c
> index 0ec583fe..090abe7f 100644
> --- a/tests/kms_addfb_basic.c
> +++ b/tests/kms_addfb_basic.c
> @@ -281,8 +281,19 @@ static void pitch_tests(int fd)
> for (i = 0; i < ARRAY_SIZE(bad_pitches); i++) {
> igt_subtest_f("bad-pitch-%i", bad_pitches[i]) {
> f.pitches[0] = bad_pitches[i];
> - igt_assert(drmIoctl(fd, DRM_IOCTL_MODE_ADDFB2, &f) ==
> -1 &&
> - errno == EINVAL);
> + igt_assert_eq(igt_ioctl(fd, DRM_IOCTL_MODE_ADDFB2,
> &f), -1);
> + igt_assert(errno != 0);
> + if (is_i915_device(fd)) {
> + igt_assert_eq(errno, EINVAL);
> + } else if (is_nouveau_device(fd)) {
> + if (bad_pitches[i] > 4 * 1024)
> + igt_assert_eq(errno, ERANGE);
> + else
> + igt_assert_eq(errno, EINVAL);
> + } else {
> + igt_info("Unknown vendor; errno unchecked
> (returned %i)", errno);
> + }
> + errno = 0;
> }
> }
>
> @@ -367,6 +378,8 @@ static void size_tests(int fd)
> struct drm_mode_fb_cmd2 f = {};
> struct drm_mode_fb_cmd2 f_16 = {};
> struct drm_mode_fb_cmd2 f_8 = {};
> + struct drm_mode_fb_cmd2 *framebuffers[] = {&f, &f_16, &f_8};
> + int i;
>
> f.width = 1024;
> f.height = 1024;
> @@ -426,18 +439,31 @@ static void size_tests(int fd)
> f_16.height++;
> f_8.height++;
> igt_subtest("too-high") {
> - igt_assert(drmIoctl(fd, DRM_IOCTL_MODE_ADDFB2, &f) == -1 &&
> - errno == EINVAL);
> - igt_assert(drmIoctl(fd, DRM_IOCTL_MODE_ADDFB2, &f_16) == -1 &&
> - errno == EINVAL);
> - igt_assert(drmIoctl(fd, DRM_IOCTL_MODE_ADDFB2, &f_8) == -1 &&
> - errno == EINVAL);
> + for (i = 0; i < ARRAY_SIZE(framebuffers); i++) {
> + igt_debug("Checking framebuffer %i\n", i);
> + igt_assert_eq(igt_ioctl(fd, DRM_IOCTL_MODE_ADDFB2,
> framebuffers[i]), -1);
> + igt_assert(errno != 0);
> + if (is_i915_device(fd))
> + igt_assert_eq(errno, EINVAL);
> + else if (is_nouveau_device(fd))
> + igt_assert_eq(errno, ERANGE);
> + else
> + igt_info("Unknown vendor; errno unchecked
> (returned %i)", errno);
> + errno = 0;
> + }
> }
>
> f.handles[0] = gem_bo_small;
> igt_subtest("bo-too-small") {
> - igt_assert(drmIoctl(fd, DRM_IOCTL_MODE_ADDFB2, &f) == -1 &&
> - errno == EINVAL);
> + igt_assert_eq(igt_ioctl(fd, DRM_IOCTL_MODE_ADDFB2, &f), -1);
> + igt_assert(errno != 0);
> + if (is_i915_device(fd))
> + igt_assert_eq(errno, EINVAL);
> + else if (is_nouveau_device(fd))
> + igt_assert_eq(errno, ERANGE);
> + else
> + igt_info("Unknown vendor; errno unchecked (returned
> %i)", errno);
> + errno = 0;
> }
>
> /* Just to check that the parameters would work. */
--
Sincerely,
Lyude Paul (she/her)
Software Engineer at Red Hat
Note: I deal with a lot of emails and have a lot of bugs on my plate. If you've
asked me a question, are waiting for a review/merge on a patch, etc. and I
haven't responded in a while, please feel free to send me another email to check
on my status. I don't bite!
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply [flat|nested] 25+ messages in thread
* [igt-dev] ✓ Fi.CI.IGT: success for series starting with [i-g-t,v4,1/2] tests/kms_addfb_basic: Mark Intel-only tests as such
2020-11-17 20:02 ` [igt-dev] [PATCH i-g-t v3 0/2] tests/kms_addfb_basic: Nouveau support Jeremy Cline
` (3 preceding siblings ...)
2020-11-18 17:00 ` [igt-dev] ✓ Fi.CI.BAT: success for series starting with [i-g-t,v4,1/2] tests/kms_addfb_basic: Mark Intel-only tests as such Patchwork
@ 2020-11-19 1:39 ` Patchwork
4 siblings, 0 replies; 25+ messages in thread
From: Patchwork @ 2020-11-19 1:39 UTC (permalink / raw)
To: Jeremy Cline; +Cc: igt-dev
[-- Attachment #1.1: Type: text/plain, Size: 22054 bytes --]
== Series Details ==
Series: series starting with [i-g-t,v4,1/2] tests/kms_addfb_basic: Mark Intel-only tests as such
URL : https://patchwork.freedesktop.org/series/84026/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_9353_full -> IGTPW_5188_full
====================================================
Summary
-------
**SUCCESS**
No regressions found.
External URL: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5188/index.html
Possible new issues
-------------------
Here are the unknown changes that may have been introduced in IGTPW_5188_full:
### IGT changes ###
#### Suppressed ####
The following results come from untrusted machines, tests, or statuses.
They do not affect the overall result.
* {igt@kms_plane_scaling@scaler-with-clipping-clamping@pipe-d-scaler-with-rotation}:
- shard-tglb: [PASS][1] -> [INCOMPLETE][2]
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9353/shard-tglb3/igt@kms_plane_scaling@scaler-with-clipping-clamping@pipe-d-scaler-with-rotation.html
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5188/shard-tglb1/igt@kms_plane_scaling@scaler-with-clipping-clamping@pipe-d-scaler-with-rotation.html
Known issues
------------
Here are the changes found in IGTPW_5188_full that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@gem_exec_reloc@basic-many-active@rcs0:
- shard-glk: [PASS][3] -> [FAIL][4] ([i915#2389])
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9353/shard-glk5/igt@gem_exec_reloc@basic-many-active@rcs0.html
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5188/shard-glk9/igt@gem_exec_reloc@basic-many-active@rcs0.html
* igt@gem_exec_whisper@basic-forked-all:
- shard-glk: [PASS][5] -> [DMESG-WARN][6] ([i915#118] / [i915#95]) +1 similar issue
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9353/shard-glk6/igt@gem_exec_whisper@basic-forked-all.html
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5188/shard-glk4/igt@gem_exec_whisper@basic-forked-all.html
* igt@i915_pm_rpm@gem-evict-pwrite:
- shard-iclb: [PASS][7] -> [SKIP][8] ([i915#579]) +1 similar issue
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9353/shard-iclb4/igt@i915_pm_rpm@gem-evict-pwrite.html
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5188/shard-iclb4/igt@i915_pm_rpm@gem-evict-pwrite.html
* igt@i915_pm_rpm@system-suspend:
- shard-kbl: [PASS][9] -> [SKIP][10] ([fdo#109271]) +2 similar issues
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9353/shard-kbl4/igt@i915_pm_rpm@system-suspend.html
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5188/shard-kbl6/igt@i915_pm_rpm@system-suspend.html
* igt@kms_cursor_crc@pipe-a-cursor-64x64-onscreen:
- shard-kbl: [PASS][11] -> [FAIL][12] ([i915#54])
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9353/shard-kbl6/igt@kms_cursor_crc@pipe-a-cursor-64x64-onscreen.html
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5188/shard-kbl6/igt@kms_cursor_crc@pipe-a-cursor-64x64-onscreen.html
- shard-apl: [PASS][13] -> [FAIL][14] ([i915#1635] / [i915#54])
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9353/shard-apl4/igt@kms_cursor_crc@pipe-a-cursor-64x64-onscreen.html
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5188/shard-apl7/igt@kms_cursor_crc@pipe-a-cursor-64x64-onscreen.html
* igt@kms_cursor_edge_walk@pipe-a-64x64-top-edge:
- shard-glk: [PASS][15] -> [DMESG-WARN][16] ([i915#1982]) +3 similar issues
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9353/shard-glk7/igt@kms_cursor_edge_walk@pipe-a-64x64-top-edge.html
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5188/shard-glk4/igt@kms_cursor_edge_walk@pipe-a-64x64-top-edge.html
* igt@kms_dp_aux_dev:
- shard-iclb: [PASS][17] -> [DMESG-WARN][18] ([i915#262])
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9353/shard-iclb2/igt@kms_dp_aux_dev.html
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5188/shard-iclb7/igt@kms_dp_aux_dev.html
* igt@kms_flip@2x-flip-vs-suspend@ab-hdmi-a1-hdmi-a2:
- shard-glk: [PASS][19] -> [INCOMPLETE][20] ([i915#2635])
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9353/shard-glk5/igt@kms_flip@2x-flip-vs-suspend@ab-hdmi-a1-hdmi-a2.html
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5188/shard-glk5/igt@kms_flip@2x-flip-vs-suspend@ab-hdmi-a1-hdmi-a2.html
* igt@kms_flip@2x-flip-vs-suspend@ab-vga1-hdmi-a1:
- shard-hsw: [PASS][21] -> [INCOMPLETE][22] ([i915#2637])
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9353/shard-hsw7/igt@kms_flip@2x-flip-vs-suspend@ab-vga1-hdmi-a1.html
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5188/shard-hsw1/igt@kms_flip@2x-flip-vs-suspend@ab-vga1-hdmi-a1.html
* igt@kms_flip@basic-plain-flip@a-dp1:
- shard-apl: [PASS][23] -> [DMESG-WARN][24] ([i915#1635] / [i915#1982]) +2 similar issues
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9353/shard-apl7/igt@kms_flip@basic-plain-flip@a-dp1.html
[24]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5188/shard-apl6/igt@kms_flip@basic-plain-flip@a-dp1.html
* igt@kms_flip@flip-vs-absolute-wf_vblank-interruptible@a-dp1:
- shard-kbl: [PASS][25] -> [DMESG-WARN][26] ([i915#1982])
[25]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9353/shard-kbl6/igt@kms_flip@flip-vs-absolute-wf_vblank-interruptible@a-dp1.html
[26]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5188/shard-kbl6/igt@kms_flip@flip-vs-absolute-wf_vblank-interruptible@a-dp1.html
* igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-cur-indfb-draw-mmap-gtt:
- shard-tglb: [PASS][27] -> [DMESG-WARN][28] ([i915#1982]) +1 similar issue
[27]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9353/shard-tglb5/igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-cur-indfb-draw-mmap-gtt.html
[28]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5188/shard-tglb7/igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-cur-indfb-draw-mmap-gtt.html
* igt@kms_plane_alpha_blend@pipe-c-constant-alpha-mid:
- shard-kbl: [PASS][29] -> [DMESG-WARN][30] ([i915#78]) +1 similar issue
[29]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9353/shard-kbl2/igt@kms_plane_alpha_blend@pipe-c-constant-alpha-mid.html
[30]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5188/shard-kbl2/igt@kms_plane_alpha_blend@pipe-c-constant-alpha-mid.html
* igt@kms_psr@psr2_primary_mmap_cpu:
- shard-iclb: [PASS][31] -> [SKIP][32] ([fdo#109441])
[31]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9353/shard-iclb2/igt@kms_psr@psr2_primary_mmap_cpu.html
[32]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5188/shard-iclb7/igt@kms_psr@psr2_primary_mmap_cpu.html
* igt@kms_vblank@pipe-b-ts-continuation-modeset-rpm:
- shard-iclb: [PASS][33] -> [SKIP][34] ([fdo#109278])
[33]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9353/shard-iclb1/igt@kms_vblank@pipe-b-ts-continuation-modeset-rpm.html
[34]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5188/shard-iclb8/igt@kms_vblank@pipe-b-ts-continuation-modeset-rpm.html
- shard-glk: [PASS][35] -> [SKIP][36] ([fdo#109271])
[35]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9353/shard-glk8/igt@kms_vblank@pipe-b-ts-continuation-modeset-rpm.html
[36]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5188/shard-glk4/igt@kms_vblank@pipe-b-ts-continuation-modeset-rpm.html
- shard-apl: [PASS][37] -> [SKIP][38] ([fdo#109271] / [i915#1635]) +2 similar issues
[37]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9353/shard-apl1/igt@kms_vblank@pipe-b-ts-continuation-modeset-rpm.html
[38]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5188/shard-apl4/igt@kms_vblank@pipe-b-ts-continuation-modeset-rpm.html
- shard-hsw: [PASS][39] -> [SKIP][40] ([fdo#109271])
[39]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9353/shard-hsw7/igt@kms_vblank@pipe-b-ts-continuation-modeset-rpm.html
[40]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5188/shard-hsw1/igt@kms_vblank@pipe-b-ts-continuation-modeset-rpm.html
#### Possible fixes ####
* igt@gem_set_tiling_vs_blt@tiled-to-tiled:
- shard-glk: [INCOMPLETE][41] -> [PASS][42]
[41]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9353/shard-glk9/igt@gem_set_tiling_vs_blt@tiled-to-tiled.html
[42]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5188/shard-glk1/igt@gem_set_tiling_vs_blt@tiled-to-tiled.html
* igt@i915_module_load@reload:
- shard-tglb: [DMESG-WARN][43] ([i915#1982]) -> [PASS][44] +4 similar issues
[43]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9353/shard-tglb5/igt@i915_module_load@reload.html
[44]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5188/shard-tglb8/igt@i915_module_load@reload.html
* igt@i915_pm_rpm@dpms-non-lpsp:
- shard-kbl: [SKIP][45] ([fdo#109271]) -> [PASS][46]
[45]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9353/shard-kbl3/igt@i915_pm_rpm@dpms-non-lpsp.html
[46]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5188/shard-kbl6/igt@i915_pm_rpm@dpms-non-lpsp.html
- shard-apl: [SKIP][47] ([fdo#109271] / [i915#1635]) -> [PASS][48]
[47]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9353/shard-apl7/igt@i915_pm_rpm@dpms-non-lpsp.html
[48]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5188/shard-apl7/igt@i915_pm_rpm@dpms-non-lpsp.html
- shard-glk: [SKIP][49] ([fdo#109271]) -> [PASS][50]
[49]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9353/shard-glk3/igt@i915_pm_rpm@dpms-non-lpsp.html
[50]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5188/shard-glk1/igt@i915_pm_rpm@dpms-non-lpsp.html
* {igt@kms_async_flips@async-flip-with-page-flip-events}:
- shard-glk: [FAIL][51] ([i915#2521]) -> [PASS][52]
[51]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9353/shard-glk7/igt@kms_async_flips@async-flip-with-page-flip-events.html
[52]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5188/shard-glk5/igt@kms_async_flips@async-flip-with-page-flip-events.html
* igt@kms_big_fb@y-tiled-8bpp-rotate-0:
- shard-kbl: [DMESG-WARN][53] ([i915#1982]) -> [PASS][54] +2 similar issues
[53]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9353/shard-kbl1/igt@kms_big_fb@y-tiled-8bpp-rotate-0.html
[54]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5188/shard-kbl6/igt@kms_big_fb@y-tiled-8bpp-rotate-0.html
* igt@kms_cursor_legacy@cursor-vs-flip-atomic-transitions-varying-size:
- shard-hsw: [FAIL][55] ([i915#2295] / [i915#2370]) -> [PASS][56]
[55]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9353/shard-hsw6/igt@kms_cursor_legacy@cursor-vs-flip-atomic-transitions-varying-size.html
[56]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5188/shard-hsw7/igt@kms_cursor_legacy@cursor-vs-flip-atomic-transitions-varying-size.html
* igt@kms_cursor_legacy@cursor-vs-flip-toggle:
- shard-hsw: [FAIL][57] ([i915#2370]) -> [PASS][58]
[57]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9353/shard-hsw1/igt@kms_cursor_legacy@cursor-vs-flip-toggle.html
[58]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5188/shard-hsw6/igt@kms_cursor_legacy@cursor-vs-flip-toggle.html
* igt@kms_flip@2x-flip-vs-expired-vblank-interruptible@bc-hdmi-a1-hdmi-a2:
- shard-glk: [FAIL][59] ([i915#79]) -> [PASS][60]
[59]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9353/shard-glk4/igt@kms_flip@2x-flip-vs-expired-vblank-interruptible@bc-hdmi-a1-hdmi-a2.html
[60]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5188/shard-glk9/igt@kms_flip@2x-flip-vs-expired-vblank-interruptible@bc-hdmi-a1-hdmi-a2.html
* igt@kms_flip@blocking-absolute-wf_vblank@a-dp1:
- shard-apl: [DMESG-WARN][61] ([i915#1635] / [i915#1982]) -> [PASS][62] +7 similar issues
[61]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9353/shard-apl7/igt@kms_flip@blocking-absolute-wf_vblank@a-dp1.html
[62]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5188/shard-apl3/igt@kms_flip@blocking-absolute-wf_vblank@a-dp1.html
* igt@kms_flip@flip-vs-expired-vblank@a-edp1:
- shard-tglb: [FAIL][63] ([i915#2598]) -> [PASS][64] +1 similar issue
[63]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9353/shard-tglb6/igt@kms_flip@flip-vs-expired-vblank@a-edp1.html
[64]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5188/shard-tglb6/igt@kms_flip@flip-vs-expired-vblank@a-edp1.html
* igt@kms_frontbuffer_tracking@fbc-badstride:
- shard-iclb: [DMESG-WARN][65] ([i915#1982]) -> [PASS][66] +1 similar issue
[65]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9353/shard-iclb7/igt@kms_frontbuffer_tracking@fbc-badstride.html
[66]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5188/shard-iclb3/igt@kms_frontbuffer_tracking@fbc-badstride.html
- shard-glk: [DMESG-WARN][67] ([i915#1982]) -> [PASS][68] +6 similar issues
[67]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9353/shard-glk7/igt@kms_frontbuffer_tracking@fbc-badstride.html
[68]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5188/shard-glk3/igt@kms_frontbuffer_tracking@fbc-badstride.html
* igt@kms_plane_lowres@pipe-c-tiling-x:
- shard-kbl: [DMESG-WARN][69] ([i915#165] / [i915#78]) -> [PASS][70]
[69]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9353/shard-kbl2/igt@kms_plane_lowres@pipe-c-tiling-x.html
[70]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5188/shard-kbl2/igt@kms_plane_lowres@pipe-c-tiling-x.html
* igt@kms_psr@psr2_primary_page_flip:
- shard-iclb: [SKIP][71] ([fdo#109441]) -> [PASS][72] +2 similar issues
[71]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9353/shard-iclb1/igt@kms_psr@psr2_primary_page_flip.html
[72]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5188/shard-iclb2/igt@kms_psr@psr2_primary_page_flip.html
* igt@kms_setmode@basic:
- shard-hsw: [FAIL][73] ([i915#31]) -> [PASS][74]
[73]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9353/shard-hsw4/igt@kms_setmode@basic.html
[74]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5188/shard-hsw1/igt@kms_setmode@basic.html
* igt@kms_vblank@pipe-c-query-forked-busy:
- shard-hsw: [DMESG-WARN][75] ([i915#1982]) -> [PASS][76] +1 similar issue
[75]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9353/shard-hsw1/igt@kms_vblank@pipe-c-query-forked-busy.html
[76]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5188/shard-hsw1/igt@kms_vblank@pipe-c-query-forked-busy.html
* igt@perf@blocking:
- shard-hsw: [INCOMPLETE][77] -> [PASS][78]
[77]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9353/shard-hsw4/igt@perf@blocking.html
[78]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5188/shard-hsw4/igt@perf@blocking.html
* igt@perf_pmu@module-unload:
- shard-hsw: [DMESG-WARN][79] ([i915#1982] / [i915#262]) -> [PASS][80]
[79]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9353/shard-hsw6/igt@perf_pmu@module-unload.html
[80]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5188/shard-hsw4/igt@perf_pmu@module-unload.html
#### Warnings ####
* igt@i915_pm_rpm@dpms-non-lpsp:
- shard-tglb: [SKIP][81] ([i915#579]) -> [SKIP][82] ([fdo#111644] / [i915#1397] / [i915#2411])
[81]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9353/shard-tglb1/igt@i915_pm_rpm@dpms-non-lpsp.html
[82]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5188/shard-tglb3/igt@i915_pm_rpm@dpms-non-lpsp.html
- shard-iclb: [SKIP][83] ([i915#579]) -> [SKIP][84] ([fdo#110892])
[83]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9353/shard-iclb2/igt@i915_pm_rpm@dpms-non-lpsp.html
[84]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5188/shard-iclb2/igt@i915_pm_rpm@dpms-non-lpsp.html
* igt@i915_pm_rpm@gem-evict-pwrite:
- shard-tglb: [DMESG-WARN][85] ([i915#2411]) -> [SKIP][86] ([i915#579]) +1 similar issue
[85]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9353/shard-tglb5/igt@i915_pm_rpm@gem-evict-pwrite.html
[86]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5188/shard-tglb8/igt@i915_pm_rpm@gem-evict-pwrite.html
* igt@kms_dp_dsc@basic-dsc-enable-edp:
- shard-iclb: [SKIP][87] ([fdo#109349]) -> [DMESG-WARN][88] ([i915#1226])
[87]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9353/shard-iclb5/igt@kms_dp_dsc@basic-dsc-enable-edp.html
[88]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5188/shard-iclb2/igt@kms_dp_dsc@basic-dsc-enable-edp.html
* igt@kms_vblank@pipe-b-ts-continuation-modeset-rpm:
- shard-tglb: [DMESG-WARN][89] ([i915#2411]) -> [SKIP][90] ([i915#2648])
[89]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9353/shard-tglb3/igt@kms_vblank@pipe-b-ts-continuation-modeset-rpm.html
[90]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5188/shard-tglb7/igt@kms_vblank@pipe-b-ts-continuation-modeset-rpm.html
* igt@kms_vblank@pipe-d-ts-continuation-suspend:
- shard-tglb: [DMESG-WARN][91] ([i915#2411]) -> [INCOMPLETE][92] ([i915#1436] / [i915#1982])
[91]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9353/shard-tglb2/igt@kms_vblank@pipe-d-ts-continuation-suspend.html
[92]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5188/shard-tglb7/igt@kms_vblank@pipe-d-ts-continuation-suspend.html
* igt@runner@aborted:
- shard-iclb: [FAIL][93] ([i915#2295] / [i915#2439] / [i915#483]) -> [FAIL][94] ([i915#2295] / [i915#2439])
[93]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9353/shard-iclb1/igt@runner@aborted.html
[94]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5188/shard-iclb3/igt@runner@aborted.html
- shard-glk: [FAIL][95] ([i915#1611] / [i915#2295] / [i915#2439] / [k.org#202321]) -> ([FAIL][96], [FAIL][97]) ([i915#1611] / [i915#2295] / [i915#2439] / [i915#483] / [k.org#202321])
[95]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9353/shard-glk2/igt@runner@aborted.html
[96]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5188/shard-glk7/igt@runner@aborted.html
[97]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5188/shard-glk5/igt@runner@aborted.html
- shard-tglb: [FAIL][98] ([i915#2295] / [i915#2439]) -> ([FAIL][99], [FAIL][100]) ([i915#1602] / [i915#2295] / [i915#2439])
[98]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9353/shard-tglb8/igt@runner@aborted.html
[99]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5188/shard-tglb7/igt@runner@aborted.html
[100]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5188/shard-tglb6/igt@runner@aborted.html
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[fdo#109278]: https://bugs.freedesktop.org/show_bug.cgi?id=109278
[fdo#109349]: https://bugs.freedesktop.org/show_bug.cgi?id=109349
[fdo#109441]: https://bugs.freedesktop.org/show_bug.cgi?id=109441
[fdo#110892]: https://bugs.freedesktop.org/show_bug.cgi?id=110892
[fdo#111644]: https://bugs.freedesktop.org/show_bug.cgi?id=111644
[i915#118]: https://gitlab.freedesktop.org/drm/intel/issues/118
[i915#1226]: https://gitlab.freedesktop.org/drm/intel/issues/1226
[i915#1397]: https://gitlab.freedesktop.org/drm/intel/issues/1397
[i915#1436]: https://gitlab.freedesktop.org/drm/intel/issues/1436
[i915#1602]: https://gitlab.freedesktop.org/drm/intel/issues/1602
[i915#1611]: https://gitlab.freedesktop.org/drm/intel/issues/1611
[i915#1635]: https://gitlab.freedesktop.org/drm/intel/issues/1635
[i915#165]: https://gitlab.freedesktop.org/drm/intel/issues/165
[i915#1982]: https://gitlab.freedesktop.org/drm/intel/issues/1982
[i915#2295]: https://gitlab.freedesktop.org/drm/intel/issues/2295
[i915#2369]: https://gitlab.freedesktop.org/drm/intel/issues/2369
[i915#2370]: https://gitlab.freedesktop.org/drm/intel/issues/2370
[i915#2389]: https://gitlab.freedesktop.org/drm/intel/issues/2389
[i915#2411]: https://gitlab.freedesktop.org/drm/intel/issues/2411
[i915#2439]: https://gitlab.freedesktop.org/drm/intel/issues/2439
[i915#2502]: https://gitlab.freedesktop.org/drm/intel/issues/2502
[i915#2521]: https://gitlab.freedesktop.org/drm/intel/issues/2521
[i915#2598]: https://gitlab.freedesktop.org/drm/intel/issues/2598
[i915#262]: https://gitlab.freedesktop.org/drm/intel/issues/262
[i915#2635]: https://gitlab.freedesktop.org/drm/intel/issues/2635
[i915#2637]: https://gitlab.freedesktop.org/drm/intel/issues/2637
[i915#2648]: https://gitlab.freedesktop.org/drm/intel/issues/2648
[i915#31]: https://gitlab.freedesktop.org/drm/intel/issues/31
[i915#483]: https://gitlab.freedesktop.org/drm/intel/issues/483
[i915#54]: https://gitlab.freedesktop.org/drm/intel/issues/54
[i915#579]: https://gitlab.freedesktop.org/drm/intel/issues/579
[i915#78]: https://gitlab.freedesktop.org/drm/intel/issues/78
[i915#79]: https://gitlab.freedesktop.org/drm/intel/issues/79
[i915#95]: https://gitlab.freedesktop.org/drm/intel/issues/95
[k.org#202321]: https://bugzilla.kernel.org/show_bug.cgi?id=202321
Participating hosts (10 -> 8)
------------------------------
Missing (2): pig-skl-6260u pig-glk-j5005
Build changes
-------------
* CI: CI-20190529 -> None
* IGT: IGT_5857 -> IGTPW_5188
* Piglit: piglit_4509 -> None
CI-20190529: 20190529
CI_DRM_9353: e55d6f83211ce8ecc6785980381c5fc196fed9bb @ git://anongit.freedesktop.org/gfx-ci/linux
IGTPW_5188: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5188/index.html
IGT_5857: 0e3ec8945fd30fe8e4a38ec3d7acacc0268b225c @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5188/index.html
[-- Attachment #1.2: Type: text/html, Size: 27024 bytes --]
[-- Attachment #2: Type: text/plain, Size: 154 bytes --]
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply [flat|nested] 25+ messages in thread
end of thread, other threads:[~2020-11-19 1:39 UTC | newest]
Thread overview: 25+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-11-13 16:49 [igt-dev] [PATCH i-g-t 0/2] tests/kms_addfb_basic: Nouveau support Jeremy Cline
2020-11-13 16:49 ` [igt-dev] [PATCH i-g-t 1/2] tests/kms_addfb_basic: Mark Intel-only tests as such Jeremy Cline
2020-11-13 19:00 ` Lyude Paul
2020-11-13 16:49 ` [igt-dev] [PATCH i-g-t 2/2] tests/kms_addfb_basic: Relax errno assertions Jeremy Cline
2020-11-13 18:59 ` Lyude Paul
2020-11-13 21:41 ` Jeremy Cline
2020-11-16 11:14 ` Petri Latvala
2020-11-13 20:27 ` [igt-dev] ✓ Fi.CI.BAT: success for tests/kms_addfb_basic: Nouveau support Patchwork
2020-11-14 0:30 ` [igt-dev] ✗ Fi.CI.IGT: failure " Patchwork
2020-11-16 22:18 ` [igt-dev] [PATCH i-g-t v2 0/2] " Jeremy Cline
2020-11-16 22:18 ` [igt-dev] [PATCH i-g-t v2 1/2] tests/kms_addfb_basic: Mark Intel-only tests as such Jeremy Cline
2020-11-16 22:18 ` [igt-dev] [PATCH i-g-t v2 2/2] tests/kms_addfb_basic: add vendor-specific errno assertions Jeremy Cline
2020-11-17 7:31 ` Petri Latvala
2020-11-17 20:02 ` [igt-dev] [PATCH i-g-t v3 0/2] tests/kms_addfb_basic: Nouveau support Jeremy Cline
2020-11-17 20:02 ` [igt-dev] [PATCH i-g-t v3 1/2] tests/kms_addfb_basic: Mark Intel-only tests as such Jeremy Cline
2020-11-17 20:02 ` [igt-dev] [PATCH i-g-t v3 2/2] tests/kms_addfb_basic: add vendor-specific errno assertions Jeremy Cline
2020-11-18 9:12 ` Petri Latvala
2020-11-18 15:23 ` [igt-dev] [PATCH i-g-t v4 0/2] tests/kms_addfb_basic: Nouveau support Jeremy Cline
2020-11-18 15:23 ` [igt-dev] [PATCH i-g-t v4 1/2] tests/kms_addfb_basic: Mark Intel-only tests as such Jeremy Cline
2020-11-18 15:23 ` [igt-dev] [PATCH i-g-t v4 2/2] tests/kms_addfb_basic: add vendor-specific errno assertions Jeremy Cline
2020-11-18 21:23 ` Lyude Paul
2020-11-18 17:00 ` [igt-dev] ✓ Fi.CI.BAT: success for series starting with [i-g-t,v4,1/2] tests/kms_addfb_basic: Mark Intel-only tests as such Patchwork
2020-11-19 1:39 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork
2020-11-17 21:02 ` [igt-dev] ✓ Fi.CI.BAT: success for series starting with [i-g-t,v3,1/2] " Patchwork
2020-11-18 1:14 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.