Re: [RFC PATCH V2] acpi/irq: Add stacked IRQ domain support to PCI interrupt link

[kernel test robot <lkp@intel.com>]

[-- Attachment #1: Type: text/plain, Size: 3652 bytes --]

Hi Chen,

[FYI, it's a private test report for your RFC patch.]
[auto build test ERROR on pm/linux-next]
[also build test ERROR on pci/next v5.10-rc4 next-20201117]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/0day-ci/linux/commits/Chen-Baozi/acpi-irq-Add-stacked-IRQ-domain-support-to-PCI-interrupt-link/20201117-214552
base:   https://git.kernel.org/pub/scm/linux/kernel/git/rafael/linux-pm.git linux-next
config: i386-randconfig-r036-20201117 (attached as .config)
compiler: gcc-9 (Debian 9.3.0-15) 9.3.0
reproduce (this is a W=1 build):
        # https://github.com/0day-ci/linux/commit/76f0a22bc937647cd1ee87ee48b2caf44e72030a
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review Chen-Baozi/acpi-irq-Add-stacked-IRQ-domain-support-to-PCI-interrupt-link/20201117-214552
        git checkout 76f0a22bc937647cd1ee87ee48b2caf44e72030a
        # save the attached .config to linux build tree
        make W=1 ARCH=i386 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

All errors (new ones prefixed by >>):

   ld: drivers/acpi/pci_link.o: in function `acpi_pci_link_allocate_irq':
>> drivers/acpi/pci_link.c:670: undefined reference to `acpi_get_irq_source_fwhandle'
   ld: drivers/acpi/pci_irq.o: in function `acpi_pci_irq_enable':
>> drivers/acpi/pci_irq.c:467: undefined reference to `acpi_register_irq'

vim +670 drivers/acpi/pci_link.c

   618	
   619	/*
   620	 * acpi_pci_link_allocate_irq
   621	 * success: return IRQ >= 0
   622	 * failure: return -1
   623	 */
   624	int acpi_pci_link_allocate_irq(acpi_handle handle, int index, int *triggering,
   625				       int *polarity, char **name, struct fwnode_handle **irq_domain)
   626	{
   627		int result;
   628		struct acpi_device *device;
   629		struct acpi_pci_link *link;
   630	
   631		result = acpi_bus_get_device(handle, &device);
   632		if (result) {
   633			printk(KERN_ERR PREFIX "Invalid link device\n");
   634			return -1;
   635		}
   636	
   637		link = acpi_driver_data(device);
   638		if (!link) {
   639			printk(KERN_ERR PREFIX "Invalid link context\n");
   640			return -1;
   641		}
   642	
   643		/* TBD: Support multiple index (IRQ) entries per Link Device */
   644		if (index) {
   645			printk(KERN_ERR PREFIX "Invalid index %d\n", index);
   646			return -1;
   647		}
   648	
   649		mutex_lock(&acpi_link_lock);
   650		if (acpi_pci_link_allocate(link)) {
   651			mutex_unlock(&acpi_link_lock);
   652			return -1;
   653		}
   654	
   655		if (!link->irq.active) {
   656			mutex_unlock(&acpi_link_lock);
   657			printk(KERN_ERR PREFIX "Link active IRQ is 0!\n");
   658			return -1;
   659		}
   660		link->refcnt++;
   661		mutex_unlock(&acpi_link_lock);
   662	
   663		if (triggering)
   664			*triggering = link->irq.triggering;
   665		if (polarity)
   666			*polarity = link->irq.polarity;
   667		if (name)
   668			*name = acpi_device_bid(link->device);
   669		if (irq_domain)
 > 670			*irq_domain = acpi_get_irq_source_fwhandle(&link->irq.resource_source);
   671	
   672		ACPI_DEBUG_PRINT((ACPI_DB_INFO,
   673				  "Link %s is referenced\n",
   674				  acpi_device_bid(link->device)));
   675		return link->irq.active;
   676	}
   677	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org

[-- Attachment #2: config.gz --]
[-- Type: application/gzip, Size: 34709 bytes --]