From: kernel test robot <lkp@intel.com>
To: kbuild@lists.01.org
Subject: Re: [RFC PATCH V2] acpi/irq: Add stacked IRQ domain support to PCI interrupt link
Date: Thu, 19 Nov 2020 00:22:08 +0800 [thread overview]
Message-ID: <202011190012.A8e4VWcK-lkp@intel.com> (raw)
[-- Attachment #1: Type: text/plain, Size: 8704 bytes --]
CC: kbuild-all(a)lists.01.org
In-Reply-To: <20201117134214.970-1-chenbaozi@phytium.com.cn>
References: <20201117134214.970-1-chenbaozi@phytium.com.cn>
TO: Chen Baozi <chenbaozi@phytium.com.cn>
Hi Chen,
[FYI, it's a private test report for your RFC patch.]
[auto build test WARNING on pm/linux-next]
[also build test WARNING on pci/next v5.10-rc4 next-20201118]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]
url: https://github.com/0day-ci/linux/commits/Chen-Baozi/acpi-irq-Add-stacked-IRQ-domain-support-to-PCI-interrupt-link/20201117-214552
base: https://git.kernel.org/pub/scm/linux/kernel/git/rafael/linux-pm.git linux-next
:::::: branch date: 27 hours ago
:::::: commit date: 27 hours ago
config: x86_64-randconfig-m001-20201118 (attached as .config)
compiler: gcc-9 (Debian 9.3.0-15) 9.3.0
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
smatch warnings:
drivers/acpi/pci_irq.c:467 acpi_pci_irq_enable() error: uninitialized symbol 'irq_domain'.
vim +/irq_domain +467 drivers/acpi/pci_irq.c
e237a5518425155 Chen Fan 2016-02-15 394
4be44fcd3bf648b Len Brown 2005-08-05 395 int acpi_pci_irq_enable(struct pci_dev *dev)
^1da177e4c3f415 Linus Torvalds 2005-04-16 396 {
beba8a643d7f774 Bjorn Helgaas 2008-12-08 397 struct acpi_prt_entry *entry;
3f0f3c27be19d39 Bjorn Helgaas 2008-12-08 398 int gsi;
3f0f3c27be19d39 Bjorn Helgaas 2008-12-08 399 u8 pin;
50eca3eb89d73d9 Bob Moore 2005-09-30 400 int triggering = ACPI_LEVEL_SENSITIVE;
10b68700add43d0 Lorenzo Pieralisi 2016-09-05 401 /*
10b68700add43d0 Lorenzo Pieralisi 2016-09-05 402 * On ARM systems with the GIC interrupt model, level interrupts
10b68700add43d0 Lorenzo Pieralisi 2016-09-05 403 * are always polarity high by specification; PCI legacy
10b68700add43d0 Lorenzo Pieralisi 2016-09-05 404 * IRQs lines are inverted before reaching the interrupt
10b68700add43d0 Lorenzo Pieralisi 2016-09-05 405 * controller and must therefore be considered active high
10b68700add43d0 Lorenzo Pieralisi 2016-09-05 406 * as default.
10b68700add43d0 Lorenzo Pieralisi 2016-09-05 407 */
10b68700add43d0 Lorenzo Pieralisi 2016-09-05 408 int polarity = acpi_irq_model == ACPI_IRQ_MODEL_GIC ?
10b68700add43d0 Lorenzo Pieralisi 2016-09-05 409 ACPI_ACTIVE_HIGH : ACPI_ACTIVE_LOW;
^1da177e4c3f415 Linus Torvalds 2005-04-16 410 char *link = NULL;
c83642d5123225a Bjorn Helgaas 2008-06-27 411 char link_desc[16];
349f0d5640c18db Kenji Kaneshige 2005-07-28 412 int rc;
76f0a22bc937647 Chen Baozi 2020-11-17 413 struct fwnode_handle *irq_domain;
^1da177e4c3f415 Linus Torvalds 2005-04-16 414
8015a01486a0f78 Kristen Accardi 2005-11-02 415 pin = dev->pin;
^1da177e4c3f415 Linus Torvalds 2005-04-16 416 if (!pin) {
4be44fcd3bf648b Len Brown 2005-08-05 417 ACPI_DEBUG_PRINT((ACPI_DB_INFO,
4be44fcd3bf648b Len Brown 2005-08-05 418 "No interrupt pin configured for device %s\n",
4be44fcd3bf648b Len Brown 2005-08-05 419 pci_name(dev)));
d550d98d3317378 Patrick Mochel 2006-06-27 420 return 0;
^1da177e4c3f415 Linus Torvalds 2005-04-16 421 }
^1da177e4c3f415 Linus Torvalds 2005-04-16 422
67b4eab91caf2ad Bjorn Helgaas 2016-02-17 423 if (dev->irq_managed && dev->irq > 0)
cffe0a2b5a34c95 Jiang Liu 2014-10-27 424 return 0;
cffe0a2b5a34c95 Jiang Liu 2014-10-27 425
beba8a643d7f774 Bjorn Helgaas 2008-12-08 426 entry = acpi_pci_irq_lookup(dev, pin);
5697b7ca406b4ee Bjorn Helgaas 2008-12-08 427 if (!entry) {
^1da177e4c3f415 Linus Torvalds 2005-04-16 428 /*
5697b7ca406b4ee Bjorn Helgaas 2008-12-08 429 * IDE legacy mode controller IRQs are magic. Why do compat
5697b7ca406b4ee Bjorn Helgaas 2008-12-08 430 * extensions always make such a nasty mess.
^1da177e4c3f415 Linus Torvalds 2005-04-16 431 */
5697b7ca406b4ee Bjorn Helgaas 2008-12-08 432 if (dev->class >> 8 == PCI_CLASS_STORAGE_IDE &&
5697b7ca406b4ee Bjorn Helgaas 2008-12-08 433 (dev->class & 0x05) == 0)
5697b7ca406b4ee Bjorn Helgaas 2008-12-08 434 return 0;
5697b7ca406b4ee Bjorn Helgaas 2008-12-08 435 }
beba8a643d7f774 Bjorn Helgaas 2008-12-08 436
74f82af1eda39c2 Bjorn Helgaas 2008-12-08 437 if (entry) {
74f82af1eda39c2 Bjorn Helgaas 2008-12-08 438 if (entry->link)
74f82af1eda39c2 Bjorn Helgaas 2008-12-08 439 gsi = acpi_pci_link_allocate_irq(entry->link,
74f82af1eda39c2 Bjorn Helgaas 2008-12-08 440 entry->index,
74f82af1eda39c2 Bjorn Helgaas 2008-12-08 441 &triggering, &polarity,
76f0a22bc937647 Chen Baozi 2020-11-17 442 &link,
76f0a22bc937647 Chen Baozi 2020-11-17 443 &irq_domain);
beba8a643d7f774 Bjorn Helgaas 2008-12-08 444 else
74f82af1eda39c2 Bjorn Helgaas 2008-12-08 445 gsi = entry->index;
74f82af1eda39c2 Bjorn Helgaas 2008-12-08 446 } else
beba8a643d7f774 Bjorn Helgaas 2008-12-08 447 gsi = -1;
^1da177e4c3f415 Linus Torvalds 2005-04-16 448
e237a5518425155 Chen Fan 2016-02-15 449 if (gsi < 0) {
^1da177e4c3f415 Linus Torvalds 2005-04-16 450 /*
^1da177e4c3f415 Linus Torvalds 2005-04-16 451 * No IRQ known to the ACPI subsystem - maybe the BIOS /
^1da177e4c3f415 Linus Torvalds 2005-04-16 452 * driver reported one, then use it. Exit in any case.
^1da177e4c3f415 Linus Torvalds 2005-04-16 453 */
29b49958cf73b43 Wenwen Wang 2019-08-20 454 if (!acpi_pci_irq_valid(dev, pin)) {
29b49958cf73b43 Wenwen Wang 2019-08-20 455 kfree(entry);
e237a5518425155 Chen Fan 2016-02-15 456 return 0;
29b49958cf73b43 Wenwen Wang 2019-08-20 457 }
e237a5518425155 Chen Fan 2016-02-15 458
c1aaae673f68448 Tomasz Nowicki 2014-02-20 459 if (acpi_isa_register_gsi(dev))
66fd3835ac9a374 Joe Perches 2012-11-21 460 dev_warn(&dev->dev, "PCI INT %c: no GSI\n",
66fd3835ac9a374 Joe Perches 2012-11-21 461 pin_name(pin));
181380b702eee1a Yinghai Lu 2013-02-16 462
b685f3b1744061a Tomasz Nowicki 2014-02-10 463 kfree(entry);
66fd3835ac9a374 Joe Perches 2012-11-21 464 return 0;
^1da177e4c3f415 Linus Torvalds 2005-04-16 465 }
^1da177e4c3f415 Linus Torvalds 2005-04-16 466
76f0a22bc937647 Chen Baozi 2020-11-17 @467 rc = acpi_register_irq(&dev->dev, gsi, triggering, polarity, irq_domain);
349f0d5640c18db Kenji Kaneshige 2005-07-28 468 if (rc < 0) {
c83642d5123225a Bjorn Helgaas 2008-06-27 469 dev_warn(&dev->dev, "PCI INT %c: failed to register GSI\n",
cf68b80b0e0cbc6 Bjorn Helgaas 2008-12-08 470 pin_name(pin));
181380b702eee1a Yinghai Lu 2013-02-16 471 kfree(entry);
d550d98d3317378 Patrick Mochel 2006-06-27 472 return rc;
349f0d5640c18db Kenji Kaneshige 2005-07-28 473 }
67b4eab91caf2ad Bjorn Helgaas 2016-02-17 474 dev->irq = rc;
67b4eab91caf2ad Bjorn Helgaas 2016-02-17 475 dev->irq_managed = 1;
^1da177e4c3f415 Linus Torvalds 2005-04-16 476
^1da177e4c3f415 Linus Torvalds 2005-04-16 477 if (link)
c83642d5123225a Bjorn Helgaas 2008-06-27 478 snprintf(link_desc, sizeof(link_desc), " -> Link[%s]", link);
c83642d5123225a Bjorn Helgaas 2008-06-27 479 else
c83642d5123225a Bjorn Helgaas 2008-06-27 480 link_desc[0] = '\0';
^1da177e4c3f415 Linus Torvalds 2005-04-16 481
85b8582d7ca5160 Vincent Palatin 2011-12-05 482 dev_dbg(&dev->dev, "PCI INT %c%s -> GSI %u (%s, %s) -> IRQ %d\n",
cf68b80b0e0cbc6 Bjorn Helgaas 2008-12-08 483 pin_name(pin), link_desc, gsi,
50eca3eb89d73d9 Bob Moore 2005-09-30 484 (triggering == ACPI_LEVEL_SENSITIVE) ? "level" : "edge",
50eca3eb89d73d9 Bob Moore 2005-09-30 485 (polarity == ACPI_ACTIVE_LOW) ? "low" : "high", dev->irq);
^1da177e4c3f415 Linus Torvalds 2005-04-16 486
181380b702eee1a Yinghai Lu 2013-02-16 487 kfree(entry);
d550d98d3317378 Patrick Mochel 2006-06-27 488 return 0;
^1da177e4c3f415 Linus Torvalds 2005-04-16 489 }
^1da177e4c3f415 Linus Torvalds 2005-04-16 490
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org
[-- Attachment #2: config.gz --]
[-- Type: application/gzip, Size: 33186 bytes --]
next reply other threads:[~2020-11-18 16:22 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-18 16:22 kernel test robot [this message]
-- strict thread matches above, loose matches on Subject: below --
2020-11-17 13:42 [RFC PATCH V2] acpi/irq: Add stacked IRQ domain support to PCI interrupt link Chen Baozi
2020-11-17 13:42 ` Chen Baozi
2020-11-17 18:57 ` Bjorn Helgaas
2020-11-17 18:57 ` Bjorn Helgaas
2020-11-18 10:37 ` Chen Baozi
2020-11-18 10:37 ` Chen Baozi
2020-11-18 13:45 ` Ard Biesheuvel
2020-11-18 13:45 ` Ard Biesheuvel
2020-11-18 13:50 ` Rafael J. Wysocki
2020-11-18 13:50 ` Rafael J. Wysocki
2020-11-17 20:01 ` kernel test robot
2020-11-18 9:27 ` Marc Zyngier
2020-11-18 9:27 ` Marc Zyngier
2020-11-18 13:36 ` Chen Baozi
2020-11-18 13:36 ` Chen Baozi
2020-11-18 9:51 ` Lorenzo Pieralisi
2020-11-18 9:51 ` Lorenzo Pieralisi
2020-11-18 14:05 ` Chen Baozi
2020-11-18 14:05 ` Chen Baozi
2020-11-19 10:37 ` Lorenzo Pieralisi
2020-11-19 10:37 ` Lorenzo Pieralisi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202011190012.A8e4VWcK-lkp@intel.com \
--to=lkp@intel.com \
--cc=kbuild@lists.01.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.