All of lore.kernel.org
 help / color / mirror / Atom feed
* [Buildroot] [PATCH] package/gvfs: show warning when BR2_STATIC_LIBS=y
@ 2020-11-18 13:13 Michael Nosthoff
  2020-11-18 15:14 ` Fabrice Fontaine
                   ` (2 more replies)
  0 siblings, 3 replies; 4+ messages in thread
From: Michael Nosthoff @ 2020-11-18 13:13 UTC (permalink / raw)
  To: buildroot

Fixes:

showing "gvfs needs a toolchain w/ wchar, threads, dynamic library"
while also showing "gvfs[ ]"
when !BR2_STATIC_LIBS

introduced by 4266c9f54f635e8a9d0a7fdedfb1c84c1de10785

Signed-off-by: Michael Nosthoff <buildroot@heine.tech>
---
 package/gvfs/Config.in | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/package/gvfs/Config.in b/package/gvfs/Config.in
index 5a6b3e73ec..68ad291436 100644
--- a/package/gvfs/Config.in
+++ b/package/gvfs/Config.in
@@ -20,4 +20,4 @@ config BR2_PACKAGE_GVFS
 comment "gvfs needs a toolchain w/ wchar, threads, dynamic library"
 	depends on BR2_USE_MMU
 	depends on !BR2_USE_WCHAR || !BR2_TOOLCHAIN_HAS_THREADS || \
-		!BR2_STATIC_LIBS
+		BR2_STATIC_LIBS
-- 
2.25.1

^ permalink raw reply related	[flat|nested] 4+ messages in thread

* [Buildroot] [PATCH] package/gvfs: show warning when BR2_STATIC_LIBS=y
  2020-11-18 13:13 [Buildroot] [PATCH] package/gvfs: show warning when BR2_STATIC_LIBS=y Michael Nosthoff
@ 2020-11-18 15:14 ` Fabrice Fontaine
  2020-11-18 16:59 ` Peter Korsgaard
  2020-12-06 22:24 ` Peter Korsgaard
  2 siblings, 0 replies; 4+ messages in thread
From: Fabrice Fontaine @ 2020-11-18 15:14 UTC (permalink / raw)
  To: buildroot

Hi,

Le mer. 18 nov. 2020 ? 14:13, Michael Nosthoff <buildroot@heine.tech> a ?crit :
>
> Fixes:
>
> showing "gvfs needs a toolchain w/ wchar, threads, dynamic library"
> while also showing "gvfs[ ]"
> when !BR2_STATIC_LIBS
Thanks for fixing this mistake.
Reviewed-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
>
> introduced by 4266c9f54f635e8a9d0a7fdedfb1c84c1de10785
>
> Signed-off-by: Michael Nosthoff <buildroot@heine.tech>
> ---
>  package/gvfs/Config.in | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/package/gvfs/Config.in b/package/gvfs/Config.in
> index 5a6b3e73ec..68ad291436 100644
> --- a/package/gvfs/Config.in
> +++ b/package/gvfs/Config.in
> @@ -20,4 +20,4 @@ config BR2_PACKAGE_GVFS
>  comment "gvfs needs a toolchain w/ wchar, threads, dynamic library"
>         depends on BR2_USE_MMU
>         depends on !BR2_USE_WCHAR || !BR2_TOOLCHAIN_HAS_THREADS || \
> -               !BR2_STATIC_LIBS
> +               BR2_STATIC_LIBS
> --
> 2.25.1
>
Best Regards,

Fabrice

^ permalink raw reply	[flat|nested] 4+ messages in thread

* [Buildroot] [PATCH] package/gvfs: show warning when BR2_STATIC_LIBS=y
  2020-11-18 13:13 [Buildroot] [PATCH] package/gvfs: show warning when BR2_STATIC_LIBS=y Michael Nosthoff
  2020-11-18 15:14 ` Fabrice Fontaine
@ 2020-11-18 16:59 ` Peter Korsgaard
  2020-12-06 22:24 ` Peter Korsgaard
  2 siblings, 0 replies; 4+ messages in thread
From: Peter Korsgaard @ 2020-11-18 16:59 UTC (permalink / raw)
  To: buildroot

>>>>> "Michael" == Michael Nosthoff via buildroot <buildroot@busybox.net> writes:

 > Fixes:
 > showing "gvfs needs a toolchain w/ wchar, threads, dynamic library"
 > while also showing "gvfs[ ]"
 > when !BR2_STATIC_LIBS

 > introduced by 4266c9f54f635e8a9d0a7fdedfb1c84c1de10785

 > Signed-off-by: Michael Nosthoff <buildroot@heine.tech>

Committed, thanks.

-- 
Bye, Peter Korsgaard

^ permalink raw reply	[flat|nested] 4+ messages in thread

* [Buildroot] [PATCH] package/gvfs: show warning when BR2_STATIC_LIBS=y
  2020-11-18 13:13 [Buildroot] [PATCH] package/gvfs: show warning when BR2_STATIC_LIBS=y Michael Nosthoff
  2020-11-18 15:14 ` Fabrice Fontaine
  2020-11-18 16:59 ` Peter Korsgaard
@ 2020-12-06 22:24 ` Peter Korsgaard
  2 siblings, 0 replies; 4+ messages in thread
From: Peter Korsgaard @ 2020-12-06 22:24 UTC (permalink / raw)
  To: buildroot

>>>>> "Michael" == Michael Nosthoff via buildroot <buildroot@busybox.net> writes:

 > Fixes:
 > showing "gvfs needs a toolchain w/ wchar, threads, dynamic library"
 > while also showing "gvfs[ ]"
 > when !BR2_STATIC_LIBS

 > introduced by 4266c9f54f635e8a9d0a7fdedfb1c84c1de10785

 > Signed-off-by: Michael Nosthoff <buildroot@heine.tech>

Committed to 2020.08.x, thanks.

-- 
Bye, Peter Korsgaard

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2020-12-06 22:24 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-11-18 13:13 [Buildroot] [PATCH] package/gvfs: show warning when BR2_STATIC_LIBS=y Michael Nosthoff
2020-11-18 15:14 ` Fabrice Fontaine
2020-11-18 16:59 ` Peter Korsgaard
2020-12-06 22:24 ` Peter Korsgaard

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.