All of lore.kernel.org
 help / color / mirror / Atom feed
From: Petr Vorel <pvorel@suse.cz>
To: ltp@lists.linux.it
Subject: [LTP] [PATCH v2 2/3] network/stress/multicast/query-flood: Convert to new API
Date: Wed, 18 Nov 2020 22:27:37 +0100	[thread overview]
Message-ID: <20201118212737.GC182229@pevik> (raw)
In-Reply-To: <20201117124320.783802-2-lkml@jv-coder.de>

Hi Joerg,

Thanks for v2!

Main info are reported by Alexey, few more notes below.

...
> +# Verify that the kernel is not crashed when joining a multicast group
> +# on a single socket, then receiving a large number of General Queries
nit: some sort of the description could be in 
tst_test TINFO message in do_setup() / do_test()

...
> +TST_NEEDS_ROOT=1
> +. mcast-lib.sh
> +
> +do_setup()
> +{
> +	mcast_setup $MCASTNUM_NORMAL
> +}
> +
> +do_test()
> +{
> +	local mcast_addr_prefix="$MCAST_IPV4_ADDR_PREFIX"
> +	[ "$TST_IPV6" ] && mcast_addr_prefix="$MCAST_IPV6_ADDR_PREFIX"
nit: maybe just $prefix is enough.
> +
> +	# Run a multicast join tool
> +	local tmpfile=$$
Please, when you need temporary files, use
TST_NEEDS_TMPDIR=1

> +	EXPECT_PASS $MCAST_LCMD -n 1 -p $mcast_addr_prefix \> $tmpfile
> +	tst_res TINFO "joined $(grep groups $tmpfile)"
> +
> +	# Send General Query from the remote host
> +	local params=""
nit: no need to add =""

...

Kind regards,
Petr

  reply	other threads:[~2020-11-18 21:27 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-11-17 12:43 [LTP] [PATCH v2 1/3] network/stress/multicast/packet-flood: Update to new API Joerg Vehlow
2020-11-17 12:43 ` [LTP] [PATCH v2 2/3] network/stress/multicast/query-flood: Convert " Joerg Vehlow
2020-11-18 21:27   ` Petr Vorel [this message]
2020-11-19  7:50     ` Joerg Vehlow
2020-11-17 12:43 ` [LTP] [PATCH v2 3/3] network/stress/route-change: " Joerg Vehlow
2020-11-18 17:04 ` [LTP] [PATCH v2 1/3] network/stress/multicast/packet-flood: Update " Alexey Kodanev
2020-11-19  7:49   ` Joerg Vehlow
2020-11-19 11:57     ` Alexey Kodanev
2020-11-19 12:05       ` Joerg Vehlow

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20201118212737.GC182229@pevik \
    --to=pvorel@suse.cz \
    --cc=ltp@lists.linux.it \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.