All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH 1/1] iommu/vt-d: Fix compile error with CONFIG_PCI_ATS not set
@ 2020-11-19  5:51 ` Lu Baolu
  0 siblings, 0 replies; 4+ messages in thread
From: Lu Baolu @ 2020-11-19  5:51 UTC (permalink / raw)
  To: Will Deacon, Joerg Roedel
  Cc: Thomas Gleixner, Geert Uytterhoeven, iommu, linux-kernel, Lu Baolu

Fix the compile error below (CONFIG_PCI_ATS not set):

drivers/iommu/intel/dmar.c: In function ‘vf_inherit_msi_domain’:
drivers/iommu/intel/dmar.c:338:59: error: ‘struct pci_dev’ has no member named ‘physfn’; did you mean ‘is_physfn’?
  338 |  dev_set_msi_domain(&pdev->dev, dev_get_msi_domain(&pdev->physfn->dev));
      |                                                           ^~~~~~
      |                                                           is_physfn

Link: https://lore.kernel.org/linux-iommu/CAMuHMdXA7wfJovmfSH2nbAhN0cPyCiFHodTvg4a8Hm9rx5Dj-w@mail.gmail.com/
Fixes: ff828729be446 ("iommu/vt-d: Cure VF irqdomain hickup")
Cc: Thomas Gleixner <tglx@linutronix.de>
Reported-by: Geert Uytterhoeven <geert@linux-m68k.org>
Signed-off-by: Lu Baolu <baolu.lu@linux.intel.com>
---
 drivers/iommu/intel/dmar.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/drivers/iommu/intel/dmar.c b/drivers/iommu/intel/dmar.c
index b2e804473209..11319e4dce4a 100644
--- a/drivers/iommu/intel/dmar.c
+++ b/drivers/iommu/intel/dmar.c
@@ -335,7 +335,9 @@ static void  dmar_pci_bus_del_dev(struct dmar_pci_notify_info *info)
 
 static inline void vf_inherit_msi_domain(struct pci_dev *pdev)
 {
-	dev_set_msi_domain(&pdev->dev, dev_get_msi_domain(&pdev->physfn->dev));
+	struct pci_dev *physfn = pci_physfn(pdev);
+
+	dev_set_msi_domain(&pdev->dev, dev_get_msi_domain(&physfn->dev));
 }
 
 static int dmar_pci_bus_notifier(struct notifier_block *nb,
-- 
2.25.1


^ permalink raw reply related	[flat|nested] 4+ messages in thread
* [PATCH 1/1] iommu/vt-d: Fix compile error with CONFIG_PCI_ATS not set
@ 2020-11-19  5:51 ` Lu Baolu
  0 siblings, 0 replies; 4+ messages in thread
From: Lu Baolu @ 2020-11-19  5:51 UTC (permalink / raw)
  To: Will Deacon, Joerg Roedel
  Cc: Thomas Gleixner, Geert Uytterhoeven, iommu, linux-kernel

Fix the compile error below (CONFIG_PCI_ATS not set):

drivers/iommu/intel/dmar.c: In function ‘vf_inherit_msi_domain’:
drivers/iommu/intel/dmar.c:338:59: error: ‘struct pci_dev’ has no member named ‘physfn’; did you mean ‘is_physfn’?
  338 |  dev_set_msi_domain(&pdev->dev, dev_get_msi_domain(&pdev->physfn->dev));
      |                                                           ^~~~~~
      |                                                           is_physfn

Link: https://lore.kernel.org/linux-iommu/CAMuHMdXA7wfJovmfSH2nbAhN0cPyCiFHodTvg4a8Hm9rx5Dj-w@mail.gmail.com/
Fixes: ff828729be446 ("iommu/vt-d: Cure VF irqdomain hickup")
Cc: Thomas Gleixner <tglx@linutronix.de>
Reported-by: Geert Uytterhoeven <geert@linux-m68k.org>
Signed-off-by: Lu Baolu <baolu.lu@linux.intel.com>
---
 drivers/iommu/intel/dmar.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/drivers/iommu/intel/dmar.c b/drivers/iommu/intel/dmar.c
index b2e804473209..11319e4dce4a 100644
--- a/drivers/iommu/intel/dmar.c
+++ b/drivers/iommu/intel/dmar.c
@@ -335,7 +335,9 @@ static void  dmar_pci_bus_del_dev(struct dmar_pci_notify_info *info)
 
 static inline void vf_inherit_msi_domain(struct pci_dev *pdev)
 {
-	dev_set_msi_domain(&pdev->dev, dev_get_msi_domain(&pdev->physfn->dev));
+	struct pci_dev *physfn = pci_physfn(pdev);
+
+	dev_set_msi_domain(&pdev->dev, dev_get_msi_domain(&physfn->dev));
 }
 
 static int dmar_pci_bus_notifier(struct notifier_block *nb,
-- 
2.25.1

_______________________________________________
iommu mailing list
iommu@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/iommu

^ permalink raw reply related	[flat|nested] 4+ messages in thread
* Re: [PATCH 1/1] iommu/vt-d: Fix compile error with CONFIG_PCI_ATS not set
  2020-11-19  5:51 ` Lu Baolu
@ 2020-11-19 10:37   ` Will Deacon
  -1 siblings, 0 replies; 4+ messages in thread
From: Will Deacon @ 2020-11-19 10:37 UTC (permalink / raw)
  To: Lu Baolu, Joerg Roedel
  Cc: catalin.marinas, kernel-team, Will Deacon, iommu,
	Geert Uytterhoeven, Thomas Gleixner, linux-kernel

On Thu, 19 Nov 2020 13:51:19 +0800, Lu Baolu wrote:
> Fix the compile error below (CONFIG_PCI_ATS not set):
> 
> drivers/iommu/intel/dmar.c: In function ‘vf_inherit_msi_domain’:
> drivers/iommu/intel/dmar.c:338:59: error: ‘struct pci_dev’ has no member named ‘physfn’; did you mean ‘is_physfn’?
>   338 |  dev_set_msi_domain(&pdev->dev, dev_get_msi_domain(&pdev->physfn->dev));
>       |                                                           ^~~~~~
>       |                                                           is_physfn

Applied to arm64 (for-next/iommu/fixes), thanks!

[1/1] iommu/vt-d: Fix compile error with CONFIG_PCI_ATS not set
      https://git.kernel.org/arm64/c/3645a34f5b96

Cheers,
-- 
Will

https://fixes.arm64.dev
https://next.arm64.dev
https://will.arm64.dev

^ permalink raw reply	[flat|nested] 4+ messages in thread
* Re: [PATCH 1/1] iommu/vt-d: Fix compile error with CONFIG_PCI_ATS not set
@ 2020-11-19 10:37   ` Will Deacon
  0 siblings, 0 replies; 4+ messages in thread
From: Will Deacon @ 2020-11-19 10:37 UTC (permalink / raw)
  To: Lu Baolu, Joerg Roedel
  Cc: Will Deacon, catalin.marinas, linux-kernel, iommu,
	Geert Uytterhoeven, Thomas Gleixner, kernel-team

On Thu, 19 Nov 2020 13:51:19 +0800, Lu Baolu wrote:
> Fix the compile error below (CONFIG_PCI_ATS not set):
> 
> drivers/iommu/intel/dmar.c: In function ‘vf_inherit_msi_domain’:
> drivers/iommu/intel/dmar.c:338:59: error: ‘struct pci_dev’ has no member named ‘physfn’; did you mean ‘is_physfn’?
>   338 |  dev_set_msi_domain(&pdev->dev, dev_get_msi_domain(&pdev->physfn->dev));
>       |                                                           ^~~~~~
>       |                                                           is_physfn

Applied to arm64 (for-next/iommu/fixes), thanks!

[1/1] iommu/vt-d: Fix compile error with CONFIG_PCI_ATS not set
      https://git.kernel.org/arm64/c/3645a34f5b96

Cheers,
-- 
Will

https://fixes.arm64.dev
https://next.arm64.dev
https://will.arm64.dev
_______________________________________________
iommu mailing list
iommu@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/iommu

^ permalink raw reply	[flat|nested] 4+ messages in thread
end of thread, other threads:[~2020-11-19 10:37 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-11-19  5:51 [PATCH 1/1] iommu/vt-d: Fix compile error with CONFIG_PCI_ATS not set Lu Baolu
2020-11-19  5:51 ` Lu Baolu
2020-11-19 10:37 ` Will Deacon
2020-11-19 10:37   ` Will Deacon

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.