All of lore.kernel.org
 help / color / mirror / Atom feed
From: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
To: miquel.raynal@bootlin.com, richard@nod.at, vigneshr@ti.com,
	robh+dt@kernel.org
Cc: bjorn.andersson@linaro.org, linux-mtd@lists.infradead.org,
	devicetree@vger.kernel.org, linux-arm-msm@vger.kernel.org,
	linux-kernel@vger.kernel.org,
	Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>,
	Linus Walleij <linus.walleij@linaro.org>
Subject: [PATCH v3 4/4] mtd: parsers: afs: Fix freeing the part name memory in failure
Date: Thu, 19 Nov 2020 12:43:08 +0530	[thread overview]
Message-ID: <20201119071308.9292-5-manivannan.sadhasivam@linaro.org> (raw)
In-Reply-To: <20201119071308.9292-1-manivannan.sadhasivam@linaro.org>

In the case of failure while parsing the partitions, the iterator should
be pre decremented by one before starting to free the memory allocated
by kstrdup(). Because in the failure case, kstrdup() will not succeed
and thus no memory will be allocated for the current iteration.

Cc: Linus Walleij <linus.walleij@linaro.org>
Fixes: 1fca1f6abb38 ("mtd: afs: simplify partition parsing")
Reviewed-by: Linus Walleij <linus.walleij@linaro.org>
Signed-off-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
---
 drivers/mtd/parsers/afs.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/drivers/mtd/parsers/afs.c b/drivers/mtd/parsers/afs.c
index 980e332bdac4..26116694c821 100644
--- a/drivers/mtd/parsers/afs.c
+++ b/drivers/mtd/parsers/afs.c
@@ -370,10 +370,8 @@ static int parse_afs_partitions(struct mtd_info *mtd,
 	return i;
 
 out_free_parts:
-	while (i >= 0) {
+	while (--i >= 0)
 		kfree(parts[i].name);
-		i--;
-	}
 	kfree(parts);
 	*pparts = NULL;
 	return ret;
-- 
2.17.1


WARNING: multiple messages have this Message-ID (diff)
From: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
To: miquel.raynal@bootlin.com, richard@nod.at, vigneshr@ti.com,
	robh+dt@kernel.org
Cc: devicetree@vger.kernel.org, linux-arm-msm@vger.kernel.org,
	Linus Walleij <linus.walleij@linaro.org>,
	linux-kernel@vger.kernel.org, bjorn.andersson@linaro.org,
	linux-mtd@lists.infradead.org,
	Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
Subject: [PATCH v3 4/4] mtd: parsers: afs: Fix freeing the part name memory in failure
Date: Thu, 19 Nov 2020 12:43:08 +0530	[thread overview]
Message-ID: <20201119071308.9292-5-manivannan.sadhasivam@linaro.org> (raw)
In-Reply-To: <20201119071308.9292-1-manivannan.sadhasivam@linaro.org>

In the case of failure while parsing the partitions, the iterator should
be pre decremented by one before starting to free the memory allocated
by kstrdup(). Because in the failure case, kstrdup() will not succeed
and thus no memory will be allocated for the current iteration.

Cc: Linus Walleij <linus.walleij@linaro.org>
Fixes: 1fca1f6abb38 ("mtd: afs: simplify partition parsing")
Reviewed-by: Linus Walleij <linus.walleij@linaro.org>
Signed-off-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
---
 drivers/mtd/parsers/afs.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/drivers/mtd/parsers/afs.c b/drivers/mtd/parsers/afs.c
index 980e332bdac4..26116694c821 100644
--- a/drivers/mtd/parsers/afs.c
+++ b/drivers/mtd/parsers/afs.c
@@ -370,10 +370,8 @@ static int parse_afs_partitions(struct mtd_info *mtd,
 	return i;
 
 out_free_parts:
-	while (i >= 0) {
+	while (--i >= 0)
 		kfree(parts[i].name);
-		i--;
-	}
 	kfree(parts);
 	*pparts = NULL;
 	return ret;
-- 
2.17.1


______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/

  parent reply	other threads:[~2020-11-19  7:13 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-11-19  7:13 [PATCH v3 0/4] Add support for Qcom SMEM based NAND parser Manivannan Sadhasivam
2020-11-19  7:13 ` Manivannan Sadhasivam
2020-11-19  7:13 ` [PATCH v3 1/4] dt-bindings: mtd: partitions: Add binding for Qcom SMEM parser Manivannan Sadhasivam
2020-11-19  7:13   ` Manivannan Sadhasivam
2020-12-07 21:52   ` Rob Herring
2020-12-07 21:52     ` Rob Herring
2020-12-11  3:31     ` Manivannan Sadhasivam
2020-12-11  3:31       ` Manivannan Sadhasivam
2020-12-11 21:13       ` Rob Herring
2020-12-11 21:13         ` Rob Herring
2020-11-19  7:13 ` [PATCH v3 2/4] mtd: parsers: Add " Manivannan Sadhasivam
2020-11-19  7:13   ` Manivannan Sadhasivam
2020-11-19  7:13 ` [PATCH v3 3/4] mtd: rawnand: qcom: Add support for " Manivannan Sadhasivam
2020-11-19  7:13   ` Manivannan Sadhasivam
2020-11-19  7:13 ` Manivannan Sadhasivam [this message]
2020-11-19  7:13   ` [PATCH v3 4/4] mtd: parsers: afs: Fix freeing the part name memory in failure Manivannan Sadhasivam
2020-12-10  4:09 ` [PATCH v3 0/4] Add support for Qcom SMEM based NAND parser Manivannan Sadhasivam
2020-12-10  4:09   ` Manivannan Sadhasivam
2020-12-10 21:24   ` Miquel Raynal
2020-12-10 21:24     ` Miquel Raynal
2020-12-11  3:10     ` Rob Herring
2020-12-11  3:10       ` Rob Herring
2020-12-11  3:36       ` Manivannan Sadhasivam
2020-12-11  3:36         ` Manivannan Sadhasivam

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20201119071308.9292-5-manivannan.sadhasivam@linaro.org \
    --to=manivannan.sadhasivam@linaro.org \
    --cc=bjorn.andersson@linaro.org \
    --cc=devicetree@vger.kernel.org \
    --cc=linus.walleij@linaro.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mtd@lists.infradead.org \
    --cc=miquel.raynal@bootlin.com \
    --cc=richard@nod.at \
    --cc=robh+dt@kernel.org \
    --cc=vigneshr@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.